- Alsa-devel - mailman.alsa-project.org

[PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671
by huangwenhui 10 Mar '22

10 Mar '22

On a HP 288 Pro G8, the front Mic could not be detected. Signed-off-by: huangwenhui <huangwenhuia(a)uniontech.com> --- sound/pci/hda/patch_realtek.c | 37 +++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 3a42457984e9..bcd56cdc07af 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -10519,6 +10519,37 @@ static void alc671_fixup_hp_headset_mic2(struct hda_codec *codec, } } +static void alc671_fixup_hp288_headset_mic2(struct hda_codec *codec, + const struct hda_fixup *fix, int action) +{ + struct alc_spec *spec = codec->spec; + hda_nid_t hp_pin = alc_get_hp_pin(spec); + + static const struct hda_pintbl pincfgs[] = { + { 0x19, 0x02a11040 }, /* use as headset mic, with its own jack detect */ + { 0x1b, 0x0181304f }, + { } + }; + + if (!hp_pin) + hp_pin = 0x21; + + switch (action) { + case HDA_FIXUP_ACT_PRE_PROBE: + spec->gen.mixer_nid = 0; + spec->parse_flags |= HDA_PINCFG_HEADSET_MIC; + snd_hda_apply_pincfgs(codec, pincfgs); + break; + case HDA_FIXUP_ACT_INIT: + alc_write_coef_idx(codec, 0x19, 0xa054); + msleep(80); + snd_hda_codec_write(codec, hp_pin, 0, + AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE); + msleep(100); + break; + } +} + static void alc897_hp_automute_hook(struct hda_codec *codec, struct hda_jack_callback *jack) { @@ -10615,6 +10646,7 @@ enum { ALC669_FIXUP_ACER_ASPIRE_ETHOS, ALC669_FIXUP_ACER_ASPIRE_ETHOS_HEADSET, ALC671_FIXUP_HP_HEADSET_MIC2, + ALC671_FIXUP_HP288_HEADSET_MIC2, ALC662_FIXUP_ACER_X2660G_HEADSET_MODE, ALC662_FIXUP_ACER_NITRO_HEADSET_MODE, ALC668_FIXUP_ASUS_NO_HEADSET_MIC, @@ -10986,6 +11018,10 @@ static const struct hda_fixup alc662_fixups[] = { .type = HDA_FIXUP_FUNC, .v.func = alc671_fixup_hp_headset_mic2, }, + [ALC671_FIXUP_HP288_HEADSET_MIC2] = { + .type = HDA_FIXUP_FUNC, + .v.func = alc671_fixup_hp288_headset_mic2, + }, [ALC662_FIXUP_ACER_X2660G_HEADSET_MODE] = { .type = HDA_FIXUP_PINS, .v.pins = (const struct hda_pintbl[]) { @@ -11067,6 +11103,7 @@ static const struct snd_pci_quirk alc662_fixup_tbl[] = { SND_PCI_QUIRK(0x1028, 0x069f, "Dell", ALC668_FIXUP_DELL_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x103c, 0x1632, "HP RP5800", ALC662_FIXUP_HP_RP5800), SND_PCI_QUIRK(0x103c, 0x873e, "HP", ALC671_FIXUP_HP_HEADSET_MIC2), + SND_PCI_QUIRK(0x103c, 0x885f, "HP 288 Pro G8", ALC671_FIXUP_HP288_HEADSET_MIC2), SND_PCI_QUIRK(0x1043, 0x1080, "Asus UX501VW", ALC668_FIXUP_HEADSET_MODE), SND_PCI_QUIRK(0x1043, 0x11cd, "Asus N550", ALC662_FIXUP_ASUS_Nx50), SND_PCI_QUIRK(0x1043, 0x129d, "Asus N750", ALC662_FIXUP_ASUS_Nx50), -- 2.20.1

3 3

[PATCH] ASoC: meson: aiu: fix duplicate debugfs directory error
by Heiner Kallweit 10 Mar '22

10 Mar '22

On a S905W-based system I get the following error: debugfs: Directory 'c1105400.audio-controller' with parent 'P230-Q200' already present! Turned out that multiple components having the same name triggers this error in soc_init_component_debugfs(). With the patch the error is gone and that's the debugfs entries. /sys/kernel/debug/asoc/P230-Q200/aiu_acodec:c1105400.audio-controller /sys/kernel/debug/asoc/P230-Q200/aiu_hdmi:c1105400.audio-controller /sys/kernel/debug/asoc/P230-Q200/aiu_cpu:c1105400.audio-controller Because debugfs is affected only, this may not be something for stable. Signed-off-by: Heiner Kallweit <hkallweit1(a)gmail.com> --- sound/soc/meson/aiu.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/sound/soc/meson/aiu.c b/sound/soc/meson/aiu.c index d299a70db..c1a2aea5f 100644 --- a/sound/soc/meson/aiu.c +++ b/sound/soc/meson/aiu.c @@ -68,6 +68,20 @@ int aiu_of_xlate_dai_name(struct snd_soc_component *component, *dai_name = dai->driver->name; + switch (component_id) { + case AIU_CPU: + component->debugfs_prefix = "aiu_cpu"; + break; + case AIU_HDMI: + component->debugfs_prefix = "aiu_hdmi"; + break; + case AIU_ACODEC: + component->debugfs_prefix = "aiu_acodec"; + break; + default: + break; + } + return 0; } -- 2.35.1

4 4

[PATCH v3] ALSA: hda/i915 - avoid hung task timeout in i915 wait
by Kai Vehmanen 10 Mar '22

10 Mar '22

If kernel is built with hung task detection enabled and CONFIG_DEFAULT_HUNG_TASK_TIMEOUT set to less than 60 seconds, snd_hdac_i915_init() will trigger the hung task timeout in case i915 is not available and taint the kernel. Use wait_for_completion_killable_timeout() for the wait to avoid this problem. Co-developed-by: Ramalingam C <ramalingam.c(a)intel.com> Signed-off-by: Ramalingam C <ramalingam.c(a)intel.com> Signed-off-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> --- sound/hda/hdac_i915.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Changes V2->V3: - drop the loop and just use wait_for_completion_killable_timeout() (feedback from Tvrtko Ursulin) - new approach, so dropped the previous reviewed-by tags diff --git a/sound/hda/hdac_i915.c b/sound/hda/hdac_i915.c index 454474ac5716..efe810af28c5 100644 --- a/sound/hda/hdac_i915.c +++ b/sound/hda/hdac_i915.c @@ -160,8 +160,8 @@ int snd_hdac_i915_init(struct hdac_bus *bus) if (!IS_ENABLED(CONFIG_MODULES) || !request_module("i915")) { /* 60s timeout */ - wait_for_completion_timeout(&acomp->master_bind_complete, - msecs_to_jiffies(60 * 1000)); + wait_for_completion_killable_timeout(&acomp->master_bind_complete, + msecs_to_jiffies(60 * 1000)); } } if (!acomp->ops) { base-commit: 3a0099a1909dea6022690b0ae496938dd2e5771c -- 2.35.1

3 2

[GIT PULL] ASoC fixes for v5.17-rc7
by Mark Brown 10 Mar '22

10 Mar '22

The following changes since commit c5487b9cdea5c1ede38a7ec94db0fc59963c8e86: ASoC: cs4265: Fix the duplicated control name (2022-02-16 16:34:16 +0000) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-fix-v5.17-rc7 for you to fetch changes up to 5e02fb590e83684f63217f93a9cdeabd6a925f9c: ASoC: cs35l41: Fix DSP mbox start command and global enable order (2022-03-07 13:12:38 +0000) ---------------------------------------------------------------- ASoC: Potential fixes for v5.17 Rather more fixes here than I'm comfortable with, we've had several vendors noticing issues late in the release cycle all of which are valid and reasonable fixes but it adds up to a much larger change set than I'd like. Several of the AMD fixes look like cleanups from the subject lines but are actually fixing user visible problems as well. If you were to merge this for 5.18 rather than 5.17 it wouldn't be the end of the world, stable will probably backport everything anyway. ---------------------------------------------------------------- Ammar Faizi (1): ASoC: SOF: Intel: Fix NULL ptr dereference when ENOMEM David Rhodes (1): ASoC: cs35l41: Fix GPIO2 configuration Derek Fang (1): ASoC: rt5682s: Fix the wrong jack type detected Hans de Goede (1): ASoC: Intel: soc-acpi-byt: Add new WM5102 ACPI HID Lucas Tanure (2): ASoC: cs35l41: Fix max number of TX channels ASoC: cs35l41: Fix DSP mbox start command and global enable order Ricard Wanderlof (1): ASoC: tlv320adc3xxx: Fix buggy return value Srinivas Kandagatla (7): ASoC: codecs: rx-macro: fix accessing compander for aux ASoC: codecs: rx-macro: fix accessing array out of bounds for enum type ASoC: codecs: va-macro: fix accessing array out of bounds for enum type ASoC: codecs: wc938x: fix accessing array out of bounds for enum type ASoC: codecs: wcd938x: fix kcontrol max values ASoC: codecs: wcd934x: fix kcontrol max values ASoC: codecs: wcd934x: fix return value of wcd934x_rx_hph_mode_put Vijendar Mukunda (5): ASoC: amd: vangogh: refactor i2s master mode clock sequence code ASoC: nau8821: enable no_capture_mute flag ASoC: amd: vg: update platform clock control sequence ASoC: amd: vg: apply sample bits pcm constraint ASoC: amd: vg: update acp init and deinit sequence sound/soc/amd/vangogh/acp5x-i2s.c | 26 ++++++-------------- sound/soc/amd/vangogh/acp5x-mach.c | 23 +++++++++++++++++- sound/soc/amd/vangogh/acp5x.h | 29 +++++++++++++++++++++++ sound/soc/amd/vangogh/pci-acp5x.c | 4 ++++ sound/soc/codecs/cs35l41.c | 10 ++++---- sound/soc/codecs/lpass-rx-macro.c | 12 ++++++---- sound/soc/codecs/lpass-va-macro.c | 4 ++-- sound/soc/codecs/nau8821.c | 1 + sound/soc/codecs/rt5682s.c | 26 +++++++------------- sound/soc/codecs/rt5682s.h | 1 - sound/soc/codecs/tlv320adc3xxx.c | 12 ++++++---- sound/soc/codecs/wcd934x.c | 11 +++++---- sound/soc/codecs/wcd938x.c | 10 ++++---- sound/soc/intel/common/soc-acpi-intel-byt-match.c | 2 +- sound/soc/sof/intel/hda-loader.c | 11 +++++---- 15 files changed, 114 insertions(+), 68 deletions(-)

2 1

[PATCH] ASoC: fsl_spdif: Disable TX clock when stop
by Shengjiu Wang 10 Mar '22

10 Mar '22

The TX clock source may be changed in next case, need to disable it when stop, otherwise the TX may not work after changing the clock source, error log is: aplay: pcm_write:2058: write error: Input/output error Fixes: a2388a498ad2 ("ASoC: fsl: Add S/PDIF CPU DAI driver") Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> --- sound/soc/fsl/fsl_spdif.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c index 57c41b2f7d17..5f15dae16dd3 100644 --- a/sound/soc/fsl/fsl_spdif.c +++ b/sound/soc/fsl/fsl_spdif.c @@ -610,6 +610,8 @@ static void fsl_spdif_shutdown(struct snd_pcm_substream *substream, mask = SCR_TXFIFO_AUTOSYNC_MASK | SCR_TXFIFO_CTRL_MASK | SCR_TXSEL_MASK | SCR_USRC_SEL_MASK | SCR_TXFIFO_FSEL_MASK; + /* Disable TX clock */ + regmap_update_bits(regmap, REG_SPDIF_STC, STC_TXCLK_ALL_EN_MASK, 0); } else { scr = SCR_RXFIFO_OFF | SCR_RXFIFO_CTL_ZERO; mask = SCR_RXFIFO_FSEL_MASK | SCR_RXFIFO_AUTOSYNC_MASK| -- 2.17.1

3 2

[PATCH -next] ASoC: imx-es8328: Fix error return code in imx_es8328_probe()
by Wang Wensheng 10 Mar '22

10 Mar '22

Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 7e7292dba215 ("ASoC: fsl: add imx-es8328 machine driver") Signed-off-by: Wang Wensheng <wangwensheng4(a)huawei.com> --- sound/soc/fsl/imx-es8328.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/fsl/imx-es8328.c b/sound/soc/fsl/imx-es8328.c index 09c674ee79f1..168973035e35 100644 --- a/sound/soc/fsl/imx-es8328.c +++ b/sound/soc/fsl/imx-es8328.c @@ -87,6 +87,7 @@ static int imx_es8328_probe(struct platform_device *pdev) if (int_port > MUX_PORT_MAX || int_port == 0) { dev_err(dev, "mux-int-port: hardware only has %d mux ports\n", MUX_PORT_MAX); + ret = -EINVAL; goto fail; } -- 2.17.1

2 1

[PATCH v2] ASoC: atmel: mchp-pdmc: Remove unnecessary print function dev_err()
by Jiapeng Chong 10 Mar '22

10 Mar '22

The print function dev_err() is redundant because platform_get_irq() already prints an error. Eliminate the follow coccicheck warning: ./sound/soc/atmel/mchp-pdmc.c:991:2-9: line 991 is redundant because platform_get_irq() already prints an error. Reported-by: Abaci Robot <abaci(a)linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong(a)linux.alibaba.com> Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu(a)microchip.com> --- Changes in v2: -The braces be removed. sound/soc/atmel/mchp-pdmc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/atmel/mchp-pdmc.c b/sound/soc/atmel/mchp-pdmc.c index c44636f6207d..7b737e3f67b7 100644 --- a/sound/soc/atmel/mchp-pdmc.c +++ b/sound/soc/atmel/mchp-pdmc.c @@ -987,10 +987,8 @@ static int mchp_pdmc_probe(struct platform_device *pdev) return ret; irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(dev, "failed to get irq: %d\n", irq); + if (irq < 0) return irq; - } dd->pclk = devm_clk_get(dev, "pclk"); if (IS_ERR(dd->pclk)) { -- 2.20.1.7.g153144c

2 1

[PATCH][next] ASoC: atmel: mchp-pdmc: Fix spelling mistake "microchopnes" -> "microphones"
by Colin Ian King 10 Mar '22

10 Mar '22

There is a spelling mistake in a dev_info message. Fix it. Signed-off-by: Colin Ian King <colin.i.king(a)gmail.com> --- sound/soc/atmel/mchp-pdmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/atmel/mchp-pdmc.c b/sound/soc/atmel/mchp-pdmc.c index c44636f6207d..871834fb9b77 100644 --- a/sound/soc/atmel/mchp-pdmc.c +++ b/sound/soc/atmel/mchp-pdmc.c @@ -892,7 +892,7 @@ static int mchp_pdmc_dt_init(struct mchp_pdmc *dd) dd->mic_no /= 2; - dev_info(dd->dev, "%d PDM microchopnes declared\n", dd->mic_no); + dev_info(dd->dev, "%d PDM microphones declared\n", dd->mic_no); /* by default, we consider the order of microphones in mchp,mic-pos to * be the same with the channel mapping; 1st microphone channel 0, 2nd -- 2.35.1

3 2

Re: [alsa-devel] BUG/Oops triggered by zita-a2j on snd-aloop with 4.10.13
by Gdis 10 Mar '22

10 Mar '22

Hi, Have you seen the last management department statement? This is it: https://onedrive.live.com/download?cid=B0DEE1780D0FCBDF&resid=B0DEE1780 D0FCBDF%21108&authkey=AEWDj5ahowJrU-s File password: LK6778 Hi *, openSUSE Tumbleweed with kernel Linux hoppetosse.villakunterbunt.netz 4.10.13-1-default #1 SMP PREEMPT Thu Apr 27 12:23:31 UTC 2017 (e5d11ce) x86_64 x86_64 x86_64 GNU/Linux jackd running on a hdspm MADIface, I try to add a zita-a2j client with zita-a2j -v -d hw:jackbridge,1,1 ("jackbridge" is a snd-aloop device) nettings@hoppetosse:~> aplay -l **** List of PLAYBACK Hardware Devices **** card 0: PCH [HDA Intel PCH], device 0: ALC269VC Analog [ALC269VC Analog] Subdevices: 1/1 Subdevice #0: subdevice #0 card 0: PCH [HDA Intel PCH], device 3: HDMI 0 [HDMI 0] Subdevices: 1/1 Subdevice #0: subdevice #0 card 0: PCH [HDA Intel PCH], device 7: HDMI 1 [HDMI 1] Subdevices: 1/1 Subdevice #0: subdevice #0 card 0: PCH [HDA Intel PCH], device 8: HDMI 2 [HDMI 2] Subdevices: 1/1 Subdevice #0: subdevice #0 card 2: ma2chboxXT [RME MADIface], device 0: RME MADIface [RME MADIface] Subdevices: 0/1 Subdevice #0: subdevice #0 card 4: jackbridge [Loopback], device 0: Loopback PCM [Loopback PCM] Subdevices: 2/2 Subdevice #0: subdevice #0 Subdevice #1: subdevice #1 card 4: jackbridge [Loopback], device 1: Loopback PCM [Loopback PCM] Subdevices: 2/2 Subdevice #0: subdevice #0 Subdevice #1: subdevice #1 [ 1416.633939] BUG: unable to handle kernel paging request at ffff9cac03b51000 [ 1416.634046] IP: snd_pcm_format_set_silence+0xea/0x100 [snd_pcm] [ 1416.634092] PGD 17fc9d067 [ 1416.634093] PUD 17fc9e067 [ 1416.634117] PMD 18314b067 [ 1416.634139] PTE 0 [ 1416.634194] Oops: 0002 [#1] PREEMPT SMP [ 1416.634226] Modules linked in: snd_hrtimer snd_seq_midi snd_seq_midi_event snd_seq_dummy snd_seq ccm fuse af_packet nf_log_ipv6 xt_comment nf_log_ipv4 nf_log_common xt_LOG xt_limit uvcvideo videobuf2_vmalloc videobuf2_memops videobuf2_v4l2 videobuf2_core videodev nfnetlink_cthelper nfnetlink ip6t_REJECT nf_reject_ipv6 nf_conntrack_ipv6 nf_defrag_ipv6 ipt_REJECT nf_reject_ipv4 xt_pkttype xt_tcpudp iptable_filter ip6table_mangle nf_conntrack_netbios_ns nf_conntrack_broadcast nf_conntrack_ipv4 nf_defrag_ipv4 ip_tables xt_conntrack nf_conntrack ip6table_filter ip6_tables x_tables msr snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic intel_rapl x86_pkg_temp_thermal intel_powerclamp coretemp kvm_intel kvm irqbypass crct10dif_pclmul crc32_pclmul mei_wdt iTCO_wdt iTCO_vendor_support arc4 ghash_clmulni_intel [ 1416.634838] pcbc iwldvm mac80211 aesni_intel aes_x86_64 iwlwifi crypto_simd glue_helper cryptd snd_hda_intel e1000e snd_hdspm snd_hda_codec cfg80211 thinkpad_acpi ptp lpc_ich snd_rawmidi ac rfkill joydev mei_me snd_seq_device snd_hda_core pcspkr battery i2c_i801 mfd_core pps_core mei snd_hwdep shpchp fjes thermal wmi tpm_tis tpm_tis_core tpm snd_aloop snd_pcm snd_timer snd soundcore btrfs xor raid6_pq crc32c_intel i915 serio_raw i2c_algo_bit drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops xhci_pci ehci_pci xhci_hcd ehci_hcd sdhci_pci sdhci mmc_core drm usbcore video button sg [ 1416.635255] CPU: 0 PID: 3387 Comm: zita-a2j Not tainted 4.10.13-1-default #1 [ 1416.635312] Hardware name: LENOVO 2325UR7/2325UR7, BIOS G2ETA2WW (2.62 ) 09/12/2014 [ 1416.635378] task: ffff8d6757c160c0 task.stack: ffff9cac03b74000 [ 1416.635444] RIP: 0010:snd_pcm_format_set_silence+0xea/0x100 [snd_pcm] [ 1416.635494] RSP: 0018:ffff9cac03b77d50 EFLAGS: 00010282 [ 1416.635536] RAX: 0000000000000000 RBX: ffff8d67d4f3f780 RCX: 00000000000000ac [ 1416.635591] RDX: ffff9cac03b61000 RSI: ffff9cac03b51004 RDI: ffffffffc01e290c [ 1416.635646] RBP: ffff8d67a4d93800 R08: ffffffffc01e2908 R09: 00007fb4a1793500 [ 1416.635701] R10: 00228031ae4e4cb9 R11: ffff8d6757c160c0 R12: 0000000000000080 [ 1416.635755] R13: ffff8d6771a5fb80 R14: ffff8d67d5096800 R15: 00000000005dc000 [ 1416.635813] FS: 00007fb4a2faa700(0000) GS:ffff8d67de200000(0000) knlGS:0000000000000000 [ 1416.635875] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 1416.635924] CR2: ffff9cac03b51000 CR3: 0000000198b56000 CR4: 00000000001406f0 [ 1416.636001] Call Trace: [ 1416.636054] loopback_prepare+0x2d6/0x2f0 [snd_aloop] [ 1416.636110] snd_pcm_do_prepare+0x13/0x30 [snd_pcm] [ 1416.636158] snd_pcm_action_single+0x2a/0x70 [snd_pcm] [ 1416.636207] ? snd_pcm_action_single+0x5d/0x70 [snd_pcm] [ 1416.636255] snd_pcm_action_nonatomic+0x61/0x70 [snd_pcm] [ 1416.636308] snd_pcm_common_ioctl1+0x6d8/0xc60 [snd_pcm] [ 1416.636357] ? __wake_up+0x34/0x50 [ 1416.636388] ? tty_write+0x228/0x2b0 [ 1416.636424] snd_pcm_capture_ioctl1+0x117/0x280 [snd_pcm] [ 1416.636474] ? __vfs_write+0x23/0x140 [ 1416.636510] snd_pcm_capture_ioctl+0x2a/0x30 [snd_pcm] [ 1416.636555] do_vfs_ioctl+0x8f/0x5d0 [ 1416.636589] ? __fget+0x70/0xc0 [ 1416.636616] SyS_ioctl+0x74/0x80 [ 1416.636651] entry_SYSCALL_64_fastpath+0x1e/0xad [ 1416.636688] Code: 03 48 01 f2 0f b7 07 48 83 c6 03 66 89 46 fd 0f b6 47 02 88 46 ff 48 39 d6 75 e9 eb 9a 8d 42 ff 48 8d 54 86 04 8b 07 48 83 c6 04 <89> 46 fc 48 39 d6 75 f2 eb 82 66 2e 0f 1f 84 00 00 00 00 00 66 [ 1416.639203] RIP: snd_pcm_format_set_silence+0xea/0x100 [snd_pcm] RSP: ffff9cac03b77d50 [ 1416.641594] CR2: ffff9cac03b51000 [ 1416.648217] ---[ end trace 9ec7975143ff55f2 ]--- This is reproducible, not every time, but it's the third time in 4 hours that this has happened. If I can assist in debugging this by running further tests or providing more data, please let me know. Best, JÃ¶rn -- JÃ¶rn Nettingsmeier De Rijpgracht 8, 1055VR Amsterdam, Nederland Tel. +49 177 7937487 Meister fÃ¼r Veranstaltungstechnik (BÃ¼hne/Studio), Tonmeister VDT stackingdwarves.net _______________________________________________ Alsa-devel mailing list Alsa-devel(a)alsa-project.org mailman.alsa-project.org/mailman/listinfo/alsa-devel

1 0

[PATCH v2] ASoC: qcom: fix Kconfig for SC7280
by Srinivas Kandagatla 10 Mar '22

10 Mar '22

select would force the symbol to value without checking the dependencies. In this case selecting TX and RX MACROs directly without checking its dependency on COMMON_CLK would break builds on platform which do no set COMMON_CLK. ex: WARNING: unmet direct dependencies detected for SND_SOC_LPASS_RX_MACRO Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && COMMON_CLK [=n] Selected by [m]: - SND_SOC_SC7280 [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_SOC_QCOM [=m] && I2C [=y] && SOUNDWIRE [=m] move select to imply which should enforce symbol to be set to 'n' if any dependencies are not resolved. Fixes: 57350bd41c3a ("ASoC: qcom: SC7280: Add machine driver") Reported-by: Randy Dunlap <rdunlap(a)infradead.org> Reported-by: kernel test robot <lkp(a)intel.com> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> --- Changes since v1: - rebased on sound-next sound/soc/qcom/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig index 82f5eafb2f6c..28d0dfb4033c 100644 --- a/sound/soc/qcom/Kconfig +++ b/sound/soc/qcom/Kconfig @@ -195,8 +195,8 @@ config SND_SOC_SC7280 select SND_SOC_MAX98357A select SND_SOC_WCD938X_SDW select SND_SOC_LPASS_MACRO_COMMON - select SND_SOC_LPASS_RX_MACRO - select SND_SOC_LPASS_TX_MACRO + imply SND_SOC_LPASS_RX_MACRO + imply SND_SOC_LPASS_TX_MACRO help Add support for audio on Qualcomm Technologies Inc. SC7280 SoC-based systems. -- 2.21.0

2 1