- Alsa-devel - mailman.alsa-project.org

Re: [PATCH 4/4] ASoC: wm8904: add DMIC support
by Pierluigi Passaro 20 Jun '22

20 Jun '22

Hi All, > > +static const char *cin_text[] = { > > + "ADC", "DMIC" > > +}; > > + > > +static SOC_ENUM_SINGLE_DECL(cin_enum, > > + WM8904_DIGITAL_MICROPHONE_0, 12, cin_text); > > Why would this be runtime selectable? I'd expect the decision to use > an analogue or digital microphone to be made in the hardware design. I agree that dedicated HW is required, but currently SW side there's no support at all. This patch is aiming to provide a way to enable DMIC on boards using it. Is this supposed to be managed in a different way ? Thanks Best Regards Pier

2 1

[PATCH] MAINTAINERS: update ASoC Qualcomm maintainer email-id
by Srinivas Kandagatla 20 Jun '22

20 Jun '22

Update Banajit's email address from codeaurora.org to quicinc.com, as codeaurora.org is not in use anymore. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 440f3d7c93b9..171fa3160696 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -16247,7 +16247,7 @@ F: drivers/crypto/qat/ QCOM AUDIO (ASoC) DRIVERS M: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> -M: Banajit Goswami <bgoswami(a)codeaurora.org> +M: Banajit Goswami <bgoswami(a)quicinc.com> L: alsa-devel(a)alsa-project.org (moderated for non-subscribers) S: Supported F: sound/soc/codecs/lpass-va-macro.c -- 2.25.1

2 1

No sound on main speaker : Zenbook UX3402/ALC294/Fedora 36
by GitHub issues - opened 20 Jun '22

20 Jun '22

alsa-project/alsa-ucm-conf issue #174 was opened from hereblur: My laptop has no sound on main speakers. 3.5mm jack and bluetooth is working fine. Asus Zenbook UX3402 ALC294 Fedora 36 Here is my `alsaucm -c hw:0 dump text` and `alsa-info.sh` output [https://paste.debian.net/1244631/](https://paste.debian.net/1244631/) Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/174 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH] ASoC: fsl_asrc_dma: Use dmaengine_terminate_async()
by Sascha Hauer 20 Jun '22

20 Jun '22

dmaengine_terminate_all() is deprecated and should no longer be used. Use dmaengine_terminate_async() instead. This involves no functional change since both functions do the same. After dmaengine_terminate_async() dmaengine_synchronize() must be called to make sure the channel has really stopped before the underlying memory is freed. This is done implicitly by dma_release_channel() called from the .hw_free hook. Signed-off-by: Sascha Hauer <s.hauer(a)pengutronix.de> --- sound/soc/fsl/fsl_asrc_dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_asrc_dma.c b/sound/soc/fsl/fsl_asrc_dma.c index fec56dbb64e60..6c4d161ddad85 100644 --- a/sound/soc/fsl/fsl_asrc_dma.c +++ b/sound/soc/fsl/fsl_asrc_dma.c @@ -114,8 +114,8 @@ static int fsl_asrc_dma_trigger(struct snd_soc_component *component, case SNDRV_PCM_TRIGGER_STOP: case SNDRV_PCM_TRIGGER_SUSPEND: case SNDRV_PCM_TRIGGER_PAUSE_PUSH: - dmaengine_terminate_all(pair->dma_chan[OUT]); - dmaengine_terminate_all(pair->dma_chan[IN]); + dmaengine_terminate_async(pair->dma_chan[OUT]); + dmaengine_terminate_async(pair->dma_chan[IN]); break; default: return -EINVAL; -- 2.30.2

2 1

[PATCH 1/2] ALSA: hda/conexant: Fix missing beep setup
by Takashi Iwai 20 Jun '22

20 Jun '22

Currently the Conexant codec driver sets up the beep NID after calling snd_hda_gen_parse_auto_config(). It turned out that this results in the insufficient setup for the beep control, as the generic parser handles the fake path in snd_hda_gen_parse_auto_config() only if the beep_nid is set up beforehand. For dealing with the beep widget properly, call cx_auto_parse_beep() before snd_hda_gen_parse_auto_config() call. Fixes: 51e19ca5f755 ("ALSA: hda/conexant - Clean up beep code") Cc: <stable(a)vger.kernel.org> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216152 Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/hda/patch_conexant.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c index 1248d1a51cf0..3e541a4c0423 100644 --- a/sound/pci/hda/patch_conexant.c +++ b/sound/pci/hda/patch_conexant.c @@ -1079,11 +1079,11 @@ static int patch_conexant_auto(struct hda_codec *codec) if (err < 0) goto error; - err = snd_hda_gen_parse_auto_config(codec, &spec->gen.autocfg); + err = cx_auto_parse_beep(codec); if (err < 0) goto error; - err = cx_auto_parse_beep(codec); + err = snd_hda_gen_parse_auto_config(codec, &spec->gen.autocfg); if (err < 0) goto error; -- 2.35.3

1 1

[PATCH 00/23] add annotation to object properties
by GitHub pull_request - opened 20 Jun '22

20 Jun '22

alsa-project/alsa-gobject pull request #77 was opened from takaswie: The gi-docgen tool requires explicit annotation for object properties to generate pages. This patchset adds missing properties for the purpose. ``` Takashi Sakamoto (23): ctl: card: add annotation to object properties ctl: card-info: add annotation to object properties card: elem-value: add annotation to object properties rawmidi: stream-pair: add annotation to object properties rawmidi: substream-info: add annotation to object properties rawmidi: substream-params: add annotation to object properties rawmidi: substream-status: add annotation to object properties hwdep: device-info: add annotation to object properties timer: device-info: add annotation to object properties timer: device-params: add annotation to object properties timer: device-status: add annotation to object properties timer: instance-info: add annotation to object properties timer: instance-params: add annotation to object properties timer: instance-status: add annotation to object properties seq: fix description of object properties in which enumerations are available seq: client-info: add annotation to object properties seq: client-pool: add annotation to object properties seq: port-info: fix tag indentation seq: queue-info: add annotation to object properties seq: queue-status: add annotation to object properties seq: queue-tempo: add annotation to object properties seq: system-info: add annotation to object properties seq: user-client: add annotation to object properties src/ctl/card-info.c | 37 ++++++++++++++++++- src/ctl/card.c | 12 ++++++- src/ctl/elem-value.c | 5 +++ src/hwdep/device-info.c | 34 +++++++++++++++--- src/rawmidi/stream-pair.c | 7 +++- src/rawmidi/substream-info.c | 66 +++++++++++++++++++++++++++++----- src/rawmidi/substream-params.c | 22 +++++++++--- src/rawmidi/substream-status.c | 10 ++++++ src/seq/client-info.c | 59 ++++++++++++++++++++++++++---- src/seq/client-pool.c | 52 ++++++++++++++++++++------- src/seq/port-info.c | 2 +- src/seq/query.c | 4 +-- src/seq/queue-info.c | 28 ++++++++++++--- src/seq/queue-status.c | 19 ++++++++-- src/seq/queue-tempo.c | 19 ++++++++-- src/seq/queue-timer-common.c | 2 +- src/seq/remove-filter.c | 19 +++++----- src/seq/system-info.c | 30 ++++++++++++++++ src/seq/user-client.c | 19 ++++++---- src/timer/device-info.c | 46 ++++++++++++++++++++++-- src/timer/device-params.c | 10 ++++++ src/timer/device-status.c | 15 ++++++++ src/timer/instance-info.c | 27 +++++++++++++- src/timer/instance-params.c | 18 ++++++++-- src/timer/instance-status.c | 20 +++++++++++ 25 files changed, 506 insertions(+), 76 deletions(-) ``` Request URL : https://github.com/alsa-project/alsa-gobject/pull/77 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/77.patch Repository URL: https://github.com/alsa-project/alsa-gobject

1 0

[PATCH v3 0/4] Add MT8186 ADSP dt-binding
by Tinghan Shen 20 Jun '22

20 Jun '22

v2 -> v3: 1. Change mbox-names to rx/tx for both mt8186 and mt8195. 2. Update description of mbox-names 3. Use static string array instead of kasprintf 4. Align clock names in dsp driver with dt-bindings v1 -> v2: 1. Change mbox-names from mbox0/mbox1 to rep/req for both mt8186 and mt8195. 2. rename clock-names and remove unused headers Tinghan Shen (4): dt-bindings: dsp: mediatek: Use meaningful names for mbox firmware: mediatek: Use meaningful names for mbox dt-bindings: dsp: mediatek: Add mt8186 dsp document ASoC: SOF: mediatek: Align mt8186 clock names with dt-bindings .../bindings/dsp/mediatek,mt8186-dsp.yaml | 91 +++++++++++++++++++ .../bindings/dsp/mediatek,mt8195-dsp.yaml | 10 +- drivers/firmware/mtk-adsp-ipc.c | 36 +++----- sound/soc/sof/mediatek/mt8186/mt8186-clk.c | 4 +- 4 files changed, 110 insertions(+), 31 deletions(-) create mode 100644 Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml -- 2.18.0

2 9

[PATCH v3 00/17] ASoC: Intel: haswell and broadwell boards update
by Cezary Rojewski 20 Jun '22

20 Jun '22

A number of patches improving overall quality and readability of haswell.c and broadwell.c source files found in sound/soc/intel/boards. Both files are first renamed and only then actual changes are being incrementally added. The respective names are: hsw_rt5640 and bdw_rt286 to match the pattern found in more recent boards. Most patches bring no functional change - the more impactful patches at are placed the end: Refactor of suspend/resume flow for the bdw_rt286 board by dropping dev->remove() in favour of card->remove() and adjust jack handling to reduce code size slightly by implementing card_set_jack(). The last patch is removing of FE DAI ops. Given the existence of platform FE DAI capabilities (either static declaration or through topology file), this code is redundant. Changes in v3: - Patch 16/17 refactoring suspend/resume has been renamed to "Refactor jack handling". Dropped the usage of card->remove() in favor of link->exit() in that very patch Changes in v2: - fixed wording error in patch 02/17 so it correctly mentions 'haswell_rt5640', not 'broadwell_rt286' - decided not to add kernel module names changes to this patchset so the review is not complicated unnecessarily. Will send them separately instead Cezary Rojewski (17): ASoC: Intel: Rename haswell source file to hsw_rt5640 ASoC: Intel: hsw_rt5640: Reword prefixes of all driver members ASoC: Intel: hsw_rt5640: Reword driver name ASoC: Intel: hsw_rt5640: Update code indentation ASoC: Intel: hsw_rt5640: Update file comments ASoC: Intel: hsw_rt5640: Improve probe() function quality ASoC: Intel: hsw_rt5640: Improve hw_params() debug-ability ASoC: Intel: Rename broadwell source file to bdw_rt286 ASoC: Intel: bdw_rt286: Reword prefixes of all driver members ASoC: Intel: bdw_rt286: Reword driver name ASoC: Intel: bdw_rt286: Update code indentation ASoC: Intel: bdw_rt286: Update file comments ASoC: Intel: bdw_rt286: Improve probe() function quality ASoC: Intel: bdw_rt286: Improve hw_params() debug-ability ASoC: Intel: bdw_rt286: Improve codec_init() quality ASoC: Intel: bdw_rt286: Refactor jack handling ASoC: Intel: bdw_rt286: Remove FE DAI ops sound/soc/intel/boards/Kconfig | 4 +- sound/soc/intel/boards/Makefile | 4 +- sound/soc/intel/boards/bdw_rt286.c | 256 +++++++++++++ sound/soc/intel/boards/broadwell.c | 336 ------------------ sound/soc/intel/boards/haswell.c | 202 ----------- sound/soc/intel/boards/hsw_rt5640.c | 176 +++++++++ .../common/soc-acpi-intel-hsw-bdw-match.c | 6 +- 7 files changed, 439 insertions(+), 545 deletions(-) create mode 100644 sound/soc/intel/boards/bdw_rt286.c delete mode 100644 sound/soc/intel/boards/broadwell.c delete mode 100644 sound/soc/intel/boards/haswell.c create mode 100644 sound/soc/intel/boards/hsw_rt5640.c -- 2.25.1

1 17

[PATCH] ALSA: memalloc: Drop x86-specific hack for WC allocations
by Takashi Iwai 20 Jun '22

20 Jun '22

The recent report for a crash on Haswell machines implied that the x86-specific (rather hackish) implementation for write-cache memory buffer allocation in ALSA core is buggy with the recent kernel in some corner cases. This patch drops the x86-specific implementation and uses the standard dma_alloc_wc() & co generically for avoiding the bug and also for simplification. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=216112 Cc: <stable(a)vger.kernel.org> # v5.18+ Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/core/memalloc.c | 23 +---------------------- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/sound/core/memalloc.c b/sound/core/memalloc.c index 15dc7160ba34..8cfdaee77905 100644 --- a/sound/core/memalloc.c +++ b/sound/core/memalloc.c @@ -431,33 +431,17 @@ static const struct snd_malloc_ops snd_dma_iram_ops = { */ static void *snd_dma_dev_alloc(struct snd_dma_buffer *dmab, size_t size) { - void *p; - - p = dma_alloc_coherent(dmab->dev.dev, size, &dmab->addr, DEFAULT_GFP); -#ifdef CONFIG_X86 - if (p && dmab->dev.type == SNDRV_DMA_TYPE_DEV_WC) - set_memory_wc((unsigned long)p, PAGE_ALIGN(size) >> PAGE_SHIFT); -#endif - return p; + return dma_alloc_coherent(dmab->dev.dev, size, &dmab->addr, DEFAULT_GFP); } static void snd_dma_dev_free(struct snd_dma_buffer *dmab) { -#ifdef CONFIG_X86 - if (dmab->dev.type == SNDRV_DMA_TYPE_DEV_WC) - set_memory_wb((unsigned long)dmab->area, - PAGE_ALIGN(dmab->bytes) >> PAGE_SHIFT); -#endif dma_free_coherent(dmab->dev.dev, dmab->bytes, dmab->area, dmab->addr); } static int snd_dma_dev_mmap(struct snd_dma_buffer *dmab, struct vm_area_struct *area) { -#ifdef CONFIG_X86 - if (dmab->dev.type == SNDRV_DMA_TYPE_DEV_WC) - area->vm_page_prot = pgprot_writecombine(area->vm_page_prot); -#endif return dma_mmap_coherent(dmab->dev.dev, area, dmab->area, dmab->addr, dmab->bytes); } @@ -471,10 +455,6 @@ static const struct snd_malloc_ops snd_dma_dev_ops = { /* * Write-combined pages */ -#ifdef CONFIG_X86 -/* On x86, share the same ops as the standard dev ops */ -#define snd_dma_wc_ops snd_dma_dev_ops -#else /* CONFIG_X86 */ static void *snd_dma_wc_alloc(struct snd_dma_buffer *dmab, size_t size) { return dma_alloc_wc(dmab->dev.dev, size, &dmab->addr, DEFAULT_GFP); @@ -497,7 +477,6 @@ static const struct snd_malloc_ops snd_dma_wc_ops = { .free = snd_dma_wc_free, .mmap = snd_dma_wc_mmap, }; -#endif /* CONFIG_X86 */ #ifdef CONFIG_SND_DMA_SGBUF static void *snd_dma_sg_fallback_alloc(struct snd_dma_buffer *dmab, size_t size); -- 2.35.3

1 0

Enabling tstamp in proc status file externally
by Pavel Hofman 20 Jun '22

20 Jun '22

Hi, Please is there any way to enable the tstamp in stream status without modifying the client calling the alsa-lib API? I wanted to measure samplerate ratio between soundcards using data in their status proc files (comparing advancement of tstamp vs. hw_ptr). The method seems to work quite good, but some clients enable the stream status tstamp (e.g. pulseaudio) and some don't (e.g. sox, aplay), resulting in zeros in the status proc file. Thanks a lot for any help or hint. Best regards, Pavel.

2 3