- Alsa-devel - mailman.alsa-project.org

cracking pulseaudio issue
by GitHub issues - edited 19 Aug '22

19 Aug '22

alsa-project/alsa-lib issue #262 was edited from shmohawk: ``` Aug 17 01:11:23 hellokitty pulseaudio[12938]: [alsa-sink-CX20590 Analog] alsa-sink.c: ALSA woke us up to write new data to the device, but there was actually nothing to write. Aug 17 01:11:23 hellokitty pulseaudio[12938]: [alsa-sink-CX20590 Analog] alsa-sink.c: Most likely this is a bug in the ALSA driver 'snd_hda_intel'. Please report this issue to the ALSA developers. Aug 17 01:11:23 hellokitty pulseaudio[12938]: [alsa-sink-CX20590 Analog] alsa-sink.c: We were woken up with POLLOUT set -- however a subsequent snd_pcm_avail() returned 0 or another value < min_avail. ``` It is symptomous with a crackling sound for ~5 seconds after any playback starts. alsa-lib 1.2.7.2 alsa-utils 1.2.7 alsa-plugins 1.2.2 Issue URL : https://github.com/alsa-project/alsa-lib/issues/262 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

snd_hda_intel: Woke up but no data
by GitHub issues - reopened 19 Aug '22

19 Aug '22

alsa-project/alsa-lib issue #262 was reopened from shmohawk: ``` Aug 17 01:11:23 hellokitty pulseaudio[12938]: [alsa-sink-CX20590 Analog] alsa-sink.c: ALSA woke us up to write new data to the device, but there was actually nothing to write. Aug 17 01:11:23 hellokitty pulseaudio[12938]: [alsa-sink-CX20590 Analog] alsa-sink.c: Most likely this is a bug in the ALSA driver 'snd_hda_intel'. Please report this issue to the ALSA developers. Aug 17 01:11:23 hellokitty pulseaudio[12938]: [alsa-sink-CX20590 Analog] alsa-sink.c: We were woken up with POLLOUT set -- however a subsequent snd_pcm_avail() returned 0 or another value < min_avail. ``` It is symptomous with a crackling sound for ~5 seconds after any playback starts. alsa-lib 1.2.7.2 alsa-utils 1.2.7 alsa-plugins 1.2.2 Issue URL : https://github.com/alsa-project/alsa-lib/issues/262 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Raising volume past 100%
by David Griffith 18 Aug '22

18 Aug '22

After reinstalling Debian on a laptop, I once again had to face the problem of how to get volume out of the built-in speakers boosted. The last time I reinstalled, I somehow got the MATE volume control applet to let me turn the volume past 100% using the mouse wheel. Over the past two days I've been trying to rediscover what I neglected to write down. I'm already aware that by bringing up the Sound Preferences dialog, I can raise volume to 153% and no further. I also know that I can use pulseaudio-ctl(1) or pactl(1) to set the volume at any arbitrary level past 100%. I remember that I went looking for solutions other people found for this that involved editing /etc/asound.conf or ~/.asoundrc, but the best I can get with that is add an extra slider to alsamixer's display that acts as apreamplifier. I was going off of http://alien.slackbook.org/blog/adding-an-alsa-software-pre-amp-to-fix-low-…. What could I have possibly done to make this work the last time? -- David Griffith dave(a)661.org A: Because it fouls the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail?

1 0

[PATCH 0/2] ASoC: Add a driver for the Iron Device SMA1303 Amp
by Kiseok Jo 18 Aug '22

18 Aug '22

This adds basic audio support for the Iron Device SMA1303 amplifier. Kiseok Jo (2): ASoC: sma1303: Add driver for Iron Device SMA1303 Amp ASoC: dt-bindings: sma1303: Iron Device SMA1303 Amp .../bindings/sound/irondevice,sma1303.yaml | 56 + sound/soc/codecs/Kconfig | 7 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/sma1303.c | 3388 +++++++++++++++++ sound/soc/codecs/sma1303.h | 604 +++ 5 files changed, 4057 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/irondevice,sma1303.yaml create mode 100644 sound/soc/codecs/sma1303.c create mode 100644 sound/soc/codecs/sma1303.h -- 2.30.2

2 3

[PATCH -next] ASoC: SOF: ipc4-topology: fix wrong use of sizeof in sof_ipc4_widget_setup_comp_src()
by Yang Yingliang 18 Aug '22

18 Aug '22

It should be size of the struct sof_ipc4_src, not data pointer pass to sof_update_ipc_object(). Fixes: b85f4fc40d56 ("ASoC: SOF: add ipc4 SRC module support") Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> --- sound/soc/sof/ipc4-topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sof/ipc4-topology.c b/sound/soc/sof/ipc4-topology.c index af072b484a60..c6abfaf5d532 100644 --- a/sound/soc/sof/ipc4-topology.c +++ b/sound/soc/sof/ipc4-topology.c @@ -771,7 +771,7 @@ static int sof_ipc4_widget_setup_comp_src(struct snd_sof_widget *swidget) goto err; ret = sof_update_ipc_object(scomp, src, SOF_SRC_TOKENS, swidget->tuples, - swidget->num_tuples, sizeof(src), 1); + swidget->num_tuples, sizeof(*src), 1); if (ret) { dev_err(scomp->dev, "Parsing SRC tokens failed\n"); goto err; -- 2.25.1

3 2

Add ASUS ROG Zenith II Extreme configuration
by GitHub pull_request - opened 18 Aug '22

18 Aug '22

alsa-project/alsa-lib pull request #263 was opened from nabajour: This points iec958_device to the correct PCM device. complements this [ALSA kernel patch](https://bugzilla.kernel.org/show_bug.cgi?id=211005). Request URL : https://github.com/alsa-project/alsa-lib/pull/263 Patch URL : https://github.com/alsa-project/alsa-lib/pull/263.patch Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[bug report] ASoC: amd: Add common framework to support I2S on ACP SOC
by Dan Carpenter 18 Aug '22

18 Aug '22

Hello Ajit Kumar Pandey, The patch 623621a9f9e1: "ASoC: amd: Add common framework to support I2S on ACP SOC" from Oct 19, 2021, leads to the following Smatch static checker warning: sound/soc/amd/acp/acp-platform.c:199 acp_dma_open() warn: '&stream->list' not removed from list sound/soc/amd/acp/acp-platform.c 173 static int acp_dma_open(struct snd_soc_component *component, struct snd_pcm_substream *substream) 174 { 175 struct snd_pcm_runtime *runtime = substream->runtime; 176 struct device *dev = component->dev; 177 struct acp_dev_data *adata = dev_get_drvdata(dev); 178 struct acp_stream *stream; 179 int ret; 180 181 stream = kzalloc(sizeof(*stream), GFP_KERNEL); 182 if (!stream) 183 return -ENOMEM; 184 185 stream->substream = substream; 186 187 spin_lock_irq(&adata->acp_lock); 188 list_add_tail(&stream->list, &adata->stream_list); Stream added to the list 189 spin_unlock_irq(&adata->acp_lock); 190 191 if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) 192 runtime->hw = acp_pcm_hardware_playback; 193 else 194 runtime->hw = acp_pcm_hardware_capture; 195 196 ret = snd_pcm_hw_constraint_integer(runtime, SNDRV_PCM_HW_PARAM_PERIODS); 197 if (ret < 0) { 198 dev_err(component->dev, "set integer constraint failed\n"); --> 199 kfree(stream); Use after free. 200 return ret; 201 } 202 runtime->private_data = stream; 203 204 writel(1, ACP_EXTERNAL_INTR_ENB(adata)); 205 206 return ret; Could we delay adding the stream to the list until right before this "return 0;"? 207 } regards, dan carpenter

1 0

[PATCH 1/2] ASoC: Intel: Skylake: fix error message of NHLT blob selection
by Icenowy Zheng 18 Aug '22

18 Aug '22

The query to select NHLT blob had been changed to use parameters of the pipeline instead of PCM, however the error message returned when it fails still uses PCM properties. Fix this inconsistency. Fixes: 87b265260046 ("ASoC: Intel: Skylake: Select proper format for NHLT blob") Signed-off-by: Icenowy Zheng <uwu(a)icenowy.me> --- sound/soc/intel/skylake/skl-topology.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c index 9bdf020a2b64..19994ec8bba1 100644 --- a/sound/soc/intel/skylake/skl-topology.c +++ b/sound/soc/intel/skylake/skl-topology.c @@ -1864,7 +1864,8 @@ static int skl_tplg_be_fill_pipe_params(struct snd_soc_dai *dai, } else { dev_err(dai->dev, "Blob NULL for id:%d type:%d dirn:%d ch:%d, freq:%d, fmt:%d\n", mconfig->vbus_id, link_type, params->stream, - params->ch, params->s_freq, params->s_fmt); + pipe_fmt->channels, pipe_fmt->freq, + pipe_fmt->bps); return -EINVAL; } -- 2.37.1

3 9

[RESEND PATCH v2 0/6] ALSA: hda: Unify codec construction
by Cezary Rojewski 18 Aug '22

18 Aug '22

A follow up to the recent HDAudio fixes series [1]. Given the recently reported regression [2], before the page fault occurring on codec shutdown can be fixed, codec construction procedure needs to be updated for skylake and sof-intel drivers. Drivers: pci-hda and avs need no changes - already making use of snd_hda_codec_device_init(). As subject touches code used by the sof-driver, additional review has been conducted on thesofproject/linux [3]. Changes in v2: - dropped snd_hda_ext_core <-> snd_hda_codec dependency by calling snd_hda_codec_device_init() directly in skylake and sof drivers probe enumeration routines, as suggested by Takashi - skylake/sof portion of the change has been split into two separate patches - new functions that aim to replace hdac_ext codec init & exit functionality are added first - for skylake and sof drivers both - third patch in the series now combines the "field -> pointer" change for hdac_hda_priv->codec plus the codec-enumeration adjustments for skylake and sof drivers Both above are here to keep git bisect happy, as suggested by Pierre [1]: https://lore.kernel.org/alsa-devel/20220706120230.427296-7-cezary.rojewski@… [2]: https://lore.kernel.org/alsa-devel/3c40df55-3aee-1e08-493b-7b30cd84dc00@lin… [3]: https://github.com/thesofproject/linux/pull/3775 Cezary Rojewski (6): ASoC: Intel: Skylake: Introduce HDA codec init and exit routines ASoC: SOF: Intel: Introduce HDA codec init and exit routines ASoC: Intel: Drop hdac_ext usage for codec device creation ALSA: hda: Always free codec on the device release ALSA: hda: Remove codec init and exit routines ALSA: hda: Fix page fault in snd_hda_codec_shutdown() include/sound/hda_codec.h | 2 - include/sound/hdaudio_ext.h | 3 -- sound/hda/ext/hdac_ext_bus.c | 53 ------------------- sound/pci/hda/hda_codec.c | 49 ++++++++--------- sound/soc/codecs/hdac_hda.c | 26 ++++----- sound/soc/codecs/hdac_hda.h | 2 +- sound/soc/intel/boards/hda_dsp_common.c | 2 +- sound/soc/intel/boards/skl_hda_dsp_generic.c | 2 +- sound/soc/intel/skylake/skl.c | 53 ++++++++++++++----- sound/soc/sof/intel/hda-codec.c | 55 ++++++++++++++------ 10 files changed, 113 insertions(+), 134 deletions(-) -- 2.25.1

3 9

[PATCH] ALSA: hda/realtek: Add quirk for Clevo NS50PU, NS70PU
by Werner Sembach 18 Aug '22

18 Aug '22

From: Christoffer Sandberg <cs(a)tuxedo.de> Fixes headset microphone detection on Clevo NS50PU and NS70PU. Signed-off-by: Christoffer Sandberg <cs(a)tuxedo.de> Signed-off-by: Werner Sembach <wse(a)tuxedocomputers.com> Cc: <stable(a)vger.kernel.org> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index fd630d62b5a0..fceac608214e 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9389,6 +9389,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1558, 0x70f4, "Clevo NH77EPY", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1558, 0x70f6, "Clevo NH77DPQ-Y", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1558, 0x7716, "Clevo NS50PU", ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1558, 0x7717, "Clevo NS70PU", ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1558, 0x7718, "Clevo L140PU", ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1558, 0x8228, "Clevo NR40BU", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1558, 0x8520, "Clevo NH50D[CD]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), -- 2.34.1

2 2