- Alsa-devel - mailman.alsa-project.org

[PATCH -next 1/3] ASoC: amd: acp: add missing platform_device_unregister() in acp_pci_probe()
by Yang Yingliang 20 Aug '22

20 Aug '22

Add missing platform_device_unregister() in error path in acp_pci_probe(). Fixes: c49f5e74a11e ("ASoC: amd: acp: Add error handling cases") Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> --- sound/soc/amd/acp/acp-pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/amd/acp/acp-pci.c b/sound/soc/amd/acp/acp-pci.c index 2c8e960cc9a6..5bb23ebe1216 100644 --- a/sound/soc/amd/acp/acp-pci.c +++ b/sound/soc/amd/acp/acp-pci.c @@ -104,6 +104,7 @@ static int acp_pci_probe(struct pci_dev *pci, const struct pci_device_id *pci_id addr = pci_resource_start(pci, 0); chip->base = devm_ioremap(&pci->dev, addr, pci_resource_len(pci, 0)); if (!chip->base) { + platform_device_unregister(dmic_dev); ret = -ENOMEM; goto release_regions; } -- 2.25.1

2 3

[PATCH] ASoC: amd: acp: remove unnecessary NULL checks
by Dan Carpenter 20 Aug '22

20 Aug '22

The list iterator can never be NULL. Delete the bogus NULL checks. Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> --- sound/soc/amd/acp/acp-platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/amd/acp/acp-platform.c b/sound/soc/amd/acp/acp-platform.c index beee53aedeaf..85a81add4ef9 100644 --- a/sound/soc/amd/acp/acp-platform.c +++ b/sound/soc/amd/acp/acp-platform.c @@ -106,14 +106,14 @@ static irqreturn_t i2s_irq_handler(int irq, void *data) spin_lock(&adata->acp_lock); list_for_each_entry(stream, &adata->stream_list, list) { - if (stream && (ext_intr_stat & stream->irq_bit)) { + if (ext_intr_stat & stream->irq_bit) { writel(stream->irq_bit, ACP_EXTERNAL_INTR_STAT(adata, rsrc->irqp_used)); snd_pcm_period_elapsed(stream->substream); i2s_flag = 1; } if (adata->rsrc->no_of_ctrls == 2) { - if (stream && (ext_intr_stat1 & stream->irq_bit)) { + if (ext_intr_stat1 & stream->irq_bit) { writel(stream->irq_bit, ACP_EXTERNAL_INTR_STAT(adata, (rsrc->irqp_used - 1))); snd_pcm_period_elapsed(stream->substream); -- 2.35.1

2 1

[PATCH] ASoC: Change handling of unimplemented set_bclk_ratio
by Martin Povišer 20 Aug '22

20 Aug '22

If a 'set_bclk_ratio' call is attempted on a DAI not implementing the method, make it an -ENOSUPP error instead of -EINVAL. Assume the DAI can still be okay with the ratio, just does not care to register a handler. No current in-tree users of snd_soc_dai_set_bclk_ratio seem to inspect the return value, but -ENOSUPP disables an error print from within the common soc_dai_ret return filter. With the new behavior a machine driver can do a blanket 'set_bclk_ratio' on all DAIs on a bus, some of which may care about the ratio, some of which may not. Signed-off-by: Martin Povišer <povik+lin(a)cutebit.org> --- sound/soc/soc-dai.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/soc-dai.c b/sound/soc/soc-dai.c index d530e8c2b77b..49752af0e205 100644 --- a/sound/soc/soc-dai.c +++ b/sound/soc/soc-dai.c @@ -124,7 +124,7 @@ EXPORT_SYMBOL_GPL(snd_soc_dai_set_pll); */ int snd_soc_dai_set_bclk_ratio(struct snd_soc_dai *dai, unsigned int ratio) { - int ret = -EINVAL; + int ret = -ENOTSUPP; if (dai->driver->ops && dai->driver->ops->set_bclk_ratio) -- 2.33.0

2 1

[PATCH] soundwire: qcom: remove unneeded check
by Steev Klimaszewski 19 Aug '22

19 Aug '22

commit 1fd0d85affe4d6 ("soundwire: qcom: Add flag for software clock gating check") added a flag for software clock gating check, however in commit 33ba01788889666 ("soundwire: qcom: Add support for controlling audio CGCR from HLOS") the same check was added without the flag, so we would still end up failing the software clock gating check. Originally reported by Amit Pundir on DB845c, I also saw it on the Lenovo Yoga C630, right before the splat, we would see qcom-soundwire wcd934x-soundwire.6.auto: Failed to get audio_cgcr reset required for soundwire-v1.6.0 however, SDM845 has a soundwire-v1.3.0 Since the flag was added in 1fd0d85affe, lets just remove this one. Fixes: 33ba01788889 ("soundwire: qcom: Add support for controlling audio CGCR from HLOS") Signed-off-by: Steev Klimaszewski <steev(a)kali.org> Reported-by: Amit Pundir <amit.pundir(a)linaro.org> --- drivers/soundwire/qcom.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index 709a7c1e0704..b621f7fb866f 100644 --- a/drivers/soundwire/qcom.c +++ b/drivers/soundwire/qcom.c @@ -1355,10 +1355,6 @@ static int qcom_swrm_probe(struct platform_device *pdev) ctrl->bus.compute_params = &qcom_swrm_compute_params; ctrl->bus.clk_stop_timeout = 300; - ctrl->audio_cgcr = devm_reset_control_get_exclusive(dev, "swr_audio_cgcr"); - if (IS_ERR(ctrl->audio_cgcr)) - dev_err(dev, "Failed to get audio_cgcr reset required for soundwire-v1.6.0\n"); - ret = qcom_swrm_get_port_config(ctrl); if (ret) goto err_clk; -- 2.35.1

2 2

[PATCH v2] ASoC: SOF: Fix compilation when HDA_AUDIO_CODEC config is disabled
by Cezary Rojewski 19 Aug '22

19 Aug '22

hda_codec_device_init() expects three parameters, not two. Fixes: 3fd63658caed ("ASoC: Intel: Drop hdac_ext usage for codec device creation") Reported-by: kernel test robot <lkp(a)intel.com> Signed-off-by: Cezary Rojewski <cezary.rojewski(a)intel.com> --- Changes in v2: - adjusted SHA-1 provided in Fixes tag sound/soc/sof/intel/hda-codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sof/intel/hda-codec.c b/sound/soc/sof/intel/hda-codec.c index 73336648cd25..1e9afc48394c 100644 --- a/sound/soc/sof/intel/hda-codec.c +++ b/sound/soc/sof/intel/hda-codec.c @@ -213,7 +213,7 @@ static int hda_codec_probe(struct snd_sof_dev *sdev, int address, put_device(&codec->core.dev); } #else - codec = hda_codec_device_init(&hbus->core, address); + codec = hda_codec_device_init(&hbus->core, address, HDA_DEV_ASOC); ret = PTR_ERR_OR_ZERO(codec); #endif -- 2.25.1

3 2

[PATCH] ASoC: SOF: Fix compilation when HDA_AUDIO_CODEC config is disabled
by Cezary Rojewski 19 Aug '22

19 Aug '22

hda_codec_device_init() expects three parameters, not two. Fixes: f2183b08c81a ("ASoC: Intel: Drop hdac_ext usage for codec device creation") Reported-by: kernel test robot <lkp(a)intel.com> Signed-off-by: Cezary Rojewski <cezary.rojewski(a)intel.com> --- sound/soc/sof/intel/hda-codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sof/intel/hda-codec.c b/sound/soc/sof/intel/hda-codec.c index 73336648cd25..1e9afc48394c 100644 --- a/sound/soc/sof/intel/hda-codec.c +++ b/sound/soc/sof/intel/hda-codec.c @@ -213,7 +213,7 @@ static int hda_codec_probe(struct snd_sof_dev *sdev, int address, put_device(&codec->core.dev); } #else - codec = hda_codec_device_init(&hbus->core, address); + codec = hda_codec_device_init(&hbus->core, address, HDA_DEV_ASOC); ret = PTR_ERR_OR_ZERO(codec); #endif -- 2.25.1

2 2

chromium - cracking pulseaudio issue (small buffer size settings - 512)
by GitHub issues - edited 19 Aug '22

19 Aug '22

alsa-project/alsa-lib issue #262 was edited from shmohawk: ``` Aug 17 01:11:23 hellokitty pulseaudio[12938]: [alsa-sink-CX20590 Analog] alsa-sink.c: ALSA woke us up to write new data to the device, but there was actually nothing to write. Aug 17 01:11:23 hellokitty pulseaudio[12938]: [alsa-sink-CX20590 Analog] alsa-sink.c: Most likely this is a bug in the ALSA driver 'snd_hda_intel'. Please report this issue to the ALSA developers. Aug 17 01:11:23 hellokitty pulseaudio[12938]: [alsa-sink-CX20590 Analog] alsa-sink.c: We were woken up with POLLOUT set -- however a subsequent snd_pcm_avail() returned 0 or another value < min_avail. ``` It is symptomous with a crackling sound for ~5 seconds after any playback starts. alsa-lib 1.2.7.2 alsa-utils 1.2.7 alsa-plugins 1.2.2 Issue URL : https://github.com/alsa-project/alsa-lib/issues/262 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH 0/3] ASoC platform driver for Apple MCA
by Martin Povišer 19 Aug '22

19 Aug '22

Hi, for review I am posting another version of the ASoC platform driver to be used on Apple M1/M2 platforms (some previous version was attached to the macaudio RFC v2 [0]). Martin Changes since [0]: - addition of locking (extra commit) - transition to set_bclk_ratio (instead of getting the bclk ratio from set_sysclk) - using shared reset control and documenting the reset in binding - formatting, comments, and a minor fix to hw driving [0] https://lore.kernel.org/asahi/20220606191910.16580-1-povik+lin@cutebit.org/ Martin Povišer (3): dt-bindings: sound: Add Apple MCA I2S transceiver ASoC: apple: mca: Start new platform driver ASoC: apple: mca: Add locks on foreign cluster access .../devicetree/bindings/sound/apple,mca.yaml | 109 ++ MAINTAINERS | 8 + sound/soc/Kconfig | 1 + sound/soc/Makefile | 1 + sound/soc/apple/Kconfig | 9 + sound/soc/apple/Makefile | 3 + sound/soc/apple/mca.c | 1173 +++++++++++++++++ 7 files changed, 1304 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/apple,mca.yaml create mode 100644 sound/soc/apple/Kconfig create mode 100644 sound/soc/apple/Makefile create mode 100644 sound/soc/apple/mca.c -- 2.33.0

3 11

ucm2: Add intial acpes8336 support
by GitHub pull_request - opened 19 Aug '22

19 Aug '22

alsa-project/alsa-ucm-conf pull request #200 was opened from yangxiaohua2009: This add support for es8336 on AMD Jadeite platform. ASLAINFO http://alsa-project.org/db/?f=b5aae41350b63c40c7743ba43ff8a7178ee93229 Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/200 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/200.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

How trivial would it be to port the DICE driver from FFADO?
by forevernoob＠tutanota.com 19 Aug '22

19 Aug '22

Hello, I'm new to these kinds of mailing lists so please forgive me if I'm doing something dumb. I would love to see Allen & Heath Zed R16 as well as Midas Venice F32 support in ALSA. Currently (at least according to libffado-2.4.4/configuration), they are supported via the DICE driver: { # Allen and Heath Zed R16. Information from Brendan Pike. vendorid = 0x000004C4; modelid = 0x00000000; vendorname = "Allen and Heath"; modelname = "Zed R16"; driver = "DICE"; mixer = "Generic_Dice_EAP"; }, { # Midas Venice F32. Information from Jano Svitok. vendorid = 0x0010C73F; modelid = 0x00000001; vendorname = "Midas"; modelname = "Venice F32"; driver = "DICE"; mixer = "Generic_Dice_EAP"; }, In their source code I think it's this file: http://subversion.ffado.org/browser/branches/2.4.x/libffado/src/dice/dice_e… So my question would be: How difficult would it be to port this driver (more specifically: Port it sufficiently enough to support the aforementioned devices) ? Are we talking trivial enough for someone with minimal C experience, a dedicated team of ALSA devs or something else? Thanks in advance, FN

2 2