- Alsa-devel - mailman.alsa-project.org

[PATCH] Revert "aplay: fix S24_LE wav header"
by Shengjiu Wang 13 Nov '24

13 Nov '24

S24_LE means the lower 24bit in 32bit space has valid data. So previous code is correct. The commit causes regression, then revert it. This reverts commit 9cdcbe0e932b97fac88a6195f87647159a6c7194. Fixes: 9cdcbe0e932b ("aplay: fix S24_LE wav header") Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> --- aplay/aplay.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/aplay/aplay.c b/aplay/aplay.c index c58c2e9..d11e63a 100644 --- a/aplay/aplay.c +++ b/aplay/aplay.c @@ -2719,11 +2719,11 @@ static void begin_wave(int fd, size_t cnt) case SND_PCM_FORMAT_S16_LE: bits = 16; break; - case SND_PCM_FORMAT_S24_LE: /* S24_LE is 24 bits stored in 32 bit width with 8 bit padding */ case SND_PCM_FORMAT_S32_LE: - case SND_PCM_FORMAT_FLOAT_LE: + case SND_PCM_FORMAT_FLOAT_LE: bits = 32; break; + case SND_PCM_FORMAT_S24_LE: case SND_PCM_FORMAT_S24_3LE: bits = 24; break; -- 2.34.1

1 0

ALC4082 - ASRock X870 Steel Legend
by GitHub issues - edited 12 Nov '24

12 Nov '24

alsa-project/alsa-ucm-conf issue #462 was edited from cybik: | Following up on | Relevant PRs | Related issues | | ------------------| ---------------- | ---------------- | | https://github.com/alsa-project/alsa-ucm-conf/issues/334 | https://github.com/alsa-project/alsa-ucm-conf/pull/461 | #434 | ### Problem statement The card "works", but there is one feature missing - though I hesitate to call it "critical": S/PDIF / TOSLINK support is incomplete. While sound works "fine" (ish), it's limited to 2 channels. * Plugging in another USB device (CM106-type, for example) gives out a plethora of configuration options (per the screenshot), though this also comes with having to select the right output * The "USB" audio outs are output-specific, which is VERY welcome, but the S/PDIF out does not allow for any advanced selection like "Supported Codecs", and the HiFi 5.1 and 7.1 do not appear to enable any IEC958/AC3 support in the background Is there something missing in the config files to allow for such support? ### Relevant files & the such * [alsa-info info dump](https://github.com/user-attachments/files/17721762/alsa-info.txt) * Screenshot of the other USB device * ![image](https://github.com/user-attachments/assets/906ea829-0210-49a8-ba16-ad1b5b1285ae) Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/462 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

ALC4082 - ASRock X870 Steel Legend
by GitHub issues - edited 12 Nov '24

12 Nov '24

alsa-project/alsa-ucm-conf issue #462 was edited from cybik: | Following up on | Relevant PRs | Related issues | | ------------------| ---------------- | ---------------- | | https://github.com/alsa-project/alsa-ucm-conf/issues/334 | https://github.com/alsa-project/alsa-ucm-conf/pull/461 | #434 | The card "works", but there is one feature missing - though I hesitate to call it "critical": S/PDIF / TOSLINK support is incomplete. While sound works "fine" (ish), it's limited to 2 channels. * Plugging in another USB device (CM106-type, for example) gives out a plethora of configuration options (per the screenshot), though this also comes with having to select the right output * The "USB" audio outs are output-specific, which is VERY welcome, but the S/PDIF out does not allow for any advanced selection like "Supported Codecs", and the HiFi 5.1 and 7.1 do not appear to enable any IEC958/AC3 support in the background Is there something missing in the config files to allow for such support? ![image](https://github.com/user-attachments/assets/906ea829-0210-49a8-ba16-ad1b5b1285ae) ### Relevant files & the such [alsa-info.txt](https://github.com/user-attachments/files/17721762/alsa-info… Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/462 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

ALC4082 - ASRock X870 Steel Legend
by GitHub issues - edited 12 Nov '24

12 Nov '24

alsa-project/alsa-ucm-conf issue #462 was edited from cybik: | Following up on | Relevant PRs | Related issues | | ------------------| ---------------- | ---------------- | | https://github.com/alsa-project/alsa-ucm-conf/issues/334 | https://github.com/alsa-project/alsa-ucm-conf/pull/461 | #434 | The card "works", but there is one feature missing - though I hesitate to call it "critical": S/PDIF / TOSLINK support is incomplete. While sound works "fine" (ish), it's limited to 2 channels. * Plugging in another USB device (CM106-type, for example) gives out a plethora of configuration options (per the screenshot), though this also comes with having to select the right output * The "USB" audio outs are output-specific, which is VERY welcome, but the S/PDIF out does not allow for any advanced selection like "Supported Codecs", and the HiFi 5.1 and 7.1 do not appear to enable any IEC958/AC3 support in the background Is there something missing in the config files to allow for such support? ![image](https://github.com/user-attachments/assets/906ea829-0210-49a8-ba16-ad1b5b1285ae) Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/462 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

ALC4082 - ASRock X870 Steel Legend
by GitHub issues - edited 12 Nov '24

12 Nov '24

alsa-project/alsa-ucm-conf issue #462 was edited from cybik: | Following up | Relevant PR | Related issues | | ------------------| ---------------- | ---------------- | | https://github.com/alsa-project/alsa-ucm-conf/issues/334 | https://github.com/alsa-project/alsa-ucm-conf/pull/461 | #434 | The card "works", but there is one feature missing - though I hesitate to call it "critical": S/PDIF / TOSLINK support is incomplete. While sound works "fine" (ish), it's limited to 2 channels. * Plugging in another USB device (CM106-type, for example) gives out a plethora of configuration options (per the screenshot), though this also comes with having to select the right output * The "USB" audio outs are output-specific, which is VERY welcome, but the S/PDIF out does not allow for any advanced selection like "Supported Codecs", and the HiFi 5.1 and 7.1 do not appear to enable any IEC958/AC3 support in the background Is there something missing in the config files to allow for such support? ![image](https://github.com/user-attachments/assets/906ea829-0210-49a8-ba16-ad1b5b1285ae) Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/462 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

ALC4082 - ASRock X870 Steel Legend
by GitHub issues - edited 12 Nov '24

12 Nov '24

alsa-project/alsa-ucm-conf issue #462 was edited from cybik: | Following up | Relevant PR | | ------------------| ---------------- | | https://github.com/alsa-project/alsa-ucm-conf/issues/334 | https://github.com/alsa-project/alsa-ucm-conf/pull/461 | The card "works", but there is one feature missing - though I hesitate to call it "critical": S/PDIF / TOSLINK support is incomplete. While sound works "fine" (ish), it's limited to 2 channels. * Plugging in another USB device (CM106-type, for example) gives out a plethora of configuration options (per the screenshot), though this also comes with having to select the right output * The "USB" audio outs (edit: *for the ALC408x*) are output-specific, which is VERY welcome, but the S/PDIF out does not allow for any advanced selection like "Supported Codecs", and the HiFi 5.1 and 7.1 do not appear to enable any IEC958/AC3 support in the background Is there something missing in the config files to allow for such support? ![image](https://github.com/user-attachments/assets/906ea829-0210-49a8-ba16-ad1b5b1285ae) Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/462 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Clevo Platfrom with ALC255
by Kailang 12 Nov '24

12 Nov '24

Hi Takashi, Attach was let Clevo platform with ALC255 enable headset Mic. BR, Kailang

2 1

[PATCH AUTOSEL 5.4 4/5] ASoC: stm: Prevent potential division by zero in stm32_sai_get_clk_div()
by Sasha Levin 12 Nov '24

12 Nov '24

From: Luo Yifan <luoyifan(a)cmss.chinamobile.com> [ Upstream commit 23569c8b314925bdb70dd1a7b63cfe6100868315 ] This patch checks if div is less than or equal to zero (div <= 0). If div is zero or negative, the function returns -EINVAL, ensuring the division operation is safe to perform. Signed-off-by: Luo Yifan <luoyifan(a)cmss.chinamobile.com> Reviewed-by: Olivier Moysan <olivier.moysan(a)foss.st.com> Link: https://patch.msgid.link/20241107015936.211902-1-luoyifan@cmss.chinamobile.… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/stm/stm32_sai_sub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index b7dc9d3192597..e8cd58c0838ee 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -318,7 +318,7 @@ static int stm32_sai_get_clk_div(struct stm32_sai_sub_data *sai, int div; div = DIV_ROUND_CLOSEST(input_rate, output_rate); - if (div > SAI_XCR1_MCKDIV_MAX(version)) { + if (div > SAI_XCR1_MCKDIV_MAX(version) || div <= 0) { dev_err(&sai->pdev->dev, "Divider %d out of range\n", div); return -EINVAL; } -- 2.43.0

1 0

[PATCH AUTOSEL 5.4 3/5] ASoC: stm: Prevent potential division by zero in stm32_sai_mclk_round_rate()
by Sasha Levin 12 Nov '24

12 Nov '24

From: Luo Yifan <luoyifan(a)cmss.chinamobile.com> [ Upstream commit 63c1c87993e0e5bb11bced3d8224446a2bc62338 ] This patch checks if div is less than or equal to zero (div <= 0). If div is zero or negative, the function returns -EINVAL, ensuring the division operation (*prate / div) is safe to perform. Signed-off-by: Luo Yifan <luoyifan(a)cmss.chinamobile.com> Link: https://patch.msgid.link/20241106014654.206860-1-luoyifan@cmss.chinamobile.… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/stm/stm32_sai_sub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index 7e965848796c3..b7dc9d3192597 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -379,8 +379,8 @@ static long stm32_sai_mclk_round_rate(struct clk_hw *hw, unsigned long rate, int div; div = stm32_sai_get_clk_div(sai, *prate, rate); - if (div < 0) - return div; + if (div <= 0) + return -EINVAL; mclk->freq = *prate / div; -- 2.43.0

1 0

[PATCH AUTOSEL 5.10 5/6] ASoC: stm: Prevent potential division by zero in stm32_sai_get_clk_div()
by Sasha Levin 12 Nov '24

12 Nov '24

From: Luo Yifan <luoyifan(a)cmss.chinamobile.com> [ Upstream commit 23569c8b314925bdb70dd1a7b63cfe6100868315 ] This patch checks if div is less than or equal to zero (div <= 0). If div is zero or negative, the function returns -EINVAL, ensuring the division operation is safe to perform. Signed-off-by: Luo Yifan <luoyifan(a)cmss.chinamobile.com> Reviewed-by: Olivier Moysan <olivier.moysan(a)foss.st.com> Link: https://patch.msgid.link/20241107015936.211902-1-luoyifan@cmss.chinamobile.… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/stm/stm32_sai_sub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index 3a7f0102b4c5c..90e4757f76b0f 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -319,7 +319,7 @@ static int stm32_sai_get_clk_div(struct stm32_sai_sub_data *sai, int div; div = DIV_ROUND_CLOSEST(input_rate, output_rate); - if (div > SAI_XCR1_MCKDIV_MAX(version)) { + if (div > SAI_XCR1_MCKDIV_MAX(version) || div <= 0) { dev_err(&sai->pdev->dev, "Divider %d out of range\n", div); return -EINVAL; } -- 2.43.0

1 0