- Alsa-devel - mailman.alsa-project.org

[GIT PULL] ASoC fixes for v6.16-rc5
by Mark Brown 10 Jul '25

10 Jul '25

The following changes since commit 3b3312f28ee2d9c386602f8521e419cfc69f4823: ASoC: cs35l56: probe() should fail if the device ID is not recognized (2025-07-03 12:22:27 +0100) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-fix-v6.16-rc5 for you to fetch changes up to a609bd74b8680dba62c44f7e6d00d381ddb2d3c0: ASoC: Intel: avs: Fix NULL ptr deref on rmmod (2025-07-08 14:54:40 +0100) ---------------------------------------------------------------- ASoC: Fixes for v6.16 Two patches here, one quirk for an AMD system and a fix for an issue on remove of the AVS driver. ---------------------------------------------------------------- Alexandru Andries (1): ASoC: amd: yc: add DMI quirk for ASUS M6501RM Amadeusz Sławiński (1): ASoC: Intel: avs: Fix NULL ptr deref on rmmod sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ sound/soc/intel/avs/pcm.c | 4 +++- 2 files changed, 10 insertions(+), 1 deletion(-)

2 1

[PATCH] ASoC: samsung: Implement abox generic structure
by ew.kim＠samsung.com 10 Jul '25

10 Jul '25

From: ew kim <ew.kim(a)samsung.com> Implemet basic abox generic drivers. This driver is a management driver for the generic drivers used in Automotive Abox, connecting them to SOC drivers. It supports various Exynos Automotive SOCs. Signed-off-by: ew kim <ew.kim(a)samsung.com> --- sound/soc/samsung/Kconfig | 2 + sound/soc/samsung/Makefile | 1 + sound/soc/samsung/auto_abox/Kconfig | 14 + sound/soc/samsung/auto_abox/generic/Kbuild | 12 + .../samsung/auto_abox/generic/abox_generic.c | 568 ++++++++++++++++++ .../auto_abox/generic/include/abox_generic.h | 87 +++ 6 files changed, 684 insertions(+) create mode 100644 sound/soc/samsung/auto_abox/Kconfig create mode 100644 sound/soc/samsung/auto_abox/generic/Kbuild create mode 100644 sound/soc/samsung/auto_abox/generic/abox_generic.c create mode 100644 sound/soc/samsung/auto_abox/generic/include/abox_generic.h diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig index 60b4b7b75215..359aa67f49db 100644 --- a/sound/soc/samsung/Kconfig +++ b/sound/soc/samsung/Kconfig @@ -148,4 +148,6 @@ config SND_SOC_SAMSUNG_MIDAS_WM1811 help Say Y if you want to add support for SoC audio on the Midas boards. +source "sound/soc/samsung/auto_abox/Kconfig" + endif #SND_SOC_SAMSUNG diff --git a/sound/soc/samsung/Makefile b/sound/soc/samsung/Makefile index 8d5f09147900..5d99cfbfa71c 100644 --- a/sound/soc/samsung/Makefile +++ b/sound/soc/samsung/Makefile @@ -42,3 +42,4 @@ obj-$(CONFIG_SND_SOC_ARNDALE) += snd-soc-arndale.o obj-$(CONFIG_SND_SOC_SAMSUNG_TM2_WM5110) += snd-soc-tm2-wm5110.o obj-$(CONFIG_SND_SOC_SAMSUNG_ARIES_WM8994) += snd-soc-aries-wm8994.o obj-$(CONFIG_SND_SOC_SAMSUNG_MIDAS_WM1811) += snd-soc-midas-wm1811.o +obj-$(CONFIG_SND_SOC_SAMSUNG_AUTO_ABOX) += auto_abox/generic/ \ No newline at end of file diff --git a/sound/soc/samsung/auto_abox/Kconfig b/sound/soc/samsung/auto_abox/Kconfig new file mode 100644 index 000000000000..d5f565d3d9c2 --- /dev/null +++ b/sound/soc/samsung/auto_abox/Kconfig @@ -0,0 +1,14 @@ +#: SPDX-License-Identifier: GPL-2.0-only + +menu "Exynosauto Automotive Abox Modules Options" + +config SND_SOC_SAMSUNG_AUTO_ABOX + tristate "ASoC support for Samsung Exynosauto Automotive ABOX Audio" + select SND_SOC_COMPRESS + help + Say Y or M if you want to add support for codecs attached to + the Samsung SoC Auto ABOX interface. You will also need to + select the audio interfaces to support below. + +endmenu + diff --git a/sound/soc/samsung/auto_abox/generic/Kbuild b/sound/soc/samsung/auto_abox/generic/Kbuild new file mode 100644 index 000000000000..fa6ba7091730 --- /dev/null +++ b/sound/soc/samsung/auto_abox/generic/Kbuild @@ -0,0 +1,12 @@ +# SPDX-License-Identifier: GPL-2.0 +# Exynosauto Automotive Abox Driver Support + +snd-soc-samsung-abox-generic-$(CONFIG_SND_SOC_SAMSUNG_AUTO_ABOX) := \ + abox_generic.o + +ccflags-y += -I./include + +obj-$(CONFIG_SND_SOC_SAMSUNG_AUTO_ABOX) += \ + snd-soc-samsung-abox-generic.o + + diff --git a/sound/soc/samsung/auto_abox/generic/abox_generic.c b/sound/soc/samsung/auto_abox/generic/abox_generic.c new file mode 100644 index 000000000000..c4588e0a6a60 --- /dev/null +++ b/sound/soc/samsung/auto_abox/generic/abox_generic.c @@ -0,0 +1,568 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (c) 2020 Samsung Electronics Co., Ltd. + * http://www.samsung.com/ + * + * EXYNOS - sound/soc/samsung/auto_abox/generic/abox_generic.c + */ + +//#define DEBUG +#include <linux/clk.h> +#include <linux/io.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/of_address.h> +#include <linux/of_platform.h> +#include <linux/delay.h> +#include <linux/suspend.h> +#include <sound/soc.h> +#include <sound/soc-dapm.h> +#include <sound/pcm_params.h> +#include <linux/of_reserved_mem.h> +#include <linux/types.h> +#include <linux/kernel.h> +#include <linux/init.h> +#include <linux/sched/clock.h> +#include <linux/ktime.h> +#include <linux/iommu.h> +#include <linux/clk-provider.h> +#include <linux/kmod.h> +#include <linux/umh.h> +#include <linux/string.h> + +#include "include/abox_generic.h" + +static struct abox_generic_data *g_abox_generic_data; + +/** + * @cnotice + * @prdcode + * @Sub_SW_Component{abox_generic} + * @ALM_Link {work item url} + * @purpose "get value from virtual address" + * @logic "return global abox_generic_data" + * \image html + * @params + * @param{in, -, -, -} + * @endparam + * @retval {-, struct *abox_generic_data, !NULL, NULL} + */ +struct abox_generic_data *abox_generic_get_abox_generic_data(void) +{ + return g_abox_generic_data; +} + +static struct abox_generic_data *abox_generic_get_generic_data_from_child(struct device *child_dev) +{ + struct device *generic_dev = child_dev->parent; + struct abox_generic_data *generic_data = NULL; + + if (!generic_dev) { + pr_err("%s Failed to get generic device\n", __func__); + return NULL; + } + generic_data = dev_get_drvdata(generic_dev); + if (!generic_data) { + dev_err(generic_dev, "%s Failed to get generic data\n", __func__); + return NULL; + } + return generic_data; +} + +int abox_generic_set_dma_buffer(struct device *pcm_dev) +{ + struct abox_generic_data *generic_data = abox_generic_get_generic_data_from_child(pcm_dev); + int ret = 0; + + if (!generic_data) { + dev_err(pcm_dev, "%s Failed to get generic data\n", __func__); + return 0; + } + + if (!generic_data->soc_ioctl) { + dev_err(pcm_dev, "%s Failed to get soc_ioctl\n", __func__); + return 0; + } + ret = generic_data->soc_ioctl(generic_data->soc_dev, ABOX_SOC_IOCTL_SET_DMA_BUFFER, pcm_dev); + + return ret; +} + +int abox_generic_set_pp_pointer(struct device *pcm_dev) +{ + struct abox_generic_data *generic_data = abox_generic_get_generic_data_from_child(pcm_dev); + int ret = 0; + + if (!generic_data) { + dev_err(pcm_dev, "%s Failed to get generic data\n", __func__); + return 0; + } + if (!generic_data->soc_ioctl) { + dev_err(pcm_dev, "%s Failed to get soc_ioctl\n", __func__); + return 0; + } + ret = generic_data->soc_ioctl(generic_data->soc_dev, ABOX_SOC_IOCTL_SET_PP_POINTER, pcm_dev); + + return ret; +} + +int abox_generic_attach_soc_callback(struct device *soc_dev, + SOC_IOCTL soc_ioctl) +{ + struct abox_generic_data *generic_data = ABOX_GENERIC_DATA; + + dev_info(soc_dev, "%s(%d) Attach SoC IOCTL\n", __func__, __LINE__); + if (!generic_data) { + dev_err(soc_dev, "%s Generic Drv is not ready\n", __func__); + return -ENODATA; + } + generic_data->soc_dev = soc_dev; + generic_data->soc_ioctl = soc_ioctl; + + generic_data->num_of_rdma = generic_data->soc_ioctl(generic_data->soc_dev, + ABOX_SOC_IOCTL_GET_NUM_OF_RDMA, NULL); + generic_data->num_of_wdma = generic_data->soc_ioctl(generic_data->soc_dev, + ABOX_SOC_IOCTL_GET_NUM_OF_WDMA, NULL); + generic_data->num_of_uaif = generic_data->soc_ioctl(generic_data->soc_dev, + ABOX_SOC_IOCTL_GET_NUM_OF_UAIF, NULL); + dev_info(soc_dev, "%s(%d) num_of_rdma:%d\n", __func__, __LINE__, generic_data->num_of_rdma); + dev_info(soc_dev, "%s(%d) num_of_wdma:%d\n", __func__, __LINE__, generic_data->num_of_wdma); + dev_info(soc_dev, "%s(%d) num_of_uaif:%d\n", __func__, __LINE__, generic_data->num_of_uaif); + + return 0; +} +EXPORT_SYMBOL(abox_generic_attach_soc_callback); + +struct platform_device *abox_generic_get_pcm_platform_dev(int pcm_id, int stream_type) +{ + struct abox_generic_data *generic_data = ABOX_GENERIC_DATA; + struct platform_device **pdev_pcm = NULL; + + if (stream_type == SNDRV_PCM_STREAM_PLAYBACK) + pdev_pcm = generic_data->pdev_pcm_playback; + else + pdev_pcm = generic_data->pdev_pcm_capture; + + return pdev_pcm[pcm_id]; +} +EXPORT_SYMBOL(abox_generic_get_pcm_platform_dev); + +int abox_generic_get_num_of_pcm(int stream_type) +{ + struct abox_generic_data *generic_data = ABOX_GENERIC_DATA; + + if (!generic_data) { + pr_err("%s Failed to get abox_generic_data\n", __func__); + return -ENODATA; + } + + return (stream_type == SNDRV_PCM_STREAM_PLAYBACK) ? generic_data->num_of_pcm_playback : + generic_data->num_of_pcm_capture; +} +EXPORT_SYMBOL(abox_generic_get_num_of_pcm); + +int abox_generic_get_num_of_i2s_dummy(void) +{ + struct abox_generic_data *generic_data = ABOX_GENERIC_DATA; + + if (!generic_data) { + pr_err("%s Failed to get abox_generic_data\n", __func__); + return -ENODATA; + } + + return generic_data->num_of_i2s_dummy; +} +EXPORT_SYMBOL(abox_generic_get_num_of_i2s_dummy); + +int abox_generic_get_num_of_dma(struct device *pcm_dev, int stream_type) +{ + struct abox_generic_data *generic_data = abox_generic_get_generic_data_from_child(pcm_dev); + + return (stream_type == SNDRV_PCM_STREAM_PLAYBACK) ? + generic_data->num_of_rdma : generic_data->num_of_wdma; +} + +/** + * @cnotice + * @prdcode + * @Sub_SW_Component{abox generic} + * @ALM_Link {work item url} + * @purpose "Registering the pcm_playback/pcm_capture pdev to abox driver" + * @logic "Get the pcm playback instance and update the pcm playback/capture id and + * increament the pcm playback/capture count" + * \image html + * @params + * @param{in, pdev_pcm_dev, struct platform_device *, !NULL} + * @param{in, id, unsigned int, 0 ~ 32} + * @param{in, stream_type, int, 0 ~ 1} + * @endparam + * @retval{ret, int, Undefined, 0, <0} + */ +int abox_generic_register_pcm_dev(struct platform_device *pdev_pcm, + unsigned int id, int stream_type) +{ + struct device *pcm_dev = &pdev_pcm->dev; + struct abox_generic_data *generic_data = abox_generic_get_generic_data_from_child(pcm_dev); + int num_of_pcm_dev = 0; + + dev_dbg(pcm_dev, "[%s] PCM%d Attached Stream_type:%d\n", __func__, id, stream_type); + num_of_pcm_dev = (stream_type == SNDRV_PCM_STREAM_PLAYBACK) ? + generic_data->num_of_pcm_playback : generic_data->num_of_pcm_capture; + if (id >= num_of_pcm_dev) { + dev_err(pcm_dev, "%s: invalid id(%u) : Stream Type:%d\n", __func__, id, stream_type); + return -EINVAL; + } + + if (stream_type == SNDRV_PCM_STREAM_PLAYBACK) + generic_data->pdev_pcm_playback[id] = pdev_pcm; + else + generic_data->pdev_pcm_capture[id] = pdev_pcm; + + return 0; +} + +/** + * @cnotice + * @prdcode + * @Sub_SW_Component{abox} + * @ALM_Link {work item url} + * @purpose "finding struct device of frontend from backend" + * @logic "get device of backend using component and alsa macro" + * \image html audio-interface_abox_abox_find_fe_dev_from_rtd.png + * @params + * @param{in, be, struct snd_soc_pcm_runtime *, -} + * @endparam + * @retval {-, struct device *, !NULL, NULL} + */ +struct device *abox_generic_find_fe_dev_from_rtd(struct snd_soc_pcm_runtime *be) +{ + struct abox_generic_data *generic_data = ABOX_GENERIC_DATA; + struct snd_soc_dpcm *dpcm = NULL; + struct snd_soc_pcm_runtime *fe = NULL; + int stream_type = 0; + + if (!generic_data) + return NULL; + + for (stream_type = 0; stream_type <= SNDRV_PCM_STREAM_LAST; stream_type++) { + int cmpnt_index = 0; + struct snd_soc_component *component = NULL; + + for_each_dpcm_fe(be, stream_type, dpcm) { + fe = dpcm->fe; + if (fe) + break; + } + if (!fe) + continue; + + for_each_rtd_components(fe, cmpnt_index, component) { + struct platform_device **pdev = NULL; + int num_of_pcm_dev = 0; + int i = 0; + + if (stream_type == SNDRV_PCM_STREAM_PLAYBACK) { + num_of_pcm_dev = generic_data->num_of_pcm_playback; + pdev = generic_data->pdev_pcm_playback; + } else { + num_of_pcm_dev = generic_data->num_of_pcm_capture; + pdev = generic_data->pdev_pcm_capture; + } + for (i = 0; i < num_of_pcm_dev; i++) + if (pdev[i] && component->dev == &pdev[i]->dev) + return component->dev; + } + } + + return NULL; +} +EXPORT_SYMBOL_GPL(abox_generic_find_fe_dev_from_rtd); + +int abox_generic_request_soc_ioctl(struct device *generic_dev, enum abox_soc_ioctl_cmd cmd, + void *data) +{ + struct abox_generic_data *generic_data = dev_get_drvdata(generic_dev); + struct device *soc_dev = generic_data->soc_dev; + + if (IS_ERR_OR_NULL(soc_dev)) { + dev_err(generic_dev, "%s SoC Device is not ready\n", __func__); + return -ENODATA; + } + return generic_data->soc_ioctl(soc_dev, cmd, data); +} + +/** + * @cnotice + * @prdcode + * @Sub_SW_Component{abox generic} + * @ALM_Link + * @purpose "suspend of the abox generic to be called by S2R" + * @logic + * \image html + * @params + * @param{in, dev, struct device *, !NULL} + * @endparam + * @retval{ret, int, Undefined, 0, <0} + */ +static int abox_generic_suspend(struct device *dev) +{ + struct abox_generic_data *data = dev_get_drvdata(dev); + int ret = 0; + + dev_info(dev, "%s start\n", __func__); + if (!data) { + dev_err(dev, "%s: Invalid abox generic data\n", __func__); + return -ENODATA; + } + + dev_info(dev, "%s end\n", __func__); + + return ret; +} + +/** + * @cnotice + * @prdcode + * @Sub_SW_Component{abox generic} + * @ALM_Link + * @purpose "Resume the abox generic during S2R operation" + * @logic + * \image html + * @params + * @param{in, dev, struct device *, !NULL} + * @endparam + * @retval{ret, int, Undefined, 0, <0} + */ +static int abox_generic_resume(struct device *dev) +{ + struct abox_generic_data *data = dev_get_drvdata(dev); + int ret = 0; + + dev_info(dev, "%s start\n", __func__); + if (!data) { + dev_err(dev, "%s: Invalid abox generic data\n", __func__); + return -ENODATA; + } + + dev_info(dev, "%s end\n", __func__); + return ret; +} + +static struct platform_driver *abox_generic_sub_drivers[] = { +}; + +/** + * @cnotice + * @prdcode + * @Sub_SW_Component{abox} + * @ALM_Link {work item url} + * @purpose "Read property from device tree node" + * @logic + * \image html + * @params + * @param{in, dev, struct:: device *, !NULL} + * @param{in, dev->of_node, struct:: device_node, !NULL} + * @param{out, data->num_of_pcm_playback, unsigned int, 0} + * @param{out, data->num_of_pcm_capture, unsigned int, 0} + * @param{out, data->num_of_i2s_dummy, unsigned int, 0} + * @param{out, abox_sfr_set, int, 0} + * @endparam + * @retval{ret, int, 0, 0, > 0} + */ +static int abox_generic_read_property_from_dt(struct device *dev, struct abox_generic_data *data) +{ + struct device_node *np = dev->of_node; + int ret = 0; + + ret = of_property_read_u32(np, "samsung,num-of-pcm_playback", &data->num_of_pcm_playback); + if (ret < 0) { + dev_err(dev, "%s property reading fail\n", "samsung,num-of-pcm_playback"); + return ret; + } + ret = of_property_read_u32(np, "samsung,num-of-pcm_capture", &data->num_of_pcm_capture); + if (ret < 0) { + dev_err(dev, "%s property reading fail\n", "samsung,num-of-pcm_capture"); + return ret; + } + ret = of_property_read_u32(np, "samsung,num-of-i2s-dummy-backend", &data->num_of_i2s_dummy); + if (ret < 0) { + dev_err(dev, "%s property reading fail\n", "samsung,num-of-i2s-dummy-backend"); + return ret; + } + + return ret; +} + +/** + * @cnotice + * @prdcode + * @Sub_SW_Component{abox generic} + * @ALM_Link {work item url} + * @purpose "Allocate memory for abox generic" + * @logic + * \image html + * @params + * @param{in, dev, struct:: device *, !NULL} + * @param{in, data, struct:: abox_gneric_data, !NULL} + * @param{out, data->pdev_pcm_playback, struct:: platform_device, !NULL} + * @param{out, data->pdev_pcm_capture, struct:: platform_device, !NULL} + * @endparam + * @retval{ret, int, 0, 0, > 0} + */ +static int abox_generic_allocate_memory(struct device *dev, struct abox_generic_data *data) +{ + int ret = 0; + + data->pdev_pcm_playback = devm_kzalloc(dev, + sizeof(struct platform_device *) * data->num_of_pcm_playback, GFP_KERNEL); + if (!data->pdev_pcm_playback) { + dev_err(dev, "%s Can't allocate memory for pdev_pcm_playback\n", __func__); + ret = -ENOMEM; + return ret; + } + data->pdev_pcm_capture = devm_kzalloc(dev, + sizeof(struct platform_device *) * data->num_of_pcm_capture, GFP_KERNEL); + if (!data->pdev_pcm_capture) { + dev_err(dev, "%s Can't allocate memory for pdev_pcm_capture\n", __func__); + ret = -ENOMEM; + return ret; + } + + return ret; +} + +/** + * @cnotice + * @prdcode + * @Sub_SW_Component{abox generic} + * @ALM_Link {work item url} + * @purpose "Probing the abox generic" + * @logic + * \image html + * @params + * @param{in, pdev, struct platform_device *, !NULL} + * @param{in, pdev->dev, struct:: device, !NULL} + * @endparam + * @retval{ret, int, 0, 0, > 0} + */ +static int samsung_abox_generic_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct device_node *np = dev->of_node; + struct abox_generic_data *data; + int ret = 0; + + dev_info(dev, "%s\n", __func__); + data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); + if (!data) { + return -ENOMEM; + } + + data->pdev = pdev; + ret = abox_generic_read_property_from_dt(dev, data); + if (ret < 0) { + dev_err(dev, "%s Failed to read property. ret:%d\n", __func__, ret); + return ret; + } + ret = abox_generic_allocate_memory(dev, data); + if (ret < 0) { + dev_err(dev, "%s Failed to allocate memory. ret:%d\n", __func__, ret); + return ret; + } + g_abox_generic_data = data; + platform_set_drvdata(pdev, data); + + platform_register_drivers(abox_generic_sub_drivers, ARRAY_SIZE(abox_generic_sub_drivers)); + ret = of_platform_populate(np, NULL, NULL, dev); + if (ret < 0) { + dev_err(dev, "Failed to populate sub-platform_devices. ret:%d\n", ret); + return ret; + } + + return ret; +} + +/** + * @cnotice + * @prdcode + * @Sub_SW_Component{abox generic} + * @ALM_Link {work item url} + * @purpose "Disbaling the abox generic" + * @logic "Disbale the abox generic" + * \image html + * @params + * @param{in, pdev->dev, struct::device, !NULL} + * @endparam + * @noret + */ +static void samsung_abox_generic_remove(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct abox_generic_data *data = dev_get_drvdata(dev); + + dev_info(dev, "%s\n", __func__); + + if (!data) { + dev_err(dev, "%s: Invalid abox generic data\n", __func__); + return; + } + return; +} + +/** + * @cnotice + * @prdcode + * @Sub_SW_Component{abox generic} + * @ALM_Link {work item url} + * @purpose "shutdown of the abox generic" + * @logic "Disbale the abox hardware by calling the following function + * pm_runtime_disable(dev)" + * \image html + * @params + * @param{in, pdev->dev, struct:: device, !NULL} + * @endparam + * @noret + */ +static void samsung_abox_generic_shutdown(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct abox_generic_data *data = dev_get_drvdata(dev); + + if (!data) { + dev_err(dev, "%s: Invalid abox generic data\n", __func__); + return; + } + return; +} + +static const struct of_device_id samsung_abox_generic_match[] = { + { + .compatible = "samsung,abox_generic", + }, + {}, +}; +MODULE_DEVICE_TABLE(of, samsung_abox_generic_match); + +static const struct dev_pm_ops samsung_abox_generic_pm = { + SET_SYSTEM_SLEEP_PM_OPS(abox_generic_suspend, abox_generic_resume) +}; + +struct platform_driver samsung_abox_generic_driver = { + .probe = samsung_abox_generic_probe, + .remove = samsung_abox_generic_remove, + .shutdown = samsung_abox_generic_shutdown, + .driver = { + .name = "samsung-abox-generic", + .owner = THIS_MODULE, + .of_match_table = of_match_ptr(samsung_abox_generic_match), + .pm = &samsung_abox_generic_pm, + }, +}; + +module_platform_driver(samsung_abox_generic_driver); +/* Module information */ +MODULE_AUTHOR("Eunwoo Kim, <ew.kim(a)samsung.com>"); +MODULE_DESCRIPTION("Samsung ASoC A-Box Generic Driver"); +MODULE_ALIAS("platform:samsung-abox-generic"); +MODULE_LICENSE("GPL v2"); + diff --git a/sound/soc/samsung/auto_abox/generic/include/abox_generic.h b/sound/soc/samsung/auto_abox/generic/include/abox_generic.h new file mode 100644 index 000000000000..1c954272e2b5 --- /dev/null +++ b/sound/soc/samsung/auto_abox/generic/include/abox_generic.h @@ -0,0 +1,87 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * ALSA SoC - Samsung ABOX Share Function and Data structure + * for Exynos specific extensions + * + * Copyright (C) 2013-2020 Samsung Electronics Co., Ltd. + * + * EXYNOS - sound/soc/samsung/abox/include/abox_generic.h + */ + +#ifndef __SND_SOC_ABOX_GENERIC_BASE_H +#define __SND_SOC_ABOX_GENERIC_BASE_H + +#define ABOX_GENERIC_DATA abox_generic_get_abox_generic_data(); + +struct snd_soc_pcm_runtime; + +enum abox_soc_ioctl_cmd { + ABOX_SOC_IOCTL_GET_NUM_OF_RDMA, + ABOX_SOC_IOCTL_GET_NUM_OF_WDMA, + ABOX_SOC_IOCTL_GET_NUM_OF_UAIF, + ABOX_SOC_IOCTL_GET_SOC_TIMER, + ABOX_SOC_IOCTL_SET_DMA_BUFFER, + ABOX_SOC_IOCTL_SET_PP_POINTER, + ABOX_SOC_IOCTL_SET_PERF_PERIOD, + ABOX_SOC_IOCTL_CHECK_TIME_MUTEX, + ABOX_SOC_IOCTL_CHECK_TIME_NO_MUTEX, + ABOX_SOC_IOCTL_PCM_DUMP_INTR, + ABOX_SOC_IOCTL_PCM_DUMP_CLOSE, + ABOX_SOC_IOCTL_PCM_DUMP_ADD_CONTROL, + ABOX_SOC_IOCTL_MAX +}; + +typedef int (*SOC_IOCTL)(struct device *soc_dev, enum abox_soc_ioctl_cmd cmd, void *data); + +struct abox_generic_data { + struct platform_device *pdev; + struct platform_device **pdev_pcm_playback; + struct platform_device **pdev_pcm_capture; + unsigned int num_of_pcm_playback; + unsigned int num_of_pcm_capture; + unsigned int num_of_i2s_dummy; + unsigned int num_of_rdma; + unsigned int num_of_wdma; + unsigned int num_of_uaif; + struct device *soc_dev; + SOC_IOCTL soc_ioctl; +}; + + +/************ Internal API ************/ + +struct abox_generic_data *abox_generic_get_abox_generic_data(void); + +int abox_generic_set_dma_buffer(struct device *pcm_dev); + +int abox_generic_request_soc_ioctl(struct device *generic_dev, enum abox_soc_ioctl_cmd cmd, + void *data); + +int abox_generic_set_pp_pointer(struct device *pcm_dev); + + + + +/************ External API ************/ + +extern struct device *abox_generic_find_fe_dev_from_rtd(struct snd_soc_pcm_runtime *be); + +extern struct platform_device *abox_generic_get_pcm_platform_dev(int pcm_id, + int stream_type); + +extern int abox_generic_get_num_of_pcm(int stream_type); + +extern int abox_generic_get_num_of_i2s_dummy(void); + +extern int abox_generic_get_num_of_dma(struct device *pcm_dev, + int stream_type); + +extern int abox_generic_attach_soc_callback(struct device *soc_dev, + SOC_IOCTL soc_ioctl); + +extern int abox_generic_register_pcm_dev(struct platform_device *pdev_pcm_dev, + unsigned int id, int stream_type); + + +#endif //__SND_SOC_ABOX_GENERIC_BASE_H + -- 2.25.1

5 7

[PATCH] ASoC: dt-bindings: Add samsung,abox-generic document
by ew kim 09 Jul '25

09 Jul '25

Add soundcard bindings for the abox generic of exynus automotive. Signed-off-by: ew kim <ew.kim(a)samsung.com> --- .../bindings/sound/samsung,abox-generic.yaml | 77 +++++++++++++++++++ 1 file changed, 77 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/samsung,abox-generic.yaml diff --git a/Documentation/devicetree/bindings/sound/samsung,abox-generic.yaml b/Documentation/devicetree/bindings/sound/samsung,abox-generic.yaml new file mode 100644 index 000000000000..bf641a197903 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/samsung,abox-generic.yaml @@ -0,0 +1,77 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/soc/samsung/abox-generic.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Samsung Exynos Automotive Abox Generic + +maintainers: + - name: Eunwoo Kim + email: ew.kim(a)samsung.com + +description: | + Samsung Exynos Automotive Abox Generic core node. + + This node represents the generic Abox controller which manages + various Abox sub-drivers and acts as a hub connecting them to + SoC-level audio drivers. It provides PCM playback and capture + configuration, as well as dummy I2S backend handling, enabling + integration between Abox IP blocks and the SoC audio subsystem. + + Typically, this node is used to initialize and configure playback, + capture, and routing between the Abox and other SoC audio components. + +properties: + compatible: + const: samsung,abox_generic + + samsung,num-of-pcm_playback: + description: Number of PCM playback instances. + $ref: /schemas/types.yaml#/definitions/uint32 + + samsung,num-of-pcm_capture: + description: Number of PCM capture instances. + $ref: /schemas/types.yaml#/definitions/uint32 + + samsung,num-of-i2s-dummy-backend: + description: Number of dummy I2S backend instances. + $ref: /schemas/types.yaml#/definitions/uint32 + + status: + description: Availability status. + enum: [ "okay", "disabled" ] + + '#address-cells': + description: Number of address cells in the node. + const: 2 + + '#size-cells': + description: Number of size cells in the node. + const: 1 + + ranges: + description: Standard `ranges` property for bus address mapping. + type: object + +required: + - compatible + - samsung,num-of-pcm_playback + - samsung,num-of-pcm_capture + - samsung,num-of-i2s-dummy-backend + +additionalProperties: false + +examples: + - | + abox_generic: abox_generic@generic { + compatible = "samsung,abox_generic"; + samsung,num-of-pcm_playback = <32>; + samsung,num-of-pcm_capture = <32>; + samsung,num-of-i2s-dummy-backend = <5>; + status = "disabled"; + #address-cells = <2>; + #size-cells = <1>; + ranges; + }; + -- 2.25.1

3 2

[tiwai-sound:test/hda-reorg 17/42] sound/soc/intel/atom/sst/sst_acpi.c:272: undefined reference to `snd_intel_acpi_dsp_driver_probe'
by kernel test robot 08 Jul '25

08 Jul '25

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git test/hda-reorg head: be6979113a769a90bab2a55a30ae83b76f5971e6 commit: d1bc64a913342041aaacdde0c0920eb0d5b96281 [17/42] ALSA: hda: Move HD-audio core stuff into sound/hda/core config: i386-randconfig-063-20250522 (https://download.01.org/0day-ci/archive/20250708/202507081351.iyDgGOUP-lkp@…) compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250708/202507081351.iyDgGOUP-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202507081351.iyDgGOUP-lkp@intel.com/ All errors (new ones prefixed by >>): ld: sound/soc/intel/atom/sst/sst_acpi.o: in function `sst_acpi_probe': >> sound/soc/intel/atom/sst/sst_acpi.c:272: undefined reference to `snd_intel_acpi_dsp_driver_probe' vim +272 sound/soc/intel/atom/sst/sst_acpi.c 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 255 5129ad6e4e6999 sound/soc/intel/sst/sst_acpi.c Wei Yongjun 2014-12-09 256 static int sst_acpi_probe(struct platform_device *pdev) 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 257 { 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 258 struct device *dev = &pdev->dev; 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 259 int ret = 0; 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 260 struct intel_sst_drv *ctx; 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 261 const struct acpi_device_id *id; 7feb2f786a46d3 sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2017-10-12 262 struct snd_soc_acpi_mach *mach; 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 263 struct platform_device *mdev; 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 264 struct platform_device *plat_dev; 12cc291b0b5850 sound/soc/intel/atom/sst/sst_acpi.c Vinod Koul 2015-11-05 265 struct sst_platform_info *pdata; 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 266 unsigned int dev_id; 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 267 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 268 id = acpi_match_device(dev->driver->acpi_match_table, dev); 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 269 if (!id) 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 270 return -ENODEV; df5f5edaef4b65 sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2020-11-12 271 df5f5edaef4b65 sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2020-11-12 @272 ret = snd_intel_acpi_dsp_driver_probe(dev, id->id); df5f5edaef4b65 sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2020-11-12 273 if (ret != SND_INTEL_DSP_DRIVER_ANY && ret != SND_INTEL_DSP_DRIVER_SST) { df5f5edaef4b65 sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2020-11-12 274 dev_dbg(dev, "SST ACPI driver not selected, aborting probe\n"); df5f5edaef4b65 sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2020-11-12 275 return -ENODEV; df5f5edaef4b65 sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2020-11-12 276 } df5f5edaef4b65 sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2020-11-12 277 1635c694124fe6 sound/soc/intel/atom/sst/sst_acpi.c Colin Ian King 2016-09-16 278 dev_dbg(dev, "for %s\n", id->id); 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 279 7feb2f786a46d3 sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2017-10-12 280 mach = (struct snd_soc_acpi_mach *)id->driver_data; 7feb2f786a46d3 sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2017-10-12 281 mach = snd_soc_acpi_find_machine(mach); 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 282 if (mach == NULL) { 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 283 dev_err(dev, "No matching machine driver found\n"); 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 284 return -ENODEV; 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 285 } 73a33f6f6d44db sound/soc/intel/atom/sst/sst_acpi.c Vinod Koul 2016-07-08 286 536cfd2f375d36 sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2019-05-30 287 if (soc_intel_is_byt()) 6004640638a2cb sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2017-10-12 288 mach->pdata = &byt_rvp_platform_data; 6004640638a2cb sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2017-10-12 289 else 6004640638a2cb sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2017-10-12 290 mach->pdata = &chv_platform_data; 12cc291b0b5850 sound/soc/intel/atom/sst/sst_acpi.c Vinod Koul 2015-11-05 291 pdata = mach->pdata; 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 292 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 293 if (!strcmp(id->id, "LPE0F28")) { 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 294 struct resource *rsrc; 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 295 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 296 /* Use regular BYT SST PCI VID:PID */ 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 297 dev_id = 0x80860F28; 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 298 byt_rvp_platform_data.res_info = &lpe8086_res_info; 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 299 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 300 /* 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 301 * The "LPE0F28" ACPI device has separate IO-mem resources for: 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 302 * DDR, SHIM, MBOX, IRAM, DRAM, CFG 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 303 * None of which covers the entire LPE base address range. 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 304 * lpe8086_res_info.acpi_lpe_res_index points to the SHIM. 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 305 * Patch this to cover the entire base address range as expected 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 306 * by sst_platform_get_resources(). 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 307 */ 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 308 rsrc = platform_get_resource(pdev, IORESOURCE_MEM, 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 309 pdata->res_info->acpi_lpe_res_index); 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 310 if (!rsrc) { c1895ba181e560 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-26 311 dev_err(dev, "Invalid SHIM base\n"); 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 312 return -EIO; 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 313 } 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 314 rsrc->start -= pdata->res_info->shim_offset; 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 315 rsrc->end = rsrc->start + 0x200000 - 1; 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 316 } else { 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 317 ret = kstrtouint(id->id, 16, &dev_id); 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 318 if (ret < 0) { 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 319 dev_err(dev, "Unique device id conversion error: %d\n", ret); 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 320 return ret; 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 321 } 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 322 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 323 if (soc_intel_is_byt_cr(pdev)) 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 324 byt_rvp_platform_data.res_info = &bytcr_res_info; 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 325 } 6668610b4d8ce9 sound/soc/intel/atom/sst/sst_acpi.c Hans de Goede 2024-10-25 326 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 327 dev_dbg(dev, "ACPI device id: %x\n", dev_id); 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 328 a68bc0d43e1b96 sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2016-08-12 329 ret = sst_alloc_drv_context(&ctx, dev, dev_id); a68bc0d43e1b96 sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2016-08-12 330 if (ret < 0) a68bc0d43e1b96 sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2016-08-12 331 return ret; a68bc0d43e1b96 sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2016-08-12 332 3ee1cd4f81e15f sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2018-11-01 333 /* update machine parameters */ 3ee1cd4f81e15f sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2018-11-01 334 mach->mach_params.acpi_ipc_irq_index = 3ee1cd4f81e15f sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2018-11-01 335 pdata->res_info->acpi_ipc_irq_index; 3ee1cd4f81e15f sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2018-11-01 336 caf94ed8629afb sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2016-01-04 337 plat_dev = platform_device_register_data(dev, pdata->platform, -1, caf94ed8629afb sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2016-01-04 338 NULL, 0); f5d40b400fe2de sound/soc/intel/sst/sst_acpi.c Wei Yongjun 2014-12-09 339 if (IS_ERR(plat_dev)) { caf94ed8629afb sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2016-01-04 340 dev_err(dev, "Failed to create machine device: %s\n", caf94ed8629afb sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2016-01-04 341 pdata->platform); f5d40b400fe2de sound/soc/intel/sst/sst_acpi.c Wei Yongjun 2014-12-09 342 return PTR_ERR(plat_dev); 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 343 } 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 344 caf94ed8629afb sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2016-01-04 345 /* caf94ed8629afb sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2016-01-04 346 * Create platform device for sst machine driver, caf94ed8629afb sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2016-01-04 347 * pass machine info as pdata caf94ed8629afb sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2016-01-04 348 */ caf94ed8629afb sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2016-01-04 349 mdev = platform_device_register_data(dev, mach->drv_name, -1, caf94ed8629afb sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2016-01-04 350 (const void *)mach, sizeof(*mach)); f5d40b400fe2de sound/soc/intel/sst/sst_acpi.c Wei Yongjun 2014-12-09 351 if (IS_ERR(mdev)) { caf94ed8629afb sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2016-01-04 352 dev_err(dev, "Failed to create machine device: %s\n", caf94ed8629afb sound/soc/intel/atom/sst/sst_acpi.c Pierre-Louis Bossart 2016-01-04 353 mach->drv_name); f5d40b400fe2de sound/soc/intel/sst/sst_acpi.c Wei Yongjun 2014-12-09 354 return PTR_ERR(mdev); 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 355 } 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 356 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 357 /* Fill sst platform data */ 12cc291b0b5850 sound/soc/intel/atom/sst/sst_acpi.c Vinod Koul 2015-11-05 358 ctx->pdata = pdata; 12cc291b0b5850 sound/soc/intel/atom/sst/sst_acpi.c Vinod Koul 2015-11-05 359 strcpy(ctx->firmware_name, mach->fw_filename); 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 360 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 361 ret = sst_platform_get_resources(ctx); 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 362 if (ret) 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 363 return ret; 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 364 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 365 ret = sst_context_init(ctx); 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 366 if (ret < 0) 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 367 return ret; 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 368 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 369 sst_configure_runtime_pm(ctx); 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 370 platform_set_drvdata(pdev, ctx); 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 371 return ret; 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 372 } 336cfbb05edf7b sound/soc/intel/sst/sst_acpi.c Vinod Koul 2014-11-11 373 :::::: The code at line 272 was first introduced by commit :::::: df5f5edaef4b653fa731dcf3753e71766f95c2cd ASoC: Intel: Atom: add dynamic selection of DSP driver :::::: TO: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> :::::: CC: Mark Brown <broonie(a)kernel.org> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH v2] ALSA: hda/tas2781: Fix calibration data parser issue
by Baojun Xu 07 Jul '25

07 Jul '25

We will copy calibration data from position behind to front. We has created a variable (tmp_val) point on top of calibration data buffer, and tmp_val[1] is max of node number in original calibration data structure, it will be overwritten after first data copy, so can't be used as max node number check in for loop. So we create a new variable to save max of node number (tmp_val[1]), used to check if max node number was reached in for loop. And a point need to be increased to point at calibration data in node. Data saved position also need to be increased one byte. Fixes: 4fe238513407 ("ALSA: hda/tas2781: Move and unified the calibrated-data getting function for SPI and I2C into the tas2781_hda lib") Signed-off-by: Baojun Xu <baojun.xu(a)ti.com> --- Change in v2: - Add more description about this fix. --- sound/pci/hda/tas2781_hda.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sound/pci/hda/tas2781_hda.c b/sound/pci/hda/tas2781_hda.c index 5f1d4b3e9688..34217ce9f28e 100644 --- a/sound/pci/hda/tas2781_hda.c +++ b/sound/pci/hda/tas2781_hda.c @@ -44,7 +44,7 @@ static void tas2781_apply_calib(struct tasdevice_priv *p) TASDEVICE_REG(0, 0x13, 0x70), TASDEVICE_REG(0, 0x18, 0x7c), }; - unsigned int crc, oft; + unsigned int crc, oft, node_num; unsigned char *buf; int i, j, k, l; @@ -80,8 +80,9 @@ static void tas2781_apply_calib(struct tasdevice_priv *p) dev_err(p->dev, "%s: CRC error\n", __func__); return; } + node_num = tmp_val[1]; - for (j = 0, k = 0; j < tmp_val[1]; j++) { + for (j = 0, k = 0; j < node_num; j++) { oft = j * 6 + 3; if (tmp_val[oft] == TASDEV_UEFI_CALI_REG_ADDR_FLG) { for (i = 0; i < TASDEV_CALIB_N; i++) { @@ -99,8 +100,9 @@ static void tas2781_apply_calib(struct tasdevice_priv *p) } data[l] = k; + oft++; for (i = 0; i < TASDEV_CALIB_N * 4; i++) - data[l + i] = data[4 * oft + i]; + data[l + i + 1] = data[4 * oft + i]; k++; } } -- 2.43.0

1 0

[PATCH v1] ALSA: hda/tas2781: Add bus name in device name check
by Baojun Xu 06 Jul '25

06 Jul '25

Device name start from bus name, as we use strstarts() to do compare, need add it for TXNW2781 device. Fixes: b2904df0a347 ("ALSA: hda/tas2781: Add compatible for hardware id TIAS2781 and TXNW2781") Signed-off-by: Baojun Xu <baojun.xu(a)ti.com> --- sound/pci/hda/tas2781_hda_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c index b9cdbca951e4..530c2266ab3b 100644 --- a/sound/pci/hda/tas2781_hda_i2c.c +++ b/sound/pci/hda/tas2781_hda_i2c.c @@ -588,7 +588,7 @@ static int tas2781_hda_i2c_probe(struct i2c_client *clt) hda_priv->save_calibration = tas2781_save_calibration; tas_hda->priv->global_addr = TAS2781_GLOBAL_ADDR; } else if (strstarts(dev_name(&clt->dev), - "TXNW2781:00-tas2781-hda.0")) { + "i2c-TXNW2781:00-tas2781-hda.0")) { device_name = "TXNW2781"; hda_priv->save_calibration = tas2781_save_calibration; tas_hda->priv->global_addr = TAS2781_GLOBAL_ADDR; -- 2.43.0

1 1

[PATCH v1] ALSA: hda/tas2781: Fix calibration data parser issue
by Baojun Xu 06 Jul '25

06 Jul '25

Calibration data was overwritten during parser, it cause issue. Fixes: 4fe238513407 ("ALSA: hda/tas2781: Move and unified the calibrated-data getting function for SPI and I2C into the tas2781_hda lib") Signed-off-by: Baojun Xu <baojun.xu(a)ti.com> --- sound/pci/hda/tas2781_hda.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sound/pci/hda/tas2781_hda.c b/sound/pci/hda/tas2781_hda.c index 5f1d4b3e9688..34217ce9f28e 100644 --- a/sound/pci/hda/tas2781_hda.c +++ b/sound/pci/hda/tas2781_hda.c @@ -44,7 +44,7 @@ static void tas2781_apply_calib(struct tasdevice_priv *p) TASDEVICE_REG(0, 0x13, 0x70), TASDEVICE_REG(0, 0x18, 0x7c), }; - unsigned int crc, oft; + unsigned int crc, oft, node_num; unsigned char *buf; int i, j, k, l; @@ -80,8 +80,9 @@ static void tas2781_apply_calib(struct tasdevice_priv *p) dev_err(p->dev, "%s: CRC error\n", __func__); return; } + node_num = tmp_val[1]; - for (j = 0, k = 0; j < tmp_val[1]; j++) { + for (j = 0, k = 0; j < node_num; j++) { oft = j * 6 + 3; if (tmp_val[oft] == TASDEV_UEFI_CALI_REG_ADDR_FLG) { for (i = 0; i < TASDEV_CALIB_N; i++) { @@ -99,8 +100,9 @@ static void tas2781_apply_calib(struct tasdevice_priv *p) } data[l] = k; + oft++; for (i = 0; i < TASDEV_CALIB_N * 4; i++) - data[l + i] = data[4 * oft + i]; + data[l + i + 1] = data[4 * oft + i]; k++; } } -- 2.43.0

1 0

test: update midifile library to ANSI C
by GitHub pull_request - opened 06 Jul '25

06 Jul '25

alsa-project/alsa-lib pull request #463 was opened from atsampson: The `midifile` library used by the `playmidi1` program dates from 1989, and used pre-ANSI function definitions and prototypes. GCC 15 now defaults to C23 where `()` means the same as `(void)` in prototypes, which causes type mismatch errors. Update the code to use ANSI function definitions and prototypes, so it'll compile happily as anything from ANSI C to C23. This revealed that `playmidi1`'s `do_tempo` had the wrong argument type, so correct that as well. Fixes #452. Request URL : https://github.com/alsa-project/alsa-lib/pull/463 Patch URL : https://github.com/alsa-project/alsa-lib/pull/463.patch Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[tiwai-sound:test/hda-reorg 41/53] sound/hda/codecs/cirrus/cs421x.c:561:35: warning: 'cs421x_codec_ops' defined but not used
by kernel test robot 05 Jul '25

05 Jul '25

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git test/hda-reorg head: 6119728edf86cefcbf7b20e000414c85916e900d commit: 484072d3f99c402030fcee94e28ab3ea76d04247 [41/53] ALSA: hda/cirrus: Split to cs420x and cs421x drivers config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20250705/202507051737.DMAkxayN-lkp@…) compiler: sh4-linux-gcc (GCC) 15.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250705/202507051737.DMAkxayN-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202507051737.DMAkxayN-lkp@intel.com/ All warnings (new ones prefixed by >>): >> sound/hda/codecs/cirrus/cs421x.c:561:35: warning: 'cs421x_codec_ops' defined but not used [-Wunused-const-variable=] 561 | static const struct hda_codec_ops cs421x_codec_ops = { | ^~~~~~~~~~~~~~~~ vim +/cs421x_codec_ops +561 sound/hda/codecs/cirrus/cs421x.c 560 > 561 static const struct hda_codec_ops cs421x_codec_ops = { 562 .probe = cs421x_probe, 563 .remove = snd_hda_gen_remove, 564 .build_controls = snd_hda_gen_build_controls, 565 .build_pcms = snd_hda_gen_build_pcms, 566 .init = cs421x_init, 567 .unsol_event = snd_hda_jack_unsol_event, 568 .suspend = cs421x_suspend, 569 .stream_pm = snd_hda_gen_stream_pm, 570 }; 571 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[tiwai-sound:test/hda-reorg 29/53] sound/hda/common/hwdep.c:26:6: warning: label followed by a declaration is a C23 extension
by kernel test robot 05 Jul '25

05 Jul '25

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git test/hda-reorg head: 6119728edf86cefcbf7b20e000414c85916e900d commit: 5b965be899c8e3286f5111b7e90207afe5124b67 [29/53] ALSA: hda: Move common codec driver into sound/hda/common directory config: riscv-randconfig-001-20250705 (https://download.01.org/0day-ci/archive/20250705/202507051454.VintnWOF-lkp@…) compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project 61529d9e36fa86782a2458e6bdeedf7f376ef4b5) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250705/202507051454.VintnWOF-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202507051454.VintnWOF-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from sound/hda/common/hwdep.c:10: In file included from include/linux/compat.h:17: include/linux/fs.h:3979:15: warning: label followed by a declaration is a C23 extension [-Wc23-extensions] 3979 | if (unlikely(get_user(c, path))) | ^ arch/riscv/include/asm/uaccess.h:274:3: note: expanded from macro 'get_user' 274 | __get_user((x), __p) : \ | ^ arch/riscv/include/asm/uaccess.h:244:2: note: expanded from macro '__get_user' 244 | __get_user_error(__gu_val, __gu_ptr, __gu_err); \ | ^ arch/riscv/include/asm/uaccess.h:207:2: note: expanded from macro '__get_user_error' 207 | __get_user_nocheck(x, ptr, __gu_failed); \ | ^ arch/riscv/include/asm/uaccess.h:196:3: note: expanded from macro '__get_user_nocheck' 196 | __get_user_8((x), __gu_ptr, label); \ | ^ arch/riscv/include/asm/uaccess.h:130:2: note: expanded from macro '__get_user_8' 130 | u32 __user *__ptr = (u32 __user *)(ptr); \ | ^ >> sound/hda/common/hwdep.c:26:6: warning: label followed by a declaration is a C23 extension [-Wc23-extensions] 26 | if (get_user(verb, &arg->verb)) | ^ arch/riscv/include/asm/uaccess.h:274:3: note: expanded from macro 'get_user' 274 | __get_user((x), __p) : \ | ^ arch/riscv/include/asm/uaccess.h:244:2: note: expanded from macro '__get_user' 244 | __get_user_error(__gu_val, __gu_ptr, __gu_err); \ | ^ arch/riscv/include/asm/uaccess.h:207:2: note: expanded from macro '__get_user_error' 207 | __get_user_nocheck(x, ptr, __gu_failed); \ | ^ arch/riscv/include/asm/uaccess.h:196:3: note: expanded from macro '__get_user_nocheck' 196 | __get_user_8((x), __gu_ptr, label); \ | ^ arch/riscv/include/asm/uaccess.h:130:2: note: expanded from macro '__get_user_8' 130 | u32 __user *__ptr = (u32 __user *)(ptr); \ | ^ sound/hda/common/hwdep.c:40:6: warning: label followed by a declaration is a C23 extension [-Wc23-extensions] 40 | if (get_user(verb, &arg->verb)) | ^ arch/riscv/include/asm/uaccess.h:274:3: note: expanded from macro 'get_user' 274 | __get_user((x), __p) : \ | ^ arch/riscv/include/asm/uaccess.h:244:2: note: expanded from macro '__get_user' 244 | __get_user_error(__gu_val, __gu_ptr, __gu_err); \ | ^ arch/riscv/include/asm/uaccess.h:207:2: note: expanded from macro '__get_user_error' 207 | __get_user_nocheck(x, ptr, __gu_failed); \ | ^ arch/riscv/include/asm/uaccess.h:196:3: note: expanded from macro '__get_user_nocheck' 196 | __get_user_8((x), __gu_ptr, label); \ | ^ arch/riscv/include/asm/uaccess.h:130:2: note: expanded from macro '__get_user_8' 130 | u32 __user *__ptr = (u32 __user *)(ptr); \ | ^ 3 warnings generated. vim +26 sound/hda/common/hwdep.c 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 17 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 18 /* 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 19 * write/read an out-of-bound verb 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 20 */ 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 21 static int verb_write_ioctl(struct hda_codec *codec, 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 22 struct hda_verb_ioctl __user *arg) 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 23 { 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 24 u32 verb, res; 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 25 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 @26 if (get_user(verb, &arg->verb)) 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 27 return -EFAULT; 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 28 res = snd_hda_codec_read(codec, verb >> 24, 0, 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 29 (verb >> 8) & 0xffff, verb & 0xff); 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 30 if (put_user(res, &arg->res)) 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 31 return -EFAULT; 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 32 return 0; 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 33 } 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 34 :::::: The code at line 26 was first introduced by commit :::::: 2807314d467e7dd929c42050031aabbd28e78f0b [ALSA] hda-intel - Add hwdep interface :::::: TO: Takashi Iwai <tiwai(a)suse.de> :::::: CC: Jaroslav Kysela <perex(a)perex.cz> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0