- Alsa-devel - mailman.alsa-project.org

ALC287 problem
by ollierazdow＠protonmail.com 26 Jun '23

26 Jun '23

I have a problem with the ALC287 codec that might indicate a missing fix in the Kernel. There is digital noise in the output unless I run the command: sudo hda-verb /dev/snd/hwC0D0 0x1d SET_PIN_WIDGET_CONTROL 0x0 I looked through the file /sound/pci/hda/patch_realtek.c and found ALC285_FIXUP_LENOVO_PC_BEEP_IN_NOISE but it does not affect my hardware. The latest Kernel I tried was 6.1.32. I'm not familiar enough with how the file is organized to write a patch myself, but If anyone has advice about how to address it I could try. I wanted to bring alert to this though because it seems like a missing fix. I also posted here with a bit more detail: https://bugzilla.kernel.org/show_bug.cgi?id=217580

1 0

USB-Audio: Add Steinberg UR44C
by GitHub pull_request - opened 25 Jun '23

25 Jun '23

alsa-project/alsa-ucm-conf pull request #330 was opened from cyberchrime: Adds support for the Steinberg UR44C. In fact, it is similar to the Steinberg UR44, but uses USB-C with USB 3.1 and has a different USB devnum (1730 instead of 1700). Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/330 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/330.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

MIC capture stops due to playback
by Arjav Parikh 25 Jun '23

25 Jun '23

Hi I am using alsa api's in my C Program to implement two-way talk i.e capturing data from mic and playing sound on speaker received from Cloud. I am using a Microsemi ZL38050 Audio DSP connected to an Ambarella CV25 SOC via I2S/SPI. Randomly I have observed that If I stop and resume receiving data from Cloud to play it on speaker using snd_pcm_writei() then my capture path stops. I do not hear any sound captured from MIC. Can someone help me to debug this issue because when this issue occurs there are no errors reported from Alsa nor do I see anything in dmesg as well. Thanks & Regards, Arjav Parikh

1 0

[PATCH] ALSA: aloop: Fix &cable->lock deadlock issues
by YE Chengfeng 25 Jun '23

25 Jun '23

The timer loopback_jiffies_timer_function is executed under bottom-half softirq context and require a spinlock, thus other process context code requiring the same lock (i.e., loopback_trigger, loopback_pointer) can deadlock with the timer if it is preempted while holding the lock. Deadlock scenario: loopback_trigger -> spin_lock(&cable->lock); <timer interrupt> -> loopback_jiffies_timer_function -> spin_lock_irqsave(&dpcm->cable->lock, flags); Fix the potential deadlock by using spin_lock_irqsave. Signed-off-by: Chengfeng Ye <cyeaa(a)connect.ust.hk> --- sound/drivers/aloop.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/sound/drivers/aloop.c b/sound/drivers/aloop.c index a38e602b4fc6..8ee93f8581b4 100644 --- a/sound/drivers/aloop.c +++ b/sound/drivers/aloop.c @@ -379,6 +379,7 @@ static int loopback_trigger(struct snd_pcm_substream *substream, int cmd) struct snd_pcm_runtime *runtime = substream->runtime; struct loopback_pcm *dpcm = runtime->private_data; struct loopback_cable *cable = dpcm->cable; + unsigned long flags; int err = 0, stream = 1 << substream->stream; switch (cmd) { @@ -389,39 +390,39 @@ static int loopback_trigger(struct snd_pcm_substream *substream, int cmd) dpcm->last_jiffies = jiffies; dpcm->pcm_rate_shift = 0; dpcm->last_drift = 0; - spin_lock(&cable->lock); + spin_lock_irqsave(&cable->lock, flags); cable->running |= stream; cable->pause &= ~stream; err = cable->ops->start(dpcm); - spin_unlock(&cable->lock); + spin_unlock_irqrestore(&cable->lock, flags); if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) loopback_active_notify(dpcm); break; case SNDRV_PCM_TRIGGER_STOP: - spin_lock(&cable->lock); + spin_lock_irqsave(&cable->lock, flags); cable->running &= ~stream; cable->pause &= ~stream; err = cable->ops->stop(dpcm); - spin_unlock(&cable->lock); + spin_unlock_irqrestore(&cable->lock, flags); if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) loopback_active_notify(dpcm); break; case SNDRV_PCM_TRIGGER_PAUSE_PUSH: case SNDRV_PCM_TRIGGER_SUSPEND: - spin_lock(&cable->lock); + spin_lock_irqsave(&cable->lock, flags); cable->pause |= stream; err = cable->ops->stop(dpcm); - spin_unlock(&cable->lock); + spin_unlock_irqrestore(&cable->lock, flags); if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) loopback_active_notify(dpcm); break; case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: case SNDRV_PCM_TRIGGER_RESUME: - spin_lock(&cable->lock); + spin_lock_irqsave(&cable->lock, flags); dpcm->last_jiffies = jiffies; cable->pause &= ~stream; err = cable->ops->start(dpcm); - spin_unlock(&cable->lock); + spin_unlock_irqrestore(&cable->lock, flags); if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) loopback_active_notify(dpcm); break; @@ -865,12 +866,13 @@ static snd_pcm_uframes_t loopback_pointer(struct snd_pcm_substream *substream) struct snd_pcm_runtime *runtime = substream->runtime; struct loopback_pcm *dpcm = runtime->private_data; snd_pcm_uframes_t pos; + unsigned long flags; - spin_lock(&dpcm->cable->lock); + spin_lock_irqsave(&dpcm->cable->lock, flags); if (dpcm->cable->ops->pos_update) dpcm->cable->ops->pos_update(dpcm->cable); pos = dpcm->buf_pos; - spin_unlock(&dpcm->cable->lock); + spin_unlock_irqrestore(&dpcm->cable->lock, flags); return bytes_to_frames(runtime, pos); } -- 2.17.1

2 1

[PATCH] ALSA: pcm: fix ELD constraints for (E)AC3, DTS(-HD) and MLP formats
by Matthias Reichl 25 Jun '23

25 Jun '23

The SADs of compressed formats contain the channel and sample rate info of the audio data inside the compressed stream, but when building constraints we must use the rates and channels used to transport the compressed streams. eg 48kHz 6ch EAC3 needs to be transmitted as a 2ch 192kHz stream. This patch fixes the constraints for the common AC3 and DTS formats, the constraints for the less common MPEG, DSD etc formats are copied directly from the info in the SADs as before as I don't have the specs and equipment to test those. Signed-off-by: Matthias Reichl <hias(a)horus.com> --- sound/core/pcm_drm_eld.c | 73 ++++++++++++++++++++++++++++++++++++++-- 1 file changed, 70 insertions(+), 3 deletions(-) diff --git a/sound/core/pcm_drm_eld.c b/sound/core/pcm_drm_eld.c index 4b5faae5d16e5..07075071972dd 100644 --- a/sound/core/pcm_drm_eld.c +++ b/sound/core/pcm_drm_eld.c @@ -2,11 +2,25 @@ /* * PCM DRM helpers */ +#include <linux/bitfield.h> #include <linux/export.h> +#include <linux/hdmi.h> #include <drm/drm_edid.h> #include <sound/pcm.h> #include <sound/pcm_drm_eld.h> +#define SAD0_CHANNELS_MASK GENMASK(2, 0) /* max number of channels - 1 */ +#define SAD0_FORMAT_MASK GENMASK(6, 3) /* audio format */ + +#define SAD1_RATE_MASK GENMASK(6, 0) /* bitfield of supported rates */ +#define SAD1_RATE_32000_MASK BIT(0) +#define SAD1_RATE_44100_MASK BIT(1) +#define SAD1_RATE_48000_MASK BIT(2) +#define SAD1_RATE_88200_MASK BIT(3) +#define SAD1_RATE_96000_MASK BIT(4) +#define SAD1_RATE_176400_MASK BIT(5) +#define SAD1_RATE_192000_MASK BIT(6) + static const unsigned int eld_rates[] = { 32000, 44100, @@ -17,9 +31,62 @@ static const unsigned int eld_rates[] = { 192000, }; +static unsigned int map_rate_families(const u8 *sad, + unsigned int mask_32000, + unsigned int mask_44100, + unsigned int mask_48000) +{ + unsigned int rate_mask = 0; + + if (sad[1] & SAD1_RATE_32000_MASK) + rate_mask |= mask_32000; + if (sad[1] & (SAD1_RATE_44100_MASK | SAD1_RATE_88200_MASK | SAD1_RATE_176400_MASK)) + rate_mask |= mask_44100; + if (sad[1] & (SAD1_RATE_48000_MASK | SAD1_RATE_96000_MASK | SAD1_RATE_192000_MASK)) + rate_mask |= mask_48000; + return rate_mask; +} + +static unsigned int sad_rate_mask(const u8 *sad) +{ + switch (FIELD_GET(SAD0_FORMAT_MASK, sad[0])) { + case HDMI_AUDIO_CODING_TYPE_PCM: + return sad[1] & SAD1_RATE_MASK; + case HDMI_AUDIO_CODING_TYPE_AC3: + case HDMI_AUDIO_CODING_TYPE_DTS: + return map_rate_families(sad, + SAD1_RATE_32000_MASK, + SAD1_RATE_44100_MASK, + SAD1_RATE_48000_MASK); + case HDMI_AUDIO_CODING_TYPE_EAC3: + case HDMI_AUDIO_CODING_TYPE_DTS_HD: + case HDMI_AUDIO_CODING_TYPE_MLP: + return map_rate_families(sad, + 0, + SAD1_RATE_176400_MASK, + SAD1_RATE_192000_MASK); + default: + /* TODO adjust for other compressed formats as well */ + return sad[1] & SAD1_RATE_MASK; + } +} + static unsigned int sad_max_channels(const u8 *sad) { - return 1 + (sad[0] & 7); + switch (FIELD_GET(SAD0_FORMAT_MASK, sad[0])) { + case HDMI_AUDIO_CODING_TYPE_PCM: + return 1 + FIELD_GET(SAD0_CHANNELS_MASK, sad[0]); + case HDMI_AUDIO_CODING_TYPE_AC3: + case HDMI_AUDIO_CODING_TYPE_DTS: + case HDMI_AUDIO_CODING_TYPE_EAC3: + return 2; + case HDMI_AUDIO_CODING_TYPE_DTS_HD: + case HDMI_AUDIO_CODING_TYPE_MLP: + return 8; + default: + /* TODO adjust for other compressed formats as well */ + return 1 + FIELD_GET(SAD0_CHANNELS_MASK, sad[0]); + } } static int eld_limit_rates(struct snd_pcm_hw_params *params, @@ -42,7 +109,7 @@ static int eld_limit_rates(struct snd_pcm_hw_params *params, * requested number of channels. */ if (c->min <= max_channels) - rate_mask |= sad[1]; + rate_mask |= sad_rate_mask(sad); } } @@ -70,7 +137,7 @@ static int eld_limit_channels(struct snd_pcm_hw_params *params, rate_mask |= BIT(i); for (i = drm_eld_sad_count(eld); i > 0; i--, sad += 3) - if (rate_mask & sad[1]) + if (rate_mask & sad_rate_mask(sad)) t.max = max(t.max, sad_max_channels(sad)); } -- 2.39.2

3 4

[PATCH v2 RESEND] ASoC: fsl MPC52xx drivers require PPC_BESTCOMM
by Randy Dunlap 25 Jun '23

25 Jun '23

Both SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA select SND_SOC_MPC5200_AC97. The latter symbol depends on PPC_BESTCOMM, so the 2 former symbols should also depend on PPC_BESTCOMM since "select" does not follow any dependency chains. This prevents a kconfig warning and build errors: WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97 Depends on [n]: SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC52xx [=y] && PPC_BESTCOMM [=n] Selected by [m]: - SND_MPC52xx_SOC_PCM030 [=m] && SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC5200_SIMPLE [=y] - SND_MPC52xx_SOC_EFIKA [=m] && SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_EFIKA [=y] ERROR: modpost: "mpc5200_audio_dma_destroy" [sound/soc/fsl/mpc5200_psc_ac97.ko] undefined! ERROR: modpost: "mpc5200_audio_dma_create" [sound/soc/fsl/mpc5200_psc_ac97.ko] undefined! Fixes: 40d9ec14e7e1 ("ASoC: remove BROKEN from Efika and pcm030 fabric drivers") Signed-off-by: Randy Dunlap <rdunlap(a)infradead.org> Cc: Grant Likely <grant.likely(a)secretlab.ca> Cc: Mark Brown <broonie(a)kernel.org> Cc: Liam Girdwood <lgirdwood(a)gmail.com> Cc: Shengjiu Wang <shengjiu.wang(a)gmail.com> Cc: Xiubo Li <Xiubo.Lee(a)gmail.com> Cc: alsa-devel(a)alsa-project.org Cc: linuxppc-dev(a)lists.ozlabs.org Cc: Jaroslav Kysela <perex(a)perex.cz> Cc: Takashi Iwai <tiwai(a)suse.com> --- v2: use correct email address for Mark Brown. sound/soc/fsl/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -- a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -243,7 +243,7 @@ config SND_SOC_MPC5200_AC97 config SND_MPC52xx_SOC_PCM030 tristate "SoC AC97 Audio support for Phytec pcm030 and WM9712" - depends on PPC_MPC5200_SIMPLE + depends on PPC_MPC5200_SIMPLE && PPC_BESTCOMM select SND_SOC_MPC5200_AC97 select SND_SOC_WM9712 help @@ -252,7 +252,7 @@ config SND_MPC52xx_SOC_PCM030 config SND_MPC52xx_SOC_EFIKA tristate "SoC AC97 Audio support for bbplan Efika and STAC9766" - depends on PPC_EFIKA + depends on PPC_EFIKA && PPC_BESTCOMM select SND_SOC_MPC5200_AC97 select SND_SOC_STAC9766 help

2 3

Focusrite Scarlett 2i2 3rd Gen suffers from high output latency with the 1.2.9-1 update
by GitHub issues - edited 25 Jun '23

25 Jun '23

alsa-project/alsa-ucm-conf issue #329 was edited from IsaacLambat: Hello, I have recently upgraded from `alsa-ucm-conf 1.2.8-1` to `1.2.9-1` and this has caused some latency of around 1/2 seconds for outputting audio via the `Focusrite Scarlett 2i2 3rd Gen` with is connected the computer via USB. No latency is introduced when plugging wired headphones directly in to the motherboard so this seems to be isolated to the device. I noticed the change logs indicate better support for this device was added in this version (which is great!) so these changes may have affected the existing settings of the headphones. I have downgraded only `alsa-ucm-conf` to `1.2.8-1` and the output has no latency so I am using this as a workaround. I use PulseAudio with ALSA on Arch Linux. Versions: ``` alsa-card-profiles - 0.3.71 alsa-lib - 1.2.9 alsa-ucm-conf - 1.2.9 alsa-utils - 1.2.9 pulseaudio - 16.1 Arch Linux - 6.3.9-arch1-1 ``` dmesg detects the product as `Scarlett 2i2 USB` Please let me know if any more information is needed (such as logs or config files) and if there is anything I should try. Many thanks :D Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/329 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH v2 00/45] Add support for sam9x7 SoC family
by Varshini Rajendran 24 Jun '23

24 Jun '23

This patch series adds support for the new SoC family - sam9x7. - The device tree, configs and drivers are added - Clock driver for sam9x7 is added - Support for basic peripherals is added - Target board SAM9X75 Curiosity is added Changes in v2: -------------- - Added sam9x7 specific compatibles in DT with fallbacks - Documented all the newly added DT compatible strings - Added device tree for the target board sam9x75 curiosity and documented the same in the DT bindings documentation - Removed the dt nodes that are not supported at the moment - Removed the configs added by previous version that are not supported at the moment - Fixed all the corrections in the commit message - Changed all the instances of copyright year to 2023 - Added sam9x7 flag in PIT64B configuration - Moved macro definitions to header file - Added another divider in mck characteristics in the pmc driver - Fixed the memory leak in the pmc driver - Dropped patches that are no longer needed - Picked up Acked-by and Reviewed-by tags Hari Prasath (1): irqchip/atmel-aic5: Add support for sam9x7 aic Varshini Rajendran (44): dt-bindings: microchip: atmel,at91rm9200-tcb: add sam9x60, sam9x7 compatible dt-bindings: usb: ehci: Add atmel at91sam9g45-ehci compatible dt-bindings: usb: generic-ehci: Document clock-names property dt-bindings: net: cdns,macb: add documentation for sam9x7 ethernet interface ARM: at91: pm: add support for sam9x7 SoC family ARM: at91: pm: add sam9x7 SoC init config ARM: at91: add support in SoC driver for new sam9x7 clk: at91: clk-sam9x60-pll: re-factor to support individual core freq outputs clk: at91: sam9x7: add support for HW PLL freq dividers clk: at91: sama7g5: move mux table macros to header file dt-bindings: clk: at91: add bindings for SAM9X7's clock controller dt-bindings: reset: atmel,at91sam9260-reset: add sam9x7 binding dt-bindings: atmel-sysreg: add bindings for sam9x7 dt-bindings: crypto: add bindings for sam9x7 in Atmel AES dt-bindings: crypto: add bindings for sam9x7 in Atmel SHA dt-bindings: crypto: add bindings for sam9x7 in Atmel TDES dt-bindings: dmaengine: at_xdmac: add compatible with microchip,sam9x7 dt-bindings: i2c: at91: Add SAM9X7 compatible string dt-bindings: mfd: at91: Add SAM9X7 compatible string dt-bindings: atmel-gpbr: add microchip,sam9x7-gpbr dt-bindings: atmel-matrix: add microchip,sam9x7-matrix dt-bindings: atmel-smc: add microchip,sam9x7-smc dt-bindings: atmel-ssc: add microchip,sam9x7-ssc dt-bindings: sdhci-of-at91: add microchip,sam9x7-sdhci dt-bindings: atmel-nand: add microchip,sam9x7-pmecc dt-bindings: pinctrl: at91: add bindings for SAM9X7 dt-bindings: rng: atmel,at91-trng: document sam9x7 TRNG dt-bindings: rtc: at91rm9200: add sam9x7 compatible dt-bindings: rtt: at91rm9260: add sam9x7 compatible dt-bindings: serial: atmel,at91-usart: add compatible for sam9x7 dt-bindings: atmel-classd: add sam9x7 compatible spi: dt-bindings: atmel,at91rm9200-spi: add sam9x7 compatible dt-bindings: usb: atmel: Update DT bindings documentation for sam9x7 dt-bindings: watchdog: sama5d4-wdt: add compatible for sam9x7-wdt dt-bindings: irqchip/atmel-aic5: Add support for sam9x7 aic clk: at91: sam9x7: add sam9x7 pmc driver power: reset: at91-poweroff: lookup for proper pmc dt node for sam9x7 power: reset: at91-reset: add reset support for sam9x7 SoC power: reset: at91-reset: add sdhwc support for sam9x7 SoC ARM: at91: Kconfig: add config flag for SAM9X7 SoC ARM: configs: at91: enable config flags for sam9x7 SoC family ARM: dts: at91: sam9x7: add device tree for SoC dt-bindings: arm: add sam9x75 curiosity board ARM: dts: at91: sam9x75_curiosity: add device tree for sam9x75 curiosity board .../devicetree/bindings/arm/atmel-at91.yaml | 6 + .../devicetree/bindings/arm/atmel-sysregs.txt | 7 +- .../devicetree/bindings/clock/at91-clock.txt | 7 +- .../crypto/atmel,at91sam9g46-aes.yaml | 5 +- .../crypto/atmel,at91sam9g46-sha.yaml | 5 +- .../crypto/atmel,at91sam9g46-tdes.yaml | 5 +- .../devicetree/bindings/dma/atmel-xdma.txt | 4 +- .../bindings/i2c/atmel,at91sam-i2c.yaml | 3 + .../interrupt-controller/atmel,aic.txt | 2 +- .../devicetree/bindings/mfd/atmel-flexcom.txt | 2 +- .../devicetree/bindings/mfd/atmel-gpbr.txt | 1 + .../devicetree/bindings/mfd/atmel-matrix.txt | 1 + .../devicetree/bindings/mfd/atmel-smc.txt | 1 + .../devicetree/bindings/misc/atmel-ssc.txt | 1 + .../devicetree/bindings/mmc/sdhci-atmel.txt | 4 +- .../devicetree/bindings/mtd/atmel-nand.txt | 1 + .../devicetree/bindings/net/cdns,macb.yaml | 1 + .../bindings/pinctrl/atmel,at91-pinctrl.txt | 3 +- .../reset/atmel,at91sam9260-reset.yaml | 1 + .../bindings/rng/atmel,at91-trng.yaml | 1 + .../bindings/rtc/atmel,at91rm9200-rtc.yaml | 1 + .../bindings/rtc/atmel,at91sam9260-rtt.yaml | 1 + .../bindings/serial/atmel,at91-usart.yaml | 3 + .../soc/microchip/atmel,at91rm9200-tcb.yaml | 2 + .../bindings/sound/atmel,sama5d2-classd.yaml | 5 +- .../bindings/spi/atmel,at91rm9200-spi.yaml | 1 + .../devicetree/bindings/usb/atmel-usb.txt | 9 +- .../devicetree/bindings/usb/generic-ehci.yaml | 5 + .../bindings/watchdog/atmel,sama5d4-wdt.yaml | 1 + arch/arm/boot/dts/Makefile | 2 + arch/arm/boot/dts/at91-sam9x75_curiosity.dts | 336 +++++ arch/arm/boot/dts/sam9x7.dtsi | 1237 +++++++++++++++++ arch/arm/configs/at91_dt_defconfig | 1 + arch/arm/mach-at91/Kconfig | 23 +- arch/arm/mach-at91/Makefile | 1 + arch/arm/mach-at91/generic.h | 2 + arch/arm/mach-at91/pm.c | 35 + arch/arm/mach-at91/sam9x7.c | 34 + drivers/clk/at91/Makefile | 1 + drivers/clk/at91/clk-sam9x60-pll.c | 50 +- drivers/clk/at91/pmc.h | 18 + drivers/clk/at91/sam9x60.c | 7 + drivers/clk/at91/sam9x7.c | 942 +++++++++++++ drivers/clk/at91/sama7g5.c | 42 +- drivers/irqchip/irq-atmel-aic5.c | 10 + drivers/power/reset/Kconfig | 4 +- drivers/power/reset/at91-sama5d2_shdwc.c | 1 + drivers/soc/atmel/soc.c | 23 + drivers/soc/atmel/soc.h | 9 + 49 files changed, 2806 insertions(+), 61 deletions(-) create mode 100644 arch/arm/boot/dts/at91-sam9x75_curiosity.dts create mode 100644 arch/arm/boot/dts/sam9x7.dtsi create mode 100644 arch/arm/mach-at91/sam9x7.c create mode 100644 drivers/clk/at91/sam9x7.c -- 2.25.1

4 82

[PATCH] ASoC: tas2781: Fix error code in tas2781_load_calibration()
by Dan Carpenter 24 Jun '23

24 Jun '23

Return -EINVAL instead of success on this error path. Fixes: 915f5eadebd2 ("ASoC: tas2781: firmware lib") Signed-off-by: Dan Carpenter <dan.carpenter(a)linaro.org> --- sound/soc/codecs/tas2781-fmwlib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/tas2781-fmwlib.c b/sound/soc/codecs/tas2781-fmwlib.c index cbf0aef2c001..eb55abae0d7b 100644 --- a/sound/soc/codecs/tas2781-fmwlib.c +++ b/sound/soc/codecs/tas2781-fmwlib.c @@ -1924,6 +1924,7 @@ int tas2781_load_calibration(void *context, char *file_name, if (!fw_entry->size) { dev_err(tas_priv->dev, "%s: file read error: size = %lu\n", __func__, (unsigned long)fw_entry->size); + ret = -EINVAL; goto out; } fmw.size = fw_entry->size; -- 2.39.2

2 1

Focusrite Scarlett 2i2 3rd Gen suffers from high output latency with the 1.2.9-1 update
by GitHub issues - edited 23 Jun '23

23 Jun '23

alsa-project/alsa-ucm-conf issue #329 was edited from IsaacLambat: Hello, I have recently upgraded from `alsa-ucm-conf 1.2.8-1` to `1.2.9-1` and this has caused some latency of around 1 second for outputting audio via the `Focusrite Scarlett 2i2 3rd Gen` with is connected the computer via USB. No latency is introduced when plugging wired headphones directly in to the motherboard so this seems to be isolated to the device. I noticed the change logs indicate better support for this device was added in this version (which is great!) so these changes may have affected the existing settings of the headphones. I have downgraded only `alsa-ucm-conf` to `1.2.8-1` and the output has no latency so I am using this as a workaround. I use PulseAudio with ALSA on Arch Linux. Versions: ``` alsa-card-profiles - 0.3.71 alsa-lib - 1.2.9 alsa-ucm-conf - 1.2.9 alsa-utils - 1.2.9 pulseaudio - 16.1 Arch Linux - 6.3.9-arch1-1 ``` dmesg detects the product as `Scarlett 2i2 USB` Please let me know if any more information is needed (such as logs or config files) and if there is anything I should try. Many thanks :D Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/329 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0