- Alsa-devel - mailman.alsa-project.org

ucm2: HDA: HiFi-analog/mic: Refactor the analog mic discovery and pre…
by GitHub pull_request - opened 18 Mar '25

18 Mar '25

alsa-project/alsa-ucm-conf pull request #526 was opened from ujfalusi: …sentation The current mic device creation works on certain machines and fails on others. There are several places of conflicts and setups which can only just fail, but this is mostly not an issue if the user never uses the mic, only the speaker/headset - which, to be honest is what most of us do ;) As an example: The mic selection in most codecs are via enum and it is assumed to be named 'Input Source', which is not always the case as some device uses 'Capture Source' for the control's name. There is also different sets of mics that one can select from: Exhibit A numid=6,iface=MIXER,name='Input Source' ; type=ENUMERATED,access=rw------,values=1,items=2 ; Item #0 'Headset Mic' ; Item #1 'Headphone Mic' : values=1 Exhibit B numid=6,iface=MIXER,name='Capture Source' ; type=ENUMERATED,access=rw------,values=1,items=2 ; Item #0 'Internal Mic' ; Item #1 'Headset Mic' : values=0 Exhibit C numid=6,iface=MIXER,name='Capture Source' ; type=ENUMERATED,access=rw------,values=1,items=3 ; Item #0 'Internal Mic' ; Item #1 'Headset Mic' ; Item #2 'Headphone Mic' : values=0 Exhibit D (this pushes the limits... The patch will ignore item 1) numid=6,iface=MIXER,name='Capture Source' ; type=ENUMERATED,access=rw------,values=1,items=3 ; Item #0 'Internal Mic' ; Item #1 'Internal Mic 1' ; Item #2 'Mic' : values=2 Other issue is that we have this 'Headphone Mic', which turned out to be a 'Stereo Microphone in Headphone Jack', so if it is selected then the Headphone cannot work, they conflict, they use the same rings for different direction and purpose. This patch aims to make the mic discovery a bit more deterministic and pragmatic. But even if the UCM creates the use case profiles correctly, it is still up to UIs (KDE/GNOME/etc) to misunderstand how UCM presents the profiles, what they mean and most of all what 'Mic1', `Mic2', etc is. KDE presents the profiles as they are and user can selct between them to pick the right combination of output and input. GNOME goes further with simplification (and fails with it) and presents 'random' Configuration profiles for Output and Input, plus a device selection and they do work in an interesting way. GNOME also have popup for specifying the type of the plugged accessory, which does not worl at all with UCM profiles. But, this patch is meant for a small step to have clear rules based mic presentation for HDA. The expectation is that what have worked will work as it used to and what did not worked should be detected and presented correctly. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/526 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/526.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH 1/3] ASoC: amd: acp: Fix snd_soc_acpi_mach id's duplicate symbol error
by Venkata Prasad Potturu 17 Mar '25

17 Mar '25

Move snd_soc_acpi_mach id's of all acp platforms form header file to amd-acpi-mach.c file to avoid below errors. ld.lld: error: duplicate symbol: amp_rt1019 ld.lld: error: duplicate symbol: amp_max ld.lld: error: duplicate symbol: snd_soc_acpi_amd_acp63_acp_machines ld.lld: error: duplicate symbol: snd_soc_acpi_amd_acp70_acp_machines ld.lld: error: duplicate symbol: snd_soc_acpi_amd_rmb_acp_machines ld.lld: error: duplicate symbol: snd_soc_acpi_amd_acp_machines Fixes: 6e60db74b69c ("ASoC: amd: acp: Refactor acp machine select") Reported-by: kernel test robot <lkp(a)intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202503160801.yExt0K2E-lkp@intel.com/ Signed-off-by: Venkata Prasad Potturu <venkataprasad.potturu(a)amd.com> --- sound/soc/amd/acp/Kconfig | 8 +++ sound/soc/amd/acp/Makefile | 2 + sound/soc/amd/acp/acp-pci.c | 8 +-- sound/soc/amd/acp/amd-acpi-mach.c | 93 +++++++++++++++++++++++++++++++ sound/soc/amd/acp/amd.h | 79 ++------------------------ 5 files changed, 111 insertions(+), 79 deletions(-) create mode 100644 sound/soc/amd/acp/amd-acpi-mach.c diff --git a/sound/soc/amd/acp/Kconfig b/sound/soc/amd/acp/Kconfig index 157c124570c8..b9432052c638 100644 --- a/sound/soc/amd/acp/Kconfig +++ b/sound/soc/amd/acp/Kconfig @@ -28,6 +28,9 @@ config SND_SOC_AMD_ACP_LEGACY_COMMON config SND_SOC_AMD_ACP_I2S tristate +config SND_SOC_AMD_ACPI_MACH + tristate + config SND_SOC_AMD_ACP_PCM tristate select SND_SOC_ACPI if ACPI @@ -37,6 +40,7 @@ config SND_SOC_AMD_ACP_PCI depends on X86 && PCI depends on ACPI select SND_SOC_AMD_ACP_LEGACY_COMMON + select SND_SOC_AMD_ACPI_MACH help This options enables generic PCI driver for ACP device. @@ -47,6 +51,7 @@ config SND_AMD_ASOC_RENOIR select SND_SOC_AMD_ACP_I2S select SND_SOC_AMD_ACP_PDM select SND_SOC_AMD_ACP_LEGACY_COMMON + select SND_SOC_AMD_ACPI_MACH depends on X86 && PCI help This option enables Renoir I2S support on AMD platform. @@ -58,6 +63,7 @@ config SND_AMD_ASOC_REMBRANDT select SND_SOC_AMD_ACP_I2S select SND_SOC_AMD_ACP_PDM select SND_SOC_AMD_ACP_LEGACY_COMMON + select SND_SOC_AMD_ACPI_MACH depends on AMD_NODE depends on X86 && PCI help @@ -74,6 +80,7 @@ config SND_AMD_ASOC_ACP63 select SND_SOC_AMD_ACP_I2S select SND_SOC_AMD_ACP_PDM select SND_SOC_AMD_ACP_LEGACY_COMMON + select SND_SOC_AMD_ACPI_MACH help This option enables Acp6.3 I2S support on AMD platform. Say Y if you want to enable AUDIO on ACP6.3 @@ -88,6 +95,7 @@ config SND_AMD_ASOC_ACP70 select SND_SOC_AMD_ACP_I2S select SND_SOC_AMD_ACP_PDM select SND_SOC_AMD_ACP_LEGACY_COMMON + select SND_SOC_AMD_ACPI_MACH help This option enables Acp7.0 PDM support on AMD platform. Say Y if you want to enable AUDIO on ACP7.0 diff --git a/sound/soc/amd/acp/Makefile b/sound/soc/amd/acp/Makefile index 7c75892e678b..08220b9a3802 100644 --- a/sound/soc/amd/acp/Makefile +++ b/sound/soc/amd/acp/Makefile @@ -11,6 +11,7 @@ snd-acp-pdm-y := acp-pdm.o snd-acp-legacy-common-y := acp-legacy-common.o snd-acp-pci-y := acp-pci.o snd-amd-sdw-acpi-y := amd-sdw-acpi.o +snd-amd-acpi-mach-y := amd-acpi-mach.o #platform specific driver snd-acp-renoir-y := acp-renoir.o @@ -32,6 +33,7 @@ obj-$(CONFIG_SND_SOC_AMD_ACP_I2S) += snd-acp-i2s.o obj-$(CONFIG_SND_SOC_AMD_ACP_PDM) += snd-acp-pdm.o obj-$(CONFIG_SND_SOC_AMD_ACP_LEGACY_COMMON) += snd-acp-legacy-common.o obj-$(CONFIG_SND_SOC_AMD_ACP_PCI) += snd-acp-pci.o +obj-$(CONFIG_SND_SOC_AMD_ACPI_MACH) += snd-amd-acpi-mach.o obj-$(CONFIG_SND_AMD_ASOC_RENOIR) += snd-acp-renoir.o obj-$(CONFIG_SND_AMD_ASOC_REMBRANDT) += snd-acp-rembrandt.o diff --git a/sound/soc/amd/acp/acp-pci.c b/sound/soc/amd/acp/acp-pci.c index 9322379cb36f..e15904aabc06 100644 --- a/sound/soc/amd/acp/acp-pci.c +++ b/sound/soc/amd/acp/acp-pci.c @@ -137,26 +137,26 @@ static int acp_pci_probe(struct pci_dev *pci, const struct pci_device_id *pci_id chip->name = "acp_asoc_renoir"; chip->rsrc = &rn_rsrc; chip->acp_hw_ops_init = acp31_hw_ops_init; - chip->machines = snd_soc_acpi_amd_acp_machines; + chip->machines = &snd_soc_acpi_amd_acp_machines; break; case 0x6f: chip->name = "acp_asoc_rembrandt"; chip->rsrc = &rmb_rsrc; chip->acp_hw_ops_init = acp6x_hw_ops_init; - chip->machines = snd_soc_acpi_amd_rmb_acp_machines; + chip->machines = &snd_soc_acpi_amd_rmb_acp_machines; break; case 0x63: chip->name = "acp_asoc_acp63"; chip->rsrc = &acp63_rsrc; chip->acp_hw_ops_init = acp63_hw_ops_init; - chip->machines = snd_soc_acpi_amd_acp63_acp_machines; + chip->machines = &snd_soc_acpi_amd_acp63_acp_machines; break; case 0x70: case 0x71: chip->name = "acp_asoc_acp70"; chip->rsrc = &acp70_rsrc; chip->acp_hw_ops_init = acp70_hw_ops_init; - chip->machines = snd_soc_acpi_amd_acp70_acp_machines; + chip->machines = &snd_soc_acpi_amd_acp70_acp_machines; break; default: dev_err(dev, "Unsupported device revision:0x%x\n", pci->revision); diff --git a/sound/soc/amd/acp/amd-acpi-mach.c b/sound/soc/amd/acp/amd-acpi-mach.c new file mode 100644 index 000000000000..d95047d2ee94 --- /dev/null +++ b/sound/soc/amd/acp/amd-acpi-mach.c @@ -0,0 +1,93 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * amd-acpi-match.c - tables and support for ACP platforms + * ACPI enumeration. + * + * Copyright 2025 Advanced Micro Devices, Inc. + */ + +#include <sound/soc-acpi.h> + +struct snd_soc_acpi_codecs amp_rt1019 = { + .num_codecs = 1, + .codecs = {"10EC1019"} +}; + +struct snd_soc_acpi_codecs amp_max = { + .num_codecs = 1, + .codecs = {"MX98360A"} +}; + +struct snd_soc_acpi_mach snd_soc_acpi_amd_acp_machines[] = { + { + .id = "10EC5682", + .drv_name = "acp3xalc56821019", + .machine_quirk = snd_soc_acpi_codec_list, + .quirk_data = &amp_rt1019, + }, + { + .id = "RTL5682", + .drv_name = "acp3xalc5682sm98360", + .machine_quirk = snd_soc_acpi_codec_list, + .quirk_data = &amp_max, + }, + { + .id = "RTL5682", + .drv_name = "acp3xalc5682s1019", + .machine_quirk = snd_soc_acpi_codec_list, + .quirk_data = &amp_rt1019, + }, + { + .id = "AMDI1019", + .drv_name = "renoir-acp", + }, + { + .id = "ESSX8336", + .drv_name = "acp3x-es83xx", + }, + {}, +}; +EXPORT_SYMBOL_NS_GPL(snd_soc_acpi_amd_acp_machines, "SND_SOC_ACP_COMMON"); + +struct snd_soc_acpi_mach snd_soc_acpi_amd_rmb_acp_machines[] = { + { + .id = "10508825", + .drv_name = "rmb-nau8825-max", + .machine_quirk = snd_soc_acpi_codec_list, + .quirk_data = &amp_max, + }, + { + .id = "AMDI0007", + .drv_name = "rembrandt-acp", + }, + { + .id = "RTL5682", + .drv_name = "rmb-rt5682s-rt1019", + .machine_quirk = snd_soc_acpi_codec_list, + .quirk_data = &amp_rt1019, + }, + {}, +}; +EXPORT_SYMBOL_NS_GPL(snd_soc_acpi_amd_rmb_acp_machines, "SND_SOC_ACP_COMMON"); + +struct snd_soc_acpi_mach snd_soc_acpi_amd_acp63_acp_machines[] = { + { + .id = "AMDI0052", + .drv_name = "acp63-acp", + }, + {}, +}; +EXPORT_SYMBOL_NS_GPL(snd_soc_acpi_amd_acp63_acp_machines, "SND_SOC_ACP_COMMON"); + +struct snd_soc_acpi_mach snd_soc_acpi_amd_acp70_acp_machines[] = { + { + .id = "AMDI0029", + .drv_name = "acp70-acp", + }, + {}, +}; +EXPORT_SYMBOL_NS_GPL(snd_soc_acpi_amd_acp70_acp_machines, "SND_SOC_ACP_COMMON"); + +MODULE_DESCRIPTION("AMD ACP tables and support for ACPI enumeration"); +MODULE_LICENSE("GPL"); +MODULE_AUTHOR("Venkataprasad.potturu(a)amd.com"); diff --git a/sound/soc/amd/acp/amd.h b/sound/soc/amd/acp/amd.h index 796f8efd395c..928aa60ab386 100644 --- a/sound/soc/amd/acp/amd.h +++ b/sound/soc/amd/acp/amd.h @@ -277,81 +277,10 @@ struct acp_resource acp70_rsrc = { .sram_pte_offset = 0x03800000, }; -struct snd_soc_acpi_codecs amp_rt1019 = { - .num_codecs = 1, - .codecs = {"10EC1019"} -}; - -struct snd_soc_acpi_codecs amp_max = { - .num_codecs = 1, - .codecs = {"MX98360A"} -}; - -struct snd_soc_acpi_mach snd_soc_acpi_amd_acp_machines[] = { - { - .id = "10EC5682", - .drv_name = "acp3xalc56821019", - .machine_quirk = snd_soc_acpi_codec_list, - .quirk_data = &amp_rt1019, - }, - { - .id = "RTL5682", - .drv_name = "acp3xalc5682sm98360", - .machine_quirk = snd_soc_acpi_codec_list, - .quirk_data = &amp_max, - }, - { - .id = "RTL5682", - .drv_name = "acp3xalc5682s1019", - .machine_quirk = snd_soc_acpi_codec_list, - .quirk_data = &amp_rt1019, - }, - { - .id = "AMDI1019", - .drv_name = "renoir-acp", - }, - { - .id = "ESSX8336", - .drv_name = "acp3x-es83xx", - }, - {}, -}; - -struct snd_soc_acpi_mach snd_soc_acpi_amd_rmb_acp_machines[] = { - { - .id = "10508825", - .drv_name = "rmb-nau8825-max", - .machine_quirk = snd_soc_acpi_codec_list, - .quirk_data = &amp_max, - }, - { - .id = "AMDI0007", - .drv_name = "rembrandt-acp", - }, - { - .id = "RTL5682", - .drv_name = "rmb-rt5682s-rt1019", - .machine_quirk = snd_soc_acpi_codec_list, - .quirk_data = &amp_rt1019, - }, - {}, -}; - -struct snd_soc_acpi_mach snd_soc_acpi_amd_acp63_acp_machines[] = { - { - .id = "AMDI0052", - .drv_name = "acp63-acp", - }, - {}, -}; - -struct snd_soc_acpi_mach snd_soc_acpi_amd_acp70_acp_machines[] = { - { - .id = "AMDI0029", - .drv_name = "acp70-acp", - }, - {}, -}; +extern struct snd_soc_acpi_mach snd_soc_acpi_amd_acp_machines; +extern struct snd_soc_acpi_mach snd_soc_acpi_amd_rmb_acp_machines; +extern struct snd_soc_acpi_mach snd_soc_acpi_amd_acp63_acp_machines; +extern struct snd_soc_acpi_mach snd_soc_acpi_amd_acp70_acp_machines; extern const struct snd_soc_dai_ops asoc_acp_cpu_dai_ops; extern const struct snd_soc_dai_ops acp_dmic_dai_ops; -- 2.39.2

2 3

[PATCH v2 00/14] Implement acp_common_hw_ops support for all acp platforms
by Venkata Prasad Potturu 17 Mar '25

17 Mar '25

This patch series is to implement acp_common_hw_ops support and refactor interrupt handler registration and interrupt handling. Venkata Prasad Potturu (14): ASoC: amd: acp: Remove redundant acp70 chip->name ASoC: amd: acp: Implement acp_common_hw_ops support for acp platforms ASoC: amd: acp: Refactor dmic-codec platform device creation ASoC: amd: acp: Refactor acp platform device creation ASoC: amd: acp: Refactor acp machine select ASoC: amd: acp: Add new interrupt handle callbacks in acp_common_hw_ops ASoC: amd: acp: Remove redundant acp_dev_data structure ASoC: amd: acp: Move spin_lock and list initialization to acp-pci driver ASoC: amd: acp: Remove white line ASoC: amd: acp: Refactor acp70 platform resource structure ASoC: amd: acp: Refactor acp63 platform resource structure ASoC: amd: acp: Refactor rembrant platform resource structure ASoC: amd: acp: Refactor renoir platform resource structure ASoC: amd: acp: Fix for enabling DMIC on acp platforms via _DSD entry sound/soc/amd/acp/acp-i2s.c | 185 +++++++++--------- sound/soc/amd/acp/acp-legacy-common.c | 254 ++++++++++++++++++------ sound/soc/amd/acp/acp-pci.c | 210 ++++++++++++-------- sound/soc/amd/acp/acp-pdm.c | 53 +++-- sound/soc/amd/acp/acp-platform.c | 145 ++++---------- sound/soc/amd/acp/acp-rembrandt.c | 111 +++-------- sound/soc/amd/acp/acp-renoir.c | 110 ++--------- sound/soc/amd/acp/acp63.c | 94 +++------ sound/soc/amd/acp/acp70.c | 84 +++----- sound/soc/amd/acp/amd.h | 270 +++++++++++++++++++++----- sound/soc/amd/acp/chip_offset_byte.h | 12 +- 11 files changed, 792 insertions(+), 736 deletions(-) -- 2.39.2

4 17

sof-soundwire: rt1318: add playback control switch
by GitHub pull_request - opened 17 Mar '25

17 Mar '25

alsa-project/alsa-ucm-conf pull request #525 was opened from shumingfan: rt1318: add playback control switch Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/525 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/525.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

iecset.1: Some remarks and a patch with editorial changes for this man page
by Bjarni Ingi Gislason 15 Mar '25

15 Mar '25

Package: alsa-utils Version: 1.2.13-1 Severity: minor Tags: patch * What led up to the situation? Checking for defects with a new version test-[g|n]roff -mandoc -t -K utf8 -rF0 -rHY=0 -rCHECKSTYLE=10 -ww -z < "man page" [Use "groff -e ' $' -e '\\~$' <file>" to find obvious trailing spaces.] ["test-groff" is a script in the repository for "groff"; is not shipped] (local copy and "troff" slightly changed by me). [The fate of "test-nroff" was decided in groff bug #55941.] * What was the outcome of this action? an.tmac:<stdin>:1: style: .TH missing fourth argument; consider package/project name and version (e.g., "groff 1.23.0") an.tmac:<stdin>:24: misuse, warning: .BI is for at least 2 arguments, got 1 Use macro '.B' for one argument or split argument. an.tmac:<stdin>:28: misuse, warning: .BI is for at least 2 arguments, got 1 Use macro '.B' for one argument or split argument. an.tmac:<stdin>:33: misuse, warning: .BI is for at least 2 arguments, got 1 Use macro '.B' for one argument or split argument. * What outcome did you expect instead? No output (no warnings). -.- General remarks and further material, if a diff-file exist, are in the attachments. -- System Information: Debian Release: trixie/sid APT prefers testing APT policy: (500, 'testing') Architecture: amd64 (x86_64) Kernel: Linux 6.12.17-amd64 (SMP w/2 CPU threads; PREEMPT) Locale: LANG=is_IS.iso88591, LC_CTYPE=is_IS.iso88591 (charmap=ISO-8859-1), LANGUAGE not set Shell: /bin/sh linked to /usr/bin/dash Init: sysvinit (via /sbin/init) Versions of packages alsa-utils depends on: ii kmod 34-3 ii libasound2t64 1.2.13-1+b1 ii libatopology2t64 1.2.13-1+b1 ii libc6 2.41-4 ii libfftw3-single3 3.3.10-2+b1 ii libncursesw6 6.5+20250216-2 ii libsamplerate0 0.2.2-4+b2 ii libtinfo6 6.5+20250216-2 alsa-utils recommends no packages. Versions of packages alsa-utils suggests: pn dialog <none> -- no debconf information

1 0

DRAFT [for alsa-lib-1.2.14]: USB-Audio: GoXLR: enable detection of beta firmware (25 channels)
by GitHub pull_request - opened 15 Mar '25

15 Mar '25

alsa-project/alsa-ucm-conf pull request #524 was opened from perexg: 'Syntax 8' is required (alsa-lib 1.2.14+) Fixes: 17f9b4f ("USB-Audio: GoXLR - fix the channel detection for mini, cleanups") Link: https://github.com/alsa-project/alsa-ucm-conf/issues/444 Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/524 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/524.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

GoXLR: Add 'Broadcast Stream Mix 2' to Capture if channels are available
by GitHub pull_request - opened 15 Mar '25

15 Mar '25

alsa-project/alsa-ucm-conf pull request #523 was opened from FrostyCoolSlug: Fixes: #444 Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/523 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/523.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

pyalsa.alsamixer.Element.get_volume_dB returns error status instead of actual value
by GitHub issues - opened 15 Mar '25

15 Mar '25

alsa-project/alsa-python issue #16 was opened from tespent: I am writing a status collector for my PC, and I noticed that `pyalsa.alsamixer.Element.get_volume_dB` always returns 0 in my test, which lead to invalid result for the collected status. After digging into code I notice that the following code returns `res` instead of `val` as the result: https://github.com/alsa-project/alsa-python/blob/f8f9260282eb9c97f53e4689e0… I am able to workaround this issue by using `elem.ask_volume_dB(elem.get_volume())` but this looks silly. Btw, I'm willing to contribute and subscribed to alsa-devel mailing list but I didn't figure out exactly how. Can someone tell me? Issue URL : https://github.com/alsa-project/alsa-python/issues/16 Repository URL: https://github.com/alsa-project/alsa-python

1 0

ucm2: Add support for Lenovo Yoga 7x and T14s
by GitHub pull_request - opened 14 Mar '25

14 Mar '25

alsa-project/alsa-ucm-conf pull request #522 was opened from Srinivas-Kandagatla: This patch series adds support for Lenovo T14s and Yoga Slim 7x based on Qualcomm x1e80100 SoC. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/522 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/522.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

USB-Audio: GoXLR - fix the channel detection for mini, cleanups
by GitHub pull_request - opened 14 Mar '25

14 Mar '25

alsa-project/alsa-ucm-conf pull request #521 was opened from perexg: Note that detection for 25 channels requires commit [1] (alsa-lib 1.2.14+). [1] https://github.com/alsa-project/alsa-lib/commit/7fbd47ce797939862025ef42486… BugLink: https://github.com/alsa-project/alsa-ucm-conf/issues/444 Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/521 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/521.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0