- Alsa-devel - mailman.alsa-project.org

SNDRV_PCM_IOCTL_READI_FRAMES returns EIO
by Muni Sekhar 11 Jun '21

11 Jun '21

Hi all, I am using a USB sound card(snd-usb-audio), and it fails while doing the audio recording "arecord: pcm_read:2032: read error: Input/output error". I noticed recording(arecord) audio data on a USB sound card fails at SNDRV_PCM_IOCTL_READI_FRAMES is giving EIO. Can someone please clarify when the kernel returns EIO for Ioctl SNDRV_PCM_IOCTL_READI_FRAMES? and is there a workaround for this? Output of the alsamixer is attached. -- Thanks, Sekhar

2 5

[PATCH 0/3] ALSA: bebob: remove workarounds for suppressed quirks
by Takashi Sakamoto 11 Jun '21

11 Jun '21

Hi, As a result to apply the commit 1bd1b3be8655 ("ALSA: bebob: perform sequence replay for media clock recovery"), some quirks seem to be suppressed. This patchset removes workarounds for the suppressed quirks and includes code cleanup. Takashi Sakamoto (3): ALSA: bebob: dismiss sleep after breaking connections ALSA: bebob: delete workaround for protocol version 3 ALSA: bebob: code refactoring for model-dependent quirks sound/firewire/bebob/bebob.c | 41 ++++++++++++++++++++--------- sound/firewire/bebob/bebob.h | 10 ++++--- sound/firewire/bebob/bebob_stream.c | 32 ++++++---------------- 3 files changed, 42 insertions(+), 41 deletions(-) -- 2.27.0

2 4

Add support for automatic attributes in Topology2.0
by GitHub pull_request - opened 11 Jun '21

11 Jun '21

alsa-project/alsa-utils pull request #97 was opened from ranj063: Add support for automatic attributes in Topology2.0 and also add support for processing objects that are simply used to update the parent object's private data. Request URL : https://github.com/alsa-project/alsa-utils/pull/97 Patch URL : https://github.com/alsa-project/alsa-utils/pull/97.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

ALSA lib pcm_dmix.c:1063:(snd_pcm_dmix_open) unable to create IPC semaphore
by GitHub issues - edited 11 Jun '21

11 Jun '21

alsa-project/alsa-lib issue #153 was edited from Cean1024: alsa info: alsa-config-1.0 alsa-lib-1.1.5 alsa-plugins-1.1.5 alsa-utils-1.1.5 asound.conf: ``` pcm.dmixer { type dmix ipc_key 1024 slave { pcm "hw:0,0" period_time 0 period_size 1024 buffer_size 4096 rate 48000 format "S32_LE" channels 2 } bindings { 0 0 1 1 } } ``` test cmd: ``` arecord -f dat | aplay -f dat -D plug:dmixer ``` Issue URL : https://github.com/alsa-project/alsa-lib/issues/153 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

ALSA lib pcm_dmix.c:1063:(snd_pcm_dmix_open) unable to create IPC semaphore
by GitHub issues - edited 11 Jun '21

11 Jun '21

alsa-project/alsa-lib issue #153 was edited from Cean1024: alsa info: alsa-config-1.0 alsa-lib-1.1.5 alsa-plugins-1.1.5 alsa-utils-1.1.5 asound.conf: pcm.dmixer { type dmix ipc_key 1024 slave { pcm "hw:0,0" period_time 0 period_size 1024 buffer_size 4096 rate 48000 format "S32_LE" channels 2 } bindings { 0 0 1 1 } } test cmd: arecord -f dat | aplay -f dat -D plug:dmixer Issue URL : https://github.com/alsa-project/alsa-lib/issues/153 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH v2 0/3] ALSA: pcm:firewire: allow to operate for period elapse event in process context
by Takashi Sakamoto 11 Jun '21

11 Jun '21

Hi, This patchset is revised version of my previous one: * https://lore.kernel.org/alsa-devel/20210609012244.24296-1-o-takashi@sakamoc… All of drivers in ALSA firewire stack have two chances to process isochronous packets of any isochronous context; in software IRQ context for 1394 OHCI, and in process context of ALSA PCM application. In the process context, callbacks of .pointer and .ack are utilized. The callbacks are done by ALSA PCM core under acquiring lock of PCM substream, In design of ALSA PCM core, call of snd_pcm_period_elapsed() is used for drivers to awaken user processes from waiting for available frames. The function voluntarily acquires lock of PCM substream, therefore it is not called in the process context since it causes dead lock. As a workaround to avoid the dead lock, all of drivers in ALSA firewire stack use workqueue to delegate the call. This patchset is my attempt for the issue. A variant of 'snd_pcm_period_elapsed()' without lock acquisition is going to be added, named 'snd_pcm_period_elapsed_under_stream_lock()'. The call is available in callbacks of .pointer and .ack of snd_pcm_ops structure. Changes from v1: * fix context section of kernel API documentation Takashi Sakamoto (3): ALSA: pcm: add snd_pcm_period_elapsed() variant without acquiring lock of PCM substream ALSA: firewire-lib: operate for period elapse event in process context ALSA: firewire-lib: obsolete workqueue for period update include/sound/pcm.h | 1 + sound/core/pcm_lib.c | 71 +++++++++++++++++++++++++++-------- sound/firewire/amdtp-stream.c | 46 +++++++---------------- sound/firewire/amdtp-stream.h | 1 - 4 files changed, 71 insertions(+), 48 deletions(-) -- 2.27.0

2 16

ALSA lib pcm_dmix.c:1063:(snd_pcm_dmix_open) unable to create IPC semaphore
by GitHub issues - opened 11 Jun '21

11 Jun '21

alsa-project/alsa-lib issue #153 was opened from Cean1024: Issue URL : https://github.com/alsa-project/alsa-lib/issues/153 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Re: [PATCH] ASoC:fsl_spdif:Remove superfluous error message around platform_get_irq()
by Shengjiu Wang 11 Jun '21

11 Jun '21

On Thu, Jun 10, 2021 at 12:02 PM Zhongjun Tan <hbut_tan(a)163.com> wrote: > > From: Tan Zhongjun <tanzhongjun(a)yulong.com> > > The platform_get_irq() prints error message telling that interrupt is > missing, hence there is no need to duplicated that message. > > Signed-off-by: Tan Zhongjun <tanzhongjun(a)yulong.com> Acked-by: Shengjiu Wang <shengjiu.wang(a)gmail.com> > --- > sound/soc/fsl/fsl_spdif.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c > index 2a76714eb8e6..29cefd459241 100644 > --- a/sound/soc/fsl/fsl_spdif.c > +++ b/sound/soc/fsl/fsl_spdif.c > @@ -1368,10 +1368,8 @@ static int fsl_spdif_probe(struct platform_device *pdev) > > for (i = 0; i < spdif_priv->soc->interrupts; i++) { > irq = platform_get_irq(pdev, i); > - if (irq < 0) { > - dev_err(&pdev->dev, "no irq for node %s\n", pdev->name); > + if (irq < 0) > return irq; > - } > > ret = devm_request_irq(&pdev->dev, irq, spdif_isr, 0, > dev_name(&pdev->dev), spdif_priv); > -- > 2.17.1 >

1 0

Re: [PATCH] ASoC:fsl_easrc:Remove superfluous error message around platform_get_irq()
by Shengjiu Wang 11 Jun '21

11 Jun '21

On Thu, Jun 10, 2021 at 8:52 PM Zhongjun Tan <hbut_tan(a)163.com> wrote: > > From: Tan Zhongjun <tanzhongjun(a)yulong.com> > > Clean up the check for irq.dev_err is superfluous as platform_get_irq() > already prints an error.Remove curly braces to confirm to styling > requirements. > > Signed-off-by: Tan Zhongjun <tanzhongjun(a)yulong.com> Acked-by: Shengjiu Wang <shengjiu.wang(a)gmail.com> > --- > sound/soc/fsl/fsl_easrc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/sound/soc/fsl/fsl_easrc.c b/sound/soc/fsl/fsl_easrc.c > index b1765c7d3bcd..25747433916e 100644 > --- a/sound/soc/fsl/fsl_easrc.c > +++ b/sound/soc/fsl/fsl_easrc.c > @@ -1901,10 +1901,8 @@ static int fsl_easrc_probe(struct platform_device *pdev) > } > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(dev, "no irq for node %pOF\n", np); > + if (irq < 0) > return irq; > - } > > ret = devm_request_irq(&pdev->dev, irq, fsl_easrc_isr, 0, > dev_name(dev), easrc); > -- > 2.17.1 > >

1 0

[PATCH] ALSA: seq: Fix race of snd_seq_timer_open()
by Takashi Iwai 10 Jun '21

10 Jun '21

The timer instance per queue is exclusive, and snd_seq_timer_open() should have managed the concurrent accesses. It looks as if it's checking the already existing timer instance at the beginning, but it's not right, because there is no protection, hence any later concurrent call of snd_seq_timer_open() may override the timer instance easily. This may result in UAF, as the leftover timer instance can keep running while the queue itself gets closed, as spotted by syzkaller recently. For avoiding the race, add a proper check at the assignment of tmr->timeri again, and return -EBUSY if it's been already registered. Reported-by: syzbot+ddc1260a83ed1cbf6fb5(a)syzkaller.appspotmail.com Cc: <stable(a)vger.kernel.org> Link: https://lore.kernel.org/r/000000000000dce34f05c42f110c@google.com Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/core/seq/seq_timer.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/sound/core/seq/seq_timer.c b/sound/core/seq/seq_timer.c index 1645e4142e30..9863be6fd43e 100644 --- a/sound/core/seq/seq_timer.c +++ b/sound/core/seq/seq_timer.c @@ -297,8 +297,16 @@ int snd_seq_timer_open(struct snd_seq_queue *q) return err; } spin_lock_irq(&tmr->lock); - tmr->timeri = t; + if (tmr->timeri) + err = -EBUSY; + else + tmr->timeri = t; spin_unlock_irq(&tmr->lock); + if (err < 0) { + snd_timer_close(t); + snd_timer_instance_free(t); + return err; + } return 0; } -- 2.26.2

1 0