- Alsa-devel - mailman.alsa-project.org

[PATCH -next 0/9] ASoC: fsl: Use devm_platform_get_and_ioremap_resource()
by Yang Yingliang 13 Jun '21

13 Jun '21

patch #1 ~ #8: Use devm_platform_get_and_ioremap_resource() patch #9 check return value of platform_get_resource_byname() Yang Yingliang (9): ASoC: fsl_asrc: Use devm_platform_get_and_ioremap_resource() ASoC: fsl_aud2htx: Use devm_platform_get_and_ioremap_resource() ASoC: fsl_easrc: Use devm_platform_get_and_ioremap_resource() ASoC: fsl_esai: Use devm_platform_get_and_ioremap_resource() ASoC: fsl_micfil: Use devm_platform_get_and_ioremap_resource() ASoC: fsl_sai: Use devm_platform_get_and_ioremap_resource() ASoC: fsl_spdif: Use devm_platform_get_and_ioremap_resource() ASoC: fsl_ssi: Use devm_platform_get_and_ioremap_resource() ASoC: fsl_xcvr: check return value after calling platform_get_resource_byname() sound/soc/fsl/fsl_asrc.c | 3 +-- sound/soc/fsl/fsl_aud2htx.c | 3 +-- sound/soc/fsl/fsl_easrc.c | 3 +-- sound/soc/fsl/fsl_esai.c | 3 +-- sound/soc/fsl/fsl_micfil.c | 3 +-- sound/soc/fsl/fsl_sai.c | 3 +-- sound/soc/fsl/fsl_spdif.c | 3 +-- sound/soc/fsl/fsl_ssi.c | 3 +-- sound/soc/fsl/fsl_xcvr.c | 4 ++++ 9 files changed, 12 insertions(+), 16 deletions(-) -- 2.25.1

2 10

alsa-lib 1.2.5 breaks espeak
by GitHub issues - opened 13 Jun '21

13 Jun '21

alsa-project/alsa-lib issue #155 was opened from MrBitBucket: In archlinux amd64 upgrading alsa-lib from 1.2.4 - 1.2.5 breaks the espeak application https://sourceforge.net/projects/espeak/. I see extra errors in espeak output eg ```Expression 'framesAvail' failed in 'src/hostapi/alsa/pa_linux_alsa.c', line: 3629 Expression 'PaAlsaStreamComponent_GetAvailableFrames( self, &framesAvail, xrun )' failed in 'src/hostapi/alsa/pa_linux_alsa.c', line: 3989 Expression 'PaAlsaStreamComponent_RegisterChannels( &self->playback, &self->bufferProcessor, &playbackFrames, &xrun )' failed in 'src/hostapi/alsa/pa_linux_alsa.c', line: 4118 Expression 'PaAlsaStream_SetUpBuffers( stream, &framesGot, &xrun )' failed in 'src/hostapi/alsa/pa_linux_alsa.c', line: 4359``` Issue URL : https://github.com/alsa-project/alsa-lib/issues/155 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH 0/6] ALSA: bebob/fireworks: device entry corrections
by Takashi Sakamoto 12 Jun '21

12 Jun '21

Hi, After working for hardware database of systemd[1], I realize that current device entries of ALSA bebob/fireworks drivers includes some issues. This patchset corrects them. [1] https://github.com/systemd/systemd/pull/19124 Takashi Sakamoto (6): ALSA: bebob: fulfil device entries ALSA: fireworks: fulfil device entries ALSA: bebob: correct device entry for Mackie D.2 FireWire option card ALSA: bebob: correct device entry for Acoustic Reality eAR Master One, Eroica, Figaro, and Ciaccona ALSA: bebob: code refactoring for M-Audio models ALSA: bebob: correct device entries for Phonic Helix Board and FireFly series sound/firewire/bebob/bebob.c | 92 ++++++++++++++-------------- sound/firewire/bebob/bebob.h | 9 --- sound/firewire/fireworks/fireworks.c | 15 +++++ sound/firewire/fireworks/fireworks.h | 8 --- 4 files changed, 61 insertions(+), 63 deletions(-) -- 2.30.2

2 7

[PATCH][next] ALSA: i2c: tea6330t: Remove redundant initialization of variable err
by Colin King 12 Jun '21

12 Jun '21

From: Colin Ian King <colin.king(a)canonical.com> The variable err is being initialized with a value that is never read, it is being updated later on. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- sound/i2c/tea6330t.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/i2c/tea6330t.c b/sound/i2c/tea6330t.c index 742d0f724375..037d6293f728 100644 --- a/sound/i2c/tea6330t.c +++ b/sound/i2c/tea6330t.c @@ -284,7 +284,7 @@ int snd_tea6330t_update_mixer(struct snd_card *card, struct tea6330t *tea; const struct snd_kcontrol_new *knew; unsigned int idx; - int err = -ENOMEM; + int err; u8 default_treble, default_bass; unsigned char bytes[7]; -- 2.31.1

2 1

[PATCH] ALSA: firewire-lib: replace in_interrupt() with in_softirq()
by Takashi Sakamoto 12 Jun '21

12 Jun '21

Tasklet is used to handle isochronous context of 1394 OHCI. The explicit usage of in_softirq() may be preferable than in_interrupt(). Signed-off-by: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> --- sound/firewire/amdtp-stream-trace.h | 2 +- sound/firewire/amdtp-stream.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/firewire/amdtp-stream-trace.h b/sound/firewire/amdtp-stream-trace.h index aa53c13b89d3..5fd2aeccdfc2 100644 --- a/sound/firewire/amdtp-stream-trace.h +++ b/sound/firewire/amdtp-stream-trace.h @@ -49,7 +49,7 @@ TRACE_EVENT(amdtp_packet, __entry->data_blocks = data_blocks; __entry->data_block_counter = data_block_counter, __entry->packet_index = packet_index; - __entry->irq = !!in_interrupt(); + __entry->irq = !!in_softirq(); __entry->index = index; ), TP_printk( diff --git a/sound/firewire/amdtp-stream.c b/sound/firewire/amdtp-stream.c index 1d9bc7b07df1..aad9778d1c4d 100644 --- a/sound/firewire/amdtp-stream.c +++ b/sound/firewire/amdtp-stream.c @@ -610,7 +610,7 @@ static void update_pcm_pointers(struct amdtp_stream *s, // buffer associated to PCM substream to process PCM frames in the buffer, instead // of receiving notification of period elapsed by poll wait. if (!pcm->runtime->no_period_wakeup) { - if (in_interrupt()) { + if (in_softirq()) { // In software IRQ context for 1394 OHCI. snd_pcm_period_elapsed(pcm); } else { @@ -1026,7 +1026,7 @@ static void generate_pkt_descs(struct amdtp_stream *s, const __be32 *ctx_header, static inline void cancel_stream(struct amdtp_stream *s) { s->packet_index = -1; - if (in_interrupt()) + if (in_softirq()) amdtp_stream_pcm_abort(s); WRITE_ONCE(s->pcm_buffer_pointer, SNDRV_PCM_POS_XRUN); } @@ -1738,7 +1738,7 @@ unsigned long amdtp_domain_stream_pcm_pointer(struct amdtp_domain *d, if (irq_target && amdtp_stream_running(irq_target)) { // In software IRQ context, the call causes dead-lock to disable the tasklet // synchronously. - if (!in_interrupt()) + if (!in_softirq()) fw_iso_context_flush_completions(irq_target->context); } -- 2.30.2

2 1

[PATCH -next] ALSA: n64: check return value after calling platform_get_resource()
by Yang Yingliang 12 Jun '21

12 Jun '21

It will cause null-ptr-deref if platform_get_resource() returns NULL, we need check the return value. Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> --- sound/mips/snd-n64.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/mips/snd-n64.c b/sound/mips/snd-n64.c index e35e93157755..463a6fe589eb 100644 --- a/sound/mips/snd-n64.c +++ b/sound/mips/snd-n64.c @@ -338,6 +338,10 @@ static int __init n64audio_probe(struct platform_device *pdev) strcpy(card->longname, "N64 Audio"); res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); + if (!res) { + err = -EINVAL; + goto fail_dma_alloc; + } if (devm_request_irq(&pdev->dev, res->start, n64audio_isr, IRQF_SHARED, "N64 Audio", priv)) { err = -EBUSY; -- 2.25.1

2 1

[PATCH -next] ALSA: hda/tegra: Use devm_platform_get_and_ioremap_resource()
by Yang Yingliang 12 Jun '21

12 Jun '21

Use devm_platform_get_and_ioremap_resource() to simplify code. Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> --- sound/pci/hda/hda_tegra.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/pci/hda/hda_tegra.c b/sound/pci/hda/hda_tegra.c index 6f2b743b9d75..5aeef6123781 100644 --- a/sound/pci/hda/hda_tegra.c +++ b/sound/pci/hda/hda_tegra.c @@ -235,11 +235,9 @@ static int hda_tegra_init_chip(struct azx *chip, struct platform_device *pdev) { struct hda_tegra *hda = container_of(chip, struct hda_tegra, chip); struct hdac_bus *bus = azx_bus(chip); - struct device *dev = hda->dev; struct resource *res; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - hda->regs = devm_ioremap_resource(dev, res); + hda->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res); if (IS_ERR(hda->regs)) return PTR_ERR(hda->regs); -- 2.25.1

2 1

[PATCH -next] ALSA: trident: Fix build error
by YueHaibing 12 Jun '21

12 Jun '21

sound/pci/trident/trident_memory.c: In function ‘set_tlb_bus’: sound/pci/trident/trident_memory.c:85:35: error: ‘pagetr’ undeclared (first use in this function); did you mean ‘page’? for (i = 0; i < UNIT_PAGES; i++, pagetr++) { ^~~~~~ page Fixes: 74fb98311c4e ("ALSA: trident: Drop shadow TLB pointer table") Signed-off-by: YueHaibing <yuehaibing(a)huawei.com> --- sound/pci/trident/trident_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/trident/trident_memory.c b/sound/pci/trident/trident_memory.c index f831ec02702f..4ad3855101c9 100644 --- a/sound/pci/trident/trident_memory.c +++ b/sound/pci/trident/trident_memory.c @@ -82,7 +82,7 @@ static inline void set_tlb_bus(struct snd_trident *trident, int page, { int i; page *= UNIT_PAGES; - for (i = 0; i < UNIT_PAGES; i++, pagetr++) { + for (i = 0; i < UNIT_PAGES; i++, page++) { __set_tlb_bus(trident, page, addr); addr += SNDRV_TRIDENT_PAGE_SIZE; } -- 2.17.1

2 1

Question about upmix plugin
by GitHub issues - opened 11 Jun '21

11 Jun '21

alsa-project/alsa-plugins issue #25 was opened from krumpfwylg: Hi, I've noticed the [latest commits](https://github.com/alsa-project/alsa-plugins/pull/2) done to the upmix plugin, but there's something I don't understand. Line 24 of pcm_upmix.c is _#define UPMIX_PCM_FORMAT SND_PCM_FORMAT_S16_ Does that mean the upmix plugin is still only capable of using S16_LE format ? Or does the UPMIX_PCM_FORMAT value can get changed to S32_LE by tweaking it in asoundrc file ? Issue URL : https://github.com/alsa-project/alsa-plugins/issues/25 Repository URL: https://github.com/alsa-project/alsa-plugins

1 0

Config parsing of pcm_rate broken since 1.1.7 (at least for a52 pcm plugin)
by GitHub issues - opened 11 Jun '21

11 Jun '21

alsa-project/alsa-lib issue #154 was opened from quequotion: As noted [in the mailing list](https://mailman.alsa-project.org/pipermail/alsa-devel/2019-December/1… back in 2019, config parsing (for alsa-plugins a52 pcm at least) has been broken since alsa-lib 1.1.7. As far as I know this was never bisected to a single commit in either alsa-lib or alsa-plugins. Looking at the mailing list discussion, it occurs to me that it may have given the impression that the config parser was broken when using [a patch that ports alsa-plugins to libswresample](https://git.harting.dev/anonfunc/alsa-plugins/commit/9cdbbb9874757b6f8fda7fb4ac2e3fc59da65946). Config parsing is broken *regardless* of that patch. @IdleGandalf worked around this by applying a patch to alsa-lib, in [src/pcm/pcm_rate.c](https://git.harting.dev/anonfunc/alsa-lib/commit/646bc80a63b0220300678a38e0c26a9a13af6fc0), but never got a response if this was an appropriate method to resolve the issue. Should this be fixed in alsa-lib or in alsa-plugins? Note: above links are to mirrors of the original patches, also in a repository owned by @IdleGandalf as far as I can tell. The links in the mailing list discussion are now 404. Issue URL : https://github.com/alsa-project/alsa-lib/issues/154 Repository URL: https://github.com/alsa-project/alsa-lib

1 0