- Alsa-devel - mailman.alsa-project.org

[PATCH v1] ALSA: hda/tas2781: Upgrade calibratd-data writing code to support Alpha and Beta dsp firmware
by Shenghao Ding 28 Mar '25

28 Mar '25

Since 2025, the firmware for tas2781 has been added more audio acoustic features, such as non-linear compensation, advanced battery guard, rattle-noise suppression, etc. The version was divided into two different series. Both series have a slight change on the calibrated data storage addresses, which becames flexible instead of fixed. In order to support new firwmares in time, the code have some related upgrades. Signed-off-by: Shenghao Ding <shenghao-ding(a)ti.com> --- v2: - revise the subject and description. v1: - Add updating calibration addresses code into tas2781_apply_calib in case of Alpha and Beta firmware. --- sound/pci/hda/tas2781_hda_i2c.c | 30 ++++++++++++++++++++---------- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c index 9ed49b0dbe6b..29dc4f500580 100644 --- a/sound/pci/hda/tas2781_hda_i2c.c +++ b/sound/pci/hda/tas2781_hda_i2c.c @@ -558,28 +558,38 @@ static int tas2563_save_calibration(struct tasdevice_priv *tas_priv) static void tas2781_apply_calib(struct tasdevice_priv *tas_priv) { - static const unsigned char page_array[CALIB_MAX] = { - 0x17, 0x18, 0x18, 0x13, 0x18, + struct calidata *cali_data = &tas_priv->cali_data; + struct cali_reg *r = &cali_data->cali_reg_array; + unsigned int cali_reg[CALIB_MAX] = { + TASDEVICE_REG(0, 0x17, 0x74), + TASDEVICE_REG(0, 0x18, 0x0c), + TASDEVICE_REG(0, 0x18, 0x14), + TASDEVICE_REG(0, 0x13, 0x70), + TASDEVICE_REG(0, 0x18, 0x7c), }; - static const unsigned char rgno_array[CALIB_MAX] = { - 0x74, 0x0c, 0x14, 0x70, 0x7c, - }; - int offset = 0; int i, j, rc; + int oft = 0; __be32 data; + if (tas_priv->dspbin_typ != TASDEV_BASIC) { + cali_reg[0] = r->r0_reg; + cali_reg[1] = r->invr0_reg; + cali_reg[2] = r->r0_low_reg; + cali_reg[3] = r->pow_reg; + cali_reg[4] = r->tlimit_reg; + } + for (i = 0; i < tas_priv->ndev; i++) { for (j = 0; j < CALIB_MAX; j++) { data = cpu_to_be32( - *(uint32_t *)&tas_priv->cali_data.data[offset]); + *(uint32_t *)&tas_priv->cali_data.data[oft]); rc = tasdevice_dev_bulk_write(tas_priv, i, - TASDEVICE_REG(0, page_array[j], rgno_array[j]), - (unsigned char *)&data, 4); + cali_reg[j], (unsigned char *)&data, 4); if (rc < 0) dev_err(tas_priv->dev, "chn %d calib %d bulk_wr err = %d\n", i, j, rc); - offset += 4; + oft += 4; } } } -- 2.34.1

2 1

[ alsa-lib ] OpenHarmony Adaptation Proposal
by GitHub issues - opened 28 Mar '25

28 Mar '25

alsa-project/alsa-lib issue #445 was opened from Asercn: # [ alsa-lib ] OpenHarmony Adaptation Proposal ## Background OpenHarmony is an open-source project incubated and operated by the OpenAtom Open Source Foundation. Its goal is to build an operating system framework and platform for intelligent terminal devices in the era of full scenarios, full connectivity, and full intelligence. ALSA, as an important audio architecture in Linux systems, allows developers to use Linux system calls in programs to control and manage the underlying operating system. Due to its efficient and easy-to-use features, it is also suitable for embedded devices, which aligns well with OpenHarmony's concept of supporting a variety of devices. Currently, ALSA is widely used in the mobile application development field of OpenHarmony. We will submit the adaptation code via a pull request (PR) as soon as possible. This issue is created to engage in in-depth discussions with the community about integrating the adaptation code. We sincerely welcome any valuable suggestions. ## Adaptation Plan 1. Details of the ALSA adaptation plan: 2. Submit back to the main community. 3. Ongoing community maintenance. ## Test Results We have completed large-scale compatibility testing, covering different versions of HarmonyOS and various types of HarmonyOS devices. The test results show that the modified version is highly compatible with the HarmonyOS system and no significant stability issues have been observed. Benefits to the Upstream Community * Can reach OpenHarmony’s large user base and developer community. * By supporting the development trends of the operating system, it ensures the long-term development potential of the project. * Enhances the project's processing capability in diverse operating environments. Issue URL : https://github.com/alsa-project/alsa-lib/issues/445 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Add UCM2 support for ASUS ROG Strix B850-I Gaming WiFi
by GitHub pull_request - edited 28 Mar '25

28 Mar '25

alsa-project/alsa-ucm-conf pull request #537 was edited from austinthiel: [Link to open issue](https://github.com/alsa-project/alsa-ucm-conf/issues/534#issue-29483… I referenced [this guide](https://askubuntu.com/a/1469066) to get SPDIF out working on my ASUS B850-I Gaming WiFi [alsa-info.txt](https://github.com/user-attachments/files/19499096/alsa-info… In case it's relevant, using a sample rate of 48kHz is required. I found that other sample rate produces very low quality, garbled audio. I read that this is because SPDIF only supports 48kHz in hardware, and any other sample rates require the Realtek drivers. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/537 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/537.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Add UCM2 support for ASUS ROG Strix B850-I Gaming WiFi
by GitHub pull_request - edited 28 Mar '25

28 Mar '25

alsa-project/alsa-ucm-conf pull request #537 was edited from austinthiel: Referenced [this guide](https://askubuntu.com/a/1469066) to get SPDIF out working on my ASUS B850-I Gaming WiFi [alsa-info.txt](https://github.com/user-attachments/files/19499096/alsa-info… In case it's relevant, using a sample rate of 48kHz is required. I found that other sample rate produces very low quality, garbled audio. I read that this is because SPDIF only supports 48kHz in hardware, and any other sample rates require the Realtek drivers. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/537 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/537.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Add UCM2 support for ASUS ROG Strix B850-I Gaming WiFi
by GitHub pull_request - edited 28 Mar '25

28 Mar '25

alsa-project/alsa-ucm-conf pull request #537 was edited from austinthiel: Referenced [this guide](https://askubuntu.com/a/1469066) to get SPDIF out working on my ASUS B850-I Gaming WiFi [alsa-info.txt](https://github.com/user-attachments/files/19499096/alsa-info… In case it's relevant, using a sample rate of 48kHz is required. I found that other sample rate produces very low quality, garbled audio. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/537 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/537.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Add UCM2 support for ASUS ROG Strix B850-I Gaming WiFi
by GitHub pull_request - opened 28 Mar '25

28 Mar '25

alsa-project/alsa-ucm-conf pull request #537 was opened from austinthiel: Referenced [this guide](https://askubuntu.com/a/1469066) to get SPDIF out working on my ASUS B850-I Gaming WiFi [alsa-info.txt](https://github.com/user-attachments/files/19498803/alsa-info… In case it's relevant, using a sample rate of 48kHz is required. I found that other sample rate produces very low quality, garbled audio. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/537 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/537.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

USB-Audio Add Roland BridgeCast One USB-Audio.conf
by GitHub pull_request - opened 27 Mar '25

27 Mar '25

alsa-project/alsa-ucm-conf pull request #536 was opened from Simon99de: Add Roland BridgeCast One uses the same config as the bridge cast v2 as it has the same outputs and it worked in my test. 0582:030d Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/536 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/536.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

USB-Audio: ALC4080 - add rear microphone support for 0414:a014
by GitHub pull_request - opened 26 Mar '25

26 Mar '25

alsa-project/alsa-ucm-conf pull request #535 was opened from perexg: 0414:a014 Gigabyte B850I Aorus Pro (rev 1.0) Link: https://github.com/alsa-project/alsa-ucm-conf/issues/528 Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/535 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/535.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH 2/3] ASoC: amd: use new ACP dev names for DAI links
by Brady Norander 26 Mar '25

26 Mar '25

The old names used automatic platform device ids, which means they could change. Use the new device names which will never change. Depends on patch: drm/amdgpu: use static ids for ACP platform devs [1] [1] https://lore.kernel.org/all/20250325210517.2097188-1-bradynorander@gmail.co… Signed-off-by: Brady Norander <bradynorander(a)gmail.com> --- sound/soc/amd/acp-da7219-max98357a.c | 8 ++++---- sound/soc/amd/acp-es8336.c | 4 ++-- sound/soc/amd/acp-rt5645.c | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/sound/soc/amd/acp-da7219-max98357a.c b/sound/soc/amd/acp-da7219-max98357a.c index 02b04f355ca6..42aa009c4e13 100644 --- a/sound/soc/amd/acp-da7219-max98357a.c +++ b/sound/soc/amd/acp-da7219-max98357a.c @@ -517,11 +517,11 @@ static const struct snd_soc_ops cz_rt5682_dmic1_cap_ops = { }; SND_SOC_DAILINK_DEF(designware1, - DAILINK_COMP_ARRAY(COMP_CPU("designware-i2s.1.auto"))); + DAILINK_COMP_ARRAY(COMP_CPU("designware-i2s.1"))); SND_SOC_DAILINK_DEF(designware2, - DAILINK_COMP_ARRAY(COMP_CPU("designware-i2s.2.auto"))); + DAILINK_COMP_ARRAY(COMP_CPU("designware-i2s.2"))); SND_SOC_DAILINK_DEF(designware3, - DAILINK_COMP_ARRAY(COMP_CPU("designware-i2s.3.auto"))); + DAILINK_COMP_ARRAY(COMP_CPU("designware-i2s.3"))); SND_SOC_DAILINK_DEF(dlgs, DAILINK_COMP_ARRAY(COMP_CODEC("i2c-DLGS7219:00", "da7219-hifi"))); @@ -533,7 +533,7 @@ SND_SOC_DAILINK_DEF(adau, DAILINK_COMP_ARRAY(COMP_CODEC("ADAU7002:00", "adau7002-hifi"))); SND_SOC_DAILINK_DEF(platform, - DAILINK_COMP_ARRAY(COMP_PLATFORM("acp_audio_dma.0.auto"))); + DAILINK_COMP_ARRAY(COMP_PLATFORM("acp_audio_dma.0"))); static struct snd_soc_dai_link cz_dai_7219_98357[] = { { diff --git a/sound/soc/amd/acp-es8336.c b/sound/soc/amd/acp-es8336.c index 0193b3eae7a6..b16dde0e2987 100644 --- a/sound/soc/amd/acp-es8336.c +++ b/sound/soc/amd/acp-es8336.c @@ -137,11 +137,11 @@ static const struct snd_soc_ops st_es8336_ops = { }; SND_SOC_DAILINK_DEF(designware1, - DAILINK_COMP_ARRAY(COMP_CPU("designware-i2s.2.auto"))); + DAILINK_COMP_ARRAY(COMP_CPU("designware-i2s.1"))); SND_SOC_DAILINK_DEF(codec, DAILINK_COMP_ARRAY(COMP_CODEC("i2c-ESSX8336:00", "ES8316 HiFi"))); SND_SOC_DAILINK_DEF(platform, - DAILINK_COMP_ARRAY(COMP_PLATFORM("acp_audio_dma.1.auto"))); + DAILINK_COMP_ARRAY(COMP_PLATFORM("acp_audio_dma.0"))); static struct snd_soc_dai_link st_dai_es8336[] = { { diff --git a/sound/soc/amd/acp-rt5645.c b/sound/soc/amd/acp-rt5645.c index 72ddad24dbda..11d373169380 100644 --- a/sound/soc/amd/acp-rt5645.c +++ b/sound/soc/amd/acp-rt5645.c @@ -108,15 +108,15 @@ static const struct snd_soc_ops cz_aif1_ops = { }; SND_SOC_DAILINK_DEF(designware1, - DAILINK_COMP_ARRAY(COMP_CPU("designware-i2s.1.auto"))); + DAILINK_COMP_ARRAY(COMP_CPU("designware-i2s.1"))); SND_SOC_DAILINK_DEF(designware2, - DAILINK_COMP_ARRAY(COMP_CPU("designware-i2s.2.auto"))); + DAILINK_COMP_ARRAY(COMP_CPU("designware-i2s.2"))); SND_SOC_DAILINK_DEF(codec, DAILINK_COMP_ARRAY(COMP_CODEC("i2c-10EC5650:00", "rt5645-aif1"))); SND_SOC_DAILINK_DEF(platform, - DAILINK_COMP_ARRAY(COMP_PLATFORM("acp_audio_dma.0.auto"))); + DAILINK_COMP_ARRAY(COMP_PLATFORM("acp_audio_dma.0"))); static struct snd_soc_dai_link cz_dai_rt5650[] = { { -- 2.49.0

2 2

[PATCH 3/3] ASoC: dwc: always enable/disable i2s irqs
by Brady Norander 26 Mar '25

26 Mar '25

Commit a42e988 ("ASoC: dwc: add DMA handshake control") changed the behavior of the driver to not enable or disable i2s irqs if using DMA. This breaks platforms such as AMD ACP. Revert to the old behavior by always enabling and disabling i2s irqs while keeping DMA handshake control. Fixes: a42e988 ("ASoC: dwc: add DMA handshake control") Signed-off-by: Brady Norander <bradynorander(a)gmail.com> --- sound/soc/dwc/dwc-i2s.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c index 57b789d7fbed..5b4f20dbf7bb 100644 --- a/sound/soc/dwc/dwc-i2s.c +++ b/sound/soc/dwc/dwc-i2s.c @@ -199,12 +199,10 @@ static void i2s_start(struct dw_i2s_dev *dev, else i2s_write_reg(dev->i2s_base, IRER, 1); - /* I2S needs to enable IRQ to make a handshake with DMAC on the JH7110 SoC */ - if (dev->use_pio || dev->is_jh7110) - i2s_enable_irqs(dev, substream->stream, config->chan_nr); - else + if (!(dev->use_pio || dev->is_jh7110)) i2s_enable_dma(dev, substream->stream); + i2s_enable_irqs(dev, substream->stream, config->chan_nr); i2s_write_reg(dev->i2s_base, CER, 1); } @@ -218,11 +216,12 @@ static void i2s_stop(struct dw_i2s_dev *dev, else i2s_write_reg(dev->i2s_base, IRER, 0); - if (dev->use_pio || dev->is_jh7110) - i2s_disable_irqs(dev, substream->stream, 8); - else + if (!(dev->use_pio || dev->is_jh7110)) i2s_disable_dma(dev, substream->stream); + i2s_disable_irqs(dev, substream->stream, 8); + + if (!dev->active) { i2s_write_reg(dev->i2s_base, CER, 0); i2s_write_reg(dev->i2s_base, IER, 0); -- 2.49.0

2 1