- Alsa-devel - mailman.alsa-project.org

Dell XPS 9320: Mic-Mute LED not working
by GitHub issues - opened 18 Dec '22

18 Dec '22

alsa-project/alsa-ucm-conf issue #251 was opened from heftig: The mic-mute LED on my XPS 9320 does not work. Reading `/sys/class/sound/ctl-led/mic/card0/list` outputs `52 18`. Control `18` is the expected `rt714 FU02 Capture Switch` set in `ucm2/codecs/rt715-sdca/init.conf`. Control `52` is: ``` numid=52,iface=MIXER,name='PGA5.0 5 Master Capture Switch' ; type=BOOLEAN,access=rw------,values=2 : values=on,on ``` In this state, the LED does turn on when both switches are off, but muting via PipeWire only toggles control 18. Detaching the LED from `52` (so that only `18` remains) makes it work properly. I've tried finding out how `52` gets attached, but couldn't find anything. Is this done in-kernel? Linux 6.1 ALSA 1.2.8 Arch Linux Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/251 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

RE: [PATCH] ASoC: amd: yc: Add Razer Blade 14 2022 into DMI table
by Limonciello, Mario 16 Dec '22

16 Dec '22

[Public] > -----Original Message----- > From: Wim Van Boven <wimvanboven(a)gmail.com> > Sent: Friday, December 16, 2022 02:18 > Cc: wimvanboven(a)gmail.com; Liam Girdwood <lgirdwood(a)gmail.com>; > Mark Brown <broonie(a)kernel.org>; Jaroslav Kysela <perex(a)perex.cz>; > Takashi Iwai <tiwai(a)suse.com>; Limonciello, Mario > <Mario.Limonciello(a)amd.com>; Saba Kareem, Syed > <Syed.SabaKareem(a)amd.com>; Leohearts <leohearts(a)leohearts.com>; > Brent Mendelsohn <mendiebm(a)gmail.com>; Xiaoyan Li > <lxy.lixiaoyan(a)gmail.com>; linkt <xazrael(a)hotmail.com>; alsa-devel@alsa- > project.org; linux-kernel(a)vger.kernel.org > Subject: [PATCH] ASoC: amd: yc: Add Razer Blade 14 2022 into DMI table > > Razer Blade 14 (2022) - RZ09-0427 needs the quirk to enable the built in > microphone > > Signed-off-by: Wim Van Boven <wimvanboven(a)gmail.com> Thanks! Link: https://bugzilla.kernel.org/show_bug.cgi?id=216801 Reviewed-by: Mario Limonciello <mario.limonciello(a)amd.com> > --- > sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x- > mach.c > index 1f0b5527c594..469c5e79e0ea 100644 > --- a/sound/soc/amd/yc/acp6x-mach.c > +++ b/sound/soc/amd/yc/acp6x-mach.c > @@ -220,6 +220,13 @@ static const struct dmi_system_id > yc_acp_quirk_table[] = { > DMI_MATCH(DMI_PRODUCT_NAME, "Redmi Book > Pro 14 2022"), > } > }, > + { > + .driver_data = &acp6x_card, > + .matches = { > + DMI_MATCH(DMI_BOARD_VENDOR, "Razer"), > + DMI_MATCH(DMI_PRODUCT_NAME, "Blade 14 > (2022) - RZ09-0427"), > + } > + }, > {} > }; > > -- > 2.38.1

1 0

aplay,axfer: Replace off64_t with off_t
by GitHub pull_request - opened 15 Dec '22

15 Dec '22

alsa-project/alsa-utils pull request #183 was opened from kraj: Also replace lseek64 with lseek. _FILE_OFFSET_BITS=64 is passed to needed platforms since configure uses AC_SYS_LARGEFILE macro. Therefore off_t is already 64-bit and lseek is same as lseek64. Additionally this fixes buils with latest musl where these lfs64 functions are moved out from _GNU_SOURCE and under _LARGEFILE64_SOURCE macro alone. This makes the builds fail on 32-bit platforms even though default off_t on musl is 64-bit always. Signed-off-by: Khem Raj <raj.khem(a)gmail.com> Request URL : https://github.com/alsa-project/alsa-utils/pull/183 Patch URL : https://github.com/alsa-project/alsa-utils/pull/183.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[PATCH] ASoC: lochnagar: Fix unused lochnagar_of_match warning
by Krzysztof Kozlowski 15 Dec '22

15 Dec '22

lochnagar_of_match is used unconditionally, so COMPILE_TEST builds without OF warn: sound/soc/codecs/lochnagar-sc.c:247:34: error: ‘lochnagar_of_match’ defined but not used [-Werror=unused-const-variable=] Reported-by: kernel test robot <lkp(a)intel.com> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> --- sound/soc/codecs/lochnagar-sc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/lochnagar-sc.c b/sound/soc/codecs/lochnagar-sc.c index 13fbd8830b09..5e0bd0d24ed3 100644 --- a/sound/soc/codecs/lochnagar-sc.c +++ b/sound/soc/codecs/lochnagar-sc.c @@ -253,7 +253,7 @@ MODULE_DEVICE_TABLE(of, lochnagar_of_match); static struct platform_driver lochnagar_sc_codec_driver = { .driver = { .name = "lochnagar-soundcard", - .of_match_table = of_match_ptr(lochnagar_of_match), + .of_match_table = lochnagar_of_match, }, .probe = lochnagar_sc_probe, -- 2.34.1

2 1

[PATCH 1/2] ASoC: max98088: fix dai1/2_hw_params access
by Rouven Czerwinski 15 Dec '22

15 Dec '22

From: Marco Felsch <m.felsch(a)pengutronix.de> According the reference manuals [1], [2] updating register 0x14/1c should only be done after #shdn bit is set to 0. [1] https://datasheets.maximintegrated.com/en/ds/MAX98089.pdf [2] https://datasheets.maximintegrated.com/en/ds/MAX98088.pdf Signed-off-by: Marco Felsch <m.felsch(a)pengutronix.de> --- sound/soc/codecs/max98088.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/max98088.c b/sound/soc/codecs/max98088.c index 405ec16be2b6..7f108e147355 100644 --- a/sound/soc/codecs/max98088.c +++ b/sound/soc/codecs/max98088.c @@ -977,6 +977,8 @@ static int max98088_dai1_hw_params(struct snd_pcm_substream *substream, rate = params_rate(params); + snd_soc_component_update_bits(component, M98088_REG_51_PWR_SYS, M98088_SHDNRUN, 0); + switch (params_width(params)) { case 16: snd_soc_component_update_bits(component, M98088_REG_14_DAI1_FORMAT, @@ -990,8 +992,6 @@ static int max98088_dai1_hw_params(struct snd_pcm_substream *substream, return -EINVAL; } - snd_soc_component_update_bits(component, M98088_REG_51_PWR_SYS, M98088_SHDNRUN, 0); - if (rate_value(rate, &regval)) return -EINVAL; @@ -1047,6 +1047,8 @@ static int max98088_dai2_hw_params(struct snd_pcm_substream *substream, rate = params_rate(params); + snd_soc_component_update_bits(component, M98088_REG_51_PWR_SYS, M98088_SHDNRUN, 0); + switch (params_width(params)) { case 16: snd_soc_component_update_bits(component, M98088_REG_1C_DAI2_FORMAT, @@ -1060,8 +1062,6 @@ static int max98088_dai2_hw_params(struct snd_pcm_substream *substream, return -EINVAL; } - snd_soc_component_update_bits(component, M98088_REG_51_PWR_SYS, M98088_SHDNRUN, 0); - if (rate_value(rate, &regval)) return -EINVAL; -- 2.38.1

3 5

Re: [PATCH] Add HP Stream 8 to bytcr_rt5640.c
by Mark Brown 14 Dec '22

14 Dec '22

On Wed, 14 Dec 2022 07:08:30 -0500, Moises Cardona wrote: > The bytcr_rt5640.c file already supports the HP Stream 7. > > The HP Stream 8 is almost identical in terms of the hardware > with the exception of it having stereo speakers, a SIM > card slot and the obvious size difference. > > Signed-off-by Moises Cardona <moisesmcardona(a)gmail.com> > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] Add HP Stream 8 to bytcr_rt5640.c commit: ff5870a76c2abda389650d3711cdddc031d12665 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark

1 0

Re: [PATCH] Add HP Stream 8 to bytcr_rt5640.c
by Pierre-Louis Bossart 14 Dec '22

14 Dec '22

On 12/13/22 11:35, Moises Cardona wrote: > The HP Stream 8 tablet is identical to the HP Stream 7 in terms of the PCB, > with the exception of the added SIM Card Slot. > Therefore, I'm submitting this patch which properly initializes the audio > and enables the headphone jack to work, just like it does in the > HP Stream 7. > > Signed-off-by: Moises Cardona <moisesmcardona(a)gmail.com> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> > --- > sound/soc/intel/boards/bytcr_rt5640.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c > index fb9d9e271845..1d964b1ceff4 100644 > --- a/sound/soc/intel/boards/bytcr_rt5640.c > +++ b/sound/soc/intel/boards/bytcr_rt5640.c > @@ -796,6 +796,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = { > BYT_RT5640_SSP0_AIF1 | > BYT_RT5640_MCLK_EN), > }, > + { /* HP Stream 8 */ > + .matches = { > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "HP Stream 8 Tablet"), > + }, > + .driver_data = (void *)(BYTCR_INPUT_DEFAULTS | > + BYT_RT5640_MONO_SPEAKER | > + BYT_RT5640_JD_NOT_INV | > + BYT_RT5640_SSP0_AIF1 | > + BYT_RT5640_MCLK_EN), > + }, > { /* I.T.Works TW891 */ > .matches = { > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),

3 2

Re: [PATCH] Add HP Stream 8 to bytcr_rt5640.c
by Hans de Goede 14 Dec '22

14 Dec '22

Hi, On 12/14/22 13:08, Moises Cardona wrote: > The bytcr_rt5640.c file already supports the HP Stream 7. > > The HP Stream 8 is almost identical in terms of the hardware > with the exception of it having stereo speakers, a SIM > card slot and the obvious size difference. > > > Signed-off-by Moises Cardona <moisesmcardona(a)gmail.com> Thanks, this new version (which should have been marked as v2) looks good to me: Reviewed-by: Hans de Goede <hdegoede(a)redhat.com> Regards, Hans > > --- > sound/soc/intel/boards/bytcr_rt5640.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c > index fb9d9e271845..569d039d680b 100644 > --- a/sound/soc/intel/boards/bytcr_rt5640.c > +++ b/sound/soc/intel/boards/bytcr_rt5640.c > @@ -796,6 +796,16 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = { > BYT_RT5640_SSP0_AIF1 | > BYT_RT5640_MCLK_EN), > }, > + { /* HP Stream 8 */ > + .matches = { > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "HP Stream 8 Tablet"), > + }, > + .driver_data = (void *)(BYTCR_INPUT_DEFAULTS | > + BYT_RT5640_JD_NOT_INV | > + BYT_RT5640_SSP0_AIF1 | > + BYT_RT5640_MCLK_EN), > + }, > { /* I.T.Works TW891 */ > .matches = { > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),

1 0

Re: [PATCH 2/2] ASoC: da7213: Add support for mono, set frame width to 32 when possible
by Mark Brown 14 Dec '22

14 Dec '22

On Wed, Dec 14, 2022 at 03:31:26PM +0100, Piotr Wojtaszczyk wrote: > It was a single patch, with no deps. > It's flagged as patch 2/2? > On Wed, Dec 14, 2022 at 3:21 PM Mark Brown <broonie(a)kernel.org> wrote: Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is being addressed.

1 0

[PATCH] ASoC: SOF: mediatek: initialize panic_info to zero
by YC Hung 14 Dec '22

14 Dec '22

Coverity spotted that panic_info is not initialized to zero in mtk_adsp_dump. Using uninitialized value panic_info.linenum when calling snd_sof_get_status. Fix this coverity by initializing panic_info struct as zero. Signed-off-by: YC Hung <yc.hung(a)mediatek.com> --- sound/soc/sof/mediatek/mtk-adsp-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sof/mediatek/mtk-adsp-common.c b/sound/soc/sof/mediatek/mtk-adsp-common.c index 1e0769c668a7..de8dbe27cd0d 100644 --- a/sound/soc/sof/mediatek/mtk-adsp-common.c +++ b/sound/soc/sof/mediatek/mtk-adsp-common.c @@ -60,7 +60,7 @@ void mtk_adsp_dump(struct snd_sof_dev *sdev, u32 flags) { char *level = (flags & SOF_DBG_DUMP_OPTIONAL) ? KERN_DEBUG : KERN_ERR; struct sof_ipc_dsp_oops_xtensa xoops; - struct sof_ipc_panic_info panic_info; + struct sof_ipc_panic_info panic_info = {}; u32 stack[MTK_ADSP_STACK_DUMP_SIZE]; u32 status; -- 2.18.0

3 2