- Alsa-devel - mailman.alsa-project.org

[PATCH] ALSA: usb-audio: Rename ALSA kcontrol PCM and PCM1 for the KTMicro sound card
by wangdicheng 13 Jun '25

13 Jun '25

From: wangdicheng <wangdicheng(a)kylinos.cn> PCM1 not in Pulseaudio's control list;standardize control to "Speaker"and"Headphone" Signed-off-by: wangdicheng <wangdicheng(a)kylinos.cn> --- sound/usb/mixer_maps.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/sound/usb/mixer_maps.c b/sound/usb/mixer_maps.c index 0e9b5431a47f..faac7df1fbcf 100644 --- a/sound/usb/mixer_maps.c +++ b/sound/usb/mixer_maps.c @@ -383,6 +383,13 @@ static const struct usbmix_name_map ms_usb_link_map[] = { { 0 } /* terminator */ }; +/* KTMicro USB */ +static struct usbmix_name_map s31b2_0022_map[] = { + { 23, "Speaker Playback" }, + { 18, "Headphone Playback" }, + { 0 } +}; + /* ASUS ROG Zenith II with Realtek ALC1220-VB */ static const struct usbmix_name_map asus_zenith_ii_map[] = { { 19, NULL, 12 }, /* FU, Input Gain Pad - broken response, disabled */ @@ -692,6 +699,11 @@ static const struct usbmix_ctl_map usbmix_ctl_maps[] = { .id = USB_ID(0x045e, 0x083c), .map = ms_usb_link_map, }, + { + /* KTMicro USB */ + .id = USB_ID(0X31b2, 0x0022), + .map = s31b2_0022_map, + }, { 0 } /* terminator */ }; -- 2.25.1

2 1

ucm2: sof-soundwire: add rt712+rt1320 amplifier
by GitHub pull_request - opened 13 Jun '25

13 Jun '25

alsa-project/alsa-ucm-conf pull request #580 was opened from shumingfan: This patch makes SpeakerCodec could get rt712+rt1320 string from spk:rt712+rt1320 component string. According to the control name, we will know that one or two amplifiers exist. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/580 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/580.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[tiwai-sound:for-next 10/18] mixer_quirks.c:undefined reference to `input_close_device'
by kernel test robot 13 Jun '25

13 Jun '25

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next head: 30f85eddbdebba7665f9b7b772821e588547ca9e commit: 79d561c4ec0497669f19a9550cfb74812f60938b [10/18] ALSA: usb-audio: Add mixer quirk for Sony DualSense PS5 config: nios2-randconfig-001-20250613 (https://download.01.org/0day-ci/archive/20250613/202506130733.gnPKw2l3-lkp@…) compiler: nios2-linux-gcc (GCC) 11.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250613/202506130733.gnPKw2l3-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202506130733.gnPKw2l3-lkp@intel.com/ All errors (new ones prefixed by >>): nios2-linux-ld: sound/usb/mixer_quirks.o: in function `snd_dualsense_ih_disconnect': >> mixer_quirks.c:(.text+0x25d8): undefined reference to `input_close_device' >> mixer_quirks.c:(.text+0x25d8): relocation truncated to fit: R_NIOS2_CALL26 against `input_close_device' >> nios2-linux-ld: mixer_quirks.c:(.text+0x25e0): undefined reference to `input_unregister_handle' >> mixer_quirks.c:(.text+0x25e0): relocation truncated to fit: R_NIOS2_CALL26 against `input_unregister_handle' nios2-linux-ld: sound/usb/mixer_quirks.o: in function `snd_dualsense_mixer_elem_free': >> mixer_quirks.c:(.text+0x26f0): undefined reference to `input_unregister_handler' >> mixer_quirks.c:(.text+0x26f0): relocation truncated to fit: R_NIOS2_CALL26 against `input_unregister_handler' nios2-linux-ld: sound/usb/mixer_quirks.o: in function `snd_dualsense_ih_connect': >> mixer_quirks.c:(.text+0x2d8c): undefined reference to `input_register_handle' >> mixer_quirks.c:(.text+0x2d8c): relocation truncated to fit: R_NIOS2_CALL26 against `input_register_handle' >> nios2-linux-ld: mixer_quirks.c:(.text+0x2d9c): undefined reference to `input_open_device' >> mixer_quirks.c:(.text+0x2d9c): relocation truncated to fit: R_NIOS2_CALL26 against `input_open_device' nios2-linux-ld: mixer_quirks.c:(.text+0x2dac): undefined reference to `input_unregister_handle' mixer_quirks.c:(.text+0x2dac): relocation truncated to fit: R_NIOS2_CALL26 against `input_unregister_handle' nios2-linux-ld: sound/usb/mixer_quirks.o: in function `snd_dualsense_jack_create': >> mixer_quirks.c:(.text+0x2f30): undefined reference to `input_register_handler' >> mixer_quirks.c:(.text+0x2f30): relocation truncated to fit: R_NIOS2_CALL26 against `input_register_handler' -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

UCM2: Intel: sof-hda-dsp: HiFi: Fix handling of mono DMICs
by GitHub pull_request - opened 12 Jun '25

12 Jun '25

alsa-project/alsa-ucm-conf pull request #579 was opened from ujfalusi: When a single DMIC is present in the system we need to set the CaptureChannels to 1 since the PCM device only supports mono, PA/PW will reject the profile since it cannot open the DMIC PCM device. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/579 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/579.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

tinycompress: fix compress_read API
by GitHub pull_request - opened 11 Jun '25

11 Jun '25

alsa-project/tinycompress pull request #28 was opened from quic-ajender: In blocking mode: read is blocked until it reads some bytes In Non-blocking mode: read as much as available bytes, if available. Request URL : https://github.com/alsa-project/tinycompress/pull/28 Patch URL : https://github.com/alsa-project/tinycompress/pull/28.patch Repository URL: https://github.com/alsa-project/tinycompress

1 0

Asus Zephyrus G16 2025 GA605KM (AMD)
by GitHub issues - edited 10 Jun '25

10 Jun '25

alsa-project/alsa-ucm-conf issue #578 was edited from nefelim4ag: [alsa-info](https://alsa-project.org/db/?f=eca30fae9c2bfca031f9cc921462dd7bc… I'm not too familiar with the audio stack to really make a fix. From my small investigation, it seems like there is no UCM for my card (generic_1): ``` ~ cat /proc/asound/cards 0 [NVidia ]: HDA-Intel - HDA NVidia HDA NVidia at 0xd0080000 irq 128 1 [Generic ]: HDA-Intel - HD-Audio Generic HD-Audio Generic at 0xb02c8000 irq 129 2 [Generic_1 ]: HDA-Intel - HD-Audio Generic HD-Audio Generic at 0xb02c0000 irq 130 ``` My issue is that audio control from KDE is borked. ![Image](https://github.com/user-attachments/assets/0636ad48-7edf-4de0-bb68-e8669e2ab5e2) Instead of just adjusting the PCM volume, it adjusts the master, then the speaker, and then the PCM. Other knobs seem to do no useful work, except the speaker balance (AMP1/AMP2). (also, I'm not sure that master and speaker actually do what they are named; they both seem to just make the sound "dull") I can clone repo, test PR & etc. Thanks. Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/578 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Asus Zephyrus G16 2025 GA605KM (AMD)
by GitHub issues - opened 10 Jun '25

10 Jun '25

alsa-project/alsa-ucm-conf issue #578 was opened from nefelim4ag: [alsa-info](https://alsa-project.org/db/?f=eca30fae9c2bfca031f9cc921462dd7bc… I'm not too familiar with the audio stack to really make a fix. From my small investigation, it seems like there is no UCM for my card: ``` ~ cat /proc/asound/cards 0 [NVidia ]: HDA-Intel - HDA NVidia HDA NVidia at 0xd0080000 irq 128 1 [Generic ]: HDA-Intel - HD-Audio Generic HD-Audio Generic at 0xb02c8000 irq 129 2 [Generic_1 ]: HDA-Intel - HD-Audio Generic HD-Audio Generic at 0xb02c0000 irq 130 ``` My issue is that audio control from KDE is borked. ![Image](https://github.com/user-attachments/assets/0636ad48-7edf-4de0-bb68-e8669e2ab5e2) Instead of just adjusting the PCM volume, it adjusts the master, then the speaker, and then the PCM. Other knobs seem to do no useful work, except the speaker balance (AMP1/AMP2). (also, I'm not sure that master and speaker actually do what they are named; they both seem to just make the sound "dull") I can clone repo, test PR & etc. Thanks. Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/578 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Request for help: How to upgrade a sound driver from kernel 4.14 to 6.6
by Steve Broshar 10 Jun '25

10 Jun '25

I have an audio driver/module that builds for kernel 4.14, but not for 6.6 due to changes in the kernel API.I find that API types (structs) and functions have been removed or changed, but IDK how to modify my code to use the updated API. Further, some of the changes seem less than clean. For example, in a couple places struct fields have been removed, but comments that used to precede the fields are still there such the comments are clearly no longer relevant and are therefore confusing. I have to wonder how many comments are out-of-date. My ask is for help fixing my code. I don't expect you to fix directly, but I need to know how to go about figuring out how to fix it. What changed in the API? Is there an upgrade guide/info? I am going to include more than a little info. I realize that it might be overwhelming. But, I fear that I try to reduce the info too much it will not convey the relevant context. I'll start with my analysis of my compiler errors that I get. Seems that the struct snd_soc_codec and struct snd_soc_codec_driver were removed. Seems that snd_soc_register_codec() and snd_soc_unregister_codec() were removed. What replaces these things? What do I need to change to accommodate the removal of these? FYI, here are my compiler errors: <build-errors> $ make -C ../../.. M=$PWD make: Entering directory '/home/steve/code/compton-kernel' CC [M] /home/steve/code/compton-kernel/drivers/compton/dep-imx8-i2s/dep_i2s.o /home/steve/code/compton-kernel/drivers/compton/dep-imx8-i2s/dep_i2s.c:110:38: warning: 'struct snd_soc_codec' declared inside parameter list will not be visible outside of this definition or declaration 110 | static int codec_driver_probe(struct snd_soc_codec *codec) | ^~~~~~~~~~~~~ In file included from ./include/linux/device.h:15, from ./include/linux/platform_device.h:13, from ./include/linux/of_device.h:5, from /home/steve/code/compton-kernel/drivers/compton/dep-imx8-i2s/dep_i2s.c:7: /home/steve/code/compton-kernel/drivers/compton/dep-imx8-i2s/dep_i2s.c: In function 'codec_driver_probe': /home/steve/code/compton-kernel/drivers/compton/dep-imx8-i2s/dep_i2s.c:112:19: error: invalid use of undefined type 'struct snd_soc_codec' 112 | dev_info(codec->dev, "Entered %s", __func__); | ^~ ./include/linux/dev_printk.h:110:25: note: in definition of macro 'dev_printk_index_wrap' 110 | _p_func(dev, fmt, ##__VA_ARGS__); \ | ^~~ /home/steve/code/compton-kernel/drivers/compton/dep-imx8-i2s/dep_i2s.c:112:5: note: in expansion of macro 'dev_info' 112 | dev_info(codec->dev, "Entered %s", __func__); | ^~~~~~~~ /home/steve/code/compton-kernel/drivers/compton/dep-imx8-i2s/dep_i2s.c: At top level: /home/steve/code/compton-kernel/drivers/compton/dep-imx8-i2s/dep_i2s.c:116:21: error: variable 'codec_driver' has initializer but incomplete type 116 | static const struct snd_soc_codec_driver codec_driver = { | ^~~~~~~~~~~~~~~~~~~~ /home/steve/code/compton-kernel/drivers/compton/dep-imx8-i2s/dep_i2s.c:117:6: error: 'const struct snd_soc_codec_driver' has no member named 'probe' 117 | .probe = codec_driver_probe, | ^~~~~ /home/steve/code/compton-kernel/drivers/compton/dep-imx8-i2s/dep_i2s.c:117:14: warning: excess elements in struct initializer 117 | .probe = codec_driver_probe, | ^~~~~~~~~~~~~~~~~~ /home/steve/code/compton-kernel/drivers/compton/dep-imx8-i2s/dep_i2s.c:117:14: note: (near initialization for 'codec_driver') /home/steve/code/compton-kernel/drivers/compton/dep-imx8-i2s/dep_i2s.c:118:6: error: 'const struct snd_soc_codec_driver' has no member named 'component_driver' 118 | .component_driver = { | ^~~~~~~~~~~~~~~~ /home/steve/code/compton-kernel/drivers/compton/dep-imx8-i2s/dep_i2s.c:118:25: error: extra brace group at end of initializer 118 | .component_driver = { | ^ /home/steve/code/compton-kernel/drivers/compton/dep-imx8-i2s/dep_i2s.c:118:25: note: (near initialization for 'codec_driver') /home/steve/code/compton-kernel/drivers/compton/dep-imx8-i2s/dep_i2s.c:118:25: warning: excess elements in struct initializer /home/steve/code/compton-kernel/drivers/compton/dep-imx8-i2s/dep_i2s.c:118:25: note: (near initialization for 'codec_driver') /home/steve/code/compton-kernel/drivers/compton/dep-imx8-i2s/dep_i2s.c: In function 'platform_driver_probe_': /home/steve/code/compton-kernel/drivers/compton/dep-imx8-i2s/dep_i2s.c:153:12: error: implicit declaration of function 'snd_soc_register_codec'; did you mean 'snd_soc_register_dai'? [-Werror=implicit-function-declaration] 153 | stat = snd_soc_register_codec(&pdev->dev, &codec_driver, &dai_driver, 1); | ^~~~~~~~~~~~~~~~~~~~~~ | snd_soc_register_dai /home/steve/code/compton-kernel/drivers/compton/dep-imx8-i2s/dep_i2s.c: In function 'platform_driver_remove': /home/steve/code/compton-kernel/drivers/compton/dep-imx8-i2s/dep_i2s.c:166:5: error: implicit declaration of function 'snd_soc_unregister_codec'; did you mean 'snd_soc_unregister_dai'? [-Werror=implicit-function-declaration] 166 | snd_soc_unregister_codec(&pdev->dev); | ^~~~~~~~~~~~~~~~~~~~~~~~ | snd_soc_unregister_dai /home/steve/code/compton-kernel/drivers/compton/dep-imx8-i2s/dep_i2s.c: At top level: /home/steve/code/compton-kernel/drivers/compton/dep-imx8-i2s/dep_i2s.c:116:42: error: storage size of 'codec_driver' isn't known 116 | static const struct snd_soc_codec_driver codec_driver = { | ^~~~~~~~~~~~ cc1: some warnings being treated as errors make[2]: *** [scripts/Makefile.build:243: /home/steve/code/compton-kernel/drivers/compton/dep-imx8-i2s/dep_i2s.o] Error 1 make[1]: *** [/home/steve/code/compton-kernel/Makefile:1921: /home/steve/code/compton-kernel/drivers/compton/dep-imx8-i2s] Error 2 make: *** [Makefile:234: __sub-make] Error 2 make: Leaving directory '/home/steve/code/compton-kernel' </build-errors> My code (for 4.14 kernel) --------------------------------- Here's my driver code. The macro INCLUDE_PROBLEMATIC_CODE is used around each chuck that fails to compile. If not defined, the code does compile, but of course is missing important parts. <my-code> #define INCLUDE_PROBLEMATIC_CODE /* * Audindate Dante Embedded Platform (DEP) I2S Codec (ALSA SoC) driver; Linux module * Supports sample rates, bit depths and TDM modes for Dante devices. */ #include <linux/module.h> #include <linux/of_device.h> #include <linux/clk.h> #include <sound/soc.h> #include <sound/pcm.h> #include <linux/printk.h> #define DEP_I2S_PCM_RATES (SNDRV_PCM_RATE_44100 | SNDRV_PCM_RATE_48000 | \ SNDRV_PCM_RATE_88200 | SNDRV_PCM_RATE_96000 | \ SNDRV_PCM_RATE_176400 | SNDRV_PCM_RATE_192000) #define DEP_I2S_PCM_FORMATS ( SNDRV_PCM_FMTBIT_S16_LE | \ SNDRV_PCM_FMTBIT_S24_LE | \ SNDRV_PCM_FMTBIT_S32_LE ) // for future use struct instance_state { unsigned int dummy_holder; }; static const struct snd_soc_dapm_widget widgets[] = { SND_SOC_DAPM_DAC("DAC", "Playback", SND_SOC_NOPM, 0, 0), SND_SOC_DAPM_ADC("ADC", "Capture", SND_SOC_NOPM, 0, 0), SND_SOC_DAPM_OUTPUT("LINEVOUT"), SND_SOC_DAPM_INPUT("LINEVIN"), }; static const struct snd_soc_dapm_route routes[] = { { "LINEVOUT", NULL, "DAC" }, { "ADC", NULL, "LINEVIN" }, }; static int set_fmt(struct snd_soc_dai *dai, unsigned int fmt) { switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) { case SND_SOC_DAIFMT_I2S: // supported break; case SND_SOC_DAIFMT_LEFT_J: // supported break; default: // all other formats unsupported dev_err(dai->dev, "Invalid DAI format: DEP I2S only supports left justified and I2S, got 0x%04X", fmt); return -EINVAL; } switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) { // codec as bit master and frame master (or external clock generator) // note that jumpers on DEP-EVK-IMX8 must be set correctly case SND_SOC_DAIFMT_CBM_CFM: // supported break; // codec as bit slave and frame slave (ie clocks driven from SOC) case SND_SOC_DAIFMT_CBS_CFS: // supported break; default: // all others unsupported dev_err(dai->dev, "Invalid DAI format: DEP I2S only supports CODEC as bit and frame clock master, got 0x%04X", fmt); return -EINVAL; } switch (fmt & SND_SOC_DAIFMT_INV_MASK) { default: // support bit and frame inversion break; } dev_info(dai->dev, "Set fmt to %u", fmt); return 0; } static struct snd_soc_dai_ops dep_i2s_dai_ops = { .set_fmt = set_fmt, // add mute here }; struct snd_soc_dai_driver dai_driver = { .name = "dep-i2s", .playback = { .stream_name = "Playback", .channels_min = 1, .channels_max = 16, .rate_min = 44100, .rate_max = 192000, .rates = DEP_I2S_PCM_RATES, .formats = DEP_I2S_PCM_FORMATS, }, .capture = { .stream_name = "Capture", .channels_min = 1, .channels_max = 16, .rate_min = 44100, .rate_max = 192000, .rates = DEP_I2S_PCM_RATES, .formats = DEP_I2S_PCM_FORMATS, }, .ops = &dep_i2s_dai_ops, .symmetric_rate = 1, }; #ifdef INCLUDE_PROBLEMATIC_CODE // Dummy probe static int codec_driver_probe(struct snd_soc_codec *codec) { dev_info(codec->dev, "Entered %s", __func__); return 0; } static const struct snd_soc_codec_driver codec_driver = { .probe = codec_driver_probe, .component_driver = { .dapm_widgets = widgets, .num_dapm_widgets = ARRAY_SIZE(widgets), .dapm_routes = routes, .num_dapm_routes = ARRAY_SIZE(routes), }, }; #endif #if defined(CONFIG_OF) static const struct of_device_id match_table[] = { {.compatible = "audinate,dep_i2s"}, {} }; MODULE_DEVICE_TABLE(of, match_table); #endif static int platform_driver_probe_(struct platform_device *pdev) { dev_info(&pdev->dev, "Entered %s", __func__); int stat = 0; struct instance_state *instance_state = devm_kzalloc(&pdev->dev, sizeof(struct instance_state), GFP_KERNEL); if (instance_state == NULL) { return -ENOMEM; } platform_set_drvdata(pdev, instance_state); dev_info(&pdev->dev, "Codec probe pt 2"); #ifdef INCLUDE_PROBLEMATIC_CODE // 1 == number of DAIs, might need to be 2 for dual direction, or for 2* sai? stat = snd_soc_register_codec(&pdev->dev, &codec_driver, &dai_driver, 1); if (stat < 0) { dev_err(&pdev->dev, "Failed to register codec: %d", stat); } #endif return stat; } static int platform_driver_remove(struct platform_device *pdev) { dev_info(&pdev->dev, "Entered %s", __func__); #ifdef INCLUDE_PROBLEMATIC_CODE snd_soc_unregister_codec(&pdev->dev); #endif return 0; } static struct platform_driver platform_driver = { .probe = platform_driver_probe_, .remove = platform_driver_remove, .driver = { .name = "dep-i2s-codec", .of_match_table = of_match_ptr(match_table), }, }; module_platform_driver(platform_driver); MODULE_DESCRIPTION("Audinate DEP generic I2S ASoC codec"); MODULE_AUTHOR("James Stuart <opensource(a)audinate.com>"); MODULE_ALIAS("platform:dep-i2s-codec"); MODULE_LICENSE("GPL"); </my-code> Steve Broshar Palmer Wireless Medtech

3 6

Re: [PATCH v1 1/4] ASoc: tac5x1x: add codec driver tac5x1x family
by Holalu Yogendra, Niranjan 10 Jun '25

10 Jun '25

> From: Mark Brown <broonie(a)kernel.org> > Sent: Friday, June 6, 2025 6:17 PM > Subject: Re: [PATCH v1 1/4] ASoc: tac5x1x: add codec driver > tac5x1x family > > On Fri, Jun 06, 2025 at 12:21:33PM +0530, Niranjan H Y wrote: ... > There's a few issues below but nothing that's *hugely* structural, the > bulk of the code here looks good. Thank you for your time and review comments. I will add fixes for most the comments in the next patch. Request you to take a look at some comments below. > > > +config SND_SOC_TAC5X1X > > + tristate "Texas Instruments TAC5X1X family codecs" > > + depends on I2C && REGMAP_I2C > > + > > +config SND_SOC_TAC5X1X_I2C > > + tristate "Texas Instruments TAC5X1X family driver based on I2C" > > + depends on I2C && REGMAP_I2C > > + select SND_SOC_TAC5X1X > > You need to select REGMAP_I2C if you use it, it can't be turned on > independently. If the device is I2C only then there's no need to have > the second option for I2C, that's used for devices that support both I2C > and SPI to avoid problems with dependencies on the I2C and SPI core > code. Many of these devices support SPI interface as well. So I thought I will make library and I2C interface file. But currently SPI support is not added in the driver. Is this okay to still keep this ? please suggest. ... > > > +static const char * const out_ch2_ltch[] = { > > + "OUT_CH2 OUT2P Short circuit Fault", > > + "OUT_CH2 OUT2M Short circuit Fault", > > + "OUT_CH2 DRVRP Virtual Ground Fault", > > + "OUT_CH2 DRVRM Virtual ground Fault", > > + "Reserved", > > + "Reserved", > > + "AREG SC Fault Mask", > > + "AREG SC Fault", > > +}; > > For ones where the reserved values are in the middle of the set of > values you can use _VAL_ENUM() which lets you skip over the values that > are invalid. Is there some example which I can refer? I could not find anything in the kernel source with _VAL_ENUM. I will try to refactor to avoid this. > > > +static s32 tac5x1x_regmap_write(struct tac5x1x_priv *tac5x1x, > > + u32 reg, u32 value) > > +{ > > + s32 ret; > > + s32 retry_count = 5; > > + > > + while (retry_count--) { > > + ret = regmap_write(tac5x1x->regmap, reg, > > + value); > > + if (ret >= 0) > > + break; > > + usleep_range(5000, 5050); > > + } > > + if (retry_count == -1) > > + return 3; > > + else > > + return ret; > > +} > > Is the hardware genuinely so unstable that we need to retry all the I/O? > This seems really concerning. I think this can be dropped as this is used for some legacy devices for some customer platforms. I will remove this in next patch and redo the tests. > > +static s32 tac5x1x_set_GPO1_gpio(struct snd_kcontrol *kcontrol, > > + struct snd_ctl_elem_value *ucontrol) > > +{ > > + struct snd_soc_component *component = > snd_kcontrol_chip(kcontrol); > > + s32 gpio_check, val; > > + > > + val = snd_soc_component_read(component, TAC5X1X_GPO1); > > + gpio_check = ((val & TAC5X1X_GPIOX_CFG_MASK) >> 0); > > + if (gpio_check != TAC5X1X_GPIO_GPO) { > > + dev_err(component->dev, > > + "%s: GPO1 is not configure as a GPO output\n", > > + __func__); > > + return -EINVAL; > > + } > > + > > + if (ucontrol->value.integer.value[0]) > > + val = 0; > > + else > > + val = TAC5X1X_GPO1_VAL; > > This seems to be exposing a GPIO directly to userspace, which will > prevent using that GPIO with other kernel subsystems. It would be > better to expose this via gpiolib, then if userspace control is needed > that can be done through gpiolib. Thanks for the suggestion. But, in our case, codec chip has some GPIO pins which are specific to the codec. We do not intend to expose to the other kernel subsystem. It is more of codec chip configuration to use these GPIO pins as - for e.g. daisy-chain input, audio data output, PLL input clock source, interrupt, digital audio input(PDM) etc. Depending on the hardware connection, we need to configure some registers so that the pin can function as any one of the features which mentioned in the data sheet. More info in section "5 Pin Configuration and Functions" & "Table 7-70. Multifunction Pin Assignments" in the data sheet. https://www.ti.com/lit/ds/symlink/tac5212.pdf If it feels right, I can make this also as part of the dts configuration. Please suggest if I still need to expose this as gpiolib. > > > +static const char *const tac5x1x_slot_select_text[] = { > > + "Slot 0", "Slot 1", "Slot 2", "Slot 3", > > + "Slot 4", "Slot 5", "Slot 6", "Slot 7", > > + "Slot 8", "Slot 9", "Slot 10", "Slot 11", > > + "Slot 12", "Slot 13", "Slot 14", "Slot 15", > > + "Slot 16", "Slot 17", "Slot 18", "Slot 19", > > + "Slot 20", "Slot 21", "Slot 22", "Slot 23", > > + "Slot 24", "Slot 25", "Slot 26", "Slot 27", > > + "Slot 28", "Slot 29", "Slot 30", "Slot 31", > > +}; > > TDM slot control would usually be done via set_tdm_slot(). We need the slots to be configurable in case we need to swap capture channels. Is it okay to keep this ? > > > +static const char *const out2x_vcom_text[] = { > > + "0.6 * Vref", > > + "AVDD by 2", > > +}; > > + This can be device tree setting. I will move it. > > +static const char *const diag_cfg_text[] = { > > + "0mv", "30mv", "60mv", "90mv", > > + "120mv", "150mv", "180mv", "210mv", > > + "240mv", "270mv", "300mv", "330mv", > > + "360mv", "390mv", "420mv", "450mv", > > +}; > > + > > +static const char *const diag_cfg_gnd_text[] = { > > + "0mv", "60mv", "120mv", "180mv", > > + "240mv", "300mv", "360mv", "420mv", > > + "480mv", "540mv", "600mv", "660mv", > > + "720mv", "780mv", "840mv", "900mv", > > +}; > > Are these controls that should be device tree data? We need these values to be configurable via mixer controls. Thanks, Niranjan H Y

2 1

ucm2: Qualcomm: Update the QCM6490 and QCS6490 HiFi conf files
by GitHub pull_request - opened 10 Jun '25

10 Jun '25

alsa-project/alsa-ucm-conf pull request #577 was opened from mohsRafi: Rename the HiFi conf files for QCM6490-IDP and QCS6490-RB3Gen2 boards to match with soundcard name. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/577 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/577.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0