- Alsa-devel - mailman.alsa-project.org

[PATCH V4 0/6] soundwire: amd: code improvements and new platform support
by Vijendar Mukunda 13 Feb '25

13 Feb '25

This patch series consists of code improvements and new platform support for ACP7.0 & ACP7.1 platforms. Changes since v3: - Remove extra white line in amd_sdw_manager_start() function. Changes since v2: - Rebase the patch series after dropping the patch which adds conditional check for SoundWire manager device resume when wake event is asserted. Changes since v1: - Drop white line insertion in the code. - Add a conditional check for SoundWire manager device resume when wake event is asserted. - Add new patch to set ACP_PME_EN during runtime suspend sequence - Split the existing implementation of host wake interrupt mask enablement and setting device power state in to two separate patches and refactor set device power state logic. - Drop PME status clear logic. Vijendar Mukunda (6): soundwire: amd: change the soundwire wake enable/disable sequence soundwire: amd: add debug log for soundwire wake event soundwire: amd: add support for ACP7.0 & ACP7.1 platforms soundwire: amd: set device power state during suspend/resume sequence soundwire: amd: set ACP_PME_EN during runtime suspend sequence soundwire: amd: add soundwire host wake interrupt enable/disable sequence drivers/soundwire/amd_manager.c | 149 +++++++++++++++++++++++++++++- drivers/soundwire/amd_manager.h | 26 ++++++ include/linux/soundwire/sdw_amd.h | 2 + 3 files changed, 172 insertions(+), 5 deletions(-) -- 2.34.1

3 8

[PATCH] ASoC: amd: ps: use switch statements for acp pci revision id check
by Vijendar Mukunda 13 Feb '25

13 Feb '25

Use switch statements for acp pci revision id check in SoundWire dma irq handling. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda(a)amd.com> --- sound/soc/amd/ps/pci-ps.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/sound/soc/amd/ps/pci-ps.c b/sound/soc/amd/ps/pci-ps.c index 220dca8cba85..2ff8e67c19bd 100644 --- a/sound/soc/amd/ps/pci-ps.c +++ b/sound/soc/amd/ps/pci-ps.c @@ -111,16 +111,21 @@ static short int check_and_handle_sdw_dma_irq(struct acp63_dev_data *adata, u32 stream_id = ACP63_SDW0_AUDIO2_RX; break; } - if (adata->acp_rev >= ACP70_PCI_REV) - adata->acp70_sdw0_dma_intr_stat[stream_id] = 1; - else + switch (adata->acp_rev) { + case ACP63_PCI_REV: adata->acp63_sdw0_dma_intr_stat[stream_id] = 1; - + break; + case ACP70_PCI_REV: + case ACP71_PCI_REV: + adata->acp70_sdw0_dma_intr_stat[stream_id] = 1; + break; + } sdw_dma_irq_flag = 1; } } } - if (adata->acp_rev == ACP63_PCI_REV) { + switch (adata->acp_rev) { + case ACP63_PCI_REV: if (ext_intr_stat1 & ACP63_P1_AUDIO1_RX_THRESHOLD) { writel(ACP63_P1_AUDIO1_RX_THRESHOLD, adata->acp63_base + ACP_EXTERNAL_INTR_STAT1); @@ -133,7 +138,9 @@ static short int check_and_handle_sdw_dma_irq(struct acp63_dev_data *adata, u32 adata->acp63_sdw1_dma_intr_stat[ACP63_SDW1_AUDIO1_TX] = 1; sdw_dma_irq_flag = 1; } - } else { + break; + case ACP70_PCI_REV: + case ACP71_PCI_REV: if (ext_intr_stat1 & ACP70_P1_SDW_DMA_IRQ_MASK) { for (index = ACP70_P1_AUDIO2_RX_THRESHOLD; index <= ACP70_P1_AUDIO0_TX_THRESHOLD; index++) { @@ -166,6 +173,7 @@ static short int check_and_handle_sdw_dma_irq(struct acp63_dev_data *adata, u32 } } } + break; } return sdw_dma_irq_flag; } -- 2.34.1

2 1

Re: [PATCH v14 29/53] usb: host: xhci-plat: Set XHCI max interrupters if property is present
by Dennis Babcock 12 Feb '25

12 Feb '25

Hi Dennis Louis Babcock jr

1 0

Add HIFI Config support for QCM6490-IDP and QCS6490-RB3Gen2 Qualcomm boards
by GitHub pull_request - opened 12 Feb '25

12 Feb '25

alsa-project/alsa-ucm-conf pull request #508 was opened from mohsRafi: Add HIFI Config support for QCM6490-IDP and QCS6490-RB3Gen2 Qualcomm boards Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/508 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/508.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Add HIFI config support for QCM6490-IDP, QCS6490-RB3Gen2 Qualcomm boards
by GitHub pull_request - opened 12 Feb '25

12 Feb '25

alsa-project/alsa-ucm-conf pull request #507 was opened from mohsRafi: Add HIFI config support for QCM6490-IDP, QCS6490-RB3Gen2 Qualcomm boards Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/507 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/507.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

RE: [Bug 219743] [REGRESSION, BISECTED] ASUS GA402XY Headset mic stopped working after 6.12.2
by Kailang 12 Feb '25

12 Feb '25

Fixup headset MIC no function.

2 1

[PATCH V2 00/23] ASoC: amd: acp70: add soundwire and acp pdm support
by Vijendar Mukunda 11 Feb '25

11 Feb '25

This patch series includes below changes - Add Audio IO support for ACP7.0 and ACP7.1 platforms for SoundWire IO and ACP PDM controller combination. - Add common driver modules for ACP7.0 and ACP7.1 platforms (acp pci driver, Soundwire dma driver, pdm platform driver). - Add SoundWire generic machine driver changes for legacy stack (No DSP enabled) for ACP7.0 & ACP7.1 platforms. - Add SoundWire machines for ACP7.0 & ACP7.1 platforms. Changes since v1: - Change the code sequence for handling SoundWire wake interrupts. - Add new patch to restore host wake interrupt mask - Add new patch to enable ACP PME during ACP init sequence. - Change ACP PCI driver PM ops code sequence. Vijendar Mukunda (23): ASoC: amd: add register header file for ACP7.0 platform ASoC: amd: acp70: add acp pci driver for ACP7.0 and ACP7.1 platforms ASoC: amd: acp70: add acp init and de-init functions ASoC: amd: acp70: add logic for scanning acp child devices ASoC: amd: acp70: create platform devices for acp child nodes ASoC: amd: acp70: enable driver build for ACP7.0 platform ASoC: amd: acp70: add acp pdm platform driver ASoC: amd: acp70: add acp pdm driver dma ops and dai ops ASoC: amd: acp70: add acp soundwire dma driver ASoC: amd: update ACP7.0 KConfig option description ASoC: amd: acp70: add soundwire dma driver dma ops ASoC: amd: acp70: add acp ip interrupt handler ASoC: amd: acp70: add acp pdm driver pm ops ASoC: amd: acp70: add pm ops support for soundwire dma driver ASoC: amd: acp70: add acp driver pm ops support ASoC: amd: acp70: enable wake capability for acp pci driver ASoC: amd: acp70: add soundwire wake interrupt handling ASoC: amd: acp70: enable soundwire host wake irq mask ASoC: amd: acp70: enable acp pme enable during acp init sequence ASoC: amd: acp70: create a device node for soundwire machine driver ASoC: amd: acp: add machine driver changes for ACP7.0 and ACP7.1 platforms ASoC: amd: acp: add RT711, RT714 & RT1316 support for ACP7.0 platform ASoC: amd: acp: amd-acp70-acpi-match: Add rt722 support include/sound/acp70_chip_offset_byte.h | 484 +++++++++++++ sound/soc/amd/Kconfig | 12 + sound/soc/amd/Makefile | 1 + sound/soc/amd/acp/Makefile | 2 +- sound/soc/amd/acp/acp-sdw-legacy-mach.c | 16 + sound/soc/amd/acp/acp-sdw-mach-common.c | 34 + sound/soc/amd/acp/amd-acp70-acpi-match.c | 132 ++++ sound/soc/amd/acp/soc_amd_sdw_common.h | 11 + sound/soc/amd/acp70/Makefile | 9 + sound/soc/amd/acp70/acp70-pdm-dma.c | 463 +++++++++++++ sound/soc/amd/acp70/acp70-sdw-dma.c | 586 ++++++++++++++++ sound/soc/amd/acp70/acp70.h | 288 ++++++++ sound/soc/amd/acp70/pci-acp70.c | 833 +++++++++++++++++++++++ sound/soc/amd/mach-config.h | 1 + 14 files changed, 2871 insertions(+), 1 deletion(-) create mode 100644 include/sound/acp70_chip_offset_byte.h create mode 100644 sound/soc/amd/acp/amd-acp70-acpi-match.c create mode 100644 sound/soc/amd/acp70/Makefile create mode 100644 sound/soc/amd/acp70/acp70-pdm-dma.c create mode 100644 sound/soc/amd/acp70/acp70-sdw-dma.c create mode 100644 sound/soc/amd/acp70/acp70.h create mode 100644 sound/soc/amd/acp70/pci-acp70.c -- 2.34.1

4 35

[PATCH V3 00/25] ASoC: amd: Add support for ACP7.0 & ACP7.1 platforms
by Vijendar Mukunda 10 Feb '25

10 Feb '25

This patch series includes the below changes - Refactor existing ACP6.3 platform ACP PCI driver, SoundWire DMA driver code. - Add Audio IO support for ACP7.0 and ACP7.1 platforms for SoundWire IO and ACP PDM controller combination. - Add SoundWire generic machine driver changes for legacy stack (No DSP enabled) for ACP7.0 & ACP7.1 platforms. - Add SoundWire machines for ACP7.0 & ACP7.1 platforms. Changes since v2: - As per Mark's comment, to avoid code duplication drop separate folder(acp70) for ACP7.0 & ACP7.1 platforms and refactor existing ACP6.3 platform ACP PCI driver, SoundWire DMA driver code and add support for ACP7.0 & ACP7.1 platforms. - Add ACP PCI driver hw_ops for ACP6.3, ACP7.0 & ACP7.1 platforms. - Implement platform specific code in Soundwire DMA driver by adding acp pci revision id checks for ACP6.3/ACP7.0/ACP7.1 platforms. - Refactor existing ACP PCI driver Interrupt handler code. - Add new Soundwire machine for RT1320 Speaker + RT722 multi function codec combination. - Add machine driver quirks for Dell SKU's. Changes since v1: - Change the code sequence for handling SoundWire wake interrupts. - Add new patch to restore host wake interrupt mask - Add new patch to enable ACP PME during ACP init sequence. - Change ACP PCI driver PM ops code sequence. Vijendar Mukunda (25): ASoC: amd: ps: rename structure names, variable and other macros ASoC: amd: ps: use macro for ACP6.3 pci revision id ASoC: amd: ps: add acp pci driver hw_ops for acp6.3 platform ASoC: amd: ps: add callback functions for acp pci driver pm ops ASoC: amd: ps: add callback to read acp pin configuration ASoC: amd: ps: add soundwire dma irq thread callback ASoC: amd: ps: refactor soundwire dma interrupt handling ASoC: amd: ps: store acp revision id in SoundWire dma driver private data ASoC: amd: ps: refactor soundwire dma driver code ASoC: amd: ps: refactor soundwire dma interrupts enable/disable sequence ASoC: amd: ps: rename acp_restore_sdw_dma_config() function ASoC: amd: ps: add pci driver hw_ops for ACP7.0 & ACP7.1 variants ASoC: amd: ps: add pm ops related hw_ops for ACP7.0 & ACP7.1 platforms ASoC: amd: ps: add ACP7.0 & ACP7.1 specific soundwire dma driver changes ASoC: amd: ps: implement function to restore dma config for ACP7.0 platform ASoC: amd: ps: add soundwire dma interrupts handling for ACP7.0 platform ASoC: amd: ps: add soundwire wake interrupt handling ASoC: amd: ps: update module description ASoC: amd: ps: update file description and copyright year ASoC: amd: update Pink Sardine platform Kconfig description ASoC: amd: acp: add machine driver changes for ACP7.0 and ACP7.1 platforms ASoC: amd: acp: add RT711, RT714 & RT1316 support for ACP7.0 platform ASoC: amd: acp: amd-acp70-acpi-match: Add rt722 support ASoC: amd: acp: amd-acp70-acpi-match: Add RT1320 & RT722 combination soundwire machine ASoC: amd: amd_sdw: Add quirks for Dell SKU's sound/soc/amd/Kconfig | 10 +- sound/soc/amd/acp/Kconfig | 1 + sound/soc/amd/acp/Makefile | 2 +- sound/soc/amd/acp/acp-sdw-legacy-mach.c | 45 +++ sound/soc/amd/acp/acp-sdw-mach-common.c | 34 ++ sound/soc/amd/acp/amd-acp70-acpi-match.c | 160 ++++++++ sound/soc/amd/acp/soc_amd_sdw_common.h | 12 + sound/soc/amd/mach-config.h | 1 + sound/soc/amd/ps/Makefile | 2 +- sound/soc/amd/ps/acp63.h | 246 ++++++++++-- sound/soc/amd/ps/pci-ps.c | 422 +++++++++----------- sound/soc/amd/ps/ps-common.c | 475 +++++++++++++++++++++++ sound/soc/amd/ps/ps-pdm-dma.c | 6 +- sound/soc/amd/ps/ps-sdw-dma.c | 375 ++++++++++++++---- 14 files changed, 1440 insertions(+), 351 deletions(-) create mode 100644 sound/soc/amd/acp/amd-acp70-acpi-match.c create mode 100644 sound/soc/amd/ps/ps-common.c -- 2.34.1

3 28

[PATCH] ALSA: hda/conexant: Add quirk for HP ProBook 450 G4 mute LED
by John Veness 10 Feb '25

10 Feb '25

Allows the LED on the dedicated mute button on the HP ProBook 450 G4 laptop to change colour correctly. Signed-off-by: John Veness <john-linux(a)pelago.org.uk> --- sound/pci/hda/patch_conexant.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c index 538c37a78..84ab357b8 100644 --- a/sound/pci/hda/patch_conexant.c +++ b/sound/pci/hda/patch_conexant.c @@ -1080,6 +1080,7 @@ static const struct hda_quirk cxt5066_fixups[] = { SND_PCI_QUIRK(0x103c, 0x814f, "HP ZBook 15u G3", CXT_FIXUP_MUTE_LED_GPIO), SND_PCI_QUIRK(0x103c, 0x8174, "HP Spectre x360", CXT_FIXUP_HP_SPECTRE), SND_PCI_QUIRK(0x103c, 0x822e, "HP ProBook 440 G4", CXT_FIXUP_MUTE_LED_GPIO), + SND_PCI_QUIRK(0x103c, 0x8231, "HP ProBook 450 G4", CXT_FIXUP_MUTE_LED_GPIO), SND_PCI_QUIRK(0x103c, 0x828c, "HP EliteBook 840 G4", CXT_FIXUP_HP_DOCK), SND_PCI_QUIRK(0x103c, 0x8299, "HP 800 G3 SFF", CXT_FIXUP_HP_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x103c, 0x829a, "HP 800 G3 DM", CXT_FIXUP_HP_MIC_NO_PRESENCE), -- 2.48.1

1 0

alsaloop doesn't pass sound with libsamplerate resampling on raspberry pi 5
by GitHub issues - edited 10 Feb '25

10 Feb '25

alsa-project/alsa-utils issue #291 was edited from willangley: Hi alsa-utils team! I'm using `alsaloop`s on a Raspberry Pi 5 as part of a slightly ridiculous signal chain: * Yamaha P-525 keyboard * USB C-to-A cable * Raspberry Pi 5 * USB A-to-B cable * ESI U24XL * SPDIF in/out * Focusrite Clarett+ 4Pre * ... * MacBook Pro [Why? The analog Aux In/Aux Out on the keyboard have an always on loopback connection, which is undesirable when playing to a video meeting. The USB port has user controllable loopback.] Two alsaloop processes run on the Pi, one moving sound from the computer to the piano, one moving sound from the piano to the computer. Both run under `supervisord`. I've got them running at acceptable latency — RTL Utility says 40ms from my MacBook Pro. But I haven't been able to get any of the high quality resampling options working -- everything other than add/drop stops passing sound within a few seconds. I'm surprised; this Pi should be powerful enough to handle this. Any ideas how to troubleshoot it? I didn't see errors in logs at the default log level. Thank you! Will Issue URL : https://github.com/alsa-project/alsa-utils/issues/291 Repository URL: https://github.com/alsa-project/alsa-utils

1 0