- Alsa-devel - mailman.alsa-project.org

[PATCH AUTOSEL 6.4 16/54] ASoC: da7219: Check for failure reading AAD IRQ events
by Sasha Levin 13 Aug '23

13 Aug '23

From: Dmytro Maluka <dmy(a)semihalf.com> [ Upstream commit f0691dc16206f21b13c464434366e2cd632b8ed7 ] When handling an AAD interrupt, if IRQ events read failed (for example, due to i2c "Transfer while suspended" failure, i.e. when attempting to read it while DA7219 is suspended, which may happen due to a spurious AAD interrupt), the events array contains garbage uninitialized values. So instead of trying to interprete those values and doing any actions based on them (potentially resulting in misbehavior, e.g. reporting bogus events), refuse to handle the interrupt. Signed-off-by: Dmytro Maluka <dmy(a)semihalf.com> Link: https://lore.kernel.org/r/20230717193737.161784-3-dmy@semihalf.com Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/codecs/da7219-aad.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/da7219-aad.c b/sound/soc/codecs/da7219-aad.c index 07c5d9d354b6d..70c175744772c 100644 --- a/sound/soc/codecs/da7219-aad.c +++ b/sound/soc/codecs/da7219-aad.c @@ -361,11 +361,15 @@ static irqreturn_t da7219_aad_irq_thread(int irq, void *data) struct da7219_priv *da7219 = snd_soc_component_get_drvdata(component); u8 events[DA7219_AAD_IRQ_REG_MAX]; u8 statusa; - int i, report = 0, mask = 0; + int i, ret, report = 0, mask = 0; /* Read current IRQ events */ - regmap_bulk_read(da7219->regmap, DA7219_ACCDET_IRQ_EVENT_A, - events, DA7219_AAD_IRQ_REG_MAX); + ret = regmap_bulk_read(da7219->regmap, DA7219_ACCDET_IRQ_EVENT_A, + events, DA7219_AAD_IRQ_REG_MAX); + if (ret) { + dev_warn_ratelimited(component->dev, "Failed to read IRQ events: %d\n", ret); + return IRQ_NONE; + } if (!events[DA7219_AAD_IRQ_REG_A] && !events[DA7219_AAD_IRQ_REG_B]) return IRQ_NONE; -- 2.40.1

1 0

[PATCH AUTOSEL 6.4 15/54] ASoC: da7219: Flush pending AAD IRQ when suspending
by Sasha Levin 13 Aug '23

13 Aug '23

From: Dmytro Maluka <dmy(a)semihalf.com> [ Upstream commit 91e292917dad64ab8d1d5ca2ab3069ad9dac6f72 ] da7219_aad_suspend() disables jack detection, which should prevent generating new interrupts by DA7219 while suspended. However, there is a theoretical possibility that there is a pending interrupt generated just before suspending DA7219 and not handled yet, so the IRQ handler may still run after DA7219 is suspended. To prevent that, wait until the pending IRQ handling is done. This patch arose as an attempt to fix the following I2C failure occurring sometimes during system suspend or resume: [ 355.876211] i2c_designware i2c_designware.3: Transfer while suspended [ 355.876245] WARNING: CPU: 2 PID: 3576 at drivers/i2c/busses/i2c-designware-master.c:570 i2c_dw_xfer+0x411/0x440 ... [ 355.876462] Call Trace: [ 355.876468] <TASK> [ 355.876475] ? update_load_avg+0x1b3/0x615 [ 355.876484] __i2c_transfer+0x101/0x1d8 [ 355.876494] i2c_transfer+0x74/0x10d [ 355.876504] regmap_i2c_read+0x6a/0x9c [ 355.876513] _regmap_raw_read+0x179/0x223 [ 355.876521] regmap_raw_read+0x1e1/0x28e [ 355.876527] regmap_bulk_read+0x17d/0x1ba [ 355.876532] ? __wake_up+0xed/0x1bb [ 355.876542] da7219_aad_irq_thread+0x54/0x2c9 [snd_soc_da7219 5fb8ebb2179cf2fea29af090f3145d68ed8e2184] [ 355.876556] irq_thread+0x13c/0x231 [ 355.876563] ? irq_forced_thread_fn+0x5f/0x5f [ 355.876570] ? irq_thread_fn+0x4d/0x4d [ 355.876576] kthread+0x13a/0x152 [ 355.876581] ? synchronize_irq+0xc3/0xc3 [ 355.876587] ? kthread_blkcg+0x31/0x31 [ 355.876592] ret_from_fork+0x1f/0x30 [ 355.876601] </TASK> which indicates that the AAD IRQ handler is unexpectedly running when DA7219 is suspended, and as a result, is trying to read data from DA7219 over I2C and is hitting the I2C driver "Transfer while suspended" failure. However, with this patch the above failure is still reproducible. So this patch does not fix any real observed issue so far, but at least is useful for confirming that the above issue is not caused by a pending IRQ but rather looks like a DA7219 hardware issue with an IRQ unexpectedly generated after jack detection is already disabled. Signed-off-by: Dmytro Maluka <dmy(a)semihalf.com> Link: https://lore.kernel.org/r/20230717193737.161784-2-dmy@semihalf.com Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/codecs/da7219-aad.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/da7219-aad.c b/sound/soc/codecs/da7219-aad.c index 993a0d00bc48d..07c5d9d354b6d 100644 --- a/sound/soc/codecs/da7219-aad.c +++ b/sound/soc/codecs/da7219-aad.c @@ -910,6 +910,8 @@ void da7219_aad_suspend(struct snd_soc_component *component) } } } + + synchronize_irq(da7219_aad->irq); } void da7219_aad_resume(struct snd_soc_component *component) -- 2.40.1

1 0

"alsactl restore" does not load the driver state
by GitHub issues - edited 13 Aug '23

13 Aug '23

alsa-project/alsa-utils issue #229 was edited from YuGiOhJCJ: Hello, When I type "alsactl restore", it does not load the driver state. Steps to reproduce: 1. Open a first terminal dedicated to alsa-mixer 2. Open a second terminal where you will type the following commands 3. In the first terminal, press F4, set the audio volume for capture to 40 4. In the second terminal, type "sudo alsactl store" in order to save the driver state to /var/lib/alsa/asound.state 5. In the first terminal, set the audio volume for capture to 35 6. In the second terminal, type "sudo alsactl restore" in order to load the driver state from /var/lib/alsa/asound.state Expected results: I should see in the first terminal that the audio volume for capture is restored to 40. Current results: I see in the first terminal that the audio volume for capture is not restored to 40. It is still set to 35! How to fix that please? Thank you. Best regards. About my system: Packages: - alsa-lib-1.2.9 - alsa-plugins-1.2.7.1 - alsa-utils-1.2.9 Operating system: Slackware 14.2 (64-bit) Architecture: x86_64 Kernel: Linux 5.18.10 ![image](https://github.com/alsa-project/alsa-utils/assets/2247896/d4cc947f-b8db-493f-bf03-f18af9c821b3) Issue URL : https://github.com/alsa-project/alsa-utils/issues/229 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

"alsactl restore" does not load the driver state
by GitHub issues - opened 13 Aug '23

13 Aug '23

alsa-project/alsa-utils issue #229 was opened from YuGiOhJCJ: Hello, When I type "alsactl restore", it does not load the driver state. Steps to reproduce: 1. Open a first terminal dedicated to alsa-mixer 2. Open a second terminal where you will type the following commands 3. In the first terminal, press F4, set the audio volume for capture to 40 4. In the second terminal, type "sudo alsactl store" in order to save the driver state to /var/lib/alsa/asound.state 5. In the first terminal, set the audio volume for capture to 35 6. In the second terminal, type "sudo alsactl restore" in order to load the driver state to /var/lib/alsa/asound.state Expected results: I should see in the first terminal that the audio volume for capture is restored to 40. Current results: I see in the first terminal that the audio volume for capture is not restored to 40. It is still set to 35! How to fix that please? Thank you. Best regards. About my system: Packages: - alsa-lib-1.2.9 - alsa-plugins-1.2.7.1 - alsa-utils-1.2.9 Operating system: Slackware 14.2 (64-bit) Architecture: x86_64 Kernel: Linux 5.18.10 ![image](https://github.com/alsa-project/alsa-utils/assets/2247896/d4cc947f-b8db-493f-bf03-f18af9c821b3) Issue URL : https://github.com/alsa-project/alsa-utils/issues/229 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[PATCH v2 0/4] Device tree and config updates for the Librem 5 devkit
by Guido Günther 12 Aug '23

12 Aug '23

The device tree updates ensure the A53 cores don't get powered off and fix a DT warning. This isn't testable with the arm64 default config unless we enable the rsi wifi modules too so do this as well. While at that include a binding file update. This is against next-20230809 that include David's option,gtm601 conversion. v2: - drop "dt-bindings: mmc: Fix reference to pwr-seq-simple" already picked up by Ulf Hansson, thanks! - add acked-by from Conor Dooley, thanks! - rework sdio changes as proposed by Sherry Sun Guido Günther (4): dt-bindings: sound: gtm601: Add description arm64: dts: imx8mq-librem5-devkit: Mark buck2 as always on arm64: dts: imx8mq-librem5-devkit: Drop power-supply arm64: defconfig: Enable Redpine 91X wlan driver .../bindings/sound/option,gtm601.yaml | 6 +++-- .../dts/freescale/imx8mq-librem5-devkit.dts | 26 ++++++++----------- arch/arm64/configs/defconfig | 1 + 3 files changed, 16 insertions(+), 17 deletions(-) -- 2.40.1

3 8

[tiwai-sound:test/pcm-iov_iter 3/25] sound/core/memory.c:108:53: warning: passing argument 2 of 'copy_from_iter' makes integer from pointer without a cast
by kernel test robot 12 Aug '23

12 Aug '23

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git test/pcm-iov_iter head: da1be13e050f24d088d24fd65517d56f27a2eeb1 commit: 516e284c8b17a5129fcfbfb1f2f4e11093e13d3f [3/25] ALSA: core: Add memory copy helpers between iov_iter and iomem config: i386-randconfig-r033-20230812 (https://download.01.org/0day-ci/archive/20230812/202308120931.Aj1gaY7K-lkp@…) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230812/202308120931.Aj1gaY7K-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202308120931.Aj1gaY7K-lkp@intel.com/ All warnings (new ones prefixed by >>): sound/core/memory.c: In function 'copy_from_iter_toio': >> sound/core/memory.c:108:53: warning: passing argument 2 of 'copy_from_iter' makes integer from pointer without a cast [-Wint-conversion] 108 | return !copy_from_iter((void __force *)dst, src, count) ? -EFAULT : 0; | ^~~ | | | struct iov_iter * In file included from include/sound/pcm.h:19, from sound/core/memory.c:12: include/linux/uio.h:199:42: note: expected 'size_t' {aka 'unsigned int'} but argument is of type 'struct iov_iter *' 199 | size_t copy_from_iter(void *addr, size_t bytes, struct iov_iter *i) | ~~~~~~~^~~~~ >> sound/core/memory.c:108:58: warning: passing argument 3 of 'copy_from_iter' makes pointer from integer without a cast [-Wint-conversion] 108 | return !copy_from_iter((void __force *)dst, src, count) ? -EFAULT : 0; | ^~~~~ | | | size_t {aka unsigned int} include/linux/uio.h:199:66: note: expected 'struct iov_iter *' but argument is of type 'size_t' {aka 'unsigned int'} 199 | size_t copy_from_iter(void *addr, size_t bytes, struct iov_iter *i) | ~~~~~~~~~~~~~~~~~^ vim +/copy_from_iter +108 sound/core/memory.c 93 94 /** 95 * copy_from_iter_toio - copy data from iov_iter to mmio-space 96 * @dst: the destination pointer on mmio-space 97 * @src: the source iov_iter 98 * @count: the data size to copy in bytes 99 * 100 * Copies the data from iov_iter to mmio-space. 101 * Only the single segment iov_iter is assumed for now. 102 * 103 * Return: Zero if successful, or non-zero on failure. 104 */ 105 int copy_from_iter_toio(void __iomem *dst, struct iov_iter *src, size_t count) 106 { 107 #if defined(__i386__) || defined(CONFIG_SPARC32) > 108 return !copy_from_iter((void __force *)dst, src, count) ? -EFAULT : 0; -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

MSI x570s Carbon Max WiFi ALC 4080
by GitHub issues - edited 11 Aug '23

11 Aug '23

alsa-project/alsa-ucm-conf issue #338 was edited from zpackrat: Fedora 38 patched to current, issue has existed for months. Rear output jacks for Center/Sub and Rear Speakers are reversed. I use a 5.1 speaker setup. When I run sound tests in the gnome audio settings the issue is verifiable. Also audio that requires center channel for dialogue has issues. This is specifically the rear audio I/O ports. Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/338 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

MSI x570s Carbon Max WiFi ALC 4080
by GitHub issues - opened 11 Aug '23

11 Aug '23

alsa-project/alsa-ucm-conf issue #338 was opened from zpackrat: Fedora 38 patched to current, issue has existed for months. Rear output jacks for Center/Sub and Rear Speakers are reversed. I use a 5.1 speaker setup. When I run sound tests in the gnome audio settings the issue is verifiable. Also audio that requires center channel for dialogue has issues. Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/338 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[RFC] pcm: Add MSBITS subformat options
by GitHub pull_request - edited 11 Aug '23

11 Aug '23

alsa-project/alsa-lib pull request #342 was edited from crojewsk-intel: Improve granularity of format selection for S32/U32 formats by adding masks representing 20, 24 and 32 most significant bits. As a preparation step introduce `snd_pcm_subformat_value()` for easy name-to-subformat conversions. While at it, fix few warnings that pop up in subformat-related code during compilation. Request URL : https://github.com/alsa-project/alsa-lib/pull/342 Patch URL : https://github.com/alsa-project/alsa-lib/pull/342.patch Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[RFC] pcm: Add MSBITS subformat options
by GitHub pull_request - edited 11 Aug '23

11 Aug '23

alsa-project/alsa-lib pull request #342 was edited from crojewsk-intel: Improve granularity of format selection for S32/U32 formats by adding masks representing 20 and 24 most significant bits. As a preparation step introduce `snd_pcm_subformat_value()` for easy name-to-subformat conversions. While at it, fix few warnings that pop up in subformat-related code during compilation. Request URL : https://github.com/alsa-project/alsa-lib/pull/342 Patch URL : https://github.com/alsa-project/alsa-lib/pull/342.patch Repository URL: https://github.com/alsa-project/alsa-lib

1 0