- Alsa-devel - mailman.alsa-project.org

Alsa Lib segfaults when built statically
by GitHub issues - edited 04 Sep '23

04 Sep '23

alsa-project/alsa-lib issue #349 was edited from cybersoulK: I am building a game that uses alsa. All of my linux players segfault. This has been going for over 1 year. Alsa-lib is built statically on a ubuntu machine with the following commands: ``` git clone https://github.com/alsa-project/alsa-lib cd alsa-lib apt-get update apt-get install libtool apt-get install make apt install autoconf autoreconf -i ./configure --disable-shared make ``` Then i use libasound.a to build my Rust executable (On my mac machine). I do the same process to build openssl for linux and it works great. So There definitely is an issue when building alsa lib statically. One of my players was able to provide me with a core dump that might be helpful to track down the fault: <img width="770" alt="image" src="https://github.com/alsa-project/alsa-lib/assets/102260392/7390b851-47a1-4e5…"> [coredump.txt](https://github.com/alsa-project/alsa-lib/files/12508784/cored… Issue URL : https://github.com/alsa-project/alsa-lib/issues/349 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Alsa Lib segfaults when built statically
by GitHub issues - edited 04 Sep '23

04 Sep '23

alsa-project/alsa-lib issue #349 was edited from cybersoulK: I am building a game that uses alsa. All of my linux players segfault. This has been going for over 1 year. Alsa-lib is built statically on a ubuntu machine with the following commands: ``` git clone https://github.com/alsa-project/alsa-lib cd alsa-lib apt-get update apt-get install libtool apt-get install make apt install autoconf autoreconf -i ./configure --disable-shared make ``` Then i use libasound.a to build my Rust executable (On my mac machine). I do the same process to build openssl for linux and it works great. So There definitely is an issue when building alsa lib statically. One of my players was able to provide me with a core dump that might be helpful to track the fault: <img width="770" alt="image" src="https://github.com/alsa-project/alsa-lib/assets/102260392/7390b851-47a1-4e5…"> [coredump.txt](https://github.com/alsa-project/alsa-lib/files/12508784/cored… Issue URL : https://github.com/alsa-project/alsa-lib/issues/349 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Alsa Lib segfaults when built statically
by GitHub issues - edited 04 Sep '23

04 Sep '23

alsa-project/alsa-lib issue #349 was edited from cybersoulK: I am building a game that uses alsa. All of my linux players segfault. Alsa Lib is built statically on a ubuntu machine with the following commands: ``` git clone https://github.com/alsa-project/alsa-lib cd alsa-lib apt-get update apt-get install libtool apt-get install make apt install autoconf autoreconf -i ./configure --disable-shared make ``` Then i use libasound.a to build my Rust executable (On my mac machine). I do the same process to build openssl for linux and it works great. So There definitely is an issue when building alsa lib statically. One of my players was able to provide me with a core dump that might be helpful to track the fault: <img width="770" alt="image" src="https://github.com/alsa-project/alsa-lib/assets/102260392/7390b851-47a1-4e5…"> [coredump.txt](https://github.com/alsa-project/alsa-lib/files/12508784/cored… Issue URL : https://github.com/alsa-project/alsa-lib/issues/349 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Alsa Lib segfaults when built statically
by GitHub issues - edited 04 Sep '23

04 Sep '23

alsa-project/alsa-lib issue #349 was edited from cybersoulK: I am building a game that uses alsa. All of my linux players executables segfault. Alsa Lib is built statically on a ubuntu machine with the following commands: ``` git clone https://github.com/alsa-project/alsa-lib cd alsa-lib apt-get update apt-get install libtool apt-get install make apt install autoconf autoreconf -i ./configure --disable-shared make ``` Then i use libasound.a to build my Rust executable (On my mac machine). I do the same process to build openssl for linux and it works great. So There definitely is an issue when building alsa lib statically. One of my players was able to provide me with a core dump that might be helpful to track the fault: <img width="770" alt="image" src="https://github.com/alsa-project/alsa-lib/assets/102260392/7390b851-47a1-4e5…"> [coredump.txt](https://github.com/alsa-project/alsa-lib/files/12508784/cored… Issue URL : https://github.com/alsa-project/alsa-lib/issues/349 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Alsa Lib segfaults when built statically
by GitHub issues - opened 04 Sep '23

04 Sep '23

alsa-project/alsa-lib issue #349 was opened from cybersoulK: I building a game that uses alsa for linux. All of my linux players executables segfault. Alsa Lib is built statically on a ubuntu machine with the following commands: ``` git clone https://github.com/alsa-project/alsa-lib cd alsa-lib apt-get update apt-get install libtool apt-get install make apt install autoconf autoreconf -i ./configure --disable-shared make ``` Then i use libasound.a to build my Rust executable (On my mac machine). I do the same process to build openssl for linux and it works great. So There definitely is an issue when building alsa lib statically. One of my players was able to provide me with a core dump that might be helpful to track the fault: <img width="770" alt="image" src="https://github.com/alsa-project/alsa-lib/assets/102260392/7390b851-47a1-4e5…"> [coredump.txt](https://github.com/alsa-project/alsa-lib/files/12508784/cored… Issue URL : https://github.com/alsa-project/alsa-lib/issues/349 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH 0/2][RFC] Refactor snd primitives refcounters
by cujomalainey＠chromium.org 04 Sep '23

04 Sep '23

From: Curtis Malainey <cujomalainey(a)chromium.org> As previously identified in [1] there are some issues with how kobjs are handled in sound/core. The solution provided in [2] is a workaround for the issues to fix the failures. This series is a first attempt at the larger refactor needed to properly handle the objects. [1] https://mailman.alsa-project.org/hyperkitty/list/alsa-devel@alsa-project.or… [2] https://mailman.alsa-project.org/hyperkitty/list/alsa-devel@alsa-project.or… Curtis Malainey (2): ALSA: core: add snd_device_init ALSA: core: split control primitives out of snd_card include/sound/control.h | 1 + include/sound/core.h | 34 +-- sound/core/control.c | 330 +++++++++++++---------- sound/core/control_compat.c | 8 +- sound/core/control_led.c | 18 +- sound/core/init.c | 33 +-- sound/pci/hda/hda_codec.c | 3 +- sound/soc/intel/atom/sst-atom-controls.c | 8 +- sound/soc/soc-card.c | 2 +- sound/usb/media.c | 2 +- 10 files changed, 249 insertions(+), 190 deletions(-) -- 2.42.0.rc1.204.g551eb34607-goog

5 9

[PATCH] ALSA: scarlett2: Fix a potential memory leak in scarlett2_init_notify()
by Christophe JAILLET 03 Sep '23

03 Sep '23

If kmalloc() fails, we should release 'mixer->urb'. Fixes: 9e4d5c1be21f ("ALSA: usb-audio: Scarlett Gen 2 mixer interface") Signed-off-by: Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> --- sound/usb/mixer_scarlett_gen2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/usb/mixer_scarlett_gen2.c b/sound/usb/mixer_scarlett_gen2.c index 9d11bb08667e..a439c7f64b2e 100644 --- a/sound/usb/mixer_scarlett_gen2.c +++ b/sound/usb/mixer_scarlett_gen2.c @@ -4060,8 +4060,10 @@ static int scarlett2_init_notify(struct usb_mixer_interface *mixer) return -ENOMEM; transfer_buffer = kmalloc(private->wMaxPacketSize, GFP_KERNEL); - if (!transfer_buffer) + if (!transfer_buffer) { + usb_free_urb(mixer->urb); return -ENOMEM; + } usb_fill_int_urb(mixer->urb, dev, pipe, transfer_buffer, private->wMaxPacketSize, -- 2.34.1

2 2

1.2.10: control.h missing definitions for snd_ump_endpoint_info_t and snd_ump_block_info_t
by GitHub issues - opened 02 Sep '23

02 Sep '23

alsa-project/alsa-lib issue #348 was opened from ajakk: When configured with raw MIDI support, `control.h` declares: ``` int snd_ctl_ump_endpoint_info(snd_ctl_t *ctl, snd_ump_endpoint_info_t *info); int snd_ctl_ump_block_info(snd_ctl_t *ctl, snd_ump_block_info_t *info); ``` However, it doesn't seem that the `snd_ump*` types are defined here, and this results in build failures in applications compiling against alsa-lib-1.2.10. [For example](https://bugs.gentoo.org/913521) ([build log](https://913521.bugs.gentoo.org/attachment.cgi?id=869245)): ``` [77/90] /usr/bin/x86_64-pc-linux-gnu-g++ -I/var/tmp/portage/x11-misc/polybar-3.6.3-r3/work/polybar-3.6.3/include -I/var/tmp/portage/x11-misc/polybar-3.6.3-r3/work/polybar-3.6.3_build/generated-sources -isystem /usr/include/cairo -isystem /usr/include/libpng16 -isystem /usr/include/freetype2 -isystem /usr/include/pixman-1 -isystem /var/tmp/portage/x11-misc/polybar-3.6.3-r3/work/polybar-3.6.3/lib/xpp/include -isystem /var/tmp/portage/x11-misc/polybar-3.6.3-r3/work/polybar-3.6.3_build/lib/xpp/generated-sources/include -O2 -pipe -march=native -fno-diagnostics-color -std=c++14 -fno-diagnostics-color -Wall -Wextra -Wpedantic -Wsuggest-override -MD -MT bin/CMakeFiles/poly.dir/adapters/alsa/control.cpp.o -MF bin/CMakeFiles/poly.dir/adapters/alsa/control.cpp.o.d -o bin/CMakeFiles/poly.dir/adapters/alsa/control.cpp.o -c /var/tmp/portage/x11-misc/polybar-3.6.3-r3/work/polybar-3.6.3/src/adapters/alsa/control.cpp FAILED: bin/CMakeFiles/poly.dir/adapters/alsa/control.cpp.o /usr/bin/x86_64-pc-linux-gnu-g++ -I/var/tmp/portage/x11-misc/polybar-3.6.3-r3/work/polybar-3.6.3/include -I/var/tmp/portage/x11-misc/polybar-3.6.3-r3/work/polybar-3.6.3_build/generated-sources -isystem /usr/include/cairo -isystem /usr/include/libpng16 -isystem /usr/include/freetype2 -isystem /usr/include/pixman-1 -isystem /var/tmp/portage/x11-misc/polybar-3.6.3-r3/work/polybar-3.6.3/lib/xpp/include -isystem /var/tmp/portage/x11-misc/polybar-3.6.3-r3/work/polybar-3.6.3_build/lib/xpp/generated-sources/include -O2 -pipe -march=native -fno-diagnostics-color -std=c++14 -fno-diagnostics-color -Wall -Wextra -Wpedantic -Wsuggest-override -MD -MT bin/CMakeFiles/poly.dir/adapters/alsa/control.cpp.o -MF bin/CMakeFiles/poly.dir/adapters/alsa/control.cpp.o.d -o bin/CMakeFiles/poly.dir/adapters/alsa/control.cpp.o -c /var/tmp/portage/x11-misc/polybar-3.6.3-r3/work/polybar-3.6.3/src/adapters/alsa/control.cpp In file included from /var/tmp/portage/x11-misc/polybar-3.6.3-r3/work/polybar-3.6.3/include/adapters/alsa/generic.hpp:37, from /var/tmp/portage/x11-misc/polybar-3.6.3-r3/work/polybar-3.6.3/src/adapters/alsa/control.cpp:2: /usr/include/alsa/control.h:417:47: error: ‘snd_ump_endpoint_info_t’ has not been declared 417 | int snd_ctl_ump_endpoint_info(snd_ctl_t *ctl, snd_ump_endpoint_info_t *info); | ^~~~~~~~~~~~~~~~~~~~~~~ /usr/include/alsa/control.h:418:44: error: ‘snd_ump_block_info_t’ has not been declared 418 | int snd_ctl_ump_block_info(snd_ctl_t *ctl, snd_ump_block_info_t *info); | ^~~~~~~~~~~~~~~~~~~~ ``` Issue URL : https://github.com/alsa-project/alsa-lib/issues/348 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH 1/2] ALSA: pcm: Fix error checks of default read/write copy ops
by Takashi Iwai 02 Sep '23

02 Sep '23

copy_from/to_iter() returns the actually copied bytes, and the more correct check should be to compare with the given bytes, instead of zero-check. Fixes: cf393babb37a ("ALSA: pcm: Add copy ops with iov_iter") Reported-by: Al Viro <viro(a)zeniv.linux.org.uk> Closes: https://lore.kernel.org/r/20230902053044.GJ3390869@ZenIV Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/core/pcm_lib.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c index 4859fb1caec9..a11cd7d6295f 100644 --- a/sound/core/pcm_lib.c +++ b/sound/core/pcm_lib.c @@ -1992,8 +1992,8 @@ static int default_write_copy(struct snd_pcm_substream *substream, int channel, unsigned long hwoff, struct iov_iter *iter, unsigned long bytes) { - if (!copy_from_iter(get_dma_ptr(substream->runtime, channel, hwoff), - bytes, iter)) + if (copy_from_iter(get_dma_ptr(substream->runtime, channel, hwoff), + bytes, iter) != bytes) return -EFAULT; return 0; } @@ -2025,8 +2025,8 @@ static int default_read_copy(struct snd_pcm_substream *substream, int channel, unsigned long hwoff, struct iov_iter *iter, unsigned long bytes) { - if (!copy_to_iter(get_dma_ptr(substream->runtime, channel, hwoff), - bytes, iter)) + if (copy_to_iter(get_dma_ptr(substream->runtime, channel, hwoff), + bytes, iter) != bytes) return -EFAULT; return 0; } -- 2.35.3

1 1

[PATCH v2 00/25] ALSA: Generic PCM copy ops using iov_iter
by Takashi Iwai 02 Sep '23

02 Sep '23

Hi, this is a v2 patch set for cleaning up the PCM copy ops using iov_iter to deal with kernel / user-space pointers consistently. v1->v2: * The error condition checks of copy_to/from_iter() are changed to be more strictly * Put Acked and Reviewed tags * The indents in the patch in dmaengine was slightly changed v1: https://lore.kernel.org/r/20230814115523.15279-1-tiwai@suse.de Takashi === Cc: Alexander Viro <viro(a)zeniv.linux.org.uk> Cc: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> Cc: Andrey Utkin <andrey_utkin(a)fastmail.com> Cc: Anton Sviridenko <anton(a)corp.bluecherry.net> Cc: Arnaud Pouliquen <arnaud.pouliquen(a)foss.st.com> Cc: Banajit Goswami <bgoswami(a)quicinc.com> Cc: Bluecherry Maintainers <maintainers(a)bluecherrydvr.com> Cc: Claudiu Beznea <claudiu.beznea(a)microchip.com> Cc: Ismael Luceno <ismael(a)iodev.co.uk> Cc: Lars-Peter Clausen <lars(a)metafoo.de> Cc: Mark Brown <broonie(a)kernel.org> Cc: Mauro Carvalho Chehab <mchehab(a)kernel.org> Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko(a)epam.com> Cc: Olivier Moysan <olivier.moysan(a)foss.st.com> Cc: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> Cc: linux-media(a)vger.kernel.org Cc: xen-devel(a)lists.xenproject.org === Takashi Iwai (25): iov_iter: Export import_ubuf() ALSA: pcm: Add copy ops with iov_iter ALSA: core: Add memory copy helpers between iov_iter and iomem ALSA: dummy: Convert to generic PCM copy ops ALSA: gus: Convert to generic PCM copy ops ALSA: emu8000: Convert to generic PCM copy ops ALSA: es1938: Convert to generic PCM copy ops ALSA: korg1212: Convert to generic PCM copy ops ALSA: nm256: Convert to generic PCM copy ops ALSA: rme32: Convert to generic PCM copy ops ALSA: rme96: Convert to generic PCM copy ops ALSA: hdsp: Convert to generic PCM copy ops ALSA: rme9652: Convert to generic PCM copy ops ALSA: sh: Convert to generic PCM copy ops ALSA: xen: Convert to generic PCM copy ops ALSA: pcmtest: Update comment about PCM copy ops media: solo6x10: Convert to generic PCM copy ops ASoC: component: Add generic PCM copy ops ASoC: mediatek: Convert to generic PCM copy ops ASoC: qcom: Convert to generic PCM copy ops ASoC: dmaengine: Convert to generic PCM copy ops ASoC: dmaengine: Use iov_iter for process callback, too ALSA: doc: Update description for the new PCM copy ops ASoC: pcm: Drop obsoleted PCM copy_user ops ALSA: pcm: Drop obsoleted PCM copy_user and copy_kernel ops .../kernel-api/writing-an-alsa-driver.rst | 58 ++++------- drivers/media/pci/solo6x10/solo6x10-g723.c | 39 ++------ include/sound/dmaengine_pcm.h | 2 +- include/sound/pcm.h | 13 ++- include/sound/soc-component.h | 14 +-- lib/iov_iter.c | 1 + sound/core/memory.c | 56 +++++++++-- sound/core/pcm_lib.c | 95 ++++++++++--------- sound/core/pcm_native.c | 2 +- sound/drivers/dummy.c | 12 +-- sound/drivers/pcmtest.c | 2 +- sound/isa/gus/gus_pcm.c | 23 +---- sound/isa/sb/emu8000_pcm.c | 74 ++++----------- sound/pci/es1938.c | 30 +----- sound/pci/korg1212/korg1212.c | 50 +++------- sound/pci/nm256/nm256.c | 42 ++------ sound/pci/rme32.c | 50 +++------- sound/pci/rme96.c | 42 ++------ sound/pci/rme9652/hdsp.c | 42 ++------ sound/pci/rme9652/rme9652.c | 46 ++------- sound/sh/sh_dac_audio.c | 25 +---- sound/soc/atmel/mchp-pdmc.c | 2 +- sound/soc/mediatek/common/mtk-btcvsd.c | 27 ++---- sound/soc/qcom/lpass-platform.c | 13 +-- sound/soc/soc-component.c | 16 ++-- sound/soc/soc-generic-dmaengine-pcm.c | 18 ++-- sound/soc/soc-pcm.c | 4 +- sound/soc/stm/stm32_sai_sub.c | 2 +- sound/xen/xen_snd_front_alsa.c | 56 +++-------- 29 files changed, 269 insertions(+), 587 deletions(-) -- 2.35.3

3 30