- Alsa-devel - mailman.alsa-project.org

MSI x570s Carbon Max WiFi ALC 4080
by GitHub issues - opened 11 Aug '23

11 Aug '23

alsa-project/alsa-ucm-conf issue #338 was opened from zpackrat: Fedora 38 patched to current, issue has existed for months. Rear output jacks for Center/Sub and Rear Speakers are reversed. I use a 5.1 speaker setup. When I run sound tests in the gnome audio settings the issue is verifiable. Also audio that requires center channel for dialogue has issues. Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/338 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[RFC] pcm: Add MSBITS subformat options
by GitHub pull_request - edited 11 Aug '23

11 Aug '23

alsa-project/alsa-lib pull request #342 was edited from crojewsk-intel: Improve granularity of format selection for S32/U32 formats by adding masks representing 20, 24 and 32 most significant bits. As a preparation step introduce `snd_pcm_subformat_value()` for easy name-to-subformat conversions. While at it, fix few warnings that pop up in subformat-related code during compilation. Request URL : https://github.com/alsa-project/alsa-lib/pull/342 Patch URL : https://github.com/alsa-project/alsa-lib/pull/342.patch Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[RFC] pcm: Add MSBITS subformat options
by GitHub pull_request - edited 11 Aug '23

11 Aug '23

alsa-project/alsa-lib pull request #342 was edited from crojewsk-intel: Improve granularity of format selection for S32/U32 formats by adding masks representing 20 and 24 most significant bits. As a preparation step introduce `snd_pcm_subformat_value()` for easy name-to-subformat conversions. While at it, fix few warnings that pop up in subformat-related code during compilation. Request URL : https://github.com/alsa-project/alsa-lib/pull/342 Patch URL : https://github.com/alsa-project/alsa-lib/pull/342.patch Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH v1] ALSA: hda/cs8409: Support new Dell Dolphin Variants
by Stefan Binding 11 Aug '23

11 Aug '23

Add 4 new Dell Dolphin Systems, same configuration as older systems. Signed-off-by: Stefan Binding <sbinding(a)opensource.cirrus.com> --- sound/pci/hda/patch_cs8409-tables.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/pci/hda/patch_cs8409-tables.c b/sound/pci/hda/patch_cs8409-tables.c index b288874e401e..36b411d1a960 100644 --- a/sound/pci/hda/patch_cs8409-tables.c +++ b/sound/pci/hda/patch_cs8409-tables.c @@ -550,6 +550,10 @@ const struct snd_pci_quirk cs8409_fixup_tbl[] = { SND_PCI_QUIRK(0x1028, 0x0C50, "Dolphin", CS8409_DOLPHIN), SND_PCI_QUIRK(0x1028, 0x0C51, "Dolphin", CS8409_DOLPHIN), SND_PCI_QUIRK(0x1028, 0x0C52, "Dolphin", CS8409_DOLPHIN), + SND_PCI_QUIRK(0x1028, 0x0C73, "Dolphin", CS8409_DOLPHIN), + SND_PCI_QUIRK(0x1028, 0x0C75, "Dolphin", CS8409_DOLPHIN), + SND_PCI_QUIRK(0x1028, 0x0C7D, "Dolphin", CS8409_DOLPHIN), + SND_PCI_QUIRK(0x1028, 0x0C7F, "Dolphin", CS8409_DOLPHIN), {} /* terminator */ }; -- 2.34.1

2 1

[PATCH v2 0/3] soundwire: allow for more than 8 devices, keep IDA for wake-capable devices
by Bard Liao 11 Aug '23

11 Aug '23

This series suggests a hybrid strategy for device number allocation, where only wake-capable devices use a system-unique Device Number which will be used on LunarLake to handle wake-ups using the HDaudio WAKEEN and WAKESTS. Pierre-Louis Bossart (3): soundwire: extend parameters of new_peripheral_assigned() callback soundwire: bus: add callbacks for device_number allocation soundwire: intel_auxdevice: add hybrid IDA-based device_number allocation v2: - Move the device numver allocation from bus.c to intel_auxdevice.c - List the codecs with wake capability in a quirk table, and assign device number according to that quirk table. drivers/soundwire/bus.c | 18 +++--- drivers/soundwire/intel_auxdevice.c | 85 ++++++++++++++++++++++++++--- include/linux/soundwire/sdw.h | 12 ++-- include/linux/soundwire/sdw_intel.h | 7 +++ 4 files changed, 99 insertions(+), 23 deletions(-) -- 2.25.1

2 4

[PATCH 0/2] soundwire: improve pm_runtime handling
by Bard Liao 11 Aug '23

11 Aug '23

This patchset improves the pm_runtime behavior in rare corner cases identified by the Intel CI in the last 6 months. a) in stress-tests, it's not uncommon to see the following type of warnings when the codec reports as ATTACHED "rt711 sdw:0:025d:0711:00: runtime PM trying to activate child device sdw:0:025d:0711:00 but parent (sdw-master-0) is not active" This warning was not correlated with any functional issue, but it exposed a design issue on when to enable pm_runtime. The recommended practice in the pm_runtime documentation is to keep the devices in 'suspended' mode and mark them as 'active' when they are really functional. Pierre-Louis Bossart (2): soundwire: intel_auxdevice: enable pm_runtime earlier on startup soundWire: intel_auxdevice: resume 'sdw-master' on startup and system resume drivers/soundwire/intel_auxdevice.c | 27 +++++++++++++++++++-------- 1 file changed, 19 insertions(+), 8 deletions(-) -- 2.25.1

3 5

[PATCH -next] ASoC: SOF: Intel: Remove duplicated include in lnl.c
by Yang Li 10 Aug '23

10 Aug '23

./sound/soc/sof/intel/lnl.c: hda.h is included more than once. Signed-off-by: Yang Li <yang.lee(a)linux.alibaba.com> --- sound/soc/sof/intel/lnl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/sof/intel/lnl.c b/sound/soc/sof/intel/lnl.c index 3d919b0b6891..db94b45e53af 100644 --- a/sound/soc/sof/intel/lnl.c +++ b/sound/soc/sof/intel/lnl.c @@ -16,7 +16,6 @@ #include "hda-ipc.h" #include "../sof-audio.h" #include "mtl.h" -#include "hda.h" #include <sound/hda-mlink.h> /* LunarLake ops */ -- 2.20.1.7.g153144c

3 2

[PATCH v1 0/5] Device tree and config updates for the Librem 5 devkit
by Guido Günther 10 Aug '23

10 Aug '23

The device tree updates ensure the A53 don't get powered off and fix a DT warning. This isn't testable with the arm64 default config unless we enable the rsi wifi modules too so do this as well. While at that include two binding file updates. This is against next-20230809 that include David's option,gtm601 conversion. Guido Günther (5): dt-bindings: sound: gtm601: Add description dt-bindings: mmc: Fix reference to pwr-seq-simple arm64: dts: imx8mq-librem5-devkit: Mark buck2 as always on arm64: dts: imx8mq-librem5-devkit: Drop power-supply arm64: defconfig: Enable Redpine 91X wlan driver .../devicetree/bindings/mmc/mmc-controller.yaml | 2 +- .../devicetree/bindings/sound/option,gtm601.yaml | 6 ++++-- .../boot/dts/freescale/imx8mq-librem5-devkit.dts | 14 +++++--------- arch/arm64/configs/defconfig | 1 + 4 files changed, 11 insertions(+), 12 deletions(-) -- 2.40.1

6 10

[PATCH] ASoC: rt715: Add software reset in io init
by Jack Yu 10 Aug '23

10 Aug '23

Add software reset before setting preset registers to make sure all the registers are the default value before preset. Signed-off-by: Jack Yu <jack.yu(a)realtek.com> --- sound/soc/codecs/rt715.c | 56 ++++++++++++++++++++++++++++++++++++++++ sound/soc/codecs/rt715.h | 7 +++++ 2 files changed, 63 insertions(+) diff --git a/sound/soc/codecs/rt715.c b/sound/soc/codecs/rt715.c index 79416bb48814..c95f481cd235 100644 --- a/sound/soc/codecs/rt715.c +++ b/sound/soc/codecs/rt715.c @@ -52,6 +52,60 @@ static int rt715_index_write(struct regmap *regmap, unsigned int reg, return ret; } +static int rt715_index_write_nid(struct regmap *regmap, + unsigned int nid, unsigned int reg, unsigned int value) +{ + int ret; + unsigned int addr = ((RT715_PRIV_INDEX_W_H_2 | nid) << 8) | reg; + + ret = regmap_write(regmap, addr, value); + if (ret < 0) + pr_err("Failed to set private value: %06x <= %04x ret=%d\n", + addr, value, ret); + + return ret; +} + +static int rt715_index_read_nid(struct regmap *regmap, + unsigned int nid, unsigned int reg, unsigned int *value) +{ + int ret; + unsigned int addr = ((RT715_PRIV_INDEX_W_H_2 | nid) << 8) | reg; + + *value = 0; + ret = regmap_read(regmap, addr, value); + if (ret < 0) + pr_err("Failed to get private value: %06x => %04x ret=%d\n", + addr, *value, ret); + + return ret; +} + +static int rt715_index_update_bits(struct regmap *regmap, unsigned int nid, + unsigned int reg, unsigned int mask, unsigned int val) +{ + unsigned int tmp, orig; + int ret; + + ret = rt715_index_read_nid(regmap, nid, reg, &orig); + if (ret < 0) + return ret; + + tmp = orig & ~mask; + tmp |= val & mask; + + return rt715_index_write_nid(regmap, nid, reg, tmp); +} + +static void rt715_reset(struct regmap *regmap) +{ + regmap_write(regmap, RT715_FUNC_RESET, 0); + rt715_index_update_bits(regmap, RT715_VENDOR_REGISTERS, + RT715_VD_CLEAR_CTRL, RT715_CLEAR_HIDDEN_REG, + RT715_CLEAR_HIDDEN_REG); +} + + static void rt715_get_gain(struct rt715_priv *rt715, unsigned int addr_h, unsigned int addr_l, unsigned int val_h, unsigned int *r_val, unsigned int *l_val) @@ -1040,6 +1094,8 @@ int rt715_io_init(struct device *dev, struct sdw_slave *slave) pm_runtime_get_noresume(&slave->dev); + rt715_reset(rt715->regmap); + /* Mute nid=08h/09h */ regmap_write(rt715->regmap, RT715_SET_GAIN_LINE_ADC_H, 0xb080); regmap_write(rt715->regmap, RT715_SET_GAIN_MIX_ADC_H, 0xb080); diff --git a/sound/soc/codecs/rt715.h b/sound/soc/codecs/rt715.h index 12a0ae656d09..6e37bf64e12f 100644 --- a/sound/soc/codecs/rt715.h +++ b/sound/soc/codecs/rt715.h @@ -48,6 +48,7 @@ struct rt715_priv { #define RT715_INLINE_CMD 0x55 /* Index (NID:20h) */ +#define RT715_VD_CLEAR_CTRL 0x01 #define RT715_SDW_INPUT_SEL 0x39 #define RT715_EXT_DMIC_CLK_CTRL2 0x54 @@ -71,6 +72,8 @@ struct rt715_priv { #define RT715_READ_HDA_0 0x2015 #define RT715_PRIV_INDEX_W_H 0x7520 #define RT715_PRIV_INDEX_W_L 0x85a0 +#define RT715_PRIV_INDEX_W_H_2 0x7500 +#define RT715_PRIV_INDEX_W_L_2 0x8580 #define RT715_PRIV_DATA_W_H 0x7420 #define RT715_PRIV_DATA_W_L 0x84a0 #define RT715_PRIV_INDEX_R_H 0x9d20 @@ -198,6 +201,10 @@ struct rt715_priv { #define RT715_SET_DMIC4_CONFIG_DEFAULT4\ (RT715_VERB_SET_CONFIG_DEFAULT4 | RT715_DMIC4) +/* vendor register clear ctrl-1 (0x01)(NID:20h) */ +#define RT715_CLEAR_HIDDEN_REG (0x1 << 15) + + #define RT715_MUTE_SFT 7 #define RT715_DIR_IN_SFT 6 #define RT715_DIR_OUT_SFT 7 -- 2.34.1

2 1

[PATCH] ASoC: meson: axg-tdm-formatter: fix channel slot allocation
by Jerome Brunet 10 Aug '23

10 Aug '23

When the tdm lane mask is computed, the driver currently fills the 1st lane before moving on to the next. If the stream has less channels than the lanes can accommodate, slots will be disabled on the last lanes. Unfortunately, the HW distribute channels in a different way. It distribute channels in pair on each lanes before moving on the next slots. This difference leads to problems if a device has an interface with more than 1 lane and with more than 2 slots per lane. For example: a playback interface with 2 lanes and 4 slots each (total 8 slots - zero based numbering) - Playing a 8ch stream: - All slots activated by the driver - channel #2 will be played on lane #1 - slot #0 following HW placement - Playing a 4ch stream: - Lane #1 disabled by the driver - channel #2 will be played on lane #0 - slot #2 This behaviour is obviously not desirable. Change the way slots are activated on the TDM lanes to follow what the HW does and make sure each channel always get mapped to the same slot/lane. Fixes: 1a11d88f499c ("ASoC: meson: add tdm formatter base driver") Signed-off-by: Jerome Brunet <jbrunet(a)baylibre.com> --- sound/soc/meson/axg-tdm-formatter.c | 42 ++++++++++++++++++----------- 1 file changed, 26 insertions(+), 16 deletions(-) diff --git a/sound/soc/meson/axg-tdm-formatter.c b/sound/soc/meson/axg-tdm-formatter.c index 9883dc777f63..63333a2b0a9c 100644 --- a/sound/soc/meson/axg-tdm-formatter.c +++ b/sound/soc/meson/axg-tdm-formatter.c @@ -30,27 +30,32 @@ int axg_tdm_formatter_set_channel_masks(struct regmap *map, struct axg_tdm_stream *ts, unsigned int offset) { - unsigned int val, ch = ts->channels; - unsigned long mask; - int i, j; + unsigned int ch = ts->channels; + u32 val[AXG_TDM_NUM_LANES]; + int i, j, k; + + /* + * We need to mimick the slot distribution used by the HW to keep the + * channel placement consistent regardless of the number of channel + * in the stream. This is why the odd algorithm below is used. + */ + memset(val, 0, sizeof(*val) * AXG_TDM_NUM_LANES); /* * Distribute the channels of the stream over the available slots - * of each TDM lane + * of each TDM lane. We need to go over the 32 slots ... */ - for (i = 0; i < AXG_TDM_NUM_LANES; i++) { - val = 0; - mask = ts->mask[i]; - - for (j = find_first_bit(&mask, 32); - (j < 32) && ch; - j = find_next_bit(&mask, 32, j + 1)) { - val |= 1 << j; - ch -= 1; + for (i = 0; (i < 32) && ch; i += 2) { + /* ... of all the lanes ... */ + for (j = 0; j < AXG_TDM_NUM_LANES; j++) { + /* ... then distribute the channels in pairs */ + for (k = 0; k < 2; k++) { + if ((BIT(i + k) & ts->mask[j]) && ch) { + val[j] |= BIT(i + k); + ch -= 1; + } + } } - - regmap_write(map, offset, val); - offset += regmap_get_reg_stride(map); } /* @@ -63,6 +68,11 @@ int axg_tdm_formatter_set_channel_masks(struct regmap *map, return -EINVAL; } + for (i = 0; i < AXG_TDM_NUM_LANES; i++) { + regmap_write(map, offset, val[i]); + offset += regmap_get_reg_stride(map); + } + return 0; } EXPORT_SYMBOL_GPL(axg_tdm_formatter_set_channel_masks); -- 2.40.1

2 1