- Alsa-devel - mailman.alsa-project.org

[PATCH v3 00/28] Add support for QMC HDLC, framer infrastruture and PEF2256 framer
by Herve Codina 16 Aug '23

16 Aug '23

Hi, I have a system where I need to handle an HDLC interface and some audio data. The HDLC data are transferred using a TDM bus on which a PEF2256 (E1/T1 framer) is present. The PEF2256 transfers data from/to the TDM bus to/from the E1 line. This PEF2256 is connected to a PowerQUICC SoC for the control path and the TDM is connected to the SoC (QMC component) for the data path. From the QMC HDLC driver, I need to handle HDLC data using the QMC, carrier detection using the PEF2256 (E1 line carrier) and set/get some PEF2256 configuration. The QMC HDLC driver considers the PEF2256 as a generic framer. It performs operations that involve the PEF2256 through the generic framer API. The audio data are exchanged with the PEF2256 using a CPU DAI connected to the TDM bus through the QMC and the PEF2256 needs to be seen as a codec in order to be linked to the CPU DAI. The codec handles the carrier detection using the PEF2256 and reports the carrier state to the ALSA subsystem using the ASoC jack detection. The codec, even if instantiated by the PEF2256 driver, considers the PEF2256 as a generic framer. The generic framer has: - 2 consumers (QMC HDLC drv and codec) - 1 provider (PEF2256) So, the design is the following: +------------------+ +---------+ | QMC | <- TDM -> | PEF2256 | <-> E1 +---------+ | +-------------+ | | | | CPU DAI | <-data--> | QMC channel | | | | +---------+ | +-------------+ | | | +--------------+ | +-------------+ | | | | QMC HDLC drv | <-data--> | QMC channel | | | | +--------------+ | +-------------+ | | | ^ +------------------+ | | | +--------+ +-------------+ | | +-> | framer | <-> | PEF2256 drv | <- local bus ->| | | | | | +---------+ +-> | | | | | +--------+ | +-------+ | +-------------------> | codec | | | +-------+ | +-------------+ Further more, the TDM timeslots used by the QMC HDLC driver need to be configured at runtime (QMC dynamic timeslots). Several weeks ago, I sent two series related to this topic: - Add the Lantiq PEF2256 audio support [1] - RFC Add support for QMC HDLC and PHY [2] This current series is a rework of these two series taking into account feedbacks previously received. In order to implement all of this, I do the following: 1) Perform some fixes (patches 1, 2, 3, 4) 2) Introduce the QMC HDLC driver (patches 5, 6, 7) 3) Add QMC dynamic timeslot support (patches 8 - 18) 4) Add timeslots change support in QMC HDLC (patch 19) 5) Introduce framer infrastructure (patch 20) 6) Add PEF2256 framer provider (patches 11, 22, 23, 24, 25) 7) Add framer codec as a framer consumer (patch 26) 8) Add framer support as a framer consumer in QMC HDLC (patch 27, 28) The series contains the full story and detailed modifications. If needed, the series can be split and/or commmits can be squashed. Let me know. Compare to the previous iteration https://lore.kernel.org/linux-kernel/20230726150225.483464-1-herve.codina@b… This v3 series mainly: - Fixes some implementation details. - Adds a new patch (patch 5) to remove existing inline keyword in the QMC driver. - Squashes patches related to the QMC HDLC binding together. Best regards, Hervé [1]: https://lore.kernel.org/all/20230417171601.74656-1-herve.codina@bootlin.com/ [2]: https://lore.kernel.org/all/20230323103154.264546-1-herve.codina@bootlin.co… Changes v2 -> v3 - Patches 1, 2, 3, 4 Add 'Reviewed-by: Christophe Leroy <christophe.leroy(a)csgroup.eu>' - New patch Remove inline keyword from the existing registers accessors helpers - Patch 6 (patches 5, 27 in v2) Update the binding title Squash patch 27 - Patch 7 (patch 6 in v2) Remove the cast in netdev_to_qmc_hdlc() Add 'Reviewed-by: Christophe Leroy <christophe.leroy(a)csgroup.eu>' - Patch 8 (patch 7 in v2): No change - Patches 9, 10 (patches 8, 9 in v2) Add 'Reviewed-by: Christophe Leroy <christophe.leroy(a)csgroup.eu>' - Patch 11 (patch 10 in v2) Remove inline keyword from the introduced qmc_clrsetbits16() helper Add 'Reviewed-by: Christophe Leroy <christophe.leroy(a)csgroup.eu>' - Patches 12, 13, 14, 15, 16, 17, 18, 19, 20 Add 'Reviewed-by: Christophe Leroy <christophe.leroy(a)csgroup.eu>' - Patch 21 (patch 20 in v2) Remove unneeded framer NULL pointer check Add 'Reviewed-by: Christophe Leroy <christophe.leroy(a)csgroup.eu>' - Patch 22 (patch 21 in v2) Change sclkr and sclkx clocks description Remove the framer phandle property from the framer subnodes (ie. from framer-codec nodes) - Patch 23 (patch 22 in v2) Initialize 'disabled' variable at declaration Fix commit log Add 'Reviewed-by: Christophe Leroy <christophe.leroy(a)csgroup.eu>' - Patch 24 (patch 23 in v2) Remove inline keyword from the existing registers accessors helpers Use dev_warn_ratelimited() in default interrupt handler Add 'Reviewed-by: Christophe Leroy <christophe.leroy(a)csgroup.eu>' - Patch 25 (patch 24 in v2) Replace #include "linux/bitfield.h" by #include <linux/bitfield.h> Fold the pinctrl anonymous struct into the struct pef2256_pinctrl Update commit log Add 'Reviewed-by: Christophe Leroy <christophe.leroy(a)csgroup.eu>' - Patch 26 (patch 25 in v2) Add 'Reviewed-by: Christophe Leroy <christophe.leroy(a)csgroup.eu>' - Patch 27 (patch 26 in v2) Fix error message Changed the ch.max computation in framer_dai_hw_rule_channels_by_format() Add 'Reviewed-by: Christophe Leroy <christophe.leroy(a)csgroup.eu>' - Patch 28 Add 'Reviewed-by: Christophe Leroy <christophe.leroy(a)csgroup.eu>' Changes v1 -> v2 - Patches 1, 2 (New in v2) Fix __iomem addresses declaration - Patch 19 (17 in v1) Fix a compilation warning - Patch 26 (24 in v1) Fix a typo in Kconfig file Fix issues raised by sparse (make C=1) Herve Codina (28): soc: fsl: cpm1: tsa: Fix __iomem addresses declaration soc: fsl: cpm1: qmc: Fix __iomem addresses declaration soc: fsl: cpm1: qmc: Fix rx channel reset soc: fsl: cpm1: qmc: Extend the API to provide Rx status soc: fsl: cpm1: qmc: Remove inline function specifiers dt-bindings: net: Add support for QMC HDLC net: wan: Add support for QMC HDLC MAINTAINERS: Add the Freescale QMC HDLC driver entry soc: fsl: cpm1: qmc: Introduce available timeslots masks soc: fsl: cpm1: qmc: Rename qmc_setup_tsa* to qmc_init_tsa* soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa* soc: fsl: cpm1: qmc: Remove no more needed checks from qmc_check_chans() soc: fsl: cpm1: qmc: Check available timeslots in qmc_check_chans() soc: fsl: cpm1: qmc: Add support for disabling channel TSA entries soc: fsl: cpm1: qmc: Split Tx and Rx TSA entries setup soc: fsl: cpm1: qmc: Introduce is_tsa_64rxtx flag soc: fsl: cpm1: qmc: Handle timeslot entries at channel start() and stop() soc: fsl: cpm1: qmc: Remove timeslots handling from setup_chan() soc: fsl: cpm1: qmc: Introduce functions to change timeslots at runtime wan: qmc_hdlc: Add runtime timeslots changes support net: wan: Add framer framework support dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer mfd: core: Ensure disabled devices are skiped without aborting net: wan: framer: Add support for the Lantiq PEF2256 framer pinctrl: Add support for the Lantic PEF2256 pinmux MAINTAINERS: Add the Lantiq PEF2256 driver entry ASoC: codecs: Add support for the framer codec net: wan: fsl_qmc_hdlc: Add framer support .../devicetree/bindings/net/fsl,qmc-hdlc.yaml | 46 + .../bindings/net/lantiq,pef2256.yaml | 219 +++++ MAINTAINERS | 17 + drivers/mfd/mfd-core.c | 17 +- drivers/net/wan/Kconfig | 14 + drivers/net/wan/Makefile | 3 + drivers/net/wan/framer/Kconfig | 35 + drivers/net/wan/framer/Makefile | 7 + drivers/net/wan/framer/framer-core.c | 886 ++++++++++++++++++ drivers/net/wan/framer/pef2256/Makefile | 8 + drivers/net/wan/framer/pef2256/pef2256-regs.h | 250 +++++ drivers/net/wan/framer/pef2256/pef2256.c | 880 +++++++++++++++++ drivers/net/wan/fsl_qmc_hdlc.c | 820 ++++++++++++++++ drivers/pinctrl/Kconfig | 14 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/pinctrl-pef2256-regs.h | 65 ++ drivers/pinctrl/pinctrl-pef2256.c | 308 ++++++ drivers/soc/fsl/qe/qmc.c | 501 ++++++++-- drivers/soc/fsl/qe/tsa.c | 22 +- include/linux/framer/framer-provider.h | 194 ++++ include/linux/framer/framer.h | 199 ++++ include/linux/framer/pef2256.h | 31 + include/soc/fsl/qe/qmc.h | 25 +- sound/soc/codecs/Kconfig | 15 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/framer-codec.c | 413 ++++++++ sound/soc/fsl/fsl_qmc_audio.c | 2 +- 27 files changed, 4872 insertions(+), 122 deletions(-) create mode 100644 Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml create mode 100644 Documentation/devicetree/bindings/net/lantiq,pef2256.yaml create mode 100644 drivers/net/wan/framer/Kconfig create mode 100644 drivers/net/wan/framer/Makefile create mode 100644 drivers/net/wan/framer/framer-core.c create mode 100644 drivers/net/wan/framer/pef2256/Makefile create mode 100644 drivers/net/wan/framer/pef2256/pef2256-regs.h create mode 100644 drivers/net/wan/framer/pef2256/pef2256.c create mode 100644 drivers/net/wan/fsl_qmc_hdlc.c create mode 100644 drivers/pinctrl/pinctrl-pef2256-regs.h create mode 100644 drivers/pinctrl/pinctrl-pef2256.c create mode 100644 include/linux/framer/framer-provider.h create mode 100644 include/linux/framer/framer.h create mode 100644 include/linux/framer/pef2256.h create mode 100644 sound/soc/codecs/framer-codec.c -- 2.41.0

5 36

Fwd: [Bug 217440] New: ALC236 audio disappears from HP 15z-fc000 on warm boot
by Joseph C. Sible 16 Aug '23

16 Aug '23

Hello, Forwarding my regression bug report submission per the instructions in "Reporting regressions". #regzbot introduced: 5aec989130 https://bugzilla.kernel.org/show_bug.cgi?id=217440 Regards, Joseph C. Sible ---------- Forwarded message --------- From: <bugzilla-daemon(a)kernel.org> Date: Sat, May 13, 2023 at 3:46 PM Subject: [Bug 217440] New: ALC236 audio disappears from HP 15z-fc000 on warm boot To: <josephcsible(a)gmail.com> https://bugzilla.kernel.org/show_bug.cgi?id=217440 Bug ID: 217440 Summary: ALC236 audio disappears from HP 15z-fc000 on warm boot Product: Drivers Version: 2.5 Kernel Version: 6.3.2 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P3 Component: Sound(ALSA) Assignee: perex(a)perex.cz Reporter: josephcsible(a)gmail.com Regression: Yes Bisected 5aec98913095ed3b4424ed6c5fdeb6964e9734da commit-id: On an HP 15z-fc000 laptop that uses Realtek ALC236 for sound, once the system is warm booted ("reboot" from within Linux), sound stops working completely and the device doesn't even show up anymore. Once this happens, the only way to get it to come back is to cold boot ("poweroff" from within Linux, wait for it to turn completely off, and turn it back on with the physical power button). In particular, once you boot from a "bad" kernel, no number of warm boots with "good" kernels will ever bring sound back. I bisected this to commit 5aec989, which first appeared in 5.15-rc6. In addition, I confirmed by doing a custom build of 6.3.2 with reverts of both f30741c (just to avoid a conflict) and 5aec989, which works correctly for me. -- You may reply to this email to add a comment. You are receiving this mail because: You reported the bug.

5 48

[PATCH] -- fix Boss MS-3 midi-usb communication
by john_candlish＠mail.candlish.net 16 Aug '23

16 Aug '23

This one line change gets MIDI communication flowing between ALSA and the Boss MS-3 multi-effect switcher. ///// *** sound/usb/midi.c 2023-08-10 22:46:31.016346930 +0200 --- sound/usb/midi.c-orig 2023-07-19 16:37:03.000000000 +0200 *************** *** 2106,2113 **** struct usb_endpoint_descriptor *epd; int i, out_eps = 0, in_eps = 0; ! if (USB_ID_VENDOR(umidi->usb_id) == 0x0582 && ! USB_ID_PRODUCT(umidi->usb_id) != 0x01f5) snd_usbmidi_switch_roland_altsetting(umidi); if (endpoint[0].out_ep || endpoint[0].in_ep) --- 2106,2112 ---- struct usb_endpoint_descriptor *epd; int i, out_eps = 0, in_eps = 0; ! if (USB_ID_VENDOR(umidi->usb_id) == 0x0582) snd_usbmidi_switch_roland_altsetting(umidi); if (endpoint[0].out_ep || endpoint[0].in_ep) ///// There are doubtless other Roland/Boss USB_ID_PRODUCT id's that are effected and it would be nice to make the USB_ID_PRODUCT value a tunable, but that is beyond my competence.

2 3

Build fails
by GitHub issues - edited 16 Aug '23

16 Aug '23

alsa-project/alsa-utils issue #230 was edited from symdeb: Follow INSTALL $ls -l total 148 -rw-rw-r-- 1 user user 440 Aug 16 17:40 acinclude.m4 drwxrwxr-x 3 user user 4096 Aug 16 17:40 alsaconf drwxrwxr-x 3 user user 4096 Aug 16 17:40 alsactl drwxrwxr-x 2 user user 4096 Aug 16 17:40 alsa-info drwxrwxr-x 2 user user 4096 Aug 16 17:40 alsaloop drwxrwxr-x 2 user user 4096 Aug 16 17:40 alsamixer drwxrwxr-x 2 user user 4096 Aug 16 17:40 alsaucm drwxrwxr-x 2 user user 4096 Aug 16 17:40 amidi drwxrwxr-x 2 user user 4096 Aug 16 17:40 amixer drwxrwxr-x 2 user user 4096 Aug 16 17:40 aplay drwxrwxr-x 3 user user 4096 Aug 16 17:40 axfer drwxrwxr-x 3 user user 4096 Aug 16 17:40 bat -rw-rw-r-- 1 user user 1055 Aug 16 17:40 ChangeLog -rw-rw-r-- 1 user user 17587 Aug 16 17:40 configure.ac -rw-rw-r-- 1 user user 18002 Aug 16 17:40 COPYING -rwxrwxr-x 1 user user 780 Aug 16 17:40 gitcompile drwxrwxr-x 2 user user 4096 Aug 16 17:40 iecset drwxrwxr-x 2 user user 4096 Aug 16 17:40 include -rw-rw-r-- 1 user user 1595 Aug 16 17:40 INSTALL drwxrwxr-x 2 user user 4096 Aug 16 17:40 m4 -rw-rw-r-- 1 user user 1063 Aug 16 17:40 Makefile.am drwxrwxr-x 2 user user 4096 Aug 16 17:40 nhlt drwxrwxr-x 2 user user 4096 Aug 16 17:40 po -rw-rw-r-- 1 user user 1392 Aug 16 17:40 README.md drwxrwxr-x 6 user user 4096 Aug 16 17:40 seq drwxrwxr-x 3 user user 4096 Aug 16 17:40 speaker-test -rw-rw-r-- 1 user user 187 Aug 16 17:40 TODO drwxrwxr-x 3 user user 4096 Aug 16 17:40 topology drwxrwxr-x 2 user user 4096 Aug 16 17:40 utils $aclocal $gettextize Copying file ABOUT-NLS Copying file config.rpath Copying file po/Makefile.in.in Copying file po/Makevars.template Copying file po/Rules-quot Copying file po/boldquot.sed Copying file po/en(a)boldquot.header Copying file po/en(a)quot.header Copying file po/insert-header.sin Copying file po/quot.sed Copying file po/remove-potcdate.sin Creating po/ChangeLog Copying file m4/gettext.m4 Copying file m4/host-cpu-c-abi.m4 Copying file m4/iconv.m4 Copying file m4/intlmacosx.m4 Copying file m4/lib-ld.m4 Copying file m4/lib-link.m4 Copying file m4/lib-prefix.m4 Copying file m4/nls.m4 Copying file m4/po.m4 Copying file m4/progtest.m4 Updating EXTRA_DIST in m4/Makefile.am (backup is in m4/Makefile.am~) Updating configure.ac (backup is in configure.ac~) Adding an entry to ChangeLog (backup is in ChangeLog~) Please run 'aclocal -I m4' to regenerate the aclocal.m4 file. You need aclocal from GNU automake 1.9 (or newer) to do this. Then run 'autoconf' to regenerate the configure file. You will also need config.guess and config.sub, which you can get from the CVS of the 'config' project at https://savannah.gnu.org/. The commands to fetch them are $ wget 'https://savannah.gnu.org/cgi-bin/viewcvs/*checkout*/config/config/config.gu…' $ wget 'https://savannah.gnu.org/cgi-bin/viewcvs/*checkout*/config/config/config.sub' You might also want to copy the convenience header file gettext.h from the /usr/share/gettext directory into your package. It is a wrapper around <libintl.h> that implements the configure --disable-nls option. Press Return to acknowledge the previous three paragraphs. $autoheader configure.ac:480: error: `po/Makefile.in' is already registered with AC_CONFIG_FILES. ./lib/autoconf/status.m4:289: AC_CONFIG_FILES is expanded from... configure.ac:480: the top level autom4te: error: /usr/bin/m4 failed with exit status: 1 autoheader: error: '/usr/bin/autom4te' failed with exit status: 1 $automake --foreign --copy --add-missing configure.ac:480: error: `po/Makefile.in' is already registered with AC_CONFIG_FILES. ./lib/autoconf/status.m4:289: AC_CONFIG_FILES is expanded from... configure.ac:480: the top level autom4te: error: /usr/bin/m4 failed with exit status: 1 $aclocal -I m4 configure.ac:480: error: `po/Makefile.in' is already registered with AC_CONFIG_FILES. ./lib/autoconf/status.m4:289: AC_CONFIG_FILES is expanded from... configure.ac:480: the top level autom4te: error: /usr/bin/m4 failed with exit status: 1 aclocal: error: autom4te failed with exit status: 1 ./configure bash: ./configure: No such file or directory aclocal --version aclocal (GNU automake) 1.16.5 Issue URL : https://github.com/alsa-project/alsa-utils/issues/230 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

Build fails
by GitHub issues - edited 16 Aug '23

16 Aug '23

alsa-project/alsa-utils issue #230 was edited from symdeb: Follow INSTALL $ls -l total 148 -rw-rw-r-- 1 user user 440 Aug 16 17:40 acinclude.m4 drwxrwxr-x 3 user user 4096 Aug 16 17:40 alsaconf drwxrwxr-x 3 user user 4096 Aug 16 17:40 alsactl drwxrwxr-x 2 user user 4096 Aug 16 17:40 alsa-info drwxrwxr-x 2 user user 4096 Aug 16 17:40 alsaloop drwxrwxr-x 2 user user 4096 Aug 16 17:40 alsamixer drwxrwxr-x 2 user user 4096 Aug 16 17:40 alsaucm drwxrwxr-x 2 user user 4096 Aug 16 17:40 amidi drwxrwxr-x 2 user user 4096 Aug 16 17:40 amixer drwxrwxr-x 2 user user 4096 Aug 16 17:40 aplay drwxrwxr-x 3 user user 4096 Aug 16 17:40 axfer drwxrwxr-x 3 user user 4096 Aug 16 17:40 bat -rw-rw-r-- 1 user user 1055 Aug 16 17:40 ChangeLog -rw-rw-r-- 1 user user 17587 Aug 16 17:40 configure.ac -rw-rw-r-- 1 user user 18002 Aug 16 17:40 COPYING -rwxrwxr-x 1 user user 780 Aug 16 17:40 gitcompile drwxrwxr-x 2 user user 4096 Aug 16 17:40 iecset drwxrwxr-x 2 user user 4096 Aug 16 17:40 include -rw-rw-r-- 1 user user 1595 Aug 16 17:40 INSTALL drwxrwxr-x 2 user user 4096 Aug 16 17:40 m4 -rw-rw-r-- 1 user user 1063 Aug 16 17:40 Makefile.am drwxrwxr-x 2 user user 4096 Aug 16 17:40 nhlt drwxrwxr-x 2 user user 4096 Aug 16 17:40 po -rw-rw-r-- 1 user user 1392 Aug 16 17:40 README.md drwxrwxr-x 6 user user 4096 Aug 16 17:40 seq drwxrwxr-x 3 user user 4096 Aug 16 17:40 speaker-test -rw-rw-r-- 1 user user 187 Aug 16 17:40 TODO drwxrwxr-x 3 user user 4096 Aug 16 17:40 topology drwxrwxr-x 2 user user 4096 Aug 16 17:40 utils $aclocal $gettextize Copying file ABOUT-NLS Copying file config.rpath Copying file po/Makefile.in.in Copying file po/Makevars.template Copying file po/Rules-quot Copying file po/boldquot.sed Copying file po/en(a)boldquot.header Copying file po/en(a)quot.header Copying file po/insert-header.sin Copying file po/quot.sed Copying file po/remove-potcdate.sin Creating po/ChangeLog Copying file m4/gettext.m4 Copying file m4/host-cpu-c-abi.m4 Copying file m4/iconv.m4 Copying file m4/intlmacosx.m4 Copying file m4/lib-ld.m4 Copying file m4/lib-link.m4 Copying file m4/lib-prefix.m4 Copying file m4/nls.m4 Copying file m4/po.m4 Copying file m4/progtest.m4 Updating EXTRA_DIST in m4/Makefile.am (backup is in m4/Makefile.am~) Updating configure.ac (backup is in configure.ac~) Adding an entry to ChangeLog (backup is in ChangeLog~) Please run 'aclocal -I m4' to regenerate the aclocal.m4 file. You need aclocal from GNU automake 1.9 (or newer) to do this. Then run 'autoconf' to regenerate the configure file. You will also need config.guess and config.sub, which you can get from the CVS of the 'config' project at https://savannah.gnu.org/. The commands to fetch them are $ wget 'https://savannah.gnu.org/cgi-bin/viewcvs/*checkout*/config/config/config.gu…' $ wget 'https://savannah.gnu.org/cgi-bin/viewcvs/*checkout*/config/config/config.sub' You might also want to copy the convenience header file gettext.h from the /usr/share/gettext directory into your package. It is a wrapper around <libintl.h> that implements the configure --disable-nls option. Press Return to acknowledge the previous three paragraphs. $autoheader configure.ac:480: error: `po/Makefile.in' is already registered with AC_CONFIG_FILES. ./lib/autoconf/status.m4:289: AC_CONFIG_FILES is expanded from... configure.ac:480: the top level autom4te: error: /usr/bin/m4 failed with exit status: 1 autoheader: error: '/usr/bin/autom4te' failed with exit status: 1 $automake --foreign --copy --add-missing configure.ac:480: error: `po/Makefile.in' is already registered with AC_CONFIG_FILES. ./lib/autoconf/status.m4:289: AC_CONFIG_FILES is expanded from... configure.ac:480: the top level autom4te: error: /usr/bin/m4 failed with exit status: 1 $aclocal -I m4 configure.ac:480: error: `po/Makefile.in' is already registered with AC_CONFIG_FILES. ./lib/autoconf/status.m4:289: AC_CONFIG_FILES is expanded from... configure.ac:480: the top level autom4te: error: /usr/bin/m4 failed with exit status: 1 aclocal: error: autom4te failed with exit status: 1 ./configure bash: ./configure: No such file or directory Issue URL : https://github.com/alsa-project/alsa-utils/issues/230 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

Build fails
by GitHub issues - edited 16 Aug '23

16 Aug '23

alsa-project/alsa-utils issue #230 was edited from symdeb: Follow INSTALL $ls -l total 148 -rw-rw-r-- 1 user user 440 Aug 16 17:40 acinclude.m4 drwxrwxr-x 3 user user 4096 Aug 16 17:40 alsaconf drwxrwxr-x 3 user user 4096 Aug 16 17:40 alsactl drwxrwxr-x 2 user user 4096 Aug 16 17:40 alsa-info drwxrwxr-x 2 user user 4096 Aug 16 17:40 alsaloop drwxrwxr-x 2 user user 4096 Aug 16 17:40 alsamixer drwxrwxr-x 2 user user 4096 Aug 16 17:40 alsaucm drwxrwxr-x 2 user user 4096 Aug 16 17:40 amidi drwxrwxr-x 2 user user 4096 Aug 16 17:40 amixer drwxrwxr-x 2 user user 4096 Aug 16 17:40 aplay drwxrwxr-x 3 user user 4096 Aug 16 17:40 axfer drwxrwxr-x 3 user user 4096 Aug 16 17:40 bat -rw-rw-r-- 1 user user 1055 Aug 16 17:40 ChangeLog -rw-rw-r-- 1 user user 17587 Aug 16 17:40 configure.ac -rw-rw-r-- 1 user user 18002 Aug 16 17:40 COPYING -rwxrwxr-x 1 user user 780 Aug 16 17:40 gitcompile drwxrwxr-x 2 user user 4096 Aug 16 17:40 iecset drwxrwxr-x 2 user user 4096 Aug 16 17:40 include -rw-rw-r-- 1 user user 1595 Aug 16 17:40 INSTALL drwxrwxr-x 2 user user 4096 Aug 16 17:40 m4 -rw-rw-r-- 1 user user 1063 Aug 16 17:40 Makefile.am drwxrwxr-x 2 user user 4096 Aug 16 17:40 nhlt drwxrwxr-x 2 user user 4096 Aug 16 17:40 po -rw-rw-r-- 1 user user 1392 Aug 16 17:40 README.md drwxrwxr-x 6 user user 4096 Aug 16 17:40 seq drwxrwxr-x 3 user user 4096 Aug 16 17:40 speaker-test -rw-rw-r-- 1 user user 187 Aug 16 17:40 TODO drwxrwxr-x 3 user user 4096 Aug 16 17:40 topology drwxrwxr-x 2 user user 4096 Aug 16 17:40 utils $aclocal $gettextize Copying file ABOUT-NLS Copying file config.rpath Copying file po/Makefile.in.in Copying file po/Makevars.template Copying file po/Rules-quot Copying file po/boldquot.sed Copying file po/en(a)boldquot.header Copying file po/en(a)quot.header Copying file po/insert-header.sin Copying file po/quot.sed Copying file po/remove-potcdate.sin Creating po/ChangeLog Copying file m4/gettext.m4 Copying file m4/host-cpu-c-abi.m4 Copying file m4/iconv.m4 Copying file m4/intlmacosx.m4 Copying file m4/lib-ld.m4 Copying file m4/lib-link.m4 Copying file m4/lib-prefix.m4 Copying file m4/nls.m4 Copying file m4/po.m4 Copying file m4/progtest.m4 Updating EXTRA_DIST in m4/Makefile.am (backup is in m4/Makefile.am~) Updating configure.ac (backup is in configure.ac~) Adding an entry to ChangeLog (backup is in ChangeLog~) Please run 'aclocal -I m4' to regenerate the aclocal.m4 file. You need aclocal from GNU automake 1.9 (or newer) to do this. Then run 'autoconf' to regenerate the configure file. You will also need config.guess and config.sub, which you can get from the CVS of the 'config' project at https://savannah.gnu.org/. The commands to fetch them are $ wget 'https://savannah.gnu.org/cgi-bin/viewcvs/*checkout*/config/config/config.gu…' $ wget 'https://savannah.gnu.org/cgi-bin/viewcvs/*checkout*/config/config/config.sub' You might also want to copy the convenience header file gettext.h from the /usr/share/gettext directory into your package. It is a wrapper around <libintl.h> that implements the configure --disable-nls option. Press Return to acknowledge the previous three paragraphs. $autoheader configure.ac:480: error: `po/Makefile.in' is already registered with AC_CONFIG_FILES. ./lib/autoconf/status.m4:289: AC_CONFIG_FILES is expanded from... configure.ac:480: the top level autom4te: error: /usr/bin/m4 failed with exit status: 1 autoheader: error: '/usr/bin/autom4te' failed with exit status: 1 $automake --foreign --copy --add-missing configure.ac:480: error: `po/Makefile.in' is already registered with AC_CONFIG_FILES. ./lib/autoconf/status.m4:289: AC_CONFIG_FILES is expanded from... configure.ac:480: the top level autom4te: error: /usr/bin/m4 failed with exit status: 1 aclocal -I m4 configure.ac:480: error: `po/Makefile.in' is already registered with AC_CONFIG_FILES. ./lib/autoconf/status.m4:289: AC_CONFIG_FILES is expanded from... configure.ac:480: the top level autom4te: error: /usr/bin/m4 failed with exit status: 1 aclocal: error: autom4te failed with exit status: 1 ./configure bash: ./configure: No such file or directory Issue URL : https://github.com/alsa-project/alsa-utils/issues/230 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

Build fails
by GitHub issues - edited 16 Aug '23

16 Aug '23

alsa-project/alsa-utils issue #230 was edited from symdeb: Follow INSTALL $ls -l total 148 -rw-rw-r-- 1 user user 440 Aug 16 17:40 acinclude.m4 drwxrwxr-x 3 user user 4096 Aug 16 17:40 alsaconf drwxrwxr-x 3 user user 4096 Aug 16 17:40 alsactl drwxrwxr-x 2 user user 4096 Aug 16 17:40 alsa-info drwxrwxr-x 2 user user 4096 Aug 16 17:40 alsaloop drwxrwxr-x 2 user user 4096 Aug 16 17:40 alsamixer drwxrwxr-x 2 user user 4096 Aug 16 17:40 alsaucm drwxrwxr-x 2 user user 4096 Aug 16 17:40 amidi drwxrwxr-x 2 user user 4096 Aug 16 17:40 amixer drwxrwxr-x 2 user user 4096 Aug 16 17:40 aplay drwxrwxr-x 3 user user 4096 Aug 16 17:40 axfer drwxrwxr-x 3 user user 4096 Aug 16 17:40 bat -rw-rw-r-- 1 user user 1055 Aug 16 17:40 ChangeLog -rw-rw-r-- 1 user user 17587 Aug 16 17:40 configure.ac -rw-rw-r-- 1 user user 18002 Aug 16 17:40 COPYING -rwxrwxr-x 1 user user 780 Aug 16 17:40 gitcompile drwxrwxr-x 2 user user 4096 Aug 16 17:40 iecset drwxrwxr-x 2 user user 4096 Aug 16 17:40 include -rw-rw-r-- 1 user user 1595 Aug 16 17:40 INSTALL drwxrwxr-x 2 user user 4096 Aug 16 17:40 m4 -rw-rw-r-- 1 user user 1063 Aug 16 17:40 Makefile.am drwxrwxr-x 2 user user 4096 Aug 16 17:40 nhlt drwxrwxr-x 2 user user 4096 Aug 16 17:40 po -rw-rw-r-- 1 user user 1392 Aug 16 17:40 README.md drwxrwxr-x 6 user user 4096 Aug 16 17:40 seq drwxrwxr-x 3 user user 4096 Aug 16 17:40 speaker-test -rw-rw-r-- 1 user user 187 Aug 16 17:40 TODO drwxrwxr-x 3 user user 4096 Aug 16 17:40 topology drwxrwxr-x 2 user user 4096 Aug 16 17:40 utils $aclocal $gettextize Copying file ABOUT-NLS Copying file config.rpath Copying file po/Makefile.in.in Copying file po/Makevars.template Copying file po/Rules-quot Copying file po/boldquot.sed Copying file po/en(a)boldquot.header Copying file po/en(a)quot.header Copying file po/insert-header.sin Copying file po/quot.sed Copying file po/remove-potcdate.sin Creating po/ChangeLog Copying file m4/gettext.m4 Copying file m4/host-cpu-c-abi.m4 Copying file m4/iconv.m4 Copying file m4/intlmacosx.m4 Copying file m4/lib-ld.m4 Copying file m4/lib-link.m4 Copying file m4/lib-prefix.m4 Copying file m4/nls.m4 Copying file m4/po.m4 Copying file m4/progtest.m4 Updating EXTRA_DIST in m4/Makefile.am (backup is in m4/Makefile.am~) Updating configure.ac (backup is in configure.ac~) Adding an entry to ChangeLog (backup is in ChangeLog~) Please run 'aclocal -I m4' to regenerate the aclocal.m4 file. You need aclocal from GNU automake 1.9 (or newer) to do this. Then run 'autoconf' to regenerate the configure file. You will also need config.guess and config.sub, which you can get from the CVS of the 'config' project at https://savannah.gnu.org/. The commands to fetch them are $ wget 'https://savannah.gnu.org/cgi-bin/viewcvs/*checkout*/config/config/config.gu…' $ wget 'https://savannah.gnu.org/cgi-bin/viewcvs/*checkout*/config/config/config.sub' You might also want to copy the convenience header file gettext.h from the /usr/share/gettext directory into your package. It is a wrapper around <libintl.h> that implements the configure --disable-nls option. Press Return to acknowledge the previous three paragraphs. $autoheader configure.ac:480: error: `po/Makefile.in' is already registered with AC_CONFIG_FILES. ./lib/autoconf/status.m4:289: AC_CONFIG_FILES is expanded from... configure.ac:480: the top level autom4te: error: /usr/bin/m4 failed with exit status: 1 autoheader: error: '/usr/bin/autom4te' failed with exit status: 1 $automake --foreign --copy --add-missing configure.ac:480: error: `po/Makefile.in' is already registered with AC_CONFIG_FILES. ./lib/autoconf/status.m4:289: AC_CONFIG_FILES is expanded from... configure.ac:480: the top level autom4te: error: /usr/bin/m4 failed with exit status: 1 aclocal -I m4 configure.ac:480: error: `po/Makefile.in' is already registered with AC_CONFIG_FILES. ./lib/autoconf/status.m4:289: AC_CONFIG_FILES is expanded from... configure.ac:480: the top level autom4te: error: /usr/bin/m4 failed with exit status: 1 aclocal: error: autom4te failed with exit status: 1 Issue URL : https://github.com/alsa-project/alsa-utils/issues/230 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

Build fails
by GitHub issues - opened 16 Aug '23

16 Aug '23

alsa-project/alsa-utils issue #230 was opened from symdeb: Follow INSTALL $ls -l total 148 -rw-rw-r-- 1 user user 440 Aug 16 17:40 acinclude.m4 drwxrwxr-x 3 user user 4096 Aug 16 17:40 alsaconf drwxrwxr-x 3 user user 4096 Aug 16 17:40 alsactl drwxrwxr-x 2 user user 4096 Aug 16 17:40 alsa-info drwxrwxr-x 2 user user 4096 Aug 16 17:40 alsaloop drwxrwxr-x 2 user user 4096 Aug 16 17:40 alsamixer drwxrwxr-x 2 user user 4096 Aug 16 17:40 alsaucm drwxrwxr-x 2 user user 4096 Aug 16 17:40 amidi drwxrwxr-x 2 user user 4096 Aug 16 17:40 amixer drwxrwxr-x 2 user user 4096 Aug 16 17:40 aplay drwxrwxr-x 3 user user 4096 Aug 16 17:40 axfer drwxrwxr-x 3 user user 4096 Aug 16 17:40 bat -rw-rw-r-- 1 user user 1055 Aug 16 17:40 ChangeLog -rw-rw-r-- 1 user user 17587 Aug 16 17:40 configure.ac -rw-rw-r-- 1 user user 18002 Aug 16 17:40 COPYING -rwxrwxr-x 1 user user 780 Aug 16 17:40 gitcompile drwxrwxr-x 2 user user 4096 Aug 16 17:40 iecset drwxrwxr-x 2 user user 4096 Aug 16 17:40 include -rw-rw-r-- 1 user user 1595 Aug 16 17:40 INSTALL drwxrwxr-x 2 user user 4096 Aug 16 17:40 m4 -rw-rw-r-- 1 user user 1063 Aug 16 17:40 Makefile.am drwxrwxr-x 2 user user 4096 Aug 16 17:40 nhlt drwxrwxr-x 2 user user 4096 Aug 16 17:40 po -rw-rw-r-- 1 user user 1392 Aug 16 17:40 README.md drwxrwxr-x 6 user user 4096 Aug 16 17:40 seq drwxrwxr-x 3 user user 4096 Aug 16 17:40 speaker-test -rw-rw-r-- 1 user user 187 Aug 16 17:40 TODO drwxrwxr-x 3 user user 4096 Aug 16 17:40 topology drwxrwxr-x 2 user user 4096 Aug 16 17:40 utils $aclocal $gettextize Copying file ABOUT-NLS Copying file config.rpath Copying file po/Makefile.in.in Copying file po/Makevars.template Copying file po/Rules-quot Copying file po/boldquot.sed Copying file po/en(a)boldquot.header Copying file po/en(a)quot.header Copying file po/insert-header.sin Copying file po/quot.sed Copying file po/remove-potcdate.sin Creating po/ChangeLog Copying file m4/gettext.m4 Copying file m4/host-cpu-c-abi.m4 Copying file m4/iconv.m4 Copying file m4/intlmacosx.m4 Copying file m4/lib-ld.m4 Copying file m4/lib-link.m4 Copying file m4/lib-prefix.m4 Copying file m4/nls.m4 Copying file m4/po.m4 Copying file m4/progtest.m4 Updating EXTRA_DIST in m4/Makefile.am (backup is in m4/Makefile.am~) Updating configure.ac (backup is in configure.ac~) Adding an entry to ChangeLog (backup is in ChangeLog~) Please run 'aclocal -I m4' to regenerate the aclocal.m4 file. You need aclocal from GNU automake 1.9 (or newer) to do this. Then run 'autoconf' to regenerate the configure file. You will also need config.guess and config.sub, which you can get from the CVS of the 'config' project at https://savannah.gnu.org/. The commands to fetch them are $ wget 'https://savannah.gnu.org/cgi-bin/viewcvs/*checkout*/config/config/config.gu…' $ wget 'https://savannah.gnu.org/cgi-bin/viewcvs/*checkout*/config/config/config.sub' You might also want to copy the convenience header file gettext.h from the /usr/share/gettext directory into your package. It is a wrapper around <libintl.h> that implements the configure --disable-nls option. Press Return to acknowledge the previous three paragraphs. $autoheader configure.ac:480: error: `po/Makefile.in' is already registered with AC_CONFIG_FILES. ./lib/autoconf/status.m4:289: AC_CONFIG_FILES is expanded from... configure.ac:480: the top level autom4te: error: /usr/bin/m4 failed with exit status: 1 autoheader: error: '/usr/bin/autom4te' failed with exit status: 1 $automake --foreign --copy --add-missing configure.ac:480: error: `po/Makefile.in' is already registered with AC_CONFIG_FILES. ./lib/autoconf/status.m4:289: AC_CONFIG_FILES is expanded from... configure.ac:480: the top level autom4te: error: /usr/bin/m4 failed with exit status: 1 Issue URL : https://github.com/alsa-project/alsa-utils/issues/230 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[PATCH RESEND 1/3] ASoC: codecs: tlv320aic32x4: Fix Wvoid-pointer-to-enum-cast warning
by Krzysztof Kozlowski 16 Aug '23

16 Aug '23

'type' is an enum, thus cast of pointer on 64-bit compile test with W=1 causes: tlv320aic32x4.c:1352:18: error: cast to smaller integer type 'enum aic32x4_type' from 'void *' [-Werror,-Wvoid-pointer-to-enum-cast] Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> --- Resending because thread got duplicated/messed on the lists. I also dropped patch for aw88261 from the series, because it was fixed other way by Arnd. --- sound/soc/codecs/tlv320aic32x4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/tlv320aic32x4.c b/sound/soc/codecs/tlv320aic32x4.c index ffe1828a4b7e..6829834a412f 100644 --- a/sound/soc/codecs/tlv320aic32x4.c +++ b/sound/soc/codecs/tlv320aic32x4.c @@ -1349,7 +1349,7 @@ int aic32x4_probe(struct device *dev, struct regmap *regmap) return -ENOMEM; aic32x4->dev = dev; - aic32x4->type = (enum aic32x4_type)dev_get_drvdata(dev); + aic32x4->type = (uintptr_t)dev_get_drvdata(dev); dev_set_drvdata(dev, aic32x4); -- 2.34.1

3 4

[PATCH v2] ALSA: hda: intel-dsp-cfg: Add Chromebook quirk to ADL/RPL
by Brady Norander 16 Aug '23

16 Aug '23

AlderLake and RaptorLake Chromebooks currently use the HDA driver by default. Add a quirk to use the SOF driver on these platforms, which is needed for functional internal audio. Signed-off-by: Brady Norander <bradynorander(a)gmail.com> --- v2: Removed quirk from SKUs not used in Chrome platforms sound/hda/intel-dsp-config.c | 60 +++++++++++++++++++++++++++++++++--- 1 file changed, 56 insertions(+), 4 deletions(-) diff --git a/sound/hda/intel-dsp-config.c b/sound/hda/intel-dsp-config.c index dcf2453138a5..24a948baf1bc 100644 --- a/sound/hda/intel-dsp-config.c +++ b/sound/hda/intel-dsp-config.c @@ -167,10 +167,10 @@ static const struct config_entry config_table[] = { #endif /* - * CoffeeLake, CannonLake, CometLake, IceLake, TigerLake use legacy - * HDAudio driver except for Google Chromebooks and when DMICs are - * present. Two cases are required since Coreboot does not expose NHLT - * tables. + * CoffeeLake, CannonLake, CometLake, IceLake, TigerLake, AlderLake, + * RaptorLake use legacy HDAudio driver except for Google Chromebooks + * and when DMICs are present. Two cases are required since Coreboot + * does not expose NHLT tables. * * When the Chromebook quirk is not present, it's based on information * that no such device exists. When the quirk is present, it could be @@ -408,6 +408,19 @@ static const struct config_entry config_table[] = { .flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE, .device = PCI_DEVICE_ID_INTEL_HDA_RPL_S, }, + { + .flags = FLAG_SOF, + .device = PCI_DEVICE_ID_INTEL_HDA_ADL_P, + .dmi_table = (const struct dmi_system_id []) { + { + .ident = "Google Chromebooks", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Google"), + } + }, + {} + } + }, { .flags = FLAG_SOF, .device = PCI_DEVICE_ID_INTEL_HDA_ADL_P, @@ -434,14 +447,53 @@ static const struct config_entry config_table[] = { .flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE, .device = PCI_DEVICE_ID_INTEL_HDA_ADL_M, }, + { + .flags = FLAG_SOF, + .device = PCI_DEVICE_ID_INTEL_HDA_ADL_N, + .dmi_table = (const struct dmi_system_id []) { + { + .ident = "Google Chromebooks", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Google"), + } + }, + {} + } + }, { .flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE, .device = PCI_DEVICE_ID_INTEL_HDA_ADL_N, }, + { + .flags = FLAG_SOF, + .device = PCI_DEVICE_ID_INTEL_HDA_RPL_P_0, + .dmi_table = (const struct dmi_system_id []) { + { + .ident = "Google Chromebooks", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Google"), + } + }, + {} + } + }, { .flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE, .device = PCI_DEVICE_ID_INTEL_HDA_RPL_P_0, }, + { + .flags = FLAG_SOF, + .device = PCI_DEVICE_ID_INTEL_HDA_RPL_P_1, + .dmi_table = (const struct dmi_system_id []) { + { + .ident = "Google Chromebooks", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Google"), + } + }, + {} + } + }, { .flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE, .device = PCI_DEVICE_ID_INTEL_HDA_RPL_P_1, -- 2.41.0

4 7