- Alsa-devel - mailman.alsa-project.org

Asus ZenBook UX363EA audio codec ALC294 - Speakers reporting as Headphones
by GitHub issues - opened 26 Aug '23

26 Aug '23

alsa-project/alsa-ucm-conf issue #343 was opened from SoloRobo: I have an Asus ZenBook UX363EA audio codec ALC294 and the Speakers report as Headphones. This laptop does not have a 3.5mm jack, only speakers, and audio is working normally despite the incorrect sink port name. I've been advised to leave the following: also-info.sh http://alsa-project.org/db/?f=84daae5bf1954aeebdcbd78c52cc1813376e6d66 alsaucm -c hw:0 dump text: https://pastebin.com/pfYxSbz0 Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/343 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Re: linux-next: Tree for Aug 25 (sound/soc/fsl/mpc5200_psc_ac97.o)
by Randy Dunlap 25 Aug '23

25 Aug '23

On 8/24/23 22:52, Stephen Rothwell wrote: > Hi all, > > Changes since 20230824: > on powerpc 32-bit: WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97 Depends on [n]: SOUND [=y] && SND [=y] && SND_SOC [=y] && SND_POWERPC_SOC [=y] && PPC_MPC52xx [=y] && PPC_BESTCOMM [=n] Selected by [y]: - SND_MPC52xx_SOC_PCM030 [=y] && SOUND [=y] && SND [=y] && SND_SOC [=y] && SND_POWERPC_SOC [=y] && PPC_MPC5200_SIMPLE [=y] WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97 Depends on [n]: SOUND [=y] && SND [=y] && SND_SOC [=y] && SND_POWERPC_SOC [=y] && PPC_MPC52xx [=y] && PPC_BESTCOMM [=n] Selected by [y]: - SND_MPC52xx_SOC_PCM030 [=y] && SOUND [=y] && SND [=y] && SND_SOC [=y] && SND_POWERPC_SOC [=y] && PPC_MPC5200_SIMPLE [=y] WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97 Depends on [n]: SOUND [=y] && SND [=y] && SND_SOC [=y] && SND_POWERPC_SOC [=y] && PPC_MPC52xx [=y] && PPC_BESTCOMM [=n] Selected by [y]: - SND_MPC52xx_SOC_PCM030 [=y] && SOUND [=y] && SND [=y] && SND_SOC [=y] && SND_POWERPC_SOC [=y] && PPC_MPC5200_SIMPLE [=y] /opt/crosstool/gcc-13.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: sound/soc/fsl/mpc5200_psc_ac97.o: in function `psc_ac97_of_remove': mpc5200_psc_ac97.c:(.text+0x300): undefined reference to `mpc5200_audio_dma_destroy' /opt/crosstool/gcc-13.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: sound/soc/fsl/mpc5200_psc_ac97.o: in function `psc_ac97_of_probe': mpc5200_psc_ac97.c:(.text+0x344): undefined reference to `mpc5200_audio_dma_create' Full randconfig file is attached. -- ~Randy

1 0

[PATCH] ALSA: ump: Fix -Wformat-truncation warnings
by Takashi Iwai 25 Aug '23

25 Aug '23

Filling the rawmidi name and substream name can be truncated, and this leads to spurious compiler warnings due to -Wformat-truncation. Although the truncation is the expected behavior, it'd be better to truncate the string within "(...)" This patch puts the precision specifies to each %s for fitting the words within the size-limited strings. Fixes: 5f11dd938fe7 ("ALSA: usb-audio: Attach legacy rawmidi after probing all UMP EPs") Reported-by: kernel test robot <lkp(a)intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202308251844.1FuQYsql-lkp@intel.com/ Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/core/ump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/core/ump.c b/sound/core/ump.c index 9d6e3e748f7e..a2f91fe7905a 100644 --- a/sound/core/ump.c +++ b/sound/core/ump.c @@ -1157,7 +1157,7 @@ static void fill_substream_names(struct snd_ump_endpoint *ump, struct snd_rawmidi_substream *s; list_for_each_entry(s, &rmidi->streams[dir].substreams, list) - snprintf(s->name, sizeof(s->name), "Group %d (%s)", + snprintf(s->name, sizeof(s->name), "Group %d (%.16s)", ump->legacy_mapping[s->number] + 1, ump->info.name); } @@ -1191,7 +1191,7 @@ int snd_ump_attach_legacy_rawmidi(struct snd_ump_endpoint *ump, if (output) snd_rawmidi_set_ops(rmidi, SNDRV_RAWMIDI_STREAM_OUTPUT, &snd_ump_legacy_output_ops); - snprintf(rmidi->name, sizeof(rmidi->name), "%s (MIDI 1.0)", + snprintf(rmidi->name, sizeof(rmidi->name), "%.69s (MIDI 1.0)", ump->info.name); rmidi->info_flags = ump->core.info_flags & ~SNDRV_RAWMIDI_INFO_UMP; rmidi->ops = &snd_ump_legacy_ops; -- 2.35.3

1 0

[PATCH] ALSA: hda: Add missing dependency on CONFIG_EFI for Cirrus/TI sub-codecs
by Takashi Iwai 25 Aug '23

25 Aug '23

The CS35L41 and TAS2781 sub-codecs depend on CONFIG_EFI, as they have the code accessing efi variable directly. Reported-by: kernel test robot <lkp(a)intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202308250621.1lwt7PtZ-lkp@intel.com/ Fixes: 5be27f1e3ec9 ("ALSA: hda/tas2781: Add tas2781 HDA driver") Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/hda/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/pci/hda/Kconfig b/sound/pci/hda/Kconfig index 91db5f8f00b6..0d7502d6e060 100644 --- a/sound/pci/hda/Kconfig +++ b/sound/pci/hda/Kconfig @@ -104,6 +104,7 @@ config SND_HDA_SCODEC_CS35L41_I2C tristate "Build CS35L41 HD-audio side codec support for I2C Bus" depends on I2C depends on ACPI + depends on EFI depends on SND_SOC select SND_SOC_CS35L41_LIB select SND_HDA_SCODEC_CS35L41 @@ -119,6 +120,7 @@ config SND_HDA_SCODEC_CS35L41_SPI tristate "Build CS35L41 HD-audio codec support for SPI Bus" depends on SPI_MASTER depends on ACPI + depends on EFI depends on SND_SOC select SND_SOC_CS35L41_LIB select SND_HDA_SCODEC_CS35L41 @@ -165,6 +167,7 @@ config SND_HDA_SCODEC_TAS2781_I2C tristate "Build TAS2781 HD-audio side codec support for I2C Bus" depends on I2C depends on ACPI + depends on EFI depends on SND_SOC select SND_SOC_TAS2781_COMLIB select SND_SOC_TAS2781_FMWLIB -- 2.35.3

1 0

[PATCH] ALSA: doc: Fix missing backquote in midi-2.0.rst
by Takashi Iwai 25 Aug '23

25 Aug '23

Fix the missing missing backquote that caused a sphinx warning: Documentation/sound/designs/midi-2.0.rst:517: WARNING: Inline interpreted text or phrase reference start-string without end-string. Fixes: e240cff9e6e9 ("ALSA: documentation: Add description for USB MIDI 2.0 gadget driver") Reported-by: Stephen Rothwell <sfr(a)canb.auug.org.au> Closes: https://lore.kernel.org/r/20230825152957.18c54ae2@canb.auug.org.au Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- Documentation/sound/designs/midi-2.0.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/sound/designs/midi-2.0.rst b/Documentation/sound/designs/midi-2.0.rst index 3b08b98354f8..45987f256b97 100644 --- a/Documentation/sound/designs/midi-2.0.rst +++ b/Documentation/sound/designs/midi-2.0.rst @@ -515,7 +515,7 @@ connection:: % echo 2 > functions/midi2.usb0/ep.0/block.1/is_midi1 For disabling the processing of UMP Stream messages in the gadget -driver, pass `0` to `process_ump attribute in the top-level config:: +driver, pass `0` to `process_ump` attribute in the top-level config:: % echo 0 > functions/midi2.usb0/process_ump -- 2.35.3

1 0

[PATCH] ALSA: hda/realtek: Add quirk for mute LEDs on HP ENVY x360 15-eu0xxx
by Fabian Vogt 25 Aug '23

25 Aug '23

The LED for the mic mute button is controlled by GPIO2. The mute button LED is slightly more complex, it's controlled by two bits in coeff 0x0b. Add a fixup for the mute LED and chain to an existing fixup for the mic mute LED. Signed-off-by: Fabian Vogt <fabian(a)ritter-vogt.de> --- Applies on top of 89bf6209cad6. I see that SungHwan Jung (CC'd) recently submitted the same fixup for a rather similar but different model as "ALSA: hda/realtek: Add quirk for HP Victus 16-d1xxx to enable mute LED" Does your HP Victus also need the ALC245_FIXUP_HP_GPIO_LED? Then we could combine the quirks. sound/pci/hda/patch_realtek.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index dc7b7a407638..cac207d7c0b9 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -4639,6 +4639,24 @@ static void alc236_fixup_hp_mute_led_coefbit2(struct hda_codec *codec, } } +/* The mute LED is controlled by two bits in coef 0x0b: + * To turn on, set bit 3 but clear bit 2. + */ +static void alc245_fixup_hp_x360_mute_led(struct hda_codec *codec, + const struct hda_fixup *fix, int action) +{ + struct alc_spec *spec = codec->spec; + + if (action == HDA_FIXUP_ACT_PRE_PROBE) { + spec->mute_led_polarity = 0; + spec->mute_led_coef.idx = 0x0b; + spec->mute_led_coef.mask = 0xc; + spec->mute_led_coef.on = 0x8; + spec->mute_led_coef.off = 0x4; + snd_hda_gen_add_mute_led_cdev(codec, coef_mute_led_set); + } +} + /* turn on/off mic-mute LED per capture hook by coef bit */ static int coef_micmute_led_set(struct led_classdev *led_cdev, enum led_brightness brightness) @@ -7231,6 +7249,7 @@ enum { ALC295_FIXUP_DELL_INSPIRON_TOP_SPEAKERS, ALC236_FIXUP_DELL_DUAL_CODECS, ALC287_FIXUP_CS35L41_I2C_2_THINKPAD_ACPI, + ALC245_FIXUP_HP_X360_MUTE_LED, }; /* A special fixup for Lenovo C940 and Yoga Duet 7; @@ -9309,6 +9328,12 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC269_FIXUP_THINKPAD_ACPI, }, + [ALC245_FIXUP_HP_X360_MUTE_LED] = { + .type = HDA_FIXUP_FUNC, + .v.func = alc245_fixup_hp_x360_mute_led, + .chained = true, + .chain_id = ALC245_FIXUP_HP_GPIO_LED + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -9551,6 +9576,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x8870, "HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT), SND_PCI_QUIRK(0x103c, 0x8873, "HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT), SND_PCI_QUIRK(0x103c, 0x887a, "HP Laptop 15s-eq2xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2), + SND_PCI_QUIRK(0x103c, 0x888a, "HP ENVY x360 Convertible 15-eu0xxx", ALC245_FIXUP_HP_X360_MUTE_LED), SND_PCI_QUIRK(0x103c, 0x888d, "HP ZBook Power 15.6 inch G8 Mobile Workstation PC", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8895, "HP EliteBook 855 G8 Notebook PC", ALC285_FIXUP_HP_SPEAKERS_MICMUTE_LED), SND_PCI_QUIRK(0x103c, 0x8896, "HP EliteBook 855 G8 Notebook PC", ALC285_FIXUP_HP_MUTE_LED), -- 2.41.0

3 4

[GIT PULL] ASoC fixes for v6.5-rc7-2
by Mark Brown 25 Aug '23

25 Aug '23

The following changes since commit 37aba3190891d4de189bd5192ee95220e295f34d: ASoC: rt1308-sdw: fix random louder sound (2023-08-13 18:16:32 +0100) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-fix-v6.5-rc7-2 for you to fetch changes up to c008323fe361bd62a43d9fb29737dacd5c067fb7: ASoC: amd: yc: Fix a non-functional mic on Lenovo 82SJ (2023-08-24 13:15:33 +0100) ---------------------------------------------------------------- ASoC: Quirk for v6.5 One additional fix for v6.5, an additional quirk. As with the other fixes this could wait for the merge window. ---------------------------------------------------------------- BrenoRCBrito (1): ASoC: amd: yc: Add VivoBook Pro 15 to quirks list for acp6x Chao Song (1): ASoC: SOF: ipc4-pcm: fix possible null pointer deference Charles Keepax (1): ASoC: cs35l41: Correct amp_gain_tlv values Kevin-Lu (1): MAINTAINERS: Add entries for TEXAS INSTRUMENTS ASoC DRIVERS Maciej Strozek (1): ASoC: cs35l56: Read firmware uuid from a device property instead of _SUB Mario Limonciello (1): ASoC: amd: yc: Fix a non-functional mic on Lenovo 82SJ Mark Brown (1): ASoC: cs35l56: Update ACPI HID and property Shenghao Ding (1): ASoC: tas2781: fixed register access error when switching to other chips Simon Trimmer (1): ASoC: cs35l56: Add an ACPI match table MAINTAINERS | 33 +++++++++++++++++++++++++++++++++ sound/soc/amd/yc/acp6x-mach.c | 9 ++++++++- sound/soc/codecs/cs35l41.c | 2 +- sound/soc/codecs/cs35l56-i2c.c | 9 +++++++++ sound/soc/codecs/cs35l56-spi.c | 9 +++++++++ sound/soc/codecs/cs35l56.c | 31 ++++++++++++------------------- sound/soc/codecs/tas2781-comlib.c | 19 ++++++++++--------- sound/soc/sof/ipc4-pcm.c | 3 +++ 8 files changed, 85 insertions(+), 30 deletions(-)

2 1

[PATCH] ASoC: soc-core.c: Do not error if a DAI link component is not found
by Cristian Ciocaltea 25 Aug '23

25 Aug '23

A recent cleanup of soc_dai_link_sanity_check() is responsible for generating lots of confusing errors before returning -EPROBE_DEFER: acp5x_mach acp5x_mach.0: ASoC: Component acp5x_i2s_dma.0 not found for link acp5x-8821-play [...] acp5x_mach acp5x_mach.0: ASoC: Component spi-VLV1776:00 not found for link acp5x-CS35L41-Stereo [...] acp5x_mach acp5x_mach.0: ASoC: Component spi-VLV1776:01 not found for link acp5x-CS35L41-Stereo Switch back to the initial behaviour of logging those messages on KERN_DEBUG level instead of KERN_ERR. While at it, use the correct form of the verb in 'component_not_find' label. Fixes: 0e66a2c69409 ("ASoC: soc-core.c: cleanup soc_dai_link_sanity_check()") Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea(a)collabora.com> --- sound/soc/soc-core.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index a5b96c17633a..cc442c52cdea 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -942,7 +942,7 @@ static int soc_dai_link_sanity_check(struct snd_soc_card *card, * component list. */ if (!soc_find_component(dlc)) - goto component_not_find; + goto component_not_found; } /* Platform check */ @@ -963,7 +963,7 @@ static int soc_dai_link_sanity_check(struct snd_soc_card *card, * component list. */ if (!soc_find_component(dlc)) - goto component_not_find; + goto component_not_found; } /* CPU check */ @@ -988,7 +988,7 @@ static int soc_dai_link_sanity_check(struct snd_soc_card *card, * Defer card registration if Component is not added */ if (!soc_find_component(dlc)) - goto component_not_find; + goto component_not_found; } } @@ -1002,8 +1002,8 @@ static int soc_dai_link_sanity_check(struct snd_soc_card *card, dev_err(card->dev, "ASoC: Neither Component name/of_node are set for %s\n", link->name); return -EINVAL; -component_not_find: - dev_err(card->dev, "ASoC: Component %s not found for link %s\n", dlc->name, link->name); +component_not_found: + dev_dbg(card->dev, "ASoC: Component %s not found for link %s\n", dlc->name, link->name); return -EPROBE_DEFER; dai_empty: -- 2.41.0

2 3

[PATCH next] ASoC: codecs: Fix error code in aw88261_i2c_probe()
by Harshit Mogalapalli 25 Aug '23

25 Aug '23

Passing zero to dev_err_probe is a success which is incorrect when i2c_check_functionality() fails. Fix this by passing -ENXIO instead of zero to dev_err_probe(). Fixes: 028a2ae25691 ("ASoC: codecs: Add aw88261 amplifier driver") Reported-by: kernel test robot <lkp(a)intel.com> Reported-by: Dan Carpenter <error27(a)gmail.com> Closes: https://lore.kernel.org/r/202308150315.CvOTIOKm-lkp@intel.com/ Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli(a)oracle.com> --- This is only compile tested. --- sound/soc/codecs/aw88261.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/aw88261.c b/sound/soc/codecs/aw88261.c index 6e2266b71386..a697b5006b45 100644 --- a/sound/soc/codecs/aw88261.c +++ b/sound/soc/codecs/aw88261.c @@ -1245,7 +1245,7 @@ static int aw88261_i2c_probe(struct i2c_client *i2c) ret = i2c_check_functionality(i2c->adapter, I2C_FUNC_I2C); if (!ret) - return dev_err_probe(&i2c->dev, ret, "check_functionality failed"); + return dev_err_probe(&i2c->dev, -ENXIO, "check_functionality failed"); aw88261 = devm_kzalloc(&i2c->dev, sizeof(*aw88261), GFP_KERNEL); if (!aw88261) -- 2.39.3

2 1

connecting second HDMI/DVI monitor mostly makes Samsung TV sound disappear
by GitHub issues - opened 25 Aug '23

25 Aug '23

alsa-project/alsa-lib issue #347 was opened from chemelnucfin: This is the same issue I posted in Pipewire: https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/3420 But I think this issue might be relevant here also so wanted to try here also. A brief summary is that my Samsung TV loses sound when I connect either HDMI to HDMI or HDMI to DVI to any of 2 Acer and 1 Samsung monitor, but an LG monitor has no problem. The sound on the TV always comes back when I disconnect the (non-working) monitor. I have attached _wpctl status_ for both when I connect LG and Acer monitors, [0824_acer_mon_wpctl_status.txt](https://github.com/alsa-project/alsa-lib/fi… [0824_LG_mon_wpctl_status.txt](https://github.com/alsa-project/alsa-lib/file… and also _alsa_info.sh_ for both monitors. [0824_acer_mon_alsa.txt](https://github.com/alsa-project/alsa-lib/files/1243… [0824_LG_mon_alsa.txt](https://github.com/alsa-project/alsa-lib/files/124338… Please let me know if you need any other information or if there are better places for help to investigate the issue. A brief search of HDMI showed this https://github.com/alsa-project/alsa-lib/issues/95 and 3 other issues which seem less relevant https://github.com/alsa-project/alsa-lib/issues/233 https://github.com/alsa-project/alsa-lib/issues/209 https://github.com/alsa-project/alsa-lib/issues/112 Issue URL : https://github.com/alsa-project/alsa-lib/issues/347 Repository URL: https://github.com/alsa-project/alsa-lib

1 0