- Alsa-devel - mailman.alsa-project.org

[PATCH v1 1/2] ALSA: hda/tas2781: Update tas2781 HDA driver
by Shenghao Ding 04 Sep '23

04 Sep '23

Support ACPI_ID both TXNW2781 and TIAS2781, and revert structure cs35l41_dev_name. Signed-off-by: Shenghao Ding <shenghao-ding(a)ti.com> --- Changes in v1: - Redefine tas2781_generic_fixup, remove hid param - TIAS2781 has been used by our customers, see following dstd.dsl. We have discussed this with them, they requested TIAS2781 must be supported for the laptops already released to market, their new laptops will switch to TXNW2781 Name (_HID, "TIAS2781") // _HID: Hardware ID Name (_UID, Zero) // _UID: Unique ID Method (_SUB, 0, NotSerialized) // _SUB: Subsystem ID { If ((SPID == Zero)) { Return ("17AA3886") } If ((SPID == One)) { Return ("17AA3884") } } - Add TXNW2781 support in comp_match_tas2781_dev_name - revert from scodec_dev_name back to cs35l41_dev_name --- sound/pci/hda/patch_realtek.c | 35 ++++++++++++++++++----------------- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index a07df6f929..1dc50fdbdf 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6745,7 +6745,7 @@ static void comp_generic_playback_hook(struct hda_pcm_stream *hinfo, struct hda_ } } -struct scodec_dev_name { +struct cs35l41_dev_name { const char *bus; const char *hid; int index; @@ -6754,7 +6754,7 @@ struct scodec_dev_name { /* match the device name in a slightly relaxed manner */ static int comp_match_cs35l41_dev_name(struct device *dev, void *data) { - struct scodec_dev_name *p = data; + struct cs35l41_dev_name *p = data; const char *d = dev_name(dev); int n = strlen(p->bus); char tmp[32]; @@ -6773,19 +6773,27 @@ static int comp_match_cs35l41_dev_name(struct device *dev, void *data) static int comp_match_tas2781_dev_name(struct device *dev, void *data) { - struct scodec_dev_name *p = data; + const char *bus = data; const char *d = dev_name(dev); - int n = strlen(p->bus); + int n = strlen(bus); char tmp[32]; /* check the bus name */ - if (strncmp(d, p->bus, n)) + if (strncmp(d, bus, n)) return 0; /* skip the bus number */ if (isdigit(d[n])) n++; + + /* exactly match either TXNW2781 or TIAS2781 */ + /* the rest must be exact matching */ + snprintf(tmp, sizeof(tmp), "-%s:00", "TXNW2781"); + + if (!strcmp(d + n, tmp)) + return 1; + /* the rest must be exact matching */ - snprintf(tmp, sizeof(tmp), "-%s:00", p->hid); + snprintf(tmp, sizeof(tmp), "-%s:00", "TIAS2781"); return !strcmp(d + n, tmp); } @@ -6795,7 +6803,7 @@ static void cs35l41_generic_fixup(struct hda_codec *cdc, int action, const char { struct device *dev = hda_codec_dev(cdc); struct alc_spec *spec = cdc->spec; - struct scodec_dev_name *rec; + struct cs35l41_dev_name *rec; int ret, i; switch (action) { @@ -6824,24 +6832,17 @@ static void cs35l41_generic_fixup(struct hda_codec *cdc, int action, const char } static void tas2781_generic_fixup(struct hda_codec *cdc, int action, - const char *bus, const char *hid) + const char *bus) { struct device *dev = hda_codec_dev(cdc); struct alc_spec *spec = cdc->spec; - struct scodec_dev_name *rec; int ret; switch (action) { case HDA_FIXUP_ACT_PRE_PROBE: - rec = devm_kmalloc(dev, sizeof(*rec), GFP_KERNEL); - if (!rec) - return; - rec->bus = bus; - rec->hid = hid; - rec->index = 0; spec->comps[0].codec = cdc; component_match_add(dev, &spec->match, - comp_match_tas2781_dev_name, rec); + comp_match_tas2781_dev_name, (void *)bus); ret = component_master_add_with_match(dev, &comp_master_ops, spec->match); if (ret) @@ -6888,7 +6889,7 @@ static void alc287_fixup_legion_16ithg6_speakers(struct hda_codec *cdc, const st static void tas2781_fixup_i2c(struct hda_codec *cdc, const struct hda_fixup *fix, int action) { - tas2781_generic_fixup(cdc, action, "i2c", "TIAS2781"); + tas2781_generic_fixup(cdc, action, "i2c"); } /* for alc295_fixup_hp_top_speakers */ -- 2.34.1

3 5

Alsa Lib segfaults when built statically
by GitHub issues - edited 04 Sep '23

04 Sep '23

alsa-project/alsa-lib issue #349 was edited from cybersoulK: I am building a game that uses alsa. All of my linux players segfault. This has been going for over 1 year. Alsa-lib is built statically on a ubuntu machine with the following commands: ``` git clone https://github.com/alsa-project/alsa-lib cd alsa-lib apt-get update apt-get install libtool apt-get install make apt install autoconf autoreconf -i ./configure --disable-shared make ``` Then i use libasound.a to build my Rust executable (On my mac machine). I do the same process to build openssl for linux and it works great. So There definitely is an issue when building alsa lib statically. One of my players was able to provide me with a core dump that might be helpful to track down the fault: <img width="770" alt="image" src="https://github.com/alsa-project/alsa-lib/assets/102260392/7390b851-47a1-4e5…"> [coredump.txt](https://github.com/alsa-project/alsa-lib/files/12508784/cored… Issue URL : https://github.com/alsa-project/alsa-lib/issues/349 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Alsa Lib segfaults when built statically
by GitHub issues - edited 04 Sep '23

04 Sep '23

alsa-project/alsa-lib issue #349 was edited from cybersoulK: I am building a game that uses alsa. All of my linux players segfault. This has been going for over 1 year. Alsa-lib is built statically on a ubuntu machine with the following commands: ``` git clone https://github.com/alsa-project/alsa-lib cd alsa-lib apt-get update apt-get install libtool apt-get install make apt install autoconf autoreconf -i ./configure --disable-shared make ``` Then i use libasound.a to build my Rust executable (On my mac machine). I do the same process to build openssl for linux and it works great. So There definitely is an issue when building alsa lib statically. One of my players was able to provide me with a core dump that might be helpful to track the fault: <img width="770" alt="image" src="https://github.com/alsa-project/alsa-lib/assets/102260392/7390b851-47a1-4e5…"> [coredump.txt](https://github.com/alsa-project/alsa-lib/files/12508784/cored… Issue URL : https://github.com/alsa-project/alsa-lib/issues/349 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Alsa Lib segfaults when built statically
by GitHub issues - edited 04 Sep '23

04 Sep '23

alsa-project/alsa-lib issue #349 was edited from cybersoulK: I am building a game that uses alsa. All of my linux players segfault. Alsa Lib is built statically on a ubuntu machine with the following commands: ``` git clone https://github.com/alsa-project/alsa-lib cd alsa-lib apt-get update apt-get install libtool apt-get install make apt install autoconf autoreconf -i ./configure --disable-shared make ``` Then i use libasound.a to build my Rust executable (On my mac machine). I do the same process to build openssl for linux and it works great. So There definitely is an issue when building alsa lib statically. One of my players was able to provide me with a core dump that might be helpful to track the fault: <img width="770" alt="image" src="https://github.com/alsa-project/alsa-lib/assets/102260392/7390b851-47a1-4e5…"> [coredump.txt](https://github.com/alsa-project/alsa-lib/files/12508784/cored… Issue URL : https://github.com/alsa-project/alsa-lib/issues/349 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Alsa Lib segfaults when built statically
by GitHub issues - edited 04 Sep '23

04 Sep '23

alsa-project/alsa-lib issue #349 was edited from cybersoulK: I am building a game that uses alsa. All of my linux players executables segfault. Alsa Lib is built statically on a ubuntu machine with the following commands: ``` git clone https://github.com/alsa-project/alsa-lib cd alsa-lib apt-get update apt-get install libtool apt-get install make apt install autoconf autoreconf -i ./configure --disable-shared make ``` Then i use libasound.a to build my Rust executable (On my mac machine). I do the same process to build openssl for linux and it works great. So There definitely is an issue when building alsa lib statically. One of my players was able to provide me with a core dump that might be helpful to track the fault: <img width="770" alt="image" src="https://github.com/alsa-project/alsa-lib/assets/102260392/7390b851-47a1-4e5…"> [coredump.txt](https://github.com/alsa-project/alsa-lib/files/12508784/cored… Issue URL : https://github.com/alsa-project/alsa-lib/issues/349 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Alsa Lib segfaults when built statically
by GitHub issues - opened 04 Sep '23

04 Sep '23

alsa-project/alsa-lib issue #349 was opened from cybersoulK: I building a game that uses alsa for linux. All of my linux players executables segfault. Alsa Lib is built statically on a ubuntu machine with the following commands: ``` git clone https://github.com/alsa-project/alsa-lib cd alsa-lib apt-get update apt-get install libtool apt-get install make apt install autoconf autoreconf -i ./configure --disable-shared make ``` Then i use libasound.a to build my Rust executable (On my mac machine). I do the same process to build openssl for linux and it works great. So There definitely is an issue when building alsa lib statically. One of my players was able to provide me with a core dump that might be helpful to track the fault: <img width="770" alt="image" src="https://github.com/alsa-project/alsa-lib/assets/102260392/7390b851-47a1-4e5…"> [coredump.txt](https://github.com/alsa-project/alsa-lib/files/12508784/cored… Issue URL : https://github.com/alsa-project/alsa-lib/issues/349 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH 0/2][RFC] Refactor snd primitives refcounters
by cujomalainey＠chromium.org 04 Sep '23

04 Sep '23

From: Curtis Malainey <cujomalainey(a)chromium.org> As previously identified in [1] there are some issues with how kobjs are handled in sound/core. The solution provided in [2] is a workaround for the issues to fix the failures. This series is a first attempt at the larger refactor needed to properly handle the objects. [1] https://mailman.alsa-project.org/hyperkitty/list/alsa-devel@alsa-project.or… [2] https://mailman.alsa-project.org/hyperkitty/list/alsa-devel@alsa-project.or… Curtis Malainey (2): ALSA: core: add snd_device_init ALSA: core: split control primitives out of snd_card include/sound/control.h | 1 + include/sound/core.h | 34 +-- sound/core/control.c | 330 +++++++++++++---------- sound/core/control_compat.c | 8 +- sound/core/control_led.c | 18 +- sound/core/init.c | 33 +-- sound/pci/hda/hda_codec.c | 3 +- sound/soc/intel/atom/sst-atom-controls.c | 8 +- sound/soc/soc-card.c | 2 +- sound/usb/media.c | 2 +- 10 files changed, 249 insertions(+), 190 deletions(-) -- 2.42.0.rc1.204.g551eb34607-goog

5 9

[PATCH] ALSA: scarlett2: Fix a potential memory leak in scarlett2_init_notify()
by Christophe JAILLET 03 Sep '23

03 Sep '23

If kmalloc() fails, we should release 'mixer->urb'. Fixes: 9e4d5c1be21f ("ALSA: usb-audio: Scarlett Gen 2 mixer interface") Signed-off-by: Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> --- sound/usb/mixer_scarlett_gen2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/usb/mixer_scarlett_gen2.c b/sound/usb/mixer_scarlett_gen2.c index 9d11bb08667e..a439c7f64b2e 100644 --- a/sound/usb/mixer_scarlett_gen2.c +++ b/sound/usb/mixer_scarlett_gen2.c @@ -4060,8 +4060,10 @@ static int scarlett2_init_notify(struct usb_mixer_interface *mixer) return -ENOMEM; transfer_buffer = kmalloc(private->wMaxPacketSize, GFP_KERNEL); - if (!transfer_buffer) + if (!transfer_buffer) { + usb_free_urb(mixer->urb); return -ENOMEM; + } usb_fill_int_urb(mixer->urb, dev, pipe, transfer_buffer, private->wMaxPacketSize, -- 2.34.1

2 2

1.2.10: control.h missing definitions for snd_ump_endpoint_info_t and snd_ump_block_info_t
by GitHub issues - opened 03 Sep '23

03 Sep '23

alsa-project/alsa-lib issue #348 was opened from ajakk: When configured with raw MIDI support, `control.h` declares: ``` int snd_ctl_ump_endpoint_info(snd_ctl_t *ctl, snd_ump_endpoint_info_t *info); int snd_ctl_ump_block_info(snd_ctl_t *ctl, snd_ump_block_info_t *info); ``` However, it doesn't seem that the `snd_ump*` types are defined here, and this results in build failures in applications compiling against alsa-lib-1.2.10. [For example](https://bugs.gentoo.org/913521) ([build log](https://913521.bugs.gentoo.org/attachment.cgi?id=869245)): ``` [77/90] /usr/bin/x86_64-pc-linux-gnu-g++ -I/var/tmp/portage/x11-misc/polybar-3.6.3-r3/work/polybar-3.6.3/include -I/var/tmp/portage/x11-misc/polybar-3.6.3-r3/work/polybar-3.6.3_build/generated-sources -isystem /usr/include/cairo -isystem /usr/include/libpng16 -isystem /usr/include/freetype2 -isystem /usr/include/pixman-1 -isystem /var/tmp/portage/x11-misc/polybar-3.6.3-r3/work/polybar-3.6.3/lib/xpp/include -isystem /var/tmp/portage/x11-misc/polybar-3.6.3-r3/work/polybar-3.6.3_build/lib/xpp/generated-sources/include -O2 -pipe -march=native -fno-diagnostics-color -std=c++14 -fno-diagnostics-color -Wall -Wextra -Wpedantic -Wsuggest-override -MD -MT bin/CMakeFiles/poly.dir/adapters/alsa/control.cpp.o -MF bin/CMakeFiles/poly.dir/adapters/alsa/control.cpp.o.d -o bin/CMakeFiles/poly.dir/adapters/alsa/control.cpp.o -c /var/tmp/portage/x11-misc/polybar-3.6.3-r3/work/polybar-3.6.3/src/adapters/alsa/control.cpp FAILED: bin/CMakeFiles/poly.dir/adapters/alsa/control.cpp.o /usr/bin/x86_64-pc-linux-gnu-g++ -I/var/tmp/portage/x11-misc/polybar-3.6.3-r3/work/polybar-3.6.3/include -I/var/tmp/portage/x11-misc/polybar-3.6.3-r3/work/polybar-3.6.3_build/generated-sources -isystem /usr/include/cairo -isystem /usr/include/libpng16 -isystem /usr/include/freetype2 -isystem /usr/include/pixman-1 -isystem /var/tmp/portage/x11-misc/polybar-3.6.3-r3/work/polybar-3.6.3/lib/xpp/include -isystem /var/tmp/portage/x11-misc/polybar-3.6.3-r3/work/polybar-3.6.3_build/lib/xpp/generated-sources/include -O2 -pipe -march=native -fno-diagnostics-color -std=c++14 -fno-diagnostics-color -Wall -Wextra -Wpedantic -Wsuggest-override -MD -MT bin/CMakeFiles/poly.dir/adapters/alsa/control.cpp.o -MF bin/CMakeFiles/poly.dir/adapters/alsa/control.cpp.o.d -o bin/CMakeFiles/poly.dir/adapters/alsa/control.cpp.o -c /var/tmp/portage/x11-misc/polybar-3.6.3-r3/work/polybar-3.6.3/src/adapters/alsa/control.cpp In file included from /var/tmp/portage/x11-misc/polybar-3.6.3-r3/work/polybar-3.6.3/include/adapters/alsa/generic.hpp:37, from /var/tmp/portage/x11-misc/polybar-3.6.3-r3/work/polybar-3.6.3/src/adapters/alsa/control.cpp:2: /usr/include/alsa/control.h:417:47: error: ‘snd_ump_endpoint_info_t’ has not been declared 417 | int snd_ctl_ump_endpoint_info(snd_ctl_t *ctl, snd_ump_endpoint_info_t *info); | ^~~~~~~~~~~~~~~~~~~~~~~ /usr/include/alsa/control.h:418:44: error: ‘snd_ump_block_info_t’ has not been declared 418 | int snd_ctl_ump_block_info(snd_ctl_t *ctl, snd_ump_block_info_t *info); | ^~~~~~~~~~~~~~~~~~~~ ``` Issue URL : https://github.com/alsa-project/alsa-lib/issues/348 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH 1/2] ALSA: pcm: Fix error checks of default read/write copy ops
by Takashi Iwai 02 Sep '23

02 Sep '23

copy_from/to_iter() returns the actually copied bytes, and the more correct check should be to compare with the given bytes, instead of zero-check. Fixes: cf393babb37a ("ALSA: pcm: Add copy ops with iov_iter") Reported-by: Al Viro <viro(a)zeniv.linux.org.uk> Closes: https://lore.kernel.org/r/20230902053044.GJ3390869@ZenIV Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/core/pcm_lib.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c index 4859fb1caec9..a11cd7d6295f 100644 --- a/sound/core/pcm_lib.c +++ b/sound/core/pcm_lib.c @@ -1992,8 +1992,8 @@ static int default_write_copy(struct snd_pcm_substream *substream, int channel, unsigned long hwoff, struct iov_iter *iter, unsigned long bytes) { - if (!copy_from_iter(get_dma_ptr(substream->runtime, channel, hwoff), - bytes, iter)) + if (copy_from_iter(get_dma_ptr(substream->runtime, channel, hwoff), + bytes, iter) != bytes) return -EFAULT; return 0; } @@ -2025,8 +2025,8 @@ static int default_read_copy(struct snd_pcm_substream *substream, int channel, unsigned long hwoff, struct iov_iter *iter, unsigned long bytes) { - if (!copy_to_iter(get_dma_ptr(substream->runtime, channel, hwoff), - bytes, iter)) + if (copy_to_iter(get_dma_ptr(substream->runtime, channel, hwoff), + bytes, iter) != bytes) return -EFAULT; return 0; } -- 2.35.3

1 1