- Alsa-devel - mailman.alsa-project.org

[PATCH v2 0/2] Support mute notifications for CS35L41 HDA
by Stefan Binding 18 Sep '23

18 Sep '23

Some systems use a special keyboard shortcut to mute speaker audio. On systems using CS35L41 HDA which have this shortcut, add a mechanism which uses ACPI notifications to determine when the shortcut is pressed, and then mute the amps inside the driver. Since this is not a normal mute mechanism, it does not go through userspace. To allow userspace to be able to track this special state, add an ALSA control which tracks the state of this forced mute Stefan Binding (1): ALSA: hda: cs35l41: Add read-only ALSA control for forced mute Vitaly Rodionov (1): ALSA: hda: cs35l41: Support mute notifications for CS35L41 HDA sound/pci/hda/cs35l41_hda.c | 132 ++++++++++++++++++++++++++++++---- sound/pci/hda/cs35l41_hda.h | 3 + sound/pci/hda/hda_component.h | 4 ++ sound/pci/hda/patch_realtek.c | 57 ++++++++++++++- 4 files changed, 182 insertions(+), 14 deletions(-) -- 2.34.1

3 5

[PATCH] ALSA: dummy: Fix &dpcm->lock deadlock issues
by YE Chengfeng 18 Sep '23

18 Sep '23

The timer dummy_systimer_callback is executed under softirq context, thus other process context code requiring the same lock should disable interrupt. Otherwise there would be potential deadlock issues when the code executing under process context (i.e., dummy_systimer_pointer, dummy_systimer_start, dummy_systimer_stop) is preempted by the timer while holding the lock. Deadlock scenario: dummy_systimer_pointer -> spin_lock(&dpcm->lock); <timer interrupt> -> dummy_systimer_callback -> spin_lock_irqsave(&dpcm->lock, flags); Fix the potential deadlock by using spin_lock_irqsave. Signed-off-by: Chengfeng Ye <cyeaa(a)connect.ust.hk> --- sound/drivers/dummy.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/sound/drivers/dummy.c b/sound/drivers/dummy.c index 9c17b49a2ae1..04fb4f17e05c 100644 --- a/sound/drivers/dummy.c +++ b/sound/drivers/dummy.c @@ -268,19 +268,23 @@ static void dummy_systimer_update(struct dummy_systimer_pcm *dpcm) static int dummy_systimer_start(struct snd_pcm_substream *substream) { struct dummy_systimer_pcm *dpcm = substream->runtime->private_data; - spin_lock(&dpcm->lock); + unsigned long flags; + + spin_lock_irqsave(&dpcm->lock, flags); dpcm->base_time = jiffies; dummy_systimer_rearm(dpcm); - spin_unlock(&dpcm->lock); + spin_unlock_irqrestore(&dpcm->lock, flags); return 0; } static int dummy_systimer_stop(struct snd_pcm_substream *substream) { struct dummy_systimer_pcm *dpcm = substream->runtime->private_data; - spin_lock(&dpcm->lock); + unsigned long flags; + + spin_lock_irqsave(&dpcm->lock, flags); del_timer(&dpcm->timer); - spin_unlock(&dpcm->lock); + spin_unlock_irqrestore(&dpcm->lock, flags); return 0; } @@ -320,11 +324,12 @@ dummy_systimer_pointer(struct snd_pcm_substream *substream) { struct dummy_systimer_pcm *dpcm = substream->runtime->private_data; snd_pcm_uframes_t pos; + unsigned long flags; - spin_lock(&dpcm->lock); + spin_lock_irqsave(&dpcm->lock, flags); dummy_systimer_update(dpcm); pos = dpcm->frac_pos / HZ; - spin_unlock(&dpcm->lock); + spin_unlock_irqrestore(&dpcm->lock, flags); return pos; } -- 2.17.1

2 4

[PATCH 0/4] ALSA: scarlett2: Driver updates
by Geoffrey D. Bennett 18 Sep '23

18 Sep '23

Hi Takashi, I think it's time to enable this driver by default because: - Early versions of this mixer driver did not work on all hardware, so out of caution the driver was disabled by default and had to be explicitly enabled with device_setup=1. - Since commit 764fa6e686e0 ("ALSA: usb-audio: scarlett2: Fix device hang with ehci-pci") (21/May/2021) no more problems of this nature have been reported. - Therefore, patch 1 in this series proposes to enable the driver by default, but provide a new device_setup option to disable the driver in case that is needed. Patch 3 adds support for the Clarett 8Pre USB. This is the first device supported by this driver which is controlled identically to another, so patch 2 first allows sharing the device_info struct between models. Patch 4 adds the specific product series name (like "Scarlett Gen 2") to various messages so the text is correct without being unwieldy & generic (like "Scarlett Gen 2/3/Clarett USB/Clarett+"). Geoffrey D. Bennett (4): ALSA: scarlett2: Default mixer driver to enabled ALSA: scarlett2: Move USB IDs out from device_info struct ALSA: scarlett2: Add support for Clarett 8Pre USB ALSA: scarlett2: Add correct product series name to messages sound/usb/mixer_quirks.c | 1 + sound/usb/mixer_scarlett_gen2.c | 148 ++++++++++++++++++-------------- 2 files changed, 83 insertions(+), 66 deletions(-) -- 2.41.0

2 5

[PATCH] asoc: mediatek: common: Remove check of return value of mtk_memif_set_addr() and mtk_memif_set_format()
by Alexandra Diupina 18 Sep '23

18 Sep '23

The mtk_memif_set_addr() and mtk_memif_set_format() functions always returns 0, so it is necessary to remove the check of its return value (which was probably specified by analogy with the check of return values for other functions) to make the code more readable Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: df799b9502ed ("ASoC: mediatek: common: refine hw_params and hw_prepare") Signed-off-by: Alexandra Diupina <adiupina(a)astralinux.ru> --- sound/soc/mediatek/common/mtk-afe-fe-dai.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/sound/soc/mediatek/common/mtk-afe-fe-dai.c b/sound/soc/mediatek/common/mtk-afe-fe-dai.c index 882cdf86c8bf..3c8a11c5958d 100644 --- a/sound/soc/mediatek/common/mtk-afe-fe-dai.c +++ b/sound/soc/mediatek/common/mtk-afe-fe-dai.c @@ -143,15 +143,10 @@ int mtk_afe_fe_hw_params(struct snd_pcm_substream *substream, substream->runtime->dma_bytes); /* set addr */ - ret = mtk_memif_set_addr(afe, id, + mtk_memif_set_addr(afe, id, substream->runtime->dma_area, substream->runtime->dma_addr, substream->runtime->dma_bytes); - if (ret) { - dev_err(afe->dev, "%s(), error, id %d, set addr, ret %d\n", - __func__, id, ret); - return ret; - } /* set channel */ ret = mtk_memif_set_channel(afe, id, channels); @@ -170,12 +165,7 @@ int mtk_afe_fe_hw_params(struct snd_pcm_substream *substream, } /* set format */ - ret = mtk_memif_set_format(afe, id, format); - if (ret) { - dev_err(afe->dev, "%s(), error, id %d, set format %d, ret %d\n", - __func__, id, format, ret); - return ret; - } + mtk_memif_set_format(afe, id, format); return 0; } -- 2.30.2

2 1

[PATCH V3 0/5] ASoC: codecs: Add aw87390 amplifier driver
by wangweidong.a＠awinic.com 18 Sep '23

18 Sep '23

From: Weidong Wang <wangweidong.a(a)awinic.com> The awinic aw87390 is a new high efficiency, low noise, constant large volume, 6th Smart K audio amplifier. Add a DT schema for describing awinic aw87390 audio amplifiers. They are controlled using I2C. v2 -> v3: Modify the type of "awinic,sync-flag" property to bool Modify function return value Modify commit information Change the name of "sync-flag" to "awinic,sync-flag" Weidong Wang (5): ASoC: dt-bindings: awinic,aw88395: Add properties for multiple PA support ASoC: dt-bindings: Add schema for "awinic,aw87390" ASoC: codecs: Add code for bin parsing compatible with aw87390 ASoC: codecs: Change the aw88261 variable name and i2c driver name ASoC: codecs: Add aw87390 amplifier driver .../bindings/sound/awinic,aw87390.yaml | 58 +++ .../bindings/sound/awinic,aw88395.yaml | 16 + sound/soc/codecs/Kconfig | 15 +- sound/soc/codecs/Makefile | 2 + sound/soc/codecs/aw87390.c | 462 ++++++++++++++++++ sound/soc/codecs/aw87390.h | 85 ++++ sound/soc/codecs/aw88261.c | 27 +- sound/soc/codecs/aw88261.h | 4 +- sound/soc/codecs/aw88395/aw88395.c | 9 +- sound/soc/codecs/aw88395/aw88395.h | 2 +- sound/soc/codecs/aw88395/aw88395_device.c | 47 +- sound/soc/codecs/aw88395/aw88395_device.h | 6 +- sound/soc/codecs/aw88395/aw88395_lib.c | 25 +- sound/soc/codecs/aw88395/aw88395_reg.h | 1 + 14 files changed, 686 insertions(+), 73 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/awinic,aw87390.yaml create mode 100644 sound/soc/codecs/aw87390.c create mode 100644 sound/soc/codecs/aw87390.h base-commit: ce9ecca0238b140b88f43859b211c9fdfd8e5b70 -- 2.41.0

2 6

[PATCH 0/2] ASoC: Add rtq9128 audio amplifier
by cy_huang＠richtek.com 18 Sep '23

18 Sep '23

From: ChiYuan Huang <cy_huang(a)richtek.com> This patch series adds Richtek rtq9128 automotive audio amplifier support. It can deliver up to 4x75W into 4Ohm speaker from a 25V supply in automotive applications. ChiYuan Huang (2): ASoC: dt-bindings: Add Richtek rtq9128 audio amplifier ASoC: codecs: Add Richtek rtq9128audio amplifier support .../bindings/sound/richtek,rtq9128.yaml | 51 ++ sound/soc/codecs/Kconfig | 15 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/rtq9128.c | 742 ++++++++++++++++++ 4 files changed, 810 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/richtek,rtq9128.yaml create mode 100644 sound/soc/codecs/rtq9128.c base-commit: ce9ecca0238b140b88f43859b211c9fdfd8e5b70 -- 2.34.1

2 3

[PATCH] soundwire: bus: Add explicit include for irqdomain.h
by Charles Keepax 18 Sep '23

18 Sep '23

This header should be explicitly included, to make sure it is included for all Kconfigs. Fixes: 12a95123bfe1 ("soundwire: bus: Allow SoundWire peripherals to register IRQ handlers") Reported-by: kernel test robot <lkp(a)intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202309150522.MoKeF4jx-lkp@intel.com/ Signed-off-by: Charles Keepax <ckeepax(a)opensource.cirrus.com> --- drivers/soundwire/bus.c | 1 + drivers/soundwire/bus_type.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c index 1720031f35a35..5869b71f10923 100644 --- a/drivers/soundwire/bus.c +++ b/drivers/soundwire/bus.c @@ -4,6 +4,7 @@ #include <linux/acpi.h> #include <linux/delay.h> #include <linux/irq.h> +#include <linux/irqdomain.h> #include <linux/mod_devicetable.h> #include <linux/pm_runtime.h> #include <linux/soundwire/sdw_registers.h> diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c index fafbc284e82da..dc9c508f48a4b 100644 --- a/drivers/soundwire/bus_type.c +++ b/drivers/soundwire/bus_type.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 // Copyright(c) 2015-17 Intel Corporation. +#include <linux/irqdomain.h> #include <linux/module.h> #include <linux/mod_devicetable.h> #include <linux/pm_domain.h> -- 2.30.2

1 1

bat: really skip analysis of the first period and update related comment
by GitHub pull_request - edited 18 Sep '23

18 Sep '23

alsa-project/alsa-utils pull request #237 was edited from dbrignoli: Prior to this change bat/analyze.c would skip the last period of the recording, contrary to the comment in the code which stated the first period was meant to be skipped. The comment has been updated to state that both the first and last period are skipped and the code has been updated to match. Request URL : https://github.com/alsa-project/alsa-utils/pull/237 Patch URL : https://github.com/alsa-project/alsa-utils/pull/237.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

bat: really skip analysis of the first period and update related comment
by GitHub pull_request - opened 18 Sep '23

18 Sep '23

alsa-project/alsa-utils pull request #237 was opened from dbrignoli: Prior to this change bat/analyze.c would skip the last period of the recording, contrary to what the comment in the code which stated the first period was meant to be skipped. The comment has been updated to state that both the first and last period are skipped and the code has been updated to match. Request URL : https://github.com/alsa-project/alsa-utils/pull/237 Patch URL : https://github.com/alsa-project/alsa-utils/pull/237.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[PATCH v3 0/3] ASoC: wm8782: Allow higher audio rates
by John Watts 18 Sep '23

18 Sep '23

The wm8782 supports higher audio rates than just 48kHz. This is configured by setting the FSAMPEN pin on the codec chip. This patch series introduces the 'wlf,fsampen' device tree property to indicate the pin status and control the maximum rate available when using the codec. v2 -> v3: - Rate is now properly constrained using ALSA constraints v1 -> v2: - Switched from max-rate property to wlf,fsampen property - Clarified property is optional, not required John Watts (3): ASoC: wm8782: Constrain maximum audio rate at runtime ASoC: wm8782: Use wlf,fsampen device tree property ASoC: dt-bindings: wlf,wm8782: Add wlf,fsampen property .../devicetree/bindings/sound/wm8782.txt | 5 ++ sound/soc/codecs/wm8782.c | 63 +++++++++++++++---- 2 files changed, 55 insertions(+), 13 deletions(-) -- 2.42.0

2 7