- Alsa-devel - mailman.alsa-project.org

[PATCH 5.10 1/1] ASoC: ops: Check for negative values before reading them
by d.privalov 12 Mar '25

12 Mar '25

From: Mark Brown <broonie(a)kernel.org> commit 1601033da2dd2052e0489137f7788a46a8fcd82f upstream. The controls allow inputs to be specified as negative but our manipulating them into register fields need to be done on unsigned variables so the checks for negative numbers weren't taking effect properly. Do the checks for negative values on the variable in the ABI struct rather than on our local unsigned copy. Signed-off-by: Mark Brown <broonie(a)kernel.org> Link: https://lore.kernel.org/r/20220128192443.3504823-1-broonie@kernel.org Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Dmitriy Privalov <d.privalov(a)omp.ru> --- sound/soc/soc-ops.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/soc/soc-ops.c b/sound/soc/soc-ops.c index a83cd8d8a9633..a1087dfee532d 100644 --- a/sound/soc/soc-ops.c +++ b/sound/soc/soc-ops.c @@ -316,26 +316,26 @@ int snd_soc_put_volsw(struct snd_kcontrol *kcontrol, if (sign_bit) mask = BIT(sign_bit + 1) - 1; + if (ucontrol->value.integer.value[0] < 0) + return -EINVAL; val = ucontrol->value.integer.value[0]; if (mc->platform_max && ((int)val + min) > mc->platform_max) return -EINVAL; if (val > max - min) return -EINVAL; - if (val < 0) - return -EINVAL; val = (val + min) & mask; if (invert) val = max - val; val_mask = mask << shift; val = val << shift; if (snd_soc_volsw_is_stereo(mc)) { + if (ucontrol->value.integer.value[1] < 0) + return -EINVAL; val2 = ucontrol->value.integer.value[1]; if (mc->platform_max && ((int)val2 + min) > mc->platform_max) return -EINVAL; if (val2 > max - min) return -EINVAL; - if (val2 < 0) - return -EINVAL; val2 = (val2 + min) & mask; if (invert) val2 = max - val2; @@ -429,13 +429,13 @@ int snd_soc_put_volsw_sx(struct snd_kcontrol *kcontrol, int err = 0; unsigned int val, val_mask, val2 = 0; + if (ucontrol->value.integer.value[0] < 0) + return -EINVAL; val = ucontrol->value.integer.value[0]; if (mc->platform_max && val > mc->platform_max) return -EINVAL; if (val > max) return -EINVAL; - if (val < 0) - return -EINVAL; val_mask = mask << shift; val = (val + min) & mask; val = val << shift; -- 2.34.1

1 0

Add SetLED macro to hide implementation details for LED handling
by GitHub pull_request - opened 11 Mar '25

11 Mar '25

alsa-project/alsa-ucm-conf pull request #517 was opened from perexg: This change also reduces modprobe calls when settings is split to multiple configuration files. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/517 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/517.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

USB-Audio: Improve support for Focusrite 4th Gen devices
by GitHub pull_request - opened 10 Mar '25

10 Mar '25

alsa-project/alsa-ucm-conf pull request #516 was opened from perexg: There are 4 capture channels. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/516 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/516.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH 00/14] Implement acp_common_hw_ops support for all platforms
by Venkata Prasad Potturu 10 Mar '25

10 Mar '25

This patch series is to implement acp_common_hw_ops support and refactor interrupt handler registration and interrupt handling. Venkata Prasad Potturu (14): ASoC: amd: acp: Remove redundant acp70 chip->name ASoC: amd: acp: Implement acp_common_hw_ops support for acp platforms ASoC: amd: acp: Refactor dmic-codec platform device creation ASoC: amd: acp: Refactor acp platform device creation ASoC: amd: acp: Refactor acp machine select ASoC: amd: acp: Add new interrupt handle callbacks in acp_common_hw_ops ASoC: amd: acp: Remove redundant acp_dev_data structure ASoC: amd: acp: Move spin_lock and list initialization to acp-pci driver ASoC: amd: acp: Remove white line ASoC: amd: acp: Refactor acp70 platform resource structure ASoC: amd: acp: Refactor acp63 platform resource structure ASoC: amd: acp: Refactor rembrant platform resource structure ASoC: amd: acp: Refactor renoir platform resource structure ASoC: amd: acp: Fix for enabling DMIC on acp platforms via _DSD entry sound/soc/amd/acp/acp-i2s.c | 185 +++++++++--------- sound/soc/amd/acp/acp-legacy-common.c | 254 ++++++++++++++++++------ sound/soc/amd/acp/acp-pci.c | 210 ++++++++++++-------- sound/soc/amd/acp/acp-pdm.c | 53 +++-- sound/soc/amd/acp/acp-platform.c | 145 ++++---------- sound/soc/amd/acp/acp-rembrandt.c | 111 +++-------- sound/soc/amd/acp/acp-renoir.c | 110 ++--------- sound/soc/amd/acp/acp63.c | 94 +++------ sound/soc/amd/acp/acp70.c | 84 +++----- sound/soc/amd/acp/amd.h | 270 +++++++++++++++++++++----- sound/soc/amd/acp/chip_offset_byte.h | 12 +- 11 files changed, 792 insertions(+), 736 deletions(-) -- 2.39.2

3 18

[PATCH alsa-ucm-conf] sof-soundwire: Split cs42l43 dmic initialisation
by Charles Keepax 10 Mar '25

10 Mar '25

Split the initialisation of cs42l43 into a headset part and a dmic part. This will prevent the dmic mute controls getting attached to the mute LED when the codec dmics are not being used. Signed-off-by: Charles Keepax <ckeepax(a)opensource.cirrus.com> --- ucm2/codecs/cs42l43-dmic/init.conf | 23 +++++++++++++++++++++++ ucm2/codecs/cs42l43/init.conf | 11 +---------- ucm2/sof-soundwire/sof-soundwire.conf | 2 +- 3 files changed, 25 insertions(+), 11 deletions(-) create mode 100644 ucm2/codecs/cs42l43-dmic/init.conf diff --git a/ucm2/codecs/cs42l43-dmic/init.conf b/ucm2/codecs/cs42l43-dmic/init.conf new file mode 100644 index 0000000..441d082 --- /dev/null +++ b/ucm2/codecs/cs42l43-dmic/init.conf @@ -0,0 +1,23 @@ +# cs42l43 specific control settings + +LibraryConfig.remap.Config { + ctl.default.map { + "name='cs42l43 Microphone Capture Switch'" { + "name='cs42l43 Decimator 3 Switch'".vindex.0 0 + "name='cs42l43 Decimator 4 Switch'".vindex.1 0 + } + "name='cs42l43 Microphone Capture Volume'" { + "name='cs42l43 Decimator 3 Volume'".vindex.0 0 + "name='cs42l43 Decimator 4 Volume'".vindex.1 0 + } + } +} + +FixedBootSequence [ + cset "name='cs42l43 Decimator 3 Switch' 0" + cset "name='cs42l43 Decimator 4 Switch' 0" + exec "-/sbin/modprobe snd_ctl_led" + sysw "-/class/sound/ctl-led/mic/card${CardNumber}/attach:cs42l43 Decimator 3 Switch" + sysw "-/class/sound/ctl-led/mic/card${CardNumber}/attach:cs42l43 Decimator 4 Switch" +] + diff --git a/ucm2/codecs/cs42l43/init.conf b/ucm2/codecs/cs42l43/init.conf index 0fbb517..8e41a0f 100644 --- a/ucm2/codecs/cs42l43/init.conf +++ b/ucm2/codecs/cs42l43/init.conf @@ -2,14 +2,6 @@ LibraryConfig.remap.Config { ctl.default.map { - "name='cs42l43 Microphone Capture Switch'" { - "name='cs42l43 Decimator 3 Switch'".vindex.0 0 - "name='cs42l43 Decimator 4 Switch'".vindex.1 0 - } - "name='cs42l43 Microphone Capture Volume'" { - "name='cs42l43 Decimator 3 Volume'".vindex.0 0 - "name='cs42l43 Decimator 4 Volume'".vindex.1 0 - } "name='cs42l43 Headset Microphone Capture Switch'" { "name='cs42l43 Decimator 1 Switch'".vindex.0 0 } @@ -20,8 +12,7 @@ LibraryConfig.remap.Config { } FixedBootSequence [ + cset "name='cs42l43 Decimator 1 Switch' 0" exec "-/sbin/modprobe snd_ctl_led" sysw "-/class/sound/ctl-led/mic/card${CardNumber}/attach:cs42l43 Decimator 1 Switch" - sysw "-/class/sound/ctl-led/mic/card${CardNumber}/attach:cs42l43 Decimator 3 Switch" - sysw "-/class/sound/ctl-led/mic/card${CardNumber}/attach:cs42l43 Decimator 4 Switch" ] diff --git a/ucm2/sof-soundwire/sof-soundwire.conf b/ucm2/sof-soundwire/sof-soundwire.conf index 96d2966..57e5610 100644 --- a/ucm2/sof-soundwire/sof-soundwire.conf +++ b/ucm2/sof-soundwire/sof-soundwire.conf @@ -114,7 +114,7 @@ If.hs_init { If.mic_init { Condition { Type RegexMatch - Regex "(rt712-dmic|rt713-dmic|rt715(-sdca)?)" + Regex "(cs42l43-dmic|rt712-dmic|rt713-dmic|rt715(-sdca)?)" String "${var:MicCodec1}" } True.Include.mic_init.File "/codecs/${var:MicCodec1}/init.conf" -- 2.39.5

2 1

Channel count in Focusrite Scarlett Gen 4 (1235:8218) SplitPCM configuration
by GitHub issues - edited 09 Mar '25

09 Mar '25

alsa-project/alsa-ucm-conf issue #515 was edited from pv: The configuration https://github.com/alsa-project/alsa-ucm-conf/blob/master/ucm2/USB-Audio/Fo… specifies `HWChannels 2` for the Mic1 and Mic2 devices. This gets translated to `CaptureChannels 2` for `alsaucm open '<<<SplitPCM=1>>>hw:2'`. However, we've got a report https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/4597#note_2815906 that looks like snd_pcm_hw_params_set_channels(pcm_handle, hwparams, 2) for the CapturePCM "_ucm0001.hw:Gen,0" fails with error. The PCM can be opened with 4 channels, though. Without `SplitPCM=1`, it also probably works but I'm not sure what channel count the `dshare` plugin is using. The issue also affects the `Direct` profile, which also specifies `CaptureChannels 2`. Is the `HWChannels 2` for Mic1/2 input direction right? Shall `CaptureChannels 2` in UCM device be interpreted as that the device can be opened with exactly 2 channels, or that it can be opened with some number of channels >= 2? <details> ``` $ alsaucm open '<<<SplitPCM=1>>>hw:2' dump text Verb.HiFi { Comment Default Device.Line1 { Comment "Headphones / Line 1-2" Values { CaptureCTL "_ucm0001.hw:Gen" PlaybackCTL "_ucm0001.hw:Gen" PlaybackPCM "_ucm0001.hw:Gen" PlaybackPriority 200 } } Device.Mic1 { Comment "Input 1 Mic/Inst/Line" Values { CaptureCTL "_ucm0001.hw:Gen" CaptureChannel0 0 CaptureChannelPos0 MONO CaptureChannels 2 CapturePCM "_ucm0001.hw:Gen,0" CapturePriority 200 PlaybackCTL "_ucm0001.hw:Gen" } } Device.Mic2 { Comment "Input 2 Mic/Inst/Line" Values { CaptureCTL "_ucm0001.hw:Gen" CaptureChannel0 1 CaptureChannelPos0 MONO CaptureChannels 2 CapturePCM "_ucm0001.hw:Gen,0" CapturePriority 100 PlaybackCTL "_ucm0001.hw:Gen" } } } Verb.Direct { Comment "Direct Scarlett Solo 4th Gen" Device.Direct { Comment "Direct Scarlett Solo 4th Gen" Values { CaptureCTL "_ucm0001.hw:Gen" CaptureChannels 2 CapturePCM "_ucm0001.hw:Gen" CapturePriority 1000 PlaybackCTL "_ucm0001.hw:Gen" PlaybackChannels 2 PlaybackPCM "_ucm0001.hw:Gen" PlaybackPriority 1000 } } } ``` </details> Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/515 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Channel count in Focusrite Scarlett Gen 4 (1235:8218) SplitPCM configuration
by GitHub issues - opened 09 Mar '25

09 Mar '25

alsa-project/alsa-ucm-conf issue #515 was opened from pv: The configuration https://github.com/alsa-project/alsa-ucm-conf/blob/master/ucm2/USB-Audio/Fo… specifies `HWChannels 2` for the Mic1 and Mic2 devices. This gets translated to `CaptureChannels 2` for `alsaucm open '<<<SplitPCM=1>>>hw:2'`. However, we've got a report https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/4597#note_2815906 that looks like snd_pcm_hw_params_set_channels(pcm_handle, hwparams, 2) for the CapturePCM "_ucm0001.hw:Gen,0" fails with error. The PCM can be opened with 4 channels, though. Without `SplitPCM=1`, it also probably works but I'm not sure what channel count the `dshare` plugin is using. Is the `HWChannels 2` for Mic1/2 input direction right? Shall `CaptureChannels 2` in UCM device be interpreted as that the device can be opened with exactly 2 channels, or that it can be opened with some number of channels >= 2? <details> ``` $ alsaucm open '<<<SplitPCM=1>>>hw:2' dump text Verb.HiFi { Comment Default Device.Line1 { Comment "Headphones / Line 1-2" Values { CaptureCTL "_ucm0001.hw:Gen" PlaybackCTL "_ucm0001.hw:Gen" PlaybackPCM "_ucm0001.hw:Gen" PlaybackPriority 200 } } Device.Mic1 { Comment "Input 1 Mic/Inst/Line" Values { CaptureCTL "_ucm0001.hw:Gen" CaptureChannel0 0 CaptureChannelPos0 MONO CaptureChannels 2 CapturePCM "_ucm0001.hw:Gen,0" CapturePriority 200 PlaybackCTL "_ucm0001.hw:Gen" } } Device.Mic2 { Comment "Input 2 Mic/Inst/Line" Values { CaptureCTL "_ucm0001.hw:Gen" CaptureChannel0 1 CaptureChannelPos0 MONO CaptureChannels 2 CapturePCM "_ucm0001.hw:Gen,0" CapturePriority 100 PlaybackCTL "_ucm0001.hw:Gen" } } } Verb.Direct { Comment "Direct Scarlett Solo 4th Gen" Device.Direct { Comment "Direct Scarlett Solo 4th Gen" Values { CaptureCTL "_ucm0001.hw:Gen" CaptureChannels 2 CapturePCM "_ucm0001.hw:Gen" CapturePriority 1000 PlaybackCTL "_ucm0001.hw:Gen" PlaybackChannels 2 PlaybackPCM "_ucm0001.hw:Gen" PlaybackPriority 1000 } } } ``` </details> Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/515 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

RE: [PATCH v5 2/2] ASoC: dt-bindings: Add Everest ES8389 audio CODEC
by Zhang Yi 09 Mar '25

09 Mar '25

> > 1 file changed, 50 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/sound/everest,es8389.yaml > > > > diff --git a/Documentation/devicetree/bindings/sound/everest,es8389.yaml b/Documentation/devicetree/bindings/sound/everest,es8389.yaml > > > You got feedback how to create CC list. Two times. > > You still create it incorrectly and Cc address which does not exist in > the kernel and is a proof you work on wrong tree, which I asked to correct. > > What's more, there is still no changelog and you never responded to > review comments. > > Can you slow down with resubmits and rethink the received feedback? I > expect that feedback to be responded to, so I am not wasting time here > repeating the same every time. I'm sorry for the trouble I've caused you. And I have responded to the comments at v3 and v4.

1 0

PORT: GTK2 to GTK3
by GitHub pull_request - opened 07 Mar '25

07 Mar '25

alsa-project/alsa-tools pull request #27 was opened from genbtc: I've undertaken a task of porting alsa-tools programs from GTK2 to GTK3. These patches start with a base of 5eaadd15bda4cf0424ee2470a6d304a0c2ce10cb (master) Date: Mon Jan 27 (latest pull) Results: Compilation completes successfully, Linked to GTK3, but I do not have the hardware cards to test run them. All work has been done by me, and I request a code review on the GDK 2 Pixmap to GDK 3 Pixbuf + Cairo surfaces. Like it needs new logic and new plan. not simply change statement A to B (whatever I did to get it to compile) I tried to comply with the existing style, and There was also a fair bit of inconsequential whitespace removed like (\n\t\n) or trailing space chars as I discovered them. Looking forward to upstreaming these changes somehow if you would like to work on this. - genBTC @ gentoo Request URL : https://github.com/alsa-project/alsa-tools/pull/27 Patch URL : https://github.com/alsa-project/alsa-tools/pull/27.patch Repository URL: https://github.com/alsa-project/alsa-tools

1 0

[PATCH v5 0/2] ASoC: codecs: add support for ES8389
by Zhang Yi 07 Mar '25

07 Mar '25

The driver is for codec ES8389 of everest-semi. Zhang Yi (2): ASoC: codecs: add support for ES8389 ASoC: dt-bindings: Add Everest ES8389 audio CODEC .../bindings/sound/everest,es8389.yaml | 50 + sound/soc/codecs/Kconfig | 6 +- sound/soc/codecs/Makefile | 2 + sound/soc/codecs/es8389.c | 966 ++++++++++++++++++ sound/soc/codecs/es8389.h | 140 +++ 5 files changed, 1163 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/sound/everest,es8389.yaml create mode 100644 sound/soc/codecs/es8389.c create mode 100644 sound/soc/codecs/es8389.h -- 2.17.1

3 4