- Alsa-devel - mailman.alsa-project.org

[GIT PULL] ASoC fixes for v6.15-rc6
by Mark Brown 16 May '25

16 May '25

The following changes since commit 92a09c47464d040866cf2b4cd052bc60555185fb: Linux 6.15-rc5 (2025-05-04 13:55:04 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-fix-v6.15-rc6 for you to fetch changes up to 7dd7f39fce0022b386ef1ea5ffef92ecc7dfc6af: ASoC: SOF: Intel: hda: Fix UAF when reloading module (2025-05-14 16:34:48 +0200) ---------------------------------------------------------------- ASoC: Fixes for v6.15 A collection of driver specific fixes that built up over the past few weeks, plus one core patch which fixes handling of topology files where some DAI names are substrings of others. ---------------------------------------------------------------- Arnd Bergmann (1): ASoC: mediatek: mt8188-mt6359: select CONFIG_SND_SOC_MT6359_ACCDET Kai Vehmanen (1): ASoc: SOF: topology: connect DAI to a single DAI link Nícolas F. R. A. Prado (1): ASoC: mediatek: mt8188-mt6359: Depend on MT6359_ACCDET set or disabled Peter Ujfalusi (3): ASoC: SOF: ipc4-control: Use SOF_CTRL_CMD_BINARY as numid for bytes_ext ASoC: SOF: ipc4-pcm: Delay reporting is only supported for playback direction ASoC: SOF: Intel: hda-bus: Use PIO mode on ACE2+ platforms Tavian Barnes (1): ASoC: SOF: Intel: hda: Fix UAF when reloading module sound/soc/mediatek/Kconfig | 1 + sound/soc/sof/intel/hda-bus.c | 2 +- sound/soc/sof/intel/hda.c | 16 +++++++++++++++- sound/soc/sof/ipc4-control.c | 11 ++++++++++- sound/soc/sof/ipc4-pcm.c | 3 ++- sound/soc/sof/topology.c | 18 ++++++++++++++---- 6 files changed, 43 insertions(+), 8 deletions(-)

2 1

restore auto-mute mode for Dell Chrome platform
by Kailang 16 May '25

16 May '25

Hi Takashi, Attach patch was approved by Google guy. BR, Kailang

2 1

[PATCH 1/1] bat: Fix buffer time configuration
by Alexander Stein 16 May '25

16 May '25

By swapping time configuration some hardware constraints can be supported. Fixes the error: Set parameter to device error: buffer time: 500000 hw:tqmtlv320aic32: Invalid argument(-22) Signed-off-by: Alexander Stein <alexander.stein(a)ew.tq-group.com> --- Our common 'alsabat -Dhw:tqmtlv320aic32 -f S16_LE -c 2 -r 44100 -F 997:500' failed ona i.MX95 based platform, while it worked flawlessly on others, e.g. i.MX8M Plus. Upon searching I stumbled across [1], which this patch is inspired/based on. [1] https://github.com/arkq/bluez-alsa/pull/290/commits/da78b82ff77310093b4b4a9… --- bat/alsa.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/bat/alsa.c b/bat/alsa.c index 67489c4..457e79a 100644 --- a/bat/alsa.c +++ b/bat/alsa.c @@ -221,23 +221,23 @@ static int set_snd_pcm_params(struct bat *bat, struct pcm_container *sndpcm) period_time = buffer_time / DIV_BUFFERTIME; - /* Set buffer time and period time */ - err = snd_pcm_hw_params_set_buffer_time_near(sndpcm->handle, - params, &buffer_time, 0); + /* Set period time and buffer time */ + err = snd_pcm_hw_params_set_period_time_near(sndpcm->handle, + params, &period_time, 0); if (err < 0) { fprintf(bat->err, _("Set parameter to device error: ")); - fprintf(bat->err, _("buffer time: %d %s: %s(%d)\n"), - buffer_time, + fprintf(bat->err, _("period time: %d %s: %s(%d)\n"), + period_time, device_name, snd_strerror(err), err); return err; } - err = snd_pcm_hw_params_set_period_time_near(sndpcm->handle, - params, &period_time, 0); + err = snd_pcm_hw_params_set_buffer_time_near(sndpcm->handle, + params, &buffer_time, 0); if (err < 0) { fprintf(bat->err, _("Set parameter to device error: ")); - fprintf(bat->err, _("period time: %d %s: %s(%d)\n"), - period_time, + fprintf(bat->err, _("buffer time: %d %s: %s(%d)\n"), + buffer_time, device_name, snd_strerror(err), err); return err; } -- 2.43.0

2 2

Device rename regression fixes
by GitHub pull_request - opened 15 May '25

15 May '25

alsa-project/alsa-ucm-conf pull request #563 was opened from jhovold: A recent change renaming device sections introduced a name collision which broke the internal microphones on the Lenovo ThinkPad X13s. A number of jack hw mute and conflicting devices properties are now also referring to non-existing devices. Please consider doing a bug fix release as soon as possible to address the X13s regression in v1.2.14. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/563 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/563.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

MIDI 2.0 Network UDP server/client programs for ALSA
by Takashi Iwai 14 May '25

14 May '25

Hi, I recently wrote a set of small programs for the new Network MIDI 2.0 UDP transport with ALSA sequencer / rawmidi API, based on v1.0 spec. The current version (v0.3) is found at: https://github.com/tiwai/amidi2net A network server can be invoked simply via: % amidi2net-server and this will create an ALSA sequencer client/port. This ALSA sequencer port can be connected by any other ALSA sequencer programs or devices. The server opens a UDP port, so that it can be connected by a client on another machine on the net, e.g.: % amidi2net-client -l amidi2net which creates an ALSA sequencer client/port similarly, and this can be connected by other apps, too. After the network connection, server and client can pass the UMP data between them freely, so they work as a bridge or hub for applications on both machines. Some details are found in README and man pages. For the builds, you'll need openssl and avahi devel packages. (It allows to build without those, but basic functions will be missing.) As it's a quite initial version, there can be bugs and subject to change. But the stuff seems working stably. Feel free to reach me if you find any issues. thanks, Takashi

1 0

[PATCH v4] ALSA: hda/tas2781: Fix the ld issue reported by kernel test robot
by Shenghao Ding 13 May '25

13 May '25

After commit 9fa6a693ad8d ("ALSA: hda/tas2781: Remove tas2781_spi_fwlib.c and leverage SND_SOC_TAS2781_FMWLIB")created a separated lib for i2c, However, tasdevice_remove() used for not only for I2C but for SPI being still in that lib caused ld issue. All errors (new ones prefixed by >>): >> ld.lld: error: undefined symbol: tasdevice_remove >>> referenced by tas2781_hda.c:33 (sound/pci/hda/tas2781_hda.c:33) >>> vmlinux.o:(tas2781_hda_remove) To fix this issue, the implementation of tasdevice_remove was moved from tas2781-comlib-i2c.c to tas2781-comlib.c. Fixes: 9fa6a693ad8d ("ALSA: hda/tas2781: Remove tas2781_spi_fwlib.c and leverage SND_SOC_TAS2781_FMWLIB") Reported-by: kernel test robot <lkp(a)intel.com> Closes: https://urldefense.com/v3/__https://lore.kernel.org/oe-kbuild-all/202505111… Signed-off-by: Shenghao Ding <shenghao-ding(a)ti.com> --- v4: - Put report tag around Signed-off-by without quotes. v3: - Drop the report tag in the patch description. v2: - put the Fixes tag to point out the commit that introduced the regression - Add compiling error information reported by kernel test robot into patch description. v1: - | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://urldefense.com/v3/__https://lore.kernel.org/oe-kbuild-all/202505111… --- sound/soc/codecs/tas2781-comlib-i2c.c | 6 ------ sound/soc/codecs/tas2781-comlib.c | 6 ++++++ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/soc/codecs/tas2781-comlib-i2c.c b/sound/soc/codecs/tas2781-comlib-i2c.c index a75b812618ee..c078bb0a8437 100644 --- a/sound/soc/codecs/tas2781-comlib-i2c.c +++ b/sound/soc/codecs/tas2781-comlib-i2c.c @@ -364,12 +364,6 @@ int tascodec_init(struct tasdevice_priv *tas_priv, void *codec, } EXPORT_SYMBOL_GPL(tascodec_init); -void tasdevice_remove(struct tasdevice_priv *tas_priv) -{ - mutex_destroy(&tas_priv->codec_lock); -} -EXPORT_SYMBOL_GPL(tasdevice_remove); - MODULE_DESCRIPTION("TAS2781 common library for I2C"); MODULE_AUTHOR("Shenghao Ding, TI, <shenghao-ding(a)ti.com>"); MODULE_LICENSE("GPL"); diff --git a/sound/soc/codecs/tas2781-comlib.c b/sound/soc/codecs/tas2781-comlib.c index ad2f65359b15..076c1d955972 100644 --- a/sound/soc/codecs/tas2781-comlib.c +++ b/sound/soc/codecs/tas2781-comlib.c @@ -225,6 +225,12 @@ void tasdevice_dsp_remove(void *context) } EXPORT_SYMBOL_GPL(tasdevice_dsp_remove); +void tasdevice_remove(struct tasdevice_priv *tas_priv) +{ + mutex_destroy(&tas_priv->codec_lock); +} +EXPORT_SYMBOL_GPL(tasdevice_remove); + MODULE_DESCRIPTION("TAS2781 common library"); MODULE_AUTHOR("Shenghao Ding, TI, <shenghao-ding(a)ti.com>"); MODULE_LICENSE("GPL"); -- 2.43.0

3 3

[PATCH] ASoC: tlv320aic3x: Use dev_err_probe
by Nishanth Menon 13 May '25

13 May '25

During probe the regulator supply drivers may not yet be available. Use dev_err_probe to provide just the pertinent log. Signed-off-by: Nishanth Menon <nm(a)ti.com> --- Testing based on next-20250512 (includes additional patch) on AM62a7-sk Before: https://gist.github.com/nmenon/be94f21e83b4260ad3f89e1ae8f0d188#file-before… After: https://gist.github.com/nmenon/be94f21e83b4260ad3f89e1ae8f0d188#file-after-… sound/soc/codecs/tlv320aic3x.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c index 56e795a00e22..f1649df19738 100644 --- a/sound/soc/codecs/tlv320aic3x.c +++ b/sound/soc/codecs/tlv320aic3x.c @@ -1818,10 +1818,8 @@ int aic3x_probe(struct device *dev, struct regmap *regmap, kernel_ulong_t driver ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(aic3x->supplies), aic3x->supplies); - if (ret) { - dev_err(dev, "Failed to request supplies: %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "Failed to request supplies\n"); aic3x_configure_ocmv(dev, aic3x); -- 2.47.0

2 1

[PATCH v1] ALSA: hda/tas2781: Fix the symbol was not declare warning reported by kernel test robot
by Shenghao Ding 13 May '25

13 May '25

After commit 28a09d9e42c5 ("ALSA: hda/tas2781: Create an independent lib to save the shared parts for both SPI and I2C driver") created a separated lib for both hda-i2c and hda-spi driver, which caused this issue. sparse warnings: (new ones prefixed by >>) >> sound/pci/hda/tas2781_hda_spi.c:496:25: sparse: sparse: symbol 'tas2781_snd_ctls' was not declared. Should it be static? >> sound/pci/hda/tas2781_hda_spi.c:505:25: sparse: sparse: symbol 'tas2781_prof_ctl' was not declared. Should it be static? >> sound/pci/hda/tas2781_hda_spi.c:512:25: sparse: sparse: symbol 'tas2781_dsp_ctls' was not declared. Should it be static? Fixes: 28a09d9e42c5 ("ALSA: hda/tas2781: Create an independent lib to save the shared parts for both SPI and I2C driver") Reported-by: kernel test robot <lkp(a)intel.com> Closes: https://urldefense.com/v3/__https://lore.kernel.org/oe-kbuild-all/202505130… Signed-off-by: Shenghao Ding <shenghao-ding(a)ti.com> --- v1: - | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://urldefense.com/v3/__https://lore.kernel.org/oe-kbuild-all/202505130… --- sound/pci/hda/tas2781_hda_spi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/pci/hda/tas2781_hda_spi.c b/sound/pci/hda/tas2781_hda_spi.c index 50b82ecabb90..e0f8603c4854 100644 --- a/sound/pci/hda/tas2781_hda_spi.c +++ b/sound/pci/hda/tas2781_hda_spi.c @@ -493,7 +493,7 @@ static int tas2781_force_fwload_put(struct snd_kcontrol *kcontrol, return change; } -struct snd_kcontrol_new tas2781_snd_ctls[] = { +static struct snd_kcontrol_new tas2781_snd_ctls[] = { ACARD_SINGLE_RANGE_EXT_TLV(NULL, TAS2781_AMP_LEVEL, 1, 0, 20, 0, tas2781_amp_getvol, tas2781_amp_putvol, amp_vol_tlv), ACARD_SINGLE_RANGE_EXT_TLV(NULL, TAS2781_DVC_LVL, 0, 0, 200, 1, @@ -502,14 +502,14 @@ struct snd_kcontrol_new tas2781_snd_ctls[] = { tas2781_force_fwload_put), }; -struct snd_kcontrol_new tas2781_prof_ctl = { +static struct snd_kcontrol_new tas2781_prof_ctl = { .iface = SNDRV_CTL_ELEM_IFACE_CARD, .info = tasdevice_info_profile, .get = tasdevice_get_profile_id, .put = tasdevice_set_profile_id, }; -struct snd_kcontrol_new tas2781_dsp_ctls[] = { +static struct snd_kcontrol_new tas2781_dsp_ctls[] = { /* Speaker Program */ { .iface = SNDRV_CTL_ELEM_IFACE_CARD, -- 2.43.0

2 1

[PATCH v3] ALSA: hda/tas2781: Fix the ld issue reported by kernel test robot
by Shenghao Ding 13 May '25

13 May '25

After commit 9fa6a693ad8d ("ALSA: hda/tas2781: Remove tas2781_spi_fwlib.c and leverage SND_SOC_TAS2781_FMWLIB")created a separated lib for i2c, However, tasdevice_remove() used for not only for I2C but for SPI being still in that lib caused ld issue. All errors (new ones prefixed by >>): >> ld.lld: error: undefined symbol: tasdevice_remove >>> referenced by tas2781_hda.c:33 (sound/pci/hda/tas2781_hda.c:33) >>> vmlinux.o:(tas2781_hda_remove) To fix this issue, the implementation of tasdevice_remove was moved from tas2781-comlib-i2c.c to tas2781-comlib.c. Fixes: 9fa6a693ad8d ("ALSA: hda/tas2781: Remove tas2781_spi_fwlib.c and leverage SND_SOC_TAS2781_FMWLIB") Signed-off-by: Shenghao Ding <shenghao-ding(a)ti.com> --- v3: - Drop the report tag in the patch description. v2: - put the Fixes tag to point out the commit that introduced the regression - Add compiling error information reported by kernel test robot into patch description. v1: - | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://urldefense.com/v3/__https://lore.kernel.org/oe-kbuild-all/202505111… --- sound/soc/codecs/tas2781-comlib-i2c.c | 6 ------ sound/soc/codecs/tas2781-comlib.c | 6 ++++++ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/soc/codecs/tas2781-comlib-i2c.c b/sound/soc/codecs/tas2781-comlib-i2c.c index a75b812618ee..c078bb0a8437 100644 --- a/sound/soc/codecs/tas2781-comlib-i2c.c +++ b/sound/soc/codecs/tas2781-comlib-i2c.c @@ -364,12 +364,6 @@ int tascodec_init(struct tasdevice_priv *tas_priv, void *codec, } EXPORT_SYMBOL_GPL(tascodec_init); -void tasdevice_remove(struct tasdevice_priv *tas_priv) -{ - mutex_destroy(&tas_priv->codec_lock); -} -EXPORT_SYMBOL_GPL(tasdevice_remove); - MODULE_DESCRIPTION("TAS2781 common library for I2C"); MODULE_AUTHOR("Shenghao Ding, TI, <shenghao-ding(a)ti.com>"); MODULE_LICENSE("GPL"); diff --git a/sound/soc/codecs/tas2781-comlib.c b/sound/soc/codecs/tas2781-comlib.c index ad2f65359b15..076c1d955972 100644 --- a/sound/soc/codecs/tas2781-comlib.c +++ b/sound/soc/codecs/tas2781-comlib.c @@ -225,6 +225,12 @@ void tasdevice_dsp_remove(void *context) } EXPORT_SYMBOL_GPL(tasdevice_dsp_remove); +void tasdevice_remove(struct tasdevice_priv *tas_priv) +{ + mutex_destroy(&tas_priv->codec_lock); +} +EXPORT_SYMBOL_GPL(tasdevice_remove); + MODULE_DESCRIPTION("TAS2781 common library"); MODULE_AUTHOR("Shenghao Ding, TI, <shenghao-ding(a)ti.com>"); MODULE_LICENSE("GPL"); -- 2.43.0

2 1

Fwd: [Bug 220109] New: Audio disappears on HP 15-fc000 after warm boot again (ALC256 code path)
by Ruslan Nikolaev 13 May '25

13 May '25

Hi, Forwarding my regression bug report for HP 15-fc000 / ALC236 (ALC256 code path). #regzbot introduced: v6.12.2 https://bugzilla.kernel.org/show_bug.cgi?id=220109 Sincerely, Ruslan Forwarded Message (see logs in the bug report above): There was a similar bug in the past (Bug 217440), which was fixed for this laptop. (I believe the code path is for ALC256, see below.) The same issue is occurring again as of kernel v.6.12.2. The symptoms are very similar - initially audio works but after a warm reboot, the audio completely disappears until the computer is powered off (there is no audio output at all). The issue is caused by a different change now. By bisecting different kernel versions, I found that reverting cc3d0b5dd989d3238d456f9fd385946379a9c13d in patch_realtek.c ( see https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/sou… ) restores the sound and it works fine after the reboot.

2 2