- Alsa-devel - mailman.alsa-project.org

[PATCH 0/6] ASoC: codecs: Simplify mclk initialization
by Cezary Rojewski 26 Feb '24

26 Feb '24

The patchset may not cover all codecs found in the codecs/ directory - noticed a possible improvement and grepped for similar pattern across C files found in the directory. Those addressed here seem pretty straightforward. Most of clk_xxx() functions do check if provided clk-pointer is non-NULL. These do not check if the pointer is an error-pointer. Providing such to a clk_xxx() results in a panic. By utilizing _optional() variant of devm_clk_get() the driver code is both simplified and more robust. There is no need to remember about IS_ERR(clk) checks each time mclk is accessed. Cezary Rojewski (6): ASoC: codecs: da7213: Simplify mclk initialization ASoC: codecs: nau8825: Simplify mclk initialization ASoC: codecs: rt5514: Simplify mclk initialization ASoC: codecs: rt5616: Simplify mclk initialization ASoC: codecs: rt5640: Simplify mclk initialization ASoC: codecs: rt5660: Simplify mclk initialization sound/soc/codecs/da7213.c | 12 ++++-------- sound/soc/codecs/nau8825.c | 12 ++++-------- sound/soc/codecs/rt5514.c | 9 +++------ sound/soc/codecs/rt5616.c | 9 +++------ sound/soc/codecs/rt5640.c | 9 +++------ sound/soc/codecs/rt5660.c | 9 +++------ 6 files changed, 20 insertions(+), 40 deletions(-) -- 2.25.1

2 7

[PATCH v4 0/2] ASoC: codecs: tx-macro: correct TX SMIC MUXn widgets on SM8350+
by Krzysztof Kozlowski 26 Feb '24

26 Feb '24

Hi, Changelog in individual patches. v2: https://lore.kernel.org/alsa-devel/20240125153110.410295-1-krzysztof.kozlow… v1: https://lore.kernel.org/all/20230717140138.201745-1-krzysztof.kozlowski@lin… Best regards, Krzysztof Krzysztof Kozlowski (2): ASoC: codecs: tx-macro: split widgets per different LPASS versions ASoC: codecs: tx-macro: correct TX SMIC MUXn widgets on SM8350+ sound/soc/codecs/lpass-macro-common.h | 7 + sound/soc/codecs/lpass-tx-macro.c | 679 +++++++++++++++++++------- 2 files changed, 514 insertions(+), 172 deletions(-) -- 2.34.1

2 4

[PATCH v3 0/2] ASoC: codecs: tx-macro: correct TX SMIC MUXn widgets on SM8350+
by Krzysztof Kozlowski 26 Feb '24

26 Feb '24

Hi, Changelog in individual patches. v2: https://lore.kernel.org/alsa-devel/20240125153110.410295-1-krzysztof.kozlow… v1: https://lore.kernel.org/all/20230717140138.201745-1-krzysztof.kozlowski@lin… Best regards, Krzysztof Krzysztof Kozlowski (2): ASoC: codecs: tx-macro: split widgets per different LPASS versions ASoC: codecs: tx-macro: correct TX SMIC MUXn widgets on SM8350+ sound/soc/codecs/lpass-macro-common.h | 7 + sound/soc/codecs/lpass-tx-macro.c | 671 +++++++++++++++++++------- 2 files changed, 506 insertions(+), 172 deletions(-) -- 2.34.1

2 4

[PATCH v2 0/4] ALSA/ASoC: Conditionally skip i915 init and cleanups
by Cezary Rojewski 26 Feb '24

26 Feb '24

A small set of changes to improve initialization of the audio stack on HDAudio devices and pair of cleanups. As the first change is the most important one here, following is the technical background for it: Commit 78f613ba1efb ("drm/i915: finish removal of CNL") and its friends removed support for i915 for all CNL-based platforms. HDAudio library, however, still treats such platforms as valid candidates for i915 binding. Update query mechanism to reflect changes made in drm tree. At the same time, i915 support for LKF-based platforms has not been provided so remove them from valid binding candidates. The snd_soc_hda change is a follow up for the above and the cleanup patches do not bring any functional changes. Changes in v2: - list of problematic VGA devices is now declared locally, no more touching drm stuff Cezary Rojewski (4): ALSA: hda: Skip i915 initialization on CNL/LKF-based platforms ASoC: codecs: hda: Skip HDMI/DP registration if i915 is missing ASoC: codecs: hda: Cleanup error messages ALSA: hda: Reuse for_each_pcm_streams() sound/hda/hdac_i915.c | 32 +++++++++++++++++++++++++++++--- sound/pci/hda/hda_codec.c | 2 +- sound/soc/codecs/hda.c | 15 ++++++++++----- 3 files changed, 40 insertions(+), 9 deletions(-) -- 2.25.1

4 12

[tiwai-sound:test/guard 50/70] sound/core/rawmidi.c:1012:6: error: cannot jump from this asm goto statement to one of its possible targets
by kernel test robot 25 Feb '24

25 Feb '24

Hi Takashi, FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant. tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git test/guard head: 0ba3f403c3b7fdd2683aac6285903f92ba81c32d commit: 369c285f8405ec663691db39ec59a01c70f80ded [50/70] ALSA: rawmidi: Use guard() for locking config: powerpc-randconfig-r081-20240225 (https://download.01.org/0day-ci/archive/20240225/202402251935.CGUH0Id9-lkp@…) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240225/202402251935.CGUH0Id9-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202402251935.CGUH0Id9-lkp@intel.com/ All errors (new ones prefixed by >>): >> sound/core/rawmidi.c:1012:6: error: cannot jump from this asm goto statement to one of its possible targets if (put_user(device, argp)) ^ arch/powerpc/include/asm/uaccess.h:66:5: note: expanded from macro 'put_user' __put_user(x, _pu_addr) : -EFAULT; \ ^ arch/powerpc/include/asm/uaccess.h:48:3: note: expanded from macro '__put_user' __put_user_size_goto(__pu_val, __pu_addr, __pu_size, __pu_failed); \ ^ arch/powerpc/include/asm/uaccess.h:116:10: note: expanded from macro '__put_user_size_goto' case 1: __put_user_asm_goto(x, __pus_addr, label, "stb"); break; \ ^ arch/powerpc/include/asm/uaccess.h:86:2: note: expanded from macro '__put_user_asm_goto' asm_volatile_goto( \ ^ include/linux/compiler_types.h:366:33: note: expanded from macro 'asm_volatile_goto' #define asm_volatile_goto(x...) asm goto(x) ^ sound/core/rawmidi.c:996:6: note: possible target of asm goto statement if (get_user(device, argp)) ^ arch/powerpc/include/asm/uaccess.h:295:5: note: expanded from macro 'get_user' __get_user(x, _gu_addr) : \ ^ arch/powerpc/include/asm/uaccess.h:283:2: note: expanded from macro '__get_user' __get_user_size_allowed(__gu_val, __gu_addr, __gu_size, __gu_err); \ ^ arch/powerpc/include/asm/uaccess.h:201:16: note: expanded from macro '__get_user_size_allowed' break; \ ^ sound/core/rawmidi.c:1000:2: note: jump exits scope of variable with __attribute__((cleanup)) guard(mutex)(&register_mutex); ^ include/linux/cleanup.h:164:15: note: expanded from macro 'guard' CLASS(_name, __UNIQUE_ID(guard)) ^ include/linux/compiler.h:180:29: note: expanded from macro '__UNIQUE_ID' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ include/linux/compiler_types.h:84:22: note: expanded from macro '__PASTE' #define __PASTE(a,b) ___PASTE(a,b) ^ include/linux/compiler_types.h:83:23: note: expanded from macro '___PASTE' #define ___PASTE(a,b) a##b ^ <scratch space>:5:1: note: expanded from here __UNIQUE_ID_guard309 ^ sound/core/rawmidi.c:996:6: error: cannot jump from this asm goto statement to one of its possible targets if (get_user(device, argp)) ^ arch/powerpc/include/asm/uaccess.h:295:5: note: expanded from macro 'get_user' __get_user(x, _gu_addr) : \ ^ arch/powerpc/include/asm/uaccess.h:283:2: note: expanded from macro '__get_user' __get_user_size_allowed(__gu_val, __gu_addr, __gu_size, __gu_err); \ ^ arch/powerpc/include/asm/uaccess.h:199:3: note: expanded from macro '__get_user_size_allowed' __get_user_size_goto(x, ptr, size, __gus_failed); \ ^ arch/powerpc/include/asm/uaccess.h:187:10: note: expanded from macro '__get_user_size_goto' case 1: __get_user_asm_goto(x, (u8 __user *)ptr, label, "lbz"); break; \ ^ arch/powerpc/include/asm/uaccess.h:158:2: note: expanded from macro '__get_user_asm_goto' asm_volatile_goto( \ ^ include/linux/compiler_types.h:366:33: note: expanded from macro 'asm_volatile_goto' #define asm_volatile_goto(x...) asm goto(x) ^ sound/core/rawmidi.c:1012:6: note: possible target of asm goto statement if (put_user(device, argp)) ^ arch/powerpc/include/asm/uaccess.h:66:5: note: expanded from macro 'put_user' __put_user(x, _pu_addr) : -EFAULT; \ ^ arch/powerpc/include/asm/uaccess.h:52:9: note: expanded from macro '__put_user' \ ^ sound/core/rawmidi.c:1000:2: note: jump bypasses initialization of variable with __attribute__((cleanup)) guard(mutex)(&register_mutex); ^ include/linux/cleanup.h:164:15: note: expanded from macro 'guard' CLASS(_name, __UNIQUE_ID(guard)) ^ include/linux/compiler.h:180:29: note: expanded from macro '__UNIQUE_ID' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ include/linux/compiler_types.h:84:22: note: expanded from macro '__PASTE' #define __PASTE(a,b) ___PASTE(a,b) ^ include/linux/compiler_types.h:83:23: note: expanded from macro '___PASTE' #define ___PASTE(a,b) a##b ^ <scratch space>:5:1: note: expanded from here __UNIQUE_ID_guard309 ^ 2 errors generated. Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97 Depends on [n]: SOUND [=m] && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC52xx [=y] && PPC_BESTCOMM [=n] Selected by [m]: - SND_MPC52xx_SOC_EFIKA [=m] && SOUND [=m] && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_EFIKA [=y] WARNING: unmet direct dependencies detected for ADB_CUDA Depends on [n]: MACINTOSH_DRIVERS [=n] && (ADB [=n] || PPC_PMAC [=y]) && !PPC_PMAC64 [=n] Selected by [y]: - PPC_PMAC [=y] && PPC_BOOK3S [=y] && CPU_BIG_ENDIAN [=y] && POWER_RESET [=y] && PPC32 [=y] vim +1012 sound/core/rawmidi.c ^1da177e4c3f41 Linus Torvalds 2005-04-16 986 127ae6f6dad2ed Takashi Iwai 2023-05-23 987 /* ioctl to find the next device; either legacy or UMP depending on @find_ump */ 127ae6f6dad2ed Takashi Iwai 2023-05-23 988 static int snd_rawmidi_next_device(struct snd_card *card, int __user *argp, 127ae6f6dad2ed Takashi Iwai 2023-05-23 989 bool find_ump) ^1da177e4c3f41 Linus Torvalds 2005-04-16 990 ^1da177e4c3f41 Linus Torvalds 2005-04-16 991 { 127ae6f6dad2ed Takashi Iwai 2023-05-23 992 struct snd_rawmidi *rmidi; ^1da177e4c3f41 Linus Torvalds 2005-04-16 993 int device; 127ae6f6dad2ed Takashi Iwai 2023-05-23 994 bool is_ump; ^1da177e4c3f41 Linus Torvalds 2005-04-16 995 127ae6f6dad2ed Takashi Iwai 2023-05-23 996 if (get_user(device, argp)) ^1da177e4c3f41 Linus Torvalds 2005-04-16 997 return -EFAULT; a7a13d0676335a Dan Carpenter 2010-09-09 998 if (device >= SNDRV_RAWMIDI_DEVICES) /* next device is -1 */ a7a13d0676335a Dan Carpenter 2010-09-09 999 device = SNDRV_RAWMIDI_DEVICES - 1; 369c285f8405ec Takashi Iwai 2024-02-21 1000 guard(mutex)(&register_mutex); ^1da177e4c3f41 Linus Torvalds 2005-04-16 1001 device = device < 0 ? 0 : device + 1; 127ae6f6dad2ed Takashi Iwai 2023-05-23 1002 for (; device < SNDRV_RAWMIDI_DEVICES; device++) { 127ae6f6dad2ed Takashi Iwai 2023-05-23 1003 rmidi = snd_rawmidi_search(card, device); 127ae6f6dad2ed Takashi Iwai 2023-05-23 1004 if (!rmidi) 127ae6f6dad2ed Takashi Iwai 2023-05-23 1005 continue; 127ae6f6dad2ed Takashi Iwai 2023-05-23 1006 is_ump = rawmidi_is_ump(rmidi); 127ae6f6dad2ed Takashi Iwai 2023-05-23 1007 if (find_ump == is_ump) ^1da177e4c3f41 Linus Torvalds 2005-04-16 1008 break; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1009 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 1010 if (device == SNDRV_RAWMIDI_DEVICES) ^1da177e4c3f41 Linus Torvalds 2005-04-16 1011 device = -1; 127ae6f6dad2ed Takashi Iwai 2023-05-23 @1012 if (put_user(device, argp)) ^1da177e4c3f41 Linus Torvalds 2005-04-16 1013 return -EFAULT; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1014 return 0; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1015 } 127ae6f6dad2ed Takashi Iwai 2023-05-23 1016 :::::: The code at line 1012 was first introduced by commit :::::: 127ae6f6dad2edb2201e27b7e6fa72994b537fad ALSA: rawmidi: Skip UMP devices at SNDRV_CTL_IOCTL_RAWMIDI_NEXT_DEVICE :::::: TO: Takashi Iwai <tiwai(a)suse.de> :::::: CC: Takashi Iwai <tiwai(a)suse.de> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

Attempt to Fix ALC285 on Linux for HP Envy x360 Laptops
by Athaariq Ardhiansyah 25 Feb '24

25 Feb '24

Dear Mr. Yang and ALSA contributors, Currently, I'm trying to fix ALC285 for HP Envy x360 13-ar0107au convertible laptop on Linux v6.7.6 kernel. It has several problems including B&O soundbar speakers won't work and volume too low even though it's 100%. For now, the B&O soundbar is working. However, I'm still struggling to fix the low volume problem. The draft patch is attached to this mail. If you don't mind, please let me know the information about the correct coefficients, so I can help you fix the problem and test it on my device. Thank you for your attention. Sincerely, Eric

1 0

[tiwai-sound:test/guard 46/70] sound/core/hwdep.c:291:8: error: cannot jump from this asm goto statement to one of its possible targets
by kernel test robot 25 Feb '24

25 Feb '24

Hi Takashi, FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant. tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git test/guard head: 08e50f26c5431175dc7207664c292f3ecc134121 commit: 9c86a0c433a5a99e2d5cc4713609efed801632a1 [46/70] ALSA: hwdep: Use guard() for locking config: powerpc-randconfig-r081-20240225 (https://download.01.org/0day-ci/archive/20240225/202402251039.08XAcTR2-lkp@…) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240225/202402251039.08XAcTR2-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202402251039.08XAcTR2-lkp@intel.com/ All errors (new ones prefixed by >>): >> sound/core/hwdep.c:291:8: error: cannot jump from this asm goto statement to one of its possible targets if (put_user(device, (int __user *)arg)) ^ arch/powerpc/include/asm/uaccess.h:66:5: note: expanded from macro 'put_user' __put_user(x, _pu_addr) : -EFAULT; \ ^ arch/powerpc/include/asm/uaccess.h:48:3: note: expanded from macro '__put_user' __put_user_size_goto(__pu_val, __pu_addr, __pu_size, __pu_failed); \ ^ arch/powerpc/include/asm/uaccess.h:116:10: note: expanded from macro '__put_user_size_goto' case 1: __put_user_asm_goto(x, __pus_addr, label, "stb"); break; \ ^ arch/powerpc/include/asm/uaccess.h:86:2: note: expanded from macro '__put_user_asm_goto' asm_volatile_goto( \ ^ include/linux/compiler_types.h:366:33: note: expanded from macro 'asm_volatile_goto' #define asm_volatile_goto(x...) asm goto(x) ^ sound/core/hwdep.c:273:8: note: possible target of asm goto statement if (get_user(device, (int __user *)arg)) ^ arch/powerpc/include/asm/uaccess.h:295:5: note: expanded from macro 'get_user' __get_user(x, _gu_addr) : \ ^ arch/powerpc/include/asm/uaccess.h:283:2: note: expanded from macro '__get_user' __get_user_size_allowed(__gu_val, __gu_addr, __gu_size, __gu_err); \ ^ arch/powerpc/include/asm/uaccess.h:201:16: note: expanded from macro '__get_user_size_allowed' break; \ ^ sound/core/hwdep.c:276:4: note: jump exits scope of variable with __attribute__((cleanup)) guard(mutex)(&register_mutex); ^ include/linux/cleanup.h:164:15: note: expanded from macro 'guard' CLASS(_name, __UNIQUE_ID(guard)) ^ include/linux/compiler.h:180:29: note: expanded from macro '__UNIQUE_ID' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ include/linux/compiler_types.h:84:22: note: expanded from macro '__PASTE' #define __PASTE(a,b) ___PASTE(a,b) ^ include/linux/compiler_types.h:83:23: note: expanded from macro '___PASTE' #define ___PASTE(a,b) a##b ^ <scratch space>:163:1: note: expanded from here __UNIQUE_ID_guard260 ^ sound/core/hwdep.c:273:8: error: cannot jump from this asm goto statement to one of its possible targets if (get_user(device, (int __user *)arg)) ^ arch/powerpc/include/asm/uaccess.h:295:5: note: expanded from macro 'get_user' __get_user(x, _gu_addr) : \ ^ arch/powerpc/include/asm/uaccess.h:283:2: note: expanded from macro '__get_user' __get_user_size_allowed(__gu_val, __gu_addr, __gu_size, __gu_err); \ ^ arch/powerpc/include/asm/uaccess.h:199:3: note: expanded from macro '__get_user_size_allowed' __get_user_size_goto(x, ptr, size, __gus_failed); \ ^ arch/powerpc/include/asm/uaccess.h:187:10: note: expanded from macro '__get_user_size_goto' case 1: __get_user_asm_goto(x, (u8 __user *)ptr, label, "lbz"); break; \ ^ arch/powerpc/include/asm/uaccess.h:158:2: note: expanded from macro '__get_user_asm_goto' asm_volatile_goto( \ ^ include/linux/compiler_types.h:366:33: note: expanded from macro 'asm_volatile_goto' #define asm_volatile_goto(x...) asm goto(x) ^ sound/core/hwdep.c:291:8: note: possible target of asm goto statement if (put_user(device, (int __user *)arg)) ^ arch/powerpc/include/asm/uaccess.h:66:5: note: expanded from macro 'put_user' __put_user(x, _pu_addr) : -EFAULT; \ ^ arch/powerpc/include/asm/uaccess.h:52:9: note: expanded from macro '__put_user' \ ^ sound/core/hwdep.c:276:4: note: jump bypasses initialization of variable with __attribute__((cleanup)) guard(mutex)(&register_mutex); ^ include/linux/cleanup.h:164:15: note: expanded from macro 'guard' CLASS(_name, __UNIQUE_ID(guard)) ^ include/linux/compiler.h:180:29: note: expanded from macro '__UNIQUE_ID' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ include/linux/compiler_types.h:84:22: note: expanded from macro '__PASTE' #define __PASTE(a,b) ___PASTE(a,b) ^ include/linux/compiler_types.h:83:23: note: expanded from macro '___PASTE' #define ___PASTE(a,b) a##b ^ <scratch space>:163:1: note: expanded from here __UNIQUE_ID_guard260 ^ 2 errors generated. Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97 Depends on [n]: SOUND [=m] && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC52xx [=y] && PPC_BESTCOMM [=n] Selected by [m]: - SND_MPC52xx_SOC_EFIKA [=m] && SOUND [=m] && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_EFIKA [=y] WARNING: unmet direct dependencies detected for ADB_CUDA Depends on [n]: MACINTOSH_DRIVERS [=n] && (ADB [=n] || PPC_PMAC [=y]) && !PPC_PMAC64 [=n] Selected by [y]: - PPC_PMAC [=y] && PPC_BOOK3S [=y] && CPU_BIG_ENDIAN [=y] && POWER_RESET [=y] && PPC32 [=y] vim +291 sound/core/hwdep.c ^1da177e4c3f41 Linus Torvalds 2005-04-16 263 d9a98de218ce18 Takashi Iwai 2005-11-17 264 static int snd_hwdep_control_ioctl(struct snd_card *card, d9a98de218ce18 Takashi Iwai 2005-11-17 265 struct snd_ctl_file * control, ^1da177e4c3f41 Linus Torvalds 2005-04-16 266 unsigned int cmd, unsigned long arg) ^1da177e4c3f41 Linus Torvalds 2005-04-16 267 { ^1da177e4c3f41 Linus Torvalds 2005-04-16 268 switch (cmd) { ^1da177e4c3f41 Linus Torvalds 2005-04-16 269 case SNDRV_CTL_IOCTL_HWDEP_NEXT_DEVICE: ^1da177e4c3f41 Linus Torvalds 2005-04-16 270 { ^1da177e4c3f41 Linus Torvalds 2005-04-16 271 int device; ^1da177e4c3f41 Linus Torvalds 2005-04-16 272 ^1da177e4c3f41 Linus Torvalds 2005-04-16 273 if (get_user(device, (int __user *)arg)) ^1da177e4c3f41 Linus Torvalds 2005-04-16 274 return -EFAULT; f7b2bb8549e352 Dan Carpenter 2011-10-28 275 9c86a0c433a5a9 Takashi Iwai 2024-02-21 276 guard(mutex)(&register_mutex); f7b2bb8549e352 Dan Carpenter 2011-10-28 277 if (device < 0) f7b2bb8549e352 Dan Carpenter 2011-10-28 278 device = 0; f7b2bb8549e352 Dan Carpenter 2011-10-28 279 else if (device < SNDRV_MINOR_HWDEPS) f7b2bb8549e352 Dan Carpenter 2011-10-28 280 device++; f7b2bb8549e352 Dan Carpenter 2011-10-28 281 else f7b2bb8549e352 Dan Carpenter 2011-10-28 282 device = SNDRV_MINOR_HWDEPS; f7b2bb8549e352 Dan Carpenter 2011-10-28 283 ^1da177e4c3f41 Linus Torvalds 2005-04-16 284 while (device < SNDRV_MINOR_HWDEPS) { f87135f56cb266 Clemens Ladisch 2005-11-20 285 if (snd_hwdep_search(card, device)) ^1da177e4c3f41 Linus Torvalds 2005-04-16 286 break; ^1da177e4c3f41 Linus Torvalds 2005-04-16 287 device++; ^1da177e4c3f41 Linus Torvalds 2005-04-16 288 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 289 if (device >= SNDRV_MINOR_HWDEPS) ^1da177e4c3f41 Linus Torvalds 2005-04-16 290 device = -1; ^1da177e4c3f41 Linus Torvalds 2005-04-16 @291 if (put_user(device, (int __user *)arg)) ^1da177e4c3f41 Linus Torvalds 2005-04-16 292 return -EFAULT; ^1da177e4c3f41 Linus Torvalds 2005-04-16 293 return 0; ^1da177e4c3f41 Linus Torvalds 2005-04-16 294 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 295 case SNDRV_CTL_IOCTL_HWDEP_INFO: ^1da177e4c3f41 Linus Torvalds 2005-04-16 296 { d9a98de218ce18 Takashi Iwai 2005-11-17 297 struct snd_hwdep_info __user *info = (struct snd_hwdep_info __user *)arg; 9c86a0c433a5a9 Takashi Iwai 2024-02-21 298 int device; d9a98de218ce18 Takashi Iwai 2005-11-17 299 struct snd_hwdep *hwdep; ^1da177e4c3f41 Linus Torvalds 2005-04-16 300 ^1da177e4c3f41 Linus Torvalds 2005-04-16 301 if (get_user(device, &info->device)) ^1da177e4c3f41 Linus Torvalds 2005-04-16 302 return -EFAULT; 9c86a0c433a5a9 Takashi Iwai 2024-02-21 303 guard(mutex)(&register_mutex); f87135f56cb266 Clemens Ladisch 2005-11-20 304 hwdep = snd_hwdep_search(card, device); 9c86a0c433a5a9 Takashi Iwai 2024-02-21 305 if (!hwdep) 9c86a0c433a5a9 Takashi Iwai 2024-02-21 306 return -ENXIO; 9c86a0c433a5a9 Takashi Iwai 2024-02-21 307 return snd_hwdep_info(hwdep, info); ^1da177e4c3f41 Linus Torvalds 2005-04-16 308 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 309 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 310 return -ENOIOCTLCMD; ^1da177e4c3f41 Linus Torvalds 2005-04-16 311 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 312 :::::: The code at line 291 was first introduced by commit :::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2 :::::: TO: Linus Torvalds <torvalds(a)ppc970.osdl.org> :::::: CC: Linus Torvalds <torvalds(a)ppc970.osdl.org> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

pulseaudio: rewind does not seem to work properly
by GitHub issues - opened 24 Feb '24

24 Feb '24

alsa-project/alsa-plugins issue #56 was opened from z-s-e: In my application, after I use `snd_pcm_rewind()` strange things happen, such as `snd_pcm_status_get_avail()` reporting a value larger than `period_count * frames_per_period` which my app depends on to never happen. Issue URL : https://github.com/alsa-project/alsa-plugins/issues/56 Repository URL: https://github.com/alsa-project/alsa-plugins

1 0

Re: PCI SSID and Codec SSID collision?
by Willian Wang 24 Feb '24

24 Feb '24

Hi, I'm curious about the reasons for the fixup table to be the same for PCI and Codec SSIDs and if the PCI SSID is usually more important for it to be checked before the Codec. Anyway, would a simple conditional statement to match these exact PCI and Codec SSID to set the fixup manually be enough? There seems to already exist a manual fix for TX300 and ROG Strix G17 there (not the same kind of fix and with a FIXME comment, though). I have this exact laptop model and would like to try to contribute to the code if it's not too complicated.

3 4

[PATCH v14 00/53] Introduce QC USB SND audio offloading support
by Wesley Cheng 24 Feb '24

24 Feb '24

Several Qualcomm based chipsets can support USB audio offloading to a dedicated audio DSP, which can take over issuing transfers to the USB host controller. The intention is to reduce the load on the main processors in the SoC, and allow them to be placed into lower power modes. There are several parts to this design: 1. Adding ASoC binding layer 2. Create a USB backend for Q6DSP 3. Introduce XHCI interrupter support 4. Create vendor ops for the USB SND driver USB | ASoC -------------------------------------------------------------------- | _________________________ | |sm8250 platform card | | |_________________________| | | | | ___V____ ____V____ | |Q6USB | |Q6AFE | | |"codec" | |"cpu" | | |________| |_________| | ^ ^ ^ | | |________| | ___V____ | | |SOC-USB | | ________ ________ | | | |USB SND |<--->|QC offld|<------------>|________| | |(card.c)| | |<---------- | |________| |________|___ | | | ^ ^ | | | ____________V_________ | | | | | |APR/GLINK | __ V_______________V_____ | | | |______________________| |USB SND (endpoint.c) | | | | ^ |_________________________| | | | | ^ | | | ___________V___________ | | | |->|audio DSP | ___________V_____________ | | |_______________________| |XHCI HCD |<- | |_________________________| | Adding ASoC binding layer: soc-usb: Intention is to treat a USB port similar to a headphone jack. The port is always present on the device, but cable/pin status can be enabled/disabled. Expose mechanisms for USB backend ASoC drivers to communicate with USB SND. Create a USB backend for Q6DSP: q6usb: Basic backend driver that will be responsible for maintaining the resources needed to initiate a playback stream using the Q6DSP. Will be the entity that checks to make sure the connected USB audio device supports the requested PCM format. If it does not, the PCM open call will fail, and userpsace ALSA can take action accordingly. Introduce XHCI interrupter support: XHCI HCD supports multiple interrupters, which allows for events to be routed to different event rings. This is determined by "Interrupter Target" field specified in Section "6.4.1.1 Normal TRB" of the XHCI specification. Events in the offloading case will be routed to an event ring that is assigned to the audio DSP. Create vendor ops for the USB SND driver: qc_audio_offload: This particular driver has several components associated with it: - QMI stream request handler - XHCI interrupter and resource management - audio DSP memory management When the audio DSP wants to enable a playback stream, the request is first received by the ASoC platform sound card. Depending on the selected route, ASoC will bring up the individual DAIs in the path. The Q6USB backend DAI will send an AFE port start command (with enabling the USB playback path), and the audio DSP will handle the request accordingly. Part of the AFE USB port start handling will have an exchange of control messages using the QMI protocol. The qc_audio_offload driver will populate the buffer information: - Event ring base address - EP transfer ring base address and pass it along to the audio DSP. All endpoint management will now be handed over to the DSP, and the main processor is not involved in transfers. Overall, implementing this feature will still expose separate sound card and PCM devices for both the platorm card and USB audio device: 0 [SM8250MTPWCD938]: sm8250 - SM8250-MTP-WCD9380-WSA8810-VA-D SM8250-MTP-WCD9380-WSA8810-VA-DMIC 1 [Audio ]: USB-Audio - USB Audio Generic USB Audio at usb-xhci-hcd.1.auto-1.4, high speed This is to ensure that userspace ALSA entities can decide which route to take when executing the audio playback. In the above, if card#1 is selected, then USB audio data will take the legacy path over the USB PCM drivers, etc... This feature was validated using: - tinymix: set/enable the multimedia path to route to USB backend - tinyplay: issue playback on platform card Changelog -------------------------------------------- Changes in v14: - Cleaned up some USB SND related feedback: - Renamed SNDUSB OFFLD playback available --> USB offload capable card - Fixed locking while checking if stream is in use - Replaced some mutex pairs with guard(mutex) Changes in v13: - Pulled in secondary/primary interrupter rework from Mathias from: https://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git/log/drivers… - Did some cleanup and commit message updates, and tested on current code base. - Added mutex locking to xhci sideband to help prevent any race conditions, esp. for when accessing shared references. - Addresed concerns from Hillf about gfp_flags and locking used in qc_usb_audio_offload. - Rebased onto usb-next Changes in v12: - Updated copyright year to 2024. Happy new years! - Fixed newline format on mixer offload driver. Changes in v11: - Modified QMI format structures to be const Changes in v10: - Added new mixer for exposing kcontrol for sound card created by USB SND. This allows for applications to know which platform sound card has offload support. Will return the card number. - Broke down and cleaned up some functions/APIs within qc_audio_offload driver. - Exported xhci_initialize_ring_info(), and modified XHCI makefile to allow for the XHCI sideband to exist as a module. - Reworked the jack registration and moved it to the QCOM platform card driver, ie sm8250. - Added an SOC USB API to fetch a standard component tag that can be appended to the platform sound card. Added this tag to sm8250 if any USB path exists within the DT node. - Moved kcontrols that existed in the Q6USB driver, and made it a bit more generic, so that naming can be standardized across solutions. SOC USB is now responsible for creation of these kcontrols. - Added a SOC USB RST document explaining some code flows and implementation details so that other vendors can utilize the framework. - Addressed a case where USB device connection events are lost if usb offload driver (qc_audio_offload) is not probed when everything else has been initialized, ie USB SND, SOC USB and ASoC sound card. Add a rediscover device call during module init, to ensure that connection events will be propagated. - Rebased to usb-next. Changes in v9: - Fixed the dt binding check issue with regards to num-hc-interrupters. Changes in v8: - Cleaned up snd_soc_usb_find_priv_data() based on Mark's feedback. Removed some of the duplicate looping code that was present on previous patches. Also renamed the API. - Integrated Mathias' suggestions on his new sideband changes: https://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git/log/?h=feat… - Addressed some of Mathias' fixme tags, such as: - Resetting transfer ring dequeue/enqueue pointers - Issuing stop endpoint command during ep removal - Reset ERDP properly to first segment ring during interrupter removal. (this is currently just being cleared to 0, but should be pointing to a valid segment if controller is still running. Changes in v7: - Fixed dt check error for q6usb bindings - Updated q6usb property from qcom,usb-audio-intr-num --> qcom,usb-audio-intr-idx - Removed separate DWC3 HC interrupters num property, and place limits to XHCI one. - Modified xhci_ring_to_sgtable() to use assigned IOVA/DMA address to fetch pages, as it is not ensured event ring allocated is always done in the vmalloc range. Changes in v6: - Fixed limits and description on several DT bindings (XHCI and Q6USB) - Fixed patch subjects to follow other ALSA/ASoC notations. USB SND - Addressed devices which expose multiple audio (UAC) interfaces. These devices will create a single USB sound card with multiple audio streams, and receive multiple interface probe routines. QC offload was not properly considering cases with multiple probe calls. - Renamed offload module name and kconfig to fit within the SND domain. - Renamed attach/detach endpoint API to keep the hw_params notation. Changes in v5: - Removed some unnescessary files that were included - Fixed some typos mentioned - Addressed dt-binding issues and added hc-interrupters definition to usb-xhci.yaml XHCI: - Moved secondary skip events API to xhci-ring and updated implementation - Utilized existing XHCI APIs, such as inc_deq and xhci_update_erst_dequeue() USB SND - Renamed and reworked the APIs in "sound: usb: Export USB SND APIs for modules" patch to include suggestions to utilize snd_usb_hw_params/free and to avoid generic naming. - Added a resume_cb() op for completion sake. - Addressed some locking concerns with regards to when registering for platform hooks. - Added routine to disconnect all offloaded devices during module unbind. ASoC - Replaced individual PCM parameter arguments in snd_soc_usb_connect() with new snd_soc_usb_device structure to pass along PCM info. - Modified snd_jack set report to notify HEADPHONE event, as we do not support record path. Changes in v4: - Rebased to xhci/for-usb-next - Addressed some dt-bindings comments XHCI: - Pulled in latest changes from Mathias' feature_interrupters branch: https://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git/log/?h=feat… - Fixed commit text and signage for the XHCI sideband/interrupter related changes - Added some logic to address the FIXME tags mentioned throughout the commits, such as handling multi segment rings and building the SGT, locking concerns, and ep cleanup operations. - Removed some fixme tags for conditions that may not be needed/addressed. - Repurposed the new endpoint stop sync API to be utilized in other places. - Fixed potential compile issue if XHCI sideband config is not defined. ASoC: - Added sound jack control into the Q6USB driver. Allows for userpsace to know when an offload capable device is connected. USB SND: - Avoided exporting _snd_pcm_hw_param_set based on Takashi's recommendation. - Split USB QMI packet header definitions into a separate commit. This is used to properly allow the QMI interface driver to parse and route QMI packets accordingly - Added a "depends on" entry when enabling QC audio offload to avoid compile time issues. Changes in v3: - Changed prefix from RFC to PATCH - Rebased entire series to usb-next - Updated copyright years XHCI: - Rebased changes on top of XHCI changes merged into usb-next, and only added changes that were still under discussion. - Added change to read in the "num-hc-interrupters" device property. ASoC: - qusb6 USB backend - Incorporated suggestions to fetch iommu information with existing APIs - Added two new sound kcontrols to fetch offload status and offload device selection. - offload status - will return the card and pcm device in use tinymix -D 0 get 1 --> 1, 0 (offload in progress on card#1 pcm#0) - device selection - set the card and pcm device to enable offload on. Ex.: tinymix -D 0 set 1 2 0 --> sets offload on card#2 pcm#0 (this should be the USB card) USB SND: - Fixed up some locking related concerns for registering platform ops. - Moved callbacks under the register_mutex, so that - Modified APIs to properly pass more information about the USB SND device, so that the Q6USB backend can build a device list/map, in order to monitor offload status and device selection. Changes in v2: XHCI: - Replaced XHCI and HCD changes with Mathias' XHCI interrupter changes in his tree: https://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git/log/?h=feat… Adjustments made to Mathias' changes: - Created xhci-intr.h to export/expose interrupter APIs versus exposing xhci.h. Moved dependent structures to this file as well. (so clients can parse out information from "struct xhci_interrupter") - Added some basic locking when requesting interrupters. - Fixed up some sanity checks. - Removed clearing of the ERSTBA during freeing of the interrupter. (pending issue where SMMU fault occurs if DMA addr returned is 64b - TODO) - Clean up pending events in the XHCI secondary interrupter. While testing USB bus suspend, it was seen that on bus resume, the xHCI HC would run into a command timeout. - Added offloading APIs to xHCI to fetch transfer and event ring information. ASoC: - Modified soc-usb to allow for multiple USB port additions. For this to work, the USB offload driver has to have a reference to the USB backend by adding a "usb-soc-be" DT entry to the device saved into XHCI sysdev. - Created separate dt-bindings for defining USB_RX port. - Increased APR timeout to accommodate the situation where the AFE port start command could be delayed due to having to issue a USB bus resume while handling the QMI stream start command. USB SND: - Added a platform ops during usb_audio_suspend(). This allows for the USB offload driver to halt the audio stream when system enters PM suspend. This ensures the audio DSP is not issuing transfers on the USB bus. - Do not override platform ops if they are already populated. - Introduce a shared status variable between the USB offload and USB SND layers, to ensure that only one path is active at a time. If the USB bus is occupied, then userspace is notified that the path is busy. Mathias Nyman (13): xhci: fix possible null pointer dereference at secondary interrupter removal xhci: fix off by one check when adding a secondary interrupter. xhci: Add interrupt pending autoclear flag to each interrupter xhci: Add helper to set an interrupters interrupt moderation interval xhci: make isoc_bei_interval variable interrupter specific. xhci: remove unnecessary event_ring_deq parameter from xhci_handle_event() xhci: update event ring dequeue pointer position to controller correctly xhci: move event processing for one interrupter to a separate function xhci: add helper that checks for unhandled events on a event ring xhci: Don't check if the event ring is valid before every event TRB xhci: Decouple handling an event from checking for unhandled events xhci: add helper to stop endpoint and wait for completion xhci: sideband: add initial api to register a sideband entity Wesley Cheng (40): usb: host: xhci: Export enable and disable interrupter APIs usb: host: xhci: Repurpose event handler for skipping interrupter events xhci: export XHCI IMOD setting helper for interrupters usb: host: xhci-sideband: Expose a sideband interrupter enable API usb: host: xhci-mem: Cleanup pending secondary event ring events usb: host: xhci-mem: Allow for interrupter clients to choose specific index ASoC: Add SOC USB APIs for adding an USB backend ASoC: dt-bindings: qcom,q6dsp-lpass-ports: Add USB_RX port ASoC: qcom: qdsp6: Introduce USB AFE port to q6dsp ASoC: qdsp6: q6afe: Increase APR timeout ASoC: qcom: qdsp6: Add USB backend ASoC driver for Q6 ALSA: usb-audio: Introduce USB SND platform op callbacks ALSA: usb-audio: Export USB SND APIs for modules ALSA: usb-audio: Save UAC sample size information usb: dwc3: Specify maximum number of XHCI interrupters usb: host: xhci-plat: Set XHCI max interrupters if property is present ALSA: usb-audio: qcom: Add USB QMI definitions ALSA: usb-audio: qcom: Introduce QC USB SND offloading support ALSA: usb-audio: Check for support for requested audio format ASoC: usb: Add PCM format check API for USB backend ASoC: qcom: qdsp6: Ensure PCM format is supported by USB audio device ALSA: usb-audio: Prevent starting of audio stream if in use ALSA: usb-audio: Do not allow USB offload path if PCM device is in use ASoC: dt-bindings: Add Q6USB backend ASoC: dt-bindings: Update example for enabling USB offload on SM8250 ALSA: usb-audio: qcom: Populate PCM and USB chip information ASoC: qcom: qdsp6: Add support to track available USB PCM devices ASoC: Introduce SND kcontrols to select sound card and PCM device ASoC: qcom: qdsp6: Add SOC USB offload select get/put callbacks ASoC: Add SND kcontrol for fetching USB offload status ASoC: qcom: qdsp6: Add PCM ops to track current state ASoC: usb: Create SOC USB SND jack kcontrol ASoC: qcom: qdsp6: Add headphone jack for offload connection status ASoC: usb: Fetch ASoC sound card information ALSA: usb-audio: mixer: Add USB offloading mixer control ALSA: usb-audio: qcom: Use card and PCM index from QMI request ALSA: usb-audio: Allow for rediscovery of connected USB SND devices ASoC: usb: Rediscover USB SND devices on USB port add ASoC: qcom: Populate SoC components string ASoC: doc: Add documentation for SOC USB .../devicetree/bindings/sound/qcom,q6usb.yaml | 55 + .../bindings/sound/qcom,sm8250.yaml | 15 + Documentation/sound/soc/index.rst | 1 + Documentation/sound/soc/usb.rst | 611 ++++++ drivers/usb/dwc3/core.c | 12 + drivers/usb/dwc3/core.h | 2 + drivers/usb/dwc3/host.c | 5 +- drivers/usb/host/Kconfig | 9 + drivers/usb/host/Makefile | 2 + drivers/usb/host/xhci-mem.c | 53 +- drivers/usb/host/xhci-plat.c | 2 + drivers/usb/host/xhci-ring.c | 240 ++- drivers/usb/host/xhci-sideband.c | 439 ++++ drivers/usb/host/xhci.c | 97 +- drivers/usb/host/xhci.h | 21 +- .../sound/qcom,q6dsp-lpass-ports.h | 1 + include/linux/usb/xhci-sideband.h | 70 + include/sound/q6usboffload.h | 20 + include/sound/soc-usb.h | 90 + sound/soc/Makefile | 2 +- sound/soc/qcom/Kconfig | 4 + sound/soc/qcom/common.c | 41 + sound/soc/qcom/common.h | 4 +- sound/soc/qcom/qdsp6/Makefile | 1 + sound/soc/qcom/qdsp6/q6afe-dai.c | 60 + sound/soc/qcom/qdsp6/q6afe.c | 193 +- sound/soc/qcom/qdsp6/q6afe.h | 36 +- sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c | 23 + sound/soc/qcom/qdsp6/q6dsp-lpass-ports.h | 1 + sound/soc/qcom/qdsp6/q6routing.c | 9 + sound/soc/qcom/qdsp6/q6usb.c | 401 ++++ sound/soc/qcom/sm8250.c | 14 +- sound/soc/soc-usb.c | 538 +++++ sound/usb/Kconfig | 19 + sound/usb/Makefile | 3 +- sound/usb/card.c | 109 + sound/usb/card.h | 24 + sound/usb/endpoint.c | 1 + sound/usb/format.c | 1 + sound/usb/helper.c | 1 + sound/usb/mixer.c | 5 + sound/usb/mixer_usb_offload.c | 72 + sound/usb/mixer_usb_offload.h | 17 + sound/usb/pcm.c | 104 +- sound/usb/pcm.h | 11 + sound/usb/qcom/Makefile | 2 + sound/usb/qcom/qc_audio_offload.c | 1910 +++++++++++++++++ sound/usb/qcom/usb_audio_qmi_v01.c | 892 ++++++++ sound/usb/qcom/usb_audio_qmi_v01.h | 162 ++ 49 files changed, 6228 insertions(+), 177 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6usb.yaml create mode 100644 Documentation/sound/soc/usb.rst create mode 100644 drivers/usb/host/xhci-sideband.c create mode 100644 include/linux/usb/xhci-sideband.h create mode 100644 include/sound/q6usboffload.h create mode 100644 include/sound/soc-usb.h create mode 100644 sound/soc/qcom/qdsp6/q6usb.c create mode 100644 sound/soc/soc-usb.c create mode 100644 sound/usb/mixer_usb_offload.c create mode 100644 sound/usb/mixer_usb_offload.h create mode 100644 sound/usb/qcom/Makefile create mode 100644 sound/usb/qcom/qc_audio_offload.c create mode 100644 sound/usb/qcom/usb_audio_qmi_v01.c create mode 100644 sound/usb/qcom/usb_audio_qmi_v01.h

3 71