- Alsa-devel - mailman.alsa-project.org

[PATCH v2 0/2] Add Cadence I2S-MC controller driver
by Xingyu Wu 18 Apr '24

18 Apr '24

The Cadence Multi-channel I2S (I2S-MC) Controller implements a function of the multi-channel (up to 8-channel) bus. Each stereo channel combines functions of a transmitter and a receiver, and can switch freely between them. Each channel has independent gating, clock and interruption control. It also support some of these channels are used as playback and others can also be used as record in the same time. Four I2S controllers are used on the StarFive JH8100 SoC. Two of the I2S controllers use two stereo channels, one of them use four channels, and one use eight. It had tested on the fpga with WM8960 and PDM. Changes since v1: - Added new compatible for StarFive JH8100 SoC and a special property to be got as the max channels number in the bindings. - Dropped the useless '|' in the bindings. - Moved the drivers to a new folder named 'cdns' and modified the name of functions. v1: https://lore.kernel.org/all/20231221033223.73201-1-xingyu.wu@starfivetech.c… Xingyu Wu (2): ASoC: dt-bindings: Add bindings for Cadence I2S-MC controller ASoC: cdns: Add drivers of Cadence Multi-Channel I2S Controller .../bindings/sound/cdns,i2s-mc.yaml | 110 +++ MAINTAINERS | 6 + sound/soc/Kconfig | 1 + sound/soc/Makefile | 1 + sound/soc/cdns/Kconfig | 18 + sound/soc/cdns/Makefile | 3 + sound/soc/cdns/cdns-i2s-mc-pcm.c | 262 +++++++ sound/soc/cdns/cdns-i2s-mc.c | 724 ++++++++++++++++++ sound/soc/cdns/cdns-i2s-mc.h | 157 ++++ 9 files changed, 1282 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/cdns,i2s-mc.yaml create mode 100644 sound/soc/cdns/Kconfig create mode 100644 sound/soc/cdns/Makefile create mode 100644 sound/soc/cdns/cdns-i2s-mc-pcm.c create mode 100644 sound/soc/cdns/cdns-i2s-mc.c create mode 100644 sound/soc/cdns/cdns-i2s-mc.h -- 2.25.1

4 20

[PATCH] Fix volumn control of ThinkBook 16P Gen4
by zhanghuayu1233＠qq.com 18 Apr '24

18 Apr '24

From: Huayu Zhang <zhanghuayu1233(a)qq.com> change HDA & AMP configuration from ALC287_FIXUP_CS35L41_I2C_2 to ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD for ThinkBook 16P Gen4 models to fix volumn control issue (cannot fully mute). Signed-off-by: Huayu Zhang <zhanghuayu1233(a)qq.com> --- sound/pci/hda/patch_realtek.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index d6940bc4ec39..1aef223307bb 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -10396,8 +10396,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x17aa, 0x3886, "Y780 VECO DUAL", ALC287_FIXUP_TAS2781_I2C), SND_PCI_QUIRK(0x17aa, 0x38a7, "Y780P AMD YG dual", ALC287_FIXUP_TAS2781_I2C), SND_PCI_QUIRK(0x17aa, 0x38a8, "Y780P AMD VECO dual", ALC287_FIXUP_TAS2781_I2C), - SND_PCI_QUIRK(0x17aa, 0x38a9, "Thinkbook 16P", ALC287_FIXUP_CS35L41_I2C_2), - SND_PCI_QUIRK(0x17aa, 0x38ab, "Thinkbook 16P", ALC287_FIXUP_CS35L41_I2C_2), + SND_PCI_QUIRK(0x17aa, 0x38a9, "Thinkbook 16P", ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD), + SND_PCI_QUIRK(0x17aa, 0x38ab, "Thinkbook 16P", ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD), SND_PCI_QUIRK(0x17aa, 0x38b4, "Legion Slim 7 16IRH8", ALC287_FIXUP_CS35L41_I2C_2), SND_PCI_QUIRK(0x17aa, 0x38b5, "Legion Slim 7 16IRH8", ALC287_FIXUP_CS35L41_I2C_2), SND_PCI_QUIRK(0x17aa, 0x38b6, "Legion Slim 7 16APH8", ALC287_FIXUP_CS35L41_I2C_2), -- 2.34.1

2 1

[PATCH v2 0/7] Add features, fixes and laptops for CS35L41 HDA
by Stefan Binding 18 Apr '24

18 Apr '24

This chain adds a number of improvements for CS35L41, including a new firmware loading feature, as well as some additional cleanup. Patch 1 adds support for a new firmware tuning file which is used to set special tuning parameters used by the firmware. The HP Omen laptop added in patches 2 and 3 use such a feature. Patch 4 changes the DSP1RX5/6 Source used by the firmware to depend on the boost type. A similar change in the ASoC driver will be needed later. Patches 5 and 6 are cleanup patches, with the first of those re-using cs-amp-lib for calibration which as added for CS35L56 drivers, ensuring that all laptops are using the correct calibration values. Patch 7 fixes a small error in the CS35L41 Property table for the Lenovo Legion slim 7 16ARHA7. Changes since v1: - Fixed print statements based on warnings from kernel test robot Richard Fitzgerald (1): ALSA: hda: cs35l41: Remove redundant argument to cs35l41_request_firmware_file() Stefan Binding (6): ALSA: hda: cs35l41: Set the max PCM Gain using tuning setting ALSA: hda: cs35l41: Support HP Omen models without _DSD ALSA: hda/realtek: Add quirks for HP Omen models using CS35L41 ALSA: hda: cs35l41: Update DSP1RX5/6 Sources for DSP config ALSA: hda: cs35l41: Use shared cs-amp-lib to apply calibration ALSA: hda: cs35l41: Remove Speaker ID for Lenovo Legion slim 7 16ARHA7 include/sound/cs35l41.h | 5 + sound/pci/hda/Kconfig | 2 + sound/pci/hda/cs35l41_hda.c | 347 +++++++++++++++++++-------- sound/pci/hda/cs35l41_hda.h | 6 + sound/pci/hda/cs35l41_hda_property.c | 8 +- sound/pci/hda/patch_realtek.c | 4 + 6 files changed, 265 insertions(+), 107 deletions(-) -- 2.34.1

2 8

[PATCH v1] ALSA: hda/tas2781: Add new vendor_id and subsystem_id to support ThinkPad ICE-1
by Shenghao Ding 18 Apr '24

18 Apr '24

Add new vendor_id and subsystem_id to support new Lenovo laptop ThinkPad ICE-1 Signed-off-by: Shenghao Ding <shenghao-ding(a)ti.com> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index cdcb28aa9d7b..051ca23c8cfa 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -10333,6 +10333,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x17aa, 0x222e, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), SND_PCI_QUIRK(0x17aa, 0x2231, "Thinkpad T560", ALC292_FIXUP_TPT460), SND_PCI_QUIRK(0x17aa, 0x2233, "Thinkpad", ALC292_FIXUP_TPT460), + SND_PCI_QUIRK(0x17aa, 0x2234, "Thinkpad ICE-1", ALC287_FIXUP_TAS2781_I2C), SND_PCI_QUIRK(0x17aa, 0x2245, "Thinkpad T470", ALC298_FIXUP_TPT470_DOCK), SND_PCI_QUIRK(0x17aa, 0x2246, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), SND_PCI_QUIRK(0x17aa, 0x2247, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), -- 2.34.1

2 1

[PATCH v1 RESEND] slimbus: stream: Add null pointer check for client functions
by Viken Dadhaniya 17 Apr '24

17 Apr '24

There is a possible scenario where client driver is calling slimbus stream APIs in incorrect sequence and it might lead to invalid null access of the stream pointer in slimbus enable/disable/prepare/unprepare/free function. Fix this by checking validity of the stream before accessing in all function API’s exposed to client. Signed-off-by: Viken Dadhaniya <quic_vdadhani(a)quicinc.com> --- drivers/slimbus/stream.c | 37 +++++++++++++++++++++++++++++++++---- 1 file changed, 33 insertions(+), 4 deletions(-) diff --git a/drivers/slimbus/stream.c b/drivers/slimbus/stream.c index 1d6b38657917..c5a436fd0952 100644 --- a/drivers/slimbus/stream.c +++ b/drivers/slimbus/stream.c @@ -202,10 +202,16 @@ static int slim_get_prate_code(int rate) int slim_stream_prepare(struct slim_stream_runtime *rt, struct slim_stream_config *cfg) { - struct slim_controller *ctrl = rt->dev->ctrl; + struct slim_controller *ctrl; struct slim_port *port; int num_ports, i, port_id, prrate; + if (!rt || !cfg) { + pr_err("%s: Stream or cfg is NULL, Check from client side\n", __func__); + return -EINVAL; + } + + ctrl = rt->dev->ctrl; if (rt->ports) { dev_err(&rt->dev->dev, "Stream already Prepared\n"); return -EINVAL; @@ -358,9 +364,15 @@ int slim_stream_enable(struct slim_stream_runtime *stream) { DEFINE_SLIM_BCAST_TXN(txn, SLIM_MSG_MC_BEGIN_RECONFIGURATION, 3, SLIM_LA_MANAGER, NULL); - struct slim_controller *ctrl = stream->dev->ctrl; + struct slim_controller *ctrl; int ret, i; + if (!stream) { + pr_err("%s: Stream is NULL, Check from client side\n", __func__); + return -EINVAL; + } + + ctrl = stream->dev->ctrl; if (ctrl->enable_stream) { ret = ctrl->enable_stream(stream); if (ret) @@ -411,12 +423,18 @@ int slim_stream_disable(struct slim_stream_runtime *stream) { DEFINE_SLIM_BCAST_TXN(txn, SLIM_MSG_MC_BEGIN_RECONFIGURATION, 3, SLIM_LA_MANAGER, NULL); - struct slim_controller *ctrl = stream->dev->ctrl; + struct slim_controller *ctrl; int ret, i; + if (!stream) { + pr_err("%s: Stream is NULL, Check from client side\n", __func__); + return -EINVAL; + } + if (!stream->ports || !stream->num_ports) return -EINVAL; + ctrl = stream->dev->ctrl; if (ctrl->disable_stream) ctrl->disable_stream(stream); @@ -448,6 +466,11 @@ int slim_stream_unprepare(struct slim_stream_runtime *stream) { int i; + if (!stream) { + pr_err("%s: Stream is NULL, Check from client side\n", __func__); + return -EINVAL; + } + if (!stream->ports || !stream->num_ports) return -EINVAL; @@ -476,8 +499,14 @@ EXPORT_SYMBOL_GPL(slim_stream_unprepare); */ int slim_stream_free(struct slim_stream_runtime *stream) { - struct slim_device *sdev = stream->dev; + struct slim_device *sdev; + + if (!stream) { + pr_err("%s: Stream is NULL, Check from client side\n", __func__); + return -EINVAL; + } + sdev = stream->dev; spin_lock(&sdev->stream_list_lock); list_del(&stream->node); spin_unlock(&sdev->stream_list_lock); -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

3 5

[PATCH v2] slimbus: stream: Add null pointer check for client APIs
by Viken Dadhaniya 17 Apr '24

17 Apr '24

Due to incorrect sequrnce of slimbus APIs called by client driver, facing system crash in slimbus framework APIs. To prevent system crash, add NULL pointer check in enable/disable/prepare/unprepare/free APIs. Signed-off-by: Viken Dadhaniya <quic_vdadhani(a)quicinc.com> --- v1 -> v2: - Update commit log. - Update debug logs. v1 Link: https://lore.kernel.org/linux-arm-msm/ZhgIHHP1FUeCr+vx@hu-bjorande-lv.qualc… --- --- drivers/slimbus/stream.c | 37 +++++++++++++++++++++++++++++++++---- 1 file changed, 33 insertions(+), 4 deletions(-) diff --git a/drivers/slimbus/stream.c b/drivers/slimbus/stream.c index 1d6b38657917..76d0579cbf53 100644 --- a/drivers/slimbus/stream.c +++ b/drivers/slimbus/stream.c @@ -202,10 +202,16 @@ static int slim_get_prate_code(int rate) int slim_stream_prepare(struct slim_stream_runtime *rt, struct slim_stream_config *cfg) { - struct slim_controller *ctrl = rt->dev->ctrl; + struct slim_controller *ctrl; struct slim_port *port; int num_ports, i, port_id, prrate; + if (!rt || !cfg) { + pr_err("Invalid stream rt or cfg\n"); + return -EINVAL; + } + + ctrl = rt->dev->ctrl; if (rt->ports) { dev_err(&rt->dev->dev, "Stream already Prepared\n"); return -EINVAL; @@ -358,9 +364,15 @@ int slim_stream_enable(struct slim_stream_runtime *stream) { DEFINE_SLIM_BCAST_TXN(txn, SLIM_MSG_MC_BEGIN_RECONFIGURATION, 3, SLIM_LA_MANAGER, NULL); - struct slim_controller *ctrl = stream->dev->ctrl; + struct slim_controller *ctrl; int ret, i; + if (!stream) { + pr_err("Invalid stream\n"); + return -EINVAL; + } + + ctrl = stream->dev->ctrl; if (ctrl->enable_stream) { ret = ctrl->enable_stream(stream); if (ret) @@ -411,12 +423,18 @@ int slim_stream_disable(struct slim_stream_runtime *stream) { DEFINE_SLIM_BCAST_TXN(txn, SLIM_MSG_MC_BEGIN_RECONFIGURATION, 3, SLIM_LA_MANAGER, NULL); - struct slim_controller *ctrl = stream->dev->ctrl; + struct slim_controller *ctrl; int ret, i; + if (!stream) { + pr_err("Invalid stream"); + return -EINVAL; + } + if (!stream->ports || !stream->num_ports) return -EINVAL; + ctrl = stream->dev->ctrl; if (ctrl->disable_stream) ctrl->disable_stream(stream); @@ -448,6 +466,11 @@ int slim_stream_unprepare(struct slim_stream_runtime *stream) { int i; + if (!stream) { + pr_err("Invalid stream\n"); + return -EINVAL; + } + if (!stream->ports || !stream->num_ports) return -EINVAL; @@ -476,8 +499,14 @@ EXPORT_SYMBOL_GPL(slim_stream_unprepare); */ int slim_stream_free(struct slim_stream_runtime *stream) { - struct slim_device *sdev = stream->dev; + struct slim_device *sdev; + + if (!stream) { + pr_err("Invalid stream\n"); + return -EINVAL; + } + sdev = stream->dev; spin_lock(&sdev->stream_list_lock); list_del(&stream->node); spin_unlock(&sdev->stream_list_lock); -- 2.17.1

1 0

[PATCH 0/7] Xperia 1 V support
by Konrad Dybcio 17 Apr '24

17 Apr '24

DTS for the phone and some fly-by fixes Patch 1 for Mark/sound Rest for qcom Signed-off-by: Konrad Dybcio <konrad.dybcio(a)linaro.org> --- Konrad Dybcio (7): dt-bindings: ASoC: cs35l45: Add interrupts dt-bindings: arm: qcom: Add Xperia 1 V arm64: dts: qcom: sm8550: Mark QUPs and GPI dma-coherent arm64: dts: qcom: sm8550: Mark APPS SMMU as dma-coherent arm64: dts: qcom: sm8550: Add missing DWC3 quirks arm64: dts: qcom: sm8550: Mark DWC3 as dma-coherent arm64: dts: qcom: Add SM8550 Xperia 1 V Documentation/devicetree/bindings/arm/qcom.yaml | 1 + .../devicetree/bindings/sound/cirrus,cs35l45.yaml | 3 + arch/arm64/boot/dts/qcom/Makefile | 1 + .../dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts | 779 +++++++++++++++++++++ arch/arm64/boot/dts/qcom/sm8550.dtsi | 20 +- 5 files changed, 801 insertions(+), 3 deletions(-) --- base-commit: ae00c445390b349e070a64dc62f08aa878db7248 change-id: 20240210-topic-1v-18e9697d2056 Best regards, -- Konrad Dybcio <konrad.dybcio(a)linaro.org>

8 20

[PATCH ver.2 6.1.y 0/6] ASoC: codecs: es8326: fix support (backport from v6.6)
by kovalev＠altlinux.org 17 Apr '24

17 Apr '24

Without these patches, all tested laptop models using the es8326 audio codec have no sound from the speakers and headphones, and the headset microphone does not work. Although the initialization of the sound card is successful. -- ver.2: drop a commit that does not affect the fix of functionality; added an explanation that does not work on the current version of the kernel without patches. -- Patches have been successfully tested on the latest 6.1.86 kernel. [PATCH 6.1.y 1/6] ASoC: codecs: ES8326: Add es8326_mute function [PATCH 6.1.y 2/6] ASoC: codecs: ES8326: Change Hp_detect register names [PATCH 6.1.y 3/6] ASoC: codecs: ES8326: Change Volatile Reg function [PATCH 6.1.y 4/6] ASoC: codecs: ES8326: Fix power-up sequence [PATCH 6.1.y 5/6] ASOC: codecs: ES8326: Add calibration support for [PATCH 6.1.y 6/6] ASoC: codecs: ES8326: Update jact detection function

1 6

[PATCH v3 71/74] x86/cpu/vfm: Update sound/soc/intel/avs/boards/es8336.c
by Tony Luck 17 Apr '24

17 Apr '24

New CPU #defines encode vendor and family as well as model. Signed-off-by: Tony Luck <tony.luck(a)intel.com> --- sound/soc/intel/avs/boards/es8336.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sound/soc/intel/avs/boards/es8336.c b/sound/soc/intel/avs/boards/es8336.c index 5c90a6007577..6c86c581877e 100644 --- a/sound/soc/intel/avs/boards/es8336.c +++ b/sound/soc/intel/avs/boards/es8336.c @@ -18,6 +18,7 @@ #include <sound/pcm_params.h> #include <sound/soc.h> #include <sound/soc-acpi.h> +#include <asm/cpu_device_id.h> #include <asm/intel-family.h> #include "../utils.h" @@ -153,9 +154,9 @@ static int avs_es8336_hw_params(struct snd_pcm_substream *substream, int clk_freq; int ret; - switch (boot_cpu_data.x86_model) { - case INTEL_FAM6_KABYLAKE_L: - case INTEL_FAM6_KABYLAKE: + switch (boot_cpu_data.x86_vfm) { + case INTEL_KABYLAKE_L: + case INTEL_KABYLAKE: clk_freq = 24000000; break; default: -- 2.44.0

2 1

ucm2: HDA: Use Master volume control for dual speakers
by GitHub pull_request - opened 16 Apr '24

16 Apr '24

alsa-project/alsa-ucm-conf pull request #410 was opened from tuxedoxt: This PR extends the existing 'activate Bass Speaker' case with additional configuration - Use Master mixer for volume control (instead of only using Speaker) - Configure Speaker Volume and Bass Speaker volume to max since Master volume regulation is used It fixes a case where only the first speaker volume is changed using the system volume control. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/410 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/410.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0