- Alsa-devel - mailman.alsa-project.org

[PATCH AUTOSEL 6.11 14/16] ASoC: stm: Prevent potential division by zero in stm32_sai_get_clk_div()
by Sasha Levin 12 Nov '24

12 Nov '24

From: Luo Yifan <luoyifan(a)cmss.chinamobile.com> [ Upstream commit 23569c8b314925bdb70dd1a7b63cfe6100868315 ] This patch checks if div is less than or equal to zero (div <= 0). If div is zero or negative, the function returns -EINVAL, ensuring the division operation is safe to perform. Signed-off-by: Luo Yifan <luoyifan(a)cmss.chinamobile.com> Reviewed-by: Olivier Moysan <olivier.moysan(a)foss.st.com> Link: https://patch.msgid.link/20241107015936.211902-1-luoyifan@cmss.chinamobile.… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/stm/stm32_sai_sub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index 19307812ec765..64f52c75e2aa8 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -317,7 +317,7 @@ static int stm32_sai_get_clk_div(struct stm32_sai_sub_data *sai, int div; div = DIV_ROUND_CLOSEST(input_rate, output_rate); - if (div > SAI_XCR1_MCKDIV_MAX(version)) { + if (div > SAI_XCR1_MCKDIV_MAX(version) || div <= 0) { dev_err(&sai->pdev->dev, "Divider %d out of range\n", div); return -EINVAL; } -- 2.43.0

1 0

[PATCH AUTOSEL 6.11 13/16] ASoC: stm: Prevent potential division by zero in stm32_sai_mclk_round_rate()
by Sasha Levin 12 Nov '24

12 Nov '24

From: Luo Yifan <luoyifan(a)cmss.chinamobile.com> [ Upstream commit 63c1c87993e0e5bb11bced3d8224446a2bc62338 ] This patch checks if div is less than or equal to zero (div <= 0). If div is zero or negative, the function returns -EINVAL, ensuring the division operation (*prate / div) is safe to perform. Signed-off-by: Luo Yifan <luoyifan(a)cmss.chinamobile.com> Link: https://patch.msgid.link/20241106014654.206860-1-luoyifan@cmss.chinamobile.… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/stm/stm32_sai_sub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index ad2492efb1cdc..19307812ec765 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -378,8 +378,8 @@ static long stm32_sai_mclk_round_rate(struct clk_hw *hw, unsigned long rate, int div; div = stm32_sai_get_clk_div(sai, *prate, rate); - if (div < 0) - return div; + if (div <= 0) + return -EINVAL; mclk->freq = *prate / div; -- 2.43.0

1 0

[PATCH AUTOSEL 6.11 07/16] ASoC: tas2781: Add new driver version for tas2563 & tas2781 qfn chip
by Sasha Levin 12 Nov '24

12 Nov '24

From: Shenghao Ding <shenghao-ding(a)ti.com> [ Upstream commit fe09de2db2365eed8b44b572cff7d421eaf1754a ] Add new driver version to support tas2563 & tas2781 qfn chip Signed-off-by: Shenghao Ding <shenghao-ding(a)ti.com> Link: https://patch.msgid.link/20241104100055.48-1-shenghao-ding@ti.com Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/codecs/tas2781-fmwlib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/tas2781-fmwlib.c b/sound/soc/codecs/tas2781-fmwlib.c index f3a7605f07104..6474cc551d551 100644 --- a/sound/soc/codecs/tas2781-fmwlib.c +++ b/sound/soc/codecs/tas2781-fmwlib.c @@ -1992,6 +1992,7 @@ static int tasdevice_dspfw_ready(const struct firmware *fmw, break; case 0x202: case 0x400: + case 0x401: tas_priv->fw_parse_variable_header = fw_parse_variable_header_git; tas_priv->fw_parse_program_data = -- 2.43.0

1 0

[RESEND PATCH v5 0/6] ASoC: fsl: add memory to memory function for ASRC
by Shengjiu Wang 12 Nov '24

12 Nov '24

This function is base on the accelerator implementation for compress API: https://patchwork.kernel.org/project/alsa-devel/patch/20241002093904.180979… Audio signal processing also has the requirement for memory to memory similar as Video. This asrc memory to memory (memory ->asrc->memory) case is a non real time use case. User fills the input buffer to the asrc module, after conversion, then asrc sends back the output buffer to user. So it is not a traditional ALSA playback and capture case. Because we had implemented the "memory -> asrc ->i2s device-> codec" use case in ALSA. Now the "memory->asrc->memory" needs to reuse the code in asrc driver, so the patch 1 and patch 2 is for refining the code to make it can be shared by the "memory->asrc->memory" driver. Other change is to add memory to memory support for two kinds of i.MX ASRC modules. changes in v5: - Drop Jaroslav Kysela's patch as it has been merged. - Add Jaroslav Kysela's Acked-by tag, received in v3. changes in v4: - remove the RFC tag, no comments receive in v3 - Add Jaroslav Kysela's patch in this patch set. because it may be better for reviewing in a full patch set. - Fix the list_for_each_entry_reverse to list_for_each_entry_safe_reverse - Fix some coding style issues in Jaroslav Kysela's patch changes in v3: - use Jaroslav's suggestion for header file compress_params.h (PATCH 01) - remove the ASRC_OUTPUT_FORMAT/ASRC_OUTPUT_RATE definition - remove ASRC_RATIO_MOD in this version because it uses .set_metadata() Will wait Jaroslav's update or other better method in the future. - Address some comments from Pierre. changes in v2: - Remove the changes in compress API - drop the SNDRV_COMPRESS_SRC_RATIO_MOD - drop the SND_AUDIOCODEC_SRC and struct snd_dec_src - define private metadata key value ASRC_OUTPUT_FORMAT/ASRC_OUTPUT_RATE/ASRC_RATIO_MOD Shengjiu Wang (6): ALSA: compress: Add output rate and output format support ASoC: fsl_asrc: define functions for memory to memory usage ASoC: fsl_easrc: define functions for memory to memory usage ASoC: fsl_asrc_m2m: Add memory to memory function ASoC: fsl_asrc: register m2m platform device ASoC: fsl_easrc: register m2m platform device include/uapi/sound/compress_params.h | 23 +- sound/soc/fsl/Kconfig | 1 + sound/soc/fsl/Makefile | 2 +- sound/soc/fsl/fsl_asrc.c | 179 ++++++- sound/soc/fsl/fsl_asrc.h | 2 + sound/soc/fsl/fsl_asrc_common.h | 70 +++ sound/soc/fsl/fsl_asrc_m2m.c | 727 +++++++++++++++++++++++++++ sound/soc/fsl/fsl_easrc.c | 261 +++++++++- sound/soc/fsl/fsl_easrc.h | 4 + 9 files changed, 1260 insertions(+), 9 deletions(-) create mode 100644 sound/soc/fsl/fsl_asrc_m2m.c -- 2.34.1

1 6

ALC4082 - ASRock X870 Steel Legend
by GitHub issues - edited 12 Nov '24

12 Nov '24

alsa-project/alsa-ucm-conf issue #462 was edited from cybik: | Following up | Relevant PR | | ------------------| ---------------- | | https://github.com/alsa-project/alsa-ucm-conf/issues/334 | https://github.com/alsa-project/alsa-ucm-conf/pull/461 | The card "works", but there is one feature missing - though I hesitate to call it "critical": S/PDIF / TOSLINK support is incomplete. While sound works "fine" (ish), it's limited to 2 channels. * Plugging in another USB device (CM106-type, for example) gives out a plethora of configuration options (per the screenshot), though this also comes with having to select the right output * The "USB" audio outs are output-specific, which is VERY welcome, but the S/PDIF out does not allow for any advanced selection like "Supported Codecs", and the HiFi 5.1 and 7.1 do not appear to enable any IEC958/AC3 support in the background Is there something missing in the config files to allow for such support? ![image](https://github.com/user-attachments/assets/906ea829-0210-49a8-ba16-ad1b5b1285ae) Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/462 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

ALC4082 - ASRock X870 Steel Legend
by GitHub issues - edited 12 Nov '24

12 Nov '24

alsa-project/alsa-ucm-conf issue #462 was edited from cybik: | Following up | Relevant PR | | ------------------| ---------------- | | https://github.com/alsa-project/alsa-ucm-conf/issues/334 | https://github.com/alsa-project/alsa-ucm-conf/pull/461 | The card "works", but there is one feature missing - though I hesitate to call it "critical": S/PDIF / TOSLINK support is incomplete. While sound works "fine" (ish), it's limited to 2 channels. * Plugging in another USB device (CM106-type, for example) gives out a plethora of configuration options (per the screenshot), though this also comes with having to select the right output * The USB audio outs are output-specific, which is VERY welcome, but the S/PDIF out does not allow for any advanced selection like "Supported Codecs", and the HiFi 5.1 and 7.1 do not appear to enable any IEC958/AC3 support in the background Is there something missing in the config files to allow for such support? ![image](https://github.com/user-attachments/assets/906ea829-0210-49a8-ba16-ad1b5b1285ae) Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/462 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

ALC4082 - ASRock X870 Steel Legend
by GitHub issues - edited 12 Nov '24

12 Nov '24

alsa-project/alsa-ucm-conf issue #462 was edited from cybik: | Following up | Relevant PR | | ------------------| ---------------- | | https://github.com/alsa-project/alsa-ucm-conf/issues/334 | https://github.com/alsa-project/alsa-ucm-conf/pull/461 | The card "works", but there is one feature missing - though I hesitate to call it "critical": S/PDIF / TOSLINK support is incomplete. While sound works "fine" (ish), it's limited to 2 channels. * Plugging in another device (CM106-type, for example) gives out a plethora of configuration options (per the screenshot), though this also comes with having to select the right output * The USB audio outs are output-specific, which is VERY welcome, but the S/PDIF out does not allow for any advanced selection like "Supported Codecs", and the HiFi 5.1 and 7.1 do not appear to enable any IEC958/AC3 support in the background Is there something missing in the config files to allow for such support? ![image](https://github.com/user-attachments/assets/906ea829-0210-49a8-ba16-ad1b5b1285ae) Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/462 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

ALC4082 - ASRock X870 Steel Legend
by GitHub issues - edited 12 Nov '24

12 Nov '24

alsa-project/alsa-ucm-conf issue #462 was edited from cybik: Following up on https://github.com/alsa-project/alsa-ucm-conf/issues/334 | Relevant PR: https://github.com/alsa-project/alsa-ucm-conf/pull/461 The card "works", but there is one feature missing - though I hesitate to call it "critical": S/PDIF / TOSLINK support is incomplete. While sound works "fine" (ish), it's limited to 2 channels. * Plugging in another device (CM106-type, for example) gives out a plethora of configuration options (per the screenshot), though this also comes with having to select the right output * The USB audio outs are output-specific, which is VERY welcome, but the S/PDIF out does not allow for any advanced selection like "Supported Codecs", and the HiFi 5.1 and 7.1 do not appear to enable any IEC958/AC3 support in the background Is there something missing in the config files to allow for such support? ![image](https://github.com/user-attachments/assets/906ea829-0210-49a8-ba16-ad1b5b1285ae) Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/462 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

ALC4082 - ASRock X870 Steel Legend
by GitHub issues - opened 12 Nov '24

12 Nov '24

alsa-project/alsa-ucm-conf issue #462 was opened from cybik: Following up on https://github.com/alsa-project/alsa-ucm-conf/issues/334 The card "works", but there is one feature missing - though I hesitate to call it "critical": S/PDIF / TOSLINK support is incomplete. While sound works "fine" (ish), it's limited to 2 channels. * Plugging in another device (CM106-type, for example) gives out a plethora of configuration options (per the screenshot), though this also comes with having to select the right output * The USB audio outs are output-specific, which is VERY welcome, but the S/PDIF out does not allow for any advanced selection like "Supported Codecs", and the HiFi 5.1 and 7.1 do not appear to enable any IEC958/AC3 support in the background Is there something missing in the config files to allow for such support? ![image](https://github.com/user-attachments/assets/906ea829-0210-49a8-ba16-ad1b5b1285ae) Relevant PR: https://github.com/alsa-project/alsa-ucm-conf/pull/461 Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/462 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

`amixer sset Master` doesnt increase and decrease both sides equally
by GitHub issues - opened 11 Nov '24

11 Nov '24

alsa-project/alsa-utils issue #279 was opened from lquenti: I look through the issues, man pages and internet and hope I didn't miss anything. Please tell me if its a user error. Whenever I use `amixer sset Master` to increase volume, it will not increase them evenly. Here is a before ![before](https://github.com/user-attachments/assets/4ccfa220-608c-4407-9f6e-fc1d27f1a91b) and after ![after](https://github.com/user-attachments/assets/250ab254-d46a-44e4-a201-58f9224b6293) Interestingly amixer seem to think that it is still evenly balanced, although alsamixer shows that it is unbalanced afterwards. --- Interestingly, when decreasing, the unevenness flips to the other side. [Other people also seem to struggle with it](https://stackoverflow.com/questions/69826139/using-amixer-to-set-audio-… Thank you so much. If it is something somewhat simple to fix, I can also write a fix myself, but for now I am unsure what the problem is. Issue URL : https://github.com/alsa-project/alsa-utils/issues/279 Repository URL: https://github.com/alsa-project/alsa-utils

1 0