- Alsa-devel - mailman.alsa-project.org

[alsa-devel] alsa callback not async - Second post to this list
by William Estrada 14 Sep '08

14 Sep '08

Hi guys, I am cross posting this because I am not sure which list it belongs to. I have a test program I wrote to help me learn ALSA APIs, It work to a degree. It is a simple Capture/Playback interface. My problem is that when the Callback starts, it does not allow any cycles back to the main program. The main program waits for console input to tell the callback when to stop. Well it does not accept any console input when the callback is running. Any ideas?? The source is here: http://64.124.13.3/_ALSA_/Echo/ -- William Estrada MrUmunhum(a)popdial.com Mt-Umunhum-Wireless.net ( http://Mt-Umunhum-Wireless.net ) Ymessenger: MrUmunhum

1 0

[alsa-devel] [PATCH take 2] ALSA: HDA: patch_analog: Quirk for Asus P5Q Premium/Pro boards.
by robbat2＠gentoo.org 14 Sep '08

14 Sep '08

From: Robin H. Johnson <robbat2(a)gentoo.org> Use 6STACK_DIG for the AD2000BX variant of the AD1989B chip used by Asus on their Asus P5Q Premium and Pro boards. Signed-off-by: Robin H. Johnson <robbat2(a)gentoo.org> diff --git a/sound/pci/hda/patch_analog.c b/sound/pci/hda/patch_analog.c index 42b1a23..2b00c4a 100644 --- a/sound/pci/hda/patch_analog.c +++ b/sound/pci/hda/patch_analog.c @@ -2884,6 +2884,7 @@ static struct snd_pci_quirk ad1988_cfg_tbl[] = { SND_PCI_QUIRK(0x1043, 0x81ec, "Asus P5B-DLX", AD1988_6STACK_DIG), SND_PCI_QUIRK(0x1043, 0x81f6, "Asus M2N-SLI", AD1988_6STACK_DIG), SND_PCI_QUIRK(0x1043, 0x8277, "Asus P5K-E/WIFI-AP", AD1988_6STACK_DIG), + SND_PCI_QUIRK(0x1043, 0x8311, "Asus P5Q-Premium/Pro", AD1988_6STACK_DIG), {} }; -- 1.6.0.1

1 0

[alsa-devel] [PATCH] ALSA: HDA: patch_analog: Quirk for Asus P5Q Premium/Pro boards.
by robbat2＠gentoo.org 14 Sep '08

14 Sep '08

From: Robin H. Johnson <robbat2(a)orbis-terrarum.net> Use 6STACK_DIG for the AD2000BX variant of the AD1989B chip used by Asus on their Asus P5Q Premium and Pro boards. Signed-off-by: Robin H. Johnson <robbat2(a)gentoo.org> diff --git a/sound/pci/hda/patch_analog.c b/sound/pci/hda/patch_analog.c index 42b1a23..2b00c4a 100644 --- a/sound/pci/hda/patch_analog.c +++ b/sound/pci/hda/patch_analog.c @@ -2884,6 +2884,7 @@ static struct snd_pci_quirk ad1988_cfg_tbl[] = { SND_PCI_QUIRK(0x1043, 0x81ec, "Asus P5B-DLX", AD1988_6STACK_DIG), SND_PCI_QUIRK(0x1043, 0x81f6, "Asus M2N-SLI", AD1988_6STACK_DIG), SND_PCI_QUIRK(0x1043, 0x8277, "Asus P5K-E/WIFI-AP", AD1988_6STACK_DIG), + SND_PCI_QUIRK(0x1043, 0x8311, "Asus P5Q-Premium/Pro", AD1988_6STACK_DIG), {} }; -- 1.6.0.1

1 0

[alsa-devel] [PATCH] ALSA: HDA: hda_local: Less magic numbers.
by robbat2＠gentoo.org 14 Sep '08

14 Sep '08

From: Robin H. Johnson <robbat2(a)gentoo.org> Explain some of the magic numbers I saw while trying to fix the AD1989 SPDIF issue. Maybe should just use the expanded form directly in the verbs? Signed-off-by: Robin H. Johnson <robbat2(a)gentoo.org> diff --git a/sound/pci/hda/hda_local.h b/sound/pci/hda/hda_local.h index d688f50..7957fef 100644 --- a/sound/pci/hda/hda_local.h +++ b/sound/pci/hda/hda_local.h @@ -368,12 +368,15 @@ int snd_hda_parse_pin_def_config(struct hda_codec *codec, #define AMP_OUT_UNMUTE 0xb000 #define AMP_OUT_ZERO 0xb000 /* pinctl values */ -#define PIN_IN 0x20 -#define PIN_VREF80 0x24 -#define PIN_VREF50 0x21 -#define PIN_OUT 0x40 -#define PIN_HP 0xc0 -#define PIN_HP_AMP 0x80 +#define PIN_IN (AC_PINCTL_IN_EN) +#define PIN_VREFHIZ (AC_PINCTL_IN_EN | AC_PINCTL_VREF_HIZ) +#define PIN_VREF50 (AC_PINCTL_IN_EN | AC_PINCTL_VREF_50) +#define PIN_VREFGRD (AC_PINCTL_IN_EN | AC_PINCTL_VREF_GRD) +#define PIN_VREF80 (AC_PINCTL_IN_EN | AC_PINCTL_VREF_80) +#define PIN_VREF100 (AC_PINCTL_IN_EN | AC_PINCTL_VREF_100) +#define PIN_OUT (AC_PINCTL_OUT_EN) +#define PIN_HP (AC_PINCTL_OUT_EN | AC_PINCTL_HP_EN) +#define PIN_HP_AMP (AC_PINCTL_HP_EN) /* * get widget capabilities -- 1.6.0.1

1 0

[alsa-devel] [PATCH] ALSA: HDA: patch_analog: Implement multiple outputs for AD1988
by robbat2＠gentoo.org 14 Sep '08

14 Sep '08

From: Robin H. Johnson <robbat2(a)gentoo.org> Implement the slave_dig_outs for AD1989 cards. Untested due to lack of hardware. Signed-off-by: Robin H. Johnson <robbat2(a)gentoo.org> diff --git a/sound/pci/hda/patch_analog.c b/sound/pci/hda/patch_analog.c index 0899b6b..b037324 100644 --- a/sound/pci/hda/patch_analog.c +++ b/sound/pci/hda/patch_analog.c @@ -1826,9 +1826,14 @@ static hda_nid_t ad1988_capsrc_nids[3] = { 0x0c, 0x0d, 0x0e }; -#define AD1988_SPDIF_OUT 0x02 +#define AD1988_SPDIF_OUT 0x02 +#define AD1988_SPDIF_OUT_HDMI 0x0b #define AD1988_SPDIF_IN 0x07 +static hda_nid_t ad1989b_slave_dig_outs[2] = { + AD1988_SPDIF_OUT, AD1988_SPDIF_OUT_HDMI +}; + static struct hda_input_mux ad1988_6stack_capture_source = { .num_items = 5, .items = { @@ -2143,6 +2148,7 @@ static struct snd_kcontrol_new ad1988_spdif_in_mixers[] = { static struct snd_kcontrol_new ad1989_spdif_out_mixers[] = { HDA_CODEC_VOLUME("IEC958 Playback Volume", 0x1b, 0x0, HDA_OUTPUT), + HDA_CODEC_VOLUME("HDMI Playback Volume", 0x1d, 0x0, HDA_OUTPUT), { } /* end */ }; @@ -2981,6 +2987,7 @@ static int patch_ad1988(struct hda_codec *codec) ad1989_spdif_out_mixers; spec->init_verbs[spec->num_init_verbs++] = ad1989_spdif_init_verbs; + codec->slave_dig_outs = ad1989b_slave_dig_outs; } else { spec->mixers[spec->num_mixers++] = ad1988_spdif_out_mixers; -- 1.6.0.1

1 0

[alsa-devel] [PATCH] ALSA: HDA: hda_proc: Fix printf format specifier
by robbat2＠gentoo.org 14 Sep '08

14 Sep '08

From: Robin H. Johnson <robbat2(a)gentoo.org> The Pincap output had a typod format specifier, leading to an extraneous "08" in the output, which is a reserved bit of the Vref field, and was really confused :-). Signed-off-by: Robin H. Johnson <robbat2(a)gentoo.org> diff --git a/sound/pci/hda/hda_proc.c b/sound/pci/hda/hda_proc.c index 4927c4b..743d779 100644 --- a/sound/pci/hda/hda_proc.c +++ b/sound/pci/hda/hda_proc.c @@ -216,7 +216,7 @@ static void print_pin_caps(struct snd_info_buffer *buffer, unsigned int caps, val; caps = snd_hda_param_read(codec, nid, AC_PAR_PIN_CAP); - snd_iprintf(buffer, " Pincap 0x08%x:", caps); + snd_iprintf(buffer, " Pincap 0x%08x:", caps); if (caps & AC_PINCAP_IN) snd_iprintf(buffer, " IN"); if (caps & AC_PINCAP_OUT) -- 1.6.0.1

1 0

[alsa-devel] [ALSA hda_codec 1/1] NULL pointer deference fixes for slave_dig_outs
by robbat2＠gentoo.org 13 Sep '08

13 Sep '08

From: Robin H. Johnson <robbat2(a)gentoo.org> The new multiple digital output code forgot to check the slave_dig_outs for NULL in several places. This manifests as an OOPS when changing volume amongst other things. Signed-off-by: Robin H. Johnson <robbat2(a)gentoo.org> diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index 696d77e..b22061b 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -1462,14 +1462,15 @@ static int snd_hda_spdif_default_put(struct snd_kcontrol *kcontrol, AC_VERB_SET_DIGI_CONVERT_2, val >> 8); - for (d = codec->slave_dig_outs; *d; d++) { - snd_hda_codec_write_cache(codec, *d, 0, - AC_VERB_SET_DIGI_CONVERT_1, - val & 0xff); - snd_hda_codec_write_cache(codec, *d, 0, - AC_VERB_SET_DIGI_CONVERT_2, - val >> 8); - } + if (codec->slave_dig_outs) + for (d = codec->slave_dig_outs; *d; d++) { + snd_hda_codec_write_cache(codec, *d, 0, + AC_VERB_SET_DIGI_CONVERT_1, + val & 0xff); + snd_hda_codec_write_cache(codec, *d, 0, + AC_VERB_SET_DIGI_CONVERT_2, + val >> 8); + } } mutex_unlock(&codec->spdif_mutex); @@ -1507,10 +1508,12 @@ static int snd_hda_spdif_out_switch_put(struct snd_kcontrol *kcontrol, AC_VERB_SET_DIGI_CONVERT_1, val & 0xff); - for (d = codec->slave_dig_outs; *d; d++) - snd_hda_codec_write_cache(codec, *d, 0, - AC_VERB_SET_DIGI_CONVERT_1, - val & 0xff); + if (codec->slave_dig_outs) + for (d = codec->slave_dig_outs; *d; d++) + snd_hda_codec_write_cache(codec, *d, 0, + AC_VERB_SET_DIGI_CONVERT_1, + val & 0xff); + /* unmute amp switch (if any) */ if ((get_wcaps(codec, nid) & AC_WCAP_OUT_AMP) && (val & AC_DIG1_ENABLE)) @@ -1664,9 +1667,10 @@ static int snd_hda_spdif_in_switch_put(struct snd_kcontrol *kcontrol, snd_hda_codec_write_cache(codec, nid, 0, AC_VERB_SET_DIGI_CONVERT_1, val); - for (d = codec->slave_dig_outs; *d; d++) - snd_hda_codec_write_cache(codec, *d, 0, - AC_VERB_SET_DIGI_CONVERT_1, val); + if (codec->slave_dig_outs) + for (d = codec->slave_dig_outs; *d; d++) + snd_hda_codec_write_cache(codec, *d, 0, + AC_VERB_SET_DIGI_CONVERT_1, val); } mutex_unlock(&codec->spdif_mutex); return change; @@ -2617,10 +2621,11 @@ static void setup_dig_out_stream(struct hda_codec *codec, hda_nid_t nid, snd_hda_codec_write(codec, nid, 0, AC_VERB_SET_DIGI_CONVERT_1, codec->spdif_ctls & ~AC_DIG1_ENABLE & 0xff); - for (d = codec->slave_dig_outs; *d; d++) - snd_hda_codec_write(codec, *d, 0, - AC_VERB_SET_DIGI_CONVERT_1, - codec->spdif_ctls & ~AC_DIG1_ENABLE & 0xff); + if (codec->slave_dig_outs) + for (d = codec->slave_dig_outs; *d; d++) + snd_hda_codec_write(codec, *d, 0, + AC_VERB_SET_DIGI_CONVERT_1, + codec->spdif_ctls & ~AC_DIG1_ENABLE & 0xff); } snd_hda_codec_setup_stream(codec, nid, stream_tag, 0, format); /* turn on again (if needed) */ @@ -2628,10 +2633,11 @@ static void setup_dig_out_stream(struct hda_codec *codec, hda_nid_t nid, snd_hda_codec_write(codec, nid, 0, AC_VERB_SET_DIGI_CONVERT_1, codec->spdif_ctls & 0xff); - for (d = codec->slave_dig_outs; *d; d++) - snd_hda_codec_write(codec, *d, 0, - AC_VERB_SET_DIGI_CONVERT_1, - codec->spdif_ctls & 0xff); + if (codec->slave_dig_outs) + for (d = codec->slave_dig_outs; *d; d++) + snd_hda_codec_write(codec, *d, 0, + AC_VERB_SET_DIGI_CONVERT_1, + codec->spdif_ctls & 0xff); } } -- 1.6.0.1

2 1

[alsa-devel] [PATCH] Fix oopses in snd-hda-intel from alsa v1.0.18rc3
by Herton Ronaldo Krzesinski 13 Sep '08

13 Sep '08

Fixes the following oopses and other likewise possible ones: BUG: unable to handle kernel NULL pointer dereference at 00000000 IP: [<f8cc5917>] :snd_hda_intel:snd_hda_spdif_out_switch_put+0x97/0x130 *pde = 00000000 Oops: 0000 [#1] SMP Modules linked in: snd_seq_dummy snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device ipv6 snd_pcm_oss snd_mixer_oss coretemp it87 hwmon_vid binfmt_misc loop nls_utf8 ntfs dm_mirror dm_log dm_mod floppy cpufreq_ondemand cpufreq_conservative cpufreq_powersave acpi_cpufreq freq_table snd_hda_intel snd_pcm ub ppdev snd_timer evdev snd_page_alloc r8169 snd_hwdep usbhid snd mii iTCO_wdt button thermal iTCO_vendor_support i2c_i801 processor parport_pc parport serio_raw i2c_core usb_storage intel_agp sr_mod rtc_cmos ff_memless agpgart soundcore sg ata_piix ahci libata dock sd_mod scsi_mod crc_t10dif raid456 async_xor async_memcpy async_tx xor raid0 ext3 jbd uhci_hcd ohci_hcd ehci_hcd usbcore [last unloaded: scsi_wait_scan] Pid: 3730, comm: alsactl Not tainted (2.6.27-desktop-0.rc6.2mnb #1) EIP: 0060:[<f8cc5917>] EFLAGS: 00010246 CPU: 3 EIP is at snd_hda_spdif_out_switch_put+0x97/0x130 [snd_hda_intel] EAX: 00000000 EBX: 00000000 ECX: 00000000 EDX: 00000003 ESI: f7b86200 EDI: 00000001 EBP: f6d8bd94 ESP: f6d8bd68 DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068 Process alsactl (pid: 3730, ti=f6d8a000 task=f731d6a0 task.ti=f6d8a000) Stack: 0000070d 00000001 00000000 00000001 00000006 f7b86380 00065a80 00000001 f6c35a80 f69d8c00 f8bd12d0 f6d8bda4 f8bd106a f6c35a80 f69d8c00 f6d8bdb4 f8bd1318 f69d8c00 f711da00 f6d8bf4c f8bcfa59 f6d8bf04 bf893e30 f6cdc8c0 Call Trace: [<f8bd12d0>] ? slave_put+0x0/0x60 [snd] [<f8bd106a>] ? slave_put_val+0x2a/0xa0 [snd] [<f8bd1318>] ? slave_put+0x48/0x60 [snd] [<f8bcfa59>] ? snd_ctl_ioctl+0xc99/0xe70 [snd] [<c01b0317>] ? dput+0x87/0x130 [<c0207e40>] ? ccs_capable+0x30/0x1f0 [<f8bcedc0>] ? snd_ctl_ioctl+0x0/0xe70 [snd] [<c01a928e>] ? vfs_ioctl+0x5e/0xa0 [<c01a4805>] ? putname+0x25/0x40 [<c01a932e>] ? do_vfs_ioctl+0x5e/0x2e0 [<c019a617>] ? do_sys_open+0xc7/0xf0 [<c01a9613>] ? sys_ioctl+0x63/0x70 [<c0103e1b>] ? sysenter_do_call+0x12/0x2f ======================= Code: b7 45 ee 0f b7 c9 0f b6 f9 89 4d e0 31 c9 89 7c 24 04 89 45 e4 89 c2 89 f0 c7 04 24 0d 07 00 00 e8 3f f7 ff ff 8b 9e 9c 01 00 00 <0f> b7 03 66 85 c0 74 23 90 0f b7 d0 31 c9 83 c3 02 89 f0 89 7c EIP: [<f8cc5917>] snd_hda_spdif_out_switch_put+0x97/0x130 [snd_hda_intel] SS:ESP 0068:f6d8bd68 ---[ end trace 1e63c3510a780bec ]--- BUG: unable to handle kernel NULL pointer dereference at 00000000 IP: [<f8cb07d5>] :snd_hda_intel:setup_dig_out_stream+0xf5/0x140 *pde = 00000000 Oops: 0000 [#1] SMP Modules linked in: nfs lockd nfs_acl sunrpc af_packet radeon drm snd_seq_dummy snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device ipv6 snd_pcm_oss snd_mixer_oss coretemp it87 hwmon_vid binfmt_misc loop nls_utf8 ntfs dm_mirror dm_log dm_mod floppy cpufreq_ondemand cpufreq_conservative cpufreq_powersave acpi_cpufreq freq_table ppdev evdev snd_hda_intel thermal snd_pcm snd_timer r8169 snd_page_alloc ub snd_hwdep intel_agp mii snd i2c_i801 button usbhid parport_pc agpgart i2c_core parport serio_raw processor soundcore iTCO_wdt rtc_cmos ff_memless iTCO_vendor_support sr_mod usb_storage sg ata_piix ahci libata dock sd_mod scsi_mod crc_t10dif raid456 async_xor async_memcpy async_tx xor raid0 ext3 jbd uhci_hcd ohci_hcd ehci_hcd usbcore [last unloaded: scsi_wait_scan] Pid: 5139, comm: artsd Not tainted (2.6.27-desktop-0.rc6.2mnb #1) EIP: 0060:[<f8cb07d5>] EFLAGS: 00210202 CPU: 2 EIP is at setup_dig_out_stream+0xf5/0x140 [snd_hda_intel] EAX: 00000000 EBX: 00000000 ECX: 00000000 EDX: 00000003 ESI: f6d54600 EDI: 00000006 EBP: f5afbcd8 ESP: f5afbcc0 DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068 Process artsd (pid: 5139, ti=f5afa000 task=f6b50000 task.ti=f5afa000) Stack: 0000070d 00000000 00000005 00000031 f7022050 f6d54600 f5afbd04 f8cb0a8d 00000031 0000e008 00000005 f6d54780 f8ceb39c 00000002 00000031 f6d55500 f5afbd60 f5afbd18 f8cba051 00000031 f7066d00 f7066d00 f5afbd70 f8cae925 Call Trace: [<f8cb0a8d>] ? snd_hda_multi_out_analog_prepare+0x1fd/0x240 [snd_hda_intel] [<f8cba051>] ? alc880_playback_pcm_prepare+0x21/0x30 [snd_hda_intel] [<f8cae925>] ? azx_pcm_prepare+0x345/0x3c0 [snd_hda_intel] [<f8c17d5c>] ? snd_pcm_do_prepare+0xc/0x20 [snd_pcm] [<f8c178ab>] ? snd_pcm_action_single+0x2b/0x60 [snd_pcm] [<f8c18a8b>] ? snd_pcm_action_nonatomic+0x6b/0x70 [snd_pcm] [<f8c1b437>] ? snd_pcm_common_ioctl1+0x607/0x1720 [snd_pcm] [<c0182f6f>] ? handle_mm_fault+0x11f/0x7e0 [<c012a0c0>] ? default_wake_function+0x0/0x10 [<c03820f8>] ? unlock_kernel+0x28/0x2f [<f8bc8688>] ? snd_open+0xd8/0x150 [snd] [<c011cef0>] ? do_page_fault+0x330/0x870 [<c017d7a2>] ? vma_prio_tree_insert+0x22/0xc0 [<c0185f89>] ? vma_link+0xa9/0xf0 [<f8c1c988>] ? snd_pcm_playback_ioctl1+0x38/0x3e0 [snd_pcm] [<c018699e>] ? mmap_region+0x2be/0x4b0 [<c0207e40>] ? ccs_capable+0x30/0x1f0 [<f8c1cd76>] ? snd_pcm_playback_ioctl+0x46/0x50 [snd_pcm] [<f8c1cd30>] ? snd_pcm_playback_ioctl+0x0/0x50 [snd_pcm] [<c01a928e>] ? vfs_ioctl+0x5e/0xa0 [<c01a932e>] ? do_vfs_ioctl+0x5e/0x2e0 [<c01a9613>] ? sys_ioctl+0x63/0x70 [<c0103e1b>] ? sysenter_do_call+0x12/0x2f [<c0380000>] ? schedule+0x760/0x940 ======================= Code: b4 26 00 00 00 00 81 e2 fe 00 00 00 0f b7 f8 89 54 24 04 31 c9 89 fa 89 f0 c7 04 24 0d 07 00 00 e8 91 eb ff ff 8b 9e 9c 01 00 00 <0f> b7 03 66 85 c0 0f 84 2e ff ff ff 8d b4 26 00 00 00 00 0f b7 EIP: [<f8cb07d5>] setup_dig_out_stream+0xf5/0x140 [snd_hda_intel] SS:ESP 0068:f5afbcc0 ---[ end trace d44a3a67f9b19615 ]--- --- Signed-off-by: Herton Ronaldo Krzesinski <herton(a)mandriva.com.br> diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index 696d77e..531364d 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -1462,14 +1462,15 @@ static int snd_hda_spdif_default_put(struct snd_kcontrol *kcontrol, AC_VERB_SET_DIGI_CONVERT_2, val >> 8); - for (d = codec->slave_dig_outs; *d; d++) { - snd_hda_codec_write_cache(codec, *d, 0, + if (codec->slave_dig_outs) + for (d = codec->slave_dig_outs; *d; d++) { + snd_hda_codec_write_cache(codec, *d, 0, AC_VERB_SET_DIGI_CONVERT_1, val & 0xff); - snd_hda_codec_write_cache(codec, *d, 0, + snd_hda_codec_write_cache(codec, *d, 0, AC_VERB_SET_DIGI_CONVERT_2, val >> 8); - } + } } mutex_unlock(&codec->spdif_mutex); @@ -1507,8 +1508,9 @@ static int snd_hda_spdif_out_switch_put(struct snd_kcontrol *kcontrol, AC_VERB_SET_DIGI_CONVERT_1, val & 0xff); - for (d = codec->slave_dig_outs; *d; d++) - snd_hda_codec_write_cache(codec, *d, 0, + if (codec->slave_dig_outs) + for (d = codec->slave_dig_outs; *d; d++) + snd_hda_codec_write_cache(codec, *d, 0, AC_VERB_SET_DIGI_CONVERT_1, val & 0xff); /* unmute amp switch (if any) */ @@ -1664,8 +1666,9 @@ static int snd_hda_spdif_in_switch_put(struct snd_kcontrol *kcontrol, snd_hda_codec_write_cache(codec, nid, 0, AC_VERB_SET_DIGI_CONVERT_1, val); - for (d = codec->slave_dig_outs; *d; d++) - snd_hda_codec_write_cache(codec, *d, 0, + if (codec->slave_dig_outs) + for (d = codec->slave_dig_outs; *d; d++) + snd_hda_codec_write_cache(codec, *d, 0, AC_VERB_SET_DIGI_CONVERT_1, val); } mutex_unlock(&codec->spdif_mutex); @@ -2617,9 +2620,10 @@ static void setup_dig_out_stream(struct hda_codec *codec, hda_nid_t nid, snd_hda_codec_write(codec, nid, 0, AC_VERB_SET_DIGI_CONVERT_1, codec->spdif_ctls & ~AC_DIG1_ENABLE & 0xff); - for (d = codec->slave_dig_outs; *d; d++) - snd_hda_codec_write(codec, *d, 0, - AC_VERB_SET_DIGI_CONVERT_1, + if (codec->slave_dig_outs) + for (d = codec->slave_dig_outs; *d; d++) + snd_hda_codec_write(codec, *d, 0, + AC_VERB_SET_DIGI_CONVERT_1, codec->spdif_ctls & ~AC_DIG1_ENABLE & 0xff); } snd_hda_codec_setup_stream(codec, nid, stream_tag, 0, format); @@ -2628,9 +2632,10 @@ static void setup_dig_out_stream(struct hda_codec *codec, hda_nid_t nid, snd_hda_codec_write(codec, nid, 0, AC_VERB_SET_DIGI_CONVERT_1, codec->spdif_ctls & 0xff); - for (d = codec->slave_dig_outs; *d; d++) - snd_hda_codec_write(codec, *d, 0, - AC_VERB_SET_DIGI_CONVERT_1, + if (codec->slave_dig_outs) + for (d = codec->slave_dig_outs; *d; d++) + snd_hda_codec_write(codec, *d, 0, + AC_VERB_SET_DIGI_CONVERT_1, codec->spdif_ctls & 0xff); } -- []'s Herton

2 2

[alsa-devel] [PATCH] hda: fixed hp_nid DAC for DELL_M6
by Matthew Ranostay 13 Sep '08

13 Sep '08

This patch sets the HP out not used by the "Headphone to Line Out" switch to the hp_nid. Signed-off-by: Matthew Ranostay <mranostay(a)embeddedalley.com> --- diff --git a/pci/hda/patch_sigmatel.c b/pci/hda/patch_sigmatel.c index f41ba17..0218aa7 100644 --- a/pci/hda/patch_sigmatel.c +++ b/pci/hda/patch_sigmatel.c @@ -747,8 +747,8 @@ static struct hda_verb dell_m6_core_init[] = { { 0x1f, AC_VERB_SET_VOLUME_KNOB_CONTROL, 0xec}, /* setup audio connections */ { 0x0d, AC_VERB_SET_CONNECT_SEL, 0x00}, - { 0x0a, AC_VERB_SET_CONNECT_SEL, 0x01}, - { 0x0f, AC_VERB_SET_CONNECT_SEL, 0x02}, + { 0x0a, AC_VERB_SET_CONNECT_SEL, 0x02}, + { 0x0f, AC_VERB_SET_CONNECT_SEL, 0x01}, /* setup adcs to point to mixer */ { 0x20, AC_VERB_SET_CONNECT_SEL, 0x0b}, { 0x21, AC_VERB_SET_CONNECT_SEL, 0x0b},

2 1

[alsa-devel] [PATCH] hda: Added a STAC_HP_M4 quirk
by Matthew Ranostay 13 Sep '08

13 Sep '08

Added a new quirk for STAC_HP_M4 series for an 92hd75xxx family laptop. Signed-off-by: Matthew Ranostay <mranostay(a)embeddedalley.com> --- diff --git a/pci/hda/patch_sigmatel.c b/pci/hda/patch_sigmatel.c index f00334f..3000ecf 100644 --- a/pci/hda/patch_sigmatel.c +++ b/pci/hda/patch_sigmatel.c @@ -80,6 +80,7 @@ enum { STAC_92HD71BXX_REF, STAC_DELL_M4_1, STAC_DELL_M4_2, + STAC_HP_M4, STAC_92HD71BXX_MODELS }; @@ -1527,12 +1528,14 @@ static unsigned int *stac92hd71bxx_brd_tbl[STAC_92HD71BXX_MODELS] = { [STAC_92HD71BXX_REF] = ref92hd71bxx_pin_configs, [STAC_DELL_M4_1] = dell_m4_1_pin_configs, [STAC_DELL_M4_2] = dell_m4_2_pin_configs, + [STAC_HP_M4] = NULL, }; static const char *stac92hd71bxx_models[STAC_92HD71BXX_MODELS] = { [STAC_92HD71BXX_REF] = "ref", [STAC_DELL_M4_1] = "dell-m4-1", [STAC_DELL_M4_2] = "dell-m4-2", + [STAC_HP_M4] = "hp-m4", }; static struct snd_pci_quirk stac92hd71bxx_cfg_tbl[] = { @@ -4204,10 +4207,24 @@ again: spec->num_muxes = ARRAY_SIZE(stac92hd71bxx_mux_nids); spec->num_adcs = ARRAY_SIZE(stac92hd71bxx_adc_nids); - spec->num_dmics = STAC92HD71BXX_NUM_DMICS; - spec->num_smuxes = ARRAY_SIZE(stac92hd71bxx_smux_nids); spec->num_dmuxes = ARRAY_SIZE(stac92hd71bxx_dmux_nids); + switch (spec->board_config) { + case STAC_HP_M4: + spec->num_dmics = 0; + spec->num_smuxes = 1; + spec->num_dmuxes = 0; + + /* enable internal microphone */ + snd_hda_codec_write_cache(codec, 0x0e, 0, + AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_VREF80); + break; + default: + spec->num_dmics = STAC92HD71BXX_NUM_DMICS; + spec->num_smuxes = ARRAY_SIZE(stac92hd71bxx_smux_nids); + spec->num_dmuxes = ARRAY_SIZE(stac92hd71bxx_dmux_nids); + }; + spec->multiout.num_dacs = 1; spec->multiout.hp_nid = 0x11; spec->multiout.dac_nids = stac92hd71bxx_dac_nids;

2 1