July 2024 - Alsa-devel - mailman.alsa-project.org

[bug report] ASoC: Intel: cht_bsw_rt5645: Set card.components string
by Dan Carpenter 23 Jul '24

23 Jul '24

Hello Hans de Goede, Commit f87b4402163b ("ASoC: Intel: cht_bsw_rt5645: Set card.components string") from Nov 26, 2023 (linux-next), leads to the following Smatch static checker warning: sound/soc/intel/boards/cht_bsw_rt5645.c:587 snd_cht_mc_probe() error: we previously assumed 'adev' could be null (see line 581) sound/soc/intel/boards/cht_bsw_rt5645.c 570 /* set correct codec name */ 571 for (i = 0; i < ARRAY_SIZE(cht_dailink); i++) 572 if (cht_dailink[i].codecs->name && 573 !strcmp(cht_dailink[i].codecs->name, 574 "i2c-10EC5645:00")) { 575 dai_index = i; 576 break; 577 } 578 579 /* fixup codec name based on HID */ 580 adev = acpi_dev_get_first_match_dev(mach->id, NULL, -1); 581 if (adev) { ^^^^ The old code assumes adev can be NULL 582 snprintf(cht_rt5645_codec_name, sizeof(cht_rt5645_codec_name), 583 "i2c-%s", acpi_dev_name(adev)); 584 cht_dailink[dai_index].codecs->name = cht_rt5645_codec_name; 585 } 586 /* acpi_get_first_physical_node() returns a borrowed ref, no need to deref */ --> 587 codec_dev = acpi_get_first_physical_node(adev); ^^^^ Unchecked dereference 588 acpi_dev_put(adev); 589 if (!codec_dev) 590 return -EPROBE_DEFER; 591 592 snd_soc_card_chtrt5645.components = rt5645_components(codec_dev); 593 snd_soc_card_chtrt5650.components = rt5645_components(codec_dev); 594 regards, dan carpenter

2 2

[PATCH for-6.10 0/2] ASoC: cs35l56: Set correct upper volume limit
by Richard Fitzgerald 23 Jul '24

23 Jul '24

Patch series to limit the upper range of the CS35L56 volume control to +12 dB. These commits were not marked 'Fixes' because they were thought to be only a cosmetic issue. The user could reduce the volume to a usable value. But for some complex audio topologies with SOF Audio DSP + CS42L43 + multiple CS35L56 it has turned out to be not obvious to the user what the problem actually is and what to do to fix it. As support for these topologies went into 6.10 we would like this series to be applied to 6.10. Richard Fitzgerald (2): ASoC: cs35l56: Use header defines for Speaker Volume control definition ASoC: cs35l56: Limit Speaker Volume to +12dB maximum include/sound/cs35l56.h | 2 +- sound/soc/codecs/cs35l56.c | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) -- 2.39.2

2 3

[PATCH 0/4] MSM8953/MSM8976 ASoC support
by Adam Skladowski 23 Jul '24

23 Jul '24

Introduce support for basic sound card setup on MSM8953/MSM8976 platforms, document new compatibles and introduce support for more dais. Most of code is sourced from msm8953-mainline fork over github with some changes implemented by me,some basic changes are mentioned in each patch. Adam Skladowski (1): ASoC: dt-bindings: qcom,sm8250: Add msm8953/msm8976-qdsp6-sndcard Vladimir Lypak (3): ASoC: qcom: apq8016_sbc.c: Add Quinary support ASoC: msm8916-wcd-analog: add cajon and cajon v2 support ASoC: qcom: apq8016_sbc: Add support for msm8953/msm8976 SoC .../bindings/sound/qcom,sm8250.yaml | 28 ++++++- sound/soc/codecs/msm8916-wcd-analog.c | 63 +++++++++++++- sound/soc/qcom/apq8016_sbc.c | 82 ++++++++++++++++++- 3 files changed, 164 insertions(+), 9 deletions(-) -- 2.45.2

4 8

[RFC 00/xx] ALSA: ALSA: add snd_stream_is_playback/capture()
by Kuninori Morimoto 23 Jul '24

23 Jul '24

Hi Iwai-san, Mark Current many drivers are using below code to know its direction. if (direction == SNDRV_PCM_STREAM_PLAYBACK) I think it should be handled by function. But is it acceptable idea ? Because it will be too many patch-set, I want to know it was acceptable idea or not before posting patch-bomb. I will post main patch, and sample driver patches. Thank you for your help !! Best regards --- Kuninori Morimoto

5 17

[PATCH] ASoc: TAS2781: Fix tasdev_load_calibrated_data()
by Dan Carpenter 22 Jul '24

22 Jul '24

This function has a reversed if statement so it's either a no-op or it leads to a NULL dereference. Fixes: b195acf5266d ("ASoC: tas2781: Fix wrong loading calibrated data sequence") Signed-off-by: Dan Carpenter <dan.carpenter(a)linaro.org> --- sound/soc/codecs/tas2781-fmwlib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/tas2781-fmwlib.c b/sound/soc/codecs/tas2781-fmwlib.c index 63626b982d04..8f9a3ae7153e 100644 --- a/sound/soc/codecs/tas2781-fmwlib.c +++ b/sound/soc/codecs/tas2781-fmwlib.c @@ -2162,7 +2162,7 @@ static void tasdev_load_calibrated_data(struct tasdevice_priv *priv, int i) return; cal = cal_fmw->calibrations; - if (cal) + if (!cal) return; load_calib_data(priv, &cal->dev_data); -- 2.43.0

2 1

[PATCH] ASoC: Intel: use soc_intel_is_byt_cr() only when IOSF_MBI is reachable
by Pierre-Louis Bossart 22 Jul '24

22 Jul '24

the Intel kbuild bot reports a link failure when IOSF_MBI is built-in but the Merrifield driver is configured as a module. The soc-intel-quirks.h is included for Merrifield platforms, but IOSF_MBI is not selected for that platform. ld.lld: error: undefined symbol: iosf_mbi_read >>> referenced by atom.c >>> sound/soc/sof/intel/atom.o:(atom_machine_select) in archive vmlinux.a This patch forces the use of the fallback static inline when IOSF_MBI is not reachable. Fixes: 536cfd2f375d ("ASoC: Intel: use common helpers to detect CPUs") Reported-by: kernel test robot <lkp(a)intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202407160704.zpdhJ8da-lkp@intel.com/ Suggested-by: Takashi Iwai <tiwai(a)suse.de> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reviewed-by: Péter Ujfalusi <peter.ujfalusi(a)linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> --- sound/soc/intel/common/soc-intel-quirks.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/common/soc-intel-quirks.h b/sound/soc/intel/common/soc-intel-quirks.h index de4e550c5b34..42bd51456b94 100644 --- a/sound/soc/intel/common/soc-intel-quirks.h +++ b/sound/soc/intel/common/soc-intel-quirks.h @@ -11,7 +11,7 @@ #include <linux/platform_data/x86/soc.h> -#if IS_ENABLED(CONFIG_X86) +#if IS_REACHABLE(CONFIG_IOSF_MBI) #include <linux/dmi.h> #include <asm/iosf_mbi.h> -- 2.43.0

2 1

[PATCH alsa-utils 00/10] Cleanup seq/* stuff and extend aseqsend
by Takashi Iwai 22 Jul '24

22 Jul '24

Hi, this is a series of cleanup / fix patches for alsa-utils/seq/* stuff, including the extension of aseqsend to support UMP packet bytes. Takashi === Takashi Iwai (10): configure: Requires the latest ALSA-lib release 1.2.12 aplaymidi: Drop ifdef for UMP support aplaymidi: Allow to pass 0 to -u option, too aconnect: Drop superfluous ifdefs aseqdump: Drop ifdef for UMP support aseqdump: Check the -u option value properly configure: Drop unused conditionals aseqdump: Show SysEx prefix to UMP SysEx data dump aseqsend: Support UMP mode aseqsend: Support long options configure.ac | 13 +------- seq/aconnect/aconnect.c | 31 ------------------ seq/aplaymidi/aplaymidi.c | 32 +++--------------- seq/aseqdump/aseqdump.c | 25 +++----------- seq/aseqsend/aseqsend.1 | 69 +++++++++++++++++++++------------------ seq/aseqsend/aseqsend.c | 54 +++++++++++++++++++++++++++++- 6 files changed, 100 insertions(+), 124 deletions(-) -- 2.43.0

1 10

[PATCH v3] ALSA: usb-audio: Add a quirk for Sonix HD USB Camera
by wangdicheng 22 Jul '24

22 Jul '24

From: wangdicheng <wangdicheng(a)kylinos.cn> Sonix HD USB Camera does not support reading the sample rate which leads to many lines of "cannot get freq at ep 0x84". This patch adds the USB ID to quirks.c and avoids those error messages. (snip) [1.789698] usb 3-3: new high-speed USB device number 2 using xhci_hcd [1.984121] usb 3-3: New USB device found, idVendor=0c45, idProduct=6340, bcdDevice= 0.00 [1.984124] usb 3-3: New USB device strings: Mfr=2, Product=1, SerialNumber=0 [1.984127] usb 3-3: Product: USB 2.0 Camera [1.984128] usb 3-3: Manufacturer: Sonix Technology Co., Ltd. [5.440957] usb 3-3: 3:1: cannot get freq at ep 0x84 [12.130679] usb 3-3: 3:1: cannot get freq at ep 0x84 [12.175065] usb 3-3: 3:1: cannot get freq at ep 0x84 Signed-off-by: wangdicheng <wangdicheng(a)kylinos.cn> --- v2 -> v3: Update the insertion order of ID 0c45 v1 -> v2: Arrange the ID in order --- sound/usb/quirks.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index 58156fbca02c..b42654033c33 100644 --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -2125,6 +2125,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = { QUIRK_FLAG_CTL_MSG_DELAY_1M), DEVICE_FLG(0x0b0e, 0x0349, /* Jabra 550a */ QUIRK_FLAG_CTL_MSG_DELAY_1M), + DEVICE_FLG(0x0c45, 0x6340, /* Sonix HD USB Camera */ + QUIRK_FLAG_GET_SAMPLE_RATE), DEVICE_FLG(0x0ecb, 0x205c, /* JBL Quantum610 Wireless */ QUIRK_FLAG_FIXED_RATE), DEVICE_FLG(0x0ecb, 0x2069, /* JBL Quantum810 Wireless */ -- 2.25.1

1 0

[PATCH] ASoC: sti: add missing probe entry for player and reader
by Jerome Audu 22 Jul '24

22 Jul '24

Restores the audio functionality that was broken since Linux version 6.6.y by adding the missing probe functions for the player and reader components. Fixes: 9f625f5e6cf9 ("ASoC: sti: merge DAI call back functions into ops") Signed-off-by: Jerome Audu <jau(a)free.fr> --- Specifically, the probe function in `sound/soc/sti/sti_uniperif.c:415` is being replaced by another probe function located at `sound/soc/sti/sti_uniperif.c:453`, which should instead be derived from the player and reader components. My patch correctly reinserts the missing probe entries, restoring the intended functionality. The patch modifies the following files: - `sound/soc/sti/sti_uniperif.c`: Changes the visibility of `sti_uniperiph_dai_probe` to non-static. - `sound/soc/sti/uniperif.h`: Adds the declaration of `sti_uniperiph_dai_probe`. - `sound/soc/sti/uniperif_player.c`: Adds `probe` function to `uni_player_dai_ops`. - `sound/soc/sti/uniperif_reader.c`: Adds `probe` function to `uni_reader_dai_ops`. This ensures the correct `probe` functions are utilized, thus fixing the audio regression. --- sound/soc/sti/sti_uniperif.c | 2 +- sound/soc/sti/uniperif.h | 1 + sound/soc/sti/uniperif_player.c | 1 + sound/soc/sti/uniperif_reader.c | 1 + 4 files changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/sti/sti_uniperif.c b/sound/soc/sti/sti_uniperif.c index ba824f14a39c..a7956e5a4ee5 100644 --- a/sound/soc/sti/sti_uniperif.c +++ b/sound/soc/sti/sti_uniperif.c @@ -352,7 +352,7 @@ static int sti_uniperiph_resume(struct snd_soc_component *component) return ret; } -static int sti_uniperiph_dai_probe(struct snd_soc_dai *dai) +int sti_uniperiph_dai_probe(struct snd_soc_dai *dai) { struct sti_uniperiph_data *priv = snd_soc_dai_get_drvdata(dai); struct sti_uniperiph_dai *dai_data = &priv->dai_data; diff --git a/sound/soc/sti/uniperif.h b/sound/soc/sti/uniperif.h index 2a5de328501c..74e51f0ff85c 100644 --- a/sound/soc/sti/uniperif.h +++ b/sound/soc/sti/uniperif.h @@ -1380,6 +1380,7 @@ int uni_reader_init(struct platform_device *pdev, struct uniperif *reader); /* common */ +int sti_uniperiph_dai_probe(struct snd_soc_dai *dai); int sti_uniperiph_dai_set_fmt(struct snd_soc_dai *dai, unsigned int fmt); diff --git a/sound/soc/sti/uniperif_player.c b/sound/soc/sti/uniperif_player.c index dd9013c47664..6d1ce030963c 100644 --- a/sound/soc/sti/uniperif_player.c +++ b/sound/soc/sti/uniperif_player.c @@ -1038,6 +1038,7 @@ static const struct snd_soc_dai_ops uni_player_dai_ops = { .startup = uni_player_startup, .shutdown = uni_player_shutdown, .prepare = uni_player_prepare, + .probe = sti_uniperiph_dai_probe, .trigger = uni_player_trigger, .hw_params = sti_uniperiph_dai_hw_params, .set_fmt = sti_uniperiph_dai_set_fmt, diff --git a/sound/soc/sti/uniperif_reader.c b/sound/soc/sti/uniperif_reader.c index 065c5f0d1f5f..05ea2b794eb9 100644 --- a/sound/soc/sti/uniperif_reader.c +++ b/sound/soc/sti/uniperif_reader.c @@ -401,6 +401,7 @@ static const struct snd_soc_dai_ops uni_reader_dai_ops = { .startup = uni_reader_startup, .shutdown = uni_reader_shutdown, .prepare = uni_reader_prepare, + .probe = sti_uniperiph_dai_probe, .trigger = uni_reader_trigger, .hw_params = sti_uniperiph_dai_hw_params, .set_fmt = sti_uniperiph_dai_set_fmt, --- base-commit: 0c3836482481200ead7b416ca80c68a29cfdaabd change-id: 20240721-sti-audio-fix-1374fffb24e7 Best regards, -- Jerome Audu <jau(a)free.fr>

1 0

[PATCH v2] ALSA: usb-audio: Add a quirk for Sonix HD USB Camera
by wangdicheng 22 Jul '24

22 Jul '24

From: wangdicheng <wangdicheng(a)kylinos.cn> Sonix HD USB Camera does not support reading the sample rate which leads to many lines of "cannot get freq at ep 0x84". This patch adds the USB ID to quirks.c and avoids those error messages. (snip) [1.789698] usb 3-3: new high-speed USB device number 2 using xhci_hcd [1.984121] usb 3-3: New USB device found, idVendor=0c45, idProduct=6340, bcdDevice= 0.00 [1.984124] usb 3-3: New USB device strings: Mfr=2, Product=1, SerialNumber=0 [1.984127] usb 3-3: Product: USB 2.0 Camera [1.984128] usb 3-3: Manufacturer: Sonix Technology Co., Ltd. [5.440957] usb 3-3: 3:1: cannot get freq at ep 0x84 [12.130679] usb 3-3: 3:1: cannot get freq at ep 0x84 [12.175065] usb 3-3: 3:1: cannot get freq at ep 0x84 Signed-off-by: wangdicheng <wangdicheng(a)kylinos.cn> --- v1 -> v2: Arrange the ID in order --- sound/usb/quirks.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index 58156fbca02c..54b2d2f314ac 100644 --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -2225,6 +2225,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = { QUIRK_FLAG_ALIGN_TRANSFER), DEVICE_FLG(0x534d, 0x2109, /* MacroSilicon MS2109 */ QUIRK_FLAG_ALIGN_TRANSFER), + DEVICE_FLG(0x0c45, 0x6340, /* Sonix HD USB Camera */ + QUIRK_FLAG_GET_SAMPLE_RATE), /* Vendor matches */ VENDOR_FLG(0x045e, /* MS Lifecam */ -- 2.25.1

1 0