April 2024 - Alsa-devel - mailman.alsa-project.org

ucm2: soundwire: add rt722 SDCA device
by GitHub pull_request - opened 15 Apr '24

15 Apr '24

alsa-project/alsa-ucm-conf pull request #409 was opened from jack-cy-yu: Add support of ucm to rt722 SDCA. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/409 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/409.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH 1/3] ASoC: dt-bindings: nau8821: Add delay control for ADC
by Seven Lee 15 Apr '24

15 Apr '24

Change the original fixed delay to the assignment from the property. It will make it more flexible to different platforms to avoid pop noise at the beginning of recording. Signed-off-by: Seven Lee <wtli(a)nuvoton.com> --- .../devicetree/bindings/sound/nuvoton,nau8821.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml index 054b53954ac3..a726c5a9b067 100644 --- a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml @@ -103,6 +103,13 @@ properties: just limited to the left adc for design demand. type: boolean + nuvoton,adc-delay-ms: + description: Delay (in ms) to make input path stable and avoid pop noise. + The default value is 125 and range between 125 to 500 ms. + minimum: 125 + maximum: 500 + default: 125 + '#sound-dai-cells': const: 0 @@ -136,6 +143,7 @@ examples: nuvoton,jack-eject-debounce = <0>; nuvoton,dmic-clk-threshold = <3072000>; nuvoton,dmic-slew-rate = <0>; + nuvoton,nuvoton,adc-delay-ms = <125>; #sound-dai-cells = <0>; }; }; -- 2.25.1

3 5

[PATCH] ASoC: dt-bindings: renesas: add R8A779H0 V4M
by Kuninori Morimoto 15 Apr '24

15 Apr '24

Add document for R-Car V4M (R8A779H0). Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- Documentation/devicetree/bindings/sound/renesas,rsnd.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml index 996a13f21b63..b3da278cf141 100644 --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml @@ -49,6 +49,7 @@ properties: # for Gen4 SoC - items: - const: renesas,rcar_sound-r8a779g0 # R-Car V4H + - const: renesas,rcar_sound-r8a779h0 # R-Car V4M - const: renesas,rcar_sound-gen4 # for Generic - enum: -- 2.25.1

2 1

[PATCH] ASoC: dt-bindings: renesas,rsnd: add missing renesas,rcar_sound-gen4
by Kuninori Morimoto 15 Apr '24

15 Apr '24

It is missing generic compatible for R-Car Gen4 Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- Documentation/devicetree/bindings/sound/renesas,rsnd.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml index 0d7a6b576d88..996a13f21b63 100644 --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml @@ -55,6 +55,7 @@ properties: - renesas,rcar_sound-gen1 - renesas,rcar_sound-gen2 - renesas,rcar_sound-gen3 + - renesas,rcar_sound-gen4 reg: minItems: 1 -- 2.25.1

2 1

[PATCH 00/12] ASoC: Intel: updates for 6.10 - part4
by Pierre-Louis Bossart 15 Apr '24

15 Apr '24

More cleanups from Brent, notably the removal of the redundant cml_rt1011_rt5682 machine driver, fixes for SoundWire platforms and changes to sof_rt5682 to allow for 96+ sampling rates. For the rest of this kernel cycle, we are still working on SoundWire updates for MeteorLake (usual missing ACPI signature required for topology selection and jack detection information). We'll provide those patches as soon as they are reviewed/validated. Bard Liao (2): ASoC: Intel: sof_sdw: add missing sof_sdw_rt_amp_init for Realtek multi-function codecs ASoC: Intel: sof_rt5682: use RT5682S_PLL1 if needed Brent Lu (6): ASoC: Intel: sof_da7219: mach cleanup for adl boards ASoC: Intel: sof_da7219: mach cleanup for rpl boards ASoC: Intel: sof_da7219: add mtl_da7219_def for mtl boards ASoC: Intel: sof_realtek_common: support 4xALC1011 amplifier ASoC: Intel: sof_rt5682: support ALC1011 on cml boards ASoC: Intel: cml_rt1011_rt5682: delete driver Pierre-Louis Bossart (4): ASoC: Intel: soc-acpi: add support for HP Omen14 SoundWire configuration ASoC: Intel: sof_sdw: add JD2 quirk for HP Omen 14 ASoC: Intel: sof_sdw: add quirk for Dell SKU 0C0F ASoC: Intel: sof_sdw: remove FOUR_SPEAKER quirks sound/soc/intel/boards/Kconfig | 12 +- sound/soc/intel/boards/Makefile | 2 - sound/soc/intel/boards/cml_rt1011_rt5682.c | 609 ------------------ sound/soc/intel/boards/sof_da7219.c | 8 + sound/soc/intel/boards/sof_realtek_common.c | 178 ++++- sound/soc/intel/boards/sof_realtek_common.h | 4 +- sound/soc/intel/boards/sof_rt5682.c | 37 +- sound/soc/intel/boards/sof_sdw.c | 87 ++- sound/soc/intel/boards/sof_sdw_common.h | 1 + .../intel/common/soc-acpi-intel-adl-match.c | 19 +- .../intel/common/soc-acpi-intel-cml-match.c | 2 +- .../intel/common/soc-acpi-intel-mtl-match.c | 36 ++ .../intel/common/soc-acpi-intel-rpl-match.c | 19 +- 13 files changed, 297 insertions(+), 717 deletions(-) delete mode 100644 sound/soc/intel/boards/cml_rt1011_rt5682.c -- 2.40.1

2 13

weird behaviour with alsactl restore under pipewire
by GitHub issues - edited 14 Apr '24

14 Apr '24

alsa-project/alsa-utils issue #263 was edited from lucasreis1: So I'm at the point where I need to manually disable auto-mute after every reboot on my card. I've tried storing info using `alsactl store` and enabling `alsa-restore.service`, but I get errors when calling restore after boot (either manually or via the systemd service): ```sh Found hardware: "HDA-Intel" "ATI R6xx HDMI" "HDA:1002aa01,00aa0100,00100700" "0x1043" "0x8809" Hardware is initialized using a generic method alsactl: set_control:1339: failed to obtain info for control #1 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #2 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #3 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #4 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #5 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #6 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #7 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #8 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #9 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #10 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #11 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #12 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #13 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #14 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #15 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #16 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #17 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #18 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #19 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #20 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #21 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #22 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #23 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #24 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #25 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #26 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #27 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #28 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #33 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #34 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #35 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #36 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #37 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #38 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #39 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #40 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #41 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #42 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #43 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #44 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #45 (No such file or directory) Found hardware: "HDA-Intel" "Realtek ALC897" "HDA:10ec0897,104387fb,00100402" "0x1043" "0x87fb" Hardware is initialized using a generic method alsactl: set_control:1339: failed to obtain info for control #1 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #6 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #7 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #8 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #9 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #10 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #11 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #12 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #13 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #14 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #15 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #16 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #17 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #18 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #19 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #20 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #21 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #22 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #23 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #24 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #25 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #26 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #27 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #28 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #29 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #30 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #31 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #32 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #33 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #34 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #35 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #36 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #37 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #38 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #39 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #40 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #41 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #42 (No such file or directory) ``` If I store configs again via `alsactl store` and restore them using `alsactl restore`, everything works, but the issue returns after another reboot. Here's the output of `alsa-info.sh` if it helps: [alsa-info.txt](https://github.com/alsa-project/alsa-utils/files/14971854/al… Note that this only happens with my speakers, I have headphonse connected which work fine and are not auto-muted after every boot. Issue URL : https://github.com/alsa-project/alsa-utils/issues/263 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

weird behaviour with alsactl restore under pipewire
by GitHub issues - opened 14 Apr '24

14 Apr '24

alsa-project/alsa-utils issue #263 was opened from lucasreis1: So I'm at the point where I need to manually disable auto-mute after every reboot on my card. I've tried storing info using `alsactl store` and enabling `alsa-restore.service`, but I get errors when calling restore after boot (either manually or via the systemd service): ```sh Found hardware: "HDA-Intel" "ATI R6xx HDMI" "HDA:1002aa01,00aa0100,00100700" "0x1043" "0x8809" Hardware is initialized using a generic method alsactl: set_control:1339: failed to obtain info for control #1 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #2 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #3 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #4 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #5 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #6 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #7 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #8 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #9 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #10 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #11 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #12 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #13 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #14 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #15 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #16 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #17 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #18 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #19 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #20 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #21 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #22 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #23 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #24 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #25 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #26 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #27 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #28 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #33 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #34 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #35 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #36 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #37 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #38 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #39 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #40 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #41 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #42 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #43 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #44 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #45 (No such file or directory) Found hardware: "HDA-Intel" "Realtek ALC897" "HDA:10ec0897,104387fb,00100402" "0x1043" "0x87fb" Hardware is initialized using a generic method alsactl: set_control:1339: failed to obtain info for control #1 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #6 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #7 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #8 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #9 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #10 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #11 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #12 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #13 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #14 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #15 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #16 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #17 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #18 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #19 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #20 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #21 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #22 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #23 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #24 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #25 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #26 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #27 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #28 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #29 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #30 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #31 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #32 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #33 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #34 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #35 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #36 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #37 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #38 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #39 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #40 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #41 (No such file or directory) alsactl: set_control:1339: failed to obtain info for control #42 (No such file or directory) ``` If I store configs again via `alsactl store` and restore them using `alsactl restore`, everything works, but the issue returns after another reboot. Here's the output of `alsa-info.sh` if it helps: [alsa-info.txt](https://github.com/alsa-project/alsa-utils/files/14971854/al… Issue URL : https://github.com/alsa-project/alsa-utils/issues/263 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

Compatibility with FFMPEG 7.0
by GitHub pull_request - opened 14 Apr '24

14 Apr '24

alsa-project/alsa-plugins pull request #58 was opened from eclipseo: channel_layout has been replace with ch_layout avcodec_close has been deprecated in favor of avcodec_free_context Fix #57 Request URL : https://github.com/alsa-project/alsa-plugins/pull/58 Patch URL : https://github.com/alsa-project/alsa-plugins/pull/58.patch Repository URL: https://github.com/alsa-project/alsa-plugins

1 0

Re:Re:Re:Re: [PATCH] cpufreq: exit() callback is optional
by lizhe 13 Apr '24

13 Apr '24

HI I urge you to pay close attention to this incident once again. thanks Please don't let the Linux kernel community be filled with robbers and thieves! On April 12th, 2024, at 00:57, I sent the vulnerability and explained the situation to the maintainer at rafael(a)kernel.org and viresh.kumar(a)linaro.org. At 02:11 on April 12th, 2024, Rafael replied to me, asking me to submit it to the main branch. At 07:18 on April 12th, 2024, I submitted the vulnerability to the main branch. At 11:24 on April 12th, 2024, Viresh Kumar replied to me, confirming that the vulnerability was legitimate. At 13:49 on April 12th, 2024, Viresh Kumar released the patch to the main list. Here is the patchs I submitted to the main line . cpufreq: Remove redundant exit() functions https://lore.kernel.org/all/20240409141909.4413-1-sensor1010@163.com/ cpufreq: Convert to exit callback returning void https://lore.kernel.org/all/20240410132247.3587-1-sensor1010@163.com/ cpufreq: Covert to offline callback returning void https://lore.kernel.org/all/20240411150620.19262-1-sensor1010@163.com/ cpufreq: Fixed kernel crash caused by cpufreq issues https://lore.kernel.org/all/20240411231818.2471-1-sensor1010@163.com/ Viresh Kumar, are you not a robber and thief? As a maintainer, do you really not care about the healthy development of the community and only defend your own interests? It was me who first released the patch and publicly disclosed the vulnerability to the main branch. Viresh Kumar only understood the principle of the vulnerability after seeing my submitted patch. Moreover, I communicated with you later and requested to add my signature to the patch, but you refused to communicate. Your behavior fully demonstrates that you are a selfish person. I don't understand why there can be such a selfish person in a country where Buddhism was born, and this person is even a maintainer! At 2024-04-12 22:41:27, "lizhe" <sensor1010(a)163.com> wrote: Let's both take a step back and add my signature to the patch, since I was the one who discovered and reported the vulnerability. HI i will review how it all started. 1. i reported the vulnerability to the maintainer. 2. manitaner replay me 3. i report to main line 4. you reply me 5 . you report to main line You submitted the patch to the mainline after you learned about the vulnerability from the patch I submitted At 2024-04-12 21:54:00, "lizhe" <sensor1010(a)163.com> wrote: Hi Viresh Kumar please add my name to the signature. because i discovered this vulnerability. please reply me. thanks At 2024-04-12 18:28:56, "Greg KH" <gregkh(a)linuxfoundation.org> wrote: >On Fri, Apr 12, 2024 at 02:51:08PM +0530, Viresh Kumar wrote: >> On 12-04-24, 17:05, lizhe wrote: >> > I found it first and submitted it to the main line first. Please be fair and just. Let him withdraw his patch. >> >> Well, I decided not to reply to your emails anymore but this needs to >> be clarified a bit now. >> >> You sent a lot of patches, over and over again and it was a mess. I >> saw the this [1] series first and went over to read the code and fixed >> an issue which I found (by the $subject patch). >> >> Later I read your other patch [2], which I Acked roughly two hours >> back and yes you did send a patch that fixed the problem partially. I >> never saw it earlier, which is okay and it happens. Despite me giving >> an Ack to your patch, you have sent half-a-dozen more emails.. >> >> Then I posted a newer version of my patch some time back, removing the >> bits you already fixed [3]. >> >> That is all one side of the story. But all the noise you have created >> here has really demotivated people to review your stuff now. >> >> -- >> Viresh >> >> [1] https://lore.kernel.org/all/20240410132132.3526-1-sensor1010@163.com/ >> [2] https://lore.kernel.org/all/20240411231818.2471-1-sensor1010@163.com/ >> [3] https://lore.kernel.org/all/68294ce534668c6ab3b71a1b3e6650227c6e1f20.171291… > >Thanks for the links, I don't see that you did anything wrong here at >all. > >Lizhe, you seem to be confused as to how kernel development works. I >suggest you take some time off and read up on how this all is supposed >to happen and then work with some local people, in person, to get this >figured out first, before submitting changes again. > >thanks, > >greg k-h

1 0

[PATCH] Fix volumn control of ThinkBook 16P Gen4
by zhanghuayu1233＠qq.com 13 Apr '24

13 Apr '24

From: Huayu Zhang <zhanghuayu1233(a)qq.com> change HDA & AMP configuration from ALC287_FIXUP_CS35L41_I2C_2 to ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD for ThinkBook 16P Gen4 models to fix volumn control issue (cannot fully mute). Signed-off-by: Huayu Zhang <zhanghuayu1233(a)qq.com> --- sound/pci/hda/patch_realtek.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index d6940bc4ec39..1aef223307bb 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -10396,8 +10396,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x17aa, 0x3886, "Y780 VECO DUAL", ALC287_FIXUP_TAS2781_I2C), SND_PCI_QUIRK(0x17aa, 0x38a7, "Y780P AMD YG dual", ALC287_FIXUP_TAS2781_I2C), SND_PCI_QUIRK(0x17aa, 0x38a8, "Y780P AMD VECO dual", ALC287_FIXUP_TAS2781_I2C), - SND_PCI_QUIRK(0x17aa, 0x38a9, "Thinkbook 16P", ALC287_FIXUP_CS35L41_I2C_2), - SND_PCI_QUIRK(0x17aa, 0x38ab, "Thinkbook 16P", ALC287_FIXUP_CS35L41_I2C_2), + SND_PCI_QUIRK(0x17aa, 0x38a9, "Thinkbook 16P", ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD), + SND_PCI_QUIRK(0x17aa, 0x38ab, "Thinkbook 16P", ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD), SND_PCI_QUIRK(0x17aa, 0x38b4, "Legion Slim 7 16IRH8", ALC287_FIXUP_CS35L41_I2C_2), SND_PCI_QUIRK(0x17aa, 0x38b5, "Legion Slim 7 16IRH8", ALC287_FIXUP_CS35L41_I2C_2), SND_PCI_QUIRK(0x17aa, 0x38b6, "Legion Slim 7 16APH8", ALC287_FIXUP_CS35L41_I2C_2), -- 2.34.1

1 0