April 2024 - Alsa-devel - mailman.alsa-project.org

conf: aliases: hdmi: Include unconditionally the pcm/hdmi.conf
by GitHub pull_request - opened 23 Apr '24

23 Apr '24

alsa-project/alsa-lib pull request #393 was opened from ujfalusi: The hdmi.conf contains the high level macro to be used by cards to create the hdmi: device. Instead of including it in different config files, include it in the main aliases.conf and remove it's inclusion by other config files. This change is needed to add support for the hdmi: device mapping via UCM. Suggested-by: Jaroslav Kysela <perex(a)perex.cz> Request URL : https://github.com/alsa-project/alsa-lib/pull/393 Patch URL : https://github.com/alsa-project/alsa-lib/pull/393.patch Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH] ASoC: cs35l56: Avoid static analysis warning of uninitialised variable
by Richard Fitzgerald 23 Apr '24

23 Apr '24

From: Simon Trimmer <simont(a)opensource.cirrus.com> Static checkers complain that the silicon_uid variable passed by pointer to cs35l56_read_silicon_uid() could later be used uninitialised when calling cs_amp_get_efi_calibration_data(). cs35l56_read_silicon_uid() must have succeeded to call cs_amp_get_efi_calibration_data() and that would have populated the variable. However, initialise the value so we are not haunted by it forevermore. Signed-off-by: Simon Trimmer <simont(a)opensource.cirrus.com> Fixes: e1830f66f6c6 ("ASoC: cs35l56: Add helper functions for amp calibration") Signed-off-by: Richard Fitzgerald <rf(a)opensource.cirrus.com> --- sound/soc/codecs/cs35l56-shared.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/cs35l56-shared.c b/sound/soc/codecs/cs35l56-shared.c index 3aa39f5923eb..8af89a263594 100644 --- a/sound/soc/codecs/cs35l56-shared.c +++ b/sound/soc/codecs/cs35l56-shared.c @@ -707,7 +707,7 @@ EXPORT_SYMBOL_NS_GPL(cs35l56_calibration_controls, SND_SOC_CS35L56_SHARED); int cs35l56_get_calibration(struct cs35l56_base *cs35l56_base) { - u64 silicon_uid; + u64 silicon_uid = 0; int ret; /* Driver can't apply calibration to a secured part, so skip */ -- 2.39.2

2 1

CM106L, CM6206, CM6206-LX
by James Lehman 22 Apr '24

22 Apr '24

Hello everyone. I have been using CMedia USB sound devices to make laser control signals for many years. I have sound devices with CM106L, CM6206 and CM6206-LX. Some are populated for 6 channels and some for 8. The CM106L chip works perfectly. I can send it a stream of 16-bit data that uses the full range of -32767 to +32767 and at 100% volume in either alsamixer or Pulseaudio Volume Control, I get a perfect image. https://laserboy.org/piDAC/perfect_circle.jpg If I use a device with a CM6206, I get a very near perfect image (only clipped a tiny bit). But If I use a CM6206-LX chip, it clips hard. https://laserboy.org/piDAC/CM6206-LX_100.jpg Even if I reduce the volume to 50%, it just seems to reduce the clipped signals. https://laserboy.org/piDAC/CM6206-LX_50.jpg I'm not sure what is going on here, but it seems like there is some kind of internal digital gain of more than 1.0. I also notice that lsusb shows exactly the same device ID for both the CM6206 and the CM6206-LX. .... 0d8c:0102 C-Media Electronics, Inc. CM106 Like Sound Device And what's really weird is that a genuine CM106L shows up as something else! .... 0d8c:0006 C-Media Electronics, Inc. Storm HP-USB500 5.1 Headset Is there something I can do in alsa config to fix this issue? The CM106L is long since out of production and it seems like any device that uses the CM6206 might have the LX version (or not). There's no way to know until I get them and open them up. I'm using this on an Orange Pi Zero 3 4gb running dietpi with the 6.6.16-current-sunxi64 kernel, but that doesn't seem to matter. I get the same results any other way I try it. The LX version of this chip clips the same way in Windows too! Thanks for your time. James.

1 0

[tiwai-sound:for-next 34/51] sound/usb/mixer_scarlett2.c:3690 scarlett2_ag_target_ctl_get() error: uninitialized symbol 'err'.
by Dan Carpenter 22 Apr '24

22 Apr '24

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next head: 32cb23a0f911317cdb5030035e49a204aa86fef5 commit: e30ea5340c25d41484d551f61d8c93106989019b [34/51] ALSA: scarlett2: Add autogain target controls config: csky-randconfig-r081-20240420 (https://download.01.org/0day-ci/archive/20240420/202404201509.mWdaL3xF-lkp@…) compiler: csky-linux-gcc (GCC) 13.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Reported-by: Dan Carpenter <dan.carpenter(a)linaro.org> | Closes: https://lore.kernel.org/r/202404201509.mWdaL3xF-lkp@intel.com/ New smatch warnings: sound/usb/mixer_scarlett2.c:3690 scarlett2_ag_target_ctl_get() error: uninitialized symbol 'err'. vim +/err +3690 sound/usb/mixer_scarlett2.c e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 3665 static int scarlett2_ag_target_ctl_get( e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 3666 struct snd_kcontrol *kctl, struct snd_ctl_elem_value *ucontrol) e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 3667 { e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 3668 struct usb_mixer_elem_info *elem = kctl->private_data; e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 3669 struct usb_mixer_interface *mixer = elem->head.mixer; e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 3670 struct scarlett2_data *private = mixer->private_data; e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 3671 int err; e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 3672 e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 3673 mutex_lock(&private->data_mutex); e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 3674 e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 3675 if (private->hwdep_in_use) { e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 3676 err = -EBUSY; e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 3677 goto unlock; e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 3678 } e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 3679 e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 3680 if (private->autogain_updated) { e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 3681 err = scarlett2_update_autogain(mixer); e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 3682 if (err < 0) e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 3683 goto unlock; e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 3684 } err uninitialized on else path. e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 3685 e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 3686 ucontrol->value.integer.value[0] = private->ag_targets[elem->control]; e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 3687 e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 3688 unlock: e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 3689 mutex_unlock(&private->data_mutex); e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 @3690 return err; e30ea5340c25d41 Geoffrey D. Bennett 2024-03-13 3691 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

snd_hda_intel with buffer_size set to 32768 sounds horrible. Kernel driver bug?
by Jaime 22 Apr '24

22 Apr '24

Fresh Debian Bookworm (v12) installation with alsa but no sound server. aplay with no .asoundrc sounds great (default buffer_size is 16384). If I force the buffer_size to 32768 ([1]), then aplay sounds horrible ([2]). Is this a kernel driver bug? (If yes, I'll log it at https://bugzilla.kernel.org) I discovered this bug because pipewire sets the buffer_size to 32768 hence it triggers this bug - I've logged a bug against pipewire at [3]. Output from alsa-info at [4]. TIA. [1] To set aplay's buffer_size to 32768, I use the following ~/.asoundrc: pcm.!default { type plug slave { pcm { type dmix ipc_key 1234 slave { period_size 1024 buffer_size 32768 pcm "hw:0" format S32_LE } } } } [2] Upload of horrible sound at https://audio.com/jt-1796478503182974/audio/alsaonlybuf-32768nopipewire [3] https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/3966 [4] http://alsa-project.org/db/?f=5dbfb02c81bb1523505c725a189b6f0133f2b3d7

1 0

[PATCH v2 0/8] ASoC: codecs: wcd937x: add wcd937x audio codec support
by Mohammad Rafi Shaik 22 Apr '24

22 Apr '24

This patchset adds support for Qualcomm WCD937X codec. Qualcomm WCD9370/WCD9375 Codec is a standalone Hi-Fi audio codec IC connected over SoundWire. This device has two SoundWire devices, RX and TX respectively supporting 3 x ADCs, ClassH, Ear, Aux PA, 2xHPH, 6 DMICs and MBHC. For codec driver to be functional it would need both tx and rx Soundwire devices to be up and this is taken care by using device component framework and device-links are used to ensure proper pm dependencies. Ex tx does not enter suspend before rx or codec is suspended. This patchset along with other SoundWire patches on the list have been tested on QCM6490 IDP device. Changes since v8: - Split the patch per driver for easier review as suggested by Krzysztof - Used devm_gpiod_get api to get reset gpio as suggested by Krzysztof Prasad Kumpatla (8): ASoC: dt-bindings: wcd937x: add bindings for wcd937x ASoC: codecs: wcd937x: add wcd937x codec driver ASoC: dt-bindings: wcd937x-sdw: add bindings for wcd937x-sdw ASoC: codecs: wcd937x-sdw: add SoundWire driver ASoC: codecs: wcd937x: add basic controls ASoC: codecs: wcd937x: add playback dapm widgets ASoC: codecs: wcd937x: add capture dapm widgets ASoC: codecs: wcd937x: add audio routing and Kconfig .../bindings/sound/qcom,wcd937x-sdw.yaml | 71 + .../bindings/sound/qcom,wcd937x.yaml | 119 + sound/soc/codecs/Kconfig | 20 + sound/soc/codecs/Makefile | 7 + sound/soc/codecs/wcd937x-sdw.c | 1148 +++++++ sound/soc/codecs/wcd937x.c | 3036 +++++++++++++++++ sound/soc/codecs/wcd937x.h | 655 ++++ 7 files changed, 5056 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd937x-sdw.yaml create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd937x.yaml create mode 100644 sound/soc/codecs/wcd937x-sdw.c create mode 100644 sound/soc/codecs/wcd937x.c create mode 100644 sound/soc/codecs/wcd937x.h base-commit: 6bd343537461b57f3efe5dfc5fc193a232dfef1e -- 2.25.1

5 18

sof-hda-dsp/sof-soundwire: Create "hdmi:" mapping PCMs to allow passthrough if supported
by GitHub pull_request - opened 22 Apr '24

22 Apr '24

alsa-project/alsa-ucm-conf pull request #411 was opened from ujfalusi: Hi, SOF with IPC4 can use 'ChainDMA' on selected PCMs (HDMI/DP currently) which allows them to be used for bytestream passthrough since the data is passed through unmodified. The kernel will list the PCMs with ChainDMA to the card's components list: https://github.com/thesofproject/linux/pull/4921 For example for sof-dsp-hda cards `iec61937-pcm:5,4,3` will be added. For user space to use HDMI passthrough, the `hdmi:` PCM device should be present correctly mapping to the machine, for example for sof-dsp-hda: ``` aplay -L | grep hdmi hdmi:CARD=sofhdadsp,DEV=0 hdmi:CARD=sofhdadsp,DEV=1 hdmi:CARD=sofhdadsp,DEV=2 ``` This PR does this by 1. Checking the `iec61937-pcm` indexes against the expected HDMI devices (sof-dsp-hda: 3-5, sof-soundwire: 5-7) 2. If there is a match (passthrough can be supported) then we will create three conf files: The generated files are: [1] /var/lib/alsa/conf.d/42-sof-hdmi.conf [2] /var/lib/alsa/card[card_number].conf.d/30-sof-hdmi-common.conf [3] /var/lib/alsa/card[card_number].conf.d/31-sof-hdmi.conf [1] includes the pcm/iec958.conf and pcm/hdmi.conf to global space of alsaconf to be used by the card macros [2] Card specific macros for hdmi PCM definition, mapping [3] Card specific definitions of the three HDMI port Note for [1]: I needed to use `shell "echo '...` since the `cfg-save` would expand the includes into the saved config file and that just does not result a working alsa configuration. @perexg, I'm sure all this can be done in a cleaner way... We cannot do this unconditionally as if the HDMI is not using ChainDMA (and SOF is not IPC4) then the passthrough is not possible since the firmware might touch the data. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/411 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/411.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH v2 0/3] ASoC: nau8821: Add delay control for ADC
by Seven Lee 22 Apr '24

22 Apr '24

Change the original fixed delay to the assignment from the property. It will make it more flexible to different platforms to avoid pop noise at the beginning of recording. Change: V1 -> V2: - Revise adc-delay-ms properties description. - Fix examples of bugs found by bots. Seven Lee (3): ASoC: dt-bindings: nau8821: Add delay control for ADC ASoC: nau8821: Add delay control for ADC ASoC: nau8821: Remove redundant ADC controls .../bindings/sound/nuvoton,nau8821.yaml | 7 +++++++ sound/soc/codecs/nau8821.c | 19 +++++++++---------- sound/soc/codecs/nau8821.h | 1 + 3 files changed, 17 insertions(+), 10 deletions(-) -- 2.25.1

3 5

[PATCH] ALSA: scarlett2: Zero initialize ret in scarlett2_ag_target_ctl_get()
by Nathan Chancellor 21 Apr '24

21 Apr '24

Clang warns (or errors with CONFIG_WERROR): sound/usb/mixer_scarlett2.c:3697:6: error: variable 'err' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] 3697 | if (private->autogain_updated) { | ^~~~~~~~~~~~~~~~~~~~~~~~~ sound/usb/mixer_scarlett2.c:3707:9: note: uninitialized use occurs here 3707 | return err; | ^~~ sound/usb/mixer_scarlett2.c:3697:2: note: remove the 'if' if its condition is always true 3697 | if (private->autogain_updated) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sound/usb/mixer_scarlett2.c:3688:9: note: initialize the variable 'err' to silence this warning 3688 | int err; | ^ | = 0 1 error generated. Initialize ret to zero to ensure ret is initialized in all paths within scarlett2_ag_target_ctl_get(), which matches the style of other functions in this driver. Fixes: e30ea5340c25 ("ALSA: scarlett2: Add autogain target controls") Signed-off-by: Nathan Chancellor <nathan(a)kernel.org> --- FWIW, a lot of the functions that end in just 'mutex_unlock()' before returning could probably benefit from the cleanup.h infrastructure, which would help with the scope of err in this particular function, but I decided to go with the most minimal fix here. --- sound/usb/mixer_scarlett2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/usb/mixer_scarlett2.c b/sound/usb/mixer_scarlett2.c index a2de31a0371b..b251d25f2a85 100644 --- a/sound/usb/mixer_scarlett2.c +++ b/sound/usb/mixer_scarlett2.c @@ -3685,7 +3685,7 @@ static int scarlett2_ag_target_ctl_get( struct usb_mixer_elem_info *elem = kctl->private_data; struct usb_mixer_interface *mixer = elem->head.mixer; struct scarlett2_data *private = mixer->private_data; - int err; + int err = 0; mutex_lock(&private->data_mutex); --- base-commit: 32cb23a0f911317cdb5030035e49a204aa86fef5 change-id: 20240419-alsa-scarlett2-fix-wsometimes-uninitialized-d44f7659b52a Best regards, -- Nathan Chancellor <nathan(a)kernel.org>

2 1

[PATCH] ASoC: codecs: wsa881x: set clk_stop_mode1 flag
by srinivas.kandagatla＠linaro.org 21 Apr '24

21 Apr '24

From: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> WSA881x codecs do not retain the state while clock is stopped, so mark this with clk_stop_mode1 flag. Fixes: a0aab9e1404a ("ASoC: codecs: add wsa881x amplifier support") Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> --- sound/soc/codecs/wsa881x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/wsa881x.c b/sound/soc/codecs/wsa881x.c index 3c025dabaf7a..1253695bebd8 100644 --- a/sound/soc/codecs/wsa881x.c +++ b/sound/soc/codecs/wsa881x.c @@ -1155,6 +1155,7 @@ static int wsa881x_probe(struct sdw_slave *pdev, pdev->prop.sink_ports = GENMASK(WSA881X_MAX_SWR_PORTS, 0); pdev->prop.sink_dpn_prop = wsa_sink_dpn_prop; pdev->prop.scp_int1_mask = SDW_SCP_INT1_BUS_CLASH | SDW_SCP_INT1_PARITY; + pdev->prop.clk_stop_mode1 = true; gpiod_direction_output(wsa881x->sd_n, !wsa881x->sd_n_val); wsa881x->regmap = devm_regmap_init_sdw(pdev, &wsa881x_regmap_config); -- 2.43.0

2 1