March 2024 - Alsa-devel - mailman.alsa-project.org

[PATCH v1 0/3] ALSA: hda: cs35l41: Add support for a couple of Lenovo and Asus Laptops
by Stefan Binding 04 Mar '24

04 Mar '24

Add support for a couple of Lenovo Thinkbook 16P laptops using CS35L41 HDA. Also fix a _DSD BIOS error for the ASUS UM5302LA laptop. Stefan Binding (3): ALSA: hda: cs35l41: Support Lenovo Thinkbook 16P ALSA: hda/realtek: Add quirks for Lenovo Thinkbook 16P laptops ALSA: hda: cs35l41: Overwrite CS35L41 configuration for ASUS UM5302LA sound/pci/hda/cs35l41_hda_property.c | 6 ++++++ sound/pci/hda/patch_realtek.c | 2 ++ 2 files changed, 8 insertions(+) -- 2.34.1

2 4

Enable Headset Mic for Acer NB platform
by Kailang 04 Mar '24

04 Mar '24

Hi Takashi, This patch will enable headset Mic for Acer NB platform. Many Thanks. BR, Kailang

2 3

Scarlett Solo USB profiles missing or broken in 1.2.11
by GitHub issues - edited 03 Mar '24

03 Mar '24

alsa-project/alsa-ucm-conf issue #398 was edited from Slabity: Prior to version 1.2.10, my Scarlett Solo USB profiles looked like the following, where I could select profiles that explicitly enabled or disabled either the Inputs or Outputs: ![goodaudiooutput](https://github.com/alsa-project/alsa-ucm-conf/assets/3788421/b1bbc857-82b6-4fa5-b478-0c00c26b281c) As of 1.2.11, these profiles have disappeared and have left only a couple of profiles that do not provide the same functionality: ![badaudiooutputs](https://github.com/alsa-project/alsa-ucm-conf/assets/3788421/6c321638-3eb1-45ef-94a5-734c16477886) Other devices like my GPU's HDMI/DP Audio and motherboard's "Starship/Matisse HD Audio Controller" continue to expose the wider variety of profiles. It is only this device that seems to have the issue. I originally reported this on #346 as I thought it was related, but was told it might be a different issue. What makes me worried is the mention that this is "expected" now despite it breaking my audio setup. I can no longer select the "Digital Stereo (IEC958) Input" to exclusively enable the Input Device *without* enabling the Output Device. Here's some more information about the device: ``` $ lsusb | grep Focusrite Bus 007 Device 003: ID 1235:801c Focusrite-Novation Scarlett Solo USB $ alsaucm listcards 0: hw:2 Focusrite Scarlett Solo USB at usb-0000:10:00.3-3, high speed $ alsaucm -c hw:2 dump text Verb.HiFi { Comment Default Device.Line1 { Comment "Headphones / Line 1-2" Values { CaptureCTL "_ucm0001.hw:USB" PlaybackCTL "_ucm0001.hw:USB" PlaybackPCM "_ucm0001.hw:USB" PlaybackPriority 200 } } Device.Mic1 { Comment "Input 1 Mic" Values { CaptureCTL "_ucm0001.hw:USB" CaptureChannels 1 CapturePCM "_ucm0001.scarlett2i_mono_in:USB,0,0" CapturePriority 200 PlaybackCTL "_ucm0001.hw:USB" } } Device.Mic2 { Comment "Input 2 Inst/Line" Values { CaptureCTL "_ucm0001.hw:USB" CaptureChannels 1 CapturePCM "_ucm0001.scarlett2i_mono_in:USB,0,1" CapturePriority 100 PlaybackCTL "_ucm0001.hw:USB" } } } Verb.Direct { Comment "Direct Scarlett Solo USB" Device.Direct { Comment "Direct Scarlett Solo USB" Values { CaptureCTL "_ucm0001.hw:USB" CaptureChannels 2 CapturePCM "_ucm0001.hw:USB" CapturePriority 1000 PlaybackCTL "_ucm0001.hw:USB" PlaybackChannels 2 PlaybackPCM "_ucm0001.hw:USB" PlaybackPriority 1000 } } } ``` Some OS info it it helps: Linux distribution: NixOS on nixpkgs-unstable Kernel: 6.7.7 ALSA version: Advanced Linux Sound Architecture Driver Version k6.7.7 Pulseaudio version: 15.0.0 Pipewire version: 1.0.3 Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/398 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Scarlett Solo USB profiles missing or broken in 1.2.11
by GitHub issues - edited 03 Mar '24

03 Mar '24

alsa-project/alsa-ucm-conf issue #398 was edited from Slabity: Prior to version 1.2.10, my Scarlett Solo USB profiles looked like the following, where I could select profiles that explicitly enabled or disabled either the Inputs or Outputs: ![goodaudiooutput](https://github.com/alsa-project/alsa-ucm-conf/assets/3788421/b1bbc857-82b6-4fa5-b478-0c00c26b281c) As of 1.2.11, these profiles have disappeared and have left only a couple of profiles that do not provide the same functionality: ![badaudiooutputs](https://github.com/alsa-project/alsa-ucm-conf/assets/3788421/6c321638-3eb1-45ef-94a5-734c16477886) Other devices like my GPU's HDMI/DP Audio and motherboard's "Starship/Matisse HD Audio Controller" continue to expose the wider variety of profiles. It is only this device that seems to have the issue. I originally reported this on #346 as I thought it was related, but was told it might be a different issue. What makes me worried is the mention that this is "expected" now despite it breaking my audio setup. I can no longer select the "Digital Stereo (IEC958) Input" to exclusively enable the Input Device *without* enabling the Output Device. Here's some more information about the device: ``` $ lsusb | grep Focusrite Bus 007 Device 003: ID 1235:801c Focusrite-Novation Scarlett Solo USB $ alsaucm listcards 0: hw:2 Focusrite Scarlett Solo USB at usb-0000:10:00.3-3, high speed $ alsaucm -c hw:2 dump text Verb.HiFi { Comment Default Device.Line1 { Comment "Headphones / Line 1-2" Values { CaptureCTL "_ucm0001.hw:USB" PlaybackCTL "_ucm0001.hw:USB" PlaybackPCM "_ucm0001.hw:USB" PlaybackPriority 200 } } Device.Mic1 { Comment "Input 1 Mic" Values { CaptureCTL "_ucm0001.hw:USB" CaptureChannels 1 CapturePCM "_ucm0001.scarlett2i_mono_in:USB,0,0" CapturePriority 200 PlaybackCTL "_ucm0001.hw:USB" } } Device.Mic2 { Comment "Input 2 Inst/Line" Values { CaptureCTL "_ucm0001.hw:USB" CaptureChannels 1 CapturePCM "_ucm0001.scarlett2i_mono_in:USB,0,1" CapturePriority 100 PlaybackCTL "_ucm0001.hw:USB" } } } Verb.Direct { Comment "Direct Scarlett Solo USB" Device.Direct { Comment "Direct Scarlett Solo USB" Values { CaptureCTL "_ucm0001.hw:USB" CaptureChannels 2 CapturePCM "_ucm0001.hw:USB" CapturePriority 1000 PlaybackCTL "_ucm0001.hw:USB" PlaybackChannels 2 PlaybackPCM "_ucm0001.hw:USB" PlaybackPriority 1000 } } } ``` Some OS info it it helps: Linux distribution: NixOS Kernel: 6.7.7 ALSA version: Advanced Linux Sound Architecture Driver Version k6.7.7 Pulseaudio version: 15.0.0 Pipewire version: 1.0.3 Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/398 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Scarlett Solo USB profiles missing or broken in 1.2.11
by GitHub issues - edited 03 Mar '24

03 Mar '24

alsa-project/alsa-ucm-conf issue #398 was edited from Slabity: Prior to version 1.2.10, my Scarlett Solo USB profiles looked like the following, where I could select profiles that explicitly enabled or disabled either the Inputs or Outputs: ![goodaudiooutput](https://github.com/alsa-project/alsa-ucm-conf/assets/3788421/b1bbc857-82b6-4fa5-b478-0c00c26b281c) As of 1.2.11, these profiles have disappeared and have left only a couple of profiles that do not provide the same functionality: ![badaudiooutputs](https://github.com/alsa-project/alsa-ucm-conf/assets/3788421/6c321638-3eb1-45ef-94a5-734c16477886) Other devices like my GPU's HDMI/DP Audio and motherboard's "Starship/Matisse HD Audio Controller" continue to expose the wider variety of profiles. It is only this device that seems to have the issue. I originally reported this on #346 as I thought it was related, but was told it might be a different issue. What makes me worried is the mention that this is "expected" now despite it breaking my audio setup. I can no longer select the "Digital Stereo (IEC958) Input" to exclusively enable the Input Device *without* enabling the Output Device. Here's some more information about the device: ``` $ lsusb | grep Focusrite Bus 007 Device 003: ID 1235:801c Focusrite-Novation Scarlett Solo USB $ alsaucm listcards 0: hw:2 Focusrite Scarlett Solo USB at usb-0000:10:00.3-3, high speed $ alsaucm -c hw:2 dump text Verb.HiFi { Comment Default Device.Line1 { Comment "Headphones / Line 1-2" Values { CaptureCTL "_ucm0001.hw:USB" PlaybackCTL "_ucm0001.hw:USB" PlaybackPCM "_ucm0001.hw:USB" PlaybackPriority 200 } } Device.Mic1 { Comment "Input 1 Mic" Values { CaptureCTL "_ucm0001.hw:USB" CaptureChannels 1 CapturePCM "_ucm0001.scarlett2i_mono_in:USB,0,0" CapturePriority 200 PlaybackCTL "_ucm0001.hw:USB" } } Device.Mic2 { Comment "Input 2 Inst/Line" Values { CaptureCTL "_ucm0001.hw:USB" CaptureChannels 1 CapturePCM "_ucm0001.scarlett2i_mono_in:USB,0,1" CapturePriority 100 PlaybackCTL "_ucm0001.hw:USB" } } } Verb.Direct { Comment "Direct Scarlett Solo USB" Device.Direct { Comment "Direct Scarlett Solo USB" Values { CaptureCTL "_ucm0001.hw:USB" CaptureChannels 2 CapturePCM "_ucm0001.hw:USB" CapturePriority 1000 PlaybackCTL "_ucm0001.hw:USB" PlaybackChannels 2 PlaybackPCM "_ucm0001.hw:USB" PlaybackPriority 1000 } } } ``` Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/398 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Scarlett Solo USB profiles missing or broken in 1.2.11
by GitHub issues - opened 03 Mar '24

03 Mar '24

alsa-project/alsa-ucm-conf issue #398 was opened from Slabity: Prior to version 1.2.10, my Scarlett Solo USB profiles looked like the following, where I could select profiles that explicitly enabled or disabled either the Inputs or Outputs: ![goodaudiooutput](https://github.com/alsa-project/alsa-ucm-conf/assets/3788421/b1bbc857-82b6-4fa5-b478-0c00c26b281c) As of 1.2.11, these profiles have disappeared and have left only a couple of profiles that do not provide the same functionality: ![badaudiooutputs](https://github.com/alsa-project/alsa-ucm-conf/assets/3788421/6c321638-3eb1-45ef-94a5-734c16477886) Other devices like my GPU's HDMI/DP Audio and motherboard's "Starship/Matisse HD Audio Controller" continue to expose the wider variety of profiles. It is only this device that seems to have the issue. I originally reported this on #346 as I thought it was related, but was told it might be a different issue. What makes me worried is the mention that this is "expected" now despite it breaking my audio setup. I can no longer select the "Digital Stereo (IEC958) Input" to exclusively enable the Input Device *without* enabling the Output Device. Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/398 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH] soundwire: Use snd_soc_substream_to_rtd() to obtain rtd
by Cezary Rojewski 03 Mar '24

03 Mar '24

Utilize the helper function instead of casting from ->private_data directly. Signed-off-by: Cezary Rojewski <cezary.rojewski(a)intel.com> --- drivers/soundwire/stream.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c index f9c0adc0738d..4e9e7d2a942d 100644 --- a/drivers/soundwire/stream.c +++ b/drivers/soundwire/stream.c @@ -1718,7 +1718,7 @@ EXPORT_SYMBOL(sdw_deprepare_stream); static int set_stream(struct snd_pcm_substream *substream, struct sdw_stream_runtime *sdw_stream) { - struct snd_soc_pcm_runtime *rtd = substream->private_data; + struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream); struct snd_soc_dai *dai; int ret = 0; int i; @@ -1771,7 +1771,7 @@ EXPORT_SYMBOL(sdw_alloc_stream); int sdw_startup_stream(void *sdw_substream) { struct snd_pcm_substream *substream = sdw_substream; - struct snd_soc_pcm_runtime *rtd = substream->private_data; + struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream); struct sdw_stream_runtime *sdw_stream; char *name; int ret; @@ -1815,7 +1815,7 @@ EXPORT_SYMBOL(sdw_startup_stream); void sdw_shutdown_stream(void *sdw_substream) { struct snd_pcm_substream *substream = sdw_substream; - struct snd_soc_pcm_runtime *rtd = substream->private_data; + struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream); struct sdw_stream_runtime *sdw_stream; struct snd_soc_dai *dai; -- 2.25.1

2 1

[PATCH] soundwire: constify the struct device_type usage
by Ricardo B. Marliere 03 Mar '24

03 Mar '24

Since commit aed65af1cc2f ("drivers: make device_type const"), the driver core can properly handle constant struct device_type. Move the sdw_master_type and sdw_slave_type variables to be constant structures as well, placing it into read-only memory which can not be modified at runtime. Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Signed-off-by: Ricardo B. Marliere <ricardo(a)marliere.net> --- drivers/soundwire/master.c | 2 +- drivers/soundwire/slave.c | 2 +- include/linux/soundwire/sdw_type.h | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/soundwire/master.c b/drivers/soundwire/master.c index 51abedbbaa66..b2c64512739d 100644 --- a/drivers/soundwire/master.c +++ b/drivers/soundwire/master.c @@ -112,7 +112,7 @@ static const struct dev_pm_ops master_dev_pm = { pm_generic_runtime_resume, NULL) }; -struct device_type sdw_master_type = { +const struct device_type sdw_master_type = { .name = "soundwire_master", .release = sdw_master_device_release, .pm = &master_dev_pm, diff --git a/drivers/soundwire/slave.c b/drivers/soundwire/slave.c index 060c2982e26b..9963b92eb505 100644 --- a/drivers/soundwire/slave.c +++ b/drivers/soundwire/slave.c @@ -16,7 +16,7 @@ static void sdw_slave_release(struct device *dev) kfree(slave); } -struct device_type sdw_slave_type = { +const struct device_type sdw_slave_type = { .name = "sdw_slave", .release = sdw_slave_release, .uevent = sdw_slave_uevent, diff --git a/include/linux/soundwire/sdw_type.h b/include/linux/soundwire/sdw_type.h index b445f7200f06..693320b4f5c2 100644 --- a/include/linux/soundwire/sdw_type.h +++ b/include/linux/soundwire/sdw_type.h @@ -5,8 +5,8 @@ #define __SOUNDWIRE_TYPES_H extern const struct bus_type sdw_bus_type; -extern struct device_type sdw_slave_type; -extern struct device_type sdw_master_type; +extern const struct device_type sdw_slave_type; +extern const struct device_type sdw_master_type; static inline int is_sdw_slave(const struct device *dev) { --- base-commit: 81a7d0c4d059cb5c122110acbeec7bedfb91a741 change-id: 20240219-device_cleanup-soundwire-c037fffa2746 Best regards, -- Ricardo B. Marliere <ricardo(a)marliere.net>

2 1

[PATCH] soundwire: Use snd_soc_substream_to_rtd() to obtain rtd
by Amadeusz Sławiński 03 Mar '24

03 Mar '24

From: Cezary Rojewski <cezary.rojewski(a)intel.com> Utilize the helper function instead of casting from ->private_data directly. Signed-off-by: Cezary Rojewski <cezary.rojewski(a)intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski(a)linux.intel.com> --- drivers/soundwire/stream.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c index 69719b335bcb..652aae4e221d 100644 --- a/drivers/soundwire/stream.c +++ b/drivers/soundwire/stream.c @@ -1717,7 +1717,7 @@ EXPORT_SYMBOL(sdw_deprepare_stream); static int set_stream(struct snd_pcm_substream *substream, struct sdw_stream_runtime *sdw_stream) { - struct snd_soc_pcm_runtime *rtd = substream->private_data; + struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream); struct snd_soc_dai *dai; int ret = 0; int i; @@ -1770,7 +1770,7 @@ EXPORT_SYMBOL(sdw_alloc_stream); int sdw_startup_stream(void *sdw_substream) { struct snd_pcm_substream *substream = sdw_substream; - struct snd_soc_pcm_runtime *rtd = substream->private_data; + struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream); struct sdw_stream_runtime *sdw_stream; char *name; int ret; @@ -1814,7 +1814,7 @@ EXPORT_SYMBOL(sdw_startup_stream); void sdw_shutdown_stream(void *sdw_substream) { struct snd_pcm_substream *substream = sdw_substream; - struct snd_soc_pcm_runtime *rtd = substream->private_data; + struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream); struct sdw_stream_runtime *sdw_stream; struct snd_soc_dai *dai; -- 2.34.1

2 2

Internal mic does not work on IdeaPad 3 Chromebook
by GitHub issues - opened 03 Mar '24

03 Mar '24

alsa-project/alsa-ucm-conf issue #397 was opened from abhi-deshpande: Device - IdeaPad 3 Chromebook (Octopus Lick) OS - Fedora 39 Card - sof-glkda7219max I recently converted my Chromebook to Chultrabook and installed latest Fedora on it. It seems that most of the audio stuff works, but the internal DMIC doesn't work. I read some previous issues and commits and found that this is due to the fact that the DMIC needs channel split as CRAS does. This was being implemented in #154 I guess. I am currently on lastest alsa-lib and alsa-ucm-conf. What could be missing ? Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/397 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0