March 2024 - Alsa-devel - mailman.alsa-project.org

[PATCH] amdtp-stream: Checking a variable for zero before dividing
by Andrey Shumilin 23 Mar '24

23 Mar '24

The step variable is initialized to zero. It changes in the loop, but if it doesn’t change it will remain zero. The patch added a variable check. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Andrey Shumilin <shum.sdl(a)nppct.ru> --- sound/firewire/amdtp-stream.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/firewire/amdtp-stream.c b/sound/firewire/amdtp-stream.c index c9f153f85ae6..b61aa30f43a9 100644 --- a/sound/firewire/amdtp-stream.c +++ b/sound/firewire/amdtp-stream.c @@ -168,7 +168,8 @@ static int apply_constraint_to_size(struct snd_pcm_hw_params *params, if (snd_interval_test(r, amdtp_rate_table[i])) step = max(step, amdtp_syt_intervals[i]); } - + if (step == 0) + return -EINVAL; t.min = roundup(s->min, step); t.max = rounddown(s->max, step); t.integer = 1; -- 2.30.2

1 0

Variable mclk-fs in ASoC audio cards?
by John Watts 22 Mar '24

22 Mar '24

Greetings fellow ALSAers :) Over the past month I have been working on a driver for the 8-channel TDM CS5368 audio codec. However I've run in to an interesting snag that seems to be an open problem. Let me explain. The audio codec generally runs at 8 channels of 32-bit data, so: MCLK = BCLK = LRCK * 256 However it is possible to read 4 or 2 channels instead: MCLK = BCLK = LRCK * 128 MCLK = BCLK = LRCK * 64 This trade-off allows avoiding high frequency clocking at the expense of a reduced channel count. From what I current see the way to indicate the multiplier here is using mclk-fs in the device tree, but this would mean effectively fixing the channel count in the device tree. I have searched around found someone has suggested mapping mclk-fs to rates here: https://lore.kernel.org/all/CAEnQRZDpJu27_pB=-ZYQjsNPC8eA4-Ur-36niT2hCosMWt… This functionality is somewhat adjacent to it, but I was wondering if it would be better to somehow factor dai-tdm-slot-* in to mclk-fs calculation. Perhaps mclk-fs could be divided by dai-tdm-slot-num then multiplied by slots? Has anyone hit this problem before? How did you solve it? John.

1 0

[PATCH] [RESEND] ASoC: amd: simplify soundwire dependencies for
by Vijendar Mukunda 22 Mar '24

22 Mar '24

The CONFIG_SOUNDWIRE_AMD is a user-visible option, it should be never selected by another driver. So replace the extra complexity with a normal Kconfig dependency in SND_SOC_AMD_SOUNDWIRE. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda(a)amd.com> --- sound/soc/amd/Kconfig | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig index fa74635cee08..3508f5a96b75 100644 --- a/sound/soc/amd/Kconfig +++ b/sound/soc/amd/Kconfig @@ -134,15 +134,14 @@ config SND_SOC_AMD_RPL_ACP6x config SND_SOC_AMD_SOUNDWIRE_LINK_BASELINE tristate - select SOUNDWIRE_AMD if SND_SOC_AMD_SOUNDWIRE != n select SND_AMD_SOUNDWIRE_ACPI if ACPI config SND_SOC_AMD_SOUNDWIRE tristate "Support for SoundWire based AMD platforms" default SND_SOC_AMD_SOUNDWIRE_LINK_BASELINE depends on SND_SOC_AMD_SOUNDWIRE_LINK_BASELINE - depends on ACPI && SOUNDWIRE - depends on !(SOUNDWIRE=m && SND_SOC_AMD_SOUNDWIRE_LINK_BASELINE=y) + depends on ACPI + depends on SOUNDWIRE_AMD help This adds support for SoundWire for AMD platforms. Say Y if you want to enable SoundWire links with SOF. -- 2.34.1

2 1

[GIT PULL] ASoC fixes for v6.9-merge-window
by Mark Brown 21 Mar '24

21 Mar '24

The following changes since commit e8f897f4afef0031fe618a8e94127a0934896aba: Linux 6.8 (2024-03-10 13:38:09 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-fix-v6.9-merge-window for you to fetch changes up to 9a8b202f8cb7ebebc71f1f2a353a21c76d3063a8: ASoC: soc-compress: Fix and add DPCM locking (2024-03-18 14:41:51 +0000) ---------------------------------------------------------------- ASoC: Fixes for v6.9 A bunch of fixes that came in during the merge window, probably the most substantial thing is the DPCM locking fix for compressed audio which has been lurking for a while. ---------------------------------------------------------------- Chancel Liu (1): ASoC: soc-core.c: Skip dummy codec when adding platforms Cristian Ciocaltea (2): ASoC: SOF: amd: Move signed_fw_image to struct acp_quirk_entry ASoC: SOF: amd: Skip IRAM/DRAM size modification for Steam Deck OLED Jiawei Wang (2): ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" ASoC: amd: yc: Revert "add new YC platform variant (0x63) support" Luca Ceresoli (1): ASoC: rockchip: i2s-tdm: Fix inaccurate sampling rates M Cooley (1): ASoC: amd: yc: Fix non-functional mic on ASUS M7600RE Mark Brown (3): ASoC: Merge up release Add support for the internal RK3308 audio codec ASoC: SOF: amd: Skip IRAM/DRAM size modification Rob Herring (1): ASoC: dt-bindings: cirrus,cs42l43: Fix 'gpio-ranges' schema Shalini Manjunatha (1): ASoC: soc-compress: Fix and add DPCM locking Uwe Kleine-König (1): ASoC: tlv320adc3xxx: Don't strip remove function when driver is builtin .../ABI/testing/sysfs-bus-pci-devices-avs | 8 + .../bindings/sound/atmel,asoc-wm8904.yaml | 84 + .../bindings/sound/atmel,sam9x5-wm8731-audio.yaml | 76 + .../bindings/sound/atmel,sama5d2-classd.yaml | 7 +- .../bindings/sound/atmel-sam9x5-wm8731-audio.txt | 35 - .../devicetree/bindings/sound/atmel-wm8904.txt | 55 - .../bindings/sound/audio-graph-port.yaml | 2 +- .../devicetree/bindings/sound/cirrus,cs35l45.yaml | 3 + .../devicetree/bindings/sound/cirrus,cs42l43.yaml | 11 +- .../devicetree/bindings/sound/everest,es8326.yaml | 8 +- .../devicetree/bindings/sound/fsl,asrc.txt | 80 - .../devicetree/bindings/sound/fsl,easrc.yaml | 4 +- .../devicetree/bindings/sound/fsl,imx-asrc.yaml | 162 + .../devicetree/bindings/sound/fsl,micfil.yaml | 14 +- .../devicetree/bindings/sound/fsl,sai.yaml | 6 + .../bindings/sound/infineon,peb2466.yaml | 2 +- .../bindings/sound/microchip,sama7g5-i2smcc.yaml | 11 +- .../devicetree/bindings/sound/qcom,sm8250.yaml | 2 +- .../devicetree/bindings/sound/qcom,wcd938x.yaml | 81 +- .../bindings/sound/qcom,wcd939x-sdw.yaml | 69 + .../devicetree/bindings/sound/qcom,wcd939x.yaml | 96 + .../bindings/sound/qcom,wcd93xx-common.yaml | 95 + .../devicetree/bindings/sound/qcom,wsa8840.yaml | 11 +- .../devicetree/bindings/sound/realtek,rt1015.yaml | 41 + Documentation/devicetree/bindings/sound/rt1015.txt | 23 - .../devicetree/bindings/sound/samsung,tm2.yaml | 7 +- drivers/firmware/cirrus/cs_dsp.c | 7 +- drivers/soundwire/Makefile | 2 +- drivers/soundwire/amd_init.c | 235 ++ drivers/soundwire/amd_init.h | 13 + drivers/soundwire/amd_manager.c | 47 +- drivers/soundwire/amd_manager.h | 16 +- drivers/soundwire/dmi-quirks.c | 8 + include/linux/firmware/cirrus/cs_dsp.h | 1 - include/linux/soundwire/sdw_amd.h | 83 +- include/linux/spi/spi.h | 2 - include/sound/cs-amp-lib.h | 66 + include/sound/cs35l56.h | 10 + include/sound/cs42l42.h | 5 +- include/sound/hda-mlink.h | 2 +- include/sound/hda_register.h | 2 + include/sound/soc.h | 4 +- include/sound/sof/dai-amd.h | 7 + include/sound/sof/dai.h | 2 + include/sound/tas2781.h | 1 - include/trace/events/asoc.h | 45 +- include/uapi/sound/intel/avs/tokens.h | 9 + include/uapi/sound/sof/tokens.h | 4 + sound/pci/hda/Kconfig | 2 + sound/pci/hda/cs35l56_hda.c | 39 +- sound/pci/hda/tas2781_hda_i2c.c | 12 - sound/soc/amd/Kconfig | 17 + sound/soc/amd/Makefile | 2 +- sound/soc/amd/acp/Kconfig | 7 + sound/soc/amd/acp/Makefile | 2 + sound/soc/amd/acp/acp-mach-common.c | 6 +- sound/soc/amd/acp/acp-sof-mach.c | 26 +- sound/soc/amd/acp/amd-sdw-acpi.c | 62 + sound/soc/amd/ps/Makefile | 2 +- sound/soc/amd/ps/acp63.h | 91 +- sound/soc/amd/ps/pci-ps.c | 565 +-- sound/soc/amd/ps/ps-mach.c | 2 +- sound/soc/amd/ps/ps-pdm-dma.c | 2 +- sound/soc/amd/ps/ps-sdw-dma.c | 2 +- sound/soc/amd/yc/acp6x-mach.c | 14 +- sound/soc/amd/yc/pci-acp6x.c | 1 - sound/soc/atmel/mikroe-proto.c | 8 +- sound/soc/codecs/Kconfig | 55 +- sound/soc/codecs/Makefile | 13 + sound/soc/codecs/cs-amp-lib-test.c | 709 ++++ sound/soc/codecs/cs-amp-lib.c | 277 ++ sound/soc/codecs/cs35l56-sdw.c | 20 + sound/soc/codecs/cs35l56-shared.c | 84 + sound/soc/codecs/cs35l56.c | 44 +- sound/soc/codecs/cs42l42.c | 1 - sound/soc/codecs/cs42l43-jack.c | 27 +- sound/soc/codecs/cs42l43-sdw.c | 1 + sound/soc/codecs/cs42l43.c | 82 +- sound/soc/codecs/cs42l43.h | 21 +- sound/soc/codecs/da7213.c | 12 +- sound/soc/codecs/es8326.c | 110 +- sound/soc/codecs/es8326.h | 5 +- sound/soc/codecs/framer-codec.c | 413 +++ sound/soc/codecs/lpass-macro-common.h | 7 + sound/soc/codecs/lpass-tx-macro.c | 693 +++- sound/soc/codecs/lpass-va-macro.c | 57 + sound/soc/codecs/max98363.c | 2 +- sound/soc/codecs/max98373-sdw.c | 2 +- sound/soc/codecs/nau8540.c | 116 +- sound/soc/codecs/nau8540.h | 13 +- sound/soc/codecs/nau8825.c | 12 +- sound/soc/codecs/rt1017-sdca-sdw.c | 2 +- sound/soc/codecs/rt274.c | 2 +- sound/soc/codecs/rt286.c | 2 +- sound/soc/codecs/rt298.c | 2 +- sound/soc/codecs/rt5514-spi.c | 2 +- sound/soc/codecs/rt5514.c | 9 +- sound/soc/codecs/rt5616.c | 9 +- sound/soc/codecs/rt5640.c | 9 +- sound/soc/codecs/rt5645.c | 2 +- sound/soc/codecs/rt5651.c | 2 +- sound/soc/codecs/rt5659.c | 2 +- sound/soc/codecs/rt5660.c | 9 +- sound/soc/codecs/rt5663.c | 2 +- sound/soc/codecs/rt5665.c | 2 +- sound/soc/codecs/rt5668.c | 2 +- sound/soc/codecs/rt5682-i2c.c | 2 +- sound/soc/codecs/rt5682s.c | 2 +- sound/soc/codecs/rt712-sdca-dmic.c | 2 +- sound/soc/codecs/rt712-sdca-sdw.c | 2 +- sound/soc/codecs/rt722-sdca-sdw.c | 2 +- sound/soc/codecs/tas2781-comlib.c | 1 - sound/soc/codecs/tas2781-fmwlib.c | 2 +- sound/soc/codecs/tlv320adc3xxx.c | 4 +- sound/soc/codecs/wcd-clsh-v2.h | 1 + sound/soc/codecs/wcd-mbhc-v2.c | 95 +- sound/soc/codecs/wcd-mbhc-v2.h | 3 + sound/soc/codecs/wcd939x-sdw.c | 1551 ++++++++ sound/soc/codecs/wcd939x.c | 3686 ++++++++++++++++++++ sound/soc/codecs/wcd939x.h | 989 ++++++ sound/soc/codecs/wm_adsp.c | 27 +- sound/soc/codecs/wm_adsp.h | 2 + sound/soc/codecs/wsa884x.c | 53 +- sound/soc/fsl/eukrea-tlv320.c | 8 +- sound/soc/fsl/fsl_sai.c | 13 + sound/soc/fsl/p1022_rdk.c | 33 +- sound/soc/intel/atom/sst/sst_ipc.c | 3 +- sound/soc/intel/avs/Makefile | 5 +- sound/soc/intel/avs/apl.c | 58 +- sound/soc/intel/avs/avs.h | 70 +- sound/soc/intel/avs/board_selection.c | 85 + sound/soc/intel/avs/cnl.c | 61 + sound/soc/intel/avs/core.c | 161 +- sound/soc/intel/avs/icl.c | 197 ++ sound/soc/intel/avs/ipc.c | 66 +- sound/soc/intel/avs/loader.c | 2 +- sound/soc/intel/avs/messages.c | 1 + sound/soc/intel/avs/messages.h | 38 +- sound/soc/intel/avs/path.c | 33 + sound/soc/intel/avs/pcm.c | 77 +- sound/soc/intel/avs/registers.h | 21 +- sound/soc/intel/avs/skl.c | 59 +- sound/soc/intel/avs/sysfs.c | 35 + sound/soc/intel/avs/tgl.c | 54 + sound/soc/intel/avs/topology.c | 164 +- sound/soc/intel/avs/topology.h | 13 + sound/soc/intel/boards/Kconfig | 1 + sound/soc/intel/boards/sof_board_helpers.c | 249 +- sound/soc/intel/boards/sof_board_helpers.h | 29 + sound/soc/intel/boards/sof_cs42l42.c | 236 +- sound/soc/intel/boards/sof_rt5682.c | 151 +- sound/soc/intel/boards/sof_sdw.c | 106 +- sound/soc/intel/boards/sof_sdw_common.h | 82 +- sound/soc/intel/boards/sof_sdw_cs42l42.c | 35 +- sound/soc/intel/boards/sof_sdw_cs42l43.c | 25 +- sound/soc/intel/boards/sof_sdw_cs_amp.c | 3 +- sound/soc/intel/boards/sof_sdw_maxim.c | 4 +- sound/soc/intel/boards/sof_sdw_rt5682.c | 35 +- sound/soc/intel/boards/sof_sdw_rt700.c | 35 +- sound/soc/intel/boards/sof_sdw_rt711.c | 19 +- sound/soc/intel/boards/sof_sdw_rt712_sdca.c | 39 +- sound/soc/intel/boards/sof_sdw_rt715.c | 12 +- sound/soc/intel/boards/sof_sdw_rt715_sdca.c | 12 +- sound/soc/intel/boards/sof_sdw_rt_amp.c | 53 +- .../soc/intel/boards/sof_sdw_rt_sdca_jack_common.c | 19 +- sound/soc/intel/boards/sof_ssp_common.h | 8 + sound/soc/intel/catpt/dsp.c | 4 +- sound/soc/intel/common/soc-acpi-intel-adl-match.c | 12 +- sound/soc/intel/common/soc-acpi-intel-jsl-match.c | 10 +- sound/soc/intel/common/soc-acpi-intel-lnl-match.c | 102 + sound/soc/intel/common/soc-acpi-intel-mtl-match.c | 61 +- sound/soc/intel/common/soc-acpi-intel-rpl-match.c | 4 +- sound/soc/intel/common/soc-acpi-intel-tgl-match.c | 6 +- sound/soc/meson/aiu.c | 19 +- sound/soc/meson/aiu.h | 1 - sound/soc/meson/axg-fifo.c | 25 +- sound/soc/meson/axg-fifo.h | 14 +- sound/soc/meson/axg-frddr.c | 13 +- sound/soc/meson/axg-spdifin.c | 6 +- sound/soc/meson/axg-tdm-interface.c | 31 +- sound/soc/meson/axg-toddr.c | 30 +- sound/soc/meson/t9015.c | 20 +- sound/soc/pxa/Kconfig | 3 - sound/soc/qcom/common.c | 2 +- sound/soc/rockchip/rockchip_i2s_tdm.c | 352 +- sound/soc/sh/rz-ssi.c | 2 +- sound/soc/soc-compress.c | 4 + sound/soc/soc-core.c | 24 +- sound/soc/soc-dapm.c | 8 +- sound/soc/sof/amd/Kconfig | 18 + sound/soc/sof/amd/acp-common.c | 65 +- sound/soc/sof/amd/acp-dsp-offset.h | 10 + sound/soc/sof/amd/acp-loader.c | 34 +- sound/soc/sof/amd/acp.c | 252 +- sound/soc/sof/amd/acp.h | 33 +- sound/soc/sof/amd/pci-acp63.c | 7 + sound/soc/sof/amd/vangogh.c | 9 +- sound/soc/sof/core.c | 10 + sound/soc/sof/debug.c | 8 +- sound/soc/sof/fw-file-profile.c | 18 +- sound/soc/sof/imx/imx8.c | 16 + sound/soc/sof/imx/imx8m.c | 10 + sound/soc/sof/imx/imx8ulp.c | 10 + sound/soc/sof/intel/hda-common-ops.c | 1 + sound/soc/sof/intel/hda-dai-ops.c | 51 +- sound/soc/sof/intel/hda-dai.c | 17 +- sound/soc/sof/intel/hda-dsp.c | 5 + sound/soc/sof/intel/hda-stream.c | 9 + sound/soc/sof/intel/hda.c | 80 +- sound/soc/sof/intel/hda.h | 5 + sound/soc/sof/intel/lnl.c | 24 +- sound/soc/sof/ipc3-loader.c | 2 + sound/soc/sof/ipc3-pcm.c | 25 + sound/soc/sof/ipc3-topology.c | 40 + sound/soc/sof/ipc4-pcm.c | 19 +- sound/soc/sof/ipc4-priv.h | 4 + sound/soc/sof/ipc4-topology.c | 28 +- sound/soc/sof/ops.h | 9 + sound/soc/sof/sof-audio.c | 8 +- sound/soc/sof/sof-audio.h | 2 + sound/soc/sof/sof-priv.h | 10 + sound/soc/sof/topology.c | 30 +- sound/soc/ti/j721e-evm.c | 4 +- sound/soc/ti/omap-hdmi.c | 10 +- 224 files changed, 13139 insertions(+), 2591 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-bus-pci-devices-avs create mode 100644 Documentation/devicetree/bindings/sound/atmel,asoc-wm8904.yaml create mode 100644 Documentation/devicetree/bindings/sound/atmel,sam9x5-wm8731-audio.yaml delete mode 100644 Documentation/devicetree/bindings/sound/atmel-sam9x5-wm8731-audio.txt delete mode 100644 Documentation/devicetree/bindings/sound/atmel-wm8904.txt delete mode 100644 Documentation/devicetree/bindings/sound/fsl,asrc.txt create mode 100644 Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd939x-sdw.yaml create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd939x.yaml create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd93xx-common.yaml create mode 100644 Documentation/devicetree/bindings/sound/realtek,rt1015.yaml delete mode 100644 Documentation/devicetree/bindings/sound/rt1015.txt create mode 100644 drivers/soundwire/amd_init.c create mode 100644 drivers/soundwire/amd_init.h create mode 100644 include/sound/cs-amp-lib.h create mode 100644 sound/soc/amd/acp/amd-sdw-acpi.c create mode 100644 sound/soc/codecs/cs-amp-lib-test.c create mode 100644 sound/soc/codecs/cs-amp-lib.c create mode 100644 sound/soc/codecs/framer-codec.c create mode 100644 sound/soc/codecs/wcd939x-sdw.c create mode 100644 sound/soc/codecs/wcd939x.c create mode 100644 sound/soc/codecs/wcd939x.h create mode 100644 sound/soc/intel/avs/cnl.c create mode 100644 sound/soc/intel/avs/icl.c create mode 100644 sound/soc/intel/avs/sysfs.c create mode 100644 sound/soc/intel/avs/tgl.c

1 0

synaptics hi-res audio usb device duplex, usb bandwidth issues
by Ian Malone 21 Mar '24

21 Mar '24

Hi, In short I have a USB to 3.5mm adapter which seems not to work in duplex mode on USB2.0 systems, possibly due to a bandwidth calculation bug. This is an evolution of an issue I previously posted on the users list with no luck. I have an Anker USB-C to 3.5mm audio dongle (lsusb: Conexant Systems (Rockwell), Inc. Hi-Res Audio) which I've used for some time on my phone (Android with USB-3.2). On trying to use it with an older T420 laptop recently with only USB-2.0 ports I discovered it will not work in duplex mode. Input-only and output-only profiles work (tested recording and playback with audacity), but with duplex no sound is recorded (Fedora 39, pipewire). This is easily reproduced by looking at the pavucontrol volume monitor for Output Devices, if I switch the device to Analog or Digital Input in configuration then the Input Devices level monitor for it shows activity if I speak into or tap the microphone. With duplex selected there is no activity, the level monitor bar may or may not display. I can switch between the two behaviours by changing the profile. Various applications such as Audacity and Zoom appear to hang when accessing this microphone with the duplex profile set. I've used pipewire configuration to force the format to 16LE only (playback and recording), but this has not helped. In dmesg this error appears when this happens (microphone opened, for example by pavucontrol): [ 294.825544] usb 1-1.1: cannot submit urb 0, error -28: not enough bandwidth (T420, Fedora 39, kernel 6.7.5) The T420 has USB 2 Type A ports, so a Type C to Type A adapter is needed, but the problem is not limited to the T420 laptop. On an older Samsung Tablet (Tab-A 2019, USB-2.0 Type C, kernel 4.4.177) I've been able to test using Google Meet. Although there are no errors or freezing observed, in headphone mode over USB the headphone microphone is not being used and the tablet uses its onboard microphone instead (although headphones are selected and playback is over the headphones). Again, I can record (via voice recorder) from the headset microphone, just no duplex. Trying google meet on my phone (USB3.2) I do get duplex over the USB-3.5 adapter. On a newer laptop with USB-3.2 and a mix of type A and C ports I also get duplex (F37, kernel 6.5.12), however dmesg shows even here not all is well, using the type A and C ports on the side: [ 9172.326602] usb 3-1: new full-speed USB device number 6 using xhci_hcd [ 9172.490169] usb 3-1: New USB device found, idVendor=0572, idProduct=1b08, bcdDevice= 0.10 [ 9172.490174] usb 3-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3 [ 9172.490177] usb 3-1: Product: Hi-Res Audio [ 9172.490178] usb 3-1: Manufacturer: Synaptics [ 9172.490180] usb 3-1: SerialNumber: 000000000000000000000000 [ 9172.683435] input: Synaptics Hi-Res Audio as /devices/pci0000:00/0000:00:08.1/0000:05:00.4/usb3/3-1/3-1:1.3/0003:0572:1B08.000A/input/input36 [ 9172.736025] hid-generic 0003:0572:1B08.000A: input,hidraw5: USB HID v1.11 Device [Synaptics Hi-Res Audio] on usb-0000:05:00.4-1/input3 [ 9173.386988] usb 3-1: Not enough bandwidth for new device state. [ 9173.386994] usb 3-1: Not enough bandwidth for altsetting 1 [ 9173.386996] endpoint_set_interface: 70 callbacks suppressed [ 9173.386998] usb 3-1: 1:1: usb_set_interface failed (-28) [ 9173.387110] usb 3-1: Not enough bandwidth for new device state. [ 9173.387113] usb 3-1: Not enough bandwidth for altsetting 1 (...these 3 lines repeat 9 more times, followed by...) [ 9173.388785] usb 3-1: Not enough bandwidth for new device state. [ 9173.388789] usb 3-1: Not enough bandwidth for altsetting 1 (...these 2 lines repeat 5 more times, then stop) This is a USB3.2 system, the onboard camera has a hardware switch, so I can disable it, and the only other peripheral that appears is the AX210 bluetooth (I'd thought that would have its own bus as it's part of a separate wifi chip, but apparently not, lsusb -t below), bandwidth for even a 96kHz 24bit duplex audio device shouldn't really be an issue. $ lsusb Bus 004 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub Bus 003 Device 003: ID 8087:0032 Intel Corp. AX210 Bluetooth Bus 003 Device 002: ID 048d:c965 Integrated Technology Express, Inc. ITE Device(8295) Bus 003 Device 007: ID 0572:1b08 Conexant Systems (Rockwell), Inc. Hi-Res Audio Bus 003 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub Bus 002 Device 002: ID 0bda:0411 Realtek Semiconductor Corp. Hub Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub Bus 001 Device 004: ID 048d:c101 Integrated Technology Express, Inc. ITE Device(8910) Bus 001 Device 002: ID 0bda:5411 Realtek Semiconductor Corp. RTS5411 Hub Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub $ lsusb -t /: Bus 04.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/2p, 10000M /: Bus 03.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/4p, 480M |__ Port 1: Dev 7, If 0, Class=Audio, Driver=snd-usb-audio, 12M |__ Port 1: Dev 7, If 1, Class=Audio, Driver=snd-usb-audio, 12M |__ Port 1: Dev 7, If 2, Class=Audio, Driver=snd-usb-audio, 12M |__ Port 1: Dev 7, If 3, Class=Human Interface Device, Driver=usbhid, 12M |__ Port 3: Dev 2, If 0, Class=Human Interface Device, Driver=usbhid, 12M |__ Port 3: Dev 2, If 1, Class=Human Interface Device, Driver=usbhid, 12M |__ Port 4: Dev 3, If 0, Class=Wireless, Driver=btusb, 12M |__ Port 4: Dev 3, If 1, Class=Wireless, Driver=btusb, 12M /: Bus 02.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/2p, 10000M |__ Port 2: Dev 2, If 0, Class=Hub, Driver=hub/4p, 5000M /: Bus 01.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/4p, 480M |__ Port 2: Dev 2, If 0, Class=Hub, Driver=hub/4p, 480M |__ Port 4: Dev 4, If 0, Class=Human Interface Device, Driver=usbhid, 12M The only situation in which I *don't* get these dmesg errors is if I use one of the rear USB 3.2 ports that seem to lead to it being on its own bus: $ lsusb -t /: Bus 04.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/2p, 10000M /: Bus 03.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/4p, 480M |__ Port 3: Dev 2, If 0, Class=Human Interface Device, Driver=usbhid, 12M |__ Port 3: Dev 2, If 1, Class=Human Interface Device, Driver=usbhid, 12M |__ Port 4: Dev 3, If 0, Class=Wireless, Driver=btusb, 12M |__ Port 4: Dev 3, If 1, Class=Wireless, Driver=btusb, 12M /: Bus 02.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/2p, 10000M |__ Port 2: Dev 2, If 0, Class=Hub, Driver=hub/4p, 5000M /: Bus 01.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/4p, 480M |__ Port 2: Dev 2, If 0, Class=Hub, Driver=hub/4p, 480M |__ Port 2: Dev 7, If 0, Class=Audio, Driver=snd-usb-audio, 12M |__ Port 2: Dev 7, If 1, Class=Audio, Driver=snd-usb-audio, 12M |__ Port 2: Dev 7, If 2, Class=Audio, Driver=snd-usb-audio, 12M |__ Port 2: Dev 7, If 3, Class=Human Interface Device, Driver=usbhid, 12M |__ Port 4: Dev 4, If 0, Class=Human Interface Device, Driver=usbhid, 12M In this case the dmesg output is clear after device connection. This seems like some kind of bandwidth calculation problem in snd_usb_audio. I've tried building a kernel and modifying various of the defines in sound/usb/card.h (currently MAX_PACKS 4 and MAX_PACKS_HS (MAX_PACKS * 4), compared to 6 and *8) but not hit on a winning formula yet. Is there any information I could collect to try to fix this? -- imalone

2 6

Internal speakers and headphone not working on Huawei notebook
by Jacek Blocki 20 Mar '24

20 Mar '24

Hello, I have Huawei notebook (KLVL-WXXW-PCB) with Ubuntu 22.04.3 LTS installed alongside Windows. In Ubuntu, neither internal speakers nor headphone jack work. I only see Dummy Output while trying to adjust volume, but sound works with external HDMI monitor. Internal speakers work with Windows, so I believe hardware is fine and kernel driver (snd_hda_intel?) needs to be modified to fix the problem. I have submitted Ubuntu bug report back in January, but nobody touched it. So I try this list hoping for better result. $ cat /proc/asound/cards 0 [Generic ]: HDA-Intel - HD-Audio Generic HD-Audio Generic at 0xd03c0000 irq 64 1 [acp ]: acp - acp HUAWEI-KLVL_WXXW-M1010-KLVL_WXXW_PCB I run 6.5.0-26-generic kernel. Regards, Jacek Błocki

1 0

[sound/soc/qcom] Question about memory allocation in asoc_qcom_lpass_cpu_platform_probe
by Zijie Zhao 20 Mar '24

20 Mar '24

Dear QCOM AUDIO maintainers, We encountered an usual usage of devm_kzalloc while performing a static analysis for kernel code. https://elixir.bootlin.com/linux/v6.8/source/sound/soc/qcom/lpass-cpu.c#L12… ``` int asoc_qcom_lpass_cpu_platform_probe(struct platform_device *pdev) { ... drvdata = devm_kzalloc(dev, sizeof(struct lpass_data), GFP_KERNEL); if (!drvdata) return -ENOMEM; ... /* Allocation for i2sctl regmap fields */ drvdata->i2sctl = devm_kzalloc(&pdev->dev, sizeof(struct lpaif_i2sctl), GFP_KERNEL); /* Initialize bitfields for dai I2SCTL register */ ret = lpass_cpu_init_i2sctl_bitfields(dev, drvdata->i2sctl, drvdata->lpaif_map); if (ret) { dev_err(dev, "error init i2sctl field: %d\n", ret); return ret; } ... } ``` ``` static int lpass_cpu_init_i2sctl_bitfields(struct device *dev, struct lpaif_i2sctl *i2sctl, struct regmap *map) { struct lpass_data *drvdata = dev_get_drvdata(dev); const struct lpass_variant *v = drvdata->variant; i2sctl->loopback = devm_regmap_field_alloc(dev, map, v->loopback); ... } ``` Here devm_kzalloc might return NULL for drvdata->i2sctl if out-of-memory. Then i2sctl->loopback will cause segfault since i2sctl is never checked against NULL. Would a NULL check needed here? Like the drvdata above. Please let us know if we missed any key information or assumption! We appreciate your time! Best, Zijie

1 0

[PATCH] ASoC: SOF: Remove libraries from topology lookups
by cujomalainey＠chromium.org 20 Mar '24

20 Mar '24

From: Curtis Malainey <cujomalainey(a)chromium.org> Default firmware shipped in open source are not licensed for 3P libraries, therefore topologies should not reference them. If a OS wants to use 3P (that they have licensed) then they should use the appropriate topology override mechanisms. Fixes: 8a7d5d85ed2161 ("ASoC: SOF: mediatek: mt8195: Add devicetree support to select topologies") Signed-off-by: Curtis Malainey <cujomalainey(a)chromium.org> Cc: Wojciech Macek <wmacek(a)google.com> --- sound/soc/sof/mediatek/mt8195/mt8195.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sof/mediatek/mt8195/mt8195.c b/sound/soc/sof/mediatek/mt8195/mt8195.c index 8ee7ee246344c..f143baf75af60 100644 --- a/sound/soc/sof/mediatek/mt8195/mt8195.c +++ b/sound/soc/sof/mediatek/mt8195/mt8195.c @@ -573,7 +573,7 @@ static struct snd_sof_dsp_ops sof_mt8195_ops = { static struct snd_sof_of_mach sof_mt8195_machs[] = { { .compatible = "google,tomato", - .sof_tplg_filename = "sof-mt8195-mt6359-rt1019-rt5682-dts.tplg" + .sof_tplg_filename = "sof-mt8195-mt6359-rt1019-rt5682.tplg" }, { .compatible = "mediatek,mt8195", .sof_tplg_filename = "sof-mt8195.tplg" -- 2.44.0.291.gc1ea87d7ee-goog

4 6

[PATCH 1/2] ASoC: codecs: ES8326: Reducing power consumption
by Zhang Yi 20 Mar '24

20 Mar '24

> > For lower power consumption during hibernation, the configuration of > > es8326_suspend and es8326_remove will be adjusted. > > Adding es8326_i2c_shutdown and es8326_i2c_remove to cover different > > situations > > > > Signed-off-by: Zhang Yi <zhangyi(a)everest-semi.com> > > --- > > sound/soc/codecs/es8326.c | 34 +++++++++++++++++++++++++++++++++- > > 1 file changed, 33 insertions(+), 1 deletion(-) > > > > diff --git a/sound/soc/codecs/es8326.c b/sound/soc/codecs/es8326.c > > index 15289dadafea..5c89323035a2 100755 > > --- a/sound/soc/codecs/es8326.c > > +++ b/sound/soc/codecs/es8326.c > > @@ -1072,12 +1072,13 @@ static int es8326_suspend(struct snd_soc_component *component) > > es8326->calibrated = false; > > regmap_write(es8326->regmap, ES8326_CLK_CTL, ES8326_CLK_OFF); > > regcache_cache_only(es8326->regmap, true); > > - regcache_mark_dirty(es8326->regmap); > > > > /* reset register value to default */ > > regmap_write(es8326->regmap, ES8326_CSM_I2C_STA, 0x01); > > usleep_range(1000, 3000); > > regmap_write(es8326->regmap, ES8326_CSM_I2C_STA, 0x00); > > + > > + regcache_mark_dirty(es8326->regmap); > > return 0; > > } > > > > @@ -1163,8 +1164,13 @@ static int es8326_set_jack(struct snd_soc_component *component, > > > > static void es8326_remove(struct snd_soc_component *component) > > { > > + struct es8326_priv *es8326 = snd_soc_component_get_drvdata(component); > > + > > es8326_disable_jack_detect(component); > > es8326_set_bias_level(component, SND_SOC_BIAS_OFF); > > + regmap_write(es8326->regmap, ES8326_CSM_I2C_STA, 0x01); > > + usleep_range(1000, 3000); > > + regmap_write(es8326->regmap, ES8326_CSM_I2C_STA, 0x00); > > } > > > > static const struct snd_soc_component_driver soc_component_dev_es8326 = { > > @@ -1236,6 +1242,30 @@ static int es8326_i2c_probe(struct i2c_client *i2c) > > &es8326_dai, 1); > > } > > > > + > > +static void es8326_i2c_shutdown(struct i2c_client *i2c) > > +{ > > + struct snd_soc_component *component; > > + struct es8326_priv *es8326; > > + > > + dev_dbg(component->dev, "Enter into %s\n", __func__); > Above line works on unset pointer, you need to set component before > dereferencing it. > > + es8326 = i2c_get_clientdata(i2c); > > + component = es8326->component; > > + cancel_delayed_work_sync(&es8326->jack_detect_work); > > + cancel_delayed_work_sync(&es8326->button_press_work); > > + > > + regmap_write(es8326->regmap, ES8326_CSM_I2C_STA, 0x01); > > + usleep_range(1000, 3000); > > + regmap_write(es8326->regmap, ES8326_CSM_I2C_STA, 0x00); > > + > > + return; > > +} > > + > > +static void es8326_i2c_remove(struct i2c_client *i2c) > > +{ > > + es8326_i2c_shutdown(i2c); > > +} > > + > > static const struct i2c_device_id es8326_i2c_id[] = { > > {"es8326", 0 }, > > {} > > @@ -1265,6 +1295,8 @@ static struct i2c_driver es8326_i2c_driver = { > > .of_match_table = of_match_ptr(es8326_of_match), > > }, > > .probe = es8326_i2c_probe, > > + .shutdown = es8326_i2c_shutdown, > > + .remove = es8326_i2c_remove, > > .id_table = es8326_i2c_id, > > }; > > module_i2c_driver(es8326_i2c_driver); I'm sorry. I'll fix my mistake.

1 0

[PATCH 0/2] ASoC: codecs: ES8326: Reducin powerconsumption and
by Zhang Yi 20 Mar '24

20 Mar '24

We changed the configuration related to hibernation. and delete the REG_SUPPLY to cover mute issue. Zhang Yi (2): ASoC: codecs: ES8326: Reducing power consumption ASoC: codecs: ES8326: Delete unused REG_SUPPLY sound/soc/codecs/es8326.c | 42 ++++++++++++++++++++++++++++++--------- 1 file changed, 33 insertions(+), 9 deletions(-) -- 2.17.1

1 0