February 2024 - Alsa-devel - mailman.alsa-project.org

(no subject)
by Takashi Iwai 19 Feb '24

19 Feb '24

Linux regressions mailing list <regressions(a)lists.linux.dev> Subject: Re: [REGRESSION] Acp5x probing regression introduced between kernel 6.7.2 -> 6.7.4 In-Reply-To: <7a0cd63f-8a83-4dc5-8763-63dcdae8d68a(a)leemhuis.info> References: <CAD_nV8BG0t7US=+C28kQOR==712MPfZ9m-fuKksgoZCgrEByCw(a)mail.gmail.com> <7a0cd63f-8a83-4dc5-8763-63dcdae8d68a(a)leemhuis.info> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 On Sun, 11 Feb 2024 18:19:25 +0100, Linux regression tracking (Thorsten Leemhuis) wrote: > > [CCing a few people] > > On 11.02.24 15:34, Ted Chang wrote: > > > > I noticed 6.7.4 has introduced a regression for the steam deck. The LCD > > steam deck can no longer probe the acp5x audio chipset anymore. This > > regression does not affect the 6.8.x series. I did not test kernel > > 6.7.3 because Opensuse tumbleweed skipped the update on my machine. > > Thx for your report. FWIW, problems like this can be caused by all > sorts of changes, but obviously those in the area of audio support > are most likely to cause this. There are just a few in the > v6.7.2..v6.7.4 range[1]. Among them a commit that is related to > acp5x, that's why I CCed its author as well (Venkata Prasad Potturu). > > Maybe one of the new recipients will have an idea. If not, you most > likely will have to bisect this and check if mainline is affected > as well.[2] > > Ciao, Thorsten > > [1] > $ git log --oneline v6.7.2..v6.7.4 sound/ > f3570675bf09af ASoC: codecs: wsa883x: fix PA volume control > 2f8e9b77ca2fea ASoC: codecs: lpass-wsa-macro: fix compander volume hack > 5b465d6384e4eb ASoC: codecs: wcd938x: fix headphones volume controls > 1673211a38012e ASoC: qcom: sc8280xp: limit speaker volumes > 242b5bffa23a9c ASoC: codecs: rtq9128: Fix TDM enable and DAI format control flow > 2c272ff9859601 ASoC: codecs: rtq9128: Fix PM_RUNTIME usage > 4a28302b2c681e ALSA: hda/conexant: Fix headset auto detect fail in cx8070 and SN6140 > e37a96941fdd53 ALSA: hda: intel-dspcfg: add filters for ARL-S and ARL > ffa3eea886c6fe ALSA: hda: Intel: add HDA_ARL PCI ID support > 4b6986b170f2f2 ASoC: amd: Add new dmi entries for acp5x platform This one is the only relevant change, I suppose. The machine matches with 'Valve Jupiter'. Interestingly, the system seems working with 6.8-rc3, so some piece might be missing. Or simply reverting this patch should fix. Takashi > e38ad4ace20b4d ALSA: hda: Refer to correct stream index at loops > a434c75e0671f9 soundwire: fix initializing sysfs for same devices on different buses > > [2] I'm working on a guide that describes what's needed: > https://www.leemhuis.info/files/misc/How%20to%20bisect%20a%20Linux%20kernel… > > > Steps to reproduce the problem > > 1. Obtain a steam deck > > 2. Install kernel 6.7.4 > > 3. Boot the device and you will see dummy output in gnome shell > > > > Observed kernel logs. > > > > [ 8.755614] cs35l41 spi-VLV1776:00: supply VA not found, using dummy regulator > > [ 8.760506] cs35l41 spi-VLV1776:00: supply VP not found, using dummy regulator > > [ 8.777148] cs35l41 spi-VLV1776:00: Cirrus Logic CS35L41 (35a40), Revision: B2 > > [ 8.777471] cs35l41 spi-VLV1776:01: supply VA not found, using dummy regulator > > [ 8.777532] cs35l41 spi-VLV1776:01: supply VP not found, using dummy regulator > > [ 8.777709] cs35l41 spi-VLV1776:01: Reset line busy, assuming shared reset > > [ 8.788465] cs35l41 spi-VLV1776:01: Cirrus Logic CS35L41 (35a40), Revision: B2 > > [ 8.877280] snd_hda_intel 0000:04:00.1: enabling device (0000 -> 0002) > > [ 8.877595] snd_hda_intel 0000:04:00.1: Handle vga_switcheroo audio client > > [ 8.889913] snd_acp_pci 0000:04:00.5: enabling device (0000 -> 0002) > > [ 8.890063] snd_acp_pci 0000:04:00.5: Unsupported device revision:0x50 > > [ 8.890129] snd_acp_pci: probe of 0000:04:00.5 failed with error -22 > > [ 8.906136] snd_hda_intel 0000:04:00.1: bound 0000:04:00.0 (ops amdgpu_dm_audio_component_bind_ops [amdgpu] > > > > > > No kernel module in use shown. > > > > 04:00.5 Multimedia controller [0480]: Advanced Micro Devices, Inc. [AMD] > > ACP/ACP3X/ACP6x Audio Coprocessor [1022:15e2] (rev 50) > > Subsystem: Valve Software Device [1e44:1776] > > Flags: fast devsel, IRQ 70, IOMMU group 4 > > Memory at 80380000 (32-bit, non-prefetchable) [size=256K] > > Capabilities: <access denied> > > Kernel modules: snd_pci_acp3x, snd_rn_pci_acp3x, snd_pci_acp5x, > > snd_pci_acp6x, snd_acp_pci, snd_rpl_pci_acp6x, snd_pci_ps, > > snd_sof_amd_renoir, snd_sof_amd_rembrandt, snd_sof_amd_vangogh, > > snd_sof_amd_acp63 > > > > > > Information for package kernel-default: > > --------------------------------------- > > Repository : openSUSE-Tumbleweed-Oss > > Name : kernel-default > > Version : 6.7.4-1.1 > > Arch : x86_64 > > Vendor : openSUSE > > Installed Size : 240.3 MiB > > Installed : Yes > > Status : up-to-date > > Source package : kernel-default-6.7.4-1.1.nosrc > > Upstream URL : https://www.kernel.org/ <https://www.kernel.org/> > > Summary : The Standard Kernel > > Description : > > The standard kernel for both uniprocessor and multiprocessor systems. > > > > > > Source Timestamp: 2024-02-06 05:32:37 +0000 > > GIT Revision: 01735a3e65287585dd830a6a3d33d909a4f9ae7f > > GIT Branch: stable > > > > Handle 0x0000, DMI type 0, 26 bytes > > BIOS Information > > Vendor: Valve > > Version: F7A0120 > > Release Date: 12/01/2023 > > Address: 0xE0000 > > Runtime Size: 128 kB > > BIOS Revision: 1.20 > > Firmware Revision: 1.16 > > > > #regzbot introduced: v6.7.2..v6.7.4 > >

3 5

[PATCH] ALSA: firewire-lib: fix to check cycle continuity
by Takashi Sakamoto 19 Feb '24

19 Feb '24

The local helper function to compare the given pair of cycle count evaluates them. If the left value is less than the right value, the function returns negative value. If the safe cycle is less than the current cycle, it is the case of cycle lost. However, it is not currently handled properly. This commit fixes the bug. Cc: <stable(a)vger.kernel.org> Fixes: 705794c53b00 ("ALSA: firewire-lib: check cycle continuity") Signed-off-by: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> --- sound/firewire/amdtp-stream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/firewire/amdtp-stream.c b/sound/firewire/amdtp-stream.c index a13c0b408aad..7be17bca257f 100644 --- a/sound/firewire/amdtp-stream.c +++ b/sound/firewire/amdtp-stream.c @@ -951,7 +951,7 @@ static int generate_tx_packet_descs(struct amdtp_stream *s, struct pkt_desc *des // to the reason. unsigned int safe_cycle = increment_ohci_cycle_count(next_cycle, IR_JUMBO_PAYLOAD_MAX_SKIP_CYCLES); - lost = (compare_ohci_cycle_count(safe_cycle, cycle) > 0); + lost = (compare_ohci_cycle_count(safe_cycle, cycle) < 0); } if (lost) { dev_err(&s->unit->device, "Detect discontinuity of cycle: %d %d\n", -- 2.40.1

2 1

[PATCH 0/4] ALSA: oxfw: add support for Miglia Harmony Audio
by Takashi Sakamoto 19 Feb '24

19 Feb '24

Hi, There used to be a company called Miglia Technologies Ltd. in the UK, and the company was selling a product called Harmony Audio in 2004. Upon obtaining the product by chance recently and examining its internals, it was revealed that it utilizes Oxford Semiconductor OXFW970 for its communication function in IEEE 1394 bus. This patchset adds support for the model. Takashi Sakamoto (4): ALSA: oxfw: use const qualifier for immutable argument ALSA: oxfw: support the case that AV/C Stream Format Information command is not available ALSA: firewire-lib: handle quirk to calculate payload quadlets as data block counter ALSA: oxfw: add support for Miglia Harmony Audio sound/firewire/amdtp-stream.c | 12 ++-- sound/firewire/amdtp-stream.h | 4 ++ sound/firewire/oxfw/oxfw-stream.c | 100 +++++++++++++++++++++++------- sound/firewire/oxfw/oxfw.c | 10 ++- sound/firewire/oxfw/oxfw.h | 7 ++- 5 files changed, 103 insertions(+), 30 deletions(-) -- 2.40.1

2 5

[PATCH] clk: constify the of_phandle_args argument of of_clk_provider
by Krzysztof Kozlowski 19 Feb '24

19 Feb '24

None of the implementations of the get() and get_hw() callbacks of "struct of_clk_provider" modify the contents of received of_phandle_args pointer. They treat it as read-only variable used to find the clock to return. Make obvious that implementations are not supposed to modify the of_phandle_args, by making it a pointer to const. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> --- drivers/clk/at91/pmc.c | 3 +- drivers/clk/at91/pmc.h | 3 +- drivers/clk/baikal-t1/clk-ccu-div.c | 2 +- drivers/clk/baikal-t1/clk-ccu-pll.c | 2 +- drivers/clk/bcm/clk-kona-setup.c | 2 +- drivers/clk/clk-axm5516.c | 2 +- drivers/clk/clk-cdce706.c | 2 +- drivers/clk/clk-cdce925.c | 2 +- drivers/clk/clk-k210.c | 2 +- drivers/clk/clk-lochnagar.c | 2 +- drivers/clk/clk-max77686.c | 2 +- drivers/clk/clk-max9485.c | 2 +- drivers/clk/clk-qoriq.c | 3 +- drivers/clk/clk-renesas-pcie.c | 2 +- drivers/clk/clk-rk808.c | 2 +- drivers/clk/clk-scpi.c | 2 +- drivers/clk/clk-si521xx.c | 2 +- drivers/clk/clk-si5341.c | 2 +- drivers/clk/clk-si5351.c | 4 +-- drivers/clk/clk-sparx5.c | 3 +- drivers/clk/clk-stm32f4.c | 2 +- drivers/clk/clk-versaclock3.c | 2 +- drivers/clk/clk-versaclock5.c | 2 +- drivers/clk/clk-versaclock7.c | 2 +- drivers/clk/clk.c | 30 ++++++++++--------- drivers/clk/hisilicon/clk-hi3660-stub.c | 2 +- drivers/clk/imx/clk-imx8qxp-lpcg.c | 2 +- drivers/clk/imx/clk-scu.c | 2 +- drivers/clk/imx/clk-scu.h | 2 +- drivers/clk/keystone/sci-clk.c | 3 +- drivers/clk/meson/meson-clkc-utils.c | 3 +- drivers/clk/meson/meson-clkc-utils.h | 3 +- drivers/clk/mvebu/common.c | 2 +- drivers/clk/mvebu/cp110-system-controller.c | 2 +- drivers/clk/mvebu/kirkwood.c | 2 +- drivers/clk/nxp/clk-lpc18xx-ccu.c | 2 +- drivers/clk/qcom/clk-rpm.c | 2 +- drivers/clk/qcom/clk-rpmh.c | 2 +- drivers/clk/qcom/clk-smd-rpm.c | 2 +- drivers/clk/qcom/clk-spmi-pmic-div.c | 2 +- drivers/clk/qcom/common.c | 2 +- drivers/clk/qcom/krait-cc.c | 2 +- drivers/clk/renesas/r9a06g032-clocks.c | 2 +- drivers/clk/renesas/renesas-cpg-mssr.c | 2 +- drivers/clk/renesas/rzg2l-cpg.c | 2 +- .../clk/starfive/clk-starfive-jh7100-audio.c | 3 +- drivers/clk/starfive/clk-starfive-jh7100.c | 3 +- .../clk/starfive/clk-starfive-jh7110-aon.c | 3 +- .../clk/starfive/clk-starfive-jh7110-isp.c | 3 +- .../clk/starfive/clk-starfive-jh7110-pll.c | 3 +- .../clk/starfive/clk-starfive-jh7110-stg.c | 3 +- .../clk/starfive/clk-starfive-jh7110-sys.c | 3 +- .../clk/starfive/clk-starfive-jh7110-vout.c | 3 +- drivers/clk/tegra/clk-bpmp.c | 2 +- drivers/clk/tegra/clk-tegra124.c | 2 +- drivers/clk/tegra/clk-tegra20.c | 2 +- drivers/clk/tegra/clk-tegra30.c | 2 +- drivers/clk/ti/clkctrl.c | 2 +- drivers/clk/ux500/u8500_of_clk.c | 4 +-- drivers/clk/versatile/clk-sp810.c | 2 +- drivers/media/platform/ti/omap3isp/isp.c | 3 +- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 6 ++-- include/linux/clk-provider.h | 28 ++++++++--------- include/linux/clk.h | 4 +-- sound/soc/qcom/qdsp6/q6dsp-lpass-clocks.c | 2 +- 65 files changed, 115 insertions(+), 95 deletions(-) diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c index 5aa9c1f1c886..64ec624ffc15 100644 --- a/drivers/clk/at91/pmc.c +++ b/drivers/clk/at91/pmc.c @@ -44,7 +44,8 @@ int of_at91_get_clk_range(struct device_node *np, const char *propname, } EXPORT_SYMBOL_GPL(of_at91_get_clk_range); -struct clk_hw *of_clk_hw_pmc_get(struct of_phandle_args *clkspec, void *data) +struct clk_hw *of_clk_hw_pmc_get(const struct of_phandle_args *clkspec, + void *data) { unsigned int type = clkspec->args[0]; unsigned int idx = clkspec->args[1]; diff --git a/drivers/clk/at91/pmc.h b/drivers/clk/at91/pmc.h index 0f52e80bcd49..09ae26d0cece 100644 --- a/drivers/clk/at91/pmc.h +++ b/drivers/clk/at91/pmc.h @@ -126,7 +126,8 @@ struct pmc_data *pmc_data_allocate(unsigned int ncore, unsigned int nsystem, int of_at91_get_clk_range(struct device_node *np, const char *propname, struct clk_range *range); -struct clk_hw *of_clk_hw_pmc_get(struct of_phandle_args *clkspec, void *data); +struct clk_hw *of_clk_hw_pmc_get(const struct of_phandle_args *clkspec, + void *data); struct clk_hw * __init at91_clk_register_audio_pll_frac(struct regmap *regmap, const char *name, diff --git a/drivers/clk/baikal-t1/clk-ccu-div.c b/drivers/clk/baikal-t1/clk-ccu-div.c index 84555a00f950..97ea3d747a78 100644 --- a/drivers/clk/baikal-t1/clk-ccu-div.c +++ b/drivers/clk/baikal-t1/clk-ccu-div.c @@ -322,7 +322,7 @@ static int ccu_div_find_sys_regs(struct ccu_div_data *data) return 0; } -static struct clk_hw *ccu_div_of_clk_hw_get(struct of_phandle_args *clkspec, +static struct clk_hw *ccu_div_of_clk_hw_get(const struct of_phandle_args *clkspec, void *priv) { struct ccu_div_data *data = priv; diff --git a/drivers/clk/baikal-t1/clk-ccu-pll.c b/drivers/clk/baikal-t1/clk-ccu-pll.c index fce02ce77347..0e71d5967794 100644 --- a/drivers/clk/baikal-t1/clk-ccu-pll.c +++ b/drivers/clk/baikal-t1/clk-ccu-pll.c @@ -126,7 +126,7 @@ static int ccu_pll_find_sys_regs(struct ccu_pll_data *data) return 0; } -static struct clk_hw *ccu_pll_of_clk_hw_get(struct of_phandle_args *clkspec, +static struct clk_hw *ccu_pll_of_clk_hw_get(const struct of_phandle_args *clkspec, void *priv) { struct ccu_pll_data *data = priv; diff --git a/drivers/clk/bcm/clk-kona-setup.c b/drivers/clk/bcm/clk-kona-setup.c index 338558f6fbae..1149bcd7617f 100644 --- a/drivers/clk/bcm/clk-kona-setup.c +++ b/drivers/clk/bcm/clk-kona-setup.c @@ -773,7 +773,7 @@ static bool ccu_data_valid(struct ccu_data *ccu) } static struct clk_hw * -of_clk_kona_onecell_get(struct of_phandle_args *clkspec, void *data) +of_clk_kona_onecell_get(const struct of_phandle_args *clkspec, void *data) { struct ccu_data *ccu = data; unsigned int idx = clkspec->args[0]; diff --git a/drivers/clk/clk-axm5516.c b/drivers/clk/clk-axm5516.c index 4a3462ee8f3e..458f44f4c08e 100644 --- a/drivers/clk/clk-axm5516.c +++ b/drivers/clk/clk-axm5516.c @@ -512,7 +512,7 @@ static struct axxia_clk *axmclk_clocks[] = { }; static struct clk_hw * -of_clk_axmclk_get(struct of_phandle_args *clkspec, void *unused) +of_clk_axmclk_get(const struct of_phandle_args *clkspec, void *unused) { unsigned int idx = clkspec->args[0]; diff --git a/drivers/clk/clk-cdce706.c b/drivers/clk/clk-cdce706.c index dd3d42d9ad86..1db9fc5d2af7 100644 --- a/drivers/clk/clk-cdce706.c +++ b/drivers/clk/clk-cdce706.c @@ -618,7 +618,7 @@ static int cdce706_register_clkouts(struct cdce706_dev_data *cdce) } static struct clk_hw * -of_clk_cdce_get(struct of_phandle_args *clkspec, void *data) +of_clk_cdce_get(const struct of_phandle_args *clkspec, void *data) { struct cdce706_dev_data *cdce = data; unsigned int idx = clkspec->args[0]; diff --git a/drivers/clk/clk-cdce925.c b/drivers/clk/clk-cdce925.c index b0122093c6ff..48135ee578c5 100644 --- a/drivers/clk/clk-cdce925.c +++ b/drivers/clk/clk-cdce925.c @@ -576,7 +576,7 @@ static int cdce925_regmap_i2c_read(void *context, } static struct clk_hw * -of_clk_cdce925_get(struct of_phandle_args *clkspec, void *_data) +of_clk_cdce925_get(const struct of_phandle_args *clkspec, void *_data) { struct clk_cdce925_chip *data = _data; unsigned int idx = clkspec->args[0]; diff --git a/drivers/clk/clk-k210.c b/drivers/clk/clk-k210.c index 7b7329a907ab..2333ed3ed7a2 100644 --- a/drivers/clk/clk-k210.c +++ b/drivers/clk/clk-k210.c @@ -875,7 +875,7 @@ static inline void __init k210_register_clk_child(struct device_node *np, k210_register_clk(np, ksc, id, &parent_data, 1, 0); } -static struct clk_hw *k210_clk_hw_onecell_get(struct of_phandle_args *clkspec, +static struct clk_hw *k210_clk_hw_onecell_get(const struct of_phandle_args *clkspec, void *data) { struct k210_sysclk *ksc = data; diff --git a/drivers/clk/clk-lochnagar.c b/drivers/clk/clk-lochnagar.c index 5561a2c66b69..5b773787a225 100644 --- a/drivers/clk/clk-lochnagar.c +++ b/drivers/clk/clk-lochnagar.c @@ -215,7 +215,7 @@ static const struct clk_ops lochnagar_clk_ops = { }; static struct clk_hw * -lochnagar_of_clk_hw_get(struct of_phandle_args *clkspec, void *data) +lochnagar_of_clk_hw_get(const struct of_phandle_args *clkspec, void *data) { struct lochnagar_clk_priv *priv = data; unsigned int idx = clkspec->args[0]; diff --git a/drivers/clk/clk-max77686.c b/drivers/clk/clk-max77686.c index 3727d5472450..3ce2453c116c 100644 --- a/drivers/clk/clk-max77686.c +++ b/drivers/clk/clk-max77686.c @@ -145,7 +145,7 @@ static const struct clk_ops max77686_clk_ops = { }; static struct clk_hw * -of_clk_max77686_get(struct of_phandle_args *clkspec, void *data) +of_clk_max77686_get(const struct of_phandle_args *clkspec, void *data) { struct max77686_clk_driver_data *drv_data = data; unsigned int idx = clkspec->args[0]; diff --git a/drivers/clk/clk-max9485.c b/drivers/clk/clk-max9485.c index be9020b6c789..050246008514 100644 --- a/drivers/clk/clk-max9485.c +++ b/drivers/clk/clk-max9485.c @@ -246,7 +246,7 @@ static const struct max9485_clk max9485_clks[MAX9485_NUM_CLKS] = { }; static struct clk_hw * -max9485_of_clk_get(struct of_phandle_args *clkspec, void *data) +max9485_of_clk_get(const struct of_phandle_args *clkspec, void *data) { struct max9485_driver_data *drvdata = data; unsigned int idx = clkspec->args[0]; diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c index 4dcde305944c..95baeca8c031 100644 --- a/drivers/clk/clk-qoriq.c +++ b/drivers/clk/clk-qoriq.c @@ -1384,7 +1384,8 @@ static void __init core_pll_init(struct device_node *np) } } -static struct clk *clockgen_clk_get(struct of_phandle_args *clkspec, void *data) +static struct clk *clockgen_clk_get(const struct of_phandle_args *clkspec, + void *data) { struct clockgen *cg = data; struct clk *clk; diff --git a/drivers/clk/clk-renesas-pcie.c b/drivers/clk/clk-renesas-pcie.c index 53e21ac302e6..0fad48ff0f95 100644 --- a/drivers/clk/clk-renesas-pcie.c +++ b/drivers/clk/clk-renesas-pcie.c @@ -270,7 +270,7 @@ static void rs9_update_config(struct rs9_driver_data *rs9) } static struct clk_hw * -rs9_of_clk_get(struct of_phandle_args *clkspec, void *data) +rs9_of_clk_get(const struct of_phandle_args *clkspec, void *data) { struct rs9_driver_data *rs9 = data; unsigned int idx = clkspec->args[0]; diff --git a/drivers/clk/clk-rk808.c b/drivers/clk/clk-rk808.c index f7412b137e5e..05e5047e7ce8 100644 --- a/drivers/clk/clk-rk808.c +++ b/drivers/clk/clk-rk808.c @@ -72,7 +72,7 @@ static const struct clk_ops rk808_clkout2_ops = { }; static struct clk_hw * -of_clk_rk808_get(struct of_phandle_args *clkspec, void *data) +of_clk_rk808_get(const struct of_phandle_args *clkspec, void *data) { struct rk808_clkout *rk808_clkout = data; unsigned int idx = clkspec->args[0]; diff --git a/drivers/clk/clk-scpi.c b/drivers/clk/clk-scpi.c index 108b697bd317..8125e6ac7916 100644 --- a/drivers/clk/clk-scpi.c +++ b/drivers/clk/clk-scpi.c @@ -172,7 +172,7 @@ struct scpi_clk_data { }; static struct clk_hw * -scpi_of_clk_src_get(struct of_phandle_args *clkspec, void *data) +scpi_of_clk_src_get(const struct of_phandle_args *clkspec, void *data) { struct scpi_clk *sclk; struct scpi_clk_data *clk_data = data; diff --git a/drivers/clk/clk-si521xx.c b/drivers/clk/clk-si521xx.c index 4f7b74f889f1..5912bc5ad375 100644 --- a/drivers/clk/clk-si521xx.c +++ b/drivers/clk/clk-si521xx.c @@ -269,7 +269,7 @@ static void si521xx_diff_idx_to_reg_bit(const u16 chip_info, const int idx, } static struct clk_hw * -si521xx_of_clk_get(struct of_phandle_args *clkspec, void *data) +si521xx_of_clk_get(const struct of_phandle_args *clkspec, void *data) { struct si521xx *si = data; unsigned int idx = clkspec->args[0]; diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c index 6e8dd7387cfd..4acf1daabcdf 100644 --- a/drivers/clk/clk-si5341.c +++ b/drivers/clk/clk-si5341.c @@ -957,7 +957,7 @@ static int si5341_is_programmed_already(struct clk_si5341 *data) } static struct clk_hw * -of_clk_si5341_get(struct of_phandle_args *clkspec, void *_data) +of_clk_si5341_get(const struct of_phandle_args *clkspec, void *_data) { struct clk_si5341 *data = _data; unsigned int idx = clkspec->args[1]; diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c index 4ce83c5265b8..3b325167c072 100644 --- a/drivers/clk/clk-si5351.c +++ b/drivers/clk/clk-si5351.c @@ -1390,7 +1390,7 @@ static int si5351_dt_parse(struct i2c_client *client, } static struct clk_hw * -si53351_of_clk_get(struct of_phandle_args *clkspec, void *data) +si53351_of_clk_get(const struct of_phandle_args *clkspec, void *data) { struct si5351_driver_data *drvdata = data; unsigned int idx = clkspec->args[0]; @@ -1409,7 +1409,7 @@ static int si5351_dt_parse(struct i2c_client *client, enum si5351_variant varian } static struct clk_hw * -si53351_of_clk_get(struct of_phandle_args *clkspec, void *data) +si53351_of_clk_get(const struct of_phandle_args *clkspec, void *data) { return NULL; } diff --git a/drivers/clk/clk-sparx5.c b/drivers/clk/clk-sparx5.c index 0fad0c1a0186..b352cdc289b6 100644 --- a/drivers/clk/clk-sparx5.c +++ b/drivers/clk/clk-sparx5.c @@ -229,7 +229,8 @@ static const struct clk_ops s5_pll_ops = { .recalc_rate = s5_pll_recalc_rate, }; -static struct clk_hw *s5_clk_hw_get(struct of_phandle_args *clkspec, void *data) +static struct clk_hw *s5_clk_hw_get(const struct of_phandle_args *clkspec, + void *data) { struct s5_clk_data *s5_clk = data; unsigned int idx = clkspec->args[0]; diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c index 07c13ebe327d..daa21cc8851b 100644 --- a/drivers/clk/clk-stm32f4.c +++ b/drivers/clk/clk-stm32f4.c @@ -872,7 +872,7 @@ static int stm32f4_rcc_lookup_clk_idx(u8 primary, u8 secondary) } static struct clk_hw * -stm32f4_rcc_lookup_clk(struct of_phandle_args *clkspec, void *data) +stm32f4_rcc_lookup_clk(const struct of_phandle_args *clkspec, void *data) { int i = stm32f4_rcc_lookup_clk_idx(clkspec->args[0], clkspec->args[1]); diff --git a/drivers/clk/clk-versaclock3.c b/drivers/clk/clk-versaclock3.c index 76d7ea1964c3..257160509310 100644 --- a/drivers/clk/clk-versaclock3.c +++ b/drivers/clk/clk-versaclock3.c @@ -964,7 +964,7 @@ static struct vc3_hw_data clk_mux[] = { } }; -static struct clk_hw *vc3_of_clk_get(struct of_phandle_args *clkspec, +static struct clk_hw *vc3_of_clk_get(const struct of_phandle_args *clkspec, void *data) { unsigned int idx = clkspec->args[0]; diff --git a/drivers/clk/clk-versaclock5.c b/drivers/clk/clk-versaclock5.c index 6d31cd54d7cf..9a25e96955bd 100644 --- a/drivers/clk/clk-versaclock5.c +++ b/drivers/clk/clk-versaclock5.c @@ -731,7 +731,7 @@ static const struct clk_ops vc5_clk_out_ops = { .get_parent = vc5_clk_out_get_parent, }; -static struct clk_hw *vc5_of_clk_get(struct of_phandle_args *clkspec, +static struct clk_hw *vc5_of_clk_get(const struct of_phandle_args *clkspec, void *data) { struct vc5_driver_data *vc5 = data; diff --git a/drivers/clk/clk-versaclock7.c b/drivers/clk/clk-versaclock7.c index f323263e32c3..8345a946c1ec 100644 --- a/drivers/clk/clk-versaclock7.c +++ b/drivers/clk/clk-versaclock7.c @@ -174,7 +174,7 @@ struct vc7_bank_src_map { } src; }; -static struct clk_hw *vc7_of_clk_get(struct of_phandle_args *clkspec, +static struct clk_hw *vc7_of_clk_get(const struct of_phandle_args *clkspec, void *data) { struct vc7_driver_data *vc7 = data; diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 2253c154a824..cfb1dfeeb329 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -342,7 +342,7 @@ static struct clk_core *clk_core_lookup(const char *name) static int of_parse_clkspec(const struct device_node *np, int index, const char *name, struct of_phandle_args *out_args); static struct clk_hw * -of_clk_get_hw_from_clkspec(struct of_phandle_args *clkspec); +of_clk_get_hw_from_clkspec(const struct of_phandle_args *clkspec); #else static inline int of_parse_clkspec(const struct device_node *np, int index, const char *name, @@ -351,7 +351,7 @@ static inline int of_parse_clkspec(const struct device_node *np, int index, return -ENOENT; } static inline struct clk_hw * -of_clk_get_hw_from_clkspec(struct of_phandle_args *clkspec) +of_clk_get_hw_from_clkspec(const struct of_phandle_args *clkspec) { return ERR_PTR(-ENOENT); } @@ -4818,8 +4818,8 @@ struct of_clk_provider { struct list_head link; struct device_node *node; - struct clk *(*get)(struct of_phandle_args *clkspec, void *data); - struct clk_hw *(*get_hw)(struct of_phandle_args *clkspec, void *data); + struct clk *(*get)(const struct of_phandle_args *clkspec, void *data); + struct clk_hw *(*get_hw)(const struct of_phandle_args *clkspec, void *data); void *data; }; @@ -4830,20 +4830,22 @@ static const struct of_device_id __clk_of_table_sentinel static LIST_HEAD(of_clk_providers); static DEFINE_MUTEX(of_clk_mutex); -struct clk *of_clk_src_simple_get(struct of_phandle_args *clkspec, +struct clk *of_clk_src_simple_get(const struct of_phandle_args *clkspec, void *data) { return data; } EXPORT_SYMBOL_GPL(of_clk_src_simple_get); -struct clk_hw *of_clk_hw_simple_get(struct of_phandle_args *clkspec, void *data) +struct clk_hw *of_clk_hw_simple_get(const struct of_phandle_args *clkspec, + void *data) { return data; } EXPORT_SYMBOL_GPL(of_clk_hw_simple_get); -struct clk *of_clk_src_onecell_get(struct of_phandle_args *clkspec, void *data) +struct clk *of_clk_src_onecell_get(const struct of_phandle_args *clkspec, + void *data) { struct clk_onecell_data *clk_data = data; unsigned int idx = clkspec->args[0]; @@ -4858,7 +4860,7 @@ struct clk *of_clk_src_onecell_get(struct of_phandle_args *clkspec, void *data) EXPORT_SYMBOL_GPL(of_clk_src_onecell_get); struct clk_hw * -of_clk_hw_onecell_get(struct of_phandle_args *clkspec, void *data) +of_clk_hw_onecell_get(const struct of_phandle_args *clkspec, void *data) { struct clk_hw_onecell_data *hw_data = data; unsigned int idx = clkspec->args[0]; @@ -4881,7 +4883,7 @@ EXPORT_SYMBOL_GPL(of_clk_hw_onecell_get); * This function is *deprecated*. Use of_clk_add_hw_provider() instead. */ int of_clk_add_provider(struct device_node *np, - struct clk *(*clk_src_get)(struct of_phandle_args *clkspec, + struct clk *(*clk_src_get)(const struct of_phandle_args *clkspec, void *data), void *data) { @@ -4923,7 +4925,7 @@ EXPORT_SYMBOL_GPL(of_clk_add_provider); * @data: context pointer for @get callback. */ int of_clk_add_hw_provider(struct device_node *np, - struct clk_hw *(*get)(struct of_phandle_args *clkspec, + struct clk_hw *(*get)(const struct of_phandle_args *clkspec, void *data), void *data) { @@ -4997,7 +4999,7 @@ static struct device_node *get_clk_provider_node(struct device *dev) * Return: 0 on success or an errno on failure. */ int devm_of_clk_add_hw_provider(struct device *dev, - struct clk_hw *(*get)(struct of_phandle_args *clkspec, + struct clk_hw *(*get)(const struct of_phandle_args *clkspec, void *data), void *data) { @@ -5123,7 +5125,7 @@ static int of_parse_clkspec(const struct device_node *np, int index, static struct clk_hw * __of_clk_get_hw_from_provider(struct of_clk_provider *provider, - struct of_phandle_args *clkspec) + const struct of_phandle_args *clkspec) { struct clk *clk; @@ -5137,7 +5139,7 @@ __of_clk_get_hw_from_provider(struct of_clk_provider *provider, } static struct clk_hw * -of_clk_get_hw_from_clkspec(struct of_phandle_args *clkspec) +of_clk_get_hw_from_clkspec(const struct of_phandle_args *clkspec) { struct of_clk_provider *provider; struct clk_hw *hw = ERR_PTR(-EPROBE_DEFER); @@ -5166,7 +5168,7 @@ of_clk_get_hw_from_clkspec(struct of_phandle_args *clkspec) * providers, an input is a clock specifier data structure as returned * from the of_parse_phandle_with_args() function call. */ -struct clk *of_clk_get_from_provider(struct of_phandle_args *clkspec) +struct clk *of_clk_get_from_provider(const struct of_phandle_args *clkspec) { struct clk_hw *hw = of_clk_get_hw_from_clkspec(clkspec); diff --git a/drivers/clk/hisilicon/clk-hi3660-stub.c b/drivers/clk/hisilicon/clk-hi3660-stub.c index 3a653d54bee0..1dd7fb7cfa5b 100644 --- a/drivers/clk/hisilicon/clk-hi3660-stub.c +++ b/drivers/clk/hisilicon/clk-hi3660-stub.c @@ -108,7 +108,7 @@ static struct hi3660_stub_clk hi3660_stub_clks[HI3660_CLK_STUB_NUM] = { DEFINE_CLK_STUB(HI3660_CLK_STUB_DDR, 0x00040309, "clk-ddrc") }; -static struct clk_hw *hi3660_stub_clk_hw_get(struct of_phandle_args *clkspec, +static struct clk_hw *hi3660_stub_clk_hw_get(const struct of_phandle_args *clkspec, void *data) { unsigned int idx = clkspec->args[0]; diff --git a/drivers/clk/imx/clk-imx8qxp-lpcg.c b/drivers/clk/imx/clk-imx8qxp-lpcg.c index d0ccaa040225..feb2e4a61b6c 100644 --- a/drivers/clk/imx/clk-imx8qxp-lpcg.c +++ b/drivers/clk/imx/clk-imx8qxp-lpcg.c @@ -159,7 +159,7 @@ static const struct imx8qxp_ss_lpcg imx8qxp_ss_lsio = { #define IMX_LPCG_MAX_CLKS 8 -static struct clk_hw *imx_lpcg_of_clk_src_get(struct of_phandle_args *clkspec, +static struct clk_hw *imx_lpcg_of_clk_src_get(const struct of_phandle_args *clkspec, void *data) { struct clk_hw_onecell_data *hw_data = data; diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c index e48a904c0013..d357dc337741 100644 --- a/drivers/clk/imx/clk-scu.c +++ b/drivers/clk/imx/clk-scu.c @@ -517,7 +517,7 @@ struct clk_hw *__imx_clk_scu(struct device *dev, const char *name, return hw; } -struct clk_hw *imx_scu_of_clk_src_get(struct of_phandle_args *clkspec, +struct clk_hw *imx_scu_of_clk_src_get(const struct of_phandle_args *clkspec, void *data) { unsigned int rsrc = clkspec->args[0]; diff --git a/drivers/clk/imx/clk-scu.h b/drivers/clk/imx/clk-scu.h index af7b697f51ca..38db6a1905d0 100644 --- a/drivers/clk/imx/clk-scu.h +++ b/drivers/clk/imx/clk-scu.h @@ -27,7 +27,7 @@ extern const struct imx_clk_scu_rsrc_table imx_clk_scu_rsrc_imx8qm; int imx_clk_scu_init(struct device_node *np, const struct imx_clk_scu_rsrc_table *data); -struct clk_hw *imx_scu_of_clk_src_get(struct of_phandle_args *clkspec, +struct clk_hw *imx_scu_of_clk_src_get(const struct of_phandle_args *clkspec, void *data); struct clk_hw *imx_clk_scu_alloc_dev(const char *name, const char * const *parents, diff --git a/drivers/clk/keystone/sci-clk.c b/drivers/clk/keystone/sci-clk.c index 35fe197dd303..ba27fb22f973 100644 --- a/drivers/clk/keystone/sci-clk.c +++ b/drivers/clk/keystone/sci-clk.c @@ -375,7 +375,8 @@ static int _cmp_sci_clk(const void *a, const void *b) * when a corresponding of_clk_get call is executed. Returns a pointer * to the TI SCI hw clock struct, or ERR_PTR value in failure. */ -static struct clk_hw *sci_clk_get(struct of_phandle_args *clkspec, void *data) +static struct clk_hw *sci_clk_get(const struct of_phandle_args *clkspec, + void *data) { struct sci_clk_provider *provider = data; struct sci_clk **clk; diff --git a/drivers/clk/meson/meson-clkc-utils.c b/drivers/clk/meson/meson-clkc-utils.c index 7370644e8092..904b482bf47b 100644 --- a/drivers/clk/meson/meson-clkc-utils.c +++ b/drivers/clk/meson/meson-clkc-utils.c @@ -8,7 +8,8 @@ #include <linux/module.h> #include "meson-clkc-utils.h" -struct clk_hw *meson_clk_hw_get(struct of_phandle_args *clkspec, void *clk_hw_data) +struct clk_hw *meson_clk_hw_get(const struct of_phandle_args *clkspec, + void *clk_hw_data) { const struct meson_clk_hw_data *data = clk_hw_data; unsigned int idx = clkspec->args[0]; diff --git a/drivers/clk/meson/meson-clkc-utils.h b/drivers/clk/meson/meson-clkc-utils.h index fe6f40728949..3889ead76a07 100644 --- a/drivers/clk/meson/meson-clkc-utils.h +++ b/drivers/clk/meson/meson-clkc-utils.h @@ -14,6 +14,7 @@ struct meson_clk_hw_data { unsigned int num; }; -struct clk_hw *meson_clk_hw_get(struct of_phandle_args *clkspec, void *clk_hw_data); +struct clk_hw *meson_clk_hw_get(const struct of_phandle_args *clkspec, + void *clk_hw_data); #endif diff --git a/drivers/clk/mvebu/common.c b/drivers/clk/mvebu/common.c index 785dbede4835..19cd62152175 100644 --- a/drivers/clk/mvebu/common.c +++ b/drivers/clk/mvebu/common.c @@ -199,7 +199,7 @@ struct clk_gating_ctrl { static struct clk_gating_ctrl *ctrl; static struct clk *clk_gating_get_src( - struct of_phandle_args *clkspec, void *data) + const struct of_phandle_args *clkspec, void *data) { int n; diff --git a/drivers/clk/mvebu/cp110-system-controller.c b/drivers/clk/mvebu/cp110-system-controller.c index 03c59bf22106..8f6e2dd3e044 100644 --- a/drivers/clk/mvebu/cp110-system-controller.c +++ b/drivers/clk/mvebu/cp110-system-controller.c @@ -192,7 +192,7 @@ static void cp110_unregister_gate(struct clk_hw *hw) kfree(to_cp110_gate_clk(hw)); } -static struct clk_hw *cp110_of_clk_get(struct of_phandle_args *clkspec, +static struct clk_hw *cp110_of_clk_get(const struct of_phandle_args *clkspec, void *data) { struct clk_hw_onecell_data *clk_data = data; diff --git a/drivers/clk/mvebu/kirkwood.c b/drivers/clk/mvebu/kirkwood.c index 8bc893df4736..b2b9a7a7a8fb 100644 --- a/drivers/clk/mvebu/kirkwood.c +++ b/drivers/clk/mvebu/kirkwood.c @@ -269,7 +269,7 @@ static const struct clk_muxing_soc_desc kirkwood_mux_desc[] __initconst = { }; static struct clk *clk_muxing_get_src( - struct of_phandle_args *clkspec, void *data) + const struct of_phandle_args *clkspec, void *data) { struct clk_muxing_ctrl *ctrl = (struct clk_muxing_ctrl *)data; int n; diff --git a/drivers/clk/nxp/clk-lpc18xx-ccu.c b/drivers/clk/nxp/clk-lpc18xx-ccu.c index ddb28b38f549..3d8299b7e790 100644 --- a/drivers/clk/nxp/clk-lpc18xx-ccu.c +++ b/drivers/clk/nxp/clk-lpc18xx-ccu.c @@ -109,7 +109,7 @@ static struct lpc18xx_clk_branch clk_branches[] = { {"base_sdio_clk", "sdio", CLK_SDIO, 0}, }; -static struct clk *lpc18xx_ccu_branch_clk_get(struct of_phandle_args *clkspec, +static struct clk *lpc18xx_ccu_branch_clk_get(const struct of_phandle_args *clkspec, void *data) { struct lpc18xx_branch_clk_data *clk_data = data; diff --git a/drivers/clk/qcom/clk-rpm.c b/drivers/clk/qcom/clk-rpm.c index 745026ef4d9c..b7e048237bc0 100644 --- a/drivers/clk/qcom/clk-rpm.c +++ b/drivers/clk/qcom/clk-rpm.c @@ -514,7 +514,7 @@ static const struct of_device_id rpm_clk_match_table[] = { }; MODULE_DEVICE_TABLE(of, rpm_clk_match_table); -static struct clk_hw *qcom_rpm_clk_hw_get(struct of_phandle_args *clkspec, +static struct clk_hw *qcom_rpm_clk_hw_get(const struct of_phandle_args *clkspec, void *data) { struct rpm_cc *rcc = data; diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c index bb82abeed88f..8c2c6aa3a793 100644 --- a/drivers/clk/qcom/clk-rpmh.c +++ b/drivers/clk/qcom/clk-rpmh.c @@ -793,7 +793,7 @@ static const struct clk_rpmh_desc clk_rpmh_x1e80100 = { .num_clks = ARRAY_SIZE(x1e80100_rpmh_clocks), }; -static struct clk_hw *of_clk_rpmh_hw_get(struct of_phandle_args *clkspec, +static struct clk_hw *of_clk_rpmh_hw_get(const struct of_phandle_args *clkspec, void *data) { struct clk_rpmh_desc *rpmh = data; diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c index 8602c02047d0..5d7e0cd2d450 100644 --- a/drivers/clk/qcom/clk-smd-rpm.c +++ b/drivers/clk/qcom/clk-smd-rpm.c @@ -1232,7 +1232,7 @@ static const struct of_device_id rpm_smd_clk_match_table[] = { }; MODULE_DEVICE_TABLE(of, rpm_smd_clk_match_table); -static struct clk_hw *qcom_smdrpm_clk_hw_get(struct of_phandle_args *clkspec, +static struct clk_hw *qcom_smdrpm_clk_hw_get(const struct of_phandle_args *clkspec, void *data) { const struct rpm_smd_clk_desc *desc = data; diff --git a/drivers/clk/qcom/clk-spmi-pmic-div.c b/drivers/clk/qcom/clk-spmi-pmic-div.c index f394031eb0e5..3f65aead519d 100644 --- a/drivers/clk/qcom/clk-spmi-pmic-div.c +++ b/drivers/clk/qcom/clk-spmi-pmic-div.c @@ -181,7 +181,7 @@ struct spmi_pmic_div_clk_cc { }; static struct clk_hw * -spmi_pmic_div_clk_hw_get(struct of_phandle_args *clkspec, void *data) +spmi_pmic_div_clk_hw_get(const struct of_phandle_args *clkspec, void *data) { struct spmi_pmic_div_clk_cc *cc = data; int idx = clkspec->args[0] - 1; /* Start at 1 instead of 0 */ diff --git a/drivers/clk/qcom/common.c b/drivers/clk/qcom/common.c index 75f09e6e057e..0ae6f8ea607a 100644 --- a/drivers/clk/qcom/common.c +++ b/drivers/clk/qcom/common.c @@ -220,7 +220,7 @@ static void qcom_cc_drop_protected(struct device *dev, struct qcom_cc *cc) } } -static struct clk_hw *qcom_cc_clk_hw_get(struct of_phandle_args *clkspec, +static struct clk_hw *qcom_cc_clk_hw_get(const struct of_phandle_args *clkspec, void *data) { struct qcom_cc *cc = data; diff --git a/drivers/clk/qcom/krait-cc.c b/drivers/clk/qcom/krait-cc.c index ae325f4e1047..181f4096a506 100644 --- a/drivers/clk/qcom/krait-cc.c +++ b/drivers/clk/qcom/krait-cc.c @@ -324,7 +324,7 @@ static struct clk_hw *krait_add_clks(struct device *dev, int id, bool unique_aux return pri_mux; } -static struct clk *krait_of_get(struct of_phandle_args *clkspec, void *data) +static struct clk *krait_of_get(const struct of_phandle_args *clkspec, void *data) { unsigned int idx = clkspec->args[0]; struct clk **clks = data; diff --git a/drivers/clk/renesas/r9a06g032-clocks.c b/drivers/clk/renesas/r9a06g032-clocks.c index c1348e2d450c..f8ea88663fca 100644 --- a/drivers/clk/renesas/r9a06g032-clocks.c +++ b/drivers/clk/renesas/r9a06g032-clocks.c @@ -733,7 +733,7 @@ struct r9a06g032_clk_gate { #define to_r9a06g032_gate(_hw) container_of(_hw, struct r9a06g032_clk_gate, hw) -static int create_add_module_clock(struct of_phandle_args *clkspec, +static int create_add_module_clock(const struct of_phandle_args *clkspec, struct device *dev) { struct clk *clk; diff --git a/drivers/clk/renesas/renesas-cpg-mssr.c b/drivers/clk/renesas/renesas-cpg-mssr.c index 1b421b809796..c172444ee766 100644 --- a/drivers/clk/renesas/renesas-cpg-mssr.c +++ b/drivers/clk/renesas/renesas-cpg-mssr.c @@ -273,7 +273,7 @@ static const struct clk_ops cpg_mstp_clock_ops = { }; static -struct clk *cpg_mssr_clk_src_twocell_get(struct of_phandle_args *clkspec, +struct clk *cpg_mssr_clk_src_twocell_get(const struct of_phandle_args *clkspec, void *data) { unsigned int clkidx = clkspec->args[1]; diff --git a/drivers/clk/renesas/rzg2l-cpg.c b/drivers/clk/renesas/rzg2l-cpg.c index 3d2daa4ba2a4..7464a298b2e5 100644 --- a/drivers/clk/renesas/rzg2l-cpg.c +++ b/drivers/clk/renesas/rzg2l-cpg.c @@ -1052,7 +1052,7 @@ rzg2l_cpg_pll_clk_register(const struct cpg_core_clk *core, } static struct clk -*rzg2l_cpg_clk_src_twocell_get(struct of_phandle_args *clkspec, +*rzg2l_cpg_clk_src_twocell_get(const struct of_phandle_args *clkspec, void *data) { unsigned int clkidx = clkspec->args[1]; diff --git a/drivers/clk/starfive/clk-starfive-jh7100-audio.c b/drivers/clk/starfive/clk-starfive-jh7100-audio.c index 1fcf4e62f347..79feba75ea43 100644 --- a/drivers/clk/starfive/clk-starfive-jh7100-audio.c +++ b/drivers/clk/starfive/clk-starfive-jh7100-audio.c @@ -84,7 +84,8 @@ static const struct jh71x0_clk_data jh7100_audclk_data[] = { JH7100_AUDCLK_AUDIO_12288), }; -static struct clk_hw *jh7100_audclk_get(struct of_phandle_args *clkspec, void *data) +static struct clk_hw *jh7100_audclk_get(const struct of_phandle_args *clkspec, + void *data) { struct jh71x0_clk_priv *priv = data; unsigned int idx = clkspec->args[0]; diff --git a/drivers/clk/starfive/clk-starfive-jh7100.c b/drivers/clk/starfive/clk-starfive-jh7100.c index 03f6f26a15d8..b7e43f4847d2 100644 --- a/drivers/clk/starfive/clk-starfive-jh7100.c +++ b/drivers/clk/starfive/clk-starfive-jh7100.c @@ -267,7 +267,8 @@ static const struct jh71x0_clk_data jh7100_clk_data[] __initconst = { JH71X0_GATE(JH7100_CLK_SYSERR_APB, "syserr_apb", 0, JH7100_CLK_APB2_BUS), }; -static struct clk_hw *jh7100_clk_get(struct of_phandle_args *clkspec, void *data) +static struct clk_hw *jh7100_clk_get(const struct of_phandle_args *clkspec, + void *data) { struct jh71x0_clk_priv *priv = data; unsigned int idx = clkspec->args[0]; diff --git a/drivers/clk/starfive/clk-starfive-jh7110-aon.c b/drivers/clk/starfive/clk-starfive-jh7110-aon.c index 418efdad719b..d05da683a544 100644 --- a/drivers/clk/starfive/clk-starfive-jh7110-aon.c +++ b/drivers/clk/starfive/clk-starfive-jh7110-aon.c @@ -54,7 +54,8 @@ static const struct jh71x0_clk_data jh7110_aonclk_data[] = { JH71X0_GATE(JH7110_AONCLK_RTC_CAL, "rtc_cal", 0, JH7110_AONCLK_OSC), }; -static struct clk_hw *jh7110_aonclk_get(struct of_phandle_args *clkspec, void *data) +static struct clk_hw *jh7110_aonclk_get(const struct of_phandle_args *clkspec, + void *data) { struct jh71x0_clk_priv *priv = data; unsigned int idx = clkspec->args[0]; diff --git a/drivers/clk/starfive/clk-starfive-jh7110-isp.c b/drivers/clk/starfive/clk-starfive-jh7110-isp.c index 929b8788279e..518c4a8d4200 100644 --- a/drivers/clk/starfive/clk-starfive-jh7110-isp.c +++ b/drivers/clk/starfive/clk-starfive-jh7110-isp.c @@ -75,7 +75,8 @@ static inline int jh7110_isp_top_rst_init(struct jh71x0_clk_priv *priv) return reset_control_deassert(top_rsts); } -static struct clk_hw *jh7110_ispclk_get(struct of_phandle_args *clkspec, void *data) +static struct clk_hw *jh7110_ispclk_get(const struct of_phandle_args *clkspec, + void *data) { struct jh71x0_clk_priv *priv = data; unsigned int idx = clkspec->args[0]; diff --git a/drivers/clk/starfive/clk-starfive-jh7110-pll.c b/drivers/clk/starfive/clk-starfive-jh7110-pll.c index 3598390e8fd0..3c53459c554b 100644 --- a/drivers/clk/starfive/clk-starfive-jh7110-pll.c +++ b/drivers/clk/starfive/clk-starfive-jh7110-pll.c @@ -442,7 +442,8 @@ static const struct clk_ops jh7110_pll_ops = { .debug_init = jh7110_pll_debug_init, }; -static struct clk_hw *jh7110_pll_get(struct of_phandle_args *clkspec, void *data) +static struct clk_hw *jh7110_pll_get(const struct of_phandle_args *clkspec, + void *data) { struct jh7110_pll_priv *priv = data; unsigned int idx = clkspec->args[0]; diff --git a/drivers/clk/starfive/clk-starfive-jh7110-stg.c b/drivers/clk/starfive/clk-starfive-jh7110-stg.c index dafcb7190592..0fba5de830e9 100644 --- a/drivers/clk/starfive/clk-starfive-jh7110-stg.c +++ b/drivers/clk/starfive/clk-starfive-jh7110-stg.c @@ -75,7 +75,8 @@ static const struct jh71x0_clk_data jh7110_stgclk_data[] = { JH71X0_GATE(JH7110_STGCLK_DMA1P_AHB, "dma1p_ahb", 0, JH7110_STGCLK_STG_AXIAHB), }; -static struct clk_hw *jh7110_stgclk_get(struct of_phandle_args *clkspec, void *data) +static struct clk_hw *jh7110_stgclk_get(const struct of_phandle_args *clkspec, + void *data) { struct jh71x0_clk_priv *priv = data; unsigned int idx = clkspec->args[0]; diff --git a/drivers/clk/starfive/clk-starfive-jh7110-sys.c b/drivers/clk/starfive/clk-starfive-jh7110-sys.c index 8f5e5abfa178..6ea25b959091 100644 --- a/drivers/clk/starfive/clk-starfive-jh7110-sys.c +++ b/drivers/clk/starfive/clk-starfive-jh7110-sys.c @@ -323,7 +323,8 @@ static const struct jh71x0_clk_data jh7110_sysclk_data[] __initconst = { JH7110_SYSCLK_OSC), }; -static struct clk_hw *jh7110_sysclk_get(struct of_phandle_args *clkspec, void *data) +static struct clk_hw *jh7110_sysclk_get(const struct of_phandle_args *clkspec, + void *data) { struct jh71x0_clk_priv *priv = data; unsigned int idx = clkspec->args[0]; diff --git a/drivers/clk/starfive/clk-starfive-jh7110-vout.c b/drivers/clk/starfive/clk-starfive-jh7110-vout.c index 10cc1ec43925..7f69a4d75126 100644 --- a/drivers/clk/starfive/clk-starfive-jh7110-vout.c +++ b/drivers/clk/starfive/clk-starfive-jh7110-vout.c @@ -80,7 +80,8 @@ static int jh7110_vout_top_rst_init(struct jh71x0_clk_priv *priv) return reset_control_deassert(top_rst); } -static struct clk_hw *jh7110_voutclk_get(struct of_phandle_args *clkspec, void *data) +static struct clk_hw *jh7110_voutclk_get(const struct of_phandle_args *clkspec, + void *data) { struct jh71x0_clk_priv *priv = data; unsigned int idx = clkspec->args[0]; diff --git a/drivers/clk/tegra/clk-bpmp.c b/drivers/clk/tegra/clk-bpmp.c index 7bfba0afd778..9c53ab9b8a00 100644 --- a/drivers/clk/tegra/clk-bpmp.c +++ b/drivers/clk/tegra/clk-bpmp.c @@ -654,7 +654,7 @@ static void tegra_bpmp_unregister_clocks(struct tegra_bpmp *bpmp) clk_hw_unregister(&bpmp->clocks[i]->hw); } -static struct clk_hw *tegra_bpmp_clk_of_xlate(struct of_phandle_args *clkspec, +static struct clk_hw *tegra_bpmp_clk_of_xlate(const struct of_phandle_args *clkspec, void *data) { unsigned int id = clkspec->args[0], i; diff --git a/drivers/clk/tegra/clk-tegra124.c b/drivers/clk/tegra/clk-tegra124.c index 6c46592d794e..87f1e5bc5c0e 100644 --- a/drivers/clk/tegra/clk-tegra124.c +++ b/drivers/clk/tegra/clk-tegra124.c @@ -1502,7 +1502,7 @@ static void __init tegra124_132_clock_init_pre(struct device_node *np) writel(plld_base, clk_base + PLLD_BASE); } -static struct clk *tegra124_clk_src_onecell_get(struct of_phandle_args *clkspec, +static struct clk *tegra124_clk_src_onecell_get(const struct of_phandle_args *clkspec, void *data) { struct clk_hw *hw; diff --git a/drivers/clk/tegra/clk-tegra20.c b/drivers/clk/tegra/clk-tegra20.c index 2c58ce25af75..8a7e17d3379a 100644 --- a/drivers/clk/tegra/clk-tegra20.c +++ b/drivers/clk/tegra/clk-tegra20.c @@ -1069,7 +1069,7 @@ static const struct of_device_id pmc_match[] __initconst = { static bool tegra20_car_initialized; -static struct clk *tegra20_clk_src_onecell_get(struct of_phandle_args *clkspec, +static struct clk *tegra20_clk_src_onecell_get(const struct of_phandle_args *clkspec, void *data) { struct clk_hw *parent_hw; diff --git a/drivers/clk/tegra/clk-tegra30.c b/drivers/clk/tegra/clk-tegra30.c index 82a8cb9545eb..4317c68cdeb4 100644 --- a/drivers/clk/tegra/clk-tegra30.c +++ b/drivers/clk/tegra/clk-tegra30.c @@ -1273,7 +1273,7 @@ static struct tegra_audio_clk_info tegra30_audio_plls[] = { static bool tegra30_car_initialized; -static struct clk *tegra30_clk_src_onecell_get(struct of_phandle_args *clkspec, +static struct clk *tegra30_clk_src_onecell_get(const struct of_phandle_args *clkspec, void *data) { struct clk_hw *hw; diff --git a/drivers/clk/ti/clkctrl.c b/drivers/clk/ti/clkctrl.c index 607e34d8e289..31df051c116c 100644 --- a/drivers/clk/ti/clkctrl.c +++ b/drivers/clk/ti/clkctrl.c @@ -221,7 +221,7 @@ static const struct clk_ops omap4_clkctrl_clk_ops = { .init = omap2_init_clk_clkdm, }; -static struct clk_hw *_ti_omap4_clkctrl_xlate(struct of_phandle_args *clkspec, +static struct clk_hw *_ti_omap4_clkctrl_xlate(const struct of_phandle_args *clkspec, void *data) { struct omap_clkctrl_provider *provider = data; diff --git a/drivers/clk/ux500/u8500_of_clk.c b/drivers/clk/ux500/u8500_of_clk.c index 8e2f6c65db2a..aba91ca5ca07 100644 --- a/drivers/clk/ux500/u8500_of_clk.c +++ b/drivers/clk/ux500/u8500_of_clk.c @@ -26,7 +26,7 @@ static struct clk_hw *clkout_clk[2]; #define PRCC_KCLK_STORE(clk, base, bit) \ prcc_kclk[(base * PRCC_PERIPHS_PER_CLUSTER) + bit] = clk -static struct clk *ux500_twocell_get(struct of_phandle_args *clkspec, +static struct clk *ux500_twocell_get(const struct of_phandle_args *clkspec, void *data) { struct clk **clk_data = data; @@ -71,7 +71,7 @@ static const char * const u8500_clkout_parents[] = { "clk009", }; -static struct clk_hw *ux500_clkout_get(struct of_phandle_args *clkspec, +static struct clk_hw *ux500_clkout_get(const struct of_phandle_args *clkspec, void *data) { u32 id, source, divider; diff --git a/drivers/clk/versatile/clk-sp810.c b/drivers/clk/versatile/clk-sp810.c index 45adac1b4630..5fd21c13f546 100644 --- a/drivers/clk/versatile/clk-sp810.c +++ b/drivers/clk/versatile/clk-sp810.c @@ -68,7 +68,7 @@ static const struct clk_ops clk_sp810_timerclken_ops = { .set_parent = clk_sp810_timerclken_set_parent, }; -static struct clk *clk_sp810_timerclken_of_get(struct of_phandle_args *clkspec, +static struct clk *clk_sp810_timerclken_of_get(const struct of_phandle_args *clkspec, void *data) { struct clk_sp810 *sp810 = data; diff --git a/drivers/media/platform/ti/omap3isp/isp.c b/drivers/media/platform/ti/omap3isp/isp.c index 1cda23244c7b..e2c78f9ab797 100644 --- a/drivers/media/platform/ti/omap3isp/isp.c +++ b/drivers/media/platform/ti/omap3isp/isp.c @@ -281,7 +281,8 @@ static const struct clk_ops isp_xclk_ops = { static const char *isp_xclk_parent_name = "cam_mclk"; -static struct clk *isp_xclk_src_get(struct of_phandle_args *clkspec, void *data) +static struct clk *isp_xclk_src_get(const struct of_phandle_args *clkspec, + void *data) { unsigned int idx = clkspec->args[0]; struct isp_device *isp = data; diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c index b6908a03da58..46a77df32dff 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c @@ -3136,7 +3136,8 @@ static const struct clk_ops qmp_dp_link_clk_ops = { .recalc_rate = qmp_dp_link_clk_recalc_rate, }; -static struct clk_hw *qmp_dp_clks_hw_get(struct of_phandle_args *clkspec, void *data) +static struct clk_hw *qmp_dp_clks_hw_get(const struct of_phandle_args *clkspec, + void *data) { struct qmp_combo *qmp = data; unsigned int idx = clkspec->args[0]; @@ -3177,7 +3178,8 @@ static int phy_dp_clks_register(struct qmp_combo *qmp, struct device_node *np) return 0; } -static struct clk_hw *qmp_combo_clk_hw_get(struct of_phandle_args *clkspec, void *data) +static struct clk_hw *qmp_combo_clk_hw_get(const struct of_phandle_args *clkspec, + void *data) { struct qmp_combo *qmp = data; diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h index 1293c38ddb7f..d58313368924 100644 --- a/include/linux/clk-provider.h +++ b/include/linux/clk-provider.h @@ -1532,25 +1532,25 @@ struct clk_hw_onecell_data { #ifdef CONFIG_OF int of_clk_add_provider(struct device_node *np, - struct clk *(*clk_src_get)(struct of_phandle_args *args, + struct clk *(*clk_src_get)(const struct of_phandle_args *args, void *data), void *data); int of_clk_add_hw_provider(struct device_node *np, - struct clk_hw *(*get)(struct of_phandle_args *clkspec, + struct clk_hw *(*get)(const struct of_phandle_args *clkspec, void *data), void *data); int devm_of_clk_add_hw_provider(struct device *dev, - struct clk_hw *(*get)(struct of_phandle_args *clkspec, + struct clk_hw *(*get)(const struct of_phandle_args *clkspec, void *data), void *data); void of_clk_del_provider(struct device_node *np); -struct clk *of_clk_src_simple_get(struct of_phandle_args *clkspec, +struct clk *of_clk_src_simple_get(const struct of_phandle_args *clkspec, void *data); -struct clk_hw *of_clk_hw_simple_get(struct of_phandle_args *clkspec, +struct clk_hw *of_clk_hw_simple_get(const struct of_phandle_args *clkspec, void *data); -struct clk *of_clk_src_onecell_get(struct of_phandle_args *clkspec, void *data); -struct clk_hw *of_clk_hw_onecell_get(struct of_phandle_args *clkspec, +struct clk *of_clk_src_onecell_get(const struct of_phandle_args *clkspec, void *data); +struct clk_hw *of_clk_hw_onecell_get(const struct of_phandle_args *clkspec, void *data); int of_clk_parent_fill(struct device_node *np, const char **parents, unsigned int size); @@ -1560,21 +1560,21 @@ int of_clk_detect_critical(struct device_node *np, int index, #else /* !CONFIG_OF */ static inline int of_clk_add_provider(struct device_node *np, - struct clk *(*clk_src_get)(struct of_phandle_args *args, + struct clk *(*clk_src_get)(const struct of_phandle_args *args, void *data), void *data) { return 0; } static inline int of_clk_add_hw_provider(struct device_node *np, - struct clk_hw *(*get)(struct of_phandle_args *clkspec, + struct clk_hw *(*get)(const struct of_phandle_args *clkspec, void *data), void *data) { return 0; } static inline int devm_of_clk_add_hw_provider(struct device *dev, - struct clk_hw *(*get)(struct of_phandle_args *clkspec, + struct clk_hw *(*get)(const struct of_phandle_args *clkspec, void *data), void *data) { @@ -1583,22 +1583,22 @@ static inline int devm_of_clk_add_hw_provider(struct device *dev, static inline void of_clk_del_provider(struct device_node *np) {} static inline struct clk *of_clk_src_simple_get( - struct of_phandle_args *clkspec, void *data) + const struct of_phandle_args *clkspec, void *data) { return ERR_PTR(-ENOENT); } static inline struct clk_hw * -of_clk_hw_simple_get(struct of_phandle_args *clkspec, void *data) +of_clk_hw_simple_get(const struct of_phandle_args *clkspec, void *data) { return ERR_PTR(-ENOENT); } static inline struct clk *of_clk_src_onecell_get( - struct of_phandle_args *clkspec, void *data) + const struct of_phandle_args *clkspec, void *data) { return ERR_PTR(-ENOENT); } static inline struct clk_hw * -of_clk_hw_onecell_get(struct of_phandle_args *clkspec, void *data) +of_clk_hw_onecell_get(const struct of_phandle_args *clkspec, void *data) { return ERR_PTR(-ENOENT); } diff --git a/include/linux/clk.h b/include/linux/clk.h index 06f1b292f8a0..8e3c44ff89da 100644 --- a/include/linux/clk.h +++ b/include/linux/clk.h @@ -1141,7 +1141,7 @@ static inline struct clk *clk_get_optional(struct device *dev, const char *id) #if defined(CONFIG_OF) && defined(CONFIG_COMMON_CLK) struct clk *of_clk_get(struct device_node *np, int index); struct clk *of_clk_get_by_name(struct device_node *np, const char *name); -struct clk *of_clk_get_from_provider(struct of_phandle_args *clkspec); +struct clk *of_clk_get_from_provider(const struct of_phandle_args *clkspec); #else static inline struct clk *of_clk_get(struct device_node *np, int index) { @@ -1152,7 +1152,7 @@ static inline struct clk *of_clk_get_by_name(struct device_node *np, { return ERR_PTR(-ENOENT); } -static inline struct clk *of_clk_get_from_provider(struct of_phandle_args *clkspec) +static inline struct clk *of_clk_get_from_provider(const struct of_phandle_args *clkspec) { return ERR_PTR(-ENOENT); } diff --git a/sound/soc/qcom/qdsp6/q6dsp-lpass-clocks.c b/sound/soc/qcom/qdsp6/q6dsp-lpass-clocks.c index e758411603be..b846707baa89 100644 --- a/sound/soc/qcom/qdsp6/q6dsp-lpass-clocks.c +++ b/sound/soc/qcom/qdsp6/q6dsp-lpass-clocks.c @@ -106,7 +106,7 @@ static const struct clk_ops clk_vote_q6dsp_ops = { }; -static struct clk_hw *q6dsp_of_clk_hw_get(struct of_phandle_args *clkspec, +static struct clk_hw *q6dsp_of_clk_hw_get(const struct of_phandle_args *clkspec, void *data) { struct q6dsp_cc *cc = data; -- 2.34.1

7 8

[PATCH AUTOSEL 5.10 04/16] ASoC: codecs: wcd934x: drop unneeded regulator include
by Sasha Levin 18 Feb '24

18 Feb '24

From: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> [ Upstream commit 35314e39dabcfb256832654ad0e856a9fba744bd ] Driver does not use any regulator code, so drop redundant include of regulator/consumer.h header. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> Link: https://msgid.link/r/20240117151208.1219755-3-krzysztof.kozlowski@linaro.org Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/codecs/wcd934x.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c index 104751ac6cd1..dbed3a646524 100644 --- a/sound/soc/codecs/wcd934x.c +++ b/sound/soc/codecs/wcd934x.c @@ -13,7 +13,6 @@ #include <linux/of.h> #include <linux/platform_device.h> #include <linux/regmap.h> -#include <linux/regulator/consumer.h> #include <linux/slab.h> #include <linux/slimbus.h> #include <sound/pcm_params.h> -- 2.43.0

2 1

[PATCH] conf: USB-Audio: Add more Scarlett devices to the IEC958 blacklist
by Geoffrey D. Bennett 18 Feb '24

18 Feb '24

The Scarlett Solo and 2i2 don't have S/PDIF outputs. Signed-off-by: Geoffrey D. Bennett <g(a)b4.vu> --- src/conf/cards/USB-Audio.conf | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/conf/cards/USB-Audio.conf b/src/conf/cards/USB-Audio.conf index 80631b2e..05384a32 100644 --- a/src/conf/cards/USB-Audio.conf +++ b/src/conf/cards/USB-Audio.conf @@ -66,8 +66,11 @@ USB-Audio.pcm.iec958_device { "Plantronics USB Headset" 999 "Plantronics Wireless Audio" 999 "SB WoW Headset" 999 + "Scarlett 2i2 4th Gen" 999 "Scarlett 2i2 USB" 999 "Scarlett 2i4 USB" 999 + "Scarlett Solo 4th Gen" 999 + "Scarlett Solo USB" 999 "Sennheiser USB headset" 999 "SWTOR Gaming Headset by Razer" 999 "ThinkStation P620 Main" 999 -- 2.43.0

1 0

[PATCH v16 00/50] Introduce QC USB SND audio offloading support
by Wesley Cheng 17 Feb '24

17 Feb '24

Several Qualcomm based chipsets can support USB audio offloading to a dedicated audio DSP, which can take over issuing transfers to the USB host controller. The intention is to reduce the load on the main processors in the SoC, and allow them to be placed into lower power modes. There are several parts to this design: 1. Adding ASoC binding layer 2. Create a USB backend for Q6DSP 3. Introduce XHCI interrupter support 4. Create vendor ops for the USB SND driver USB | ASoC -------------------------------------------------------------------- | _________________________ | |sm8250 platform card | | |_________________________| | | | | ___V____ ____V____ | |Q6USB | |Q6AFE | | |"codec" | |"cpu" | | |________| |_________| | ^ ^ ^ | | |________| | ___V____ | | |SOC-USB | | ________ ________ | | | |USB SND |<--->|QC offld|<------------>|________| | |(card.c)| | |<---------- | |________| |________|___ | | | ^ ^ | | | ____________V_________ | | | | | |APR/GLINK | __ V_______________V_____ | | | |______________________| |USB SND (endpoint.c) | | | | ^ |_________________________| | | | | ^ | | | ___________V___________ | | | |->|audio DSP | ___________V_____________ | | |_______________________| |XHCI HCD |<- | |_________________________| | Adding ASoC binding layer: soc-usb: Intention is to treat a USB port similar to a headphone jack. The port is always present on the device, but cable/pin status can be enabled/disabled. Expose mechanisms for USB backend ASoC drivers to communicate with USB SND. Create a USB backend for Q6DSP: q6usb: Basic backend driver that will be responsible for maintaining the resources needed to initiate a playback stream using the Q6DSP. Will be the entity that checks to make sure the connected USB audio device supports the requested PCM format. If it does not, the PCM open call will fail, and userpsace ALSA can take action accordingly. Introduce XHCI interrupter support: XHCI HCD supports multiple interrupters, which allows for events to be routed to different event rings. This is determined by "Interrupter Target" field specified in Section "6.4.1.1 Normal TRB" of the XHCI specification. Events in the offloading case will be routed to an event ring that is assigned to the audio DSP. Create vendor ops for the USB SND driver: qc_audio_offload: This particular driver has several components associated with it: - QMI stream request handler - XHCI interrupter and resource management - audio DSP memory management When the audio DSP wants to enable a playback stream, the request is first received by the ASoC platform sound card. Depending on the selected route, ASoC will bring up the individual DAIs in the path. The Q6USB backend DAI will send an AFE port start command (with enabling the USB playback path), and the audio DSP will handle the request accordingly. Part of the AFE USB port start handling will have an exchange of control messages using the QMI protocol. The qc_audio_offload driver will populate the buffer information: - Event ring base address - EP transfer ring base address and pass it along to the audio DSP. All endpoint management will now be handed over to the DSP, and the main processor is not involved in transfers. Overall, implementing this feature will still expose separate sound card and PCM devices for both the platorm card and USB audio device: 0 [SM8250MTPWCD938]: sm8250 - SM8250-MTP-WCD9380-WSA8810-VA-D SM8250-MTP-WCD9380-WSA8810-VA-DMIC 1 [Audio ]: USB-Audio - USB Audio Generic USB Audio at usb-xhci-hcd.1.auto-1.4, high speed This is to ensure that userspace ALSA entities can decide which route to take when executing the audio playback. In the above, if card#1 is selected, then USB audio data will take the legacy path over the USB PCM drivers, etc... This feature was validated using: - tinymix: set/enable the multimedia path to route to USB backend - tinyplay: issue playback on platform card Changelog -------------------------------------------- Changes in v16: - Modified some code layer dependencies so that soc usb can be split as a separate module. - Split the kcontrols from ASoC QCOM common layer into a separate driver - Reworked SOC USB kcontrols for controlling card + pcm offload routing and status so that there are individual controls for card and pcm devices. - Added a kcontrol remove API in SOC USB to remove the controls on the fly. This required to add some kcontrol management to SOC USB. - Removed the disconnect work and workqueue for the QC USB offload as it is not required, since QMI interface driver ensures events are handled in its own WQ. Changes in v15: - Removed some already merged XHCI changes - Separated SOC USB driver from being always compiled into SOC core. Now configurable from kconfig. - Fixed up ASoC kcontrol naming to fit guidelines. - Removed some unnecessary dummy ifdefs. - Moved usb snd offload capable kcontrol to be initialized by the platform offloading driver. Changes in v14: - Cleaned up some USB SND related feedback: - Renamed SNDUSB OFFLD playback available --> USB offload capable card - Fixed locking while checking if stream is in use - Replaced some mutex pairs with guard(mutex) Changes in v13: - Pulled in secondary/primary interrupter rework from Mathias from: https://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git/log/drivers… - Did some cleanup and commit message updates, and tested on current code base. - Added mutex locking to xhci sideband to help prevent any race conditions, esp. for when accessing shared references. - Addresed concerns from Hillf about gfp_flags and locking used in qc_usb_audio_offload. - Rebased onto usb-next Changes in v12: - Updated copyright year to 2024. Happy new years! - Fixed newline format on mixer offload driver. Changes in v11: - Modified QMI format structures to be const Changes in v10: - Added new mixer for exposing kcontrol for sound card created by USB SND. This allows for applications to know which platform sound card has offload support. Will return the card number. - Broke down and cleaned up some functions/APIs within qc_audio_offload driver. - Exported xhci_initialize_ring_info(), and modified XHCI makefile to allow for the XHCI sideband to exist as a module. - Reworked the jack registration and moved it to the QCOM platform card driver, ie sm8250. - Added an SOC USB API to fetch a standard component tag that can be appended to the platform sound card. Added this tag to sm8250 if any USB path exists within the DT node. - Moved kcontrols that existed in the Q6USB driver, and made it a bit more generic, so that naming can be standardized across solutions. SOC USB is now responsible for creation of these kcontrols. - Added a SOC USB RST document explaining some code flows and implementation details so that other vendors can utilize the framework. - Addressed a case where USB device connection events are lost if usb offload driver (qc_audio_offload) is not probed when everything else has been initialized, ie USB SND, SOC USB and ASoC sound card. Add a rediscover device call during module init, to ensure that connection events will be propagated. - Rebased to usb-next. Changes in v9: - Fixed the dt binding check issue with regards to num-hc-interrupters. Changes in v8: - Cleaned up snd_soc_usb_find_priv_data() based on Mark's feedback. Removed some of the duplicate looping code that was present on previous patches. Also renamed the API. - Integrated Mathias' suggestions on his new sideband changes: https://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git/log/?h=feat… - Addressed some of Mathias' fixme tags, such as: - Resetting transfer ring dequeue/enqueue pointers - Issuing stop endpoint command during ep removal - Reset ERDP properly to first segment ring during interrupter removal. (this is currently just being cleared to 0, but should be pointing to a valid segment if controller is still running. Changes in v7: - Fixed dt check error for q6usb bindings - Updated q6usb property from qcom,usb-audio-intr-num --> qcom,usb-audio-intr-idx - Removed separate DWC3 HC interrupters num property, and place limits to XHCI one. - Modified xhci_ring_to_sgtable() to use assigned IOVA/DMA address to fetch pages, as it is not ensured event ring allocated is always done in the vmalloc range. Changes in v6: - Fixed limits and description on several DT bindings (XHCI and Q6USB) - Fixed patch subjects to follow other ALSA/ASoC notations. USB SND - Addressed devices which expose multiple audio (UAC) interfaces. These devices will create a single USB sound card with multiple audio streams, and receive multiple interface probe routines. QC offload was not properly considering cases with multiple probe calls. - Renamed offload module name and kconfig to fit within the SND domain. - Renamed attach/detach endpoint API to keep the hw_params notation. Changes in v5: - Removed some unnescessary files that were included - Fixed some typos mentioned - Addressed dt-binding issues and added hc-interrupters definition to usb-xhci.yaml XHCI: - Moved secondary skip events API to xhci-ring and updated implementation - Utilized existing XHCI APIs, such as inc_deq and xhci_update_erst_dequeue() USB SND - Renamed and reworked the APIs in "sound: usb: Export USB SND APIs for modules" patch to include suggestions to utilize snd_usb_hw_params/free and to avoid generic naming. - Added a resume_cb() op for completion sake. - Addressed some locking concerns with regards to when registering for platform hooks. - Added routine to disconnect all offloaded devices during module unbind. ASoC - Replaced individual PCM parameter arguments in snd_soc_usb_connect() with new snd_soc_usb_device structure to pass along PCM info. - Modified snd_jack set report to notify HEADPHONE event, as we do not support record path. Changes in v4: - Rebased to xhci/for-usb-next - Addressed some dt-bindings comments XHCI: - Pulled in latest changes from Mathias' feature_interrupters branch: https://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git/log/?h=feat… - Fixed commit text and signage for the XHCI sideband/interrupter related changes - Added some logic to address the FIXME tags mentioned throughout the commits, such as handling multi segment rings and building the SGT, locking concerns, and ep cleanup operations. - Removed some fixme tags for conditions that may not be needed/addressed. - Repurposed the new endpoint stop sync API to be utilized in other places. - Fixed potential compile issue if XHCI sideband config is not defined. ASoC: - Added sound jack control into the Q6USB driver. Allows for userpsace to know when an offload capable device is connected. USB SND: - Avoided exporting _snd_pcm_hw_param_set based on Takashi's recommendation. - Split USB QMI packet header definitions into a separate commit. This is used to properly allow the QMI interface driver to parse and route QMI packets accordingly - Added a "depends on" entry when enabling QC audio offload to avoid compile time issues. Changes in v3: - Changed prefix from RFC to PATCH - Rebased entire series to usb-next - Updated copyright years XHCI: - Rebased changes on top of XHCI changes merged into usb-next, and only added changes that were still under discussion. - Added change to read in the "num-hc-interrupters" device property. ASoC: - qusb6 USB backend - Incorporated suggestions to fetch iommu information with existing APIs - Added two new sound kcontrols to fetch offload status and offload device selection. - offload status - will return the card and pcm device in use tinymix -D 0 get 1 --> 1, 0 (offload in progress on card#1 pcm#0) - device selection - set the card and pcm device to enable offload on. Ex.: tinymix -D 0 set 1 2 0 --> sets offload on card#2 pcm#0 (this should be the USB card) USB SND: - Fixed up some locking related concerns for registering platform ops. - Moved callbacks under the register_mutex, so that - Modified APIs to properly pass more information about the USB SND device, so that the Q6USB backend can build a device list/map, in order to monitor offload status and device selection. Changes in v2: XHCI: - Replaced XHCI and HCD changes with Mathias' XHCI interrupter changes in his tree: https://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git/log/?h=feat… Adjustments made to Mathias' changes: - Created xhci-intr.h to export/expose interrupter APIs versus exposing xhci.h. Moved dependent structures to this file as well. (so clients can parse out information from "struct xhci_interrupter") - Added some basic locking when requesting interrupters. - Fixed up some sanity checks. - Removed clearing of the ERSTBA during freeing of the interrupter. (pending issue where SMMU fault occurs if DMA addr returned is 64b - TODO) - Clean up pending events in the XHCI secondary interrupter. While testing USB bus suspend, it was seen that on bus resume, the xHCI HC would run into a command timeout. - Added offloading APIs to xHCI to fetch transfer and event ring information. ASoC: - Modified soc-usb to allow for multiple USB port additions. For this to work, the USB offload driver has to have a reference to the USB backend by adding a "usb-soc-be" DT entry to the device saved into XHCI sysdev. - Created separate dt-bindings for defining USB_RX port. - Increased APR timeout to accommodate the situation where the AFE port start command could be delayed due to having to issue a USB bus resume while handling the QMI stream start command. USB SND: - Added a platform ops during usb_audio_suspend(). This allows for the USB offload driver to halt the audio stream when system enters PM suspend. This ensures the audio DSP is not issuing transfers on the USB bus. - Do not override platform ops if they are already populated. - Introduce a shared status variable between the USB offload and USB SND layers, to ensure that only one path is active at a time. If the USB bus is occupied, then userspace is notified that the path is busy. Mathias Nyman (11): xhci: Add interrupt pending autoclear flag to each interrupter xhci: Add helper to set an interrupters interrupt moderation interval xhci: make isoc_bei_interval variable interrupter specific. xhci: remove unnecessary event_ring_deq parameter from xhci_handle_event() xhci: update event ring dequeue pointer position to controller correctly xhci: move event processing for one interrupter to a separate function xhci: add helper that checks for unhandled events on a event ring xhci: Don't check if the event ring is valid before every event TRB xhci: Decouple handling an event from checking for unhandled events xhci: add helper to stop endpoint and wait for completion xhci: sideband: add initial api to register a sideband entity Wesley Cheng (39): usb: host: xhci: Export enable and disable interrupter APIs usb: host: xhci: Repurpose event handler for skipping interrupter events xhci: export XHCI IMOD setting helper for interrupters usb: host: xhci-sideband: Expose a sideband interrupter enable API usb: host: xhci-mem: Cleanup pending secondary event ring events usb: host: xhci-mem: Allow for interrupter clients to choose specific index ASoC: Add SOC USB APIs for adding an USB backend ASoC: dt-bindings: qcom,q6dsp-lpass-ports: Add USB_RX port ASoC: qcom: qdsp6: Introduce USB AFE port to q6dsp ASoC: qdsp6: q6afe: Increase APR timeout ASoC: qcom: qdsp6: Add USB backend ASoC driver for Q6 ALSA: usb-audio: Introduce USB SND platform op callbacks ALSA: usb-audio: Export USB SND APIs for modules ALSA: usb-audio: Save UAC sample size information usb: dwc3: Specify maximum number of XHCI interrupters usb: host: xhci-plat: Set XHCI max interrupters if property is present ALSA: usb-audio: qcom: Add USB QMI definitions ALSA: usb-audio: qcom: Introduce QC USB SND offloading support ALSA: usb-audio: Check for support for requested audio format ASoC: usb: Add PCM format check API for USB backend ASoC: qcom: qdsp6: Ensure PCM format is supported by USB audio device ALSA: usb-audio: Prevent starting of audio stream if in use ALSA: usb-audio: Do not allow USB offload path if PCM device is in use ASoC: dt-bindings: Add Q6USB backend ASoC: dt-bindings: Update example for enabling USB offload on SM8250 ALSA: usb-audio: qcom: Populate PCM and USB chip information ASoC: qcom: qdsp6: Add support to track available USB PCM devices ASoC: Introduce SND kcontrols to select sound card and PCM device ASoC: qcom: qdsp6: Add SOC USB offload select get/put callbacks ASoC: Introduce SND kcontrols to track USB offloading state ASoC: qcom: qdsp6: Add PCM ops to track current state ASoC: usb: Create SOC USB SND jack kcontrol ASoC: qcom: qdsp6: Add headphone jack for offload connection status ASoC: usb: Fetch ASoC sound card information ALSA: usb-audio: Add USB offloading capable kcontrol ALSA: usb-audio: qcom: Use card and PCM index from QMI request ASoC: usb: Rediscover USB SND devices on USB port add ASoC: qcom: Populate SoC components string ASoC: doc: Add documentation for SOC USB .../devicetree/bindings/sound/qcom,q6usb.yaml | 55 + .../bindings/sound/qcom,sm8250.yaml | 15 + Documentation/sound/soc/index.rst | 1 + Documentation/sound/soc/usb.rst | 611 ++++++ drivers/usb/dwc3/core.c | 12 + drivers/usb/dwc3/core.h | 2 + drivers/usb/dwc3/host.c | 3 + drivers/usb/host/Kconfig | 9 + drivers/usb/host/Makefile | 2 + drivers/usb/host/xhci-mem.c | 39 +- drivers/usb/host/xhci-plat.c | 2 + drivers/usb/host/xhci-ring.c | 240 ++- drivers/usb/host/xhci-sideband.c | 439 ++++ drivers/usb/host/xhci.c | 97 +- drivers/usb/host/xhci.h | 21 +- .../sound/qcom,q6dsp-lpass-ports.h | 1 + include/linux/usb/xhci-sideband.h | 70 + include/sound/q6usboffload.h | 20 + include/sound/soc-usb.h | 182 ++ sound/soc/Kconfig | 9 + sound/soc/Makefile | 2 + sound/soc/qcom/Kconfig | 10 + sound/soc/qcom/Makefile | 2 + sound/soc/qcom/qdsp6/Makefile | 1 + sound/soc/qcom/qdsp6/q6afe-dai.c | 60 + sound/soc/qcom/qdsp6/q6afe.c | 193 +- sound/soc/qcom/qdsp6/q6afe.h | 36 +- sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c | 23 + sound/soc/qcom/qdsp6/q6dsp-lpass-ports.h | 1 + sound/soc/qcom/qdsp6/q6routing.c | 9 + sound/soc/qcom/qdsp6/q6usb.c | 408 ++++ sound/soc/qcom/sm8250.c | 15 +- sound/soc/qcom/usb_offload_utils.c | 51 + sound/soc/qcom/usb_offload_utils.h | 26 + sound/soc/soc-usb.c | 660 ++++++ sound/usb/Kconfig | 25 + sound/usb/Makefile | 2 +- sound/usb/card.c | 109 + sound/usb/card.h | 15 + sound/usb/endpoint.c | 1 + sound/usb/format.c | 1 + sound/usb/helper.c | 1 + sound/usb/pcm.c | 104 +- sound/usb/pcm.h | 11 + sound/usb/qcom/Makefile | 6 + sound/usb/qcom/mixer_usb_offload.c | 65 + sound/usb/qcom/mixer_usb_offload.h | 17 + sound/usb/qcom/qc_audio_offload.c | 1914 +++++++++++++++++ sound/usb/qcom/usb_audio_qmi_v01.c | 892 ++++++++ sound/usb/qcom/usb_audio_qmi_v01.h | 162 ++ 50 files changed, 6485 insertions(+), 167 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6usb.yaml create mode 100644 Documentation/sound/soc/usb.rst create mode 100644 drivers/usb/host/xhci-sideband.c create mode 100644 include/linux/usb/xhci-sideband.h create mode 100644 include/sound/q6usboffload.h create mode 100644 include/sound/soc-usb.h create mode 100644 sound/soc/qcom/qdsp6/q6usb.c create mode 100644 sound/soc/qcom/usb_offload_utils.c create mode 100644 sound/soc/qcom/usb_offload_utils.h create mode 100644 sound/soc/soc-usb.c create mode 100644 sound/usb/qcom/Makefile create mode 100644 sound/usb/qcom/mixer_usb_offload.c create mode 100644 sound/usb/qcom/mixer_usb_offload.h create mode 100644 sound/usb/qcom/qc_audio_offload.c create mode 100644 sound/usb/qcom/usb_audio_qmi_v01.c create mode 100644 sound/usb/qcom/usb_audio_qmi_v01.h

1 51

[v4 PATCH] ALSA: virtio: Fix "Coverity: virtsnd_kctl_tlv_op(): Uninitialized variables" warning.
by Aiswarya Cyriac 16 Feb '24

16 Feb '24

This commit fixes the following warning when building virtio_snd driver. " *** CID 1583619: Uninitialized variables (UNINIT) sound/virtio/virtio_kctl.c:294 in virtsnd_kctl_tlv_op() 288 289 break; 290 } 291 292 kfree(tlv); 293 vvv CID 1583619: Uninitialized variables (UNINIT) vvv Using uninitialized value "rc". 294 return rc; 295 } 296 297 /** 298 * virtsnd_kctl_get_enum_items() - Query items for the ENUMERATED element type. 299 * @snd: VirtIO sound device. " This warning is caused by the absence of the "default" branch in the switch-block, and is a false positive because the kernel calls virtsnd_kctl_tlv_op() only with values for op_flag processed in this block. Also, this commit unifies the cleanup path for all possible control paths in the callback function. Signed-off-by: Anton Yakovlev <anton.yakovlev(a)opensynergy.com> Signed-off-by: Aiswarya Cyriac <aiswarya.cyriac(a)opensynergy.com> Reported-by: coverity-bot <keescook+coverity-bot(a)chromium.org> Addresses-Coverity-ID: 1583619 ("Uninitialized variables") Fixes: d6568e3de42d ("ALSA: virtio: add support for audio controls") --- sound/virtio/virtio_kctl.c | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/sound/virtio/virtio_kctl.c b/sound/virtio/virtio_kctl.c index 0c6ac74aca1e..7aa79c05b464 100644 --- a/sound/virtio/virtio_kctl.c +++ b/sound/virtio/virtio_kctl.c @@ -253,8 +253,8 @@ static int virtsnd_kctl_tlv_op(struct snd_kcontrol *kcontrol, int op_flag, tlv = kzalloc(size, GFP_KERNEL); if (!tlv) { - virtsnd_ctl_msg_unref(msg); - return -ENOMEM; + rc = -ENOMEM; + goto on_msg_unref; } sg_init_one(&sg, tlv, size); @@ -281,14 +281,25 @@ static int virtsnd_kctl_tlv_op(struct snd_kcontrol *kcontrol, int op_flag, hdr->hdr.code = cpu_to_le32(VIRTIO_SND_R_CTL_TLV_COMMAND); - if (copy_from_user(tlv, utlv, size)) + if (copy_from_user(tlv, utlv, size)) { rc = -EFAULT; - else + goto on_msg_unref; + } else { rc = virtsnd_ctl_msg_send(snd, msg, &sg, NULL, false); + } break; + default: + rc = -EINVAL; + /* We never get here - we listed all values for op_flag */ + WARN_ON(1); + goto on_msg_unref; } + kfree(tlv); + return rc; +on_msg_unref: + virtsnd_ctl_msg_unref(msg); kfree(tlv); return rc; -- 2.43.2

3 4

[PATCH] soundwire: bus_type: make sdw_bus_type const
by Ricardo B. Marliere 16 Feb '24

16 Feb '24

Since commit d492cc2573a0 ("driver core: device.h: make struct bus_type a const *"), the driver core can properly handle constant struct bus_type, move the sdw_bus_type variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Suggested-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Signed-off-by: Ricardo B. Marliere <ricardo(a)marliere.net> --- drivers/soundwire/bus_type.c | 2 +- include/linux/soundwire/sdw_type.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c index 9fa93bb923d7..fd65b2360fc1 100644 --- a/drivers/soundwire/bus_type.c +++ b/drivers/soundwire/bus_type.c @@ -72,7 +72,7 @@ int sdw_slave_uevent(const struct device *dev, struct kobj_uevent_env *env) return 0; } -struct bus_type sdw_bus_type = { +const struct bus_type sdw_bus_type = { .name = "soundwire", .match = sdw_bus_match, }; diff --git a/include/linux/soundwire/sdw_type.h b/include/linux/soundwire/sdw_type.h index d8c27f1e5559..b445f7200f06 100644 --- a/include/linux/soundwire/sdw_type.h +++ b/include/linux/soundwire/sdw_type.h @@ -4,7 +4,7 @@ #ifndef __SOUNDWIRE_TYPES_H #define __SOUNDWIRE_TYPES_H -extern struct bus_type sdw_bus_type; +extern const struct bus_type sdw_bus_type; extern struct device_type sdw_slave_type; extern struct device_type sdw_master_type; --- base-commit: 9282cfa2eb080e3bbb95f488af35618b614cdf76 change-id: 20240213-bus_cleanup-soundwire-8b56c6862ef1 Best regards, -- Ricardo B. Marliere <ricardo(a)marliere.net>

3 2

[PATCH] ALSA: usb-audio: More relaxed check of MIDI jack names
by Takashi Iwai 15 Feb '24

15 Feb '24

The USB audio driver tries to retrieve MIDI jack name strings that can be used for rawmidi substream names and sequencer port names, but its checking is too strict: often the firmware provides the jack info for unexpected directions, and then we miss the info although it's present. In this patch, the code to extract the jack info is changed to allow both in and out directions in a single loop. That is, the former two functions to obtain the descriptor pointers for jack in and out are changed to a single function that returns iJack of the corresponding jack ID, no matter which direction is used. It's a code simplification at the same time as well as the fix. Fixes: eb596e0fd13c ("ALSA: usb-audio: generate midi streaming substream names from jack names") Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/usb/midi.c | 77 +++++++++++++++++------------------------------- 1 file changed, 27 insertions(+), 50 deletions(-) diff --git a/sound/usb/midi.c b/sound/usb/midi.c index 6b0993258e03..c1f2e5a03de9 100644 --- a/sound/usb/midi.c +++ b/sound/usb/midi.c @@ -1742,50 +1742,44 @@ static void snd_usbmidi_get_port_info(struct snd_rawmidi *rmidi, int number, } } -static struct usb_midi_in_jack_descriptor *find_usb_in_jack_descriptor( - struct usb_host_interface *hostif, uint8_t jack_id) +/* return iJack for the corresponding jackID */ +static int find_usb_ijack(struct usb_host_interface *hostif, uint8_t jack_id) { unsigned char *extra = hostif->extra; int extralen = hostif->extralen; + struct usb_descriptor_header *h; + struct usb_midi_out_jack_descriptor *outjd; + struct usb_midi_in_jack_descriptor *injd; + size_t sz; while (extralen > 4) { - struct usb_midi_in_jack_descriptor *injd = - (struct usb_midi_in_jack_descriptor *)extra; + h = (struct usb_descriptor_header *)extra; + if (h->bDescriptorType != USB_DT_CS_INTERFACE) + goto next; - if (injd->bLength >= sizeof(*injd) && - injd->bDescriptorType == USB_DT_CS_INTERFACE && - injd->bDescriptorSubtype == UAC_MIDI_IN_JACK && - injd->bJackID == jack_id) - return injd; - if (!extra[0]) - break; - extralen -= extra[0]; - extra += extra[0]; - } - return NULL; -} - -static struct usb_midi_out_jack_descriptor *find_usb_out_jack_descriptor( - struct usb_host_interface *hostif, uint8_t jack_id) -{ - unsigned char *extra = hostif->extra; - int extralen = hostif->extralen; - - while (extralen > 4) { - struct usb_midi_out_jack_descriptor *outjd = - (struct usb_midi_out_jack_descriptor *)extra; - - if (outjd->bLength >= sizeof(*outjd) && - outjd->bDescriptorType == USB_DT_CS_INTERFACE && + outjd = (struct usb_midi_out_jack_descriptor *)h; + if (h->bLength >= sizeof(*outjd) && outjd->bDescriptorSubtype == UAC_MIDI_OUT_JACK && - outjd->bJackID == jack_id) - return outjd; + outjd->bJackID == jack_id) { + sz = USB_DT_MIDI_OUT_SIZE(outjd->bNrInputPins); + if (outjd->bLength < sz) + goto next; + return *(extra + sz - 1); + } + + injd = (struct usb_midi_in_jack_descriptor *)h; + if (injd->bLength >= sizeof(*injd) && + injd->bDescriptorSubtype == UAC_MIDI_IN_JACK && + injd->bJackID == jack_id) + return injd->iJack; + +next: if (!extra[0]) break; extralen -= extra[0]; extra += extra[0]; } - return NULL; + return 0; } static void snd_usbmidi_init_substream(struct snd_usb_midi *umidi, @@ -1796,13 +1790,10 @@ static void snd_usbmidi_init_substream(struct snd_usb_midi *umidi, const char *name_format; struct usb_interface *intf; struct usb_host_interface *hostif; - struct usb_midi_in_jack_descriptor *injd; - struct usb_midi_out_jack_descriptor *outjd; uint8_t jack_name_buf[32]; uint8_t *default_jack_name = "MIDI"; uint8_t *jack_name = default_jack_name; uint8_t iJack; - size_t sz; int res; struct snd_rawmidi_substream *substream = @@ -1816,21 +1807,7 @@ static void snd_usbmidi_init_substream(struct snd_usb_midi *umidi, intf = umidi->iface; if (intf && jack_id >= 0) { hostif = intf->cur_altsetting; - iJack = 0; - if (stream != SNDRV_RAWMIDI_STREAM_OUTPUT) { - /* in jacks connect to outs */ - outjd = find_usb_out_jack_descriptor(hostif, jack_id); - if (outjd) { - sz = USB_DT_MIDI_OUT_SIZE(outjd->bNrInputPins); - if (outjd->bLength >= sz) - iJack = *(((uint8_t *) outjd) + sz - sizeof(uint8_t)); - } - } else { - /* and out jacks connect to ins */ - injd = find_usb_in_jack_descriptor(hostif, jack_id); - if (injd) - iJack = injd->iJack; - } + iJack = find_usb_ijack(hostif, jack_id); if (iJack != 0) { res = usb_string(umidi->dev, iJack, jack_name_buf, ARRAY_SIZE(jack_name_buf)); -- 2.35.3

1 0