January 2024 - Alsa-devel - mailman.alsa-project.org

Re: Fwd: No sound drivers on HP Envy x360 ey0xxx
by voreck-lukas＠tutanota.com 04 Jan '24

04 Jan '24

I hope I'm responding correctly On bugzilla I was asked to attach dmesg and lspci output. I'm sending both as attachments (cause of their length) and hope it works, it's my first time working with these mailing lists.

4 5

[GIT PULL] ASoC fixes for v6.7-rc8
by Mark Brown 04 Jan '24

04 Jan '24

The following changes since commit 8f0f01647550daf9cd8752c1656dcb0136d79ce1: ASoC: fsl_sai: Fix channel swap issue on i.MX8MP (2023-12-19 13:23:39 +0000) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-fix-v6.7-rc8 for you to fetch changes up to b036d8ef3120b996751495ce25994eea58032a98: ASoC: meson: g12a-tohdmitx: Fix event generation for S/PDIF mux (2024-01-03 18:37:02 +0000) ---------------------------------------------------------------- ASoC: Fixes for v6.7 I recently got a LibreTech Sapphire board for my CI and while integrating it found and fixed some issues, including crashes for the enum validation. There's also a couple of patches adding quirks for another x86 laptop from Hans and an error handling fix for the Freescale rpmsg driver. ---------------------------------------------------------------- Chancel Liu (1): ASoC: fsl_rpmsg: Fix error handler with pm_runtime_enable Eugen Hristev (1): ASoC: mediatek: mt8186: fix AUD_PAD_TOP register and offset Mark Brown (4): ASoC: meson: g12a-toacodec: Validate written enum values ASoC: meson: g12a-tohdmitx: Validate written enum values ASoC: meson: g12a-toacodec: Fix event generation ASoC: meson: g12a-tohdmitx: Fix event generation for S/PDIF mux sound/soc/fsl/fsl_rpmsg.c | 10 ++++++++-- sound/soc/mediatek/mt8186/mt8186-dai-adda.c | 2 +- sound/soc/meson/g12a-toacodec.c | 5 ++++- sound/soc/meson/g12a-tohdmitx.c | 8 +++++++- 4 files changed, 20 insertions(+), 5 deletions(-)

2 1

[PATCH] ALSA: hda/realtek: Fix mute and mic-mute LEDs for HP ProBook 440 G6
by Siddhesh Dharme 04 Jan '24

04 Jan '24

LEDs in 'HP ProBook 440 G6' laptop are controlled by ALC236 codec. Enable already existing quirk 'ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF' to fix mute and mic-mute LEDs. Signed-off-by: Siddhesh Dharme <siddheshdharme18(a)gmail.com> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index c80e2f3ac..1dcfba27e 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9825,6 +9825,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x84da, "HP OMEN dc0019-ur", ALC295_FIXUP_HP_OMEN), SND_PCI_QUIRK(0x103c, 0x84e7, "HP Pavilion 15", ALC269_FIXUP_HP_MUTE_LED_MIC3), SND_PCI_QUIRK(0x103c, 0x8519, "HP Spectre x360 15-df0xxx", ALC285_FIXUP_HP_SPECTRE_X360), + SND_PCI_QUIRK(0x103c, 0x8537, "HP ProBook 440 G6", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), SND_PCI_QUIRK(0x103c, 0x860f, "HP ZBook 15 G6", ALC285_FIXUP_HP_GPIO_AMP_INIT), SND_PCI_QUIRK(0x103c, 0x861f, "HP Elite Dragonfly G1", ALC285_FIXUP_HP_GPIO_AMP_INIT), SND_PCI_QUIRK(0x103c, 0x869d, "HP", ALC236_FIXUP_HP_MUTE_LED), -- 2.43.0

1 0

[PATCH 0/4] ASoC: meson: Fix issues with LibreTech Saphire
by Mark Brown 03 Jan '24

03 Jan '24

This fixes a few issues I identified when integrating a LibreTech Saphire (based on S905D3) into my CI. Signed-off-by: Mark Brown <broonie(a)kernel.org> --- Mark Brown (4): ASoC: meson: g12a-toacodec: Validate written enum values ASoC: meson: g12a-tohdmitx: Validate written enum values ASoC: meson: g12a-toacodec: Fix event generation ASoC: meson: g12a-tohdmitx: Fix event generation for S/PDIF mux sound/soc/meson/g12a-toacodec.c | 5 ++++- sound/soc/meson/g12a-tohdmitx.c | 8 +++++++- 2 files changed, 11 insertions(+), 2 deletions(-) --- base-commit: 610a9b8f49fbcf1100716370d3b5f6f884a2835a change-id: 20240103-meson-enum-val-c8e4b2f01077 Best regards, -- Mark Brown <broonie(a)kernel.org>

1 5

Re: Oops in hdac_hda_dev_probe (6.7-rc7)
by Takashi Iwai 03 Jan '24

03 Jan '24

On Wed, 27 Dec 2023 08:37:07 +0100, Dominik Brodowski wrote: > > Hi, > > unfortunately, the latest 6.7.0-rc7 and the two previous rc kernels cause an > oops in hdac_hda_dev_probe(); sound and resume-from-suspend subsequently do > not work: > > > BUG: kernel NULL pointer dereference, address: 0000000000000078 > #PF: supervisor read access in kernel mode > #PF: error_code(0x0000) - not-present page > PGD 0 > P4D 0 > Oops: 0000 [#1] PREEMPT SMP NOPTI > Hardware name: Dell Inc. XPS 9315/00KRKP, BIOS 1.1.3 05/11/2022 > Workqueue: events sof_probe_work > > RIP: 0010:hdac_hda_dev_probe+0x42/0xf0 > Code: 48 8b 37 48 8b bb c8 04 00 00 e8 09 9b 0a 00 48 85 c0 48 89 c5 0f 84 a6 00 00 00 48 8b bb c8 04 00 00 48 89 c6 e8 1e 9a 0a 00 <41> 80 7c 24 78 00 75 46 b9 03 00 00 00 48 c7 c2 c0 b2 a1 ac 48 c7 > RSP: 0000:ffffc90000207b50 EFLAGS: 00010246 > > RAX: 0000000000000000 RBX: ffff88811495d000 RCX: 0000000000000000 > RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 > RBP: ffff888108691600 R08: 0000000000000000 R09: 0000000000000000 > R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 > R13: 0000000000000000 R14: 0000000000000000 R15: ffff88811400b028 > FS: 0000000000000000(0000) GS:ffff88886f500000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 0000000000000078 CR3: 00000002b7a5a000 CR4: 0000000000f50ef0 > PKRU: 55555554 > Call Trace: > <TASK> > ? __die+0x1e/0x70 > ? page_fault_oops+0x17c/0x4b0 > ? snd_hdac_ext_bus_link_get+0x24/0xc0 > ? exc_page_fault+0x462/0x8e0 > ? asm_exc_page_fault+0x26/0x30 > ? hdac_hda_dev_probe+0x42/0xf0 > really_probe+0x166/0x300 > ? __pfx___device_attach_driver+0x10/0x10 > __driver_probe_device+0x6e/0x120 > driver_probe_device+0x1a/0x90 > __device_attach_driver+0x8e/0xd0 > bus_for_each_drv+0x90/0xf0 > __device_attach+0xac/0x1a0 > bus_probe_device+0x93/0xb0 > device_add+0x669/0x860 > snd_hdac_device_register+0x10/0x60 > hda_codec_probe_bus+0x189/0x290 > hda_dsp_probe+0x211/0x550 > sof_probe_work+0x2c/0x430 > ? process_one_work+0x19c/0x500 > process_one_work+0x205/0x500 > worker_thread+0x1dc/0x3e0 > > ? __pfx_worker_thread+0x10/0x10 > kthread+0xea/0x120 > ? __pfx_kthread+0x10/0x10 > ret_from_fork+0x2c/0x50 > ? __pfx_kthread+0x10/0x10 > ret_from_fork_asm+0x1b/0x30 > </TASK> > Modules linked in: > CR2: 0000000000000078 > ---[ end trace 0000000000000000 ]--- > RIP: 0010:hdac_hda_dev_probe+0x42/0xf0 > Code: 48 8b 37 48 8b bb c8 04 00 00 e8 09 9b 0a 00 48 85 c0 48 89 c5 0f 84 a6 00 00 00 48 8b bb c8 04 00 00 48 89 c6 e8 1e 9a 0a 00 <41> 80 7c 24 78 00 75 46 b9 03 00 00 00 48 c7 c2 c0 b2 a1 ac 48 c7 > RSP: 0000:ffffc90000207b50 EFLAGS: 00010246 > RAX: 0000000000000000 RBX: ffff88811495d000 RCX: 0000000000000000 > RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 > RBP: ffff888108691600 R08: 0000000000000000 R09: 0000000000000000 > R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 > R13: 0000000000000000 R14: 0000000000000000 R15: ffff88811400b028 > FS: 0000000000000000(0000) GS:ffff88886f500000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 0000000000000078 CR3: 00000002b7a5a000 CR4: 0000000000f50ef0 > PKRU: 55555554 > note: kworker/2:0[24] exited with irqs disabled > > > I was able to bisect the issue to commit a0575b4add21 ("ASoC: hdac_hda: > Conditionally register dais for HDMI and Analog"). Reverting that patch on > top of mainline fixes it. As I've been (and still am) off, I had too little time for taking a deeper look now, unfortunately. But my wild guess is that it's a NULL dereference of the hdac_hda_priv referred via hdac dev. If it's correct, a oneliner like below should work around the crash. Could you give it a try? thanks, Takashi -- 8< -- --- a/sound/soc/codecs/hdac_hda.c +++ b/sound/soc/codecs/hdac_hda.c @@ -630,7 +630,7 @@ static int hdac_hda_dev_probe(struct hdac_device *hdev) snd_hdac_ext_bus_link_get(hdev->bus, hlink); /* ASoC specific initialization */ - if (hda_pvt->need_display_power) + if (hda_pvt && hda_pvt->need_display_power) ret = devm_snd_soc_register_component(&hdev->dev, &hdac_hda_hdmi_codec, hdac_hda_hdmi_dais, ARRAY_SIZE(hdac_hda_hdmi_dais));

4 11

[PATCH] ALSA: hda: cs35l41: fix building without CONFIG_SPI
by Arnd Bergmann 03 Jan '24

03 Jan '24

From: Arnd Bergmann <arnd(a)arndb.de> When CONFIG_SPI is disabled, the driver produces unused-variable warning: sound/pci/hda/cs35l41_hda_property.c: In function 'generic_dsd_config': sound/pci/hda/cs35l41_hda_property.c:181:28: error: unused variable 'spi' [-Werror=unused-variable] 181 | struct spi_device *spi; | ^~~ sound/pci/hda/cs35l41_hda_property.c:180:27: error: unused variable 'cs_gpiod' [-Werror=unused-variable] 180 | struct gpio_desc *cs_gpiod; | ^~~~~~~~ Avoid these by turning the preprocessor contionals into equivalent C code, which also helps readability. Fixes: 916d051730ae ("ALSA: hda: cs35l41: Only add SPI CS GPIO if SPI is enabled in kernel") Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- sound/pci/hda/cs35l41_hda_property.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c index 52820ca9c603..a51fb6b0f56d 100644 --- a/sound/pci/hda/cs35l41_hda_property.c +++ b/sound/pci/hda/cs35l41_hda_property.c @@ -215,7 +215,6 @@ static int generic_dsd_config(struct cs35l41_hda *cs35l41, struct device *physde if (cs35l41->control_bus == SPI) { cs35l41->index = id; -#if IS_ENABLED(CONFIG_SPI) /* * Manually set the Chip Select for the second amp <cs_gpio_index> in the node. * This is only supported for systems with 2 amps, since we cannot expand the @@ -224,7 +223,7 @@ static int generic_dsd_config(struct cs35l41_hda *cs35l41, struct device *physde * uses a native chip select), to ensure the second amp does not clash with the * first. */ - if (cfg->cs_gpio_index >= 0) { + if (IS_ENABLED(CONFIG_SPI) && cfg->cs_gpio_index >= 0) { spi = to_spi_device(cs35l41->dev); if (cfg->num_amps != 2) { @@ -255,7 +254,6 @@ static int generic_dsd_config(struct cs35l41_hda *cs35l41, struct device *physde spi_setup(spi); } } -#endif } else { if (cfg->num_amps > 2) /* -- 2.39.2

2 1

[PATCH v4] ASoc: tas2783: Add tas2783 codec driver
by Shenghao Ding 03 Jan '24

03 Jan '24

2 1

[PATCH v3] ALSA: hda: cs35l41: Support more HP models without _DSD
by Lorenz Brun 03 Jan '24

03 Jan '24

This adds overrides for a series of notebooks using a common config taken from HP's proprietary Windows driver. This has been tested on a HP 15-ey0xxxx device (subsystem 103C8A31) together with another Realtek quirk and the calibration files from the proprietary driver. Signed-off-by: Lorenz Brun <lorenz(a)brun.one> --- Changes in v2: - Use newly-introduced config table instead of function - Change boost cap value from 10uF to 24uF after cross-referencing my sources with the preexisting 103C89C6 entry. Changes in v3: - Rebase onto sound/for-next - Sorted model table - Updated commit message sound/pci/hda/cs35l41_hda_property.c | 44 ++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c index 52820ca9c603..fcc605be51cf 100644 --- a/sound/pci/hda/cs35l41_hda_property.c +++ b/sound/pci/hda/cs35l41_hda_property.c @@ -42,6 +42,28 @@ static const struct cs35l41_config cs35l41_config_table[] = { * in the ACPI. The Reset GPIO is also valid, so we can use the Reset defined in _DSD. */ { "103C89C6", 2, INTERNAL, { CS35L41_RIGHT, CS35L41_LEFT, 0, 0 }, -1, -1, -1, 1000, 4500, 24 }, + { "103C8A28", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 }, + { "103C8A29", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 }, + { "103C8A2A", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 }, + { "103C8A2B", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 }, + { "103C8A2C", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 }, + { "103C8A2D", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 }, + { "103C8A2E", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 }, + { "103C8A30", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 }, + { "103C8A31", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 }, + { "103C8BB3", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 }, + { "103C8BB4", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 }, + { "103C8BDF", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 }, + { "103C8BE0", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 }, + { "103C8BE1", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 }, + { "103C8BE2", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 }, + { "103C8BE9", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 }, + { "103C8BDD", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 }, + { "103C8BDE", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 }, + { "103C8BE3", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 }, + { "103C8BE5", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 }, + { "103C8BE6", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 }, + { "103C8B3A", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 }, { "104312AF", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 }, { "10431433", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 }, { "10431463", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 }, @@ -356,6 +378,28 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = { { "CSC3551", "10280BEB", generic_dsd_config }, { "CSC3551", "10280C4D", generic_dsd_config }, { "CSC3551", "103C89C6", generic_dsd_config }, + { "CSC3551", "103C8A28", generic_dsd_config }, + { "CSC3551", "103C8A29", generic_dsd_config }, + { "CSC3551", "103C8A2A", generic_dsd_config }, + { "CSC3551", "103C8A2B", generic_dsd_config }, + { "CSC3551", "103C8A2C", generic_dsd_config }, + { "CSC3551", "103C8A2D", generic_dsd_config }, + { "CSC3551", "103C8A2E", generic_dsd_config }, + { "CSC3551", "103C8A30", generic_dsd_config }, + { "CSC3551", "103C8A31", generic_dsd_config }, + { "CSC3551", "103C8BB3", generic_dsd_config }, + { "CSC3551", "103C8BB4", generic_dsd_config }, + { "CSC3551", "103C8BDF", generic_dsd_config }, + { "CSC3551", "103C8BE0", generic_dsd_config }, + { "CSC3551", "103C8BE1", generic_dsd_config }, + { "CSC3551", "103C8BE2", generic_dsd_config }, + { "CSC3551", "103C8BE9", generic_dsd_config }, + { "CSC3551", "103C8BDD", generic_dsd_config }, + { "CSC3551", "103C8BDE", generic_dsd_config }, + { "CSC3551", "103C8BE3", generic_dsd_config }, + { "CSC3551", "103C8BE5", generic_dsd_config }, + { "CSC3551", "103C8BE6", generic_dsd_config }, + { "CSC3551", "103C8B3A", generic_dsd_config }, { "CSC3551", "104312AF", generic_dsd_config }, { "CSC3551", "10431433", generic_dsd_config }, { "CSC3551", "10431463", generic_dsd_config }, -- 2.42.0

1 0

ASoC: dt-bindings: Query on audio-graph-card DT binding
by Sameer Pujar 03 Jan '24

03 Jan '24

Hi Rob, Mark, Morimoto-san Build error in the example mentioned earlier seems to be expected since it requires one to one connection between remote endpoints. Pasting the error I get: DTC arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dtb dtc: scripts/dtc/livetree.c:437: propval_cell: Assertion `prop->val.len == sizeof(cell_t)' failed. Aborted (core dumped) make[3]: *** [scripts/Makefile.lib:419: arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dtb] Error 134 make[2]: *** [scripts/Makefile.build:480: arch/arm64/boot/dts/nvidia] Error 2 make[1]: *** [/home/spujar/upstream/kernel/Makefile:1476: dtbs] Error 2 make[1]: *** Waiting for unfinished jobs.... CALL scripts/checksyscalls.sh make: *** [Makefile:234: __sub-make] Error 2 Execution failed. Given this, how an endpoint can be shared? Is only solution is to create dummy endpoints for CPU and connect them to each codec? Can you please suggest how this can be addressed? > Hi Morimoto-san, > > This question is regarding audio-graph-card.c driver related DT binding. > > I am looking to enable following DAI link connection in device tree > for Tegra audio: > > /-----> codec1 endpoint > / > CPU endpoint \ > \-----> codec2 endpoint > > > I see that, "remote-endpoint" property can only specify single phandle > object for connection to a remote endpoint. In other words, the link > can be one-to-one. For illustration, please see below example. However > I see it leads to a build error if phandle-array is provided for > "remote-endpoint" property. > > cpu_port { > cpu_ep: endpoint { > remote-endpoint = <&codec1_ep>, <&codec2_ep>; > }; > }; > > codec1 { > codec1_ep: endpoint { > remote-endpoint = <&cpu_ep>; > }; > }; > > codec2 { > codec2_ep: endpoint { > remote-endpoint = <&cpu_ep>; > }; > }; > > Is there a possibility to re-use the same CPU endpoint for connecting > to multiple codec endpoints like shown in above example? >

1 0

Re: Oops in hdac_hda_dev_probe (6.7-rc7)
by Willian Wang 02 Jan '24

02 Jan '24

Hi, just tested the patch and both sound and resume-from-suspend are working like 6.6 again 👍

1 0