September 2023 - Alsa-devel - mailman.alsa-project.org

RE: Re: [PATCH] ASoC: dwc: fix typo in comment
by 김명욱 12 Sep '23

12 Sep '23

ISR_RXFO means \"Status of Data Overrun interrupt for the RX channel\" according to the datasheetSo, the comment should be RX, not TXThanksMyunguk------------Original Message------------Subject : Re: [PATCH] ASoC: dwc: fix typo in commentDate : 2023-09-11 21:46:05From : Bagas Sanjaya <bagasdotme@gmailcom>To : Myunguk Kim <mwkim@gaonchipscom>, alsa-devel@alsa-projectorgCc : Liam Girdwood <lgirdwood@gmailcom>, Mark Brown <broonie@kernelorg>, Jaroslav Kysela <perex@perexcz>, Takashi Iwai <tiwai@susecom>, Maxim Kochetkov <fido_max@inboxru>, Kuninori Morimoto <kuninorimorimotogx@renesascom>, Xingyu Wu <xingyuwu@starfivetechcom>, Uwe Kleine-König <ukleine-koenig@pengutronixde>, linux-kernel@vgerkernelorgOn Mon, Sep 11, 2023 at 03:46:46PM +0900, Myunguk Kim wrote:> This fixes typo in commentOn what? Can you describe the typofix in more detail?>> Signed-off-by: Myunguk Kim <mwkim@gaonchipscom>> ---> sound/soc/dwc/dwc-i2sc | 2 +-> 1 file changed, 1 insertion(+), 1 deletion(-)>> diff --git a/sound/soc/dwc/dwc-i2sc b/sound/soc/dwc/dwc-i2sc> index 71ff894035a445e55e550924 100644> --- a/sound/soc/dwc/dwc-i2sc> +++ b/sound/soc/dwc/dwc-i2sc> @@ -138,7 +138,7 @@ static irqreturn_t i2s_irq_handler(int irq, void *dev_id)> irq_valid = true;> }>> - /* Error Handling: TX */> + /* Error Handling: RX */> if (isr[i] & ISR_RXFO)> { dev_err_ratelimited(dev->dev, \"RX overrun (ch_id=%d)\\n\", i);> irq_valid = true;Oh, you mean the code following the comment checks for RXFO overrunConfused--An old man doll just what I always wanted! - Clara

1 0

[PATCH] ASoC: fsl: imx-pcm-rpmsg: Add SNDRV_PCM_INFO_BATCH flag
by Shengjiu Wang 12 Sep '23

12 Sep '23

The rpmsg pcm device is a device which should support double buffering. Found this issue with pipewire. When there is no SNDRV_PCM_INFO_BATCH flag in driver, the pipewire will set headroom to be zero, and because rpmsg pcm device don't support residue report, when the latency setting is small, the "delay" always larger than "target" in alsa-pcm.c, that reading next period data is not scheduled on time. With SNDRV_PCM_INFO_BATCH flag in driver, the pipewire will select a smaller period size for device, then the task of reading next period data will be scheduled on time. Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> --- sound/soc/fsl/imx-pcm-rpmsg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/fsl/imx-pcm-rpmsg.c b/sound/soc/fsl/imx-pcm-rpmsg.c index d63782b8bdef..bb736d45c9e0 100644 --- a/sound/soc/fsl/imx-pcm-rpmsg.c +++ b/sound/soc/fsl/imx-pcm-rpmsg.c @@ -19,6 +19,7 @@ static struct snd_pcm_hardware imx_rpmsg_pcm_hardware = { .info = SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BLOCK_TRANSFER | + SNDRV_PCM_INFO_BATCH | SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_MMAP_VALID | SNDRV_PCM_INFO_NO_PERIOD_WAKEUP | -- 2.34.1

2 1

[PATCH v2 0/2] Fix redundant PLLA update
by Sameer Pujar 12 Sep '23

12 Sep '23

This small series fixes redundant PLLA updates that happen for each DAI link in the audio path. This helps to resolve DMIC clock issue seen on Jetson TX2 platform. Sameer Pujar (2): ASoC: soc-utils: Export snd_soc_dai_is_dummy() symbol ASoC: tegra: Fix redundant PLLA and PLLA_OUT0 updates sound/soc/soc-utils.c | 1 + sound/soc/tegra/tegra_audio_graph_card.c | 30 ++++++++++++++---------- 2 files changed, 18 insertions(+), 13 deletions(-) -- 2.17.1

2 3

[PATCH v2 00/11] Improve CS35l41-based audio codec drivers
by Cristian Ciocaltea 12 Sep '23

12 Sep '23

This patch series contains several fixes and improvements to drivers based on the CS35l41 audio codec. It has been verified on Valve's Steam Deck, except the HDA related patches. Changes in v2: - Added Acked-by tags from Charles - Reworked the shared boost handling per reviews from Charles and David - Dropped PATCH 5/9 and moved PATCH 6/9 a bit down the list, as it doesn't contain a Fixes tag - Reverted usage of devm_pm_runtime_enable() in PATCH 9/9 and replaced with a proper runtime PM changes undo in PATCH v2 06/11 - Added 3 new patches providing some HDA related fixes - v1: https://lore.kernel.org/all/20230902210621.1184693-1-cristian.ciocaltea@col… Cristian Ciocaltea (11): ASoC: cs35l41: Handle mdsync_down reg write errors ASoC: cs35l41: Handle mdsync_up reg write errors ASoC: cs35l41: Initialize completion object before requesting IRQ ASoC: cs35l41: Fix broken shared boost activation ASoC: cs35l41: Verify PM runtime resume errors in IRQ handler ASoC: cs35l41: Undo runtime PM changes at driver exit time ASoC: cs35l41: Make use of dev_err_probe() ASoC: cs35l41: Use modern pm_ops ALSA: hda: cs35l41: Fix unbalanced pm_runtime_get() ALSA: hda: cs35l41: Undo runtime PM changes at driver exit time ALSA: hda: cs35l41: Consistently use dev_err_probe() include/sound/cs35l41.h | 4 +- sound/pci/hda/cs35l41_hda.c | 23 +++++---- sound/soc/codecs/cs35l41-i2c.c | 11 ++-- sound/soc/codecs/cs35l41-lib.c | 60 +++++++++++++--------- sound/soc/codecs/cs35l41-spi.c | 11 ++-- sound/soc/codecs/cs35l41.c | 93 +++++++++++++++++++--------------- sound/soc/codecs/cs35l41.h | 1 - 7 files changed, 112 insertions(+), 91 deletions(-) -- 2.41.0

4 16

[PATCH v2 0/7] ASoC: Convert some Maxim codecs to use GPIO descriptors
by Linus Walleij 12 Sep '23

12 Sep '23

The Maxim devices are pretty straight-forward to convert over to use GPIO descriptors, so let's do it. Tested with some x86_64 allmodconfig and aarch64 allmodconfig to smoke out the worst bugs this time. Signed-off-by: Linus Walleij <linus.walleij(a)linaro.org> --- Changes in v2: - Rebased on v6.6-rc1 - Link to v1: https://lore.kernel.org/r/20230825-descriptors-asoc-max-v1-0-b212292b2f08@l… --- Linus Walleij (7): ASoC: max9768: Convert to use GPIO descriptors ASoC: max98357a: Drop pointless include ASoC: max98373: Convert to use GPIO descriptors ASoC: max98388: Correct the includes ASoC: max98396: Drop pointless include ASoC: max98520: Drop pointless includes ASoC: max98927: Drop pointless includes include/sound/max9768.h | 4 ---- sound/soc/codecs/max9768.c | 45 +++++++++++++++++++++-------------------- sound/soc/codecs/max98357a.c | 1 - sound/soc/codecs/max98373-i2c.c | 17 ---------------- sound/soc/codecs/max98373.c | 35 +++++++++++++++++--------------- sound/soc/codecs/max98373.h | 2 +- sound/soc/codecs/max98388.c | 3 +-- sound/soc/codecs/max98396.c | 1 - sound/soc/codecs/max98520.c | 2 -- sound/soc/codecs/max98927.c | 2 -- 10 files changed, 44 insertions(+), 68 deletions(-) --- base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d change-id: 20230817-descriptors-asoc-max-b71ac02bf1ff Best regards, -- Linus Walleij <linus.walleij(a)linaro.org>

2 8

[PATCH v3 1/4] ASoC: cs35l45: Checks index of cs35l45_irqs[]
by Vlad Karpovich 12 Sep '23

12 Sep '23

From: Ricardo Rivera-Matos <rriveram(a)opensource.cirrus.com> Checks the index computed by the virq offset before printing the error condition in cs35l45_spk_safe_err() handler. Signed-off-by: Ricardo Rivera-Matos <rriveram(a)opensource.cirrus.com> Signed-off-by: Vlad Karpovich <vkarpovi(a)opensource.cirrus.com> --- sound/soc/codecs/cs35l45.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/cs35l45.c b/sound/soc/codecs/cs35l45.c index 2ac4612402eb..02b1172d2647 100644 --- a/sound/soc/codecs/cs35l45.c +++ b/sound/soc/codecs/cs35l45.c @@ -1023,7 +1023,10 @@ static irqreturn_t cs35l45_spk_safe_err(int irq, void *data) i = irq - regmap_irq_get_virq(cs35l45->irq_data, 0); - dev_err(cs35l45->dev, "%s condition detected!\n", cs35l45_irqs[i].name); + if (i < 0 || i >= ARRAY_SIZE(cs35l45_irqs)) + dev_err(cs35l45->dev, "Unspecified global error condition (%d) detected!\n", irq); + else + dev_err(cs35l45->dev, "%s condition detected!\n", cs35l45_irqs[i].name); return IRQ_HANDLED; } -- 2.25.1

4 12

[PATCH] ASoC: meson: axg: extend TDM maximum sample rate to 384kHz
by Jerome Brunet 12 Sep '23

12 Sep '23

The TDM HW on the axg SoC families and derivatives actually supports 384kHz sampling rate. Update the fifo and tdm interface constraints accordingly. Signed-off-by: Jerome Brunet <jbrunet(a)baylibre.com> --- sound/soc/meson/axg-fifo.c | 2 +- sound/soc/meson/axg-fifo.h | 2 +- sound/soc/meson/axg-tdm.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/meson/axg-fifo.c b/sound/soc/meson/axg-fifo.c index bccfb770b339..2e3d0108179b 100644 --- a/sound/soc/meson/axg-fifo.c +++ b/sound/soc/meson/axg-fifo.c @@ -31,7 +31,7 @@ static struct snd_pcm_hardware axg_fifo_hw = { SNDRV_PCM_INFO_NO_PERIOD_WAKEUP), .formats = AXG_FIFO_FORMATS, .rate_min = 5512, - .rate_max = 192000, + .rate_max = 384000, .channels_min = 1, .channels_max = AXG_FIFO_CH_MAX, .period_bytes_min = AXG_FIFO_BURST, diff --git a/sound/soc/meson/axg-fifo.h b/sound/soc/meson/axg-fifo.h index b63acd723c87..df528e8cb7c9 100644 --- a/sound/soc/meson/axg-fifo.h +++ b/sound/soc/meson/axg-fifo.h @@ -22,7 +22,7 @@ struct snd_soc_pcm_runtime; #define AXG_FIFO_CH_MAX 128 #define AXG_FIFO_RATES (SNDRV_PCM_RATE_5512 | \ - SNDRV_PCM_RATE_8000_192000) + SNDRV_PCM_RATE_8000_384000) #define AXG_FIFO_FORMATS (SNDRV_PCM_FMTBIT_S8 | \ SNDRV_PCM_FMTBIT_S16_LE | \ SNDRV_PCM_FMTBIT_S20_LE | \ diff --git a/sound/soc/meson/axg-tdm.h b/sound/soc/meson/axg-tdm.h index 5774ce0916d4..42f7470b9a7f 100644 --- a/sound/soc/meson/axg-tdm.h +++ b/sound/soc/meson/axg-tdm.h @@ -16,7 +16,7 @@ #define AXG_TDM_NUM_LANES 4 #define AXG_TDM_CHANNEL_MAX 128 #define AXG_TDM_RATES (SNDRV_PCM_RATE_5512 | \ - SNDRV_PCM_RATE_8000_192000) + SNDRV_PCM_RATE_8000_384000) #define AXG_TDM_FORMATS (SNDRV_PCM_FMTBIT_S8 | \ SNDRV_PCM_FMTBIT_S16_LE | \ SNDRV_PCM_FMTBIT_S20_LE | \ -- 2.40.1

2 1

[PATCH v1 1/1] ASoC: soc.h: replace custom COUNT_ARGS() & CONCATENATE() implementations
by Andy Shevchenko 12 Sep '23

12 Sep '23

Replace custom implementation of the macros from args.h. Signed-off-by: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> --- include/sound/soc.h | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/include/sound/soc.h b/include/sound/soc.h index fa2337a3cf4c..509386ff5212 100644 --- a/include/sound/soc.h +++ b/include/sound/soc.h @@ -10,6 +10,7 @@ #ifndef __LINUX_SND_SOC_H #define __LINUX_SND_SOC_H +#include <linux/args.h> #include <linux/of.h> #include <linux/platform_device.h> #include <linux/types.h> @@ -870,12 +871,8 @@ asoc_link_to_platform(struct snd_soc_dai_link *link, int n) { .platforms = platform, \ .num_platforms = ARRAY_SIZE(platform) -#define SND_SOC_DAILINK_REGx(_1, _2, _3, func, ...) func #define SND_SOC_DAILINK_REG(...) \ - SND_SOC_DAILINK_REGx(__VA_ARGS__, \ - SND_SOC_DAILINK_REG3, \ - SND_SOC_DAILINK_REG2, \ - SND_SOC_DAILINK_REG1)(__VA_ARGS__) + CONCATENATE(SND_SOC_DAILINK_REG, COUNT_ARGS(__VA_ARGS__))(__VA_ARGS__) #define SND_SOC_DAILINK_DEF(name, def...) \ static struct snd_soc_dai_link_component name[] = { def } -- 2.40.0.1.gaa8946217a0b

3 2

[PATCH v4 0/3] Match data improvements for wm8580 driver
by Biju Das 12 Sep '23

12 Sep '23

This patch series aims to add match data improvements for wm8580 driver. This patch series is only compile tested. v3->v4: * Created patch#2 for removing trailing comma in the terminator entry for OF table. v2->v3: * Added Rb tag from Andy. * Restored OF table postion and moved in patch#2 * Moved OF table near to the user. v1->v2: * Added Ack from Charles Keepax. * Removed comma in the terminator entry. * Restored original error code -EINVAL Biju Das (3): ASoC: wm8580: Simplify probe() ASoC: wm8580: Remove trailing comma in the terminator entry ASoC: wm8580: Move OF table sound/soc/codecs/wm8580.c | 26 ++++++++++---------------- 1 file changed, 10 insertions(+), 16 deletions(-) -- 2.25.1

4 10

[RESEND,v3 0/3] ASoC: mt8188-mt6359: add SOF support
by Trevor Wu 12 Sep '23

12 Sep '23

This series introduces dynamic pinctrl and adds support for the SOF on the mt8188-mt6359 machine driver. Changes since v2: - revise mtk_sof_check_tplg_be_dai_link_fixup(). Changes since v1: - minor changes to incorporate the suggestions from the reviewer. Trevor Wu (3): ASoC: mediatek: mt8188-mt6359: support dynamic pinctrl ASoC: mediatek: common: revise SOF common code ASoC: mediatek: mt8188-mt6359: add SOF support .../soc/mediatek/common/mtk-dsp-sof-common.c | 113 +++++++-- .../soc/mediatek/common/mtk-dsp-sof-common.h | 8 + sound/soc/mediatek/mt8188/mt8188-mt6359.c | 239 +++++++++++++++++- 3 files changed, 332 insertions(+), 28 deletions(-) -- 2.18.0

3 6