August 2023 - Alsa-devel - mailman.alsa-project.org

[PATCH -next v2] ALSA: Make SND_PCMTEST depend on DEBUG_FS
by Ruan Jinjie 17 Aug '23

17 Aug '23

Since pcmtest is a test module that manipulates or gets notification via debugfs, without DEBUG_FS it can not work fine. So make SND_PCMTEST depend on DEBUG_FS. Signed-off-by: Ruan Jinjie <ruanjinjie(a)huawei.com> --- v2: - make it depend on DEBUG_FS instead of dropping error check. --- sound/drivers/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/drivers/Kconfig b/sound/drivers/Kconfig index 41c171468c1e..6debd8e95cb7 100644 --- a/sound/drivers/Kconfig +++ b/sound/drivers/Kconfig @@ -111,6 +111,7 @@ config SND_ALOOP config SND_PCMTEST tristate "Virtual PCM test driver" + depends on DEBUG_FS select SND_PCM help Say 'Y' or 'M' to include support for the Virtual PCM test driver. -- 2.34.1

3 2

Re: [PATCH -next] ALSA: pcmtest: Drop unnecessary error check for debugfs_create_dir
by Takashi Iwai 17 Aug '23

17 Aug '23

On Thu, 17 Aug 2023 08:39:22 +0200, Ruan Jinjie wrote: > > This patch removes the error checking for debugfs_create_dir in > pcmtest.c. This is because the DebugFS kernel API is developed > in a way that the caller can safely ignore the errors that > occur during the creation of DebugFS nodes. The debugfs APIs have > a IS_ERR() judge in start_creating() which can handle it > gracefully. So these checks are unnecessary. > > Signed-off-by: Ruan Jinjie <ruanjinjie(a)huawei.com> I believe debugfs is mandatory in this case (it's a test module that manipulates / gets notification via debugfs), hence it makes sense to check the error. Maybe we should add a dependency on CONFIG_DEBUG_FS in Kconfig? thanks, Takashi > --- > sound/drivers/pcmtest.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/sound/drivers/pcmtest.c b/sound/drivers/pcmtest.c > index 7f170429eb8f..9360b3bb771e 100644 > --- a/sound/drivers/pcmtest.c > +++ b/sound/drivers/pcmtest.c > @@ -669,8 +669,6 @@ static int init_debug_files(int buf_count) > char len_file_name[32]; > > driver_debug_dir = debugfs_create_dir("pcmtest", NULL); > - if (IS_ERR(driver_debug_dir)) > - return PTR_ERR(driver_debug_dir); > debugfs_create_u8("pc_test", 0444, driver_debug_dir, &playback_capture_test); > debugfs_create_u8("ioctl_test", 0444, driver_debug_dir, &ioctl_reset_test); > > -- > 2.34.1 >

2 3

[PATCH RFC 0/9] ALSA: Don't embed struct devices
by Takashi Iwai 17 Aug '23

17 Aug '23

Hi, this is another set of patches to attempt papering over the UAF problems that are seen when the delayed kobject release is enabled, as initially reported by Curtis: https://lore.kernel.org/r/20230801171928.1460120-1-cujomalainey@chromium.org There was a previous patch set with a different approach (using the device refcount dependencies), but this is a sort of step-back to the old way. https://lore.kernel.org/r/20230807135207.17708-1-tiwai@suse.de After discussions and evaluations, we agreed that decoupling the struct device from each sound component object is the safest (and easiest) way as of now. For applying the changes more consistently, I introduced a new helper for the struct device allocation and initialization, and applied all components. A couple of more changes for card_dev refcount managed aren't included in this patch set, though. They might be good to have, but this patch set should suffice for the currently seen UAF problems. For a long-term solution, we may restructure the device management, then the struct devices may be embedded again in each object. But, it'll need lots of other changes and cleanups, a big TODO. The latest patches are found in topic/dev-split branch of sound.git tree. Takashi === Takashi Iwai (9): ALSA: core: Introduce snd_device_alloc() ALSA: control: Don't embed ctl_dev ALSA: pcm: Don't embed device ALSA: hwdep: Don't embed device ALSA: rawmidi: Don't embed device ALSA: compress: Don't embed device ALSA: timer: Create device with snd_device_alloc() ALSA: seq: Create device with snd_device_alloc() ALSA: core: Drop snd_device_initialize() include/sound/compress_driver.h | 2 +- include/sound/core.h | 4 ++-- include/sound/hwdep.h | 2 +- include/sound/pcm.h | 2 +- include/sound/rawmidi.h | 2 +- sound/aoa/soundbus/i2sbus/pcm.c | 4 ++-- sound/core/compress_offload.c | 16 ++++++++------ sound/core/control.c | 14 ++++++------ sound/core/control_led.c | 4 ++-- sound/core/hwdep.c | 38 ++++++++++++++++++--------------- sound/core/init.c | 28 +++++++++++++++--------- sound/core/pcm.c | 22 +++++++++++-------- sound/core/rawmidi.c | 29 +++++++++++-------------- sound/core/seq/seq_clientmgr.c | 16 ++++++++------ sound/core/timer.c | 16 ++++++++------ sound/core/ump.c | 8 +++---- sound/pci/hda/hda_hwdep.c | 4 ++-- sound/usb/media.c | 4 ++-- 18 files changed, 119 insertions(+), 96 deletions(-) -- 2.35.3

3 12

[PATCH -next] ALSA: hda: cs35l41: change cs35l41_prop_model to static
by Yang Yingliang 17 Aug '23

17 Aug '23

cs35l41_prop_model is only used in cs35l41_hda_property.c now, change it to static. Fixes: ef4ba63f12b0 ("ALSA: hda: cs35l41: Support systems with missing _DSD properties") Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> --- sound/pci/hda/cs35l41_hda_property.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c index 673f23257a09..2d8a3edb868b 100644 --- a/sound/pci/hda/cs35l41_hda_property.c +++ b/sound/pci/hda/cs35l41_hda_property.c @@ -50,7 +50,7 @@ struct cs35l41_prop_model { const char *hid); }; -const struct cs35l41_prop_model cs35l41_prop_model_table[] = { +static const struct cs35l41_prop_model cs35l41_prop_model_table[] = { { "CLSA0100", NULL, lenovo_legion_no_acpi }, { "CLSA0101", NULL, lenovo_legion_no_acpi }, {} -- 2.25.1

2 1

[PATCH -next] ALSA: pcmtest: Drop unnecessary error check for debugfs_create_dir
by Ruan Jinjie 17 Aug '23

17 Aug '23

This patch removes the error checking for debugfs_create_dir in pcmtest.c. This is because the DebugFS kernel API is developed in a way that the caller can safely ignore the errors that occur during the creation of DebugFS nodes. The debugfs APIs have a IS_ERR() judge in start_creating() which can handle it gracefully. So these checks are unnecessary. Signed-off-by: Ruan Jinjie <ruanjinjie(a)huawei.com> --- sound/drivers/pcmtest.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/drivers/pcmtest.c b/sound/drivers/pcmtest.c index 7f170429eb8f..9360b3bb771e 100644 --- a/sound/drivers/pcmtest.c +++ b/sound/drivers/pcmtest.c @@ -669,8 +669,6 @@ static int init_debug_files(int buf_count) char len_file_name[32]; driver_debug_dir = debugfs_create_dir("pcmtest", NULL); - if (IS_ERR(driver_debug_dir)) - return PTR_ERR(driver_debug_dir); debugfs_create_u8("pc_test", 0444, driver_debug_dir, &playback_capture_test); debugfs_create_u8("ioctl_test", 0444, driver_debug_dir, &ioctl_reset_test); -- 2.34.1

1 0

SplitPCM: Fix Device variable in SplitPCMDevice macro
by GitHub pull_request - opened 17 Aug '23

17 Aug '23

alsa-project/alsa-ucm-conf pull request #339 was opened from WeirdTreeThing: Currently, the variable name is dev instead of Device as the comment would suggest, update the name to fit the comment. Also, the variable gets ignored due to it getting set to nothing right away, remove that line to allow the variable to work as intended. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/339 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/339.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH] ASoC: SOF: ipc4-pcm: fix possible null pointer deference
by Peter Ujfalusi 16 Aug '23

16 Aug '23

From: Chao Song <chao.song(a)linux.intel.com> The call to snd_sof_find_spcm_dai() could return NULL, add nullable check for the return value to avoid null pointer defenrece. Fixes: 7cb19007baba ("ASoC: SOF: ipc4-pcm: add hw_params") Signed-off-by: Chao Song <chao.song(a)linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Signed-off-by: Peter Ujfalusi <peter.ujfalusi(a)linux.intel.com> --- sound/soc/sof/ipc4-pcm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/sof/ipc4-pcm.c b/sound/soc/sof/ipc4-pcm.c index 802cbf73594e..db19cd03ecad 100644 --- a/sound/soc/sof/ipc4-pcm.c +++ b/sound/soc/sof/ipc4-pcm.c @@ -709,6 +709,9 @@ static int sof_ipc4_pcm_hw_params(struct snd_soc_component *component, struct snd_sof_pcm *spcm; spcm = snd_sof_find_spcm_dai(component, rtd); + if (!spcm) + return -EINVAL; + time_info = spcm->stream[substream->stream].private; /* delay calculation is not supported by current fw_reg ABI */ if (!time_info) -- 2.41.0

2 1

[PATCH v3 00/28] Add support for QMC HDLC, framer infrastruture and PEF2256 framer
by Herve Codina 16 Aug '23

16 Aug '23

Hi, I have a system where I need to handle an HDLC interface and some audio data. The HDLC data are transferred using a TDM bus on which a PEF2256 (E1/T1 framer) is present. The PEF2256 transfers data from/to the TDM bus to/from the E1 line. This PEF2256 is connected to a PowerQUICC SoC for the control path and the TDM is connected to the SoC (QMC component) for the data path. From the QMC HDLC driver, I need to handle HDLC data using the QMC, carrier detection using the PEF2256 (E1 line carrier) and set/get some PEF2256 configuration. The QMC HDLC driver considers the PEF2256 as a generic framer. It performs operations that involve the PEF2256 through the generic framer API. The audio data are exchanged with the PEF2256 using a CPU DAI connected to the TDM bus through the QMC and the PEF2256 needs to be seen as a codec in order to be linked to the CPU DAI. The codec handles the carrier detection using the PEF2256 and reports the carrier state to the ALSA subsystem using the ASoC jack detection. The codec, even if instantiated by the PEF2256 driver, considers the PEF2256 as a generic framer. The generic framer has: - 2 consumers (QMC HDLC drv and codec) - 1 provider (PEF2256) So, the design is the following: +------------------+ +---------+ | QMC | <- TDM -> | PEF2256 | <-> E1 +---------+ | +-------------+ | | | | CPU DAI | <-data--> | QMC channel | | | | +---------+ | +-------------+ | | | +--------------+ | +-------------+ | | | | QMC HDLC drv | <-data--> | QMC channel | | | | +--------------+ | +-------------+ | | | ^ +------------------+ | | | +--------+ +-------------+ | | +-> | framer | <-> | PEF2256 drv | <- local bus ->| | | | | | +---------+ +-> | | | | | +--------+ | +-------+ | +-------------------> | codec | | | +-------+ | +-------------+ Further more, the TDM timeslots used by the QMC HDLC driver need to be configured at runtime (QMC dynamic timeslots). Several weeks ago, I sent two series related to this topic: - Add the Lantiq PEF2256 audio support [1] - RFC Add support for QMC HDLC and PHY [2] This current series is a rework of these two series taking into account feedbacks previously received. In order to implement all of this, I do the following: 1) Perform some fixes (patches 1, 2, 3, 4) 2) Introduce the QMC HDLC driver (patches 5, 6, 7) 3) Add QMC dynamic timeslot support (patches 8 - 18) 4) Add timeslots change support in QMC HDLC (patch 19) 5) Introduce framer infrastructure (patch 20) 6) Add PEF2256 framer provider (patches 11, 22, 23, 24, 25) 7) Add framer codec as a framer consumer (patch 26) 8) Add framer support as a framer consumer in QMC HDLC (patch 27, 28) The series contains the full story and detailed modifications. If needed, the series can be split and/or commmits can be squashed. Let me know. Compare to the previous iteration https://lore.kernel.org/linux-kernel/20230726150225.483464-1-herve.codina@b… This v3 series mainly: - Fixes some implementation details. - Adds a new patch (patch 5) to remove existing inline keyword in the QMC driver. - Squashes patches related to the QMC HDLC binding together. Best regards, Hervé [1]: https://lore.kernel.org/all/20230417171601.74656-1-herve.codina@bootlin.com/ [2]: https://lore.kernel.org/all/20230323103154.264546-1-herve.codina@bootlin.co… Changes v2 -> v3 - Patches 1, 2, 3, 4 Add 'Reviewed-by: Christophe Leroy <christophe.leroy(a)csgroup.eu>' - New patch Remove inline keyword from the existing registers accessors helpers - Patch 6 (patches 5, 27 in v2) Update the binding title Squash patch 27 - Patch 7 (patch 6 in v2) Remove the cast in netdev_to_qmc_hdlc() Add 'Reviewed-by: Christophe Leroy <christophe.leroy(a)csgroup.eu>' - Patch 8 (patch 7 in v2): No change - Patches 9, 10 (patches 8, 9 in v2) Add 'Reviewed-by: Christophe Leroy <christophe.leroy(a)csgroup.eu>' - Patch 11 (patch 10 in v2) Remove inline keyword from the introduced qmc_clrsetbits16() helper Add 'Reviewed-by: Christophe Leroy <christophe.leroy(a)csgroup.eu>' - Patches 12, 13, 14, 15, 16, 17, 18, 19, 20 Add 'Reviewed-by: Christophe Leroy <christophe.leroy(a)csgroup.eu>' - Patch 21 (patch 20 in v2) Remove unneeded framer NULL pointer check Add 'Reviewed-by: Christophe Leroy <christophe.leroy(a)csgroup.eu>' - Patch 22 (patch 21 in v2) Change sclkr and sclkx clocks description Remove the framer phandle property from the framer subnodes (ie. from framer-codec nodes) - Patch 23 (patch 22 in v2) Initialize 'disabled' variable at declaration Fix commit log Add 'Reviewed-by: Christophe Leroy <christophe.leroy(a)csgroup.eu>' - Patch 24 (patch 23 in v2) Remove inline keyword from the existing registers accessors helpers Use dev_warn_ratelimited() in default interrupt handler Add 'Reviewed-by: Christophe Leroy <christophe.leroy(a)csgroup.eu>' - Patch 25 (patch 24 in v2) Replace #include "linux/bitfield.h" by #include <linux/bitfield.h> Fold the pinctrl anonymous struct into the struct pef2256_pinctrl Update commit log Add 'Reviewed-by: Christophe Leroy <christophe.leroy(a)csgroup.eu>' - Patch 26 (patch 25 in v2) Add 'Reviewed-by: Christophe Leroy <christophe.leroy(a)csgroup.eu>' - Patch 27 (patch 26 in v2) Fix error message Changed the ch.max computation in framer_dai_hw_rule_channels_by_format() Add 'Reviewed-by: Christophe Leroy <christophe.leroy(a)csgroup.eu>' - Patch 28 Add 'Reviewed-by: Christophe Leroy <christophe.leroy(a)csgroup.eu>' Changes v1 -> v2 - Patches 1, 2 (New in v2) Fix __iomem addresses declaration - Patch 19 (17 in v1) Fix a compilation warning - Patch 26 (24 in v1) Fix a typo in Kconfig file Fix issues raised by sparse (make C=1) Herve Codina (28): soc: fsl: cpm1: tsa: Fix __iomem addresses declaration soc: fsl: cpm1: qmc: Fix __iomem addresses declaration soc: fsl: cpm1: qmc: Fix rx channel reset soc: fsl: cpm1: qmc: Extend the API to provide Rx status soc: fsl: cpm1: qmc: Remove inline function specifiers dt-bindings: net: Add support for QMC HDLC net: wan: Add support for QMC HDLC MAINTAINERS: Add the Freescale QMC HDLC driver entry soc: fsl: cpm1: qmc: Introduce available timeslots masks soc: fsl: cpm1: qmc: Rename qmc_setup_tsa* to qmc_init_tsa* soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa* soc: fsl: cpm1: qmc: Remove no more needed checks from qmc_check_chans() soc: fsl: cpm1: qmc: Check available timeslots in qmc_check_chans() soc: fsl: cpm1: qmc: Add support for disabling channel TSA entries soc: fsl: cpm1: qmc: Split Tx and Rx TSA entries setup soc: fsl: cpm1: qmc: Introduce is_tsa_64rxtx flag soc: fsl: cpm1: qmc: Handle timeslot entries at channel start() and stop() soc: fsl: cpm1: qmc: Remove timeslots handling from setup_chan() soc: fsl: cpm1: qmc: Introduce functions to change timeslots at runtime wan: qmc_hdlc: Add runtime timeslots changes support net: wan: Add framer framework support dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer mfd: core: Ensure disabled devices are skiped without aborting net: wan: framer: Add support for the Lantiq PEF2256 framer pinctrl: Add support for the Lantic PEF2256 pinmux MAINTAINERS: Add the Lantiq PEF2256 driver entry ASoC: codecs: Add support for the framer codec net: wan: fsl_qmc_hdlc: Add framer support .../devicetree/bindings/net/fsl,qmc-hdlc.yaml | 46 + .../bindings/net/lantiq,pef2256.yaml | 219 +++++ MAINTAINERS | 17 + drivers/mfd/mfd-core.c | 17 +- drivers/net/wan/Kconfig | 14 + drivers/net/wan/Makefile | 3 + drivers/net/wan/framer/Kconfig | 35 + drivers/net/wan/framer/Makefile | 7 + drivers/net/wan/framer/framer-core.c | 886 ++++++++++++++++++ drivers/net/wan/framer/pef2256/Makefile | 8 + drivers/net/wan/framer/pef2256/pef2256-regs.h | 250 +++++ drivers/net/wan/framer/pef2256/pef2256.c | 880 +++++++++++++++++ drivers/net/wan/fsl_qmc_hdlc.c | 820 ++++++++++++++++ drivers/pinctrl/Kconfig | 14 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/pinctrl-pef2256-regs.h | 65 ++ drivers/pinctrl/pinctrl-pef2256.c | 308 ++++++ drivers/soc/fsl/qe/qmc.c | 501 ++++++++-- drivers/soc/fsl/qe/tsa.c | 22 +- include/linux/framer/framer-provider.h | 194 ++++ include/linux/framer/framer.h | 199 ++++ include/linux/framer/pef2256.h | 31 + include/soc/fsl/qe/qmc.h | 25 +- sound/soc/codecs/Kconfig | 15 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/framer-codec.c | 413 ++++++++ sound/soc/fsl/fsl_qmc_audio.c | 2 +- 27 files changed, 4872 insertions(+), 122 deletions(-) create mode 100644 Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml create mode 100644 Documentation/devicetree/bindings/net/lantiq,pef2256.yaml create mode 100644 drivers/net/wan/framer/Kconfig create mode 100644 drivers/net/wan/framer/Makefile create mode 100644 drivers/net/wan/framer/framer-core.c create mode 100644 drivers/net/wan/framer/pef2256/Makefile create mode 100644 drivers/net/wan/framer/pef2256/pef2256-regs.h create mode 100644 drivers/net/wan/framer/pef2256/pef2256.c create mode 100644 drivers/net/wan/fsl_qmc_hdlc.c create mode 100644 drivers/pinctrl/pinctrl-pef2256-regs.h create mode 100644 drivers/pinctrl/pinctrl-pef2256.c create mode 100644 include/linux/framer/framer-provider.h create mode 100644 include/linux/framer/framer.h create mode 100644 include/linux/framer/pef2256.h create mode 100644 sound/soc/codecs/framer-codec.c -- 2.41.0

5 36

Fwd: [Bug 217440] New: ALC236 audio disappears from HP 15z-fc000 on warm boot
by Joseph C. Sible 16 Aug '23

16 Aug '23

Hello, Forwarding my regression bug report submission per the instructions in "Reporting regressions". #regzbot introduced: 5aec989130 https://bugzilla.kernel.org/show_bug.cgi?id=217440 Regards, Joseph C. Sible ---------- Forwarded message --------- From: <bugzilla-daemon(a)kernel.org> Date: Sat, May 13, 2023 at 3:46 PM Subject: [Bug 217440] New: ALC236 audio disappears from HP 15z-fc000 on warm boot To: <josephcsible(a)gmail.com> https://bugzilla.kernel.org/show_bug.cgi?id=217440 Bug ID: 217440 Summary: ALC236 audio disappears from HP 15z-fc000 on warm boot Product: Drivers Version: 2.5 Kernel Version: 6.3.2 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P3 Component: Sound(ALSA) Assignee: perex(a)perex.cz Reporter: josephcsible(a)gmail.com Regression: Yes Bisected 5aec98913095ed3b4424ed6c5fdeb6964e9734da commit-id: On an HP 15z-fc000 laptop that uses Realtek ALC236 for sound, once the system is warm booted ("reboot" from within Linux), sound stops working completely and the device doesn't even show up anymore. Once this happens, the only way to get it to come back is to cold boot ("poweroff" from within Linux, wait for it to turn completely off, and turn it back on with the physical power button). In particular, once you boot from a "bad" kernel, no number of warm boots with "good" kernels will ever bring sound back. I bisected this to commit 5aec989, which first appeared in 5.15-rc6. In addition, I confirmed by doing a custom build of 6.3.2 with reverts of both f30741c (just to avoid a conflict) and 5aec989, which works correctly for me. -- You may reply to this email to add a comment. You are receiving this mail because: You reported the bug.

5 48

[PATCH] -- fix Boss MS-3 midi-usb communication
by john_candlish＠mail.candlish.net 16 Aug '23

16 Aug '23

This one line change gets MIDI communication flowing between ALSA and the Boss MS-3 multi-effect switcher. ///// *** sound/usb/midi.c 2023-08-10 22:46:31.016346930 +0200 --- sound/usb/midi.c-orig 2023-07-19 16:37:03.000000000 +0200 *************** *** 2106,2113 **** struct usb_endpoint_descriptor *epd; int i, out_eps = 0, in_eps = 0; ! if (USB_ID_VENDOR(umidi->usb_id) == 0x0582 && ! USB_ID_PRODUCT(umidi->usb_id) != 0x01f5) snd_usbmidi_switch_roland_altsetting(umidi); if (endpoint[0].out_ep || endpoint[0].in_ep) --- 2106,2112 ---- struct usb_endpoint_descriptor *epd; int i, out_eps = 0, in_eps = 0; ! if (USB_ID_VENDOR(umidi->usb_id) == 0x0582) snd_usbmidi_switch_roland_altsetting(umidi); if (endpoint[0].out_ep || endpoint[0].in_ep) ///// There are doubtless other Roland/Boss USB_ID_PRODUCT id's that are effected and it would be nice to make the USB_ID_PRODUCT value a tunable, but that is beyond my competence.

2 3