August 2023 - Alsa-devel - mailman.alsa-project.org

[PATCH] ALSA: ymfpci: Fix the missing snd_card_free() call at probe error
by Takashi Iwai 23 Aug '23

23 Aug '23

Like a few other drivers, YMFPCI driver needs to clean up with snd_card_free() call at an error path of the probe; otherwise the other devres resources are released before the card and it results in the UAF. This patch uses the helper for handling the probe error gracefully. Fixes: f33fc1576757 ("ALSA: ymfpci: Create card with device-managed snd_devm_card_new()") Cc: <stable(a)vger.kernel.org> Reported-and-tested-by: Takashi Yano <takashi.yano(a)nifty.ne.jp> Closes: https://lore.kernel.org/r/20230823135846.1812-1-takashi.yano@nifty.ne.jp Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/ymfpci/ymfpci.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/sound/pci/ymfpci/ymfpci.c b/sound/pci/ymfpci/ymfpci.c index b033bd290940..48444dda44de 100644 --- a/sound/pci/ymfpci/ymfpci.c +++ b/sound/pci/ymfpci/ymfpci.c @@ -152,8 +152,8 @@ static inline int snd_ymfpci_create_gameport(struct snd_ymfpci *chip, int dev, i void snd_ymfpci_free_gameport(struct snd_ymfpci *chip) { } #endif /* SUPPORT_JOYSTICK */ -static int snd_card_ymfpci_probe(struct pci_dev *pci, - const struct pci_device_id *pci_id) +static int __snd_card_ymfpci_probe(struct pci_dev *pci, + const struct pci_device_id *pci_id) { static int dev; struct snd_card *card; @@ -348,6 +348,12 @@ static int snd_card_ymfpci_probe(struct pci_dev *pci, return 0; } +static int snd_card_ymfpci_probe(struct pci_dev *pci, + const struct pci_device_id *pci_id) +{ + return snd_card_free_on_error(&pci->dev, __snd_card_ymfpci_probe(pci, pci_id)); +} + static struct pci_driver ymfpci_driver = { .name = KBUILD_MODNAME, .id_table = snd_ymfpci_ids, -- 2.35.3

1 0

[PATCH v1] Revert "ASoC: Intel: Add rpl_nau8318_8825 driver"
by Ajye Huang 23 Aug '23

23 Aug '23

This reverts commit 6b8b6892e43419f5339c47d307b1baac0eea036d. Report from kernel test robot <lkp(a)intel.com>, that in broonie/ci.git file0yZ50U, it's redundant commit 6b8b6892e434 ("ASoC: Intel: Add rpl_nau8318_8825 driver") because commit 273bc8bf2227 ("ASoC: Intel: Add rpl_nau8318_8825 driver") was committed at 2023-08-14. All errors (new ones prefixed by >>): >> sound/soc/intel/common/soc-acpi-intel-rpl-match.c:369:41: error: redefinition of 'rpl_nau8318_amp' static const struct snd_soc_acpi_codecs rpl_nau8318_amp = { ^ sound/soc/intel/common/soc-acpi-intel-rpl-match.c:359:41: note: previous definition is here static const struct snd_soc_acpi_codecs rpl_nau8318_amp = { Reported-by: kernel test robot <lkp(a)intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202308221955.FkglAuTF-lkp@intel.com/ Signed-off-by: Ajye Huang <ajye_huang(a)compal.corp-partner.google.com> --- sound/soc/intel/common/soc-acpi-intel-rpl-match.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sound/soc/intel/common/soc-acpi-intel-rpl-match.c b/sound/soc/intel/common/soc-acpi-intel-rpl-match.c index 103490ac7c838..122673c1dae27 100644 --- a/sound/soc/intel/common/soc-acpi-intel-rpl-match.c +++ b/sound/soc/intel/common/soc-acpi-intel-rpl-match.c @@ -366,11 +366,6 @@ static const struct snd_soc_acpi_codecs rpl_rt1019p_amp = { .codecs = {"RTL1019"} }; -static const struct snd_soc_acpi_codecs rpl_nau8318_amp = { - .num_codecs = 1, - .codecs = {"NVTN2012"} -}; - struct snd_soc_acpi_mach snd_soc_acpi_intel_rpl_machines[] = { { .comp_ids = &rpl_rt5682_hp, -- 2.25.1

2 4

snd_seq_ev_set_ump_data() stack smashing
by GitHub issues - opened 23 Aug '23

23 Aug '23

alsa-project/alsa-lib issue #346 was opened from symdeb: snd_seq_ev_set_ump_data(&umpev, buffer, len); When called with len > 4 causes stack smashing. A ump messages is maximum four 32bit values. Proposal solution, return error when len > 4 ? Issue URL : https://github.com/alsa-project/alsa-lib/issues/346 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH] fix: Add quirk for Asus Zenbook Pro 14 UX6404 laptop
by Rohit Pidaparthi 23 Aug '23

23 Aug '23

From 4f14cdad4f526f45747c4f0b71e24a46ebe3885c Mon Sep 17 00:00:00 2001 From: Rohit Pidaparthi <rohitpid(a)gmail.com> Date: Sat, 19 Aug 2023 02:15:16 -0700 Subject: [PATCH] fix: Add quirk for Asus Zenbook Pro 14 UX6404 laptop The Asus Zenbook Pro 14 UX6404 (1043:1863) needs binding to the CS35L41 codec over spi1 rather than spi0. This is similar to existing quirks for many ASUS Laptops. Signed-off-by: Rohit Pidaparthi <rohitpid(a)gmail.com> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index dc7b7a407638..c44464b1619f 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9681,6 +9681,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1043, 0x1d42, "ASUS Zephyrus G14 2022", ALC289_FIXUP_ASUS_GA401), SND_PCI_QUIRK(0x1043, 0x1d4e, "ASUS TM420", ALC256_FIXUP_ASUS_HPE), SND_PCI_QUIRK(0x1043, 0x1e02, "ASUS UX3402", ALC245_FIXUP_CS35L41_SPI_2), + SND_PCI_QUIRK(0x1043, 0x1863, "ASUS UX6404", ALC245_FIXUP_CS35L41_SPI_2), SND_PCI_QUIRK(0x1043, 0x1e11, "ASUS Zephyrus G15", ALC289_FIXUP_ASUS_GA502), SND_PCI_QUIRK(0x1043, 0x1e12, "ASUS UM3402", ALC287_FIXUP_CS35L41_I2C_2), SND_PCI_QUIRK(0x1043, 0x1e51, "ASUS Zephyrus M15", ALC294_FIXUP_ASUS_GU502_PINS), -- 2.39.2

2 2

aplaymidi causes pa_stream_writeable_size() failed - connection terminated
by GitHub issues - edited 23 Aug '23

23 Aug '23

alsa-project/alsa-utils issue #232 was edited from symdeb: How to reproduce: 1. Plain Ubuntu 23.04 desktop but with kernel 6.5rc1... rc7 and ALSA UMP & sequencer enabled. 2. play a video with the "video" application. 3. Insert a MIDI 2.0 UMP capable device Note: A Focusrite 18i20 Gen 1 audio interface is used for audio playback and set in Pavucontrol as "pro Audio" 4. run aplaymidi -l or aplaymidi --version within about 30 seconds of plugging in the device. (if longer, the issue is not reproduceable) 6. Audio stops and soon after the error appears stopping the video. pavuctl screen goes blank and reinitializes itself. Unplug the device Wait for about 30 seconds (this is important, sooner the error will appear) Repeat steps 2 and 4 . The error won't occur. ![image](https://github.com/alsa-project/alsa-utils/assets/19564066/9bd6e993-be47-4715-8e6c-5f2a2242027c) This is not unique to aplaymidi, other ALSA clients (aseqdump) may also cause this error. in almost all other applications there is no error, such a web browsers as playing videos in Youtube, the audio playback just stops. some applications , like browsers, can recover by readadjusting the timeline and restarting playback. Some can only recover after closing the application i.e mpv media player. Issue URL : https://github.com/alsa-project/alsa-utils/issues/232 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

aplaymidi causes pa_stream_writeable_size() failed - connection terminated
by GitHub issues - edited 23 Aug '23

23 Aug '23

alsa-project/alsa-utils issue #232 was edited from symdeb: How to reproduce: 1. Plain Ubuntu 23.04 desktop but with kernel 6.5rc1... rc7 and ALSA UMP & sequencer enabled. 2. play a video with the "video" application. 3. Insert a MIDI 2.0 UMP capable device Note: A Focusrite 18i20 Gen 1 audio interface is used for audio playback and set in Pavucontrol as "pro Audio" 4. run aplaymidi -l or aplaymidi --version within about 30 seconds of plugging in the device. (if longer, the issue may not be reproduceable) 6. Audio stops and soon after the error appears stopping the video. pavuctl screen goes blank and reinitializes itself. Unplug the device Wait for about 30 seconds (this is important, sooner the error will appear) Repeat steps 2 and 4 . The error won't occur. ![image](https://github.com/alsa-project/alsa-utils/assets/19564066/9bd6e993-be47-4715-8e6c-5f2a2242027c) This is not unique to aplaymidi, other ALSA clients (aseqdump) may also cause this error. in almost all other applications there is no error, such a web browsers as playing videos in Youtube, the audio playback just stops. some applications , like browsers, can recover by readadjusting the timeline and restarting playback. Some can only recover after closing the application i.e mpv media player. Issue URL : https://github.com/alsa-project/alsa-utils/issues/232 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

aplaymidi causes pa_stream_writeable_size() failed - connection terminated
by GitHub issues - edited 23 Aug '23

23 Aug '23

alsa-project/alsa-utils issue #232 was edited from symdeb: How to reproduce: 1. Plain Ubuntu 23.04 desktop but with kernel 6.5rc1... rc7 and ALSA UMP & sequencer enabled. 2. play a video with the "video" application. 3. Insert a MIDI 2.0 UMP capable device Note: A Focusrite 18i20 Gen 1 audio interface is used for audio playback and set in Pavucontrol as "pro Audio" 4. run aplaymidi -l or aplaymidi --version within about 30 seconds of plugging in the device. (if longer, the issue may not be reproduceable) 6. Audio stops and soon after the error appears stopping the video. pavuctl screen goes blank and seems the reinitialize itself. Unplug the device Wait for about 30 seconds (this is important, sooner the error will appear) Repeat steps 2 and 4 . The error won't occur. ![image](https://github.com/alsa-project/alsa-utils/assets/19564066/9bd6e993-be47-4715-8e6c-5f2a2242027c) This is not unique to aplaymidi, other ALSA clients (aseqdump) may also cause this error. in almost all other applications there is no error, such a web browsers as playing videos in Youtube, the audio playback just stops. some applications , like browsers, can recover by readadjusting the timeline and restarting playback. Some can only recover after closing the application i.e mpv media player. Issue URL : https://github.com/alsa-project/alsa-utils/issues/232 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

aplaymidi causes pa_stream_writeable_size() failed - connection terminated
by GitHub issues - edited 23 Aug '23

23 Aug '23

alsa-project/alsa-utils issue #232 was edited from symdeb: How to reproduce: 1. Plain Ubuntu 23.04 desktop but with kernel 6.5rc1... rc7 and ALSA UMP & sequencer enabled. 2. play a video with the "video" application. 3. Insert a MIDI 2.0 UMP capable device Note: A Focusrite 18i20 Gen 1 audio interface is used for audio playback and set in Pavucontrol as "pro Audio" 4. run aplaymidi -l or aplaymidi --version within about 30 seconds of plugging in the device. (if longer, the issue may not be reproduceable) 6. Audio stops and soon after the error appears stopping the video. Unplug the device Wait for about 30 seconds (this is important, sooner the error will appear) Repeat steps 2 and 4 . The error won't occur. ![image](https://github.com/alsa-project/alsa-utils/assets/19564066/9bd6e993-be47-4715-8e6c-5f2a2242027c) This is not unique to aplaymidi, other ALSA clients (aseqdump) may also cause this error. in almost all other applications there is no error, such a web browsers as playing videos in Youtube, the audio playback just stops. some applications , like browsers, can recover by readadjusting the timeline and restarting playback. Some can only recover after closing the application i.e mpv media player. Issue URL : https://github.com/alsa-project/alsa-utils/issues/232 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

aplaymidi causes pa_stream_writeable_size() failed - connection terminated
by GitHub issues - edited 23 Aug '23

23 Aug '23

alsa-project/alsa-utils issue #232 was edited from symdeb: How to reproduce: 1. Plain Ubuntu 23.04 desktop but with kernel 6.5rc1... rc7 and ALSA UMP & sequencer enabled. 2. play a video with the "video" application. 3. Insert a MIDI 2.0 UMP capable device Note: A Focusrite 18i20 Gen 1 audio interface is used for audio playback and set in Pavucontrol as "pro Audio" 4. run aplaymidi -l or aplaymidi --version within about 30 seconds of plugging in the device. (if longer, the issue may not be reproduceable) 6. Audio stops and soon after the error appears stopping the video. Unplug the device Wait for about 30 seconds (this is important, sooner the error will appear) Repeat steps 3 and 4 . The error won't occur. ![image](https://github.com/alsa-project/alsa-utils/assets/19564066/9bd6e993-be47-4715-8e6c-5f2a2242027c) This is not unique to aplaymidi, other ALSA clients (aseqdump) may also cause this error. in almost all other applications there is no error, such a web browsers as playing videos in Youtube, the audio playback just stops. some applications , like browsers, can recover by readadjusting the timeline and restarting playback. Some can only recover after closing the application i.e mpv media player. Issue URL : https://github.com/alsa-project/alsa-utils/issues/232 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

aplaymidi causes pa_stream_writeable_size() failed - connection terminated
by GitHub issues - edited 23 Aug '23

23 Aug '23

alsa-project/alsa-utils issue #232 was edited from symdeb: How to reproduce: 1. Plain Ubuntu 23.04 desktop but with kernel 6.5rc1... rc7 and ALSA UMP & sequencer enabled. 2. play a video with the "video" application. 3. Insert a MIDI 2.0 UMP capable device Note: A Focusrite 18i20 Gen 1 audio interface is used for audio playback and set in Pavucontrol as "pro Audio" 4. run aplaymidi -l or aplaymidi --version within about 30 seconds of plugging in the device. (longer the issue may not be reproduceable) 6. Audio stops and soon after the error appears stopping the video. Unplug the device Wait for about 30 seconds (this is important, sooner the error will appear) Repeat steps 3 and 4 . The error won't occur. ![image](https://github.com/alsa-project/alsa-utils/assets/19564066/9bd6e993-be47-4715-8e6c-5f2a2242027c) This is not unique to aplaymidi, other ALSA clients (aseqdump) may also cause this error. in almost all other applications there is no error, such a web browsers as playing videos in Youtube, the audio playback just stops. some applications , like browsers, can recover by readadjusting the timeline and restarting playback. Some can only recover after closing the application i.e mpv media player. Issue URL : https://github.com/alsa-project/alsa-utils/issues/232 Repository URL: https://github.com/alsa-project/alsa-utils

1 0