July 2023 - Alsa-devel - mailman.alsa-project.org

Garbage returned while reading unused S/PDIF, A CM106 like sound card
by Aurélien 05 Jul '23

05 Jul '23

Hello, I encounter troubles while using S/PDIF input on an CM106 like sound card (vendor 0x0d8c, device 0x0102) when the remote device which is connected by S/ PDIF to the sound card is powered off. In that case garbage data are reading from the S/PDIF rather than.. nothing It is really boring since this S/PDIF input is connected to the output speakers and once the remote deviced is powered off it emits a really disturbing sound. Since there is no input on the S/PDIF I guess that it could be a driver bug? If it's an hardware bug (I don't encounter the problem under windows..) is it possible to make a hack in order to distinguish between real data and noise on the S/PDIF input? Unfortunately this test is performed on an embedded device which runs linux 5.16.17-sun50iw6. I don't know if this problem still occurs with newer alsa version. Thank you in advance for your help. Regards, Aurélien

2 1

[PATCH 2/3] ASoC: rt5645: check return value after reading device id
by shumingf＠realtek.com 05 Jul '23

05 Jul '23

From: Shuming Fan <shumingf(a)realtek.com> If the I2C controller encounters some problems like timed-out, the codec driver will report the error code for the first read. Signed-off-by: Shuming Fan <shumingf(a)realtek.com> --- sound/soc/codecs/rt5645.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index c0d56a8f7f47..b0953e9bcaf9 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -3967,7 +3967,11 @@ static int rt5645_i2c_probe(struct i2c_client *i2c) * read and power On. */ msleep(TIME_TO_POWER_MS); - regmap_read(regmap, RT5645_VENDOR_ID2, &val); + ret = regmap_read(regmap, RT5645_VENDOR_ID2, &val); + if (ret < 0) { + dev_err(&i2c->dev, "Failed to read: 0x%02X\n, ret = %d", RT5645_VENDOR_ID2, ret); + goto err_enable; + } switch (val) { case RT5645_DEVICE_ID: -- 2.41.0

2 1

[PATCH] ASoC: cs35l45: Select REGMAP_IRQ
by Nathan Chancellor 05 Jul '23

05 Jul '23

After commit 6085f9e6dc19 ("ASoC: cs35l45: IRQ support"), without any other configuration that selects CONFIG_REGMAP_IRQ, modpost errors out with: ERROR: modpost: "regmap_irq_get_virq" [sound/soc/codecs/snd-soc-cs35l45.ko] undefined! ERROR: modpost: "devm_regmap_add_irq_chip" [sound/soc/codecs/snd-soc-cs35l45.ko] undefined! Add the Kconfig selection to ensure these functions get built and included, which resolves the build failure. Cc: stable(a)vger.kernel.org Fixes: 6085f9e6dc19 ("ASoC: cs35l45: IRQ support") Reported-by: Marcus Seyfarth <m.seyfarth(a)gmail.com> Closes: https://github.com/ClangBuiltLinux/linux/issues/1882 Signed-off-by: Nathan Chancellor <nathan(a)kernel.org> --- sound/soc/codecs/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 0cd107fa112f..76ddd3ffc496 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -715,6 +715,7 @@ config SND_SOC_CS35L41_I2C config SND_SOC_CS35L45 tristate + select REGMAP_IRQ config SND_SOC_CS35L45_SPI tristate "Cirrus Logic CS35L45 CODEC (SPI)" --- base-commit: 6f49256897083848ce9a59651f6b53fc80462397 change-id: 20230703-cs35l45-select-regmap_irq-0fd9d631763c Best regards, -- Nathan Chancellor <nathan(a)kernel.org>

2 1

snd_soc_dai_ops.startup called for all codecs
by Peter Suti 05 Jul '23

05 Jul '23

Hi, I'm trying to create a sound card which has two codecs associated with one DAI. One codec is responsible for playback and the other one for capture. I can see in soc-pcm.c that __soc_pcm_hw_params() is checking if the stream is valid for the current codec with snd_soc_dai_stream_valid() and if it isn't it is not calling the hw_params() callback. But this check is not there in __soc_pcm_open() which calls snd_soc_dai_startup() for every codec. Can someone shed some light on this? Why is startup() called for codecs that don't support the current stream? Thank you! Best Regards, Peter Suti

2 2

[tiwai-sound:test/snd_ctl_remove-lock-fix 31/38] sound/soc/mediatek/mt8188/mt8188-mt6359.c:1000:25: error: implicit declaration of function 'snd_ctl_remove'; did you mean 'snd_ctl_rename'?
by kernel test robot 05 Jul '23

05 Jul '23

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git test/snd_ctl_remove-lock-fix head: 1daeb793bc0d3c3ad9a66718852a4be0584b700c commit: 664c9b8fd2f9e61cbe85d8015fc1962ed10d8a2a [31/38] ALSA: control: Drop snd_ctl_remove() config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20230705/202307051751.ewoQ5wky-lkp@…) compiler: arm-linux-gnueabi-gcc (GCC) 12.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230705/202307051751.ewoQ5wky-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202307051751.ewoQ5wky-lkp@intel.com/ All errors (new ones prefixed by >>): sound/soc/mediatek/mt8188/mt8188-mt6359.c: In function 'mt8188_fixup_controls': >> sound/soc/mediatek/mt8188/mt8188-mt6359.c:1000:25: error: implicit declaration of function 'snd_ctl_remove'; did you mean 'snd_ctl_rename'? [-Werror=implicit-function-declaration] 1000 | snd_ctl_remove(card->snd_card, kctl); | ^~~~~~~~~~~~~~ | snd_ctl_rename cc1: some warnings being treated as errors vim +1000 sound/soc/mediatek/mt8188/mt8188-mt6359.c 9f08dcbddeb307 Trevor Wu 2023-05-26 981 9f08dcbddeb307 Trevor Wu 2023-05-26 982 static void mt8188_fixup_controls(struct snd_soc_card *card) 9f08dcbddeb307 Trevor Wu 2023-05-26 983 { 9f08dcbddeb307 Trevor Wu 2023-05-26 984 struct mt8188_mt6359_priv *priv = snd_soc_card_get_drvdata(card); 9f08dcbddeb307 Trevor Wu 2023-05-26 985 struct mt8188_card_data *card_data = (struct mt8188_card_data *)priv->private_data; 9f08dcbddeb307 Trevor Wu 2023-05-26 986 struct snd_kcontrol *kctl; 9f08dcbddeb307 Trevor Wu 2023-05-26 987 9f08dcbddeb307 Trevor Wu 2023-05-26 988 if (card_data->quirk & NAU8825_HS_PRESENT) { 9f08dcbddeb307 Trevor Wu 2023-05-26 989 struct snd_soc_dapm_widget *w, *next_w; 9f08dcbddeb307 Trevor Wu 2023-05-26 990 9f08dcbddeb307 Trevor Wu 2023-05-26 991 for_each_card_widgets_safe(card, w, next_w) { 9f08dcbddeb307 Trevor Wu 2023-05-26 992 if (strcmp(w->name, "Headphone")) 9f08dcbddeb307 Trevor Wu 2023-05-26 993 continue; 9f08dcbddeb307 Trevor Wu 2023-05-26 994 9f08dcbddeb307 Trevor Wu 2023-05-26 995 snd_soc_dapm_free_widget(w); 9f08dcbddeb307 Trevor Wu 2023-05-26 996 } 9f08dcbddeb307 Trevor Wu 2023-05-26 997 9f08dcbddeb307 Trevor Wu 2023-05-26 998 kctl = ctl_find(card->snd_card, "Headphone Switch"); 9f08dcbddeb307 Trevor Wu 2023-05-26 999 if (kctl) 9f08dcbddeb307 Trevor Wu 2023-05-26 @1000 snd_ctl_remove(card->snd_card, kctl); 9f08dcbddeb307 Trevor Wu 2023-05-26 1001 else 9f08dcbddeb307 Trevor Wu 2023-05-26 1002 dev_warn(card->dev, "Cannot find ctl : Headphone Switch\n"); 9f08dcbddeb307 Trevor Wu 2023-05-26 1003 } 9f08dcbddeb307 Trevor Wu 2023-05-26 1004 } 9f08dcbddeb307 Trevor Wu 2023-05-26 1005 :::::: The code at line 1000 was first introduced by commit :::::: 9f08dcbddeb307793bbfff036db213d2cdf03a50 ASoC: mediatek: mt8188-mt6359: support new board with nau88255 :::::: TO: Trevor Wu <trevor.wu(a)mediatek.com> :::::: CC: Mark Brown <broonie(a)kernel.org> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH v1] sound: seq: check struct system assignment problem
by Minjie Du 05 Jul '23

05 Jul '23

make data->system.parm1 avoid double assignment. but note writes "RT message with two parameters to UMP" is one of assignment is for system.parm2? I'm not sure, Could you help check it out? Thank you! Signed-off-by: Minjie Du <duminjie(a)vivo.com> --- sound/core/seq/seq_ump_convert.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/core/seq/seq_ump_convert.c b/sound/core/seq/seq_ump_convert.c index eb1d86ff6..60e637149 100644 --- a/sound/core/seq/seq_ump_convert.c +++ b/sound/core/seq/seq_ump_convert.c @@ -713,7 +713,6 @@ static int system_2p_ev_to_ump_midi1(const struct snd_seq_event *event, unsigned char status) { data->system.status = status; - data->system.parm1 = (event->data.control.value >> 7) & 0x7f; data->system.parm1 = event->data.control.value & 0x7f; return 1; } -- 2.39.0

1 0

[tiwai-sound:test/snd_ctl_remove-lock-fix 34/38] drivers/staging/greybus/audio_codec.c:810:26: warning: variable 'card' set but not used
by kernel test robot 05 Jul '23

05 Jul '23

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git test/snd_ctl_remove-lock-fix head: 6dd4ae925ae5b90ccfbcb11dce06fd505cc18bc8 commit: 812cf704dac9f2f275d7bc53818fcccde62dcef8 [34/38] staging: greybus: Avoid abusing controls_rwsem config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230705/202307051355.BQPsIfxL-lkp@…) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230705/202307051355.BQPsIfxL-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202307051355.BQPsIfxL-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/staging/greybus/audio_codec.c: In function 'gbaudio_register_module': >> drivers/staging/greybus/audio_codec.c:810:26: warning: variable 'card' set but not used [-Wunused-but-set-variable] 810 | struct snd_card *card; | ^~~~ drivers/staging/greybus/audio_codec.c: In function 'gbaudio_unregister_module': >> drivers/staging/greybus/audio_codec.c:938:26: warning: unused variable 'card' [-Wunused-variable] 938 | struct snd_card *card = comp->card->snd_card; | ^~~~ vim +/card +810 drivers/staging/greybus/audio_codec.c 64a7e2cceb75cca drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 805 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 806 int gbaudio_register_module(struct gbaudio_module_info *module) d3d2af51f9c2f29 drivers/staging/greybus/audio-codec.c Vaibhav Agarwal 2015-11-23 807 { 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 808 int ret; ce7bd8325dc75c8 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2020-07-09 809 struct snd_soc_component *comp; 2b8c2b51000e3d0 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-04-21 @810 struct snd_card *card; ac40b4d1e409971 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2020-07-09 811 struct gbaudio_jack *jack = NULL; d3d2af51f9c2f29 drivers/staging/greybus/audio-codec.c Vaibhav Agarwal 2015-11-23 812 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 813 if (!gbcodec) { 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 814 dev_err(module->dev, "GB Codec not yet probed\n"); 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 815 return -EAGAIN; d3d2af51f9c2f29 drivers/staging/greybus/audio-codec.c Vaibhav Agarwal 2015-11-23 816 } d3d2af51f9c2f29 drivers/staging/greybus/audio-codec.c Vaibhav Agarwal 2015-11-23 817 ce7bd8325dc75c8 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2020-07-09 818 comp = gbcodec->component; ce7bd8325dc75c8 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2020-07-09 819 card = comp->card->snd_card; 2b8c2b51000e3d0 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-04-21 820 812cf704dac9f2f drivers/staging/greybus/audio_codec.c Takashi Iwai 2023-07-04 821 mutex_lock(&gbcodec->register_mutex); d3d2af51f9c2f29 drivers/staging/greybus/audio-codec.c Vaibhav Agarwal 2015-11-23 822 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 823 if (module->num_dais) { 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 824 dev_err(gbcodec->dev, 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 825 "%d:DAIs not supported via gbcodec driver\n", 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 826 module->num_dais); 812cf704dac9f2f drivers/staging/greybus/audio_codec.c Takashi Iwai 2023-07-04 827 mutex_unlock(&gbcodec->register_mutex); 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 828 return -EINVAL; d3d2af51f9c2f29 drivers/staging/greybus/audio-codec.c Vaibhav Agarwal 2015-11-23 829 } d3d2af51f9c2f29 drivers/staging/greybus/audio-codec.c Vaibhav Agarwal 2015-11-23 830 ce7bd8325dc75c8 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2020-07-09 831 ret = gbaudio_init_jack(module, comp->card); 64a7e2cceb75cca drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 832 if (ret) { 812cf704dac9f2f drivers/staging/greybus/audio_codec.c Takashi Iwai 2023-07-04 833 mutex_unlock(&gbcodec->register_mutex); 64a7e2cceb75cca drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 834 return ret; 64a7e2cceb75cca drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 835 } 64a7e2cceb75cca drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 836 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 837 if (module->dapm_widgets) ce7bd8325dc75c8 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2020-07-09 838 snd_soc_dapm_new_controls(&comp->dapm, module->dapm_widgets, 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 839 module->num_dapm_widgets); 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 840 if (module->controls) ce7bd8325dc75c8 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2020-07-09 841 snd_soc_add_component_controls(comp, module->controls, 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 842 module->num_controls); 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 843 if (module->dapm_routes) ce7bd8325dc75c8 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2020-07-09 844 snd_soc_dapm_add_routes(&comp->dapm, module->dapm_routes, 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 845 module->num_dapm_routes); 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 846 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 847 /* card already instantiated, create widgets here only */ ce7bd8325dc75c8 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2020-07-09 848 if (comp->card->instantiated) { 620d28440c10b8f drivers/staging/greybus/audio_codec.c Deepak R Varma 2020-10-22 849 gbaudio_dapm_link_component_dai_widgets(comp->card, &comp->dapm); 64a7e2cceb75cca drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 850 #ifdef CONFIG_SND_JACK 461ab8077d573d4 drivers/staging/greybus/audio_codec.c Gioh Kim 2017-02-09 851 /* 461ab8077d573d4 drivers/staging/greybus/audio_codec.c Gioh Kim 2017-02-09 852 * register jack devices for this module 461ab8077d573d4 drivers/staging/greybus/audio_codec.c Gioh Kim 2017-02-09 853 * from codec->jack_list 461ab8077d573d4 drivers/staging/greybus/audio_codec.c Gioh Kim 2017-02-09 854 */ ac40b4d1e409971 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2020-07-09 855 list_for_each_entry(jack, &module->jack_list, list) { ce7bd8325dc75c8 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2020-07-09 856 snd_device_register(comp->card->snd_card, ac40b4d1e409971 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2020-07-09 857 jack->jack.jack); 64a7e2cceb75cca drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 858 } 64a7e2cceb75cca drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 859 #endif bb9986ef6b311fb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-05-04 860 } 64a7e2cceb75cca drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 861 c188fdc8176a8cb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-05-04 862 mutex_lock(&gbcodec->lock); 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 863 list_add(&module->list, &gbcodec->module_list); c188fdc8176a8cb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-05-04 864 mutex_unlock(&gbcodec->lock); c188fdc8176a8cb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-05-04 865 ce7bd8325dc75c8 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2020-07-09 866 if (comp->card->instantiated) ce7bd8325dc75c8 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2020-07-09 867 ret = snd_soc_dapm_new_widgets(comp->card); ce7bd8325dc75c8 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2020-07-09 868 dev_dbg(comp->dev, "Registered %s module\n", module->name); d3d2af51f9c2f29 drivers/staging/greybus/audio-codec.c Vaibhav Agarwal 2015-11-23 869 812cf704dac9f2f drivers/staging/greybus/audio_codec.c Takashi Iwai 2023-07-04 870 mutex_unlock(&gbcodec->register_mutex); bb9986ef6b311fb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-05-04 871 return ret; d3d2af51f9c2f29 drivers/staging/greybus/audio-codec.c Vaibhav Agarwal 2015-11-23 872 } 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 873 EXPORT_SYMBOL(gbaudio_register_module); d3d2af51f9c2f29 drivers/staging/greybus/audio-codec.c Vaibhav Agarwal 2015-11-23 874 591c45227a77505 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04 875 static void gbaudio_codec_clean_data_tx(struct gbaudio_data_connection *data) 25de3491f110648 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-01-13 876 { 79cb2b26f54e883 drivers/staging/greybus/audio_codec.c Chaehyun Lim 2016-09-20 877 u16 i2s_port, cportid; 591c45227a77505 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04 878 int ret; d764212f73cf270 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 879 d764212f73cf270 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 880 if (list_is_singular(&gbcodec->module_list)) { 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 881 ret = gb_audio_apbridgea_stop_tx(data->connection, 0); 5bbe14b7acc2a00 drivers/staging/greybus/audio_codec.c Mark Greer 2016-02-29 882 if (ret) 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 883 return; 620d28440c10b8f drivers/staging/greybus/audio_codec.c Deepak R Varma 2020-10-22 884 ret = gb_audio_apbridgea_shutdown_tx(data->connection, 0); 25de3491f110648 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-01-13 885 if (ret) 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 886 return; d764212f73cf270 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 887 } 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 888 i2s_port = 0; /* fixed for now */ 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 889 cportid = data->connection->hd_cport_id; 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 890 ret = gb_audio_apbridgea_unregister_cport(data->connection, 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 891 i2s_port, cportid, 4a8e519902e73c8 drivers/staging/greybus/audio_codec.c Mark Greer 2016-02-26 892 AUDIO_APBRIDGEA_DIRECTION_TX); 591c45227a77505 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04 893 data->state[0] = GBAUDIO_CODEC_SHUTDOWN; b19df7b9950cd8c drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-02-16 894 } b19df7b9950cd8c drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-02-16 895 591c45227a77505 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04 896 static void gbaudio_codec_clean_data_rx(struct gbaudio_data_connection *data) 591c45227a77505 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04 897 { 79cb2b26f54e883 drivers/staging/greybus/audio_codec.c Chaehyun Lim 2016-09-20 898 u16 i2s_port, cportid; 591c45227a77505 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04 899 int ret; 591c45227a77505 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04 900 d764212f73cf270 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 901 if (list_is_singular(&gbcodec->module_list)) { 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 902 ret = gb_audio_apbridgea_stop_rx(data->connection, 0); 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 903 if (ret) 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 904 return; 620d28440c10b8f drivers/staging/greybus/audio_codec.c Deepak R Varma 2020-10-22 905 ret = gb_audio_apbridgea_shutdown_rx(data->connection, 0); 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 906 if (ret) 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 907 return; d764212f73cf270 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 908 } 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 909 i2s_port = 0; /* fixed for now */ 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 910 cportid = data->connection->hd_cport_id; 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 911 ret = gb_audio_apbridgea_unregister_cport(data->connection, 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 912 i2s_port, cportid, 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 913 AUDIO_APBRIDGEA_DIRECTION_RX); 591c45227a77505 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04 914 data->state[1] = GBAUDIO_CODEC_SHUTDOWN; 591c45227a77505 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04 915 } 591c45227a77505 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04 916 591c45227a77505 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04 917 static void gbaudio_codec_cleanup(struct gbaudio_module_info *module) 591c45227a77505 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04 918 { 591c45227a77505 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04 919 struct gbaudio_data_connection *data; 591c45227a77505 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04 920 int pb_state, cap_state; 591c45227a77505 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04 921 591c45227a77505 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04 922 dev_dbg(gbcodec->dev, "%s: removed, cleanup APBridge\n", module->name); 591c45227a77505 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04 923 list_for_each_entry(data, &module->data_list, list) { 591c45227a77505 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04 924 pb_state = data->state[0]; 591c45227a77505 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04 925 cap_state = data->state[1]; 591c45227a77505 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04 926 591c45227a77505 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04 927 if (pb_state > GBAUDIO_CODEC_SHUTDOWN) 591c45227a77505 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04 928 gbaudio_codec_clean_data_tx(data); 591c45227a77505 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04 929 591c45227a77505 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04 930 if (cap_state > GBAUDIO_CODEC_SHUTDOWN) 591c45227a77505 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-04 931 gbaudio_codec_clean_data_rx(data); 6339d2322c47f4b drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-01-13 932 } 6339d2322c47f4b drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-01-13 933 } 6339d2322c47f4b drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-01-13 934 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 935 void gbaudio_unregister_module(struct gbaudio_module_info *module) 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 936 { ce7bd8325dc75c8 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2020-07-09 937 struct snd_soc_component *comp = gbcodec->component; ce7bd8325dc75c8 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2020-07-09 @938 struct snd_card *card = comp->card->snd_card; ac40b4d1e409971 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2020-07-09 939 struct gbaudio_jack *jack, *n; 33cc283928249b2 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-08-05 940 int mask; b19df7b9950cd8c drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-02-16 941 ce7bd8325dc75c8 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2020-07-09 942 dev_dbg(comp->dev, "Unregister %s module\n", module->name); b19df7b9950cd8c drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-02-16 943 812cf704dac9f2f drivers/staging/greybus/audio_codec.c Takashi Iwai 2023-07-04 944 mutex_lock(&gbcodec->register_mutex); 6dd67645f22cfeb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-03-29 945 mutex_lock(&gbcodec->lock); bb9986ef6b311fb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-05-04 946 gbaudio_codec_cleanup(module); bb9986ef6b311fb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-05-04 947 list_del(&module->list); ce7bd8325dc75c8 drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2020-07-09 948 dev_dbg(comp->dev, "Process Unregister %s module\n", module->name); c188fdc8176a8cb drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-05-04 949 mutex_unlock(&gbcodec->lock); 6339d2322c47f4b drivers/staging/greybus/audio_codec.c Vaibhav Agarwal 2016-01-13 950 :::::: The code at line 810 was first introduced by commit :::::: 2b8c2b51000e3d056f9aa27a64b93feabddf77a4 greybus: audio: Changes in response to ASoC cleanup :::::: TO: Vaibhav Agarwal <vaibhav.agarwal(a)linaro.org> :::::: CC: Greg Kroah-Hartman <gregkh(a)google.com> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH v2 0/5] ALSA: hda/realtek: add extra ROOG laptop quirks
by Luke D. Jones 05 Jul '23

05 Jul '23

- Adds quirks for various ASUS ROG laptops. - Fixes up a previous quirk - Fixes up a whitespace error This introduces a quirk chain that is similar to the ROG Ally quirk chain, but due to the verb configs being currently tested these new quirks do not use it and instead add a new chain. It is likely the Ally quirk will be removed in favour of this new chain in future. Luke D. Jones (5): ALSA: hda/realtek: Add quirk for ASUS ROG GX650P ALSA: hda/realtek: Add quirk for ASUS ROG GA402X ALSA: hda/realtek: Amend G634 quirk to enable rear speakers ALSA: hda/realtek: Add quirk for ASUS ROG G614Jx Fixes: 31278997add6 (ALSA: hda/realtek - Add headset quirk for Dell DT) sound/pci/hda/patch_realtek.c | 35 +++++++++++++++++++++++++++++++++-- 1 file changed, 33 insertions(+), 2 deletions(-) -- 2.41.0

3 7

[tiwai-sound:test/snd_ctl_remove-lock-fix 33/38] sound/soc/codecs/sigmadsp.c:676:45: error: no member named 'kctl' in 'struct sigmadsp_control'
by kernel test robot 04 Jul '23

04 Jul '23

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git test/snd_ctl_remove-lock-fix head: 6dd4ae925ae5b90ccfbcb11dce06fd505cc18bc8 commit: f6df559bc59a922fc6bd100cd018207323c3f9d1 [33/38] ASoC: sigmadsp: Simplify with snd_ctl_activate_id() config: hexagon-randconfig-r045-20230703 (https://download.01.org/0day-ci/archive/20230705/202307050346.R8ow8O6J-lkp@…) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a) reproduce: (https://download.01.org/0day-ci/archive/20230705/202307050346.R8ow8O6J-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202307050346.R8ow8O6J-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from sound/soc/codecs/sigmadsp.c:11: In file included from include/linux/i2c.h:19: In file included from include/linux/regulator/consumer.h:35: In file included from include/linux/suspend.h:5: In file included from include/linux/swap.h:9: In file included from include/linux/memcontrol.h:13: In file included from include/linux/cgroup.h:26: In file included from include/linux/kernel_stat.h:9: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/hexagon/include/asm/io.h:334: include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 547 | val = __raw_readb(PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 560 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu' 37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) | ^ In file included from sound/soc/codecs/sigmadsp.c:11: In file included from include/linux/i2c.h:19: In file included from include/linux/regulator/consumer.h:35: In file included from include/linux/suspend.h:5: In file included from include/linux/swap.h:9: In file included from include/linux/memcontrol.h:13: In file included from include/linux/cgroup.h:26: In file included from include/linux/kernel_stat.h:9: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/hexagon/include/asm/io.h:334: include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 573 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu' 35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) | ^ In file included from sound/soc/codecs/sigmadsp.c:11: In file included from include/linux/i2c.h:19: In file included from include/linux/regulator/consumer.h:35: In file included from include/linux/suspend.h:5: In file included from include/linux/swap.h:9: In file included from include/linux/memcontrol.h:13: In file included from include/linux/cgroup.h:26: In file included from include/linux/kernel_stat.h:9: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/hexagon/include/asm/io.h:334: include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 584 | __raw_writeb(value, PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 594 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 604 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ >> sound/soc/codecs/sigmadsp.c:676:45: error: no member named 'kctl' in 'struct sigmadsp_control' 676 | changed = snd_ctl_activate_id(card, &ctrl->kctl->id, active); | ~~~~ ^ 6 warnings and 1 error generated. vim +676 sound/soc/codecs/sigmadsp.c 667 668 static void sigmadsp_activate_ctrl(struct sigmadsp *sigmadsp, 669 struct sigmadsp_control *ctrl, unsigned int samplerate_mask) 670 { 671 struct snd_card *card = sigmadsp->component->card->snd_card; 672 bool active; 673 int changed; 674 675 active = sigmadsp_samplerate_valid(ctrl->samplerates, samplerate_mask); > 676 changed = snd_ctl_activate_id(card, &ctrl->kctl->id, active); 677 if (active && changed > 0) { 678 mutex_lock(&sigmadsp->lock); 679 if (ctrl->cached) 680 sigmadsp_ctrl_write(sigmadsp, ctrl, ctrl->cache); 681 mutex_unlock(&sigmadsp->lock); 682 } 683 } 684 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[tiwai-sound:test/snd_ctl_remove-lock-fix 33/38] sound/soc/codecs/sigmadsp.c:676:50: error: 'struct sigmadsp_control' has no member named 'kctl'
by kernel test robot 04 Jul '23

04 Jul '23

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git test/snd_ctl_remove-lock-fix head: 6dd4ae925ae5b90ccfbcb11dce06fd505cc18bc8 commit: f6df559bc59a922fc6bd100cd018207323c3f9d1 [33/38] ASoC: sigmadsp: Simplify with snd_ctl_activate_id() config: nios2-randconfig-r026-20230703 (https://download.01.org/0day-ci/archive/20230705/202307050119.aWILsASi-lkp@…) compiler: nios2-linux-gcc (GCC) 12.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230705/202307050119.aWILsASi-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202307050119.aWILsASi-lkp@intel.com/ All errors (new ones prefixed by >>): sound/soc/codecs/sigmadsp.c: In function 'sigmadsp_activate_ctrl': >> sound/soc/codecs/sigmadsp.c:676:50: error: 'struct sigmadsp_control' has no member named 'kctl' 676 | changed = snd_ctl_activate_id(card, &ctrl->kctl->id, active); | ^~ vim +676 sound/soc/codecs/sigmadsp.c 667 668 static void sigmadsp_activate_ctrl(struct sigmadsp *sigmadsp, 669 struct sigmadsp_control *ctrl, unsigned int samplerate_mask) 670 { 671 struct snd_card *card = sigmadsp->component->card->snd_card; 672 bool active; 673 int changed; 674 675 active = sigmadsp_samplerate_valid(ctrl->samplerates, samplerate_mask); > 676 changed = snd_ctl_activate_id(card, &ctrl->kctl->id, active); 677 if (active && changed > 0) { 678 mutex_lock(&sigmadsp->lock); 679 if (ctrl->cached) 680 sigmadsp_ctrl_write(sigmadsp, ctrl, ctrl->cache); 681 mutex_unlock(&sigmadsp->lock); 682 } 683 } 684 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0