July 2023 - Alsa-devel - mailman.alsa-project.org

[PATCH] ALSA: xen-front: refactor deprecated strncpy
by Justin Stitt 28 Jul '23

28 Jul '23

`strncpy` is deprecated for use on NUL-terminated destination strings [1]. A suitable replacement is `strscpy` [2] due to the fact that it guarantees NUL-termination on its destination buffer argument which is _not_ always the case for `strncpy`! It should be noted that, in this case, the destination buffer has a length strictly greater than the source string. Moreover, the source string is NUL-terminated (and so is the destination) which means there was no real bug happening here. Nonetheless, this patch would get us one step closer to eliminating the `strncpy` API in the kernel, as its use is too ambiguous. We need to favor less ambiguous replacements such as: strscpy, strscpy_pad, strtomem and strtomem_pad (amongst others). Technically, my patch yields subtly different behavior. The original implementation with `strncpy` would fill the entire destination buffer with null bytes [3] while `strscpy` will leave the junk, uninitialized bytes trailing after the _mandatory_ NUL-termination. So, if somehow `pcm->name` or `card->driver/shortname/longname` require this NUL-padding behavior then `strscpy_pad` should be used. My interpretation, though, is that the aforementioned fields are just fine as NUL-terminated strings. Please correct my assumptions if needed and I'll send in a v2. [1]: www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-termi… [2]: manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [3]: https://linux.die.net/man/3/strncpy Link: https://github.com/KSPP/linux/issues/90 Signed-off-by: Justin Stitt <justinstitt(a)google.com> --- sound/xen/xen_snd_front_alsa.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c index db917453a473..7a3dfce97c15 100644 --- a/sound/xen/xen_snd_front_alsa.c +++ b/sound/xen/xen_snd_front_alsa.c @@ -783,7 +783,7 @@ static int new_pcm_instance(struct xen_snd_front_card_info *card_info, pcm->info_flags = 0; /* we want to handle all PCM operations in non-atomic context */ pcm->nonatomic = true; - strncpy(pcm->name, "Virtual card PCM", sizeof(pcm->name)); + strscpy(pcm->name, "Virtual card PCM", sizeof(pcm->name)); if (instance_cfg->num_streams_pb) snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, @@ -835,9 +835,9 @@ int xen_snd_front_alsa_init(struct xen_snd_front_info *front_info) goto fail; } - strncpy(card->driver, XENSND_DRIVER_NAME, sizeof(card->driver)); - strncpy(card->shortname, cfg->name_short, sizeof(card->shortname)); - strncpy(card->longname, cfg->name_long, sizeof(card->longname)); + strscpy(card->driver, XENSND_DRIVER_NAME, sizeof(card->driver)); + strscpy(card->shortname, cfg->name_short, sizeof(card->shortname)); + strscpy(card->longname, cfg->name_long, sizeof(card->longname)); ret = snd_card_register(card); if (ret < 0) --- base-commit: 57012c57536f8814dec92e74197ee96c3498d24e change-id: 20230727-sound-xen-398c9927b3d8 Best regards, -- Justin Stitt <justinstitt(a)google.com>

3 2

[PATCH v3 00/50] Add support for sam9x7 SoC family
by Varshini Rajendran 28 Jul '23

28 Jul '23

This patch series adds support for the new SoC family - sam9x7. - The device tree, configs and drivers are added - Clock driver for sam9x7 is added - Support for basic peripherals is added - Target board SAM9X75 Curiosity is added Changes in v3: -------------- - Fixed the DT documentation errors pointed out in v2. - Dropped Acked-by tag in tcb DT doc patch as it had to be adapted according to sam9x7 correctly. - Picked by the previously missed tags. - Dropped this patch "dt-bindings: usb: generic-ehci: Document clock-names property" as the warning was not found while validating DT-schema for at91-sam9x75_curiosity.dtb. - Dropped redundant words in the commit message. - Fixed the CHECK_DTBS warnings validated against at91-sam9x75_curiosity.dtb. - Renamed dt nodes according to naming convention. - Dropped unwanted status property in dts. - Removed nodes that are not in use from the board dts. - Removed spi DT doc patch from the series as it was already applied and a fix patch was applied subsequently. Added a patch to remove the compatible to adapt sam9x7. - Added sam9x7 compatibles in usb dt documentation. Changes in v2: -------------- - Added sam9x7 specific compatibles in DT with fallbacks - Documented all the newly added DT compatible strings - Added device tree for the target board sam9x75 curiosity and documented the same in the DT bindings documentation - Removed the dt nodes that are not supported at the moment - Removed the configs added by previous version that are not supported at the moment - Fixed all the corrections in the commit message - Changed all the instances of copyright year to 2023 - Added sam9x7 flag in PIT64B configuration - Moved macro definitions to header file - Added another divider in mck characteristics in the pmc driver - Fixed the memory leak in the pmc driver - Dropped patches that are no longer needed - Picked up Acked-by and Reviewed-by tags Hari Prasath (1): irqchip/atmel-aic5: Add support for sam9x7 aic Varshini Rajendran (49): dt-bindings: microchip: atmel,at91rm9200-tcb: add sam9x60, sam9x7 compatible dt-bindings: usb: ehci: Add atmel at91sam9g45-ehci compatible dt-bindings: net: cdns,macb: add sam9x7 ethernet interface dt-bindings: clk: at91: add sam9x7 dt-bindings: clk: at91: add sam9x7 clock controller dt-bindings: reset: atmel,at91sam9260-reset: add sam9x7 dt-bindings: power: reset: atmel,sama5d2-shdwc: add sam9x7 dt-bindings: atmel-sysreg: add sam9x7 dt-bindings: crypto: add sam9x7 in Atmel AES dt-bindings: crypto: add sam9x7 in Atmel SHA dt-bindings: crypto: add sam9x7 in Atmel TDES dt-bindings: dmaengine: at_xdmac: add compatible with microchip,sam9x7 dt-bindings: i2c: at91: Add sam9x7 compatible string dt-bindings: mfd: at91: Add SAM9X7 compatible string dt-bindings: atmel-gpbr: add microchip,sam9x7-gpbr dt-bindings: atmel-matrix: add microchip,sam9x7-matrix dt-bindings: atmel-smc: add microchip,sam9x7-smc dt-bindings: atmel-ssc: add microchip,sam9x7-ssc dt-bindings: sdhci-of-at91: add microchip,sam9x7-sdhci dt-bindings: atmel-nand: add microchip,sam9x7-pmecc dt-bindings: pinctrl: at91: add sam9x7 dt-bindings: rng: atmel,at91-trng: add sam9x7 TRNG dt-bindings: rtc: at91rm9200: add sam9x7 compatible dt-bindings: rtt: at91rm9260: add sam9x7 compatible dt-bindings: serial: atmel,at91-usart: add compatible for sam9x7 dt-bindings: atmel-classd: add sam9x7 compatible dt-bindings: usb: atmel: add sam9x7 dt-bindings: watchdog: sama5d4-wdt: add compatible for sam9x7-wdt dt-bindings: irqchip/atmel-aic5: Add support for sam9x7 aic spi: dt-bindings: atmel,at91rm9200-spi: remove 9x60 compatible from list ASoC: dt-bindings: microchip: add sam9x7 dt-bindings: usb: ehci: Add sam9x7 dt-bindings: usb: add sam9x7 ARM: at91: pm: add support for sam9x7 SoC family ARM: at91: pm: add sam9x7 SoC init config ARM: at91: add support in SoC driver for new sam9x7 clk: at91: clk-sam9x60-pll: re-factor to support individual core freq outputs clk: at91: sam9x7: add support for HW PLL freq dividers clk: at91: sama7g5: move mux table macros to header file clk: at91: sam9x7: Allow PLLs to be exported and referenced in DT clk: at91: sam9x7: add sam9x7 pmc driver power: reset: at91-poweroff: lookup for proper pmc dt node for sam9x7 power: reset: at91-reset: add reset support for sam9x7 SoC power: reset: at91-reset: add sdhwc support for sam9x7 SoC ARM: at91: Kconfig: add config flag for SAM9X7 SoC ARM: configs: at91: enable config flags for sam9x7 SoC family ARM: dts: at91: sam9x7: add device tree for SoC dt-bindings: arm: add sam9x75 curiosity board ARM: dts: at91: sam9x75_curiosity: add sam9x75 curiosity board .../devicetree/bindings/arm/atmel-at91.yaml | 6 + .../devicetree/bindings/arm/atmel-sysregs.txt | 7 +- .../bindings/clock/atmel,at91rm9200-pmc.yaml | 1 + .../bindings/clock/atmel,at91sam9x5-sckc.yaml | 3 + .../crypto/atmel,at91sam9g46-aes.yaml | 6 +- .../crypto/atmel,at91sam9g46-sha.yaml | 6 +- .../crypto/atmel,at91sam9g46-tdes.yaml | 6 +- .../devicetree/bindings/dma/atmel-xdma.txt | 3 +- .../bindings/i2c/atmel,at91sam-i2c.yaml | 4 + .../interrupt-controller/atmel,aic.txt | 2 +- .../devicetree/bindings/mfd/atmel-flexcom.txt | 1 + .../devicetree/bindings/mfd/atmel-gpbr.txt | 1 + .../devicetree/bindings/mfd/atmel-matrix.txt | 1 + .../devicetree/bindings/mfd/atmel-smc.txt | 1 + .../devicetree/bindings/misc/atmel-ssc.txt | 1 + .../devicetree/bindings/mmc/sdhci-atmel.txt | 4 +- .../devicetree/bindings/mtd/atmel-nand.txt | 1 + .../devicetree/bindings/net/cdns,macb.yaml | 6 + .../bindings/pinctrl/atmel,at91-pinctrl.txt | 2 + .../power/reset/atmel,sama5d2-shdwc.yaml | 3 + .../reset/atmel,at91sam9260-reset.yaml | 4 + .../bindings/rng/atmel,at91-trng.yaml | 4 + .../bindings/rtc/atmel,at91rm9200-rtc.yaml | 18 +- .../bindings/rtc/atmel,at91sam9260-rtt.yaml | 3 + .../bindings/serial/atmel,at91-usart.yaml | 9 + .../soc/microchip/atmel,at91rm9200-tcb.yaml | 21 +- .../bindings/sound/atmel,sama5d2-classd.yaml | 7 +- .../sound/microchip,sama7g5-i2smcc.yaml | 11 +- .../bindings/spi/atmel,at91rm9200-spi.yaml | 1 - .../devicetree/bindings/usb/atmel-usb.txt | 11 +- .../devicetree/bindings/usb/generic-ehci.yaml | 7 + .../devicetree/bindings/usb/generic-ohci.yaml | 6 + .../bindings/watchdog/atmel,sama5d4-wdt.yaml | 15 +- arch/arm/boot/dts/microchip/Makefile | 5 + .../dts/microchip/at91-sam9x75_curiosity.dts | 311 +++++ arch/arm/boot/dts/microchip/sam9x7.dtsi | 1238 +++++++++++++++++ arch/arm/configs/at91_dt_defconfig | 1 + arch/arm/mach-at91/Kconfig | 23 +- arch/arm/mach-at91/Makefile | 1 + arch/arm/mach-at91/generic.h | 2 + arch/arm/mach-at91/pm.c | 35 + arch/arm/mach-at91/sam9x7.c | 34 + drivers/clk/at91/Makefile | 1 + drivers/clk/at91/clk-sam9x60-pll.c | 50 +- drivers/clk/at91/pmc.h | 18 + drivers/clk/at91/sam9x60.c | 7 + drivers/clk/at91/sam9x7.c | 946 +++++++++++++ drivers/clk/at91/sama7g5.c | 42 +- drivers/irqchip/irq-atmel-aic5.c | 10 + drivers/power/reset/Kconfig | 4 +- drivers/power/reset/at91-sama5d2_shdwc.c | 1 + drivers/soc/atmel/soc.c | 23 + drivers/soc/atmel/soc.h | 9 + include/dt-bindings/clock/at91.h | 4 + 54 files changed, 2871 insertions(+), 76 deletions(-) create mode 100644 arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts create mode 100644 arch/arm/boot/dts/microchip/sam9x7.dtsi create mode 100644 arch/arm/mach-at91/sam9x7.c create mode 100644 drivers/clk/at91/sam9x7.c -- 2.25.1

5 7

[PATCH] ASoC: fsl_micfil: refactor deprecated strncpy
by Justin Stitt 28 Jul '23

28 Jul '23

`strncpy` is deprecated for use on NUL-terminated destination strings [1]. A suitable replacement is `strscpy` [2] due to the fact that it guarantees NUL-termination on its destination buffer argument which is _not_ always the case for `strncpy`! In this case, though, there was great care taken to ensure that the destination buffer would be NUL-terminated through the use of `len - 1` ensuring that the previously zero-initialized buffer would not overwrite the last NUL byte. This means that there's no bug here. However, `strscpy` will add a mandatory NUL byte to the destination buffer as promised by the following `strscpy` implementation [3]: | /* Hit buffer length without finding a NUL; force NUL-termination. */ | if (res) | dest[res-1] = '\0'; This means we can lose the `- 1` which clears up whats happening here. All the while, we get one step closer to eliminating the ambiguous `strncpy` api in favor of its less ambiguous replacement like `strscpy`, `strscpy_pad`, `strtomem` and `strtomem_pad` amongst others. [1]: www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-termi… [2]: manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [3]: https://elixir.bootlin.com/linux/v6.3/source/lib/string.c#L183 Link: https://github.com/KSPP/linux/issues/90 Signed-off-by: Justin Stitt <justinstitt(a)google.com> --- sound/soc/fsl/fsl_micfil.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c index 3f08082a55be..fe28b27e50d0 100644 --- a/sound/soc/fsl/fsl_micfil.c +++ b/sound/soc/fsl/fsl_micfil.c @@ -1044,7 +1044,7 @@ static int fsl_micfil_probe(struct platform_device *pdev) return -ENOMEM; micfil->pdev = pdev; - strncpy(micfil->name, np->name, sizeof(micfil->name) - 1); + strscpy(micfil->name, np->name, sizeof(micfil->name)); micfil->soc = of_device_get_match_data(&pdev->dev); --- base-commit: 57012c57536f8814dec92e74197ee96c3498d24e change-id: 20230727-sound-soc-fsl-4fc5569d771e Best regards, -- Justin Stitt <justinstitt(a)google.com>

3 2

[PATCH v2 00/11] Fix support for System Suspend for CS35L41 HDA
by Stefan Binding 28 Jul '23

28 Jul '23

There have been a couple of customer reports of intermittant issues after system resume, where sometimes the DSP firmware stops responding. Investigations into this issue show that there is a race between receiving a prepare from the HDA core, and the firmware reload which is started by the system resume. This can causes the Global Enable on the CS35L41 to be enabled during the firmware load, which can sometimes cause issues in the DSP. The existing system resume behaviour also did not resume the audio, if audio was previously playing when it was suspended. In addition, during investigation, it was found there were additional problems in the System Resume sequence, as well as the Playback sequence with External Boost, where the driver does not correctly follow its enable sequence for this mode. This can cause additional issues such as pops and clicks. This chain intends to correct the sequences for playback and system suspend/resume so that the driver: obeys the external boost enable sequence; resumes audio on system resume; and avoids the race condition on firmware load and playback during system resume. Changes since v1: - Split patch 1 into 2 separate patches - Combine Patches 6 and 9 Stefan Binding (11): ALSA: cs35l41: Use mbox command to enable speaker output for external boost ALSA: cs35l41: Poll for Power Up/Down rather than waiting a fixed delay ALSA: hda: cs35l41: Check mailbox status of pause command after firmware load ALSA: hda: cs35l41: Ensure we correctly re-sync regmap before system suspending. ALSA: hda: cs35l41: Ensure we pass up any errors during system suspend. ALSA: hda: cs35l41: Move Play and Pause into separate functions ALSA: hda: hda_component: Add pre and post playback hooks to hda_component ALSA: hda: cs35l41: Use pre and post playback hooks ALSA: hda: cs35l41: Rework System Suspend to ensure correct call separation ALSA: hda: cs35l41: Add device_link between HDA and cs35l41_hda ALSA: hda: cs35l41: Ensure amp is only unmuted during playback include/sound/cs35l41.h | 5 +- sound/pci/hda/cs35l41_hda.c | 288 +++++++++++++++++++++++++-------- sound/pci/hda/hda_component.h | 2 + sound/pci/hda/patch_realtek.c | 10 +- sound/soc/codecs/cs35l41-lib.c | 118 ++++++++++++-- sound/soc/codecs/cs35l41.c | 18 +-- 6 files changed, 343 insertions(+), 98 deletions(-) -- 2.34.1

2 14

[PATCH 0/5] ASoC: st: Use maple tree register cache
by Mark Brown 28 Jul '23

28 Jul '23

The maple tree register cache has now got to the point where is is roughly feature compatible with the rbtree cache, let's convert the ST drivers to use the more modern data structure. Signed-off-by: Mark Brown <broonie(a)kernel.org> --- Mark Brown (5): ASoC: sta32x: Update to use maple tree register cache ASoC: sta350: Update to use maple tree register cache ASoC: sta529: Update to use maple tree register cache ASoC: stac9766: Update to use maple tree register cache ASoC: sti-sas: Update to use maple tree register cache sound/soc/codecs/sta32x.c | 2 +- sound/soc/codecs/sta350.c | 2 +- sound/soc/codecs/sta529.c | 2 +- sound/soc/codecs/stac9766.c | 2 +- sound/soc/codecs/sti-sas.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) --- base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5 change-id: 20230701-asoc-st-maple-fc1a8f015154 Best regards, -- Mark Brown <broonie(a)kernel.org>

1 6

[PATCH v3 26/50] dt-bindings: atmel-classd: add sam9x7 compatible
by Varshini Rajendran 28 Jul '23

28 Jul '23

Add sam9x7 compatible to DT bindings documentation. Signed-off-by: Varshini Rajendran <varshini.rajendran(a)microchip.com> --- .../devicetree/bindings/sound/atmel,sama5d2-classd.yaml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/sound/atmel,sama5d2-classd.yaml b/Documentation/devicetree/bindings/sound/atmel,sama5d2-classd.yaml index 43d04702ac2d..ae3162fcfe02 100644 --- a/Documentation/devicetree/bindings/sound/atmel,sama5d2-classd.yaml +++ b/Documentation/devicetree/bindings/sound/atmel,sama5d2-classd.yaml @@ -18,7 +18,12 @@ description: properties: compatible: - const: atmel,sama5d2-classd + oneOf: + - items: + - const: atmel,sama5d2-classd + - items: + - const: microchip,sam9x7-classd + - const: atmel,sama5d2-classd reg: maxItems: 1 -- 2.25.1

1 0

[PATCH 0/2] Intel: sof_rt5682: remove quirk flag
by Brent Lu 28 Jul '23

28 Jul '23

We add a helper funcion to detect amplifier number according to device instance in ACPI table so the SOF_MAX98390_TWEETER_SPEAKER_PRESENT flag and a dmi quirk for 4-amplifier configuration could be safely removed. Also refactory the max_98390_hw_params() function to use an array to handle the TDM parameter. Amplifier number detection and TDM parameter are tested on two Chromebooks. One with 2 MAX98390 and one with 4 MAX98390 amplifier. *** BLURB HERE *** Brent Lu (2): ASoC: Intel: maxim-common: get codec number from ACPI ASoC: Intel: sof_rt5682: remove SOF_MAX98390_TWEETER_SPEAKER_PRESENT flag sound/soc/intel/boards/sof_maxim_common.c | 174 +++++++++++++--------- sound/soc/intel/boards/sof_maxim_common.h | 21 ++- sound/soc/intel/boards/sof_rt5682.c | 37 +---- 3 files changed, 115 insertions(+), 117 deletions(-) -- 2.34.1

7 15

[PATCH v3 0/2] Intel: sof_rt5682: remove quirk flag
by Brent Lu 28 Jul '23

28 Jul '23

We add a helper function to detect amplifier number according to device instance in ACPI table so the SOF_MAX98390_TWEETER_SPEAKER_PRESENT flag and a dmi quirk for 4-amplifier configuration could be safely removed. Also refactor the max_98390_hw_params() function to use an array to handle the TDM parameter. Amplifier number detection and TDM parameter are tested on two Chromebooks. One with 2 MAX98390 and one with 4 MAX98390 amplifier. V2 Changes: - fix some typos in cover letter - use for_each_acpi_dev_match() macro to simplify the codec - use 'unsign int' for codec number variable V3 Changes: - replace pr_err() with dev_err() Brent Lu (2): ASoC: Intel: maxim-common: get codec number from ACPI ASoC: Intel: sof_rt5682: remove SOF_MAX98390_TWEETER_SPEAKER_PRESENT flag sound/soc/intel/boards/sof_maxim_common.c | 171 +++++++++++++--------- sound/soc/intel/boards/sof_maxim_common.h | 21 ++- sound/soc/intel/boards/sof_rt5682.c | 37 +---- 3 files changed, 112 insertions(+), 117 deletions(-) -- 2.34.1

3 4

[PATCH 0/3] Update the register list of MICFIL
by Chancel Liu 28 Jul '23

28 Jul '23

MICFIL IP is upgraded on i.MX93 platform. Add new registers and new bit definition. Chancel Liu (3): ASoC: fsl_micfil: Add new registers and new bit definition ASoC: fsl_micfil: Add fsl_micfil_check_version function ASoC: fsl_micfil: Use SET_SYSTEM_SLEEP_PM_OPS to simplify PM sound/soc/fsl/fsl_micfil.c | 100 ++++++++++++++++++++++++++++++------- sound/soc/fsl/fsl_micfil.h | 64 ++++++++++++++++++++++++ 2 files changed, 146 insertions(+), 18 deletions(-) -- 2.25.1

2 4

[PATCH] ASoC: rt1017: Remove unused function
by Jiapeng Chong 28 Jul '23

28 Jul '23

The function are defined in the rt1017-sdca-sdw.h file, but not called elsewhere, so delete the unused functions. sound/soc/codecs/rt1017-sdca-sdw.h:183:33: warning: ‘rt1017_sdca_mbq_defaults’ defined but not used. Reported-by: Abaci Robot <abaci(a)linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5998 Signed-off-by: Jiapeng Chong <jiapeng.chong(a)linux.alibaba.com> --- sound/soc/codecs/rt1017-sdca-sdw.h | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sound/soc/codecs/rt1017-sdca-sdw.h b/sound/soc/codecs/rt1017-sdca-sdw.h index 5968b9a7d124..4932b5dbe3c0 100644 --- a/sound/soc/codecs/rt1017-sdca-sdw.h +++ b/sound/soc/codecs/rt1017-sdca-sdw.h @@ -180,9 +180,4 @@ static const struct reg_default rt1017_sdca_reg_defaults[] = { RT1017_SDCA_CTL_REQ_POWER_STATE, 0), 0x03 }, }; -static const struct reg_default rt1017_sdca_mbq_defaults[] = { - { SDW_SDCA_CTL(FUNC_NUM_SMART_AMP, RT1017_SDCA_ENT_FU, - RT1017_SDCA_CTL_FU_VOLUME, 0x01), 0x00 }, -}; - #endif /* __RT1017_SDW_H__ */ -- 2.20.1.7.g153144c

2 1