July 2023 - Alsa-devel - mailman.alsa-project.org

[PATCH v2 0/3] AMD Vangogh support for NAU8821/MAX98388
by Cristian Ciocaltea 05 Jul '23

05 Jul '23

This patch series extends the Vangogh machine driver to support a variant based on the Nuvoton NAU88L21 Codec and the Analog Devices MAX98388 Speaker Amplifier. Changes in v2: * Reworked series to ensure the existing devices based on the CS35L41 codec continue to work fine * Rebased onto next-20230703 Cristian Ciocaltea (3): ASoC: amd: vangogh: Make use of DRV_NAME ASoC: amd: vangogh: Use dmi_first_match() for DMI quirk handling ASoC: amd: vangogh: Add support for NAU8821/MAX98388 variant sound/soc/amd/Kconfig | 5 +- sound/soc/amd/vangogh/acp5x-mach.c | 167 +++++++++++++++++++++++++---- 2 files changed, 149 insertions(+), 23 deletions(-) -- 2.41.0

2 5

[tiwai-sound:topic/midi20-gadget 63/63] htmldocs: Documentation/usb/gadget-testing.rst:1019: WARNING: Malformed table.
by kernel test robot 05 Jul '23

05 Jul '23

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git topic/midi20-gadget head: be0c9761ecd79271d4a3efacaec6963a4010a297 commit: be0c9761ecd79271d4a3efacaec6963a4010a297 [63/63] usb: gadget: midi2: Add testing documentation reproduce: (https://download.01.org/0day-ci/archive/20230706/202307060422.HHYZIPqX-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202307060422.HHYZIPqX-lkp@intel.com/ All warnings (new ones prefixed by >>): >> Documentation/usb/gadget-testing.rst:1019: WARNING: Malformed table. vim +1019 Documentation/usb/gadget-testing.rst 1003 1004 =============== =============================================== 1005 name Function Block name string 1006 direction Direction of this FB 1007 1: input, 2: output, or 3: bidirectional 1008 first_group The first UMP Group number (0-15) 1009 num_groups The number of groups in this FB (1-16) 1010 ui_hint UI-hint of this FB 1011 0: unknown, 1: receiver, 2: sender, 3: both 1012 midi_ci_verison Supported MIDI-CI version number (8 bit) 1013 is_midi1 Legacy MIDI 1.0 device (0-2) 1014 0: MIDI 2.0 device, 1015 1: MIDI 1.0 without restriction, or 1016 2: MIDI 1.0 with low speed 1017 sysex8_streams Max number of SysEx8 streams (8 bit) 1018 active Bool flag for FB activity (0 or 1) > 1019 ============= =============================================== 1020 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[tiwai-sound:test/snd_ctl_remove-lock-fix 40/54] htmldocs: ./include/sound/control.h:162: warning: expecting prototype for snd_ctl_find_id(). Prototype was for snd_ctl_find_id_mixer() instead
by kernel test robot 05 Jul '23

05 Jul '23

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git test/snd_ctl_remove-lock-fix head: 9ad18619a06d551105bd84191dca5bb5295277c7 commit: 59444a29dbfd44718fef15083aa339c2c8b579b5 [40/54] ALSA: control: Introduce snd_ctl_find_id_mixer() reproduce: (https://download.01.org/0day-ci/archive/20230706/202307060119.mTXEyy6N-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202307060119.mTXEyy6N-lkp@intel.com/ All warnings (new ones prefixed by >>): >> ./include/sound/control.h:162: warning: expecting prototype for snd_ctl_find_id(). Prototype was for snd_ctl_find_id_mixer() instead vim +162 ./include/sound/control.h 147 148 /** 149 * snd_ctl_find_id - find the control instance with the given name string 150 * @card: the card instance 151 * @name: the name string 152 * 153 * Finds the control instance with the given name and 154 * @SNDRV_CTL_ELEM_IFACE_MIXER. Other fields are set to zero. 155 * 156 * This is merely a wrapper to snd_ctl_find_id(). 157 * 158 * Return: The pointer of the instance if found, or %NULL if not. 159 */ 160 static inline struct snd_kcontrol * 161 snd_ctl_find_id_mixer(struct snd_card *card, const char *name) > 162 { 163 struct snd_ctl_elem_id id = {}; 164 165 id.iface = SNDRV_CTL_ELEM_IFACE_MIXER; 166 strscpy(id.name, name, sizeof(id.name)); 167 return snd_ctl_find_id(card, &id); 168 } 169 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH v3 0/6] Introduce STM32 system bus
by Gatien Chevallier 05 Jul '23

05 Jul '23

Document STM32 System Bus. This bus is intended to control firewall access for the peripherals connected to it. For every peripheral, the bus checks the firewall registers to see if the peripheral is configured as non-secure. If the peripheral is configured as secure, the node is marked populated, so the device won't be probed. This is useful as a firewall configuration sanity check and avoid platform crashes in case peripherals are incorrectly configured. The STM32 System Bus implements the feature-domain-controller bindings. It is used by peripherals to reference a domain controller, in this case the firewall feature domain. The bus uses the ID referenced by the feature-domains property to know where to look in the firewall to get the security configuration for the peripheral. This allows a device tree description rather than a hardcoded peripheral table in the bus driver. On STM32MP13/15 platforms, the firewall bus is represented by the ETZPC node, which is responsible for the securing / MCU isolating the capable peripherals. STM32MP13/15 device trees are updated in this series to implement the bus. All peripherals that are securable or MCU isolation capable by the ETZPC are connected to the bus. Changes in V2: - Corrected YAMLS errors highlighted by Rob's robot - Re-ordered Signed-off-by tags in two patches Changes in V3: - Document feature-domains property in YAML documentation for concerned periperals under the System Bus - Fix STM32 System Bus YAML documentation - Remove STM32 System bus bindings that were currently used as helpers for device tree - Correct few errors in driver - Add missing peripherals under the System Bus that were in SoC variation device tree files - Fix node names Gatien Chevallier (5): dt-bindings: treewide: add feature-domains description in binding files dt-bindings: bus: add STM32 System Bus bus: stm32_sys_bus: add support for STM32MP15 and STM32MP13 system bus ARM: dts: stm32: add ETZPC as a system bus for STM32MP15x boards ARM: dts: stm32: add ETZPC as a system bus for STM32MP13x boards Oleksii Moisieiev (1): dt-bindings: Document common device controller bindings .../devicetree/bindings/bus/st,sys-bus.yaml | 127 + .../bindings/crypto/st,stm32-hash.yaml | 5 + .../devicetree/bindings/dma/st,stm32-dma.yaml | 5 + .../bindings/dma/st,stm32-dmamux.yaml | 5 + .../feature-domain-controller.yaml | 84 + .../devicetree/bindings/i2c/st,stm32-i2c.yaml | 5 + .../bindings/iio/adc/st,stm32-adc.yaml | 5 + .../bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 5 + .../bindings/iio/dac/st,stm32-dac.yaml | 5 + .../bindings/media/st,stm32-cec.yaml | 5 + .../bindings/media/st,stm32-dcmi.yaml | 5 + .../memory-controllers/st,stm32-fmc2-ebi.yaml | 5 + .../bindings/mfd/st,stm32-lptimer.yaml | 5 + .../bindings/mfd/st,stm32-timers.yaml | 6 + .../devicetree/bindings/mmc/arm,pl18x.yaml | 5 + .../devicetree/bindings/net/stm32-dwmac.yaml | 5 + .../bindings/phy/phy-stm32-usbphyc.yaml | 5 + .../bindings/regulator/st,stm32-vrefbuf.yaml | 5 + .../devicetree/bindings/rng/st,stm32-rng.yaml | 5 + .../bindings/serial/st,stm32-uart.yaml | 5 + .../bindings/sound/st,stm32-i2s.yaml | 5 + .../bindings/sound/st,stm32-sai.yaml | 5 + .../bindings/sound/st,stm32-spdifrx.yaml | 5 + .../bindings/spi/st,stm32-qspi.yaml | 5 + .../devicetree/bindings/spi/st,stm32-spi.yaml | 5 + .../devicetree/bindings/usb/dwc2.yaml | 5 + MAINTAINERS | 6 + arch/arm/boot/dts/stm32mp131.dtsi | 407 +-- arch/arm/boot/dts/stm32mp133.dtsi | 51 +- arch/arm/boot/dts/stm32mp13xc.dtsi | 19 +- arch/arm/boot/dts/stm32mp13xf.dtsi | 18 +- arch/arm/boot/dts/stm32mp151.dtsi | 2722 +++++++++-------- arch/arm/boot/dts/stm32mp153.dtsi | 52 +- arch/arm/boot/dts/stm32mp15xc.dtsi | 19 +- drivers/bus/Kconfig | 9 + drivers/bus/Makefile | 1 + drivers/bus/stm32_sys_bus.c | 168 + 37 files changed, 2208 insertions(+), 1596 deletions(-) create mode 100644 Documentation/devicetree/bindings/bus/st,sys-bus.yaml create mode 100644 Documentation/devicetree/bindings/feature-controllers/feature-domain-controller.yaml create mode 100644 drivers/bus/stm32_sys_bus.c -- 2.35.3

7 23

Garbage returned while reading unused S/PDIF, A CM106 like sound card
by Aurélien 05 Jul '23

05 Jul '23

Hello, I encounter troubles while using S/PDIF input on an CM106 like sound card (vendor 0x0d8c, device 0x0102) when the remote device which is connected by S/ PDIF to the sound card is powered off. In that case garbage data are reading from the S/PDIF rather than.. nothing It is really boring since this S/PDIF input is connected to the output speakers and once the remote deviced is powered off it emits a really disturbing sound. Since there is no input on the S/PDIF I guess that it could be a driver bug? If it's an hardware bug (I don't encounter the problem under windows..) is it possible to make a hack in order to distinguish between real data and noise on the S/PDIF input? Unfortunately this test is performed on an embedded device which runs linux 5.16.17-sun50iw6. I don't know if this problem still occurs with newer alsa version. Thank you in advance for your help. Regards, Aurélien

2 1

[PATCH 2/3] ASoC: rt5645: check return value after reading device id
by shumingf＠realtek.com 05 Jul '23

05 Jul '23

From: Shuming Fan <shumingf(a)realtek.com> If the I2C controller encounters some problems like timed-out, the codec driver will report the error code for the first read. Signed-off-by: Shuming Fan <shumingf(a)realtek.com> --- sound/soc/codecs/rt5645.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index c0d56a8f7f47..b0953e9bcaf9 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -3967,7 +3967,11 @@ static int rt5645_i2c_probe(struct i2c_client *i2c) * read and power On. */ msleep(TIME_TO_POWER_MS); - regmap_read(regmap, RT5645_VENDOR_ID2, &val); + ret = regmap_read(regmap, RT5645_VENDOR_ID2, &val); + if (ret < 0) { + dev_err(&i2c->dev, "Failed to read: 0x%02X\n, ret = %d", RT5645_VENDOR_ID2, ret); + goto err_enable; + } switch (val) { case RT5645_DEVICE_ID: -- 2.41.0

2 1

[PATCH] ASoC: cs35l45: Select REGMAP_IRQ
by Nathan Chancellor 05 Jul '23

05 Jul '23

After commit 6085f9e6dc19 ("ASoC: cs35l45: IRQ support"), without any other configuration that selects CONFIG_REGMAP_IRQ, modpost errors out with: ERROR: modpost: "regmap_irq_get_virq" [sound/soc/codecs/snd-soc-cs35l45.ko] undefined! ERROR: modpost: "devm_regmap_add_irq_chip" [sound/soc/codecs/snd-soc-cs35l45.ko] undefined! Add the Kconfig selection to ensure these functions get built and included, which resolves the build failure. Cc: stable(a)vger.kernel.org Fixes: 6085f9e6dc19 ("ASoC: cs35l45: IRQ support") Reported-by: Marcus Seyfarth <m.seyfarth(a)gmail.com> Closes: https://github.com/ClangBuiltLinux/linux/issues/1882 Signed-off-by: Nathan Chancellor <nathan(a)kernel.org> --- sound/soc/codecs/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 0cd107fa112f..76ddd3ffc496 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -715,6 +715,7 @@ config SND_SOC_CS35L41_I2C config SND_SOC_CS35L45 tristate + select REGMAP_IRQ config SND_SOC_CS35L45_SPI tristate "Cirrus Logic CS35L45 CODEC (SPI)" --- base-commit: 6f49256897083848ce9a59651f6b53fc80462397 change-id: 20230703-cs35l45-select-regmap_irq-0fd9d631763c Best regards, -- Nathan Chancellor <nathan(a)kernel.org>

2 1

snd_soc_dai_ops.startup called for all codecs
by Peter Suti 05 Jul '23

05 Jul '23

Hi, I'm trying to create a sound card which has two codecs associated with one DAI. One codec is responsible for playback and the other one for capture. I can see in soc-pcm.c that __soc_pcm_hw_params() is checking if the stream is valid for the current codec with snd_soc_dai_stream_valid() and if it isn't it is not calling the hw_params() callback. But this check is not there in __soc_pcm_open() which calls snd_soc_dai_startup() for every codec. Can someone shed some light on this? Why is startup() called for codecs that don't support the current stream? Thank you! Best Regards, Peter Suti

2 2

[tiwai-sound:test/snd_ctl_remove-lock-fix 31/38] sound/soc/mediatek/mt8188/mt8188-mt6359.c:1000:25: error: implicit declaration of function 'snd_ctl_remove'; did you mean 'snd_ctl_rename'?
by kernel test robot 05 Jul '23

05 Jul '23

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git test/snd_ctl_remove-lock-fix head: 1daeb793bc0d3c3ad9a66718852a4be0584b700c commit: 664c9b8fd2f9e61cbe85d8015fc1962ed10d8a2a [31/38] ALSA: control: Drop snd_ctl_remove() config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20230705/202307051751.ewoQ5wky-lkp@…) compiler: arm-linux-gnueabi-gcc (GCC) 12.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230705/202307051751.ewoQ5wky-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202307051751.ewoQ5wky-lkp@intel.com/ All errors (new ones prefixed by >>): sound/soc/mediatek/mt8188/mt8188-mt6359.c: In function 'mt8188_fixup_controls': >> sound/soc/mediatek/mt8188/mt8188-mt6359.c:1000:25: error: implicit declaration of function 'snd_ctl_remove'; did you mean 'snd_ctl_rename'? [-Werror=implicit-function-declaration] 1000 | snd_ctl_remove(card->snd_card, kctl); | ^~~~~~~~~~~~~~ | snd_ctl_rename cc1: some warnings being treated as errors vim +1000 sound/soc/mediatek/mt8188/mt8188-mt6359.c 9f08dcbddeb307 Trevor Wu 2023-05-26 981 9f08dcbddeb307 Trevor Wu 2023-05-26 982 static void mt8188_fixup_controls(struct snd_soc_card *card) 9f08dcbddeb307 Trevor Wu 2023-05-26 983 { 9f08dcbddeb307 Trevor Wu 2023-05-26 984 struct mt8188_mt6359_priv *priv = snd_soc_card_get_drvdata(card); 9f08dcbddeb307 Trevor Wu 2023-05-26 985 struct mt8188_card_data *card_data = (struct mt8188_card_data *)priv->private_data; 9f08dcbddeb307 Trevor Wu 2023-05-26 986 struct snd_kcontrol *kctl; 9f08dcbddeb307 Trevor Wu 2023-05-26 987 9f08dcbddeb307 Trevor Wu 2023-05-26 988 if (card_data->quirk & NAU8825_HS_PRESENT) { 9f08dcbddeb307 Trevor Wu 2023-05-26 989 struct snd_soc_dapm_widget *w, *next_w; 9f08dcbddeb307 Trevor Wu 2023-05-26 990 9f08dcbddeb307 Trevor Wu 2023-05-26 991 for_each_card_widgets_safe(card, w, next_w) { 9f08dcbddeb307 Trevor Wu 2023-05-26 992 if (strcmp(w->name, "Headphone")) 9f08dcbddeb307 Trevor Wu 2023-05-26 993 continue; 9f08dcbddeb307 Trevor Wu 2023-05-26 994 9f08dcbddeb307 Trevor Wu 2023-05-26 995 snd_soc_dapm_free_widget(w); 9f08dcbddeb307 Trevor Wu 2023-05-26 996 } 9f08dcbddeb307 Trevor Wu 2023-05-26 997 9f08dcbddeb307 Trevor Wu 2023-05-26 998 kctl = ctl_find(card->snd_card, "Headphone Switch"); 9f08dcbddeb307 Trevor Wu 2023-05-26 999 if (kctl) 9f08dcbddeb307 Trevor Wu 2023-05-26 @1000 snd_ctl_remove(card->snd_card, kctl); 9f08dcbddeb307 Trevor Wu 2023-05-26 1001 else 9f08dcbddeb307 Trevor Wu 2023-05-26 1002 dev_warn(card->dev, "Cannot find ctl : Headphone Switch\n"); 9f08dcbddeb307 Trevor Wu 2023-05-26 1003 } 9f08dcbddeb307 Trevor Wu 2023-05-26 1004 } 9f08dcbddeb307 Trevor Wu 2023-05-26 1005 :::::: The code at line 1000 was first introduced by commit :::::: 9f08dcbddeb307793bbfff036db213d2cdf03a50 ASoC: mediatek: mt8188-mt6359: support new board with nau88255 :::::: TO: Trevor Wu <trevor.wu(a)mediatek.com> :::::: CC: Mark Brown <broonie(a)kernel.org> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH v1] sound: seq: check struct system assignment problem
by Minjie Du 05 Jul '23

05 Jul '23

make data->system.parm1 avoid double assignment. but note writes "RT message with two parameters to UMP" is one of assignment is for system.parm2? I'm not sure, Could you help check it out? Thank you! Signed-off-by: Minjie Du <duminjie(a)vivo.com> --- sound/core/seq/seq_ump_convert.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/core/seq/seq_ump_convert.c b/sound/core/seq/seq_ump_convert.c index eb1d86ff6..60e637149 100644 --- a/sound/core/seq/seq_ump_convert.c +++ b/sound/core/seq/seq_ump_convert.c @@ -713,7 +713,6 @@ static int system_2p_ev_to_ump_midi1(const struct snd_seq_event *event, unsigned char status) { data->system.status = status; - data->system.parm1 = (event->data.control.value >> 7) & 0x7f; data->system.parm1 = event->data.control.value & 0x7f; return 1; } -- 2.39.0

1 0