July 2023 - Alsa-devel - mailman.alsa-project.org

[PATCH v1 0/2] ASoC: dt-bindings: nau8822: minor updates
by Francesco Dolcini 21 Jul '23

21 Jul '23

From: Francesco Dolcini <francesco.dolcini(a)toradex.com> Minor updates to NAU8822 DT bindings: - Add #sound-dai-cells - Add MCLK Francesco Dolcini (2): ASoC: dt-bindings: nau8822: Add #sound-dai-cells ASoC: dt-bindings: nau8822: Add MCLK clock .../devicetree/bindings/sound/nuvoton,nau8822.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+) -- 2.25.1

3 5

Fwd: 6.4 and higher causes audio distortion
by Bagas Sanjaya 21 Jul '23

21 Jul '23

Hi, I notice a regression report on Bugzilla [1]. Quoting from it: > I have a Lenovo ThinkPad X1 Yoga Gen 7 running Arch Linux. Linux 6.4 and higher, cause audio distortion. Sometimes, this occurs to the point that nearly nothing is discernible. This carries over to wired headphones. The issue occurs on the entire mainline 6.4.x kernel series and also the 6.4.3 stable and 6.5 RC1 kernel, which are the latest at the time of writing. The issue occurs on both the Arch distributed kernels, and the mainline kernels. > > Linux kernels 6.3.x are not affected and neither is the 6.1 LTS kernel series which is what I am temporarily using. On Windows 10/11 too, the audio works as it should. This indicates that my hardware is not at fault. Bluetooth audio is not impacted from my testing, either. > > The distortion doesn't start immediately. It either occurs automatically after a random amount of time, or when I increase/decrease the volume, or when I skip forward/backward to a section. In order to stop the distortion, I have to either increase/decrease the volume until it stops, or skip forward/backward until it stops, or restart Pipewire via systemd, however it starts again due to one of the aforementioned reasons. > > At the time of this report, I am running Pipewire 0.3.74 and Wireplumber 0.4.14. This also doesn't seem like a Pipewire/Wireplumber issue, since these same versions work fine on the 6.1 LTS kernels without causing any audio distortion. > > I wrote about this on the Arch Linux forums, too, and seems like at least two other people are facing this issue. Here's the forum post: https://bbs.archlinux.org/viewtopic.php?id=287068 > > Furthermore, I filed a bug report on the Arch Linux Bug Reporter, where they suggested that the issue is a kernel regression and should be reported upstream, here. Here's the bug report that I filed on the Arch Linux Bug Reporter for anyone interested: https://bugs.archlinux.org/task/79081?project=1&pagenum=10 > > I have attached the dmesg outputs of the mainline 6.5 RC1 kernel. > > Here's some audio related hardware information from my device: > > inxi -A > > Audio: > Device-1: Intel Alder Lake PCH-P High Definition Audio > driver: sof-audio-pci-intel-tgl > API: ALSA v: k6.5.0-rc1-1-mainline status: kernel-api > > > pactl info > > Server String: /run/user/1000/pulse/native > Library Protocol Version: 35 > Server Protocol Version: 35 > Is Local: yes > Client Index: 138 > Tile Size: 65472 > User Name: tux > Host Name: NSA-Terminal-4 > Server Name: PulseAudio (on PipeWire 0.3.74) > Server Version: 15.0.0 > Default Sample Specification: float32le 2ch 48000Hz > Default Channel Map: front-left,front-right > Default Sink: alsa_output.pci-0000_00_1f.3-platform-skl_hda_dsp_generic.HiFi__hw_sofhdadsp__sink > Default Source: alsa_input.pci-0000_00_1f.3-platform-skl_hda_dsp_generic.HiFi__hw_sofhdadsp_6__source > Cookie: f9dc:5e7a > > > I can't figure out why this is happening. Kindly ask for any more information that is necessary. Thank you. See Bugzilla for the full thread and attached dmesg. Anyway, I'm adding it to regzbot so that it doesn't fall through cracks unnoticed: #regzbot introduced: v6.3..v6.4 https://bugzilla.kernel.org/show_bug.cgi?id=217673 #regzbot title: PipeWire + Wireplumber audio distortion on Lenovo ThinkPad X1 Yoga Gen 7 #regzbot link: https://bbs.archlinux.org/viewtopic.php?id=287068 #regzbot link: https://bugs.archlinux.org/task/79081?project=1&pagenum=10 Thanks. [1]: https://bugzilla.kernel.org/show_bug.cgi?id=217673 -- An old man doll... just what I always wanted! - Clara

3 3

[PATCH v2 0/5] fix for JD event handling in ClockStop Mode0
by shumingf＠realtek.com 21 Jul '23

21 Jul '23

From: Shuming Fan <shumingf(a)realtek.com> Currently, the codec driver could re-enables SDCA interrupt mask and the bus driver re-enables Imp-defined interrupt mask when the devices are re-attached. If the manager uses ClockStop Mode0 to peripherals, the SDCA/Imp-defined interrupt mask will not be enabled when the system resumes. These patches will fix this issue. -- v2 - modify the commit messages Shuming Fan (5): ASoC: rt5682-sdw: fix for JD event handling in ClockStop Mode0 ASoC: rt711: fix for JD event handling in ClockStop Mode0 ASoC: rt711-sdca: fix for JD event handling in ClockStop Mode0 ASoC: rt712-sdca: fix for JD event handling in ClockStop Mode0 ASoC: rt722-sdca: fix for JD event handling in ClockStop Mode0 sound/soc/codecs/rt5682-sdw.c | 9 ++++++++- sound/soc/codecs/rt711-sdca-sdw.c | 10 +++++++++- sound/soc/codecs/rt711-sdw.c | 9 ++++++++- sound/soc/codecs/rt712-sdca-sdw.c | 10 +++++++++- sound/soc/codecs/rt722-sdca-sdw.c | 10 +++++++++- 5 files changed, 43 insertions(+), 5 deletions(-) -- 2.34.1

1 0

[PATCH] ASoC: wm8960: Add DAC filter characteristics selection
by Shengjiu Wang 21 Jul '23

21 Jul '23

Support DAC filter characteristics selection: Normal mode and Sloping stopband. Sloping stopband may have better frequency response. Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> --- sound/soc/codecs/wm8960.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/codecs/wm8960.c b/sound/soc/codecs/wm8960.c index 366f5d769d6d..ff1355306b43 100644 --- a/sound/soc/codecs/wm8960.c +++ b/sound/soc/codecs/wm8960.c @@ -155,6 +155,7 @@ static const char *wm8960_adc_data_output_sel[] = { "Left Data = Right ADC; Right Data = Left ADC", }; static const char *wm8960_dmonomix[] = {"Stereo", "Mono"}; +static const char *wm8960_dacslope[] = {"Normal", "Sloping"}; static const struct soc_enum wm8960_enum[] = { SOC_ENUM_SINGLE(WM8960_DACCTL1, 5, 4, wm8960_polarity), @@ -165,6 +166,7 @@ static const struct soc_enum wm8960_enum[] = { SOC_ENUM_SINGLE(WM8960_ALC3, 8, 2, wm8960_alcmode), SOC_ENUM_SINGLE(WM8960_ADDCTL1, 2, 4, wm8960_adc_data_output_sel), SOC_ENUM_SINGLE(WM8960_ADDCTL1, 4, 2, wm8960_dmonomix), + SOC_ENUM_SINGLE(WM8960_DACCTL2, 1, 2, wm8960_dacslope), }; static const int deemph_settings[] = { 0, 32000, 44100, 48000 }; @@ -307,6 +309,7 @@ SOC_SINGLE_TLV("Right Output Mixer RINPUT3 Volume", SOC_ENUM("ADC Data Output Select", wm8960_enum[6]), SOC_ENUM("DAC Mono Mix", wm8960_enum[7]), +SOC_ENUM("DAC filter characteristics", wm8960_enum[8]), }; static const struct snd_kcontrol_new wm8960_lin_boost[] = { -- 2.34.1

3 2

[PATCH 2/2] ASoC: rt711-sdca: check pin sense when system resumes
by shumingf＠realtek.com 21 Jul '23

21 Jul '23

From: Shuming Fan <shumingf(a)realtek.com> If the jack is unplugged when the system was suspended, the system will believe the jack exists for a while after the system resumes. The codec needs some time, then alerts the host to detect whether the jack exists or not. This patch wants to use the pin sense to detect whether the jack exists or not when the system resumes. It could report the status immediately if the jack was unplugged. It will improve the user experience. Signed-off-by: Shuming Fan <shumingf(a)realtek.com> --- sound/soc/codecs/rt711-sdca-sdw.c | 18 ++++++++++++++++++ sound/soc/codecs/rt711-sdca.c | 2 +- sound/soc/codecs/rt711-sdca.h | 2 ++ 3 files changed, 21 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt711-sdca-sdw.c b/sound/soc/codecs/rt711-sdca-sdw.c index cb27b4a98fb6..13a5316ba999 100644 --- a/sound/soc/codecs/rt711-sdca-sdw.c +++ b/sound/soc/codecs/rt711-sdca-sdw.c @@ -12,6 +12,7 @@ #include <linux/soundwire/sdw_registers.h> #include <linux/module.h> #include <linux/pm_runtime.h> +#include <sound/jack.h> #include "rt711-sdca.h" #include "rt711-sdca-sdw.h" @@ -435,6 +436,8 @@ static int __maybe_unused rt711_sdca_dev_resume(struct device *dev) struct sdw_slave *slave = dev_to_sdw_dev(dev); struct rt711_sdca_priv *rt711 = dev_get_drvdata(dev); unsigned long time; + unsigned int pin_sense; + int ret; if (!rt711->first_hw_init) return 0; @@ -457,6 +460,21 @@ static int __maybe_unused rt711_sdca_dev_resume(struct device *dev) regcache_sync(rt711->regmap); regcache_cache_only(rt711->mbq_regmap, false); regcache_sync(rt711->mbq_regmap); + + /* + * detect whether jack exists or not + * if the jack is unplugged, we will report it immediately + * if the jack exists, it will take some time to detect, then alert the host + */ + ret = rt711_sdca_index_read(rt711, RT711_VENDOR_REG, RT711_IRQ_FLAG_TABLE2, &pin_sense); + pin_sense = ((pin_sense & 0x100) >> 8); + if (ret < 0) { + dev_err(&slave->dev, "Pin Sense read failed:%d\n", ret); + return ret; + } + if (rt711->hs_jack && !pin_sense) + snd_soc_jack_report(rt711->hs_jack, 0, SND_JACK_HEADSET); + return 0; } diff --git a/sound/soc/codecs/rt711-sdca.c b/sound/soc/codecs/rt711-sdca.c index f1a93e3ffa1c..29dce5173f90 100644 --- a/sound/soc/codecs/rt711-sdca.c +++ b/sound/soc/codecs/rt711-sdca.c @@ -42,7 +42,7 @@ static int rt711_sdca_index_write(struct rt711_sdca_priv *rt711, return ret; } -static int rt711_sdca_index_read(struct rt711_sdca_priv *rt711, +int rt711_sdca_index_read(struct rt711_sdca_priv *rt711, unsigned int nid, unsigned int reg, unsigned int *value) { int ret; diff --git a/sound/soc/codecs/rt711-sdca.h b/sound/soc/codecs/rt711-sdca.h index 11d421e8ab2b..aeedb38a0260 100644 --- a/sound/soc/codecs/rt711-sdca.h +++ b/sound/soc/codecs/rt711-sdca.h @@ -240,4 +240,6 @@ int rt711_sdca_init(struct device *dev, struct regmap *regmap, struct regmap *mbq_regmap, struct sdw_slave *slave); int rt711_sdca_jack_detect(struct rt711_sdca_priv *rt711, bool *hp, bool *mic); +int rt711_sdca_index_read(struct rt711_sdca_priv *rt711, + unsigned int nid, unsigned int reg, unsigned int *value); #endif /* __RT711_SDCA_H__ */ -- 2.34.1

1 0

[PATCH 1/2] ASoC: rt711-sdca: fix key tone missing
by shumingf＠realtek.com 21 Jul '23

21 Jul '23

From: Shuming Fan <shumingf(a)realtek.com> This patch uses a bit to check whether the system was hibernated or not. It could avoid repeating the recalibration and CBJ detection. Signed-off-by: Shuming Fan <shumingf(a)realtek.com> --- sound/soc/codecs/rt711-sdca-sdw.c | 1 + sound/soc/codecs/rt711-sdca.c | 17 ++++++++++++++++- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt711-sdca-sdw.c b/sound/soc/codecs/rt711-sdca-sdw.c index 119e1f9605d7..cb27b4a98fb6 100644 --- a/sound/soc/codecs/rt711-sdca-sdw.c +++ b/sound/soc/codecs/rt711-sdca-sdw.c @@ -101,6 +101,7 @@ static bool rt711_sdca_mbq_volatile_register(struct device *dev, unsigned int re case 0x2000080: case 0x2000081: case 0x2000083: + case 0x200009f: case 0x5800000: case 0x5800001: case 0x5f00001: diff --git a/sound/soc/codecs/rt711-sdca.c b/sound/soc/codecs/rt711-sdca.c index 07640d2f6e56..f1a93e3ffa1c 100644 --- a/sound/soc/codecs/rt711-sdca.c +++ b/sound/soc/codecs/rt711-sdca.c @@ -488,6 +488,12 @@ static void rt711_sdca_jack_init(struct rt711_sdca_priv *rt711) /* set SCP_SDCA_IntMask2[0]=1 */ sdw_write_no_pm(rt711->slave, SDW_SCP_SDCA_INTMASK2, SDW_SCP_SDCA_INTMASK_SDCA_8); dev_dbg(&rt711->slave->dev, "in %s enable\n", __func__); + + /* trigger GE interrupt */ + rt711_sdca_index_update_bits(rt711, RT711_VENDOR_HDA_CTL, + RT711_GE_MODE_RELATED_CTL, 0x0080, 0x0080); + rt711_sdca_index_update_bits(rt711, RT711_VENDOR_HDA_CTL, + RT711_GE_MODE_RELATED_CTL, 0x0080, 0x0000); } else { /* disable HID 1/2 event */ rt711_sdca_index_update_bits(rt711, RT711_VENDOR_HDA_CTL, @@ -1493,7 +1499,7 @@ int rt711_sdca_io_init(struct device *dev, struct sdw_slave *slave) { struct rt711_sdca_priv *rt711 = dev_get_drvdata(dev); int ret = 0; - unsigned int val; + unsigned int val, hibernation_flag; rt711->disable_irq = false; @@ -1525,6 +1531,11 @@ int rt711_sdca_io_init(struct device *dev, struct sdw_slave *slave) pm_runtime_get_noresume(&slave->dev); + rt711_sdca_index_read(rt711, RT711_VENDOR_REG, 0x9f, &val); + hibernation_flag = (val >> 8); + if (hibernation_flag) + goto _preset_ready_; + rt711_sdca_reset(rt711); rt711_sdca_index_read(rt711, RT711_VENDOR_REG, RT711_JD_PRODUCT_NUM, &val); @@ -1559,6 +1570,10 @@ int rt711_sdca_io_init(struct device *dev, struct sdw_slave *slave) if (rt711->hs_jack) rt711_sdca_jack_init(rt711); + if (!hibernation_flag) + rt711_sdca_index_update_bits(rt711, RT711_VENDOR_REG, 0x9f, 0x0100, 0x0100); + +_preset_ready_: if (rt711->first_hw_init) { regcache_cache_bypass(rt711->regmap, false); regcache_mark_dirty(rt711->regmap); -- 2.34.1

1 0

[PATCH 1/2] ASoC: rt1316: support the different base clock frequency
by shumingf＠realtek.com 21 Jul '23

21 Jul '23

From: Shuming Fan <shumingf(a)realtek.com> This patch configures all PLL settings to support the all of base clock frequencies. Signed-off-by: Shuming Fan <shumingf(a)realtek.com> --- sound/soc/codecs/rt1316-sdw.c | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt1316-sdw.c b/sound/soc/codecs/rt1316-sdw.c index 721821d9e9af..ce2246a2591c 100644 --- a/sound/soc/codecs/rt1316-sdw.c +++ b/sound/soc/codecs/rt1316-sdw.c @@ -76,6 +76,27 @@ static const struct reg_sequence rt1316_blind_write[] = { { 0xc713, 0x06 }, { 0xc714, 0x80 }, { 0xc715, 0x06 }, + { 0xc720, 0x17 }, + { 0xc721, 0x00 }, + { 0xc722, 0x3e }, + { 0xc723, 0x06 }, + { 0xc724, 0x80 }, + { 0xc725, 0x06 }, + { 0xc730, 0x06 }, + { 0xc731, 0x00 }, + { 0xc732, 0x3E }, + { 0xc740, 0x13 }, + { 0xc741, 0x80 }, + { 0xc742, 0x30 }, + { 0xc743, 0x06 }, + { 0xc744, 0x05 }, + { 0xc745, 0x1E }, + { 0xc750, 0x17 }, + { 0xc751, 0x00 }, + { 0xc752, 0x2E }, + { 0xc753, 0x06 }, + { 0xc754, 0x80 }, + { 0xc755, 0x06 }, { 0xc702, 0x0a }, { 0xc703, 0x0a }, { 0xc001, 0x45 }, @@ -88,7 +109,7 @@ static const struct reg_sequence rt1316_blind_write[] = { { 0xc008, 0x11 }, { 0xc009, 0x00 }, - { 0x2f0a, 0x00 }, + { 0x2f0a, 0x01 }, { 0xd101, 0xf0 }, { 0xd103, 0x9b }, { 0x2f36, 0x8e }, -- 2.34.1

1 0

[PATCH v2 0/4] ALSA: Cleanup with snd_ctl_add_followers()
by Takashi Iwai 21 Jul '23

21 Jul '23

This is another set of cleanup patches: introduce a new standard helper for adding vmaster control elements, and replace the open code in a few drivers with it. Takashi === v1->v2: Cleanup of ac97 patch to drop unnecessary check of the error condition === Takashi Iwai (4): ALSA: vmaster: Add snd_ctl_add_followers() helper ALSA: ac97: Use the standard snd_ctl_add_followers() helper ALSA: ca0106: Use the standard snd_ctl_add_followers() helper ALSA: ice1712: Use the standard snd_ctl_add_followers() helper include/sound/control.h | 3 +++ sound/core/vmaster.c | 28 ++++++++++++++++++++++++++++ sound/pci/ac97/ac97_patch.c | 16 +--------------- sound/pci/ca0106/ca0106_mixer.c | 19 ++++++------------- sound/pci/ice1712/juli.c | 19 +++---------------- sound/pci/ice1712/quartet.c | 15 +++------------ 6 files changed, 44 insertions(+), 56 deletions(-) -- 2.35.3

1 0

[GIT PULL] ASoC fixes for v6.5-rc1-2
by Mark Brown 20 Jul '23

20 Jul '23

The following changes since commit fdf0eaf11452d72945af31804e2a1048ee1b574c: Linux 6.5-rc2 (2023-07-16 15:10:37 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-fix-v6.5-rc1-2 for you to fetch changes up to 269f399dc19f0e5c51711c3ba3bd06e0ef6ef403: ASoC: fsl_sai: Disable bit clock with transmitter (2023-07-17 19:15:07 +0100) ---------------------------------------------------------------- ASoC: Fixes for v6.5 A few more fixes for v6.5, just small driver specific ones. ---------------------------------------------------------------- Dan Carpenter (1): ASoC: SOF: ipc3-dtrace: uninitialized data in dfsentry_trace_filter_write() Derek Fang (1): ASoC: rt5640: Fix the issue of speaker noise Fabio Estevam (1): ASoC: fsl_sai: Revert "ASoC: fsl_sai: Enable MCTL_MCLK_EN bit for master mode" Geert Uytterhoeven (1): ASoC: codecs: SND_SOC_WCD934X should select REGMAP_IRQ Johan Hovold (15): ASoC: codecs: wcd938x: fix codec initialisation race ASoC: codecs: wcd938x: fix mbhc impedance loglevel ASoC: codecs: wcd938x: drop inline keywords ASoC: codecs: wcd938x: use dev_printk() for impedance logging ASoC: codecs: wcd934x: demote impedance printk ASoC: codecs: wcd934x: drop inline keywords ASoC: codecs: wcd938x: fix soundwire initialisation race ASoC: codecs: wcd938x: fix missing mbhc init error handling ASoC: qdsp6: audioreach: fix topology probe deferral ASoC: codecs: wcd938x: fix missing clsh ctrl error handling ASoC: codecs: wcd938x: fix resource leaks on component remove ASoC: codecs: wcd934x: fix resource leaks on component remove ASoC: codecs: wcd-mbhc-v2: fix resource leaks on component remove ASoC: topology: suppress probe deferral errors ASoC: core: suppress probe deferral errors Mario Limonciello (1): ASoC: amd: ps: Fix extraneous error messages Mark Brown (3): ASoC: codecs: wcd938x/wcd934x: loglevel fix and ASoC/soundwire/qdsp6/wcd: fix leaks and probe deferral ASoC: Merge v6.5-rc2 Martin Povišer (1): MAINTAINERS: Redo addition of ssm3515 to APPLE SOUND Mastan Katragadda (1): ASoC: SOF: amd: add revision check for sending sha dma completion command Matthias Reichl (1): ASoC: hdmi-codec: fix channel info for compressed formats Matus Gajdos (1): ASoC: fsl_sai: Disable bit clock with transmitter Nathan Chancellor (1): ASoC: cs35l45: Select REGMAP_IRQ Rob Herring (1): ASoC: dt-bindings: audio-graph-card2: Drop incomplete example Rohit kumar (1): ASoC: dt-bindings: Update maintainer email id Sameer Pujar (1): ASoC: rt5640: Fix sleep in atomic context Sheetal (2): ASoC: tegra: Fix AMX byte map ASoC: tegra: Fix ADX byte map Shuming Fan (1): ASoC: rt5645: check return value after reading device id Srinivas Kandagatla (4): ASoC: qdsp6: q6apm: use dai link pcm id as pcm device number ASoC: qcom: q6afe-dai: fix Display Port Playback stream name ASoC: codecs: wcd938x: fix dB range for HPHL and HPHR ASoC: qcom: q6apm: do not close GPR port before closing graph Thomas Petazzoni (1): ASoC: cs42l51: fix driver to properly autoload with automatic module loading Vijendar Mukunda (6): ASoC: amd: ps: add comments for DMA irq bits mapping ASoC: amd: ps: add fix for dma irq mask for rx streams for SDW0 instance ASoC: amd: ps: fix for position register set for AUDIO0 RX stream ASoC: amd: ps: add comments for DMA register mapping ASoC: amd: ps: fix byte count return value for invalid SoundWire manager instance ASoC: amd: acp: fix for invalid dai id handling in acp_get_byte_count() .../bindings/sound/audio-graph-card2.yaml | 20 +---- .../bindings/sound/google,sc7180-trogdor.yaml | 2 +- .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 2 +- MAINTAINERS | 2 + sound/soc/amd/acp/amd.h | 7 +- sound/soc/amd/ps/acp63.h | 22 ++++- sound/soc/amd/ps/pci-ps.c | 4 +- sound/soc/amd/ps/ps-sdw-dma.c | 16 +++- sound/soc/codecs/Kconfig | 2 + sound/soc/codecs/cs42l51-i2c.c | 6 ++ sound/soc/codecs/cs42l51.c | 7 -- sound/soc/codecs/cs42l51.h | 1 - sound/soc/codecs/rt5640.c | 13 +-- sound/soc/codecs/rt5645.c | 6 +- sound/soc/codecs/wcd-mbhc-v2.c | 57 +++++++++---- sound/soc/codecs/wcd934x.c | 20 ++++- sound/soc/codecs/wcd938x.c | 99 ++++++++++++++++++---- sound/soc/fsl/fsl_sai.c | 8 +- sound/soc/fsl/fsl_sai.h | 1 + sound/soc/qcom/qdsp6/q6afe-dai.c | 2 +- sound/soc/qcom/qdsp6/q6apm-dai.c | 1 + sound/soc/qcom/qdsp6/q6apm.c | 7 +- sound/soc/qcom/qdsp6/topology.c | 4 +- sound/soc/soc-core.c | 6 +- sound/soc/soc-topology.c | 10 ++- sound/soc/sof/amd/acp.c | 10 ++- sound/soc/sof/ipc3-dtrace.c | 9 +- sound/soc/tegra/tegra210_adx.c | 34 +++++--- sound/soc/tegra/tegra210_amx.c | 40 +++++---- 29 files changed, 282 insertions(+), 136 deletions(-)

2 3

[PATCH 00/11] ALSA: Cleanup with snd_ctl_find_id_mixer()
by Takashi Iwai 20 Jul '23

20 Jul '23

Quite a few drivers have the very same open code to find a control element from the given name string. Provide a standard helper and replace with it for cleanup. Takashi === Takashi Iwai (11): ALSA: control: Introduce snd_ctl_find_id_mixer() ALSA: ca0106: Simplify with snd_ctl_find_id_mixer() ALSA: cs46xx: Simplify with snd_ctl_find_id_mixer() ALSA: emu10k1: Simplify with snd_ctl_find_id_mixer() ALSA: es1968: Simplify with snd_ctl_find_id_mixer() ALSA: ice1712: Simplify with snd_ctl_find_id_mixer() ALSA: maestro3: Simplify with snd_ctl_find_id_mixer() ALSA: via82xx: Simplify with snd_ctl_find_id_mixer() ALSA: cmipci: Simplify with snd_ctl_find_id_mixer() ASoC: mediatek: mt8188: Simplify with snd_ctl_find_id_mixer() ALSA: ac97: Simplify with snd_ctl_find_id_mixer() include/sound/control.h | 22 ++++++++++++++++++++++ sound/pci/ac97/ac97_patch.c | 6 +----- sound/pci/ca0106/ca0106_mixer.c | 15 +++------------ sound/pci/cmipci.c | 6 +----- sound/pci/cs46xx/cs46xx_lib.c | 7 ++----- sound/pci/emu10k1/emumixer.c | 11 +---------- sound/pci/es1968.c | 15 ++++----------- sound/pci/ice1712/juli.c | 13 ++----------- sound/pci/ice1712/psc724.c | 19 ++++++++----------- sound/pci/ice1712/quartet.c | 13 ++----------- sound/pci/ice1712/wm8776.c | 6 +----- sound/pci/maestro3.c | 15 ++++----------- sound/pci/via82xx.c | 6 +----- sound/soc/mediatek/mt8188/mt8188-mt6359.c | 12 +----------- 14 files changed, 53 insertions(+), 113 deletions(-) -- 2.35.3

2 12