June 2023 - Alsa-devel - mailman.alsa-project.org

topology: nhlt: intel: support m/n divider and xtal/cardinal/pll clock source
by GitHub pull_request - edited 16 Jun '23

16 Jun '23

alsa-project/alsa-utils pull request #220 was edited from brentlu: Current alsatplg supports only cardinal clock source without m/n divider. Code in SOF ssp driver is ported here to implement the divider function. I tested the code on ADL brya device with following setting: MCLK: 19.2MHz BCLK: 3.072Mz (m 24 n 25) Request URL : https://github.com/alsa-project/alsa-utils/pull/220 Patch URL : https://github.com/alsa-project/alsa-utils/pull/220.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

topology: nhlt: intel: support m/n divider and xtal/cardinal/pll clock source
by GitHub pull_request - opened 16 Jun '23

16 Jun '23

alsa-project/alsa-utils pull request #220 was opened from brentlu: Current alsatplg supports only cardinal clock source without m/n divider. Code in SOF ssp driver is ported here to implement the clock source selection and divider function. I tested the code on ADL brya device with following setting: MCLK: 19.2MHz BCLK: 3.072Mz (m 24 n 25) Request URL : https://github.com/alsa-project/alsa-utils/pull/220 Patch URL : https://github.com/alsa-project/alsa-utils/pull/220.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[PATCH v2 1/1] ASoC: dt-bindings: tlv320aic32x4: convert to DT schema format
by Alexander Stein 16 Jun '23

16 Jun '23

Convert the binding to DT schema format. Since commit 514b044cba667 ("ASoC: tlv320aic32x4: Model PLL in CCF") clocks & clock-names = "mclk" is mandatory, it has been added to required properties as well. '#sound-dai-cells' is added for reference from simple-audio-card. Signed-off-by: Alexander Stein <alexander.stein(a)ew.tq-group.com> --- Changes in v2: * Rebased onto for-next of [1] * Add vendor prefix 'ti' to file name * Simplify 'reg' property * Removed description from 'reset-gpios' * Added reference to dai-common.yaml * Fixed node name in example There is no in-tree user for aic32x4-gpio-func, so I just converted the bindings to YAML and skipped introducing a dt-binding header for defining the constants. [1] https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/log/ .../bindings/sound/ti,tlv320aic32x4.yaml | 101 ++++++++++++++++++ .../bindings/sound/tlv320aic32x4.txt | 42 -------- 2 files changed, 101 insertions(+), 42 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/ti,tlv320aic32x4.yaml delete mode 100644 Documentation/devicetree/bindings/sound/tlv320aic32x4.txt diff --git a/Documentation/devicetree/bindings/sound/ti,tlv320aic32x4.yaml b/Documentation/devicetree/bindings/sound/ti,tlv320aic32x4.yaml new file mode 100644 index 0000000000000..a7cc9aa344684 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/ti,tlv320aic32x4.yaml @@ -0,0 +1,101 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (C) 2019 Texas Instruments Incorporated +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/ti,tlv320aic32x4.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Texas Instruments TLV320AIC32x4 Stereo Audio codec + +maintainers: + - Alexander Stein <alexander.stein(a)ew.tq-group.com> + +description: | + The TLV320AIC32x4 audio codec can be accessed using I2C or SPI + +properties: + compatible: + enum: + - ti,tas2505 + - ti,tlv320aic32x4 + - ti,tlv320aic32x6 + + reg: + maxItems: 1 + + clocks: + items: + - description: Master clock + + clock-names: + items: + - const: mclk + + av-supply: + description: Analog core power supply + + dv-supply: + description: Digital core power supply + + iov-supply: + description: Digital IO power supply + + ldoin-supply: + description: LDO power supply + + reset-gpios: + maxItems: 1 + + '#sound-dai-cells': + const: 0 + + aic32x4-gpio-func: + description: | + GPIO function configuration for pins MFP1-MFP5. + Types are defined in include/sound/tlv320aic32x4.h + $ref: /schemas/types.yaml#/definitions/uint32-array + minItems: 5 + maxItems: 5 + +required: + - compatible + - reg + - clocks + - clock-names + - iov-supply + +allOf: + - $ref: dai-common.yaml# + - if: + not: + required: + - ldoin-supply + then: + required: + - av-supply + - dv-supply + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + audio-codec@18 { + compatible = "ti,tlv320aic32x4"; + reg = <0x18>; + iov-supply = <&reg_3v3>; + ldoin-supply = <&reg_3v3>; + clocks = <&clks 201>; + clock-names = "mclk"; + aic32x4-gpio-func= < + 0xff /* AIC32X4_MFPX_DEFAULT_VALUE */ + 0xff /* AIC32X4_MFPX_DEFAULT_VALUE */ + 0x04 /* MFP3 AIC32X4_MFP3_GPIO_ENABLED */ + 0xff /* AIC32X4_MFPX_DEFAULT_VALUE */ + 0x08 /* MFP5 AIC32X4_MFP5_GPIO_INPUT */ + >; + }; + }; diff --git a/Documentation/devicetree/bindings/sound/tlv320aic32x4.txt b/Documentation/devicetree/bindings/sound/tlv320aic32x4.txt deleted file mode 100644 index 0b4e21bde5bc1..0000000000000 --- a/Documentation/devicetree/bindings/sound/tlv320aic32x4.txt +++ /dev/null @@ -1,42 +0,0 @@ -Texas Instruments - tlv320aic32x4 Codec module - -The tlv320aic32x4 serial control bus communicates through I2C protocols - -Required properties: - - compatible - "string" - One of: - "ti,tlv320aic32x4" TLV320AIC3204 - "ti,tlv320aic32x6" TLV320AIC3206, TLV320AIC3256 - "ti,tas2505" TAS2505, TAS2521 - - reg: I2C slave address - - *-supply: Required supply regulators are: - "iov" - digital IO power supply - "ldoin" - LDO power supply - "dv" - Digital core power supply - "av" - Analog core power supply - If you supply ldoin, dv and av are optional. Otherwise they are required - See regulator/regulator.txt for more information about the detailed binding - format. - -Optional properties: - - reset-gpios: Reset-GPIO phandle with args as described in gpio/gpio.txt - - clocks/clock-names: Clock named 'mclk' for the master clock of the codec. - See clock/clock-bindings.txt for information about the detailed format. - - aic32x4-gpio-func - <array of 5 int> - - Types are defined in include/sound/tlv320aic32x4.h - - -Example: - -codec: tlv320aic32x4@18 { - compatible = "ti,tlv320aic32x4"; - reg = <0x18>; - clocks = <&clks 201>; - clock-names = "mclk"; - aic32x4-gpio-func= < - 0xff /* AIC32X4_MFPX_DEFAULT_VALUE */ - 0xff /* AIC32X4_MFPX_DEFAULT_VALUE */ - 0x04 /* MFP3 AIC32X4_MFP3_GPIO_ENABLED */ - 0xff /* AIC32X4_MFPX_DEFAULT_VALUE */ - 0x08 /* MFP5 AIC32X4_MFP5_GPIO_INPUT */ - >; -}; -- 2.34.1

3 9

[PATCH] ASoC: codecs: wm0010: Add MODULE_FIRMWARE macros
by Juerg Haefliger 16 Jun '23

16 Jun '23

The module loads firmware so add MODULE_FIRMWARE macros to provide that information via modinfo. Signed-off-by: Juerg Haefliger <juerg.haefliger(a)canonical.com> --- sound/soc/codecs/wm0010.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c index 034a4e858c7e..1d4259433f47 100644 --- a/sound/soc/codecs/wm0010.c +++ b/sound/soc/codecs/wm0010.c @@ -994,3 +994,6 @@ module_spi_driver(wm0010_spi_driver); MODULE_DESCRIPTION("ASoC WM0010 driver"); MODULE_AUTHOR("Mark Brown <broonie(a)opensource.wolfsonmicro.com>"); MODULE_LICENSE("GPL"); + +MODULE_FIRMWARE("wm0010.dfw"); +MODULE_FIRMWARE("wm0010_stage2.bin"); -- 2.37.2

1 0

[PATCH] ASoC: rt5677: Add MODULE_FIRMWARE macro
by Juerg Haefliger 16 Jun '23

16 Jun '23

The module loads firmware so add a MODULE_FIRMWARE macro to provide that information via modinfo. Signed-off-by: Juerg Haefliger <juerg.haefliger(a)canonical.com> --- sound/soc/codecs/rt5677.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c index 3bf019b3f700..c8fb98e3406f 100644 --- a/sound/soc/codecs/rt5677.c +++ b/sound/soc/codecs/rt5677.c @@ -5712,3 +5712,5 @@ module_i2c_driver(rt5677_i2c_driver); MODULE_DESCRIPTION("ASoC RT5677 driver"); MODULE_AUTHOR("Oder Chiou <oder_chiou(a)realtek.com>"); MODULE_LICENSE("GPL v2"); + +MODULE_FIRMWARE("rt5677_elf_vad"); -- 2.37.2

1 0

[PATCH 0/8] ASoC: SOF: misc updates for 6.5
by Pierre-Louis Bossart 16 Jun '23

16 Jun '23

Couple of improvements on virtual_widget support, firmware trace free, IPC payload dump, duplicated code in suspend and MeteorLake primary code support. Bard Liao (2): ASoC: SOF: sof-audio: add is_virtual_widget helper ASoC: SOF: sof-audio: test virtual widget in sof_walk_widgets_in_order Peter Ujfalusi (5): ASoC: SOF: core: Free the firmware trace before calling snd_sof_shutdown() ASoC: SOF: Add new sof_debug flag to request message payload dump ASoC: SOF: ipc3: Dump IPC message payload ASoC: SOF: ipc4: Switch to use the sof_debug:bit11 to dump message payload ASoC: SOF: pm: Remove duplicated code in sof_suspend Rander Wang (1): ASoC: SOF: Intel: mtl: setup primary core info on MeteorLake platform sound/soc/sof/core.c | 4 +++- sound/soc/sof/intel/mtl.c | 19 ++++++++++++---- sound/soc/sof/ipc3.c | 39 ++++++++++++++++++++++++++++++++ sound/soc/sof/ipc4.c | 46 ++++++++++++++++++-------------------- sound/soc/sof/pm.c | 12 ++++------ sound/soc/sof/sof-audio.c | 47 ++++++++++++++++++++++++++------------- sound/soc/sof/sof-priv.h | 3 +++ 7 files changed, 117 insertions(+), 53 deletions(-) -- 2.37.2

2 9

[PATCH 1/1] ASoC: dt-bindings: tlv320aic32x4: convert to DT schema format
by Alexander Stein 16 Jun '23

16 Jun '23

Convert the binding to DT schema format. Since commit 514b044cba667 ("ASoC: tlv320aic32x4: Model PLL in CCF") clocks & clock-names = "mclk" is mandatory, it has been added to required properties as well. '#sound-dai-cells' is added for reference from simple-audio-card. Signed-off-by: Alexander Stein <alexander.stein(a)ew.tq-group.com> --- There is no in-tree user for aic32x4-gpio-func, so I just converted the bindings to YAML and skipped introducing a dt-binding header for defining the constants. .../bindings/sound/tlv320aic32x4.txt | 42 ------- .../bindings/sound/tlv320aic32x4.yaml | 103 ++++++++++++++++++ 2 files changed, 103 insertions(+), 42 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/tlv320aic32x4.txt create mode 100644 Documentation/devicetree/bindings/sound/tlv320aic32x4.yaml diff --git a/Documentation/devicetree/bindings/sound/tlv320aic32x4.txt b/Documentation/devicetree/bindings/sound/tlv320aic32x4.txt deleted file mode 100644 index 0b4e21bde5bc1..0000000000000 --- a/Documentation/devicetree/bindings/sound/tlv320aic32x4.txt +++ /dev/null @@ -1,42 +0,0 @@ -Texas Instruments - tlv320aic32x4 Codec module - -The tlv320aic32x4 serial control bus communicates through I2C protocols - -Required properties: - - compatible - "string" - One of: - "ti,tlv320aic32x4" TLV320AIC3204 - "ti,tlv320aic32x6" TLV320AIC3206, TLV320AIC3256 - "ti,tas2505" TAS2505, TAS2521 - - reg: I2C slave address - - *-supply: Required supply regulators are: - "iov" - digital IO power supply - "ldoin" - LDO power supply - "dv" - Digital core power supply - "av" - Analog core power supply - If you supply ldoin, dv and av are optional. Otherwise they are required - See regulator/regulator.txt for more information about the detailed binding - format. - -Optional properties: - - reset-gpios: Reset-GPIO phandle with args as described in gpio/gpio.txt - - clocks/clock-names: Clock named 'mclk' for the master clock of the codec. - See clock/clock-bindings.txt for information about the detailed format. - - aic32x4-gpio-func - <array of 5 int> - - Types are defined in include/sound/tlv320aic32x4.h - - -Example: - -codec: tlv320aic32x4@18 { - compatible = "ti,tlv320aic32x4"; - reg = <0x18>; - clocks = <&clks 201>; - clock-names = "mclk"; - aic32x4-gpio-func= < - 0xff /* AIC32X4_MFPX_DEFAULT_VALUE */ - 0xff /* AIC32X4_MFPX_DEFAULT_VALUE */ - 0x04 /* MFP3 AIC32X4_MFP3_GPIO_ENABLED */ - 0xff /* AIC32X4_MFPX_DEFAULT_VALUE */ - 0x08 /* MFP5 AIC32X4_MFP5_GPIO_INPUT */ - >; -}; diff --git a/Documentation/devicetree/bindings/sound/tlv320aic32x4.yaml b/Documentation/devicetree/bindings/sound/tlv320aic32x4.yaml new file mode 100644 index 0000000000000..ebf84cdcb68d5 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/tlv320aic32x4.yaml @@ -0,0 +1,103 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (C) 2019 Texas Instruments Incorporated +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/tlv320aic32x4.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Texas Instruments TLV320AIC32x4 Stereo Audio codec + +maintainers: + - Alexander Stein <alexander.stein(a)ew.tq-group.com> + +description: | + The TLV320AIC32x4 audio codec can be accessed using I2C or SPI + +properties: + compatible: + enum: + - ti,tas2505 + - ti,tlv320aic32x4 + - ti,tlv320aic32x6 + + reg: + description: | + I2C address or SPI chip select of the device + + clocks: + items: + - description: Master clock + + clock-names: + items: + - const: mclk + + av-supply: + description: Analog core power supply + + dv-supply: + description: Digital core power supply + + iov-supply: + description: Digital IO power supply + + ldoin-supply: + description: LDO power supply + + reset-gpios: + maxItems: 1 + description: | + GPIO used for hardware reset + + '#sound-dai-cells': + const: 0 + + aic32x4-gpio-func: + description: | + GPIO function configuration for pins MFP1-MFP5. + Types are defined in include/sound/tlv320aic32x4.h + $ref: /schemas/types.yaml#/definitions/uint32-array + minItems: 5 + maxItems: 5 + +required: + - compatible + - reg + - clocks + - clock-names + - iov-supply + +additionalProperties: false + +allOf: + - if: + not: + required: + - ldoin-supply + then: + required: + - av-supply + - dv-supply + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + codec: tlv320aic32x4@18 { + compatible = "ti,tlv320aic32x4"; + reg = <0x18>; + iov-supply = <&reg_3v3>; + ldoin-supply = <&reg_3v3>; + clocks = <&clks 201>; + clock-names = "mclk"; + aic32x4-gpio-func= < + 0xff /* AIC32X4_MFPX_DEFAULT_VALUE */ + 0xff /* AIC32X4_MFPX_DEFAULT_VALUE */ + 0x04 /* MFP3 AIC32X4_MFP3_GPIO_ENABLED */ + 0xff /* AIC32X4_MFPX_DEFAULT_VALUE */ + 0x08 /* MFP5 AIC32X4_MFP5_GPIO_INPUT */ + >; + }; + }; -- 2.34.1

3 3

[PATCH] ASoC: amd: correct pm_runtime enable sequence
by Arun Gopal Kondaveeti 16 Jun '23

16 Jun '23

Replace pm_runtime_allow() with pm_runtime_mark_last_busy() & pm_runtime_set_active() in pm_runtime enable sequence for dma drivers. Signed-off-by: Arun Gopal <arungopal.kondaveeti(a)amd.com> --- sound/soc/amd/ps/ps-pdm-dma.c | 3 ++- sound/soc/amd/raven/acp3x-pcm-dma.c | 3 ++- sound/soc/amd/renoir/acp3x-pdm-dma.c | 3 ++- sound/soc/amd/vangogh/acp5x-pcm-dma.c | 4 ++-- sound/soc/amd/yc/acp6x-pdm-dma.c | 3 ++- 5 files changed, 10 insertions(+), 6 deletions(-) diff --git a/sound/soc/amd/ps/ps-pdm-dma.c b/sound/soc/amd/ps/ps-pdm-dma.c index bdbbb797c74d..d48f7c5af289 100644 --- a/sound/soc/amd/ps/ps-pdm-dma.c +++ b/sound/soc/amd/ps/ps-pdm-dma.c @@ -391,8 +391,9 @@ static int acp63_pdm_audio_probe(struct platform_device *pdev) } pm_runtime_set_autosuspend_delay(&pdev->dev, ACP_SUSPEND_DELAY_MS); pm_runtime_use_autosuspend(&pdev->dev); + pm_runtime_mark_last_busy(&pdev->dev); + pm_runtime_set_active(&pdev->dev); pm_runtime_enable(&pdev->dev); - pm_runtime_allow(&pdev->dev); return 0; } diff --git a/sound/soc/amd/raven/acp3x-pcm-dma.c b/sound/soc/amd/raven/acp3x-pcm-dma.c index 7362dd15ad30..9538f3ffc5d9 100644 --- a/sound/soc/amd/raven/acp3x-pcm-dma.c +++ b/sound/soc/amd/raven/acp3x-pcm-dma.c @@ -416,8 +416,9 @@ static int acp3x_audio_probe(struct platform_device *pdev) pm_runtime_set_autosuspend_delay(&pdev->dev, 2000); pm_runtime_use_autosuspend(&pdev->dev); + pm_runtime_mark_last_busy(&pdev->dev); + pm_runtime_set_active(&pdev->dev); pm_runtime_enable(&pdev->dev); - pm_runtime_allow(&pdev->dev); return 0; } diff --git a/sound/soc/amd/renoir/acp3x-pdm-dma.c b/sound/soc/amd/renoir/acp3x-pdm-dma.c index 4e299f96521f..c3b47e9bd239 100644 --- a/sound/soc/amd/renoir/acp3x-pdm-dma.c +++ b/sound/soc/amd/renoir/acp3x-pdm-dma.c @@ -430,8 +430,9 @@ static int acp_pdm_audio_probe(struct platform_device *pdev) } pm_runtime_set_autosuspend_delay(&pdev->dev, ACP_SUSPEND_DELAY_MS); pm_runtime_use_autosuspend(&pdev->dev); + pm_runtime_mark_last_busy(&pdev->dev); + pm_runtime_set_active(&pdev->dev); pm_runtime_enable(&pdev->dev); - pm_runtime_allow(&pdev->dev); return 0; } diff --git a/sound/soc/amd/vangogh/acp5x-pcm-dma.c b/sound/soc/amd/vangogh/acp5x-pcm-dma.c index 29901ee4bfe3..587dec5bb33d 100644 --- a/sound/soc/amd/vangogh/acp5x-pcm-dma.c +++ b/sound/soc/amd/vangogh/acp5x-pcm-dma.c @@ -409,9 +409,9 @@ static int acp5x_audio_probe(struct platform_device *pdev) } pm_runtime_set_autosuspend_delay(&pdev->dev, 2000); pm_runtime_use_autosuspend(&pdev->dev); + pm_runtime_mark_last_busy(&pdev->dev); + pm_runtime_set_active(&pdev->dev); pm_runtime_enable(&pdev->dev); - pm_runtime_allow(&pdev->dev); - return 0; } diff --git a/sound/soc/amd/yc/acp6x-pdm-dma.c b/sound/soc/amd/yc/acp6x-pdm-dma.c index d818eba48546..72c4591e451b 100644 --- a/sound/soc/amd/yc/acp6x-pdm-dma.c +++ b/sound/soc/amd/yc/acp6x-pdm-dma.c @@ -383,8 +383,9 @@ static int acp6x_pdm_audio_probe(struct platform_device *pdev) } pm_runtime_set_autosuspend_delay(&pdev->dev, ACP_SUSPEND_DELAY_MS); pm_runtime_use_autosuspend(&pdev->dev); + pm_runtime_mark_last_busy(&pdev->dev); + pm_runtime_set_active(&pdev->dev); pm_runtime_enable(&pdev->dev); - pm_runtime_allow(&pdev->dev); return 0; } -- 2.25.1

3 3

[PATCH v4 00/13] Add support for IIO devices in ASoC
by Herve Codina 16 Jun '23

16 Jun '23

Several weeks ago, I sent a series [1] for adding a potentiometer as an auxiliary device in ASoC. The feedback was that the potentiometer should be directly handled in IIO (as other potentiometers) and something more generic should be present in ASoC in order to have a binding to import some IIO devices into sound cards. The series related to the IIO potentiometer device is already applied. This series introduces audio-iio-aux. Its goal is to offer the binding between IIO and ASoC. It exposes attached IIO devices as ASoC auxiliary devices and allows to control them through mixer controls. On my system, the IIO device is a potentiometer and it is present in an amplifier design present in the audio path. Compare to the previous iteration https://lore.kernel.org/linux-kernel/20230612122926.107333-1-herve.codina@b… This v4 series mainly: - Fixes headers inclusion - Removes unneeded variable initialization - Adds a missing error check - Fixes typos Best regards, Hervé [1] https://lore.kernel.org/linux-kernel/20230203111422.142479-1-herve.codina@b… [2] https://lore.kernel.org/linux-kernel/20230421085245.302169-1-herve.codina@b… Changes v3 -> v4 - Patches 1, 2 No changes. - Patches 3, 4, 5 Add 'Reviewed-by: Andy Shevchenko <andy.shevchenko(a)gmail.com>'. - Patch 6 (new in v4) Fix headers inclusion order. - Patch 7 (patch 6 in v3) Add a comment related to __must_be_array() Use __array[0] of *__array - Patch 8 (patch 7 in v3) Fix minmax.h inclusion order. Add 'Reviewed-by: Andy Shevchenko <andy.shevchenko(a)gmail.com>'. - Patch 9 (patch 8 in v3) Add 'Suggested-by: Jonathan Cameron <Jonathan.Cameron(a)huawei.com>'. Add 'Reviewed-by: Andy Shevchenko <andy.shevchenko(a)gmail.com>'. - Patch 10 (patch 9 in v3) Add 'Reviewed-by: Andy Shevchenko <andy.shevchenko(a)gmail.com>'. - Patch 11 (patch 10 in v3) Fix a typo. Add 'Suggested-by: Andy Shevchenko <andy.shevchenko(a)gmail.com>'. Add 'Reviewed-by: Andy Shevchenko <andy.shevchenko(a)gmail.com>'. - Patch 12 (patch 11 in v3) Fix typos in the commit log. Fix headers inclusion order. Removed unneeded variable initialization. Replace {0} by {}. Use struct device *dev in probe(). Check an error on the snd-control-invert-range property read. - Patch 13 (patch12 in v3) No changes. Changes v2 -> v3 - Patches 1, 2 No changes. - Patch 3, 4 Add 'Acked-by: Jonathan Cameron <Jonathan.Cameron(a)huawei.com>'. - Patch 5 (new in v3) Removed the 'unused' variable and check the null pointer when used. - Patch 6 (new in v3) Introduce {min,max}_array(). - Patch 7 (new in v3) Use max_array() in iio_channel_read_max(). - Patch 8 (new in v3) Replace a FIXME comment by a TODO one. - Patch 9 (patch 5 in v2) Removed the 'unused' variable and check the null pointer when used. Use min_array(). Remplace a FIXME comment by a TODO one. - Patch 10 (patch 6 in v2) Convert existing macros to return a compound litteral instead of adding a new helper. - Patch 11 (patch 7 in v2) Remove the file name from the C file header. Use directly converted DAPM macros. Replace <linux/module.h> by <linux/mod_devicetable.h>. Add <linux/platform_device.h>. Be sure that min <= max. Swap values if it is not the case. Move the bool structure member after the int ones. Remove unneeded assignements. Use dev_err_probe() when relevant. Use str_on_off(). Use static_assert() instead of BUILD_BUG_ON(). Remove unneeded comma and blank line. Use device_property_*() instead of the OF API. - patch 8 available in v2 removed as already applied - Patch 12 (patch 9 in v2) Use devm_add_action_or_reset(). Call simple_populate_aux() from simple_parse_of(). Changes v1 -> v2 - Patch 1 Rename simple-iio-aux to audio-iio-aux Rename invert to snd-control-invert-range Remove the /schemas/iio/iio-consumer.yaml reference Remove the unneeded '|' after description - Patch 2 (new in v2) Introduce the simple-audio-card additional-devs subnode - Patch 3 (new in v2) Check err before switch() in iio_channel_read_max() - Patch 4 (new in v2) Fix raw reads and raw writes documentation - Patch 5 (patch 2 in v1) Check err before switch() in iio_channel_read_min() Fix documentation - Patch 6 (path 3 in v1) No changes - Patch 7 (patch 4 in v1) Rename simple-iio-aux to audio-iio-aux Rename invert to snd-control-invert-range Remove the mask usage from audio_iio_aux_{get,put}_volsw helpers Use directly PTR_ERR() in dev_err_probe() parameter Remove the '!!' construction Remove of_match_ptr() - Patch 8 (new in v2) Add a missing of_node_put() in the simple-card driver - Patch 9 (new in v2) Handle additional-devs in the simple-card driver Herve Codina (13): ASoC: dt-bindings: Add audio-iio-aux ASoC: dt-bindings: simple-card: Add additional-devs subnode iio: inkern: Check error explicitly in iio_channel_read_max() iio: consumer.h: Fix raw values documentation notes iio: inkern: Remove the 'unused' variable usage in iio_channel_read_max() iio: inkern: Fix headers inclusion order minmax: Introduce {min,max}_array() iio: inkern: Use max_array() to get the maximum value from an array iio: inkern: Replace a FIXME comment by a TODO one iio: inkern: Add a helper to query an available minimum raw value ASoC: soc-dapm.h: Convert macros to return a compound literal ASoC: codecs: Add support for the generic IIO auxiliary devices ASoC: simple-card: Handle additional devices .../bindings/sound/audio-iio-aux.yaml | 64 ++++ .../bindings/sound/simple-card.yaml | 53 +++ drivers/iio/inkern.c | 86 ++++- include/linux/iio/consumer.h | 37 +- include/linux/minmax.h | 36 ++ include/sound/soc-dapm.h | 138 ++++--- sound/soc/codecs/Kconfig | 12 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/audio-iio-aux.c | 338 ++++++++++++++++++ sound/soc/generic/simple-card.c | 46 ++- 10 files changed, 741 insertions(+), 71 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/audio-iio-aux.yaml create mode 100644 sound/soc/codecs/audio-iio-aux.c -- 2.40.1

3 25

Re: sound/soc/soc-pcm.c:2089:5: warning: stack frame size (2064) exceeds limit (2048) in 'dpcm_be_dai_trigger'
by Pierre-Louis Bossart 16 Jun '23

16 Jun '23

On 6/15/23 20:34, kernel test robot wrote: > Hi Pierre-Louis, > > First bad commit (maybe != root cause): > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: b6dad5178ceaf23f369c3711062ce1f2afc33644 > commit: 9995c1d096c8ab1b5f1edc4141257719f6a53524 ASoC: soc-pcm: improve BE transition for PAUSE_RELEASE > date: 1 year, 2 months ago > config: riscv-buildonly-randconfig-r001-20230615 (https://download.01.org/0day-ci/archive/20230616/202306160240.ahGjvPqw-lkp@…) > compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1) > reproduce (this is a W=1 build): > mkdir -p ~/bin > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install riscv cross compiling tool for clang build > # apt-get install binutils-riscv64-linux-gnu > # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… > git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > git fetch --no-tags linus master > git checkout 9995c1d096c8ab1b5f1edc4141257719f6a53524 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=riscv olddefconfig > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash ./ drivers/ fs/ lib/zstd/ mm/ sound/pci/hda/ sound/soc/ > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp(a)intel.com> > | Closes: https://lore.kernel.org/oe-kbuild-all/202306160240.ahGjvPqw-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > >>> sound/soc/soc-pcm.c:2089:5: warning: stack frame size (2064) exceeds limit (2048) in 'dpcm_be_dai_trigger' [-Wframe-larger-than] > int dpcm_be_dai_trigger(struct snd_soc_pcm_runtime *fe, int stream, Not sure what causes this warning to show up, the code hasn't changed in 1.2 years, nor what to do about it.... > ^ > 1 warning generated. > > > vim +/dpcm_be_dai_trigger +2089 sound/soc/soc-pcm.c > > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2088 > 23607025303af6e Liam Girdwood 2014-01-17 @2089 int dpcm_be_dai_trigger(struct snd_soc_pcm_runtime *fe, int stream, > 45c0a188ca59e7e Mark Brown 2012-05-09 2090 int cmd) > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2091 { > db3aa39c9106842 Kuninori Morimoto 2021-03-15 2092 struct snd_soc_pcm_runtime *be; > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2093 bool pause_stop_transition; > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2094 struct snd_soc_dpcm *dpcm; > b2ae80663008a76 Takashi Iwai 2021-12-07 2095 unsigned long flags; > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2096 int ret = 0; > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2097 > 8d6258a4dd26783 Kuninori Morimoto 2018-09-18 2098 for_each_dpcm_be(fe, stream, dpcm) { > db3aa39c9106842 Kuninori Morimoto 2021-03-15 2099 struct snd_pcm_substream *be_substream; > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2100 > db3aa39c9106842 Kuninori Morimoto 2021-03-15 2101 be = dpcm->be; > db3aa39c9106842 Kuninori Morimoto 2021-03-15 2102 be_substream = snd_soc_dpcm_get_substream(be, stream); > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2103 > 3c75c0ea5da749b Takashi Iwai 2022-01-19 2104 snd_soc_dpcm_stream_lock_irqsave_nested(be, stream, flags); > b2ae80663008a76 Takashi Iwai 2021-12-07 2105 > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2106 /* is this op for this BE ? */ > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2107 if (!snd_soc_dpcm_be_can_update(fe, be, stream)) > b2ae80663008a76 Takashi Iwai 2021-12-07 2108 goto next; > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2109 > a9faca15a644ff7 Kuninori Morimoto 2020-12-01 2110 dev_dbg(be->dev, "ASoC: trigger BE %s cmd %d\n", > a9faca15a644ff7 Kuninori Morimoto 2020-12-01 2111 be->dai_link->name, cmd); > a9faca15a644ff7 Kuninori Morimoto 2020-12-01 2112 > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2113 switch (cmd) { > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2114 case SNDRV_PCM_TRIGGER_START: > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2115 if (!be->dpcm[stream].be_start && > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2116 (be->dpcm[stream].state != SND_SOC_DPCM_STATE_PREPARE) && > 21fca8bdbb64df1 이경택 2020-04-01 2117 (be->dpcm[stream].state != SND_SOC_DPCM_STATE_STOP) && > 3202e2f5fac0032 Mark Brown 2021-08-30 2118 (be->dpcm[stream].state != SND_SOC_DPCM_STATE_PAUSED)) > b2ae80663008a76 Takashi Iwai 2021-12-07 2119 goto next; > 6479f7588651cbc Pierre-Louis Bossart 2021-08-17 2120 > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2121 be->dpcm[stream].be_start++; > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2122 if (be->dpcm[stream].be_start != 1) > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2123 goto next; > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2124 > a9faca15a644ff7 Kuninori Morimoto 2020-12-01 2125 ret = soc_pcm_trigger(be_substream, cmd); > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2126 if (ret) { > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2127 be->dpcm[stream].be_start--; > b2ae80663008a76 Takashi Iwai 2021-12-07 2128 goto next; > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2129 } > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2130 > 3202e2f5fac0032 Mark Brown 2021-08-30 2131 be->dpcm[stream].state = SND_SOC_DPCM_STATE_START; > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2132 break; > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2133 case SNDRV_PCM_TRIGGER_RESUME: > 3202e2f5fac0032 Mark Brown 2021-08-30 2134 if ((be->dpcm[stream].state != SND_SOC_DPCM_STATE_SUSPEND)) > b2ae80663008a76 Takashi Iwai 2021-12-07 2135 goto next; > 6479f7588651cbc Pierre-Louis Bossart 2021-08-17 2136 > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2137 be->dpcm[stream].be_start++; > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2138 if (be->dpcm[stream].be_start != 1) > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2139 goto next; > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2140 > a9faca15a644ff7 Kuninori Morimoto 2020-12-01 2141 ret = soc_pcm_trigger(be_substream, cmd); > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2142 if (ret) { > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2143 be->dpcm[stream].be_start--; > b2ae80663008a76 Takashi Iwai 2021-12-07 2144 goto next; > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2145 } > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2146 > 3202e2f5fac0032 Mark Brown 2021-08-30 2147 be->dpcm[stream].state = SND_SOC_DPCM_STATE_START; > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2148 break; > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2149 case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: > 3aa1e96a2b95e2e Pierre-Louis Bossart 2021-12-07 2150 if (!be->dpcm[stream].be_start && > 3aa1e96a2b95e2e Pierre-Louis Bossart 2021-12-07 2151 (be->dpcm[stream].state != SND_SOC_DPCM_STATE_START) && > 3aa1e96a2b95e2e Pierre-Louis Bossart 2021-12-07 2152 (be->dpcm[stream].state != SND_SOC_DPCM_STATE_PAUSED)) > b2ae80663008a76 Takashi Iwai 2021-12-07 2153 goto next; > 6479f7588651cbc Pierre-Louis Bossart 2021-08-17 2154 > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2155 fe->dpcm[stream].fe_pause = false; > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2156 be->dpcm[stream].be_pause--; > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2157 > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2158 be->dpcm[stream].be_start++; > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2159 if (be->dpcm[stream].be_start != 1) > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2160 goto next; > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2161 > a9faca15a644ff7 Kuninori Morimoto 2020-12-01 2162 ret = soc_pcm_trigger(be_substream, cmd); > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2163 if (ret) { > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2164 be->dpcm[stream].be_start--; > b2ae80663008a76 Takashi Iwai 2021-12-07 2165 goto next; > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2166 } > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2167 > 3202e2f5fac0032 Mark Brown 2021-08-30 2168 be->dpcm[stream].state = SND_SOC_DPCM_STATE_START; > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2169 break; > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2170 case SNDRV_PCM_TRIGGER_STOP: > 21fca8bdbb64df1 이경택 2020-04-01 2171 if ((be->dpcm[stream].state != SND_SOC_DPCM_STATE_START) && > 3202e2f5fac0032 Mark Brown 2021-08-30 2172 (be->dpcm[stream].state != SND_SOC_DPCM_STATE_PAUSED)) > b2ae80663008a76 Takashi Iwai 2021-12-07 2173 goto next; > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2174 > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2175 if (be->dpcm[stream].state == SND_SOC_DPCM_STATE_START) > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2176 be->dpcm[stream].be_start--; > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2177 > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2178 if (be->dpcm[stream].be_start != 0) > b2ae80663008a76 Takashi Iwai 2021-12-07 2179 goto next; > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2180 > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2181 pause_stop_transition = false; > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2182 if (fe->dpcm[stream].fe_pause) { > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2183 pause_stop_transition = true; > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2184 fe->dpcm[stream].fe_pause = false; > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2185 be->dpcm[stream].be_pause--; > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2186 } > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2187 > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2188 if (be->dpcm[stream].be_pause != 0) > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2189 ret = soc_pcm_trigger(be_substream, SNDRV_PCM_TRIGGER_PAUSE_PUSH); > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2190 else > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2191 ret = soc_pcm_trigger(be_substream, SNDRV_PCM_TRIGGER_STOP); > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2192 > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2193 if (ret) { > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2194 if (be->dpcm[stream].state == SND_SOC_DPCM_STATE_START) > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2195 be->dpcm[stream].be_start++; > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2196 if (pause_stop_transition) { > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2197 fe->dpcm[stream].fe_pause = true; > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2198 be->dpcm[stream].be_pause++; > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2199 } > b2ae80663008a76 Takashi Iwai 2021-12-07 2200 goto next; > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2201 } > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2202 > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2203 if (be->dpcm[stream].be_pause != 0) > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2204 be->dpcm[stream].state = SND_SOC_DPCM_STATE_PAUSED; > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2205 else > 3202e2f5fac0032 Mark Brown 2021-08-30 2206 be->dpcm[stream].state = SND_SOC_DPCM_STATE_STOP; > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2207 > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2208 break; > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2209 case SNDRV_PCM_TRIGGER_SUSPEND: > 3202e2f5fac0032 Mark Brown 2021-08-30 2210 if (be->dpcm[stream].state != SND_SOC_DPCM_STATE_START) > b2ae80663008a76 Takashi Iwai 2021-12-07 2211 goto next; > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2212 > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2213 be->dpcm[stream].be_start--; > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2214 if (be->dpcm[stream].be_start != 0) > b2ae80663008a76 Takashi Iwai 2021-12-07 2215 goto next; > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2216 > a9faca15a644ff7 Kuninori Morimoto 2020-12-01 2217 ret = soc_pcm_trigger(be_substream, cmd); > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2218 if (ret) { > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2219 be->dpcm[stream].be_start++; > b2ae80663008a76 Takashi Iwai 2021-12-07 2220 goto next; > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2221 } > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2222 > 3202e2f5fac0032 Mark Brown 2021-08-30 2223 be->dpcm[stream].state = SND_SOC_DPCM_STATE_SUSPEND; > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2224 break; > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2225 case SNDRV_PCM_TRIGGER_PAUSE_PUSH: > 3202e2f5fac0032 Mark Brown 2021-08-30 2226 if (be->dpcm[stream].state != SND_SOC_DPCM_STATE_START) > b2ae80663008a76 Takashi Iwai 2021-12-07 2227 goto next; > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2228 > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2229 fe->dpcm[stream].fe_pause = true; > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2230 be->dpcm[stream].be_pause++; > 9995c1d096c8ab1 Pierre-Louis Bossart 2022-04-06 2231 > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2232 be->dpcm[stream].be_start--; > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2233 if (be->dpcm[stream].be_start != 0) > b2ae80663008a76 Takashi Iwai 2021-12-07 2234 goto next; > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2235 > a9faca15a644ff7 Kuninori Morimoto 2020-12-01 2236 ret = soc_pcm_trigger(be_substream, cmd); > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2237 if (ret) { > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2238 be->dpcm[stream].be_start++; > b2ae80663008a76 Takashi Iwai 2021-12-07 2239 goto next; > 848aedfdc6ba25a Pierre-Louis Bossart 2021-12-07 2240 } > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2241 > 3202e2f5fac0032 Mark Brown 2021-08-30 2242 be->dpcm[stream].state = SND_SOC_DPCM_STATE_PAUSED; > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2243 break; > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2244 } > b2ae80663008a76 Takashi Iwai 2021-12-07 2245 next: > b2ae80663008a76 Takashi Iwai 2021-12-07 2246 snd_soc_dpcm_stream_unlock_irqrestore(be, stream, flags); > b2ae80663008a76 Takashi Iwai 2021-12-07 2247 if (ret) > b2ae80663008a76 Takashi Iwai 2021-12-07 2248 break; > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2249 } > db3aa39c9106842 Kuninori Morimoto 2021-03-15 2250 if (ret < 0) > db3aa39c9106842 Kuninori Morimoto 2021-03-15 2251 dev_err(fe->dev, "ASoC: %s() failed at %s (%d)\n", > db3aa39c9106842 Kuninori Morimoto 2021-03-15 2252 __func__, be->dai_link->name, ret); > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2253 return ret; > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2254 } > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2255 EXPORT_SYMBOL_GPL(dpcm_be_dai_trigger); > 01d7584cd2e5a93 Liam Girdwood 2012-04-25 2256 > > :::::: The code at line 2089 was first introduced by commit > :::::: 23607025303af6e84bc2cd4cabe89c21f6a22a3f ASoC: DPCM: make some DPCM API calls non static for compressed usage > > :::::: TO: Liam Girdwood <liam.r.girdwood(a)linux.intel.com> > :::::: CC: Mark Brown <broonie(a)linaro.org> >

2 1