June 2023 - Alsa-devel - mailman.alsa-project.org

[PATCH] ALSA: hda/realtek: Enable 4 amplifiers instead of 2 on a HP platform
by Chris Chiu 06 Jun '23

06 Jun '23

In the commit 7bb62340951a ("ALSA: hda/realtek: fix speaker, mute/micmute LEDs not work on a HP platform"), speakers and LEDs are fixed but only 2 CS35L41 amplifiers on SPI bus connected to Realtek codec are enabled. Need the ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED to get all amplifiers working. Signed-off-by: Chris Chiu <chris.chiu(a)canonical.com> --- sound/pci/hda/patch_realtek.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index f10790ace5c1..0e76938f56df 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9500,7 +9500,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x8b8a, "HP", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8b8b, "HP", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8b8d, "HP", ALC236_FIXUP_HP_GPIO_LED), - SND_PCI_QUIRK(0x103c, 0x8b8f, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8b8f, "HP", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8b92, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8b96, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), SND_PCI_QUIRK(0x103c, 0x8b97, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), -- 2.25.1

2 1

[PATCH 00/28] ASoC: Intel: machine driver updates for 6.5
by Pierre-Louis Bossart 06 Jun '23

06 Jun '23

An unusually large set of patches to deal with new SoundWire-based platforms. The bulk of the patches addresses support for MTL using RT712, RT713, MAX98363, CS42L42 jack codec and amplifiers. The sof_sdw machine driver had to be updated to remove limitations on number of codecs per links, dai types, dai naming, etc. We also moved parts of the Realtek and Maxim support in common code to avoid duplication. Community users also reported two Dell SKUs which were not supported in the mainline due to hardware permutations. Balamurugan C (3): ASoC: Intel: ADL: Enable HDMI-In capture feature support for non-I2S codec boards. ASoC: Intel: ADL: Moving amp only boards into end of the table. ASoC: Intel: Sof_ssp_amp: Correcting author name. Bard Liao (14): ASoC: Intel: sof_sdw: add missing exit callback ASoC: Intel: sof_sdw: add dai info ASoC: Intel: sof_sdw: use predefine dailink id ASoC: Intel: sof_sdw: add codec_info pointer ASoC: Intel: sdw_sof: append dai_type and remove codec_type ASoC: Intel: sof_sdw: add multi dailink support for a codec ASoC: Intel: sof_sdw_rt_sdca_jack_common: test SOF_JACK_JDSRC in _exit ASoC: Intel: sof_sdw: rename SOF_RT711_JDSRC to SOF_JACK_JDSRC ASoC: Intel: sof_sdw: make rt711_sdca be generic ASoC: Intel: sof_sdw: add rt712 support ASoC: Intel: soc-acpi-intel-tgl-match: add rt712 ID ASoC: Intel: soc-acpi-intel-mtl-match: add rt712 ID ASoC: Intel: sof_sdw: add rt713 support ASoC: Intel: sof_sdw: increase sdw pin index for each sdw link Pierre-Louis Bossart (4): ASoC: Intel: soc-acpi: add table for RPL Dell SKU 0BDA ASoC: Intel: sof_sdw: add quick for Dell SKU 0BDA ASoC: Intel: soc-acpi: add tables for Dell SKU 0B34 ASoC: Intel: sof-sdw: add Dell SKU 0B34 Terry Cheong (1): ASoC: Intel: Add rpl_rt1019_rt5682 driver Uday M Bhat (6): ASoC: Intel: sof_sdw: Add helper function for cs42l42 codec ASoC: Intel: sof_sdw: Rename sof_sdw_max98373.c file to sof_sdw_maxim.c ASoC: Intel: sof_sdw: Modify maxim helper functions and structure names ASoC: Intel: sof_sdw: Add support for MAX98363 codec ASoC: Intel: sof_sdw: Add support for Rex soundwire ASoC: Intel: soc-acpi: add Rex CS42l42 and MAX98363 SoundWire entries sound/soc/intel/boards/Kconfig | 4 + sound/soc/intel/boards/Makefile | 10 +- sound/soc/intel/boards/sof_rt5682.c | 11 + sound/soc/intel/boards/sof_sdw.c | 542 +++++++++++++----- sound/soc/intel/boards/sof_sdw_common.h | 86 ++- sound/soc/intel/boards/sof_sdw_cs42l42.c | 131 +++++ .../{sof_sdw_max98373.c => sof_sdw_maxim.c} | 58 +- sound/soc/intel/boards/sof_sdw_rt711.c | 4 +- sound/soc/intel/boards/sof_sdw_rt712_sdca.c | 102 ++++ ...1_sdca.c => sof_sdw_rt_sdca_jack_common.c} | 73 ++- sound/soc/intel/boards/sof_ssp_amp.c | 11 +- .../intel/common/soc-acpi-intel-adl-match.c | 46 +- .../intel/common/soc-acpi-intel-mtl-match.c | 98 ++++ .../intel/common/soc-acpi-intel-rpl-match.c | 42 ++ .../intel/common/soc-acpi-intel-tgl-match.c | 53 ++ 15 files changed, 1045 insertions(+), 226 deletions(-) create mode 100644 sound/soc/intel/boards/sof_sdw_cs42l42.c rename sound/soc/intel/boards/{sof_sdw_max98373.c => sof_sdw_maxim.c} (66%) create mode 100644 sound/soc/intel/boards/sof_sdw_rt712_sdca.c rename sound/soc/intel/boards/{sof_sdw_rt711_sdca.c => sof_sdw_rt_sdca_jack_common.c} (61%) -- 2.37.2

2 29

[PATCH 0/4] ASoC: support dai-links with symmetric clock roles
by Alvin Šipraga 06 Jun '23

06 Jun '23

From: Alvin Šipraga <alsi(a)bang-olufsen.dk> Currently the ASoC core always assumes that one end of a dai-link is a clock provider and the other a consumer. This series adds support for configuring dai-links where both ends are actually clock consumers. Alvin Šipraga (4): ASoC: dt-bindings: document new symmetric-clock-role flag ASoC: core: add support for dai-links with symmetric clock roles ASoC: audio-graph-card2: parse symmetric-clock-roles property ASoC: simple-card: parse symmetric-clock-roles property .../devicetree/bindings/sound/simple-card.yaml | 11 +++++++++++ include/sound/soc.h | 3 +++ sound/soc/generic/audio-graph-card2.c | 7 ++++++- sound/soc/generic/simple-card.c | 4 ++++ sound/soc/soc-core.c | 4 +++- 5 files changed, 27 insertions(+), 2 deletions(-) -- 2.40.0

5 15

[GIT PULL] ASoC fixes for v6.4-rc6
by Mark Brown 06 Jun '23

06 Jun '23

The following changes since commit 011a8719d6105dcb48077ea7a6a88ac019d4aa50: ASoC: dwc: move DMA init to snd_soc_dai_driver probe() (2023-05-23 21:39:30 +0100) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-fix-v6.4-rc6 for you to fetch changes up to 32cf0046a652116d6a216d575f3049a9ff9dd80d: ASoC: fsl_sai: Enable BCI bit if SAI works on synchronous mode with BYP asserted (2023-06-02 12:54:07 +0100) ---------------------------------------------------------------- ASoC: Fixes for v6.4 A lot of routine driver specific fixes here, nothing in the core though there are a couple of fixes for the generic cards. There's also a few new quirks for x86 platforms. ---------------------------------------------------------------- Chancel Liu (1): ASoC: fsl_sai: Enable BCI bit if SAI works on synchronous mode with BYP asserted Edson Juliano Drosdeck (1): ASoC: nau8824: Add quirk to active-high jack-detect Herve Codina (1): ASoC: simple-card: Add missing of_node_put() in case of error Mark Brown (1): ASoC: mediatek: fix use-after-free in driver remove Richard Fitzgerald (1): ASoC: cs35l56: Remove NULL check from cs35l56_sdw_dai_set_stream() Robert Hancock (1): ASoC: simple-card-utils: fix PCM constraint error check Ryan Lee (2): ASoC: max98363: Removed 32bit support ASoC: max98363: limit the number of channel to 1 Sicong Jiang (1): ASoC: amd: yc: Add Thinkpad Neo14 to quirks list for acp6x Srinivas Kandagatla (3): ASoC: codecs: wsa883x: do not set can_multi_write flag ASoC: codecs: wsa881x: do not set can_multi_write flag ASoC: codecs: wcd938x-sdw: do not set can_multi_write flag Trevor Wu (2): ASoC: mediatek: mt8188: fix use-after-free in driver remove path ASoC: mediatek: mt8195: fix use-after-free in driver remove path Vijendar Mukunda (1): ASoC: amd: ps: fix for acp_lock access in pdm driver sound/soc/amd/ps/pci-ps.c | 3 +- sound/soc/amd/ps/ps-pdm-dma.c | 10 +++--- sound/soc/amd/yc/acp6x-mach.c | 7 ++++ sound/soc/codecs/cs35l56.c | 3 -- sound/soc/codecs/max98363.c | 4 +-- sound/soc/codecs/nau8824.c | 24 ++++++++++++++ sound/soc/codecs/wcd938x-sdw.c | 1 - sound/soc/codecs/wsa881x.c | 1 - sound/soc/codecs/wsa883x.c | 1 - sound/soc/fsl/fsl_sai.c | 11 +++++-- sound/soc/fsl/fsl_sai.h | 1 + sound/soc/generic/simple-card-utils.c | 2 +- sound/soc/generic/simple-card.c | 1 + sound/soc/mediatek/mt8188/mt8188-afe-clk.c | 7 ---- sound/soc/mediatek/mt8188/mt8188-afe-clk.h | 1 - sound/soc/mediatek/mt8188/mt8188-afe-pcm.c | 4 --- sound/soc/mediatek/mt8188/mt8188-audsys-clk.c | 47 ++++++++++++++------------- sound/soc/mediatek/mt8188/mt8188-audsys-clk.h | 1 - sound/soc/mediatek/mt8195/mt8195-afe-clk.c | 5 --- sound/soc/mediatek/mt8195/mt8195-afe-clk.h | 1 - sound/soc/mediatek/mt8195/mt8195-afe-pcm.c | 4 --- sound/soc/mediatek/mt8195/mt8195-audsys-clk.c | 47 ++++++++++++++------------- sound/soc/mediatek/mt8195/mt8195-audsys-clk.h | 1 - 23 files changed, 99 insertions(+), 88 deletions(-)

2 1

[bug report] ASoC: starfive: Add JH7110 TDM driver
by Dan Carpenter 06 Jun '23

06 Jun '23

Hello Walker Chen, The patch fd4762b6b5cf: "ASoC: starfive: Add JH7110 TDM driver" from May 26, 2023, leads to the following Smatch static checker warning: sound/soc/starfive/jh7110_tdm.c:584 jh7110_tdm_clk_reset_get() warn: passing zero to 'PTR_ERR' sound/soc/starfive/jh7110_tdm.c 564 static int jh7110_tdm_clk_reset_get(struct platform_device *pdev, 565 struct jh7110_tdm_dev *tdm) 566 { 567 int ret; 568 569 tdm->clks[0].id = "mclk_inner"; 570 tdm->clks[1].id = "tdm_ahb"; 571 tdm->clks[2].id = "tdm_apb"; 572 tdm->clks[3].id = "tdm_internal"; 573 tdm->clks[4].id = "tdm_ext"; 574 tdm->clks[5].id = "tdm"; 575 576 ret = devm_clk_bulk_get(&pdev->dev, ARRAY_SIZE(tdm->clks), tdm->clks); 577 if (ret) { 578 dev_err(&pdev->dev, "Failed to get tdm clocks\n"); 579 return ret; 580 } 581 582 tdm->resets = devm_reset_control_array_get_exclusive(&pdev->dev); The devm_reset_control_array_get() function returns NULL if it's an optional request. But this is not optional. 583 if (IS_ERR_OR_NULL(tdm->resets)) { So that means this should be an if (IS_ERR()) check. --> 584 ret = PTR_ERR(tdm->resets); 585 dev_err(&pdev->dev, "Failed to get tdm resets"); Or if optional was intended then NULL should not be treated as an error case, but as a special kind of success case (no error message). See my blog for a long form of this information: https://staticthinking.wordpress.com/2022/08/01/mixing-error-pointers-and-n… 586 return ret; 587 } 588 589 return 0; 590 } regards, dan carpenter

2 1

[PATCH v3 0/3] Fixes and cleanup for CS35L41 HDA
by Stefan Binding 06 Jun '23

06 Jun '23

Several minor issues were found during additional testing and static analysis. These patches fix these minor issues. CHANGES SINCE V2: Patch 3: - Add missing break CHANGES SINCE V1: Patch 2: - Removed unnecessary cast Stefan Binding (3): ALSA: hda: cs35l41: Clean up Firmware Load Controls ALSA: hda: cs35l41: Fix endian conversions ALSA: hda/realtek: Delete cs35l41 component master during free sound/pci/hda/cs35l41_hda.c | 32 ++++++++++++++------------------ sound/pci/hda/patch_realtek.c | 3 +++ 2 files changed, 17 insertions(+), 18 deletions(-) -- 2.34.1

2 4

[PATCH] ALSA: control: Keep the previous numid at snd_ctl_rename_id()
by Takashi Iwai 06 Jun '23

06 Jun '23

We don't need to change the numid at each time snd_ctl_rename_id() is called, as the control element size itself doesn't change. Let's keep the previous numid value. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/core/control.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/sound/core/control.c b/sound/core/control.c index 82aa1af1d1d8..f4a90a687ae5 100644 --- a/sound/core/control.c +++ b/sound/core/control.c @@ -730,12 +730,16 @@ EXPORT_SYMBOL_GPL(snd_ctl_activate_id); * Finds the control with the old id from the card, and replaces the * id with the new one. * + * The function tries to keep the already assigned numid while replacing + * the rest. + * * Return: Zero if successful, or a negative error code on failure. */ int snd_ctl_rename_id(struct snd_card *card, struct snd_ctl_elem_id *src_id, struct snd_ctl_elem_id *dst_id) { struct snd_kcontrol *kctl; + int saved_numid; down_write(&card->controls_rwsem); kctl = snd_ctl_find_id(card, src_id); @@ -743,10 +747,10 @@ int snd_ctl_rename_id(struct snd_card *card, struct snd_ctl_elem_id *src_id, up_write(&card->controls_rwsem); return -ENOENT; } + saved_numid = kctl->id.numid; remove_hash_entries(card, kctl); kctl->id = *dst_id; - kctl->id.numid = card->last_numid + 1; - card->last_numid += kctl->count; + kctl->id.numid = saved_numid; add_hash_entries(card, kctl); up_write(&card->controls_rwsem); return 0; -- 2.35.3

2 2

[PATCH 0/4] Add Loongson HD Audio support
by Yanteng Si 06 Jun '23

06 Jun '23

* The Loongson HDA controller is compatible with High Definition Audio Specification Revision 1.0a. See <https://loongson.github.io/LoongArch-Documentation/Loongson- 7A1000-usermanual-EN.html#hda-controller> Yanteng Si (4): ALSA: hda: Add Loongson LS7A HD-Audio support ALSA: hda: Using polling mode for loongson controller by default ALSA: hda: Workaround for SDnCTL register on loongson controller ALSA: hda/intel: Workaround for WALLCLK register for loongson controller include/linux/pci_ids.h | 3 +++ sound/hda/hdac_controller.c | 8 +++++++- sound/hda/hdac_device.c | 1 + sound/hda/hdac_stream.c | 8 +++++++- sound/pci/hda/hda_controller.h | 1 + sound/pci/hda/hda_intel.c | 10 ++++++++++ sound/pci/hda/patch_hdmi.c | 1 + 7 files changed, 30 insertions(+), 2 deletions(-) -- 2.31.4

2 8

[PATCH] firmware: cs_dsp: Log correct region name in bin error messages
by Richard Fitzgerald 06 Jun '23

06 Jun '23

In cs_dsp_load_coeff() region_name should be set in the XM/YM/ZM cases otherwise any errors will log the region as "Unknown". While doing this also change one error message that logged the region type ID to log the region_name instead. This makes it consistent with other messages in the same function. Signed-off-by: Richard Fitzgerald <rf(a)opensource.cirrus.com> --- drivers/firmware/cirrus/cs_dsp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/cirrus/cs_dsp.c b/drivers/firmware/cirrus/cs_dsp.c index d7e46a57ecf9..6a9aa97373d3 100644 --- a/drivers/firmware/cirrus/cs_dsp.c +++ b/drivers/firmware/cirrus/cs_dsp.c @@ -2124,6 +2124,7 @@ static int cs_dsp_load_coeff(struct cs_dsp *dsp, const struct firmware *firmware file, blocks, le32_to_cpu(blk->len), type, le32_to_cpu(blk->id)); + region_name = cs_dsp_mem_region_name(type); mem = cs_dsp_find_region(dsp, type); if (!mem) { cs_dsp_err(dsp, "No base for region %x\n", type); @@ -2147,8 +2148,8 @@ static int cs_dsp_load_coeff(struct cs_dsp *dsp, const struct firmware *firmware reg = dsp->ops->region_to_reg(mem, reg); reg += offset; } else { - cs_dsp_err(dsp, "No %x for algorithm %x\n", - type, le32_to_cpu(blk->id)); + cs_dsp_err(dsp, "No %s for algorithm %x\n", + region_name, le32_to_cpu(blk->id)); } break; -- 2.30.2

2 1

[PATCH 0/4] ALSA: Fix kctl->id initialization
by Takashi Iwai 06 Jun '23

06 Jun '23

Inspired by the recent Jaroslav's fix patch, I skimmed over the tree and found that there are a few other similar bugs. Here is a patch set to address them. Most of them are just shuffling the call order, while the one in HD-audio is changed to use snd_ctl_replace_id() helper. Takashi === Takashi Iwai (4): ALSA: ymfpci: Fix kctl->id initialization ALSA: cmipci: Fix kctl->id initialization ALSA: gus: Fix kctl->id initialization ALSA: hda: Fix kctl->id initialization sound/isa/gus/gus_pcm.c | 2 +- sound/pci/cmipci.c | 6 +++--- sound/pci/hda/hda_codec.c | 6 +++++- sound/pci/ymfpci/ymfpci_main.c | 6 +++--- 4 files changed, 12 insertions(+), 8 deletions(-) -- 2.35.3

2 5