May 2023 - Alsa-devel - mailman.alsa-project.org

Linux Mint 21 MSI Z790-A WIFI (ALC4080) no audio from spdif
by GitHub issues - edited 25 May '23

25 May '23

alsa-project/alsa-ucm-conf issue #318 was edited from jasonzliang: Hi, I been troubleshooting problems with sound not coming out from my optical port and I narrowed it down to Linux having problems with the ALC4080 chipset on my MSI Z790-A WIFI motherboard (id: 0db0:d1d7). The version of alsa-ucm-conf installed on my system is 1.2.6.3-1ubuntu1.5. My question is, what changes do I need to make to the alsa configuration files in order to get audio working again? Thanks Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/318 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Linux Mint 21 MSI Z790-A WIFI (ALC4080) no audio from spdif
by GitHub issues - edited 25 May '23

25 May '23

alsa-project/alsa-ucm-conf issue #318 was edited from jasonzliang: Hi, I been troubleshooting problems with sound not coming out from my optical port and I narrowed it down to Linux having problems with the ALC4080 chipset on my MSI Z790-A WIFI motherboard. The version of alsa-ucm-conf installed on my system is 1.2.6.3-1ubuntu1.5. My question is, what changes do I need to make to the alsa configuration files in order to get audio working again? Thanks Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/318 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Linux Mint 21 MSI Z790-A WIFI (ALC4080) no audio from spdif
by GitHub issues - opened 25 May '23

25 May '23

alsa-project/alsa-ucm-conf issue #318 was opened from jasonzliang: Hi, I been troubleshooting problems with sound not coming out from my optical port and I narrowed it down to Linux having problems with the ALC4080 chipset on my MSI Z790-A WIFI motherboard. My question is, what changes do I need to make to the alsa configuration files in order to get audio working again? Thanks Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/318 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH 1/2] ALSA: ump: Drop redundant check of note-on with zero velocity
by Takashi Iwai 25 May '23

25 May '23

The check of a note-on event with zero velocity is done twice, and the latter one is superfluous. Let's drop it. Fixes: 0b5288f5fe63 ("ALSA: ump: Add legacy raw MIDI support") Reported-by: Dan Carpenter <dan.carpenter(a)linaro.org> Closes: https://lore.kernel.org/r/4683198a-84f6-4238-9e87-c70667d84523@kili.mountain Suggested-by: Dan Carpenter <dan.carpenter(a)linaro.org> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/core/ump_convert.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sound/core/ump_convert.c b/sound/core/ump_convert.c index cb7c2f959a27..164829d3e305 100644 --- a/sound/core/ump_convert.c +++ b/sound/core/ump_convert.c @@ -340,9 +340,6 @@ static int cvt_legacy_cmd_to_ump(struct snd_ump_endpoint *ump, switch (status) { case UMP_MSG_STATUS_NOTE_ON: - if (!buf[2]) - status = UMP_MSG_STATUS_NOTE_OFF; - fallthrough; case UMP_MSG_STATUS_NOTE_OFF: midi2->note.note = buf[1]; midi2->note.velocity = upscale_7_to_16bit(buf[2]); -- 2.35.3

1 1

[bug report] ALSA: ump: Add legacy raw MIDI support
by Dan Carpenter 25 May '23

25 May '23

Hello Takashi Iwai, The patch 0b5288f5fe63: "ALSA: ump: Add legacy raw MIDI support" from May 23, 2023, leads to the following Smatch static checker warning: sound/core/ump_convert.c:460 do_convert_to_ump() warn: right shifting more than type allows 8 vs 8 sound/core/ump_convert.c 419 static int do_convert_to_ump(struct snd_ump_endpoint *ump, 420 unsigned char group, unsigned char c, u32 *data) 421 { 422 /* bytes for 0x80-0xf0 */ 423 static unsigned char cmd_bytes[8] = { 424 3, 3, 3, 3, 2, 2, 3, 0 425 }; 426 /* bytes for 0xf0-0xff */ 427 static unsigned char system_bytes[16] = { 428 0, 2, 3, 2, 0, 0, 1, 0, 1, 1, 1, 1, 0, 0, 1, 1 429 }; 430 struct ump_cvt_to_ump *cvt = &ump->out_cvts[group]; 431 unsigned char bytes; 432 433 if (c == UMP_MIDI1_MSG_SYSEX_START) { 434 cvt->in_sysex = 1; 435 cvt->len = 0; 436 return 0; 437 } 438 if (c == UMP_MIDI1_MSG_SYSEX_END) { 439 if (!cvt->in_sysex) 440 return 0; /* skip */ 441 return cvt_legacy_sysex_to_ump(cvt, group, data, true); 442 } 443 444 if ((c & 0xf0) == UMP_MIDI1_MSG_REALTIME) { 445 bytes = system_bytes[c & 0x0f]; 446 if (!bytes) 447 return 0; /* skip */ 448 if (bytes == 1) { 449 data[0] = ump_compose(UMP_MSG_TYPE_SYSTEM, group, 0, c); 450 return 4; 451 } 452 cvt->buf[0] = c; 453 cvt->len = 1; 454 cvt->cmd_bytes = bytes; 455 cvt->in_sysex = 0; /* abort SysEx */ 456 return 0; 457 } 458 459 if (c & 0x80) { --> 460 bytes = cmd_bytes[(c >> 8) & 7]; ^^^^^^ Based on the if statement, it looks like c >> 4 was intended. 461 cvt->buf[0] = c; 462 cvt->len = 1; 463 cvt->cmd_bytes = bytes; 464 cvt->in_sysex = 0; /* abort SysEx */ 465 return 0; 466 } 467 468 if (cvt->in_sysex) { 469 cvt->buf[cvt->len++] = c; 470 if (cvt->len == 6) 471 return cvt_legacy_sysex_to_ump(cvt, group, data, false); 472 return 0; 473 } 474 475 if (!cvt->len) 476 return 0; 477 478 cvt->buf[cvt->len++] = c; 479 if (cvt->len < cvt->cmd_bytes) 480 return 0; 481 cvt->len = 1; 482 if ((cvt->buf[0] & 0xf0) == UMP_MIDI1_MSG_REALTIME) 483 return cvt_legacy_system_to_ump(cvt, group, data); 484 return cvt_legacy_cmd_to_ump(ump, cvt, group, data, cvt->cmd_bytes); 485 } regards, dan carpenter

2 1

[bug report] ALSA: ump: Add legacy raw MIDI support
by Dan Carpenter 25 May '23

25 May '23

Hello Takashi Iwai, The patch 0b5288f5fe63: "ALSA: ump: Add legacy raw MIDI support" from May 23, 2023, leads to the following Smatch static checker warning: sound/core/ump_convert.c:343 cvt_legacy_cmd_to_ump() warn: duplicate check 'buf[2]' (previous on line 333) sound/core/ump_convert.c 305 static int cvt_legacy_cmd_to_ump(struct snd_ump_endpoint *ump, 306 struct ump_cvt_to_ump *cvt, 307 unsigned char group, u32 *data, 308 unsigned char bytes) 309 { 310 const unsigned char *buf = cvt->buf; 311 struct ump_cvt_to_ump_bank *cc; 312 union snd_ump_midi2_msg *midi2 = (union snd_ump_midi2_msg *)data; 313 unsigned char status, channel; 314 315 BUILD_BUG_ON(sizeof(union snd_ump_midi1_msg) != 4); 316 BUILD_BUG_ON(sizeof(union snd_ump_midi2_msg) != 8); 317 318 /* for MIDI 1.0 UMP, it's easy, just pack it into UMP */ 319 if (ump->info.protocol & SNDRV_UMP_EP_INFO_PROTO_MIDI1) { 320 data[0] = ump_compose(UMP_MSG_TYPE_MIDI1_CHANNEL_VOICE, 321 group, 0, buf[0]); 322 data[0] |= buf[1] << 8; 323 if (bytes > 2) 324 data[0] |= buf[2]; 325 return 4; 326 } 327 328 status = *buf >> 4; 329 channel = *buf & 0x0f; 330 cc = &cvt->bank[channel]; 331 332 /* special handling: treat note-on with 0 velocity as note-off */ 333 if (status == UMP_MSG_STATUS_NOTE_ON && !buf[2]) 334 status = UMP_MSG_STATUS_NOTE_OFF; This if statment 335 336 /* initialize the packet */ 337 data[0] = ump_compose(UMP_MSG_TYPE_MIDI2_CHANNEL_VOICE, 338 group, status, channel); 339 data[1] = 0; 340 341 switch (status) { 342 case UMP_MSG_STATUS_NOTE_ON: --> 343 if (!buf[2]) 344 status = UMP_MSG_STATUS_NOTE_OFF; and this one are the same. One could be deleted. 345 fallthrough; 346 case UMP_MSG_STATUS_NOTE_OFF: 347 midi2->note.note = buf[1]; 348 midi2->note.velocity = upscale_7_to_16bit(buf[2]); 349 break; 350 case UMP_MSG_STATUS_POLY_PRESSURE: 351 midi2->paf.note = buf[1]; 352 midi2->paf.data = upscale_7_to_32bit(buf[2]); 353 break; 354 case UMP_MSG_STATUS_CC: 355 switch (buf[1]) { 356 case UMP_CC_RPN_MSB: 357 cc->rpn_set = 1; 358 cc->cc_rpn_msb = buf[2]; 359 return 0; // skip 360 case UMP_CC_RPN_LSB: 361 cc->rpn_set = 1; 362 cc->cc_rpn_lsb = buf[2]; 363 return 0; // skip 364 case UMP_CC_NRPN_MSB: 365 cc->nrpn_set = 1; 366 cc->cc_nrpn_msb = buf[2]; 367 return 0; // skip 368 case UMP_CC_NRPN_LSB: 369 cc->nrpn_set = 1; 370 cc->cc_nrpn_lsb = buf[2]; 371 return 0; // skip 372 case UMP_CC_DATA: 373 cc->cc_data_msb = buf[2]; 374 return 0; // skip 375 case UMP_CC_BANK_SELECT: 376 cc->bank_set = 1; 377 cc->cc_bank_msb = buf[2]; 378 return 0; // skip 379 case UMP_CC_BANK_SELECT_LSB: 380 cc->bank_set = 1; 381 cc->cc_bank_lsb = buf[2]; 382 return 0; // skip 383 case UMP_CC_DATA_LSB: 384 cc->cc_data_lsb = buf[2]; 385 if (cc->rpn_set || cc->nrpn_set) 386 fill_rpn(cc, midi2); 387 else 388 return 0; // skip 389 break; 390 default: 391 midi2->cc.index = buf[1]; 392 midi2->cc.data = upscale_7_to_32bit(buf[2]); 393 break; 394 } 395 break; 396 case UMP_MSG_STATUS_PROGRAM: 397 midi2->pg.program = buf[1]; 398 if (cc->bank_set) { 399 midi2->pg.bank_valid = 1; 400 midi2->pg.bank_msb = cc->cc_bank_msb; 401 midi2->pg.bank_lsb = cc->cc_bank_lsb; 402 cc->bank_set = 0; 403 cc->cc_bank_msb = cc->cc_bank_lsb = 0; 404 } 405 break; 406 case UMP_MSG_STATUS_CHANNEL_PRESSURE: 407 midi2->caf.data = upscale_7_to_32bit(buf[1]); 408 break; 409 case UMP_MSG_STATUS_PITCH_BEND: 410 midi2->pb.data = upscale_14_to_32bit(buf[1] | (buf[2] << 7)); 411 break; 412 default: 413 return 0; 414 } 415 416 return 8; 417 } regards, dan carpenter

2 1

[PATCH v2 0/7] ASoC: mt8188: add new board support
by Trevor Wu 25 May '23

25 May '23

In the series, we extend the capability of mt8188-mt6359 driver. The following changes are included. 1. Divide ADDA BE dai into two dais for SOF. 2. Register hdmi/dp jack pins. 3. dai_fmt can be configured from device tree. 4. Add some I2S codecs support. In addition, new compatible string "mediatek,mt8188-nau8825" is included for a new board support. Changes since v1: - add "Headphone Jack" for Nau8825 - separate binding patch 2 from patch 6, and rename the subject - clean up debugfs for freed widget Trevor Wu (7): ASoC: mediatek: mt8188: separate ADDA playback dai from capture dai ASoC: dt-bindings: mediatek,mt8188-mt6359: remove ADDA_BE from link-name ASoC: mediatek: mt8188-mt6359: register hdmi/dp jack pins ASoC: mediatek: common: soundcard driver add dai_fmt support ASoC: soc-dapm.c: clean up debugfs for freed widget ASoC: mediatek: mt8188-mt6359: support new board with nau88255 ASoC: dt-bindings: mediatek,mt8188-mt6359: add NAU8825 support .../sound/mediatek,mt8188-mt6359.yaml | 27 +- sound/soc/mediatek/Kconfig | 4 + .../mediatek/common/mtk-soundcard-driver.c | 49 ++- sound/soc/mediatek/mt8188/mt8188-afe-common.h | 3 +- sound/soc/mediatek/mt8188/mt8188-dai-adda.c | 73 ++-- sound/soc/mediatek/mt8188/mt8188-mt6359.c | 389 +++++++++++++++++- sound/soc/soc-dapm.c | 16 + 7 files changed, 507 insertions(+), 54 deletions(-) -- 2.18.0

3 22

Fwd: XPS 17 - Intel® Smart Sound Technology for MIPI SoundWire® Audio (device not recognized)
by Bagas Sanjaya 25 May '23

25 May '23

Hi, I notice a bug report on Bugzilla [1]. As many developers don't keep an eye on it, I decide to forward it by email. Quoting from it: > Ubuntu (Lobster) 23.04 not recognizing Intel® Smart Sound Technology for MIPI SoundWire® Audio. > > gnome-control-center showing dummy-output. > > I tried with the latest mainline kernel 6.4.00-RC2, still sound not working. See bugzilla for the full thread. The reporter said that he had problem only with integrated sound card on his laptop, and he also attached dmesg and working audio capture from Windows. Thanks. [1]: https://bugzilla.kernel.org/show_bug.cgi?id=217461 -- An old man doll... just what I always wanted! - Clara

1 0

[PATCH 00/20] ASoC: replace dpcm_playback/capture to playback/capture_only
by Kuninori Morimoto 25 May '23

25 May '23

Hi Mark Current ASoC can use DPCM, and we need to set dpcm_playback/capture to use it. OTOH, we are using playback/capture_only flag on Normal/Codec2Codec case. I think it is very duplicated, we can share same rules for all cases. This patch-set cleanup these. 1 - 7 : cleanup functions. 8 : main patch 9 - 19 : replace flags on each drivers 20 : remove old flags Kuninori Morimoto (20): 1 ASoC: soc-pcm.c: indicate error if stream has no playback no capture 2 ASoC: soc-pcm.c: use dai_link on soc_get_playback_capture() 3 ASoC: soc-pcm.c: cleanup soc_get_playback_capture() error 4 ASoC: soc-pcm.c: use temporary variable at soc_get_playback_capture() 5 ASoC: soc-pcm.c: tidyup playback/capture_only at soc_get_playback_capture() 6 ASoC: soc-pcm.c: cleanup normal connection loop at soc_get_playback_capture() part1 7 ASoC: soc-pcm.c: cleanup normal connection loop at soc_get_playback_capture() part2 8 ASoC: soc-pcm.c: cleanup soc_get_playback_capture() 9 ASoC: amd: replace dpcm_playback/capture to playback/capture_only 10 ASoC: fsl: replace dpcm_playback/capture to playback/capture_only 11 ASoC: sof: replace dpcm_playback/capture to playback/capture_only 12 ASoC: meson: replace dpcm_playback/capture to playback/capture_only 13 ASoC: Intel: replace dpcm_playback/capture to playback/capture_only 14 ASoC: samsung: replace dpcm_playback/capture to playback/capture_only 15 ASoC: mediatek: replace dpcm_playback/capture to playback/capture_only 16 ASoC: soc-dai.c: replace dpcm_playback/capture to playback/capture_only 17 ASoC: soc-core.c: replace dpcm_playback/capture to playback/capture_only 18 ASoC: soc-topology.c: replace dpcm_playback/capture to playback/capture_only 19 ASoC: soc-compress.c: replace dpcm_playback/capture to playback/capture_only 20 ASoC: soc-pcm.c: remove dpcm_playback/capture include/sound/soc.h | 4 - sound/soc/amd/acp-da7219-max98357a.c | 20 ++-- sound/soc/amd/acp-es8336.c | 2 - sound/soc/amd/acp/acp-mach-common.c | 20 +--- sound/soc/amd/acp3x-rt5682-max9836.c | 6 +- sound/soc/amd/vangogh/acp5x-mach.c | 3 - sound/soc/fsl/fsl-asoc-card.c | 16 +-- sound/soc/fsl/imx-audmix.c | 6 +- sound/soc/fsl/imx-card.c | 4 +- sound/soc/intel/avs/boards/da7219.c | 2 - sound/soc/intel/avs/boards/dmic.c | 4 +- sound/soc/intel/avs/boards/hdaudio.c | 4 - sound/soc/intel/avs/boards/i2s_test.c | 2 - sound/soc/intel/avs/boards/max98357a.c | 2 +- sound/soc/intel/avs/boards/max98373.c | 2 - sound/soc/intel/avs/boards/max98927.c | 2 - sound/soc/intel/avs/boards/nau8825.c | 2 - sound/soc/intel/avs/boards/rt274.c | 2 - sound/soc/intel/avs/boards/rt286.c | 2 - sound/soc/intel/avs/boards/rt298.c | 2 - sound/soc/intel/avs/boards/rt5682.c | 2 - sound/soc/intel/avs/boards/ssm4567.c | 2 - sound/soc/intel/boards/bdw-rt5650.c | 4 - sound/soc/intel/boards/bdw-rt5677.c | 4 - sound/soc/intel/boards/bdw_rt286.c | 10 +- sound/soc/intel/boards/bxt_da7219_max98357a.c | 32 +++--- sound/soc/intel/boards/bxt_rt298.c | 26 ++--- sound/soc/intel/boards/bytcht_cx2072x.c | 6 +- sound/soc/intel/boards/bytcht_da7213.c | 6 +- sound/soc/intel/boards/bytcht_es8316.c | 6 +- sound/soc/intel/boards/bytcht_nocodec.c | 6 +- sound/soc/intel/boards/bytcr_rt5640.c | 6 +- sound/soc/intel/boards/bytcr_rt5651.c | 6 +- sound/soc/intel/boards/bytcr_wm5102.c | 6 +- sound/soc/intel/boards/cht_bsw_max98090_ti.c | 6 +- sound/soc/intel/boards/cht_bsw_nau8824.c | 6 +- sound/soc/intel/boards/cht_bsw_rt5645.c | 6 +- sound/soc/intel/boards/cht_bsw_rt5672.c | 6 +- sound/soc/intel/boards/cml_rt1011_rt5682.c | 14 +-- sound/soc/intel/boards/ehl_rt5660.c | 14 +-- sound/soc/intel/boards/glk_rt5682_max98357a.c | 30 +++-- sound/soc/intel/boards/hsw_rt5640.c | 10 +- sound/soc/intel/boards/kbl_da7219_max98357a.c | 26 ++--- sound/soc/intel/boards/kbl_da7219_max98927.c | 54 ++++----- sound/soc/intel/boards/kbl_rt5660.c | 18 ++- sound/soc/intel/boards/kbl_rt5663_max98927.c | 44 ++++--- .../intel/boards/kbl_rt5663_rt5514_max98927.c | 22 ++-- sound/soc/intel/boards/skl_hda_dsp_common.c | 14 +-- .../soc/intel/boards/skl_nau88l25_max98357a.c | 26 ++--- sound/soc/intel/boards/skl_nau88l25_ssm4567.c | 26 ++--- sound/soc/intel/boards/skl_rt286.c | 26 ++--- sound/soc/intel/boards/sof_cs42l42.c | 12 +- sound/soc/intel/boards/sof_da7219_max98373.c | 16 +-- sound/soc/intel/boards/sof_es8336.c | 8 +- sound/soc/intel/boards/sof_nau8825.c | 12 +- sound/soc/intel/boards/sof_pcm512x.c | 8 +- sound/soc/intel/boards/sof_rt5682.c | 12 +- sound/soc/intel/boards/sof_sdw.c | 4 +- sound/soc/intel/boards/sof_ssp_amp.c | 11 +- sound/soc/intel/boards/sof_wm8804.c | 2 - sound/soc/mediatek/mt2701/mt2701-cs42448.c | 20 +--- sound/soc/mediatek/mt2701/mt2701-wm8960.c | 6 +- sound/soc/mediatek/mt6797/mt6797-mt6351.c | 24 ++-- sound/soc/mediatek/mt8173/mt8173-max98090.c | 6 +- .../mediatek/mt8173/mt8173-rt5650-rt5514.c | 6 +- .../mediatek/mt8173/mt8173-rt5650-rt5676.c | 10 +- sound/soc/mediatek/mt8173/mt8173-rt5650.c | 10 +- .../mediatek/mt8183/mt8183-da7219-max98357.c | 34 +++--- .../mt8183/mt8183-mt6358-ts3a227-max98357.c | 34 +++--- .../mt8186/mt8186-mt6366-da7219-max98357.c | 86 ++++++-------- .../mt8186/mt8186-mt6366-rt1019-rt5682s.c | 86 ++++++-------- sound/soc/mediatek/mt8188/mt8188-mt6359.c | 48 ++++---- .../mt8192/mt8192-mt6359-rt1015-rt5682.c | 78 ++++++------- sound/soc/mediatek/mt8195/mt8195-mt6359.c | 60 +++++----- sound/soc/meson/axg-card.c | 8 +- sound/soc/meson/meson-card-utils.c | 4 +- sound/soc/samsung/odroid.c | 10 +- sound/soc/soc-compress.c | 11 +- sound/soc/soc-core.c | 20 +--- sound/soc/soc-dai.c | 4 +- sound/soc/soc-pcm.c | 107 +++++++----------- sound/soc/soc-topology-test.c | 2 - sound/soc/soc-topology.c | 4 +- sound/soc/sof/nocodec.c | 4 - 84 files changed, 502 insertions(+), 842 deletions(-) -- 2.25.1

2 43

How fix microphone for ALC4080
by GitHub issues - opened 24 May '23

24 May '23

alsa-project/alsa-ucm-conf issue #317 was opened from h4kuna: Hello, i'am running on Ubuntu 22.04 where is `lsa-ucm-conf 1.2.6.3-1ubuntu1.5`. The sound card does't work. I have motherboard [MAG X570S TOMAHAWK MAX WIFI](https://www.msi.com/Motherboard/MAG-X570S-TOMAHAWK-MAX-WIFI/Specifica… where is `Realtek® ALC4080`. I saw, it added later. I try to use live CD ubuntu 23.04, where sound works, but microphone still doesn't work. ### Ubuntu 22.04 Output from [alsa-info](http://alsa-project.org/db/?f=d2e40705662fc6a0f9e64af8e64bfd0ded… ``` lsusb | grep 'USB Audio' Bus 003 Device 002: ID 0db0:a073 Micro Star International USB Audio ``` What can i to do for fix microphone? What do you need information? Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/317 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0