May 2023 - Alsa-devel - mailman.alsa-project.org

[bug report] ALSA: ump: Add legacy raw MIDI support
by Dan Carpenter 25 May '23

25 May '23

Hello Takashi Iwai, The patch 0b5288f5fe63: "ALSA: ump: Add legacy raw MIDI support" from May 23, 2023, leads to the following Smatch static checker warning: sound/core/ump_convert.c:343 cvt_legacy_cmd_to_ump() warn: duplicate check 'buf[2]' (previous on line 333) sound/core/ump_convert.c 305 static int cvt_legacy_cmd_to_ump(struct snd_ump_endpoint *ump, 306 struct ump_cvt_to_ump *cvt, 307 unsigned char group, u32 *data, 308 unsigned char bytes) 309 { 310 const unsigned char *buf = cvt->buf; 311 struct ump_cvt_to_ump_bank *cc; 312 union snd_ump_midi2_msg *midi2 = (union snd_ump_midi2_msg *)data; 313 unsigned char status, channel; 314 315 BUILD_BUG_ON(sizeof(union snd_ump_midi1_msg) != 4); 316 BUILD_BUG_ON(sizeof(union snd_ump_midi2_msg) != 8); 317 318 /* for MIDI 1.0 UMP, it's easy, just pack it into UMP */ 319 if (ump->info.protocol & SNDRV_UMP_EP_INFO_PROTO_MIDI1) { 320 data[0] = ump_compose(UMP_MSG_TYPE_MIDI1_CHANNEL_VOICE, 321 group, 0, buf[0]); 322 data[0] |= buf[1] << 8; 323 if (bytes > 2) 324 data[0] |= buf[2]; 325 return 4; 326 } 327 328 status = *buf >> 4; 329 channel = *buf & 0x0f; 330 cc = &cvt->bank[channel]; 331 332 /* special handling: treat note-on with 0 velocity as note-off */ 333 if (status == UMP_MSG_STATUS_NOTE_ON && !buf[2]) 334 status = UMP_MSG_STATUS_NOTE_OFF; This if statment 335 336 /* initialize the packet */ 337 data[0] = ump_compose(UMP_MSG_TYPE_MIDI2_CHANNEL_VOICE, 338 group, status, channel); 339 data[1] = 0; 340 341 switch (status) { 342 case UMP_MSG_STATUS_NOTE_ON: --> 343 if (!buf[2]) 344 status = UMP_MSG_STATUS_NOTE_OFF; and this one are the same. One could be deleted. 345 fallthrough; 346 case UMP_MSG_STATUS_NOTE_OFF: 347 midi2->note.note = buf[1]; 348 midi2->note.velocity = upscale_7_to_16bit(buf[2]); 349 break; 350 case UMP_MSG_STATUS_POLY_PRESSURE: 351 midi2->paf.note = buf[1]; 352 midi2->paf.data = upscale_7_to_32bit(buf[2]); 353 break; 354 case UMP_MSG_STATUS_CC: 355 switch (buf[1]) { 356 case UMP_CC_RPN_MSB: 357 cc->rpn_set = 1; 358 cc->cc_rpn_msb = buf[2]; 359 return 0; // skip 360 case UMP_CC_RPN_LSB: 361 cc->rpn_set = 1; 362 cc->cc_rpn_lsb = buf[2]; 363 return 0; // skip 364 case UMP_CC_NRPN_MSB: 365 cc->nrpn_set = 1; 366 cc->cc_nrpn_msb = buf[2]; 367 return 0; // skip 368 case UMP_CC_NRPN_LSB: 369 cc->nrpn_set = 1; 370 cc->cc_nrpn_lsb = buf[2]; 371 return 0; // skip 372 case UMP_CC_DATA: 373 cc->cc_data_msb = buf[2]; 374 return 0; // skip 375 case UMP_CC_BANK_SELECT: 376 cc->bank_set = 1; 377 cc->cc_bank_msb = buf[2]; 378 return 0; // skip 379 case UMP_CC_BANK_SELECT_LSB: 380 cc->bank_set = 1; 381 cc->cc_bank_lsb = buf[2]; 382 return 0; // skip 383 case UMP_CC_DATA_LSB: 384 cc->cc_data_lsb = buf[2]; 385 if (cc->rpn_set || cc->nrpn_set) 386 fill_rpn(cc, midi2); 387 else 388 return 0; // skip 389 break; 390 default: 391 midi2->cc.index = buf[1]; 392 midi2->cc.data = upscale_7_to_32bit(buf[2]); 393 break; 394 } 395 break; 396 case UMP_MSG_STATUS_PROGRAM: 397 midi2->pg.program = buf[1]; 398 if (cc->bank_set) { 399 midi2->pg.bank_valid = 1; 400 midi2->pg.bank_msb = cc->cc_bank_msb; 401 midi2->pg.bank_lsb = cc->cc_bank_lsb; 402 cc->bank_set = 0; 403 cc->cc_bank_msb = cc->cc_bank_lsb = 0; 404 } 405 break; 406 case UMP_MSG_STATUS_CHANNEL_PRESSURE: 407 midi2->caf.data = upscale_7_to_32bit(buf[1]); 408 break; 409 case UMP_MSG_STATUS_PITCH_BEND: 410 midi2->pb.data = upscale_14_to_32bit(buf[1] | (buf[2] << 7)); 411 break; 412 default: 413 return 0; 414 } 415 416 return 8; 417 } regards, dan carpenter

1 0

[PATCH v2 0/7] ASoC: mt8188: add new board support
by Trevor Wu 25 May '23

25 May '23

In the series, we extend the capability of mt8188-mt6359 driver. The following changes are included. 1. Divide ADDA BE dai into two dais for SOF. 2. Register hdmi/dp jack pins. 3. dai_fmt can be configured from device tree. 4. Add some I2S codecs support. In addition, new compatible string "mediatek,mt8188-nau8825" is included for a new board support. Changes since v1: - add "Headphone Jack" for Nau8825 - separate binding patch 2 from patch 6, and rename the subject - clean up debugfs for freed widget Trevor Wu (7): ASoC: mediatek: mt8188: separate ADDA playback dai from capture dai ASoC: dt-bindings: mediatek,mt8188-mt6359: remove ADDA_BE from link-name ASoC: mediatek: mt8188-mt6359: register hdmi/dp jack pins ASoC: mediatek: common: soundcard driver add dai_fmt support ASoC: soc-dapm.c: clean up debugfs for freed widget ASoC: mediatek: mt8188-mt6359: support new board with nau88255 ASoC: dt-bindings: mediatek,mt8188-mt6359: add NAU8825 support .../sound/mediatek,mt8188-mt6359.yaml | 27 +- sound/soc/mediatek/Kconfig | 4 + .../mediatek/common/mtk-soundcard-driver.c | 49 ++- sound/soc/mediatek/mt8188/mt8188-afe-common.h | 3 +- sound/soc/mediatek/mt8188/mt8188-dai-adda.c | 73 ++-- sound/soc/mediatek/mt8188/mt8188-mt6359.c | 389 +++++++++++++++++- sound/soc/soc-dapm.c | 16 + 7 files changed, 507 insertions(+), 54 deletions(-) -- 2.18.0

3 22

Fwd: XPS 17 - Intel® Smart Sound Technology for MIPI SoundWire® Audio (device not recognized)
by Bagas Sanjaya 25 May '23

25 May '23

Hi, I notice a bug report on Bugzilla [1]. As many developers don't keep an eye on it, I decide to forward it by email. Quoting from it: > Ubuntu (Lobster) 23.04 not recognizing Intel® Smart Sound Technology for MIPI SoundWire® Audio. > > gnome-control-center showing dummy-output. > > I tried with the latest mainline kernel 6.4.00-RC2, still sound not working. See bugzilla for the full thread. The reporter said that he had problem only with integrated sound card on his laptop, and he also attached dmesg and working audio capture from Windows. Thanks. [1]: https://bugzilla.kernel.org/show_bug.cgi?id=217461 -- An old man doll... just what I always wanted! - Clara

1 0

[PATCH 00/20] ASoC: replace dpcm_playback/capture to playback/capture_only
by Kuninori Morimoto 25 May '23

25 May '23

Hi Mark Current ASoC can use DPCM, and we need to set dpcm_playback/capture to use it. OTOH, we are using playback/capture_only flag on Normal/Codec2Codec case. I think it is very duplicated, we can share same rules for all cases. This patch-set cleanup these. 1 - 7 : cleanup functions. 8 : main patch 9 - 19 : replace flags on each drivers 20 : remove old flags Kuninori Morimoto (20): 1 ASoC: soc-pcm.c: indicate error if stream has no playback no capture 2 ASoC: soc-pcm.c: use dai_link on soc_get_playback_capture() 3 ASoC: soc-pcm.c: cleanup soc_get_playback_capture() error 4 ASoC: soc-pcm.c: use temporary variable at soc_get_playback_capture() 5 ASoC: soc-pcm.c: tidyup playback/capture_only at soc_get_playback_capture() 6 ASoC: soc-pcm.c: cleanup normal connection loop at soc_get_playback_capture() part1 7 ASoC: soc-pcm.c: cleanup normal connection loop at soc_get_playback_capture() part2 8 ASoC: soc-pcm.c: cleanup soc_get_playback_capture() 9 ASoC: amd: replace dpcm_playback/capture to playback/capture_only 10 ASoC: fsl: replace dpcm_playback/capture to playback/capture_only 11 ASoC: sof: replace dpcm_playback/capture to playback/capture_only 12 ASoC: meson: replace dpcm_playback/capture to playback/capture_only 13 ASoC: Intel: replace dpcm_playback/capture to playback/capture_only 14 ASoC: samsung: replace dpcm_playback/capture to playback/capture_only 15 ASoC: mediatek: replace dpcm_playback/capture to playback/capture_only 16 ASoC: soc-dai.c: replace dpcm_playback/capture to playback/capture_only 17 ASoC: soc-core.c: replace dpcm_playback/capture to playback/capture_only 18 ASoC: soc-topology.c: replace dpcm_playback/capture to playback/capture_only 19 ASoC: soc-compress.c: replace dpcm_playback/capture to playback/capture_only 20 ASoC: soc-pcm.c: remove dpcm_playback/capture include/sound/soc.h | 4 - sound/soc/amd/acp-da7219-max98357a.c | 20 ++-- sound/soc/amd/acp-es8336.c | 2 - sound/soc/amd/acp/acp-mach-common.c | 20 +--- sound/soc/amd/acp3x-rt5682-max9836.c | 6 +- sound/soc/amd/vangogh/acp5x-mach.c | 3 - sound/soc/fsl/fsl-asoc-card.c | 16 +-- sound/soc/fsl/imx-audmix.c | 6 +- sound/soc/fsl/imx-card.c | 4 +- sound/soc/intel/avs/boards/da7219.c | 2 - sound/soc/intel/avs/boards/dmic.c | 4 +- sound/soc/intel/avs/boards/hdaudio.c | 4 - sound/soc/intel/avs/boards/i2s_test.c | 2 - sound/soc/intel/avs/boards/max98357a.c | 2 +- sound/soc/intel/avs/boards/max98373.c | 2 - sound/soc/intel/avs/boards/max98927.c | 2 - sound/soc/intel/avs/boards/nau8825.c | 2 - sound/soc/intel/avs/boards/rt274.c | 2 - sound/soc/intel/avs/boards/rt286.c | 2 - sound/soc/intel/avs/boards/rt298.c | 2 - sound/soc/intel/avs/boards/rt5682.c | 2 - sound/soc/intel/avs/boards/ssm4567.c | 2 - sound/soc/intel/boards/bdw-rt5650.c | 4 - sound/soc/intel/boards/bdw-rt5677.c | 4 - sound/soc/intel/boards/bdw_rt286.c | 10 +- sound/soc/intel/boards/bxt_da7219_max98357a.c | 32 +++--- sound/soc/intel/boards/bxt_rt298.c | 26 ++--- sound/soc/intel/boards/bytcht_cx2072x.c | 6 +- sound/soc/intel/boards/bytcht_da7213.c | 6 +- sound/soc/intel/boards/bytcht_es8316.c | 6 +- sound/soc/intel/boards/bytcht_nocodec.c | 6 +- sound/soc/intel/boards/bytcr_rt5640.c | 6 +- sound/soc/intel/boards/bytcr_rt5651.c | 6 +- sound/soc/intel/boards/bytcr_wm5102.c | 6 +- sound/soc/intel/boards/cht_bsw_max98090_ti.c | 6 +- sound/soc/intel/boards/cht_bsw_nau8824.c | 6 +- sound/soc/intel/boards/cht_bsw_rt5645.c | 6 +- sound/soc/intel/boards/cht_bsw_rt5672.c | 6 +- sound/soc/intel/boards/cml_rt1011_rt5682.c | 14 +-- sound/soc/intel/boards/ehl_rt5660.c | 14 +-- sound/soc/intel/boards/glk_rt5682_max98357a.c | 30 +++-- sound/soc/intel/boards/hsw_rt5640.c | 10 +- sound/soc/intel/boards/kbl_da7219_max98357a.c | 26 ++--- sound/soc/intel/boards/kbl_da7219_max98927.c | 54 ++++----- sound/soc/intel/boards/kbl_rt5660.c | 18 ++- sound/soc/intel/boards/kbl_rt5663_max98927.c | 44 ++++--- .../intel/boards/kbl_rt5663_rt5514_max98927.c | 22 ++-- sound/soc/intel/boards/skl_hda_dsp_common.c | 14 +-- .../soc/intel/boards/skl_nau88l25_max98357a.c | 26 ++--- sound/soc/intel/boards/skl_nau88l25_ssm4567.c | 26 ++--- sound/soc/intel/boards/skl_rt286.c | 26 ++--- sound/soc/intel/boards/sof_cs42l42.c | 12 +- sound/soc/intel/boards/sof_da7219_max98373.c | 16 +-- sound/soc/intel/boards/sof_es8336.c | 8 +- sound/soc/intel/boards/sof_nau8825.c | 12 +- sound/soc/intel/boards/sof_pcm512x.c | 8 +- sound/soc/intel/boards/sof_rt5682.c | 12 +- sound/soc/intel/boards/sof_sdw.c | 4 +- sound/soc/intel/boards/sof_ssp_amp.c | 11 +- sound/soc/intel/boards/sof_wm8804.c | 2 - sound/soc/mediatek/mt2701/mt2701-cs42448.c | 20 +--- sound/soc/mediatek/mt2701/mt2701-wm8960.c | 6 +- sound/soc/mediatek/mt6797/mt6797-mt6351.c | 24 ++-- sound/soc/mediatek/mt8173/mt8173-max98090.c | 6 +- .../mediatek/mt8173/mt8173-rt5650-rt5514.c | 6 +- .../mediatek/mt8173/mt8173-rt5650-rt5676.c | 10 +- sound/soc/mediatek/mt8173/mt8173-rt5650.c | 10 +- .../mediatek/mt8183/mt8183-da7219-max98357.c | 34 +++--- .../mt8183/mt8183-mt6358-ts3a227-max98357.c | 34 +++--- .../mt8186/mt8186-mt6366-da7219-max98357.c | 86 ++++++-------- .../mt8186/mt8186-mt6366-rt1019-rt5682s.c | 86 ++++++-------- sound/soc/mediatek/mt8188/mt8188-mt6359.c | 48 ++++---- .../mt8192/mt8192-mt6359-rt1015-rt5682.c | 78 ++++++------- sound/soc/mediatek/mt8195/mt8195-mt6359.c | 60 +++++----- sound/soc/meson/axg-card.c | 8 +- sound/soc/meson/meson-card-utils.c | 4 +- sound/soc/samsung/odroid.c | 10 +- sound/soc/soc-compress.c | 11 +- sound/soc/soc-core.c | 20 +--- sound/soc/soc-dai.c | 4 +- sound/soc/soc-pcm.c | 107 +++++++----------- sound/soc/soc-topology-test.c | 2 - sound/soc/soc-topology.c | 4 +- sound/soc/sof/nocodec.c | 4 - 84 files changed, 502 insertions(+), 842 deletions(-) -- 2.25.1

2 43

How fix microphone for ALC4080
by GitHub issues - opened 24 May '23

24 May '23

alsa-project/alsa-ucm-conf issue #317 was opened from h4kuna: Hello, i'am running on Ubuntu 22.04 where is `lsa-ucm-conf 1.2.6.3-1ubuntu1.5`. The sound card does't work. I have motherboard [MAG X570S TOMAHAWK MAX WIFI](https://www.msi.com/Motherboard/MAG-X570S-TOMAHAWK-MAX-WIFI/Specifica… where is `Realtek® ALC4080`. I saw, it added later. I try to use live CD ubuntu 23.04, where sound works, but microphone still doesn't work. ### Ubuntu 22.04 Output from [alsa-info](http://alsa-project.org/db/?f=d2e40705662fc6a0f9e64af8e64bfd0ded… ``` lsusb | grep 'USB Audio' Bus 003 Device 002: ID 0db0:a073 Micro Star International USB Audio ``` What can i to do for fix microphone? What do you need information? Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/317 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

topology: pre-processor: Add support for object arrays
by GitHub pull_request - edited 24 May '23

24 May '23

alsa-project/alsa-utils pull request #216 was edited from ranj063: Introduce a new keyword, "ObjectArray" to instantiate multiple objects of the same class with different attirbutes. For example ``` ObjectArray.Base.input_audio_format [ { in_rate [ 8000 16000 48000 ] in_bit_depth [ 32 ] in_valid_bit_depth [ 24 32 ] } ] ``` This would be expanded into 6 objects with the rate, bit_depth and valid_bit_depth combinations of the arrays of values above. ``` Object.Base.input_audio_format [ { in_rate 8000 in_bit_depth 32 in_valid_bit_depth 32 } { in_rate 16000 in_bit_depth 32 in_valid_bit_depth 32 } { in_rate 48000 in_bit_depth 32 in_valid_bit_depth 32 } { in_rate 8000 in_bit_depth 32 in_valid_bit_depth 24 } { in_rate 16000 in_bit_depth 32 in_valid_bit_depth 24 } { in_rate 48000 in_bit_depth 32 in_valid_bit_depth 24 } ] ``` The Objects definition is an array so that multiple combinations can be specified so that we deal with only valid combinations. For example, 16-bit bit_depth is only valid with 16-bit valid_bit_depth. So if we also want to add those combinations with the multiple rates, the definition would look like: ``` ObjectArray.Base.input_audio_format [ { in_rate [ 8000 16000 48000 ] in_bit_depth [ 32 ] in_valid_bit_depth [ 24 32 ] } { in_rate [ 8000 16000 48000 ] in_bit_depth [ 16 ] in_valid_bit_depth [ 16 ] } ] ``` Request URL : https://github.com/alsa-project/alsa-utils/pull/216 Patch URL : https://github.com/alsa-project/alsa-utils/pull/216.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

unsuscribe
by Juan DCG 24 May '23

24 May '23

1 0

[PATCH] ALSA: hda/realtek: Enable headset onLenovo M70/M90
by Bin Li 24 May '23

24 May '23

Lenovo M70/M90 Gen4 are equipped with ALC897, and they need ALC897_FIXUP_HEADSET_MIC_PIN quirk to make its headset mic work. The previous quirk for M70/M90 is for Gen3. Signed-off-by: Bin Li <bin.li(a)canonical.com> --- sound/pci/hda/patch_realtek.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index a7e4765eff80..7b5f194513c7 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -11719,6 +11719,8 @@ static const struct snd_pci_quirk alc662_fixup_tbl[] = { SND_PCI_QUIRK(0x17aa, 0x32cb, "Lenovo ThinkCentre M70", ALC897_FIXUP_HEADSET_MIC_PIN), SND_PCI_QUIRK(0x17aa, 0x32cf, "Lenovo ThinkCentre M950", ALC897_FIXUP_HEADSET_MIC_PIN), SND_PCI_QUIRK(0x17aa, 0x32f7, "Lenovo ThinkCentre M90", ALC897_FIXUP_HEADSET_MIC_PIN), + SND_PCI_QUIRK(0x17aa, 0x3321, "Lenovo ThinkCentre M70 Gen4", ALC897_FIXUP_HEADSET_MIC_PIN), + SND_PCI_QUIRK(0x17aa, 0x331b, "Lenovo ThinkCentre M90 Gen4", ALC897_FIXUP_HEADSET_MIC_PIN), SND_PCI_QUIRK(0x17aa, 0x3742, "Lenovo TianYi510Pro-14IOB", ALC897_FIXUP_HEADSET_MIC_PIN2), SND_PCI_QUIRK(0x17aa, 0x38af, "Lenovo Ideapad Y550P", ALC662_FIXUP_IDEAPAD), SND_PCI_QUIRK(0x17aa, 0x3a0d, "Lenovo Ideapad Y550", ALC662_FIXUP_IDEAPAD), -- 2.34.1

2 1

[PATCH] regmap: sdw: check for invalid multi-register writes config
by Srinivas Kandagatla 24 May '23

24 May '23

SoundWire code as it is only supports Bulk register writes and it does not support multi-register writes. Any drivers that set can_multi_write and use regmap_multi_reg_write() will easily endup with programming the hardware incorrectly without any errors. So, add this check in bus code to be able to validate the drivers config. Fixes: 522272047dc6 ("regmap: sdw: Remove 8-bit value size restriction") Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> --- drivers/base/regmap/regmap-sdw.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/base/regmap/regmap-sdw.c b/drivers/base/regmap/regmap-sdw.c index 09899ae99fc1..159c0b740b00 100644 --- a/drivers/base/regmap/regmap-sdw.c +++ b/drivers/base/regmap/regmap-sdw.c @@ -59,6 +59,10 @@ static int regmap_sdw_config_check(const struct regmap_config *config) if (config->pad_bits != 0) return -ENOTSUPP; + /* Only bulk writes are supported not multi-register writes */ + if (config->can_multi_write) + return -ENOTSUPP; + return 0; } -- 2.21.0

2 4

[PATCH] regmap: maple: Drop the RCU read lock while syncing registers
by Mark Brown 24 May '23

24 May '23

Unfortunately the maple tree requires us to explicitly lock it so we need to take the RCU read lock while iterating. When syncing this means that we end up trying to write out register values while holding the RCU read lock which triggers lockdep issues since that is an atomic context but most buses can't be used in atomic context. Pause the iteration and drop the lock for each register we check to avoid this. Reported-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Signed-off-by: Mark Brown <broonie(a)kernel.org> --- drivers/base/regmap/regcache-maple.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/base/regmap/regcache-maple.c b/drivers/base/regmap/regcache-maple.c index 9b1b559107ef..c2e3a0f6c218 100644 --- a/drivers/base/regmap/regcache-maple.c +++ b/drivers/base/regmap/regcache-maple.c @@ -203,15 +203,18 @@ static int regcache_maple_sync(struct regmap *map, unsigned int min, mas_for_each(&mas, entry, max) { for (r = max(mas.index, lmin); r <= min(mas.last, lmax); r++) { + mas_pause(&mas); + rcu_read_unlock(); ret = regcache_sync_val(map, r, entry[r - mas.index]); if (ret != 0) goto out; + rcu_read_lock(); } } -out: rcu_read_unlock(); +out: map->cache_bypass = false; return ret; --- base-commit: 44c026a73be8038f03dbdeef028b642880cf1511 change-id: 20230523-regcache-maple-sync-lock-57ea356dc60b Best regards, -- Mark Brown <broonie(a)kernel.org>

2 2