February 2023 - Alsa-devel - mailman.alsa-project.org

OpenBSD (and maybe other *BSDs) support (2)
by GitHub pull_request - opened 25 Feb '23

25 Feb '23

alsa-project/alsa-utils pull request #193 was opened from jg1uaa: #186 addendum. forget to fix alsactl/lock.c, this is the fix. Request URL : https://github.com/alsa-project/alsa-utils/pull/193 Patch URL : https://github.com/alsa-project/alsa-utils/pull/193.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

hda-verb improvements for Asus Zenbook Pro Duo UX582LR
by Marcel Brouillet 25 Feb '23

25 Feb '23

Hello, I have a Asus Zenbook Pro Duo UX582LR that does not have sound out-of-the box. But with either this : hda-verb /dev/snd/hwC0D0 0x20 0x500 0xf hda-verb /dev/snd/hwC0D0 0x20 0x400 0x7774 hda-verb /dev/snd/hwC0D0 0x20 0x500 0x45 hda-verb /dev/snd/hwC0D0 0x20 0x400 0x5289 Or this : hda-verb /dev/snd/hwC0D0 0x20 0x500 0x1b hda-verb /dev/snd/hwC0D0 0x20 0x477 0x4a4b hda-verb /dev/snd/hwC0D0 0x20 0x500 0xf hda-verb /dev/snd/hwC0D0 0x20 0x477 0x74 Then 1. I do get output from the laptop speakers ✅ 2. I do get output through a headset when pluged in (and no sound through speakers) ✅ 3. I do get input from laptop mics, *but far too high gain. *Setting the mic level to 35% in Pulse Audio is roughly good 4. Input *remains from laptop mics even when I plug in headsets* (TRRS jack) I've been OK with this for 18 months, but decided to chip in the time to solve 3 and 4 and make it available to the community. I looked at https://github.com/alsa-project/alsa-tools/tree/master/hda-verb and understand the hda-verb syntax. But *where do I find the verb arguments (strings or the above cryptic 0x477 or 0x400) ?* Do I need to read this 220 pages document ? https://www.intel.com/content/www/us/en/standards/high-definition-audio-spe… *If anyone is willing to direct me to the few verbs to try, and please tell me if there is any risk of killing my sound interface with wrong parameters, a big thank you to you.* Regards, Marcel. Hardware : Asus Zenbook Pro Duo UX582LR Software : Ubuntu Studio 22.04.2 LTS jammy. Fresh installation 10 days ago, fully updated upgraded. alsa-base/jammy,jammy,now 1.0.25+dfsg-0ubuntu7 all [installed,automatic] alsa-tools/jammy,now 1.2.5-2 amd64 [installed,automatic] alsa-tools-gui/jammy,now 1.2.5-2 amd64 [installed,automatic] alsa-topology-conf/jammy,jammy,now 1.2.5.1-2 all [installed,automatic] alsa-ucm-conf/jammy-updates,jammy-updates,now 1.2.6.3-1ubuntu1.4 all [installed,automatic] alsa-utils/jammy,now 1.2.6-1ubuntu1 amd64 [installed,automatic]

1 0

[PATCH 1/3] ASoC: apple: mca: Fix final status read on SERDES reset
by Martin Povišer 24 Feb '23

24 Feb '23

From within the early trigger we are doing a reset of the SERDES unit, but the final status read is on a bad address. Add the missing SERDES unit offset in calculation of the address. Fixes: 3df5d0d97289 ("ASoC: apple: mca: Start new platform driver") Signed-off-by: Martin Povišer <povik+lin(a)cutebit.org> --- sound/soc/apple/mca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/apple/mca.c b/sound/soc/apple/mca.c index 24381c42eb54..9cceeb259952 100644 --- a/sound/soc/apple/mca.c +++ b/sound/soc/apple/mca.c @@ -210,7 +210,7 @@ static void mca_fe_early_trigger(struct snd_pcm_substream *substream, int cmd, SERDES_CONF_SOME_RST); readl_relaxed(cl->base + serdes_conf); mca_modify(cl, serdes_conf, SERDES_STATUS_RST, 0); - WARN_ON(readl_relaxed(cl->base + REG_SERDES_STATUS) & + WARN_ON(readl_relaxed(cl->base + serdes_unit + REG_SERDES_STATUS) & SERDES_STATUS_RST); break; default: -- 2.33.0

2 3

[PATCH] ASoC: adau7118: don't disable regulators on device unbind
by Nuno Sá 24 Feb '23

24 Feb '23

The regulators are supposed to be controlled through the set_bias_level() component callback. Moreover, the regulators are not enabled during probe and so, this would lead to a regulator unbalanced use count. Fixes: ca514c0f12b02 ("ASOC: Add ADAU7118 8 Channel PDM-to-I2S/TDM Converter driver") Signed-off-by: Nuno Sá <nuno.sa(a)analog.com> --- Note this was only checked by code inspection but unless I'm missing something, it looks clear this could happen by just insmod + rmmod the module. sound/soc/codecs/adau7118.c | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/sound/soc/codecs/adau7118.c b/sound/soc/codecs/adau7118.c index bbb097249887..a663d37e5776 100644 --- a/sound/soc/codecs/adau7118.c +++ b/sound/soc/codecs/adau7118.c @@ -444,22 +444,6 @@ static const struct snd_soc_component_driver adau7118_component_driver = { .endianness = 1, }; -static void adau7118_regulator_disable(void *data) -{ - struct adau7118_data *st = data; - int ret; - /* - * If we fail to disable DVDD, don't bother in trying IOVDD. We - * actually don't want to be left in the situation where DVDD - * is enabled and IOVDD is disabled. - */ - ret = regulator_disable(st->dvdd); - if (ret) - return; - - regulator_disable(st->iovdd); -} - static int adau7118_regulator_setup(struct adau7118_data *st) { st->iovdd = devm_regulator_get(st->dev, "iovdd"); @@ -481,8 +465,7 @@ static int adau7118_regulator_setup(struct adau7118_data *st) regcache_cache_only(st->map, true); } - return devm_add_action_or_reset(st->dev, adau7118_regulator_disable, - st); + return 0; } static int adau7118_parset_dt(const struct adau7118_data *st) -- 2.39.2

2 1

[syzbot] [alsa?] kernel BUG in __vunmap
by syzbot 23 Feb '23

23 Feb '23

Hello, syzbot found the following issue on: HEAD commit: a5541c0811a0 Merge branch 'for-next/core' into for-kernelci git tree: git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci console output: https://syzkaller.appspot.com/x/log.txt?x=12b4018b880000 kernel config: https://syzkaller.appspot.com/x/.config?x=cbd4e584773e9397 dashboard link: https://syzkaller.appspot.com/bug?extid=656c0cde55a9d107a76f compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2 userspace arch: arm64 Unfortunately, I don't have any reproducer for this issue yet. Downloadable assets: disk image: https://storage.googleapis.com/syzbot-assets/4b7702208fb9/disk-a5541c08.raw… vmlinux: https://storage.googleapis.com/syzbot-assets/9ec0153ec051/vmlinux-a5541c08.… kernel image: https://storage.googleapis.com/syzbot-assets/6f8725ad290a/Image-a5541c08.gz… IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+656c0cde55a9d107a76f(a)syzkaller.appspotmail.com ------------[ cut here ]------------ kernel BUG at mm/vmalloc.c:2707! Internal error: Oops - BUG: 00000000f2000800 [#1] PREEMPT SMP Modules linked in: CPU: 1 PID: 9210 Comm: syz-executor.0 Not tainted 6.1.0-rc8-syzkaller-33330-ga5541c0811a0 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022 pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) pc : __vunmap+0x488/0x4cc mm/vmalloc.c:2707 lr : __vunmap+0x488/0x4cc mm/vmalloc.c:2707 sp : ffff800013d73ba0 x29: ffff800013d73bb0 x28: 00000000000c0002 x27: 0000000000002000 x26: ffff0000c5a44d68 x25: ffff0000c6a14080 x24: ffff00012b5ed000 x23: 0000000000000001 x22: 0000000000000200 x21: 0000000000000000 x20: ffff80000cbdd3b4 x19: ffff0001268cfa00 x18: 0000000000000000 x17: 0000000000000000 x16: ffff80000dbe6158 x15: ffff000114e01a40 x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000 x11: ff808000084b647c x10: 0000000000000000 x9 : ffff8000084b647c x8 : ffff000114e01a40 x7 : ffff8000084bf4d4 x6 : 0000000000000000 x5 : 0000000000000080 x4 : 0000000000000000 x3 : 0000000000000000 x2 : 0000000000000000 x1 : ffff80000cbaae40 x0 : 0000000000000000 Call trace: __vunmap+0x488/0x4cc mm/vmalloc.c:2707 __vfree mm/vmalloc.c:2761 [inline] vfree+0xb0/0xfc mm/vmalloc.c:2792 snd_dma_vmalloc_free+0x20/0x30 sound/core/memalloc.c:356 snd_dma_free_pages+0x84/0xc0 sound/core/memalloc.c:127 do_free_pages sound/core/pcm_memory.c:65 [inline] snd_pcm_lib_free_pages+0xa0/0x12c sound/core/pcm_memory.c:471 do_hw_free sound/core/pcm_native.c:876 [inline] snd_pcm_release_substream+0x15c/0x1dc sound/core/pcm_native.c:2705 snd_pcm_oss_release_file sound/core/oss/pcm_oss.c:2413 [inline] snd_pcm_oss_release+0x98/0x130 sound/core/oss/pcm_oss.c:2592 __fput+0x198/0x3e4 fs/file_table.c:320 ____fput+0x20/0x30 fs/file_table.c:348 task_work_run+0x100/0x148 kernel/task_work.c:179 resume_user_mode_work include/linux/resume_user_mode.h:49 [inline] do_notify_resume+0x174/0x1f0 arch/arm64/kernel/signal.c:1132 prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:137 [inline] exit_to_user_mode arch/arm64/kernel/entry-common.c:142 [inline] el0_svc+0x9c/0x150 arch/arm64/kernel/entry-common.c:638 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:584 Code: 17ffff1f 97f7c16d 17ffff18 97f7c16b (d4210000) ---[ end trace 0000000000000000 ]--- --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller(a)googlegroups.com. syzbot will keep track of this issue. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

1 0

Re: Firewire Audio Interface
by Takashi Sakamoto 23 Feb '23

23 Feb '23

Hi, (C.C.ed to alsa-devel) On Wed, Feb 22, 2023 at 11:51:23AM -0500, mj@mj wrote: > Hey man thanks so much for the reply! > > Why TC put the phantom switch in the software instead of on the > hardware unit I can’t figure out! > > I think I’m just going to use it a 2-in 2-out interface without > the phantom. > > A friend of mine looked at the circuit board and told me it > would be too difficult to put a switch for the phantom power in it. > > Thanks again for the reply! If it is Desktop Konnekt 6, node offset 0x'ffff'e0a0'103c has the 32 bit value to express the state of phantom powering. If it is 0, disabled, else enabled. Quadlet write asynchronous transaction can change the state, but I have never used MacOs to operate any node in IEEE 1394 bus. I know some developer and user for the craft driver; e.g. * Re: [alsa-devel] Tascam Coding Inquiry * https://lore.kernel.org/alsa-devel/20200108095430.GA16741@workstation/ I think it your help to contact to them. Especially Paul Neyrinck[1] seems to complete his work for the craft driver of Digidesign Digi 002/003 family in MacOS. They are different hardware from yours, while he will help you to execute the simple read/write transaction to a certain offset of it. [1] https://neyrinck.com/ Regards Takashi Sakamoto

1 0

[PATCH v6 0/4] Add CS35L41 shared boost feature
by Lucas Tanure 22 Feb '23

22 Feb '23

Valve's Steam Deck uses CS35L41 in shared boost mode, where both speakers share the boost circuit. Add this support in the shared lib, but for now, shared boost is not supported in HDA systems as would require BIOS changes. Based on David Rhodes shared boost patches. Also, fix boost config overwriting in IRQ found in the review and do a small refactor of the code. Changes from V5: - Improved documentation from Cirrrus - All amps use MDSCYN for boost source - Active amp has TX and RX enabled Changes from V4: - Fix Document subject Changes from V3: - Fix wrong code sent - Fix ISO C90 mixed declarations and code Changes from V2: - Drop External boost without VSPK Documentation - Move Shared boost to use values 2 and 3 - Revert back to reg_sequence but reading the value first and only update the necessary bits - Fix bug found by Intel kernel Test Robot Changes from V1: - Fix Documentation patch subject - New patch for External boost without VSPK Documentation - New patch to fix boost IRQ overwriting issue - New patch to refactor IRQ release error code - reinit_completion on pcm_startup - fix DRE switch overwriting - return IRQ_HANDLED in PLL_LOCK case Lucas Tanure (4): ASoC: cs35l41: Only disable internal boost ASoC: cs35l41: Refactor error release code ALSA: cs35l41: Add shared boost feature ASoC: dt-bindings: cirrus,cs35l41: Document CS35l41 shared boost .../bindings/sound/cirrus,cs35l41.yaml | 10 +- include/sound/cs35l41.h | 13 +- sound/pci/hda/cs35l41_hda.c | 6 +- sound/soc/codecs/cs35l41-lib.c | 73 +++++++++- sound/soc/codecs/cs35l41.c | 125 +++++++++--------- sound/soc/codecs/cs35l41.h | 1 + 6 files changed, 157 insertions(+), 71 deletions(-) -- 2.39.2

2 5

[PATCH] ucm2: Rockchip: rk817: Add ALSA UCM support
by Chris Morgan 22 Feb '23

22 Feb '23

From: Chris Morgan <macromorgan(a)hotmail.com> Add ALSA-UCM support for the Rockchip RK817 audio codec. This codec is typically configured either with an internal or external amplifier as reflected by the longname. This configuration has been tested on the Anbernic RG353P (rk817_ext) and the Odroid Go Advance (rk817_int). Signed-off-by: Chris Morgan <macromorgan(a)hotmail.com> --- ucm2/Rockchip/rk817-sound/HiFi.conf | 66 ++++++++++++++++++++++ ucm2/Rockchip/rk817-sound/rk817-sound.conf | 7 +++ ucm2/conf.d/simple-card/rk817_ext.conf | 1 + ucm2/conf.d/simple-card/rk817_int.conf | 1 + 4 files changed, 75 insertions(+) create mode 100644 ucm2/Rockchip/rk817-sound/HiFi.conf create mode 100644 ucm2/Rockchip/rk817-sound/rk817-sound.conf create mode 120000 ucm2/conf.d/simple-card/rk817_ext.conf create mode 120000 ucm2/conf.d/simple-card/rk817_int.conf diff --git a/ucm2/Rockchip/rk817-sound/HiFi.conf b/ucm2/Rockchip/rk817-sound/HiFi.conf new file mode 100644 index 0000000..e285db7 --- /dev/null +++ b/ucm2/Rockchip/rk817-sound/HiFi.conf @@ -0,0 +1,66 @@ +If.1 { + Condition { + Type ControlExists + Control "name='Internal Speakers Switch'" + } + + True { + SectionDevice."Speaker".EnableSequence [ + cset "name='Playback Mux' HP" + cset "name='Internal Speakers Switch' on" + ] + + SectionDevice."Speaker".DisableSequence [ + cset "name='Internal Speakers Switch' off" + ] + } +} + +SectionDevice."Speaker" { + Comment "Internal Speaker" + + EnableSequence [ + cset "name='Playback Mux' SPK" + ] + + Value { + PlaybackMasterElem "Master Playback Volume" + PlaybackPriority 100 + PlaybackPCM "hw:${CardId}" + } + + ConflictingDevice [ + "Headphones" + ] +} + +SectionDevice."Mic" { + Comment "Microphone" + + Value { + CapturePriority 100 + CapturePCM "hw:${CardId}" + CaptureMixerElem "Mic Capture Gain" + CaptureMasterElem "Master Capture Volume" + } +} + +SectionDevice."Headphones" { + Comment "Headphones" + + EnableSequence [ + cset "name='Playback Mux' HP" + ] + + Value { + PlaybackMasterElem "Master Playback Volume" + PlaybackPriority 200 + PlaybackPCM "hw:${CardId}" + JackControl "Headphones Jack" + JackHWMute "Speaker" + } + + ConflictingDevice [ + "Speaker" + ] +} diff --git a/ucm2/Rockchip/rk817-sound/rk817-sound.conf b/ucm2/Rockchip/rk817-sound/rk817-sound.conf new file mode 100644 index 0000000..6e326af --- /dev/null +++ b/ucm2/Rockchip/rk817-sound/rk817-sound.conf @@ -0,0 +1,7 @@ +Syntax 4 + +SectionUseCase."HiFi" { + File "/Rockchip/rk817-sound/HiFi.conf" + Comment "Play HiFi quality music" +} + diff --git a/ucm2/conf.d/simple-card/rk817_ext.conf b/ucm2/conf.d/simple-card/rk817_ext.conf new file mode 120000 index 0000000..6fa8db7 --- /dev/null +++ b/ucm2/conf.d/simple-card/rk817_ext.conf @@ -0,0 +1 @@ +../../Rockchip/rk817-sound/rk817-sound.conf \ No newline at end of file diff --git a/ucm2/conf.d/simple-card/rk817_int.conf b/ucm2/conf.d/simple-card/rk817_int.conf new file mode 120000 index 0000000..6fa8db7 --- /dev/null +++ b/ucm2/conf.d/simple-card/rk817_int.conf @@ -0,0 +1 @@ +../../Rockchip/rk817-sound/rk817-sound.conf \ No newline at end of file -- 2.34.1

2 1

[PATCH 00/10] ASoC: Initial support for Cirrus Logic CS35L56
by Richard Fitzgerald 22 Feb '23

22 Feb '23

The CS35L56 is a high-performance boosted mono audio amplifier. Supported control interfaces are I2C, SPI or SoundWire. Supported audio interfaces are I2S/TDM or SoundWire. The CS35L56 has a self-booting firmware in ROM, with the ability to patch the firmware and/or apply tunings. Patches #1 to #7 add support to cs_dsp and wm_adsp for self-booting firmware and the ability to apply a .bin file without having to apply a .wmfw. Patch #8 adds the ASoC driver. Patches #9 and #10 add support for this to the Intel sof_sdw machine driver. Richard Fitzgerald (3): ASoC: cs35l56: Add driver for Cirrus Logic CS35L56 ASoC: Intel: sof_sdw: Add support for Cirrus Logic CS35L56 ASoC: Intel: soc-acpi: Add CS35L56 Soundwire to TGL Simon Trimmer (7): firmware: cs_dsp: Introduce no_core_startstop for self-booting DSPs ASoC: wm_adsp: Use no_core_startstop to prevent creating preload control firmware: cs_dsp: Support DSPs that don't require firmware download ASoC: wm_adsp: Support DSPs that don't require firmware download ASoC: wm_adsp: Expose the DSP boot work actions as wm_adsp_power_up() ASoC: wm_adsp: Add support for loading bin files without wmfw ASoC: wm_adsp: Simplify the logging of requested firmware files MAINTAINERS | 2 + drivers/firmware/cirrus/cs_dsp.c | 17 +- include/linux/firmware/cirrus/cs_dsp.h | 1 + include/sound/cs35l56.h | 266 +++ sound/soc/codecs/Kconfig | 34 + sound/soc/codecs/Makefile | 10 + sound/soc/codecs/cs35l56-i2c.c | 83 + sound/soc/codecs/cs35l56-sdw.c | 525 ++++++ sound/soc/codecs/cs35l56-shared.c | 387 +++++ sound/soc/codecs/cs35l56-spi.c | 81 + sound/soc/codecs/cs35l56.c | 1451 +++++++++++++++++ sound/soc/codecs/cs35l56.h | 77 + sound/soc/codecs/wm_adsp.c | 63 +- sound/soc/codecs/wm_adsp.h | 3 + sound/soc/intel/boards/Kconfig | 1 + sound/soc/intel/boards/Makefile | 1 + sound/soc/intel/boards/sof_sdw.c | 7 + sound/soc/intel/boards/sof_sdw_common.h | 7 + sound/soc/intel/boards/sof_sdw_cs35l56.c | 115 ++ .../intel/common/soc-acpi-intel-tgl-match.c | 57 + 20 files changed, 3172 insertions(+), 16 deletions(-) create mode 100644 include/sound/cs35l56.h create mode 100644 sound/soc/codecs/cs35l56-i2c.c create mode 100644 sound/soc/codecs/cs35l56-sdw.c create mode 100644 sound/soc/codecs/cs35l56-shared.c create mode 100644 sound/soc/codecs/cs35l56-spi.c create mode 100644 sound/soc/codecs/cs35l56.c create mode 100644 sound/soc/codecs/cs35l56.h create mode 100644 sound/soc/intel/boards/sof_sdw_cs35l56.c -- 2.30.2

2 21

Re: Firewire Audio Interface
by Takashi Sakamoto 22 Feb '23

22 Feb '23

Hi, (C.C.ed to alsa-devel) On Tue, Feb 21, 2023 at 10:21:14AM -0500, mj@mj wrote: > Hello Takashi! > I came across your name when trying to find software to make a TC > Konnekt 6 work in OSX Big Sur. > TC has abandoned the Konnekt series. > I saw this Github entry that I think is from you? > [1]https://github.com/alsa-project/snd-firewire-ctl-services/blob/master/REA… > I wanted to ask…is this your project? and would it allow me to use the > Konnekt with OSX 64-bit? I maintain the repository. Linux kernel has driver stack for audio and music unit in IEEE 1394 bus. I maintain the driver stack as well. For example, you can see backport drivers from mainline Linux kernel: * https://github.com/takaswie/snd-firewire-improve/ The repository you found is supplemental one. It provides user space service program to configure DSP functions such as channel strip effects. Besides, they are available in Linux only. As long as I know, no one work to develop craft drivers in MacOS for your device. P.S. I think you use 'Desktop Konnekt 6' or 'Konnekt 8'. Takashi Sakamoto

1 0