August 2022 - Alsa-devel - mailman.alsa-project.org

ASoC: snd_soc_info_volsw and platfrom_max
by Srinivas Kandagatla 16 Aug '22

16 Aug '22

Hi Mark, After patch 30ac49841386 (ASoC: ops: Don't modify the driver's plaform_max when reading state) all the controls that are using signed TLV range like below /* -84dB min - 40dB max */ SOC_SINGLE_S8_TLV("RX0 Digital Volume", WCD934X_CDC_RX0_RX_VOL_CTL, -84, 40, digital_gain), reports max value as 40 instead of 124. before this patch the controls max value was calculated considering the min value, but with this patch this calculation has changed resulting in low volume on most of the codecs that are using SOC_SINGLE_S8_TLV. snd_soc_put_volsw does the right thing by considering mc->min, but info_volsw does it differently. Below change fixes the issue for me, but I am bit confused with the first line of this function that calculates max value as max = mc->max - mc->min and then limits it to platform_max. diff --git a/sound/soc/soc-ops.c b/sound/soc/soc-ops.c index bd88de056358..49fb34609202 100644 --- a/sound/soc/soc-ops.c +++ b/sound/soc/soc-ops.c @@ -196,7 +196,7 @@ int snd_soc_info_volsw(struct snd_kcontrol *kcontrol, uinfo->count = snd_soc_volsw_is_stereo(mc) ? 2 : 1; uinfo->value.integer.min = 0; - uinfo->value.integer.max = max; + uinfo->value.integer.max = max - mc->min; return 0; } Or should we fix the macro to set platform_max to be max - min. thanks, Srini

2 5

[PATCH 1/2] ASoC: Intel: common: add ACPI matching tables for Raptor Lake
by Kai Vehmanen 16 Aug '22

16 Aug '22

Initial support for RPL w/ RT711 Signed-off-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Tested-by: Gopal Vamshi Krishna <vamshi.krishna.gopal(a)intel.com> --- include/sound/soc-acpi-intel-match.h | 2 + sound/soc/intel/common/Makefile | 2 +- .../intel/common/soc-acpi-intel-rpl-match.c | 51 +++++++++++++++++++ 3 files changed, 54 insertions(+), 1 deletion(-) create mode 100644 sound/soc/intel/common/soc-acpi-intel-rpl-match.c diff --git a/include/sound/soc-acpi-intel-match.h b/include/sound/soc-acpi-intel-match.h index bc7fd46ec2bc..ac750afa7bc6 100644 --- a/include/sound/soc-acpi-intel-match.h +++ b/include/sound/soc-acpi-intel-match.h @@ -30,6 +30,7 @@ extern struct snd_soc_acpi_mach snd_soc_acpi_intel_tgl_machines[]; extern struct snd_soc_acpi_mach snd_soc_acpi_intel_ehl_machines[]; extern struct snd_soc_acpi_mach snd_soc_acpi_intel_jsl_machines[]; extern struct snd_soc_acpi_mach snd_soc_acpi_intel_adl_machines[]; +extern struct snd_soc_acpi_mach snd_soc_acpi_intel_rpl_machines[]; extern struct snd_soc_acpi_mach snd_soc_acpi_intel_mtl_machines[]; extern struct snd_soc_acpi_mach snd_soc_acpi_intel_cnl_sdw_machines[]; @@ -38,6 +39,7 @@ extern struct snd_soc_acpi_mach snd_soc_acpi_intel_cml_sdw_machines[]; extern struct snd_soc_acpi_mach snd_soc_acpi_intel_icl_sdw_machines[]; extern struct snd_soc_acpi_mach snd_soc_acpi_intel_tgl_sdw_machines[]; extern struct snd_soc_acpi_mach snd_soc_acpi_intel_adl_sdw_machines[]; +extern struct snd_soc_acpi_mach snd_soc_acpi_intel_rpl_sdw_machines[]; extern struct snd_soc_acpi_mach snd_soc_acpi_intel_mtl_sdw_machines[]; /* diff --git a/sound/soc/intel/common/Makefile b/sound/soc/intel/common/Makefile index 8ca8f872ec80..41054cf09ec9 100644 --- a/sound/soc/intel/common/Makefile +++ b/sound/soc/intel/common/Makefile @@ -9,7 +9,7 @@ snd-soc-acpi-intel-match-objs := soc-acpi-intel-byt-match.o soc-acpi-intel-cht-m soc-acpi-intel-cml-match.o soc-acpi-intel-icl-match.o \ soc-acpi-intel-tgl-match.o soc-acpi-intel-ehl-match.o \ soc-acpi-intel-jsl-match.o soc-acpi-intel-adl-match.o \ - soc-acpi-intel-mtl-match.o \ + soc-acpi-intel-rpl-match.o soc-acpi-intel-mtl-match.o \ soc-acpi-intel-hda-match.o \ soc-acpi-intel-sdw-mockup-match.o diff --git a/sound/soc/intel/common/soc-acpi-intel-rpl-match.c b/sound/soc/intel/common/soc-acpi-intel-rpl-match.c new file mode 100644 index 000000000000..0b77401e4e6f --- /dev/null +++ b/sound/soc/intel/common/soc-acpi-intel-rpl-match.c @@ -0,0 +1,51 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * soc-apci-intel-rpl-match.c - tables and support for RPL ACPI enumeration. + * + * Copyright (c) 2022 Intel Corporation. + */ + +#include <sound/soc-acpi.h> +#include <sound/soc-acpi-intel-match.h> + +static const struct snd_soc_acpi_endpoint single_endpoint = { + .num = 0, + .aggregated = 0, + .group_position = 0, + .group_id = 0, +}; + +static const struct snd_soc_acpi_adr_device rt711_0_adr[] = { + { + .adr = 0x000020025D071100ull, + .num_endpoints = 1, + .endpoints = &single_endpoint, + .name_prefix = "rt711" + } +}; + +static const struct snd_soc_acpi_link_adr rpl_rvp[] = { + { + .mask = BIT(0), + .num_adr = ARRAY_SIZE(rt711_0_adr), + .adr_d = rt711_0_adr, + }, + {} +}; + +struct snd_soc_acpi_mach snd_soc_acpi_intel_rpl_machines[] = { + {}, +}; +EXPORT_SYMBOL_GPL(snd_soc_acpi_intel_rpl_machines); + +/* this table is used when there is no I2S codec present */ +struct snd_soc_acpi_mach snd_soc_acpi_intel_rpl_sdw_machines[] = { + { + .link_mask = 0x1, /* link0 required */ + .links = rpl_rvp, + .drv_name = "sof_sdw", + .sof_tplg_filename = "sof-rpl-rt711.tplg", + }, + {}, +}; +EXPORT_SYMBOL_GPL(snd_soc_acpi_intel_rpl_sdw_machines); base-commit: efe30e2cb6ff87467389cece8ce604f6601059f9 -- 2.37.2

2 2

[PATCH 0/4] ASoC: Intel: HSW and BDW updates
by Cezary Rojewski 16 Aug '22

16 Aug '22

Sharing this PR as it touches on cross-driver subjects. Four commits yet two subject. Given the small delta, decided to combine within single PR here. I plan to send these subjects separately to the mailing list though. 1. Rename hsw_rt5640 and bdw_rt286 module names 2. Drop SND_SOC_INTEL_ACPI_MATCH dependency for catpt-driver In regard to 1), this is a followup to discussion that has already happened on upstream [1]. Goal is to align kernel module names for hsw and bdw boards with their siblings found in /intel/boards and /intel/avs/boards. In regard to 2), this is yet another followup [2]. Given the fact that /intel/avs/boards are already their on upstream, intention is to align catpt-driver to approach found in the avs-driver. This is also my suggestion for existing sof-boards: most should be listed under /sof/intel/boards/ as they're not common, really - they're are SOF specific. I believe that in time /intel/common and /intel/boards should be either limited or completely removed. As subject touches code used by the sof-driver, additional review has been conducted on thesofproject/linux [3]. [1]: https://lore.kernel.org/alsa-devel/54fcdedc-278c-06b8-5402-28880597d3f4@int… [2]: https://lore.kernel.org/alsa-devel/d9fd60e0-a157-bda7-a918-5548918d1552@int… [3]: https://github.com/thesofproject/linux/pull/3799 Cezary Rojewski (4): ASoC: Intel: hsw_rt5640: Rename module ASoC: Intel: bdw_rt286: Rename module ASoC: Intel: catpt: Drop SND_SOC_ACPI_INTEL_MATCH dependency ASoC: Intel: Drop legacy HSW/BDW board-match information include/sound/soc-acpi-intel-match.h | 1 - sound/soc/intel/Kconfig | 2 +- sound/soc/intel/boards/Makefile | 8 ++--- sound/soc/intel/catpt/device.c | 33 +++++++++++++++++-- .../common/soc-acpi-intel-hsw-bdw-match.c | 15 --------- 5 files changed, 35 insertions(+), 24 deletions(-) -- 2.25.1

2 6

Rockchip I2S commit possibly ignored
by Geraldo Nascimento 16 Aug '22

16 Aug '22

Hi Mark, I was looking at Rockchip I2S commits and it seems "ASoC: rockchip: i2s: Reset the controller if soft reset failed" was supposed to have been merged to your sound.git but never was. I don't know if this was intentional or a real miss but in any case I'm letting you know. According to 515b436be291ff197c52198282bbb19e79c9d197 'Merge series "Patches to update for rockchip i2s" from Sugar Zhang <sugar.zhang(a)rock-chips.com>:' it should have been merged to your tree. In rockchip-i2s.yaml there's even documentation that references the missing commit. However in the alsa-devel archives, https://mailman.alsa-project.org/pipermail/alsa-devel/2021-August/189050.ht… I see there was no commit info for the unmerged patch. Perhaps this caused it to be black-holed? Thanks, Geraldo Nascimento

2 4

Re: [PATCH v6 1/2] ASoC: dt-bindings: Add Everest ES8326 audio CODEC
by Mark Brown 16 Aug '22

16 Aug '22

On Tue, 16 Aug 2022 10:44:55 +0800, Zhu Ning wrote: > Add device tree binding documentation for Everest ES8326 > > ---- > v5 tested by dtschema > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/2] ASoC: dt-bindings: Add Everest ES8326 audio CODEC commit: 8c6789f4e2d4ee7d6c8c60daa88ea7a4c4cf6779 [2/2] ASoC: codecs: add support for ES8326 commit: 5c439937775d77a334696a98fb2a25dee72ffa2d All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark

1 0

[RESEND v4 0/2] Add support for linked list to store acp_stream and tdm support.
by Venkata Prasad Potturu 16 Aug '22

16 Aug '22

This patch is to add support for linked list to store acp_stream instead static array and add tdm support for acp I2S stream. Ajit Kumar Pandey (1): ASoC: amd: acp: Initialize list to store acp_stream during pcm_open Venkata Prasad Potturu (1): ASoC: amd: acp: Add TDM support for acp i2s stream Changes since v3: -- Modify to spin_lock() in irq handler and spin_lock_irq() in dma open and close functions instead of spin_lock_irqsave(). -- Add tdm support patch to this series. Changes since v2: -- Add locking mechanism in irq handler, linked list updatation and deletion. Changes since v1: -- Fix compile error and remove unused variable. sound/soc/amd/acp/acp-i2s.c | 80 +++++++++++++++++++++++++++++++- sound/soc/amd/acp/acp-platform.c | 40 ++++++++-------- sound/soc/amd/acp/amd.h | 16 ++++++- 3 files changed, 113 insertions(+), 23 deletions(-) -- 2.25.1

2 3

[PATCH v5 1/2] ASoC: dt-bindings: Add Everest ES8326 audio CODEC
by Zhu Ning 16 Aug '22

16 Aug '22

Add device tree binding documentation for Everest ES8326 Signed-off-by: David Yang <yangxiaohua(a)everest-semi.com> Signed-off-by: Zhu Ning <zhuning(a)everest-semi.com> ---- v5 tested by dtschema --- .../bindings/sound/everest,es8326.yaml | 116 ++++++++++++++++++ 1 file changed, 116 insertions(+) create mode 100755 Documentation/devicetree/bindings/sound/everest,es8326.yaml diff --git a/Documentation/devicetree/bindings/sound/everest,es8326.yaml b/Documentation/devicetree/bindings/sound/everest,es8326.yaml new file mode 100755 index 000000000000..07781408e788 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/everest,es8326.yaml @@ -0,0 +1,116 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/everest,es8326.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Everest ES8326 audio CODEC + +maintainers: + - David Yang <yangxiaohua(a)everest-semi.com> + +properties: + compatible: + const: everest,es8326 + + reg: + maxItems: 1 + + clocks: + items: + - description: clock for master clock (MCLK) + + clock-names: + items: + - const: mclk + + "#sound-dai-cells": + const: 0 + + everest,jack-pol: + $ref: /schemas/types.yaml#/definitions/uint8 + description: | + just the value of reg 57. Bit(3) decides whether the jack polarity is inverted. + Bit(2) decides whether the button on the headset is inverted. + Bit(1)/(0) decides the mic properity to be OMTP/CTIA or auto. + minimum: 0x00 + maximum: 0x0f + default: 0x0f + + everest,mic1-src: + $ref: /schemas/types.yaml#/definitions/uint8 + description: + the value of reg 2A when headset plugged. + minimum: 0x00 + maximum: 0x77 + default: 0x22 + + everest,mic2-src: + $ref: /schemas/types.yaml#/definitions/uint8 + description: + the value of reg 2A when headset unplugged. + minimum: 0x00 + maximum: 0x77 + default: 0x44 + + everest,jack-detect-inverted: + $ref: /schemas/types.yaml#/definitions/flag + description: + Defined to invert the jack detection. + + everest,interrupt-src: + $ref: /schemas/types.yaml#/definitions/uint8 + description: | + value of reg 0x58, Defines the interrupt source. + Bit(2) 1 means button press triggers irq, 0 means not. + Bit(3) 1 means PIN9 is the irq source for jack detection. When set to 0, + bias change on PIN9 do not triggers irq. + Bit(4) 1 means PIN27 is the irq source for jack detection. + Bit(5) 1 means PIN9 is the irq source after MIC detect. + Bit(6) 1 means PIN27 is the irq source after MIC detect. + minimum: 0 + maximum: 0x3c + default: 0x08 + + everest,interrupt-clk: + $ref: /schemas/types.yaml#/definitions/uint8 + description: | + value of reg 0x59, Defines the interrupt output behavior. + Bit(0-3) 0 means irq pulse equals 512*internal clock + 1 means irq pulse equals 1024*internal clock + 2 means ... + 7 means irq pulse equals 65536*internal clock + 8 means irq mutes PA + 9 means irq mutes PA and DAC output + Bit(4) 1 means we invert the interrupt output. + Bit(6) 1 means the chip do not detect jack type after button released. + 0 means the chip detect jack type again after button released. + minimum: 0 + maximum: 0x7f + default: 0x45 + +required: + - compatible + - reg + - "#sound-dai-cells" + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + es8326: codec@19 { + compatible = "everest,es8326"; + reg = <0x19>; + clocks = <&clks 10>; + clock-names = "mclk"; + #sound-dai-cells = <0>; + everest,mic1-src = [22]; + everest,mic2-src = [44]; + everest,jack-pol = [0e]; + everest,interrupt-src = [08]; + everest,interrupt-clk = [45]; + }; + }; -- 2.36.1

4 5

[PATCH v2] ASoC: fsl_sai: fix incorrect mclk number in error message
by Pieterjan Camerlynck 16 Aug '22

16 Aug '22

In commit c3ecef21c3f26 ("ASoC: fsl_sai: add sai master mode support") the loop was changed to start iterating from 1 instead of 0. The error message however was not updated, reporting the wrong clock to the user. Signed-off-by: Pieterjan Camerlynck <pieterjan.camerlynck(a)gmail.com> --- V2: rebase against latest version --- sound/soc/fsl/fsl_sai.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c index 7523bb944b21..d430eece1d6b 100644 --- a/sound/soc/fsl/fsl_sai.c +++ b/sound/soc/fsl/fsl_sai.c @@ -1306,7 +1306,7 @@ static int fsl_sai_probe(struct platform_device *pdev) sai->mclk_clk[i] = devm_clk_get(dev, tmp); if (IS_ERR(sai->mclk_clk[i])) { dev_err(dev, "failed to get mclk%d clock: %ld\n", - i + 1, PTR_ERR(sai->mclk_clk[i])); + i, PTR_ERR(sai->mclk_clk[i])); sai->mclk_clk[i] = NULL; } } -- 2.25.1

3 2

[PATCH] ALSA: hda/realtek: Add quirk for Lenovo Yoga7 14IAL7
by Takashi Iwai 16 Aug '22

16 Aug '22

Lenovo Yoga7 14IAL7 requires the same quirk as Lenovo Yoga9 14IAP7 for fixing the bass speaker problems. Reported-by: Pascal Gross <baipush(a)tutanota.com> Cc: <stable(a)vger.kernel.org> Link: https://lore.kernel.org/r/N9_CjBz--3-2@tutanota.com Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index f544761eb11b..b42496c01c43 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9492,6 +9492,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x17aa, 0x3852, "Lenovo Yoga 7 14ITL5", ALC287_FIXUP_YOGA7_14ITL_SPEAKERS), SND_PCI_QUIRK(0x17aa, 0x3853, "Lenovo Yoga 7 15ITL5", ALC287_FIXUP_YOGA7_14ITL_SPEAKERS), SND_PCI_QUIRK(0x17aa, 0x3855, "Legion 7 16ITHG6", ALC287_FIXUP_LEGION_16ITHG6), + SND_PCI_QUIRK(0x17aa, 0x3869, "Lenovo Yoga7 14IAL7", ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN), SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI), SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC), SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70", ALC269_FIXUP_DMIC_THINKPAD_ACPI), -- 2.35.3

1 0

[GIT PULL] ASoC fixes for v6.0-rc1
by Mark Brown 16 Aug '22

16 Aug '22

The following changes since commit 40d060b8158e26438398bf1132925f666e3b6480: ASoC: q6asm: use kcalloc() instead of kzalloc() (2022-07-28 11:59:10 +0100) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-fix-v6.0-rc1 for you to fetch changes up to b4b5f29a076e52181f63e45a2ad1bc88593072e3: ASoC: codec: tlv320aic32x4: fix mono playback via I2S (2022-08-10 14:52:05 +0100) ---------------------------------------------------------------- ASoC: Fixes for v6.0 A relatively large batch of fixes that came in since my pull request, none of them too major and mostly device specific apart from a series of security/robustness improvements from Takashi. ---------------------------------------------------------------- Biju Das (1): ASoC: sh: rz-ssi: Improve error handling in rz_ssi_probe() error path Justin Stitt (1): ASoC: SOF: ipc3-topology: Fix clang -Wformat warning Mark Brown (2): ASoC: Fix theoretical buffer overflow by snprintf() TAS2770 fixes Martin Povišer (4): ASoC: tas2770: Set correct FSYNC polarity ASoC: tas2770: Allow mono streams ASoC: tas2770: Drop conflicting set_bias_level power setting ASoC: tas2770: Fix handling of mute/unmute Oder Chiou (1): ASoC: rt5640: Fix the JD voltage dropping issue Philipp Zabel (1): ASoC: codec: tlv320aic32x4: fix mono playback via I2S Pierre-Louis Bossart (1): ASoC: Intel: fix sof_es8336 probe Takashi Iwai (4): ASoC: Intel: avs: Fix potential buffer overflow by snprintf() ASoC: SOF: debug: Fix potential buffer overflow by snprintf() ASoC: SOF: Intel: hda: Fix potential buffer overflow by snprintf() ASoC: DPCM: Don't pick up BE without substream syed sabakareem (1): ASoC: amd: yc: Update DMI table entries for AMD platforms sound/soc/amd/yc/acp6x-mach.c | 28 +++++++++++ sound/soc/codecs/rt5640.c | 5 +- sound/soc/codecs/tas2770.c | 98 ++++++++++++++++--------------------- sound/soc/codecs/tas2770.h | 5 ++ sound/soc/codecs/tlv320aic32x4.c | 9 ++++ sound/soc/intel/avs/pcm.c | 4 +- sound/soc/intel/boards/sof_es8336.c | 4 +- sound/soc/sh/rz-ssi.c | 26 +++++----- sound/soc/soc-pcm.c | 3 ++ sound/soc/sof/debug.c | 6 +-- sound/soc/sof/intel/hda.c | 2 +- sound/soc/sof/ipc3-topology.c | 2 +- 12 files changed, 116 insertions(+), 76 deletions(-)

2 1