July 2022 - Alsa-devel - mailman.alsa-project.org

[PATCH 0/2] Add support for CLSA0101
by Lucas Tanure 27 Jul '22

27 Jul '22

Add Support for the CLSA0101 laptop, an Intel version of CLSA0100. This patch has been tested using the CLSA0100, ensuring it doesn't break the sound for it. We appreciate it if someone with CLSA0101 could verify that this the patch works for them. Lucas Tanure (2): ALSA: hda: cs35l41: Use the CS35L41 HDA internal define ALSA: hda: cs35l41: Support CLSA0101 sound/pci/hda/cs35l41_hda.c | 67 +++++++++++++++++++++-------------- sound/pci/hda/patch_realtek.c | 12 +++++++ 2 files changed, 53 insertions(+), 26 deletions(-) -- 2.37.1

3 6

[PATCH 0/4] ALSA: Defer async signal handling
by Takashi Iwai 27 Jul '22

27 Jul '22

Hi, this series is another attempt to address the potential deadlocks via kill_fasync() calls that have been reported by syzbot for long time. Instead of the previous series to drop the async handler[*], this tries to defer the kill_fasync() call. A few new common helpers are introduced at first, then the actual usages are replaced in the following patches. The patches passed the quick tests with alsa-lib test cases. Takashi [*] https://lore.kernel.org/r/20220717070549.5993-1-tiwai@suse.de === Takashi Iwai (4): ALSA: core: Add async signal helpers ALSA: timer: Use deferred fasync helper ALSA: pcm: Use deferred fasync helper ALSA: control: Use deferred fasync helper include/sound/control.h | 2 +- include/sound/core.h | 8 ++++ include/sound/pcm.h | 2 +- sound/core/control.c | 7 ++-- sound/core/misc.c | 93 +++++++++++++++++++++++++++++++++++++++++ sound/core/pcm.c | 1 + sound/core/pcm_lib.c | 2 +- sound/core/pcm_native.c | 2 +- sound/core/timer.c | 11 ++--- 9 files changed, 116 insertions(+), 12 deletions(-) -- 2.35.3

2 6

HDA ATI HDMI not supported
by GitHub issues - opened 27 Jul '22

27 Jul '22

alsa-project/alsa-ucm-conf issue #194 was opened from yangxiaohua2009: I am using the latest ucm2 file and alsalib alsainfo [http://alsa-project.org/db/?f=92c58f3a6b72fee05b678386858dbc816d25dbf3](htt… When nothing is changed, the alsaucm reload command returns error saying: `ALSA lib parser.c:244:(error_node) UCM is not supported for this HDA model (HDA ATI HDMI at 0xfeb60000 irq 28)` and the HDMI is not working. After changing the file /ucm2/HDA/HDA.conf, from `Define.AcpCardId "$${find-card:field=name,return=id,regex='^(acp|acp6x)$'}"` to `Define.AcpCardId "$${find-card:field=name,return=id,regex='^(acp|acp6x|acpes8336)$'}"` alsucm reload returns no error, but alsaucm listcards returns: `ALSA lib main.c:1541:(snd_use_case_mgr_open) error: failed to import hw:1 use case configuration -2` ` 0: hw:0` ` HDA ATI HDMI at 0xfeb60000 irq 28` despite the fact that I already added the acpes8336.conf in conf.d and acpes8336 folder. Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/194 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH] ASoC: mediatek: mt8186: set the correct string to strncmp()
by Jiaxin Yu 26 Jul '22

26 Jul '22

Fix Smatch static checker warning. strncmp() here only needs to compare the first seven bytes, so in order to make the code more clear, only the first seven bytes of the string used as the comparison are reserved. Bug report: https://www.spinics.net/lists/alsa-devel/msg145608.html sound/soc/mediatek/mt8186/mt8186-dai-adda.c:78 get_adda_priv_by_name() warn: strncmp() with weird length: 17 vs 7 sound/soc/mediatek/mt8186/mt8186-dai-adda.c 72 static struct mtk_afe_adda_priv *get_adda_priv_by_name(struct mtk_base_afe *afe, 73 const char *name) 74 { 75 struct mt8186_afe_private *afe_priv = afe->platform_priv; 76 int dai_id; 77 --> 78 if (strncmp(name, "aud_dac_hires_clk", 7) == 0 || 79 strncmp(name, "aud_adc_hires_clk", 7) == 0) Fixes: b65c466220b3 ("ASoC: mediatek: mt8186: support adda in platform driver") Signed-off-by: Jiaxin Yu <jiaxin.yu(a)mediatek.com> --- sound/soc/mediatek/mt8186/mt8186-dai-adda.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/mediatek/mt8186/mt8186-dai-adda.c b/sound/soc/mediatek/mt8186/mt8186-dai-adda.c index db71b032770d..81976f7c444e 100644 --- a/sound/soc/mediatek/mt8186/mt8186-dai-adda.c +++ b/sound/soc/mediatek/mt8186/mt8186-dai-adda.c @@ -75,8 +75,7 @@ static struct mtk_afe_adda_priv *get_adda_priv_by_name(struct mtk_base_afe *afe, struct mt8186_afe_private *afe_priv = afe->platform_priv; int dai_id; - if (strncmp(name, "aud_dac_hires_clk", 7) == 0 || - strncmp(name, "aud_adc_hires_clk", 7) == 0) + if (strncmp(name, "aud_dac", 7) == 0 || strncmp(name, "aud_adc", 7) == 0) dai_id = MT8186_DAI_ADDA; else return NULL; -- 2.25.1

2 1

[PATCH v1] ASoC: Intel: cirrus-common: Use UID to map correct amp to prefix
by Stefan Binding 26 Jul '22

26 Jul '22

Since the order of the amps in the ACPI determines the device name, and the ACPI order may change depending on hardware configuration, use UID to dynamically compute the dai links, allowing dynamic assignment of the name_prefix. Signed-off-by: Stefan Binding <sbinding(a)opensource.cirrus.com> Signed-off-by: Vitaly Rodionov <vitalyr(a)opensource.cirrus.com> --- sound/soc/intel/boards/sof_cirrus_common.c | 73 +++++++++------------- 1 file changed, 31 insertions(+), 42 deletions(-) diff --git a/sound/soc/intel/boards/sof_cirrus_common.c b/sound/soc/intel/boards/sof_cirrus_common.c index f4192df962d6..a96bc70a34d7 100644 --- a/sound/soc/intel/boards/sof_cirrus_common.c +++ b/sound/soc/intel/boards/sof_cirrus_common.c @@ -10,6 +10,9 @@ #include "../../codecs/cs35l41.h" #include "sof_cirrus_common.h" +#define CS35L41_HID "CSC3541" +#define CS35L41_MAX_AMPS 4 + /* * Cirrus Logic CS35L41/CS35L53 */ @@ -35,50 +38,12 @@ static const struct snd_soc_dapm_route cs35l41_dapm_routes[] = { {"TR Spk", NULL, "TR SPK"}, }; -static struct snd_soc_dai_link_component cs35l41_components[] = { - { - .name = CS35L41_DEV0_NAME, - .dai_name = CS35L41_CODEC_DAI, - }, - { - .name = CS35L41_DEV1_NAME, - .dai_name = CS35L41_CODEC_DAI, - }, - { - .name = CS35L41_DEV2_NAME, - .dai_name = CS35L41_CODEC_DAI, - }, - { - .name = CS35L41_DEV3_NAME, - .dai_name = CS35L41_CODEC_DAI, - }, -}; +static struct snd_soc_dai_link_component cs35l41_components[CS35L41_MAX_AMPS]; /* * Mapping between ACPI instance id and speaker position. - * - * Four speakers: - * 0: Tweeter left, 1: Woofer left - * 2: Tweeter right, 3: Woofer right */ -static struct snd_soc_codec_conf cs35l41_codec_conf[] = { - { - .dlc = COMP_CODEC_CONF(CS35L41_DEV0_NAME), - .name_prefix = "TL", - }, - { - .dlc = COMP_CODEC_CONF(CS35L41_DEV1_NAME), - .name_prefix = "WL", - }, - { - .dlc = COMP_CODEC_CONF(CS35L41_DEV2_NAME), - .name_prefix = "TR", - }, - { - .dlc = COMP_CODEC_CONF(CS35L41_DEV3_NAME), - .name_prefix = "WR", - }, -}; +static struct snd_soc_codec_conf cs35l41_codec_conf[CS35L41_MAX_AMPS]; static int cs35l41_init(struct snd_soc_pcm_runtime *rtd) { @@ -117,10 +82,10 @@ static int cs35l41_init(struct snd_soc_pcm_runtime *rtd) static const struct { unsigned int rx[2]; } cs35l41_channel_map[] = { - {.rx = {0, 1}}, /* TL */ {.rx = {0, 1}}, /* WL */ - {.rx = {1, 0}}, /* TR */ {.rx = {1, 0}}, /* WR */ + {.rx = {0, 1}}, /* TL */ + {.rx = {1, 0}}, /* TR */ }; static int cs35l41_hw_params(struct snd_pcm_substream *substream, @@ -175,8 +140,32 @@ static const struct snd_soc_ops cs35l41_ops = { .hw_params = cs35l41_hw_params, }; +static const char * const cs35l41_name_prefixes[] = { "WL", "WR", "TL", "TR" }; + +static const char * const cs35l41_uid_strings[] = { "0", "1", "2", "3" }; + +static void cs35l41_compute_codec_conf(void) +{ + int uid; + struct acpi_device *adev; + struct device *physdev; + + for (uid = 0; uid < CS35L41_MAX_AMPS; uid++) { + adev = acpi_dev_get_first_match_dev(CS35L41_HID, cs35l41_uid_strings[uid], -1); + if (!adev) + return; + physdev = get_device(acpi_get_first_physical_node(adev)); + cs35l41_components[uid].name = dev_name(physdev); + cs35l41_components[uid].dai_name = CS35L41_CODEC_DAI; + cs35l41_codec_conf[uid].dlc.name = dev_name(physdev); + cs35l41_codec_conf[uid].name_prefix = cs35l41_name_prefixes[uid]; + acpi_dev_put(adev); + } +} + void cs35l41_set_dai_link(struct snd_soc_dai_link *link) { + cs35l41_compute_codec_conf(); link->codecs = cs35l41_components; link->num_codecs = ARRAY_SIZE(cs35l41_components); link->init = cs35l41_init; -- 2.34.1

3 2

[PATCH v7] ASoc: dt-bindings: tas2780: remove tas2780 and will merge it to tas27xx
by Raphael-Xu 26 Jul '22

26 Jul '22

remove tas2780 Signed-off-by: Raphael-Xu <13691752556(a)139.com> --- .../devicetree/bindings/sound/tas2780.yaml | 75 ------------------- 1 file changed, 75 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/tas2780.yaml diff --git a/Documentation/devicetree/bindings/sound/tas2780.yaml b/Documentation/devicetree/bindings/sound/tas2780.yaml deleted file mode 100644 index 21389a16fdb9..000000000000 --- a/Documentation/devicetree/bindings/sound/tas2780.yaml +++ /dev/null @@ -1,75 +0,0 @@ -# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) -# Copyright (C) 2020-2022 Texas Instruments Incorporated -%YAML 1.2 ---- -$id: "http://devicetree.org/schemas/sound/tas2780.yaml#" -$schema: "http://devicetree.org/meta-schemas/core.yaml#" - -title: Texas Instruments TAS2780 Smart PA - -maintainers: - - Raphael Xu <raphael-xu(a)ti.com> - -description: | - The TAS2780 is a mono, digital input Class-D audio amplifier optimized for - efficiently driving high peak power into small loudspeakers. - Integrated speaker voltage and current sense provides for - real time monitoring of loudspeaker behavior. - -properties: - compatible: - enum: - - ti,tas2780 - - reg: - description: - I2C address of the device can be between 0x38 to 0x3f. - minimum: 0x38 - maximum: 0x3f - - reset-gpios: - description: GPIO used to reset the device. - maxItems: 1 - - interrupts: - maxItems: 1 - - ti,imon-slot-no: - description: TDM TX current sense time slot. - $ref: /schemas/types.yaml#/definitions/uint32 - minimum: 0 - maximum: 3 - - ti,vmon-slot-no: - description: TDM TX voltage sense time slot. - $ref: /schemas/types.yaml#/definitions/uint32 - minimum: 0 - maximum: 3 - - '#sound-dai-cells': - const: 1 - -required: - - compatible - - reg - -additionalProperties: false - -examples: - - | - #include <dt-bindings/gpio/gpio.h> - i2c0 { - #address-cells = <1>; - #size-cells = <0>; - codec: codec@38 { - compatible = "ti,tas2780"; - reg = <0x38>; - #sound-dai-cells = <1>; - interrupts = <14>; - reset-gpios = <&gpio1 15 0>; - ti,imon-slot-no = <0>; - ti,vmon-slot-no = <2>; - }; - }; - -... -- 2.35.1

3 4

rt715-sdca: use sensible capture gain value
by GitHub pull_request - opened 26 Jul '22

26 Jul '22

alsa-project/alsa-ucm-conf pull request #193 was opened from plbossart: The value of 124 used for FU02 is way too much, with saturation even in low-volume cases. The 0dB value (47) is a much better initialization value. BugLink: https://github.com/thesofproject/linux/issues/3766 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/193 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/193.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH] ASoC: dt-bindings: qcom, wcd934x: use absolute path to other schema
by Krzysztof Kozlowski 26 Jul '22

26 Jul '22

Absolute path to other DT schema is preferred over relative one. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> --- Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml index 9b225dbf8b79..8ca19f2b0b3d 100644 --- a/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml @@ -127,7 +127,7 @@ properties: gpio@42: type: object - $ref: ../gpio/qcom,wcd934x-gpio.yaml# + $ref: /schemas/gpio/qcom,wcd934x-gpio.yaml# patternProperties: "^.*@[0-9a-f]+$": -- 2.34.1

2 1

[PATCH] ASoC: amd: acp: Fix initialization of ext_intr_stat1 in i2s_irq_handler()
by Nathan Chancellor 26 Jul '22

26 Jul '22

Clang warns: ../sound/soc/amd/acp/acp-platform.c:117:19: error: variable 'ext_intr_stat1' is uninitialized when used here [-Werror,-Wuninitialized] if (stream && (ext_intr_stat1 & stream->irq_bit)) { ^~~~~~~~~~~~~~ ../sound/soc/amd/acp/acp-platform.c:97:35: note: initialize the variable 'ext_intr_stat1' to silence this warning u32 ext_intr_stat, ext_intr_stat1, i; ^ = 0 1 error generated. The variable was not properly renamed, correct it to resolve the warning. Fixes: 93f53881473c ("ASoC: amd: acp: Modify local variables name to generic") Link: https://github.com/ClangBuiltLinux/linux/issues/1675 Signed-off-by: Nathan Chancellor <nathan(a)kernel.org> --- sound/soc/amd/acp/acp-platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/amd/acp/acp-platform.c b/sound/soc/amd/acp/acp-platform.c index 10730d33c3b0..f561d39b33e2 100644 --- a/sound/soc/amd/acp/acp-platform.c +++ b/sound/soc/amd/acp/acp-platform.c @@ -100,7 +100,7 @@ static irqreturn_t i2s_irq_handler(int irq, void *data) return IRQ_NONE; if (adata->rsrc->no_of_ctrls == 2) - ext_intr_stat = readl(ACP_EXTERNAL_INTR_STAT(adata, (rsrc->irqp_used - 1))); + ext_intr_stat1 = readl(ACP_EXTERNAL_INTR_STAT(adata, (rsrc->irqp_used - 1))); ext_intr_stat = readl(ACP_EXTERNAL_INTR_STAT(adata, rsrc->irqp_used)); base-commit: be0aa8d4b0fcb4532bf7973141e911998ab39508 -- 2.37.1

3 2

[PATCH v2 0/5] ASoC: atmel: one fix and few cleanups
by Claudiu Beznea 26 Jul '22

26 Jul '22

Hi, The series adds one fix for mchp-spdifrx and few cleanups for mchp-spdifrx and mchp-spdifrx drivers. Thank you, Claudiu Beznea Changes in v2: - s/tag/tab in the title of patch 2/5 Claudiu Beznea (5): ASoC: mchp-spdifrx: disable end of block interrupt on failures ASoC: mchp-spdifrx: use single tag indent for structure ASoC: mchp-spdiftx: remove references to mchp_i2s_caps ASoC: mchp-spdiftx: return directly ret ASoC: mchp-spdiftx: add and remove black line around MODULE_DEVICE_TABLE() sound/soc/atmel/mchp-spdifrx.c | 19 +++++++++++-------- sound/soc/atmel/mchp-spdiftx.c | 21 +++++---------------- 2 files changed, 16 insertions(+), 24 deletions(-) -- 2.34.1

2 8