July 2022 - Alsa-devel - mailman.alsa-project.org

[bug report] ASoC: amd: acp: ACP code generic to support newer platforms
by Dan Carpenter 13 Jul '22

13 Jul '22

Hello V sujith kumar Reddy, This is a semi-automatic email about new static checker warnings. The patch b24484c18b10: "ASoC: amd: acp: ACP code generic to support newer platforms" from Jul 7, 2022, leads to the following Smatch complaint: sound/soc/amd/acp/acp-platform.c:99 i2s_irq_handler() warn: variable dereferenced before check 'adata' (see line 94) sound/soc/amd/acp/acp-platform.c 93 struct acp_dev_data *adata = data; 94 struct acp_resource *rsrc = adata->rsrc; ^^^^^^^^^^^ The patch adds a new dereference 95 struct acp_stream *stream; 96 u16 i2s_flag = 0; 97 u32 val, val1, i; 98 99 if (!adata) ^^^^^^ The old code assumed that "adata" could be NULL but hopefully that check can be removed? 100 return IRQ_NONE; 101 regards, dan carpenter

1 0

snd-aloop working no more on 1.2.7.1
by GitHub issues - edited 13 Jul '22

13 Jul '22

alsa-project/alsa-lib issue #251 was edited from tramchamploo: ``` pcm.er4s { # Direct hardware access type hw # Loopback card name # # Has to match "id" in the options of the snd-aloop module card "Loopback" # Loopback device ID device 0 # Number of audio channels # # Has to match the number of channels in music player app # and in the CamillaDSP input configuration channels 2 # Format of audio stream # # Has to match the format defined in the # of the CamillaDSP input configuration format "FLOAT_LE" # Sampling-rate of audio stream # # Has to match the sampling-rate defined in the # CamillaDSP configuration rate 48000 } ctl.er4s { type hw card "Loopback" } ``` This is the .asoundrc I'm using, it worked before this update. Now aplay -L doesn't show this device. Using mpd to play to the Loopback gets `snd_pcm_hw_params() failed: Invalid argument`. Here's my mpd config: ``` audio_output { type "alsa" name "Etymotic ER4S" device "er4s" format "48000:f:2" mixer_type "none" replay_gain_handler "none" auto_resample "no" auto_format "no" } resampler { plugin "soxr" quality "custom" precision "28" phase_response "50" passband_end "91" stopband_begin "100" attenu ``` Btw, alsa should really have a detailed specification on asoundrc file. The value of the format option I specify is from a dsp project, otherwise I have no idea what to write here. And according to [https://www.alsa-project.org/alsa-doc/alsa-lib/group___p_c_m.html#gaa14b7f2… it's in a totally different format. Issue URL : https://github.com/alsa-project/alsa-lib/issues/251 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

snd-aloop working no more on 1.2.7.1
by GitHub issues - edited 13 Jul '22

13 Jul '22

alsa-project/alsa-lib issue #251 was edited from tramchamploo: ``` pcm.er4s { # Direct hardware access type hw # Loopback card name # # Has to match "id" in the options of the snd-aloop module card "Loopback" # Loopback device ID device 0 # Number of audio channels # # Has to match the number of channels in music player app # and in the CamillaDSP input configuration channels 2 # Format of audio stream # # Has to match the format defined in the # of the CamillaDSP input configuration format "FLOAT_LE" # Sampling-rate of audio stream # # Has to match the sampling-rate defined in the # CamillaDSP configuration rate 48000 } ctl.er4s { type hw card "Loopback" } ``` This is the .asoundrc I'm using, it worked before this update. Now aplay -L doesn't show this device. Using mpd to play to the Loopback gets `snd_pcm_hw_params() failed: Invalid argument`. Btw, alsa should really have a detailed specification on asoundrc file. The value of the format option I specify is from a dsp project, otherwise I have no idea what to write here. And according to [https://www.alsa-project.org/alsa-doc/alsa-lib/group___p_c_m.html#gaa14b7f2… it's in a totally different format. Issue URL : https://github.com/alsa-project/alsa-lib/issues/251 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

snd-aloop working no more on 1.2.7.1
by GitHub issues - opened 13 Jul '22

13 Jul '22

alsa-project/alsa-lib issue #251 was opened from tramchamploo: `# # Place your global alsa-lib configuration here... # # pcm.er4s { # Direct hardware access type hw # Loopback card name # # Has to match "id" in the options of the snd-aloop module card "Loopback" # Loopback device ID device 0 # Number of audio channels # # Has to match the number of channels in music player app # and in the CamillaDSP input configuration channels 2 # Format of audio stream # # Has to match the format defined in the # of the CamillaDSP input configuration format "FLOAT_LE" # Sampling-rate of audio stream # # Has to match the sampling-rate defined in the # CamillaDSP configuration rate 48000 } ctl.er4s { type hw card "Loopback" } ` This is the .asoundrc I'm using, it worked before this update. Now aplay -L doesn't show this device. Using mpd to play to the Loopback gets `snd_pcm_hw_params() failed: Invalid argument`. Btw, alsa should really have a detailed specification on asoundrc file. The value of the format option I specify is from a dsp project, otherwise I have no idea what to write here. And according to [https://www.alsa-project.org/alsa-doc/alsa-lib/group___p_c_m.html#gaa14b7f2… it's in a totally different format. Issue URL : https://github.com/alsa-project/alsa-lib/issues/251 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH 0/7] ALSA: kernel doc fixes
by Takashi Iwai 13 Jul '22

13 Jul '22

Hi, this is a patch series to address minor warnings at processing kernel docs. Takashi === Takashi Iwai (7): ALSA: compress: Enable kernel doc markers for some functions ALSA: pcm: Fix missing return value comments for kernel docs ALSA: dmaengine: Fix missing return value comments for kernel docs ALSA: compress: Fix kernel doc warnings ALSA: control: Fix missing return value comments for kernel docs ALSA: memalloc: Fix missing return value comments for kernel docs ALSA: core: Fix missing return value comments for kernel docs include/sound/dmaengine_pcm.h | 2 ++ include/sound/pcm.h | 50 +++++++++++++++++++++++++-- include/uapi/sound/compress_offload.h | 2 +- include/uapi/sound/compress_params.h | 6 ++-- sound/core/compress_offload.c | 9 +++-- sound/core/control.c | 16 +++++++-- sound/core/device.c | 2 ++ sound/core/info.c | 2 ++ sound/core/init.c | 10 ++++++ sound/core/isadma.c | 3 +- sound/core/memalloc.c | 10 +++++- sound/core/pcm.c | 4 +++ sound/core/pcm_dmaengine.c | 30 ++++++++++------ sound/core/pcm_memory.c | 4 +++ sound/core/pcm_native.c | 6 ++++ sound/core/vmaster.c | 3 +- 16 files changed, 136 insertions(+), 23 deletions(-) -- 2.35.3

1 7

[PATCH] ALSA: hda/realtek - Enable the headset-mic on a Xiaomi's laptop
by Meng Tang 13 Jul '22

13 Jul '22

The headset on this machine is not defined, after applying the quirk ALC256_FIXUP_ASUS_HEADSET_MIC, the headset-mic works well Signed-off-by: Meng Tang <tangmeng(a)uniontech.com> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 91cd58849ee8..383a814b8539 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9369,6 +9369,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1d72, 0x1602, "RedmiBook", ALC255_FIXUP_XIAOMI_HEADSET_MIC), SND_PCI_QUIRK(0x1d72, 0x1701, "XiaomiNotebook Pro", ALC298_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1d72, 0x1901, "RedmiBook 14", ALC256_FIXUP_ASUS_HEADSET_MIC), + SND_PCI_QUIRK(0x1d72, 0x1945, "Redmi G", ALC256_FIXUP_ASUS_HEADSET_MIC), SND_PCI_QUIRK(0x1d72, 0x1947, "RedmiBook Air", ALC255_FIXUP_XIAOMI_HEADSET_MIC), SND_PCI_QUIRK(0x8086, 0x2074, "Intel NUC 8", ALC233_FIXUP_INTEL_NUC8_DMIC), SND_PCI_QUIRK(0x8086, 0x2080, "Intel NUC 8 Rugged", ALC256_FIXUP_INTEL_NUC8_RUGGED), -- 2.20.1

2 1

[PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc221
by Meng Tang 13 Jul '22

13 Jul '22

On a HP 288 Pro G2 MT (X9W02AV), the front mic could not be detected. In order to get it working, the pin configuration needs to be set correctly, and the ALC221_FIXUP_HP_288PRO_MIC_NO_PRESENCE fixup needs to be applied. Signed-off-by: Meng Tang <tangmeng(a)uniontech.com> --- sound/pci/hda/patch_realtek.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 34139c26795f..91cd58849ee8 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6901,6 +6901,7 @@ enum { ALC298_FIXUP_LENOVO_SPK_VOLUME, ALC256_FIXUP_DELL_INSPIRON_7559_SUBWOOFER, ALC269_FIXUP_ATIV_BOOK_8, + ALC221_FIXUP_HP_288PRO_MIC_NO_PRESENCE, ALC221_FIXUP_HP_MIC_NO_PRESENCE, ALC256_FIXUP_ASUS_HEADSET_MODE, ALC256_FIXUP_ASUS_MIC, @@ -7837,6 +7838,16 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC269_FIXUP_NO_SHUTUP }, + [ALC221_FIXUP_HP_288PRO_MIC_NO_PRESENCE] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl[]) { + { 0x19, 0x01a1913c }, /* use as headset mic, without its own jack detect */ + { 0x1a, 0x01813030 }, /* use as headphone mic, without its own jack detect */ + { } + }, + .chained = true, + .chain_id = ALC269_FIXUP_HEADSET_MODE + }, [ALC221_FIXUP_HP_MIC_NO_PRESENCE] = { .type = HDA_FIXUP_PINS, .v.pins = (const struct hda_pintbl[]) { @@ -9012,6 +9023,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x2335, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1), SND_PCI_QUIRK(0x103c, 0x2336, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1), SND_PCI_QUIRK(0x103c, 0x2337, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1), + SND_PCI_QUIRK(0x103c, 0x2b5e, "HP 288 Pro G2 MT", ALC221_FIXUP_HP_288PRO_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x103c, 0x802e, "HP Z240 SFF", ALC221_FIXUP_HP_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x103c, 0x802f, "HP Z240", ALC221_FIXUP_HP_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x103c, 0x8077, "HP", ALC256_FIXUP_HP_HEADSET_MIC), -- 2.20.1

2 1

[PATCH] ALSA: hda/realtek: fix mute/micmute LEDs for HP machines
by Jeremy Szu 13 Jul '22

13 Jul '22

* The HP ProBook 440/450 G9 and EliteBook 640/650 G9 have multiple motherboard design and they are using different subsystem ID of audio codec. Add the same quirk for other MBs. Signed-off-by: Jeremy Szu <jeremy.szu(a)canonical.com> --- sound/pci/hda/patch_realtek.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 007dd8b5e1f2..483c5f49af5d 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9096,6 +9096,10 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x89c6, "Zbook Fury 17 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x89ca, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), SND_PCI_QUIRK(0x103c, 0x8a78, "HP Dev One", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST), + SND_PCI_QUIRK(0x103c, 0x8aa0, "HP ProBook 440 G9 (MB 8A9E)", ALC236_FIXUP_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)", ALC236_FIXUP_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8aa8, "HP EliteBook 640 G9 (MB 8AA6)", ALC236_FIXUP_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8aab, "HP EliteBook 650 G9 (MB 8AA9)", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC), SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", ALC282_FIXUP_ASUS_TX300), SND_PCI_QUIRK(0x1043, 0x106d, "Asus K53BE", ALC269_FIXUP_LIMIT_INT_MIC_BOOST), -- 2.25.1

2 1

[PATCH v2 1/4] ALSA: hda: cs35l41: Don't dereference fwnode handle
by Andy Shevchenko 13 Jul '22

13 Jul '22

Use acpi_fwnode_handle() instead of dereferencing an fwnode handle directly, which is a better coding practice. Signed-off-by: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> --- v2: new change sound/pci/hda/cs35l41_hda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c index 49b25432a9f5..1a1afa0725e0 100644 --- a/sound/pci/hda/cs35l41_hda.c +++ b/sound/pci/hda/cs35l41_hda.c @@ -347,7 +347,7 @@ static int cs35l41_hda_read_acpi(struct cs35l41_hda *cs35l41, const char *hid, i /* To use the same release code for all laptop variants we can't use devm_ version of * gpiod_get here, as CLSA010* don't have a fully functional bios with an _DSD node */ - cs35l41->reset_gpio = fwnode_gpiod_get_index(&adev->fwnode, "reset", cs35l41->index, + cs35l41->reset_gpio = fwnode_gpiod_get_index(acpi_fwnode_handle(adev), "reset", cs35l41->index, GPIOD_OUT_LOW, "cs35l41-reset"); property = "cirrus,speaker-position"; -- 2.35.1

2 4

[PATCH 0/4] Extend ipc stream parameters sent to DSP
by Daniel Baluta 12 Jul '22

12 Jul '22

From: Daniel Baluta <daniel.baluta(a)nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We need a way to send extra parameters to DSP firmware. In order to do this, we introduce ext_data array at the end of ipc_stream_params. With this new addition we can send compress parameters. This requires SOF ABI bump. Daniel Baluta (4): ASoC: SOF: compress: Dynamically allocate pcm params struct ASoC: SOF: Copy compress parameters into extended data ASoC: SOF: compress: Prevent current kernel running with older FW uapi: sof: abi: Bump SOF ABI for ext_data_length include/sound/sof/stream.h | 6 ++- include/uapi/sound/sof/abi.h | 2 +- sound/soc/sof/compress.c | 73 ++++++++++++++++++++++++------------ 3 files changed, 54 insertions(+), 27 deletions(-) -- 2.27.0

2 5