July 2022 - Alsa-devel - mailman.alsa-project.org

Behringer UMC204HD HiFi "Default" profile crackling audio
by GitHub issues - opened 20 Jul '22

20 Jul '22

alsa-project/alsa-ucm-conf issue #192 was opened from acepukas: Since the recent update to 1.2.7.2, the Behringer UMC204HD "Default" profile has crackling audio through "Line A" and "Line B" ports. Switching to the "Direct" profile allows for clean audio but it's output over 4 speakers (front left and right, rear left and right). Not really sure how to trouble shoot this. Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/192 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

ASoC: Is this bug ? DAPM source vs sink
by Kuninori Morimoto 20 Jul '22

20 Jul '22

Hi ASoC Cc Lars-Peter I have noticed that DAPM source vs sink are strange. ASoC had used source/sink or input/output before, but it was exchanged by this patch a3423b02cf745c1418f1f199646c450d6fc9ca4e ("ASoC: dapm: Consolidate input and output path handling") I think source/sink pair are converted to SND_SOC_DAPM_DIR_IN/OUT by this patch. source <=> IN sink <=> OUT But, its for_each are inverted #define snd_soc_dapm_widget_for_each_sink_path(w, p) \ snd_soc_dapm_widget_for_each_path(w, SND_SOC_DAPM_DIR_IN, p) #define snd_soc_dapm_widget_for_each_source_path(w, p) \ snd_soc_dapm_widget_for_each_path(w, SND_SOC_DAPM_DIR_OUT, p) I have thought this for_each is for special handling, but, the original was sink is for sink, source is for source after all. #define snd_soc_dapm_widget_for_each_sink_path(w, p) \ list_for_each_entry(p, &w->sinks, list_source) #define snd_soc_dapm_widget_for_each_source_path(w, p) \ list_for_each_entry(p, &w->sources, list_sink) So, I guess current for_each is wrong, but I'm not 100% sure #define snd_soc_dapm_widget_for_each_sink_path(w, p) \ - snd_soc_dapm_widget_for_each_path(w, SND_SOC_DAPM_DIR_IN, p) + snd_soc_dapm_widget_for_each_path(w, SND_SOC_DAPM_DIR_OUT, p) #define snd_soc_dapm_widget_for_each_source_path(w, p) \ - snd_soc_dapm_widget_for_each_path(w, SND_SOC_DAPM_DIR_OUT, p) + snd_soc_dapm_widget_for_each_path(w, SND_SOC_DAPM_DIR_IN, p) I'm happy to create patch if I could get your ack. Thank you for your help !! Best regards --- Kuninori Morimoto

3 3

[PATCH 00/11] ASoC: SOF: Intel: updates and cleanups
by Pierre-Louis Bossart 19 Jul '22

19 Jul '22

Set of updates for IPC3, IPC4, MTL support and cleanups for the topology filename override which was broken for HDaudio platforms. It may be too late for 5.20, it's ok if these patches are applied in the next cycle. The topology override depends on the patch "ASoC: SOF: Intel: enable dmic handling with 2 or fewer SoundWire links" shared in a separate patchset. Bard Liao (1): ASoC: SOF: ipc4-topology: move ida allocate/free to widget_setup/free Peter Ujfalusi (2): ASoC: SOF: ipc3-loader: Print out the non matching ext_man magic number ASoC: SOF: Intel: atom: don't keep a temporary string in fixup_tplg_name Pierre-Louis Bossart (4): ASoC: SOF: Intel: hda: don't set fw_filename ASoC: SOF: Intel: hda: only fixup topology name if not set already ASoC: SOF: probes: rename assign/free callbacks as startup/shutdown ASoC: SOF: Intel: hda-stream: test DMA buffer first in hw_params Rander Wang (3): ASoC: SOF: ipc4-pcm: set pcm rate to dai setting ASoC: SOF: add ipc4 SRC module support ASoC: SOF: ipc4-topology: set domain bit based on dp domain type Yong Zhi (1): ASoC: SOF: Intel: MTL: remove redundant snd_sof_dsp_read() call sound/soc/sof/intel/atom.c | 16 +-- sound/soc/sof/intel/hda-probes.c | 16 +-- sound/soc/sof/intel/hda-stream.c | 15 ++- sound/soc/sof/intel/hda.c | 71 +++++++++----- sound/soc/sof/intel/mtl.c | 13 +-- sound/soc/sof/ipc3-loader.c | 6 +- sound/soc/sof/ipc4-pcm.c | 4 + sound/soc/sof/ipc4-topology.c | 156 +++++++++++++++++++++++++----- sound/soc/sof/ipc4-topology.h | 27 +++++- sound/soc/sof/sof-client-probes.c | 8 +- sound/soc/sof/sof-client-probes.h | 8 +- 11 files changed, 250 insertions(+), 90 deletions(-) -- 2.34.1

2 12

[PATCH] ASOC: nau8821: add new widget to control system clock
by Wallace Lin 19 Jul '22

19 Jul '22

From: Wallace Lin <savagecin0(a)gmail.com> Add new widget to control system clock for power saving. Signed-off-by: Wallace Lin <savagecin0(a)gmail.com> Signed-off-by: Wallace Lin <sjlin0(a)nuvoton.com> --- sound/soc/codecs/nau8821.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/sound/soc/codecs/nau8821.c b/sound/soc/codecs/nau8821.c index 2600be250a3c..83a17c48d594 100644 --- a/sound/soc/codecs/nau8821.c +++ b/sound/soc/codecs/nau8821.c @@ -36,6 +36,7 @@ static int nau8821_configure_sysclk(struct nau8821 *nau8821, int clk_id, unsigned int freq); +static bool nau8821_is_jack_inserted(struct regmap *regmap); struct nau8821_fll { int mclk_src; @@ -495,7 +496,33 @@ static int nau8821_output_dac_event(struct snd_soc_dapm_widget *w, return 0; } +static int system_clock_control(struct snd_soc_dapm_widget *w, + struct snd_kcontrol *k, int event) +{ + struct snd_soc_component *component = + snd_soc_dapm_to_component(w->dapm); + struct nau8821 *nau8821 = snd_soc_component_get_drvdata(component); + + if (SND_SOC_DAPM_EVENT_OFF(event)) { + dev_dbg(nau8821->dev, "system clock control : POWER OFF\n"); + /* Set clock source to disable or internal clock before the + * playback or capture end. Codec needs clock for Jack + * detection and button press if jack inserted; otherwise, + * the clock should be closed. + */ + if (nau8821_is_jack_inserted(nau8821->regmap)) { + nau8821_configure_sysclk(nau8821, + NAU8821_CLK_INTERNAL, 0); + } else { + nau8821_configure_sysclk(nau8821, NAU8821_CLK_DIS, 0); + } + } + return 0; +} + static const struct snd_soc_dapm_widget nau8821_dapm_widgets[] = { + SND_SOC_DAPM_SUPPLY("System Clock", SND_SOC_NOPM, 0, 0, + system_clock_control, SND_SOC_DAPM_POST_PMD), SND_SOC_DAPM_SUPPLY("MICBIAS", NAU8821_R74_MIC_BIAS, NAU8821_MICBIAS_POWERUP_SFT, 0, NULL, 0), SND_SOC_DAPM_SUPPLY("DMIC Clock", SND_SOC_NOPM, 0, 0, @@ -607,6 +634,9 @@ static const struct snd_soc_dapm_route nau8821_dapm_routes[] = { {"AIFTX", NULL, "ADCL Digital path"}, {"AIFTX", NULL, "ADCR Digital path"}, + {"AIFTX", NULL, "System Clock"}, + {"AIFRX", NULL, "System Clock"}, + {"DDACL", NULL, "AIFRX"}, {"DDACR", NULL, "AIFRX"}, -- 2.25.1

2 1

[PATCH] ASoC: amd: yc: Decrease level of error message
by Mario Limonciello 19 Jul '22

19 Jul '22

On a number of platforms that contain acp3x controller a new ERR level message is showing up: `acp6x pci device not found` This is because ACP3x and ACP6x share same PCI ID but can be identified by PCI revision. As this is expected behavior for a system with ACP3x decrease message to debug. Fixes: b1630fcbfde6c ("ASoC: amd: yc: add new YC platform varaint support") Cc: Vijendar Mukunda <Vijendar.Mukunda(a)amd.com> Signed-off-by: Mario Limonciello <mario.limonciello(a)amd.com> --- sound/soc/amd/yc/pci-acp6x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/amd/yc/pci-acp6x.c b/sound/soc/amd/yc/pci-acp6x.c index 20f7a99783f20..77c5fa1f7af14 100644 --- a/sound/soc/amd/yc/pci-acp6x.c +++ b/sound/soc/amd/yc/pci-acp6x.c @@ -159,7 +159,7 @@ static int snd_acp6x_probe(struct pci_dev *pci, case 0x6f: break; default: - dev_err(&pci->dev, "acp6x pci device not found\n"); + dev_dbg(&pci->dev, "acp6x pci device not found\n"); return -ENODEV; } if (pci_enable_device(pci)) { -- 2.25.1

2 1

[PATCH v1 1/1] rsnd: ssiu: add missing .quit callback for gen2
by Jiada Wang 19 Jul '22

19 Jul '22

From: Wang Jiada <jiada_wang(a)mentor.com> commit 83b220cf8eb2a ("ASoC: rsnd: implement BUSIF related code in ssiu.c") moved BUSIF related code in ssiu.c which added .quit callback in ssiu.c to disable error irq when ssiu quits. But .quit callback was added only for gen1 and is missing for gen2, this causes error irq is left enabled after ssiu quits on gen2. This commit adds missing .quit callback for gen2 Signed-off-by: Wang Jiada <jiada_wang(a)mentor.com> Cc: Dean Jenkins <Dean_Jenkins(a)mentor.com> Cc: Eugeniu Rosca <erosca(a)de.adit-jv.com> --- sound/soc/sh/rcar/ssiu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/sh/rcar/ssiu.c b/sound/soc/sh/rcar/ssiu.c index 4b8a63e336c7..19a8030a660d 100644 --- a/sound/soc/sh/rcar/ssiu.c +++ b/sound/soc/sh/rcar/ssiu.c @@ -417,6 +417,7 @@ static struct rsnd_mod_ops rsnd_ssiu_ops_gen2 = { .name = SSIU_NAME, .dma_req = rsnd_ssiu_dma_req, .init = rsnd_ssiu_init_gen2, + .quit = rsnd_ssiu_quit, .start = rsnd_ssiu_start_gen2, .stop = rsnd_ssiu_stop_gen2, .get_status = rsnd_ssiu_get_status, -- 2.25.1

3 2

[PATCH] docs: driver-api: firmware: add driver firmware guidelines.
by Dave Airlie 19 Jul '22

19 Jul '22

From: Dave Airlie <airlied(a)redhat.com> A recent snafu where Intel ignored upstream feedback on a firmware change, led to a late rc6 fix being required. In order to avoid this in the future we should document some expectations around linux-firmware. I was originally going to write this for drm, but it seems quite generic advice. I'm cc'ing this quite widely to reach subsystems which use fw a lot. Signed-off-by: Dave Airlie <airlied(a)redhat.com> --- Documentation/driver-api/firmware/core.rst | 1 + .../firmware/firmware-usage-guidelines.rst | 34 +++++++++++++++++++ 2 files changed, 35 insertions(+) create mode 100644 Documentation/driver-api/firmware/firmware-usage-guidelines.rst diff --git a/Documentation/driver-api/firmware/core.rst b/Documentation/driver-api/firmware/core.rst index 1d1688cbc078..803cd574bbd7 100644 --- a/Documentation/driver-api/firmware/core.rst +++ b/Documentation/driver-api/firmware/core.rst @@ -13,4 +13,5 @@ documents these features. direct-fs-lookup fallback-mechanisms lookup-order + firmware-usage-guidelines diff --git a/Documentation/driver-api/firmware/firmware-usage-guidelines.rst b/Documentation/driver-api/firmware/firmware-usage-guidelines.rst new file mode 100644 index 000000000000..34d2412e78c6 --- /dev/null +++ b/Documentation/driver-api/firmware/firmware-usage-guidelines.rst @@ -0,0 +1,34 @@ +=================== +Firmware Guidelines +=================== + +Drivers that use firmware from linux-firmware should attempt to follow +the rules in this guide. + +* Firmware should be versioned with at least a major/minor version. It + is suggested that the firmware files in linux-firmware be named with + some device specific name, and just the major version. The + major/minor/patch versions should be stored in a header in the + firmware file for the driver to detect any non-ABI fixes/issues. The + firmware files in linux-firmware should be overwritten with the newest + compatible major version. Newer major version firmware should remain + compatible with all kernels that load that major number. + +* Users should *not* have to install newer firmware to use existing + hardware when they install a newer kernel. If the hardware isn't + enabled by default or under development, this can be ignored, until + the first kernel release that enables that hardware. This means no + major version bumps without the kernel retaining backwards + compatibility for the older major versions. Minor version bumps + should not introduce new features that newer kernels depend on + non-optionally. + +* If a security fix needs lockstep firmware and kernel fixes in order to + be successful, then all supported major versions in the linux-firmware + repo should be updated with the security fix, and the kernel patches + should detect if the firmware is new enough to declare if the security + issue is fixed. All communications around security fixes should point + at both the firmware and kernel fixes. If a security fix requires + deprecating old major versions, then this should only be done as a + last option, and be stated clearly in all communications. + -- 2.36.1

6 7

Re: [PATCH -next v2] ASoC: Intel: Fix missing clk_disable_unprepare() on err in platform_clock_control()
by Pierre-Louis Bossart 19 Jul '22

19 Jul '22

On 7/18/22 20:36, Zhang Zekun wrote: > Fix the missing clk_disable_unprepare() before return > from platform_clock_control() in error handling path. > > Fixes: 9a87fc1e0619 ("ASoC: Intel: bytcr_wm5102: Add machine driver for BYT/WM5102") > Signed-off-by: Zhang Zekun <zhangzekun11(a)huawei.com> > --- > sound/soc/intel/boards/bytcr_wm5102.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/intel/boards/bytcr_wm5102.c b/sound/soc/intel/boards/bytcr_wm5102.c > index 45a6805787f5..3e3cdee4b1ce 100644 > --- a/sound/soc/intel/boards/bytcr_wm5102.c > +++ b/sound/soc/intel/boards/bytcr_wm5102.c > @@ -111,6 +111,7 @@ static int platform_clock_control(struct snd_soc_dapm_widget *w, > ret = byt_wm5102_prepare_and_enable_pll1(codec_dai, 48000); > if (ret) { > dev_err(card->dev, "Error setting codec sysclk: %d\n", ret); > + clk_disable_unprepare(priv->mclk); This change looks legit to me, but you want to CC: maintainers (Mark Brown, Takashi Iwai), use the alsa-devel mailing list and CC: the initial contributor Hans de Goede. > return ret; > } > } else {

1 0

speaker-test channel descriptions don't match expectations
by GitHub issues - opened 19 Jul '22

19 Jul '22

alsa-project/alsa-utils issue #159 was opened from pfps: The text output of speaker-test for -c6 appears to indicate that it is using 5+1 channels, with FL, FR, RL, RR, FC, LFE channels (output in a different order). But the wav files that it uses say FL, FR, RL, ??, FC, Rear Center. And this channel order doesn't seem correct, as the channels are not down-mixed to stereo correctly on my system with pipewire and pipewire-media-session. What can be done to get speaker-test and pipewire to agree on the channels? Issue URL : https://github.com/alsa-project/alsa-utils/issues/159 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[PATCH v1 1/1] ALSA: isa: Use INVALID_HWIRQ definition
by Andy Shevchenko 18 Jul '22

18 Jul '22

Use specific definition for invalid IRQ. It makes the code uniform in respect to the constant used for that. No functional change intended. Signed-off-by: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> --- sound/isa/sscape.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/isa/sscape.c b/sound/isa/sscape.c index 0bc0025f7c19..9adaf91045e9 100644 --- a/sound/isa/sscape.c +++ b/sound/isa/sscape.c @@ -140,8 +140,7 @@ struct soundscape { unsigned char midi_vol; }; -#define INVALID_IRQ ((unsigned)-1) - +#define INVALID_IRQ ((unsigned)INVALID_HWIRQ) static inline struct soundscape *get_card_soundscape(struct snd_card *c) { -- 2.35.1

2 2