July 2022 - Alsa-devel - mailman.alsa-project.org

[PATCH] ALSA: hda/realtek: Fix headset mic for Acer SF313-51
by Meng Tang 11 Jul '22

11 Jul '22

The issue on Acer SWIFT SF313-51 is that headset microphone doesn't work. The following quirk fixed headset microphone issue. Note that the fixup of SF314-54/55 (ALC256_FIXUP_ACER_HEADSET_MIC) was not successful on my SF313-51. Signed-off-by: Meng Tang <tangmeng(a)uniontech.com> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 007dd8b5e1f2..fe7c1194d052 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8886,6 +8886,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1025, 0x1290, "Acer Veriton Z4860G", ALC286_FIXUP_ACER_AIO_HEADSET_MIC), SND_PCI_QUIRK(0x1025, 0x1291, "Acer Veriton Z4660G", ALC286_FIXUP_ACER_AIO_HEADSET_MIC), SND_PCI_QUIRK(0x1025, 0x129c, "Acer SWIFT SF314-55", ALC256_FIXUP_ACER_HEADSET_MIC), + SND_PCI_QUIRK(0x1025, 0x129d, "Acer SWIFT SF313-51", ALC256_FIXUP_ACER_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1025, 0x1300, "Acer SWIFT SF314-56", ALC256_FIXUP_ACER_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1025, 0x1308, "Acer Aspire Z24-890", ALC286_FIXUP_ACER_AIO_HEADSET_MIC), SND_PCI_QUIRK(0x1025, 0x132a, "Acer TravelMate B114-21", ALC233_FIXUP_ACER_HEADSET_MIC), -- 2.20.1

2 1

[PATCH] ASoC: fsl_utils: Drop usage of __clk_get_name()
by Shengjiu Wang 11 Jul '22

11 Jul '22

Avoid build errors when CONFIG_COMMON_CLK is not set/enabled. ERROR: modpost: "__clk_get_name" [sound/soc/fsl/snd-soc-fsl-utils.ko] undefined! Fixes: 7bad8125549c ("ASoC: fsl_utils: Add function to handle PLL clock source") Reported-by: kernel test robot <lkp(a)intel.com> Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> --- sound/soc/fsl/fsl_utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_utils.c b/sound/soc/fsl/fsl_utils.c index 3e969c7bc1c5..d0fc430f7033 100644 --- a/sound/soc/fsl/fsl_utils.c +++ b/sound/soc/fsl/fsl_utils.c @@ -147,7 +147,7 @@ void fsl_asoc_reparent_pll_clocks(struct device *dev, struct clk *clk, if (reparent) { ret = clk_set_parent(p, npll); if (ret < 0) - dev_warn(dev, "failed to set parent %s: %d\n", __clk_get_name(npll), ret); + dev_warn(dev, "failed to set parent:%d\n", ret); } } EXPORT_SYMBOL(fsl_asoc_reparent_pll_clocks); -- 2.34.1

2 1

[PATCH] ASoC: mediatek: mt8186: Remove condition with no effect
by Zhongjun Tan 11 Jul '22

11 Jul '22

From: Zhongjun Tan <tanzhongjun(a)coolpad.com> Remove condition with no effect Signed-off-by: Zhongjun Tan <tanzhongjun(a)coolpad.com> --- sound/soc/mediatek/mt8186/mt8186-dai-adda.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/mediatek/mt8186/mt8186-dai-adda.c b/sound/soc/mediatek/mt8186/mt8186-dai-adda.c index db71b032770d..6be6d4f3b585 100644 --- a/sound/soc/mediatek/mt8186/mt8186-dai-adda.c +++ b/sound/soc/mediatek/mt8186/mt8186-dai-adda.c @@ -295,8 +295,6 @@ static int mtk_adda_pad_top_event(struct snd_soc_dapm_widget *w, case SND_SOC_DAPM_PRE_PMU: if (afe_priv->mtkaif_protocol == MTKAIF_PROTOCOL_2_CLK_P2) regmap_write(afe->regmap, AFE_AUD_PAD_TOP, 0x39); - else if (afe_priv->mtkaif_protocol == MTKAIF_PROTOCOL_2) - regmap_write(afe->regmap, AFE_AUD_PAD_TOP, 0x31); else regmap_write(afe->regmap, AFE_AUD_PAD_TOP, 0x31); break; -- 2.29.0

5 5

Re: Pandora audio using machine_is_omap3_pandora() check
by H. Nikolaus Schaller 11 Jul '22

11 Jul '22

Hi, > Am 05.07.2022 um 23:39 schrieb Stefan Leichter <sle85276(a)gmx.de>: > > Hi, > > Am 27.06.22 um 15:53 schrieb Tony Lindgren: >> * H. Nikolaus Schaller <hns(a)goldelico.com> [220627 11:36]: >>> Hi Tony, >>> >>>> Am 27.06.2022 um 11:52 schrieb Tony Lindgren <tony(a)atomide.com>: >>>> >>>> Hi Grazvydas, >>>> >>>> Arnd noticed that pandora audio is using machine_is_omap3_pandora() check >>>> that never succeeds for devicetree booting machines. Looks like this has >>>> been broken at some point many years ago with the devicetree conversion. >>>> >>>> Does anybody have an interest in fixing this driver? >>> >>> we already have fixes by Stefan Leichter and Grond here (incl. removing any call to machine_is_omap3_pandora): >>> >>> https://git.goldelico.com/?p=letux-kernel.git;a=shortlog;h=refs/heads/letux… >> >> OK :) >> >>> But I don't know who can volunteer to run this series through the upstreaming discussions >>> and do regression tests (AFAIR the Pandora of Grond is broken and he has no replacement). > > I hope that Grond's Pandora didn't break because of experiments to get the sound working. We tried to analyse but it is unilekely. It may just be wear somewhere else. I also see XUDF error reports from I2C from time to time and it seems to depend a little on battery charge. Difficult to pinpoint. > >> >> Probably best that Stefan and Grond do it :) Not sure what the minimal fix >> for the mainline kernel might be to get things at least try to probe. >> > > Well, I think I'm not the right person to try to mainline the patches, but if nobody else like to volunteer I will give it a try. Be warned, I have no experience with mainlining patches, even not with kernel programming at all. Therefore I need someone holding my hand. Does anybody volunteer? Yes, we all :) Basically the task is to a) shape (i.e. rebase, edit) the patches according the rules: https://www.kernel.org/doc/html/latest/process/submitting-patches.html b) add Signed-Offs etc. c) compile test d) git format-patch e) ./scripts/checkpatch.pl and fix any reported weaknesses f) send by mail to this audience (perhaps check with ./MAINTAINERS) > > I had a look to the branch Nikolaus pointed out. Here are some questions about the patches in the branch: > > - It seams to me the branch doesn't support any longer to compile the driver directly into the kernel. Am I correct? Hm. It still should? What makes you think so? > - There are three patches from Andreas and Nikolaus in the beginning of the branch. Are this patched needed to be mainlined too? No, they are not related to the Pandora but its cousin the GTA04. > - Two of my patches are super seeded by the patches from Grond. My guess it that the patches needs to be squashed together? Yes. > - Where should I send the patches? The current audience might be a little bit large? The audience is usually defined by ./MAINTAINERS And whoever could contribute in review. BR and thanks, Nikolaus

1 0

[PATCH] ALSA: hda/conexant: Apply quirk for another HP ProDesk 600 G3 model
by Meng Tang 11 Jul '22

11 Jul '22

There is another HP ProDesk 600 G3 model with the PCI SSID 103c:82b4 that requires the same quirk for controlling the mute LED. Add the corresponding entry to the quirk table. Signed-off-by: Meng Tang <tangmeng(a)uniontech.com> --- sound/pci/hda/patch_conexant.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c index 3e541a4c0423..e90da8020881 100644 --- a/sound/pci/hda/patch_conexant.c +++ b/sound/pci/hda/patch_conexant.c @@ -944,6 +944,7 @@ static const struct snd_pci_quirk cxt5066_fixups[] = { SND_PCI_QUIRK(0x103c, 0x828c, "HP EliteBook 840 G4", CXT_FIXUP_HP_DOCK), SND_PCI_QUIRK(0x103c, 0x8299, "HP 800 G3 SFF", CXT_FIXUP_HP_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x103c, 0x829a, "HP 800 G3 DM", CXT_FIXUP_HP_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x103c, 0x82b4, "HP ProDesk 600 G3", CXT_FIXUP_MUTE_LED_GPIO), SND_PCI_QUIRK(0x103c, 0x836e, "HP ProBook 455 G5", CXT_FIXUP_MUTE_LED_GPIO), SND_PCI_QUIRK(0x103c, 0x837f, "HP ProBook 470 G5", CXT_FIXUP_MUTE_LED_GPIO), SND_PCI_QUIRK(0x103c, 0x83b2, "HP EliteBook 840 G5", CXT_FIXUP_HP_DOCK), -- 2.20.1

1 0

[PATCH 1/3] ASoC: amd: remove unused header file inclusion
by Vijendar Mukunda 11 Jul '22

11 Jul '22

Removed unused header file inclusion from Jadeite platform machine driver. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda(a)amd.com> --- sound/soc/amd/acp-es8336.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/amd/acp-es8336.c b/sound/soc/amd/acp-es8336.c index eec3d57092fa..8ce26c9b3ead 100644 --- a/sound/soc/amd/acp-es8336.c +++ b/sound/soc/amd/acp-es8336.c @@ -23,7 +23,6 @@ #include <linux/module.h> #include <linux/acpi.h> -#include "../codecs/es8316.h" #include "acp.h" #define DUAL_CHANNEL 2 -- 2.25.1

5 6

Add correct support for Rane SL-1
by GitHub pull_request - edited 10 Jul '22

10 Jul '22

alsa-project/alsa-ucm-conf pull request #187 was edited from christophehenry: Following [this ticket](https://bugzilla.kernel.org/show_bug.cgi?id=216082) on kernel bugzilla, I'm trying to add corect support for [Rane SL-1](https://cdn.korn.eu/pictures/product/400/040506_3.jpg), an old USB soundcard featuring 2 stereo inputs (RCA) and 3 stereo outputs (2 RCA, 1 6.3mm jack). Currently, `alsa-info.sh` does show the correct number of inputs and outputs But neither `pavucontrol` nor Mixxx do. I was told complex hardware should be described via UCM but the syntax is unfortunately very poorly documented so I can get my head around it and get `pavucontrol` to show all the inputs and outputs. Here's what I have so far which, to my disappointment, does not work. If I put only 1 `SectionDevice` section in the file, I can display 1 ouput under `pavucontrol`. With 2 `SectionDevice`, nothing shows. Without any UCM file, `pavucontrol` shows 2 outputs, 1 intputs (instead of 3) and Mixxx shows 2 outputs and not input. [The result of `alsa-info.sh` is available here](https://bugzilla.kernel.org/attachment.cgi?id=301351). Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/187 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/187.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Add correct support for Rane SL-1
by GitHub pull_request - opened 10 Jul '22

10 Jul '22

alsa-project/alsa-ucm-conf pull request #187 was opened from christophehenry: Following [this ticket](https://bugzilla.kernel.org/show_bug.cgi?id=216082) on kernel bugzilla, I'm trying to add corect support for [Rane SL-1](https://cdn.korn.eu/pictures/product/400/040506_3.jpg), an old USB soundcard featuring 2 stereo inputs (RCA) and 3 stereo outputs (2 RCA, 1 6.3mm jack). Currently, `alsa-info.sh` does show the correct number of inputs and outputs But neither `pavucontrol` nor Mixxx do. I was told complex hardware should be described via UCM but the syntax is unfortunately very poorly documented so I can get my head around it and get `pavucontrol` to show all the inputs and outputs. Here's what I have so far which, to my disappointment, does not work. If I put only 1 `SectionDevice` section in the file, I can display 1 ouput under `pavucontrol`. With 2 `SectionDevice`, nothing shows. Without any UCM file, `pavucontrol` shows 2 outputs, 1 intputs (instead of 3) and Mixxx shows 2 outputs and not input. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/187 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/187.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

MSI MAG X570S TOMAHAWK MAX WIFI - microphone + front audio panel not working
by GitHub issues - opened 10 Jul '22

10 Jul '22

alsa-project/alsa-ucm-conf issue #186 was opened from motomyslen: The same issue was reported on many forums but I didn't see it reported here so I'm creating this topic for all people with this motherboard. **Issues** - rear mic-in/line-in not working, sound is working fine - front panel detects devices but not sound, not mic I tried with kernel 5.18 and pulseaudio 16.1 - nothing changed. [alsa-info.txt](https://github.com/alsa-project/alsa-ucm-conf/files/9078972/… Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/186 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH] ALSA: usb-audio: Fix unsigned expression compared with zero
by Zhongjun Tan 10 Jul '22

10 Jul '22

From: Zhongjun Tan <tanzhongjun(a)coolpad.com> Fix unsigned expression compared with zero Signed-off-by: Zhongjun Tan <tanzhongjun(a)coolpad.com> --- sound/usb/pcm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c index e692ae04436a..e461715a43bd 100644 --- a/sound/usb/pcm.c +++ b/sound/usb/pcm.c @@ -766,8 +766,8 @@ static int hw_rule_rate(struct snd_pcm_hw_params *params, struct snd_usb_audio *chip = subs->stream->chip; const struct audioformat *fp; struct snd_interval *it = hw_param_interval(params, SNDRV_PCM_HW_PARAM_RATE); - unsigned int rmin, rmax, r; - int i; + unsigned int rmin, rmax; + int i, r; hwc_debug("hw_rule_rate: (%d,%d)\n", it->min, it->max); rmin = UINT_MAX; -- 2.29.0

3 3